Re: [FFmpeg-devel] [PATCH 1/5] avfilter/formats: remove unused COPY_INT_LIST() macro

2015-03-16 Thread Clément Bœsch
On Sun, Mar 15, 2015 at 03:00:26PM +0100, Stefano Sabatini wrote: On date Sunday 2015-03-15 14:24:26 +0100, Clément Bœsch encoded: This macro is unused since 247fa6c27c4589d0f7a427c520d782edbb6de060. --- libavfilter/formats.c | 12 1 file changed, 12 deletions(-) diff

[FFmpeg-devel] [PATCH 1/5] avfilter/formats: remove unused COPY_INT_LIST() macro

2015-03-15 Thread Clément Bœsch
This macro is unused since 247fa6c27c4589d0f7a427c520d782edbb6de060. --- libavfilter/formats.c | 12 1 file changed, 12 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index f25328c..1fc7fa6 100644 --- a/libavfilter/formats.c +++ b/libavfilter/formats.c @@

[FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-15 Thread Clément Bœsch
--- libavfilter/formats.c | 45 - libavfilter/formats.h | 10 +- 2 files changed, 37 insertions(+), 18 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 6393416..4f9773b 100644 --- a/libavfilter/formats.c +++

[FFmpeg-devel] [PATCH 5/5] avfilter: handle error in query_formats() of a bunch of random video filters

2015-03-15 Thread Clément Bœsch
--- libavfilter/f_select.c | 9 - libavfilter/vf_codecview.c | 6 -- libavfilter/vf_colorbalance.c | 7 --- libavfilter/vf_colormatrix.c| 8 libavfilter/vf_curves.c | 6 -- libavfilter/vf_dctdnoiz.c | 6 --

[FFmpeg-devel] [PATCH 3/5] avfilter/formats: proper error handling in ff_channel_layouts_ref() and ff_formats_ref()

2015-03-15 Thread Clément Bœsch
Also make sure the allocation and its check are properly done. --- libavfilter/formats.c | 22 +++--- libavfilter/formats.h | 6 +++--- 2 files changed, 14 insertions(+), 14 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 896ceeb..6393416 100644 ---

[FFmpeg-devel] [PATCH 2/5] avfilter/formats: use av_realloc_array in ADD_FORMAT()

2015-03-15 Thread Clément Bœsch
--- libavfilter/formats.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index 1fc7fa6..896ceeb 100644 --- a/libavfilter/formats.c +++ b/libavfilter/formats.c @@ -308,8 +308,8 @@ do {

Re: [FFmpeg-devel] [PATCH] avcodec/samidec: process more of the SAMI tags

2015-03-15 Thread Clément Bœsch
On Sun, Mar 15, 2015 at 05:28:15PM +0900, Won-woo Choi wrote: Made some changes to samidec so that it can process SAMI tags. Processes B and FONT(font face, color). --- libavcodec/samidec.c | 37 +++-- 1 file changed, 35 insertions(+), 2 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-15 Thread Clément Bœsch
On Sun, Mar 15, 2015 at 03:11:14PM +0100, Clément Bœsch wrote: On Sun, Mar 15, 2015 at 03:07:16PM +0100, Stefano Sabatini wrote: On date Sunday 2015-03-15 14:24:29 +0100, Clément Bœsch encoded: --- libavfilter/formats.c | 45 - libavfilter

Re: [FFmpeg-devel] [PATCH 4/5] avfilter/formats: proper error handling in ff_set_common_*() functions

2015-03-15 Thread Clément Bœsch
On Sun, Mar 15, 2015 at 03:07:16PM +0100, Stefano Sabatini wrote: On date Sunday 2015-03-15 14:24:29 +0100, Clément Bœsch encoded: --- libavfilter/formats.c | 45 - libavfilter/formats.h | 10 +- 2 files changed, 37 insertions(+), 18

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
On Sat, Mar 14, 2015 at 03:25:19PM +0100, Michael Niedermayer wrote: On Sat, Mar 14, 2015 at 03:11:28PM +0100, Clément Bœsch wrote: On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit

[FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
Hi, I'm adding error handling in the following functions: ff_formats_ref() ff_channel_layouts_ref() ff_set_common_formats() ff_set_common_samplerates() ff_set_common_channel_layouts() (I may have forgotten some) So basically these functions would return AVERROR(ENOMEM) (or whatever

Re: [FFmpeg-devel] [RFC] libavfilter query_format() related functions error handling

2015-03-14 Thread Clément Bœsch
On Sat, Mar 14, 2015 at 01:33:12PM +0100, Nicolas George wrote: Le quartidi 24 ventôse, an CCXXIII, Michael Niedermayer a écrit : ff_set_common_channel_layouts(ctx, ff_all_channel_layouts()); ff_set_common_formats(ctx, ff_make_format_list(sample_fmts));

Re: [FFmpeg-devel] [PATCH] avfilter/formats: replace non functional av_realloc() check by assert

2015-03-12 Thread Clément Bœsch
On Thu, Mar 12, 2015 at 11:04:57PM +0100, Michael Niedermayer wrote: Simply returning on failure without indicating failure does not work it instead crashes later, its better to fail immedeately until the failure is handled. Signed-off-by: Michael Niedermayer michae...@gmx.at ---

[FFmpeg-devel] [PATCH] avfilter/formats: proper error handling in ff_channel_layouts_ref() and ff_formats_ref()

2015-03-12 Thread Clément Bœsch
Also make sure the allocation and its check are properly done. --- libavfilter/formats.c | 20 +++- libavfilter/formats.h | 6 +++--- 2 files changed, 14 insertions(+), 12 deletions(-) diff --git a/libavfilter/formats.c b/libavfilter/formats.c index eb3b87a..47b20a4 100644 ---

Re: [FFmpeg-devel] [PATCH] [PATCH] lavfi: add inverse telecine filter

2015-03-11 Thread Clément Bœsch
On Wed, Mar 11, 2015 at 07:12:16AM +, Carl Eugen Hoyos wrote: Timothy Gu timothygu99 at gmail.com writes: This is an exact inverse of the telecine filter unlike previously existing pullup and fieldmatch ones. What's the difference between the three seemingly similar

Re: [FFmpeg-devel] [PATCH] avcodec/wmalossless: use av_clip_intp2

2015-03-09 Thread Clément Bœsch
On Mon, Mar 09, 2015 at 10:01:20PM +0100, Reimar Döffinger wrote: On Sun, Mar 08, 2015 at 10:32:03PM +0100, Michael Niedermayer wrote: On Sat, Mar 07, 2015 at 11:44:10PM +0800, zhaoxiu.zeng wrote: From 47c997fa0623ab94a7a93b2d2e4cc4fa64c85d5f Mon Sep 17 00:00:00 2001 From: Zeng Zhaoxiu

Re: [FFmpeg-devel] Patch proposal : filter ebur128 : add filter name before each line of summary print

2015-03-09 Thread Clément Bœsch
On Mon, Mar 09, 2015 at 10:28:43PM +0100, Martin Vignali wrote: In attach a patch proposal, in order to make easier parse result of ebur128 filter by external scripts command line for testing : ffmpeg -i aFile.wav -filter ebur128=peak=true+sample -f null - Before patch, summary look like

Re: [FFmpeg-devel] [PATCH] dump: show audio service type

2015-03-08 Thread Clément Bœsch
On Sun, Mar 08, 2015 at 11:56:34AM +0100, Thomas Volkert wrote: --- libavformat/dump.c | 29 + 1 file changed, 29 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 56b37ff..9801042 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c

Re: [FFmpeg-devel] [PATCH] avformat/srtenc: avoid segmentation fault when transcoding from SSA to SRT

2015-03-07 Thread Clément Bœsch
On Sun, Mar 08, 2015 at 12:27:49AM +0100, Gilles Chanteperdrix wrote: On Sat, Mar 07, 2015 at 11:46:44PM +0100, Nicolas George wrote: Le septidi 17 ventôse, an CCXXIII, Gilles Chanteperdrix a écrit : You need an ASS file that produces a sub-title frame without text. I have been carrying

Re: [FFmpeg-devel] [PATCH] [release/2.6] Add release notes

2015-03-06 Thread Clément Bœsch
On Thu, Mar 05, 2015 at 08:19:44PM -0300, James Almer wrote: On 05/03/15 6:26 PM, Clément Bœsch wrote: + Now let's talk about optimizations. Ronald S. Bultje made the VP9 codec + usable on x86 32-bit systems and pre-ssse3 CPUs like Phenom (even dual core + Athlons can run 1080p

Re: [FFmpeg-devel] [PATCH] Make compilable with VS2015

2015-03-06 Thread Clément Bœsch
On Fri, Mar 06, 2015 at 06:06:23PM -0300, James Almer wrote: On 06/03/15 6:03 PM, Michael Niedermayer wrote: On Fri, Mar 06, 2015 at 09:58:37PM +0100, Michael Niedermayer wrote: On Fri, Mar 06, 2015 at 02:59:43PM -0500, Ronald S. Bultje wrote: Hi, On Fri, Mar 6, 2015 at 2:42 PM, Peter

[FFmpeg-devel] [PATCH] [release/2.6] Add release notes

2015-03-05 Thread Clément Bœsch
--- RELEASE_NOTES | 59 +++ 1 file changed, 59 insertions(+) create mode 100644 RELEASE_NOTES diff --git a/RELEASE_NOTES b/RELEASE_NOTES new file mode 100644 index 000..c1e9248 --- /dev/null +++ b/RELEASE_NOTES @@ -0,0 +1,59 @@ + +

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_showinfo: minimum widths for some early fields

2015-03-04 Thread Clément Bœsch
On Wed, Mar 04, 2015 at 10:18:07PM +0100, Michael Niedermayer wrote: On Wed, Mar 04, 2015 at 09:59:35PM +0100, Nicolas George wrote: Le quartidi 14 ventôse, an CCXXIII, Peter Cordes a écrit : - n:%PRId64 pts:%s pts_time:%s pos:%PRId64 + n:%4PRId64 pts:%7s

Re: [FFmpeg-devel] [PATCH 2/3] libx265: Return proper invalid data code

2015-03-03 Thread Clément Bœsch
On Tue, Mar 03, 2015 at 04:26:46PM +0100, Alexander Strasser wrote: On 2015-02-17 22:15 +, Derek Buitenhuis wrote: On 2/17/2015 10:10 PM, James Almer wrote: Afaik, if the error is based on user input then EINVAL (Invalid argument) is correct. AVERROR_INVALIDDATA is when the error

Re: [FFmpeg-devel] [PATCH] avcodec/proresenc_kostya: fix coded_frame handling

2015-03-02 Thread Clément Bœsch
On Mon, Mar 02, 2015 at 10:23:54PM +0100, Michael Niedermayer wrote: On Mon, Mar 02, 2015 at 09:20:23PM +0100, Clément Bœsch wrote: --- libavcodec/proresenc_kostya.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) LGTM Applied, thanks. -- Clément B

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/lavfutils: use av_frame_free for freeing an AVFrame

2015-03-02 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 11:07:23AM +, Paul B Mahol wrote: On 2/28/15, Clement Boesch u...@pkh.me wrote: --- libavfilter/lavfutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c index 80310d2..75e68a7 100644

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: use av_frame_free() for coded_frame

2015-03-02 Thread Clément Bœsch
On Mon, Mar 02, 2015 at 10:01:57AM +0100, Clément Bœsch wrote: On Mon, Mar 02, 2015 at 08:31:16AM +, Paul B Mahol wrote: On 2/28/15, Clement Boesch u...@pkh.me wrote: On Sat, Feb 28, 2015 at 10:38:32AM +0100, Clement Boesch wrote: --- libavcodec/avuienc.c| 2

Re: [FFmpeg-devel] [PATCH 3/3] avfilter/vf_tblend: use av_frame_free for freeing an AVFrame

2015-03-02 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 11:06:12AM +, Paul B Mahol wrote: On 2/28/15, Clement Boesch u...@pkh.me wrote: --- libavfilter/vf_blend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index a29cabc..d232457 100644

Re: [FFmpeg-devel] [RFC][PATCH] ffplay: factorize subtitle rendering code to a private filter

2015-03-02 Thread Clément Bœsch
On Tue, Feb 17, 2015 at 03:27:01AM +0100, Marton Balint wrote: On Sat, 14 Feb 2015, Clément Bœsch wrote: On Sat, Feb 14, 2015 at 02:08:15AM +0100, Marton Balint wrote: Signed-off-by: Marton Balint c...@passwd.hu --- Makefile | 1 + doc/ffplay.texi

Re: [FFmpeg-devel] [PATCH] configure: autodetect opencl

2015-03-02 Thread Clément Bœsch
On Mon, Mar 02, 2015 at 08:49:08AM +, Carl Eugen Hoyos wrote: Gupta, Maneesh Maneesh.Gupta at amd.com writes: Similar to the way SDL is being autodetected, the attached patch proposes to autodetect OpenCL. This cannot be done since the API is defined as being not stable. Making

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: use av_frame_free() for coded_frame

2015-03-02 Thread Clément Bœsch
On Mon, Mar 02, 2015 at 08:31:16AM +, Paul B Mahol wrote: On 2/28/15, Clement Boesch u...@pkh.me wrote: On Sat, Feb 28, 2015 at 10:38:32AM +0100, Clement Boesch wrote: --- libavcodec/avuienc.c| 2 +- libavcodec/libopenjpegenc.c | 4 ++-- libavcodec/libtheoraenc.c

Re: [FFmpeg-devel] [PATCH 1/2] libavformat/avio: added avio_put_str16be

2015-03-02 Thread Clément Bœsch
On Sun, Mar 01, 2015 at 01:30:54PM -0800, Mark Reid wrote: --- libavformat/avio.h| 6 ++ libavformat/aviobuf.c | 50 +++--- libavformat/version.h | 2 +- 3 files changed, 34 insertions(+), 24 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] avcodec/pngenc: cast double to integer type to avoid problems with some AV_WB32() implementations

2015-03-02 Thread Clément Bœsch
On Sun, Mar 01, 2015 at 08:07:46PM -0500, Ronald S. Bultje wrote: Hi, On Sun, Mar 1, 2015 at 7:38 PM, Michael Niedermayer michae...@gmx.at wrote: alternatively lrint(f)() could be used or various other options Signed-off-by: Michael Niedermayer michae...@gmx.at ---

[FFmpeg-devel] [PATCH] avcodec/proresenc_kostya: fix coded_frame handling

2015-03-02 Thread Clément Bœsch
--- libavcodec/proresenc_kostya.c | 12 +--- 1 file changed, 5 insertions(+), 7 deletions(-) diff --git a/libavcodec/proresenc_kostya.c b/libavcodec/proresenc_kostya.c index 59f73fb..440cc8b 100644 --- a/libavcodec/proresenc_kostya.c +++ b/libavcodec/proresenc_kostya.c @@ -914,7 +914,7

[FFmpeg-devel] [PATCH 1/3] avcodec: use av_frame_free() for coded_frame

2015-02-28 Thread Clément Bœsch
--- libavcodec/avuienc.c| 2 +- libavcodec/libopenjpegenc.c | 4 ++-- libavcodec/libtheoraenc.c | 2 +- libavcodec/libutvideoenc.cpp| 2 +- libavcodec/libvpxenc.c | 2 +- libavcodec/proresenc_anatoliy.c | 2 +- libavcodec/proresenc_kostya.c | 2 +-

[FFmpeg-devel] [PATCH 2/3] avfilter/lavfutils: use av_frame_free for freeing an AVFrame

2015-02-28 Thread Clément Bœsch
--- libavfilter/lavfutils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/lavfutils.c b/libavfilter/lavfutils.c index 80310d2..75e68a7 100644 --- a/libavfilter/lavfutils.c +++ b/libavfilter/lavfutils.c @@ -96,7 +96,7 @@ end: av_free_packet(pkt);

[FFmpeg-devel] [PATCH 3/3] avfilter/vf_tblend: use av_frame_free for freeing an AVFrame

2015-02-28 Thread Clément Bœsch
--- libavfilter/vf_blend.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_blend.c b/libavfilter/vf_blend.c index a29cabc..d232457 100644 --- a/libavfilter/vf_blend.c +++ b/libavfilter/vf_blend.c @@ -379,7 +379,7 @@ static av_cold void uninit(AVFilterContext

Re: [FFmpeg-devel] [PATCH 1/3] avcodec: use av_frame_free() for coded_frame

2015-02-28 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 10:38:32AM +0100, Clément Bœsch wrote: --- libavcodec/avuienc.c| 2 +- libavcodec/libopenjpegenc.c | 4 ++-- libavcodec/libtheoraenc.c | 2 +- libavcodec/libutvideoenc.cpp| 2 +- libavcodec/libvpxenc.c | 2 +- libavcodec

Re: [FFmpeg-devel] [PATCH] avformat/rmenc: limit packet size

2015-02-28 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 11:32:59PM +0100, Andreas Cadhalpun wrote: Hi, the chunk size in rm files is stored in 16 bits, but the packet size can be larger, triggering an av_assert2 in avio_w8 (via avio_wb16). Best regards, Andreas From 044b4bd4df935b918055c24ae661e9bcc31e425a Mon Sep 17

Re: [FFmpeg-devel] [PATCH 2/3] avformat: map T.140 RTP codec to text

2015-02-28 Thread Clément Bœsch
On Sat, Feb 28, 2015 at 11:15:40PM +0100, Gilles Chanteperdrix wrote: This makes more sense than mapping to AV_CODEC_ID_SUBRIP. Nothing indicates that a T.140 track contains subrip sub-titles. Signed-off-by: Gilles Chanteperdrix gilles.chanteperd...@xenomai.org --- libavformat/rtpdec.c | 2

Re: [FFmpeg-devel] [PATCH] avfilter/palettegen/RFC: fix mem leak

2015-02-27 Thread Clément Bœsch
On Fri, Feb 27, 2015 at 12:50:23PM +0100, Nicolas George wrote: Le nonidi 9 ventôse, an CCXXIII, Clement Boesch a écrit : I don't understand why I need to do that. The free is already present in the uninit, and before every update of the prev_frame update. In uninit, I see:

[FFmpeg-devel] [PATCH] avfilter/palettegen/RFC: fix mem leak

2015-02-26 Thread Clément Bœsch
I don't understand why I need to do that. The free is already present in the uninit, and before every update of the prev_frame update. --- libavfilter/vf_palettegen.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/vf_palettegen.c b/libavfilter/vf_palettegen.c index

Re: [FFmpeg-devel] [PATCH] avfilter/palettegen: export color quantization ratio

2015-02-26 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 04:14:11PM +0100, Clément Bœsch wrote: On Wed, Feb 25, 2015 at 03:43:23PM +0100, Nicolas George wrote: Le septidi 7 ventôse, an CCXXIII, Clement Boesch a écrit : +float ratio = (float)nb_out / nb_in; +snprintf(buf, sizeof(buf), %f, ratio); I wonder

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 05:15:56PM +0100, Clément Bœsch wrote: On Thu, Feb 26, 2015 at 04:13:10PM +, Derek Buitenhuis wrote: On 2/26/2015 4:10 PM, Clément Bœsch wrote: Yes, it will return an error and abort the operation. Be it done on the command line or via the API. So said

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 04:13:10PM +, Derek Buitenhuis wrote: On 2/26/2015 4:10 PM, Clément Bœsch wrote: Yes, it will return an error and abort the operation. Be it done on the command line or via the API. So said differently it won't work anymore. I do wonder what the point

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: On 2/26/2015 1:50 PM, Clément Bœsch wrote: If the option is set by default, you don't want to warn for no reason. It's not set by default. That patch never went in. Ah, my bad. I don't believe silently not writing

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 05:04:53PM +0100, Hendrik Leppkes wrote: On Thu, Feb 26, 2015 at 4:54 PM, Clément Bœsch u...@pkh.me wrote: On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: On 2/26/2015 1:50 PM, Clément Bœsch wrote: If the option is set by default, you don't want

Re: [FFmpeg-devel] [PATCH] avfilter/palettegen: use AV_QSORT()

2015-02-26 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 06:55:48PM +0100, Michael Niedermayer wrote: On Wed, Feb 25, 2015 at 04:10:44PM +0100, Clément Bœsch wrote: From: Clément Bœsch clem...@stupeflix.com This makes the sorting of the colors along an axis (r, g or b) predictible, and thus testable under FATE

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 01:47:01PM +, Derek Buitenhuis wrote: This also restricts it to MOV and MP4, since it is only defined for those formats. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- libavformat/movenc.c | 29 +++-- 1 file changed, 23

Re: [FFmpeg-devel] palette{gen,use} FATE tests

2015-02-26 Thread Clément Bœsch
On Mon, Feb 23, 2015 at 01:56:59PM +0100, Clément Bœsch wrote: Here are two tests for the recently added filters. I'm hopping that qsort will not cause any issue, otherwise we might need to switch to AV_QSORT (I'm thinking of the sort where multiple different values have the same score

Re: [FFmpeg-devel] [PATCH] movenc: Write 'colr' box correctly for MP4

2015-02-26 Thread Clément Bœsch
On Thu, Feb 26, 2015 at 06:15:30PM +0100, Michael Niedermayer wrote: On Thu, Feb 26, 2015 at 04:54:02PM +0100, Clément Bœsch wrote: On Thu, Feb 26, 2015 at 01:53:13PM +, Derek Buitenhuis wrote: On 2/26/2015 1:50 PM, Clément Bœsch wrote: If the option is set by default, you don't want

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-26 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 34 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/vf_neighbor.c | 289

[FFmpeg-devel] [PATCH] avfilter/palettegen: export color quantization ratio

2015-02-25 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com --- doc/filters.texi| 5 + libavfilter/version.h | 2 +- libavfilter/vf_palettegen.c | 14 -- 3 files changed, 18 insertions(+), 3 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index baef346..0c72145

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Clément Bœsch
On Tue, Feb 24, 2015 at 10:05:24PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- I decided to go the configure route since other features (cmov, clz) also do it , but if prefered this could instead be done with a new intmath.h header in the x86/ folder containing

[FFmpeg-devel] [PATCH] avfilter/palettegen: use AV_QSORT()

2015-02-25 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com This makes the sorting of the colors along an axis (r, g or b) predictible, and thus testable under FATE. The performance is not really an issue here since the function is called only once at the end and will need to sort very small number of entries, so

Re: [FFmpeg-devel] [PATCH] lavfi: add erosion dilation filter

2015-02-25 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 02:55:58PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- doc/filters.texi | 34 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/vf_neighbor.c | 289

Re: [FFmpeg-devel] [PATCH] avfilter/palettegen: export color quantization ratio

2015-02-25 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 03:43:23PM +0100, Nicolas George wrote: Le septidi 7 ventôse, an CCXXIII, Clement Boesch a écrit : +float ratio = (float)nb_out / nb_in; +snprintf(buf, sizeof(buf), %f, ratio); I wonder if both values could be useful instead individually. If so, either set

Re: [FFmpeg-devel] [PATCH] libavutil: add x86 optimized av_popcount

2015-02-25 Thread Clément Bœsch
On Wed, Feb 25, 2015 at 02:29:11PM -0300, James Almer wrote: On 25/02/15 12:43 PM, Clément Bœsch wrote: On Tue, Feb 24, 2015 at 10:05:24PM -0300, James Almer wrote: Signed-off-by: James Almer jamr...@gmail.com --- I decided to go the configure route since other features (cmov, clz) also

[FFmpeg-devel] [PATCH 1/2] tests: add palettegen test

2015-02-23 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com --- tests/fate/filter-video.mak| 9 + tests/ref/fate/filter-palettegen-1 | 2 ++ tests/ref/fate/filter-palettegen-2 | 2 ++ 3 files changed, 13 insertions(+) create mode 100644 tests/ref/fate/filter-palettegen-1 create mode 100644 tests

[FFmpeg-devel] palette{gen,use} FATE tests

2015-02-23 Thread Clément Bœsch
Here are two tests for the recently added filters. I'm hopping that qsort will not cause any issue, otherwise we might need to switch to AV_QSORT (I'm thinking of the sort where multiple different values have the same score in palettegen). Also not sure whether framecrc needs a bitexact flag

Re: [FFmpeg-devel] [PATCH]Fix invalid memory accesses using the fade filter

2015-02-23 Thread Clément Bœsch
On Mon, Feb 23, 2015 at 01:59:45PM +0100, Michael Niedermayer wrote: On Mon, Feb 23, 2015 at 03:27:54AM +0100, Carl Eugen Hoyos wrote: Hi! Attached patch fixes a crash with the following command line: $ ffmpeg -loop 1 -i fate-suite/lena.pnm -vf format=yuva420p,fade -f null - Please

[FFmpeg-devel] [PATCH 2/2] tests: add paletteuse test

2015-02-23 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com --- tests/fate/filter-video.mak | 12 + tests/ref/fate/filter-paletteuse-bayer | 72 + tests/ref/fate/filter-paletteuse-nodither | 72 + tests/ref/fate/filter-paletteuse

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/paletteuse: add diff_mode

2015-02-23 Thread Clément Bœsch
On Thu, Feb 19, 2015 at 01:14:04AM +0100, Michael Niedermayer wrote: On Wed, Feb 18, 2015 at 03:46:24PM +0100, Clément Bœsch wrote: From: Clément Bœsch clem...@stupeflix.com TODO: bump minor --- doc/filters.texi| 15 + libavfilter/vf_paletteuse.c | 151

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/paletteuse: fix error dithering accuracy

2015-02-23 Thread Clément Bœsch
On Wed, Feb 18, 2015 at 03:46:23PM +0100, Clément Bœsch wrote: From: Clément Bœsch clem...@stupeflix.com --- libavfilter/vf_paletteuse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index a8defc7

Re: [FFmpeg-devel] [PATCH] lavfi: add showvolume filter

2015-02-20 Thread Clément Bœsch
On Fri, Feb 20, 2015 at 02:28:21PM +, Paul B Mahol wrote: Signed-off-by: Paul B Mahol one...@gmail.com --- libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/avf_showvolume.c | 197 +++ 3 files changed, 199

Re: [FFmpeg-devel] [PATCH] libavfilter:vf_thumbnail.c: Fix bug in buffer handling for RGB width

2015-02-18 Thread Clément Bœsch
On Wed, Feb 18, 2015 at 02:22:53PM -0800, Chris Kennedy wrote: This is a pretty obvious bug we caught in the thumbnail filter that is very subtle and hardly ever shows issues except for certain videos. Yet it can be seen how it is blatantly going out of bounds by basing the width increment

Re: [FFmpeg-devel] [PATCH] libavfilter:vf_thumbnail.c: Fix bug in buffer handling for RGB width

2015-02-18 Thread Clément Bœsch
On Wed, Feb 18, 2015 at 04:09:39PM -0800, Chris Kennedy wrote: On Wed, Feb 18, 2015 at 2:34 PM, Clément Bœsch u...@pkh.me wrote: On Wed, Feb 18, 2015 at 02:22:53PM -0800, Chris Kennedy wrote: This is a pretty obvious bug we caught in the thumbnail filter that is very subtle and hardly

[FFmpeg-devel] [PATCH 2/2] avfilter/paletteuse: add diff_mode

2015-02-18 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com TODO: bump minor --- doc/filters.texi| 15 + libavfilter/vf_paletteuse.c | 151 2 files changed, 153 insertions(+), 13 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index

[FFmpeg-devel] [PATCH 1/2] avfilter/paletteuse: fix error dithering accuracy

2015-02-18 Thread Clément Bœsch
From: Clément Bœsch clem...@stupeflix.com --- libavfilter/vf_paletteuse.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavfilter/vf_paletteuse.c b/libavfilter/vf_paletteuse.c index a8defc7..87a90d0 100644 --- a/libavfilter/vf_paletteuse.c +++ b/libavfilter

Re: [FFmpeg-devel] [PATCH] avcodec: change type of ff_square_tab from uint32_t to uint16_t

2015-02-17 Thread Clément Bœsch
On Tue, Feb 17, 2015 at 04:31:07PM +0800, Zhaoxiu Zeng wrote: From bf2964c07fde48c633ca4d8276282010e7c7f084 Mon Sep 17 00:00:00 2001 From: zhaoxiu.zeng zhaoxiu.z...@gmail.com Date: Tue, 17 Feb 2015 16:03:47 +0800 Subject: [PATCH 1/1] avcodec: change type of ff_square_tab from uint32_t to

Re: [FFmpeg-devel] [PATCH] avcodec: change type of ff_square_tab from uint32_t to uint16_t

2015-02-17 Thread Clément Bœsch
On Tue, Feb 17, 2015 at 10:03:29AM +0100, Clément Bœsch wrote: On Tue, Feb 17, 2015 at 04:31:07PM +0800, Zhaoxiu Zeng wrote: From bf2964c07fde48c633ca4d8276282010e7c7f084 Mon Sep 17 00:00:00 2001 From: zhaoxiu.zeng zhaoxiu.z...@gmail.com Date: Tue, 17 Feb 2015 16:03:47 +0800 Subject

Re: [FFmpeg-devel] [PATCH 2/2] doc/faq: explain DAR/SAR preserving.

2015-02-16 Thread Clément Bœsch
On Mon, Feb 16, 2015 at 07:34:52PM +0100, Nicolas George wrote: Le primidi 21 pluviôse, an CCXXIII, Kieran Kunhya a écrit : The DAR for analogue compatible media (e.g. SD DVB) comes from the active samples and not from the full image. The exact meaning of DAR in this context is entirely

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/hevcdsp: optimize pixel comparison in sao_edge_filter

2015-02-16 Thread Clément Bœsch
On Mon, Feb 16, 2015 at 09:48:25PM +0100, James Almer wrote: ffmpeg | branch: master | James Almer jamr...@gmail.com | Mon Feb 16 16:53:31 2015 -0300| [22596383f3b8c7cd8a06570957face3875a73d3b] | committer: James Almer avcodec/hevcdsp: optimize pixel comparison in sao_edge_filter GCC

Re: [FFmpeg-devel] Color quantization for GIF v2

2015-02-14 Thread Clément Bœsch
Patchset improved with regard to: • quality: palettegen now uses the variance to determine which box to split instead of the number of color inside (a box encloses a bunch of colors and is averaged at the end to produce the palette color entry). • speed: paletteuse now cache the

Re: [FFmpeg-devel] [RFC][PATCH] ffplay: factorize subtitle rendering code to a private filter

2015-02-14 Thread Clément Bœsch
On Sat, Feb 14, 2015 at 02:08:15AM +0100, Marton Balint wrote: Signed-off-by: Marton Balint c...@passwd.hu --- Makefile | 1 + doc/ffplay.texi | 4 + ffplay.c | 336 +

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/wmalosslessdec: optimize sign operation

2015-02-14 Thread Clément Bœsch
On Sat, Feb 14, 2015 at 09:47:34AM +0100, Reimar Döffinger wrote: On 13.02.2015, at 17:51, zhaoxiu.zeng zhaoxiu.z...@gmail.com wrote: From b08b4a38c87000fe5549de96f65de6ba77740b30 Mon Sep 17 00:00:00 2001 From: Zeng Zhaoxiu zhaoxiu.z...@gmail.com Date: Fri, 13 Feb 2015 23:52:29 +0800

Re: [FFmpeg-devel] Backport keywords

2015-02-12 Thread Clément Bœsch
On Thu, Feb 12, 2015 at 09:06:54PM +0100, Michael Niedermayer wrote: Hi all ubitux pushed me into thinking about $subj, so heres some suggestions Commits which are security relevant must be backported Other (important) bugfixes can be backported as well, if someone wants to do the work.

Re: [FFmpeg-devel] [PATCH 5/6] avfilter: add paletteuse filter

2015-02-12 Thread Clément Bœsch
On Mon, Feb 09, 2015 at 06:35:13PM +0100, Clément Bœsch wrote: --- doc/filters.texi| 50 +++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/vf_paletteuse.c | 791 4 files changed, 843

Re: [FFmpeg-devel] Backport keywords

2015-02-12 Thread Clément Bœsch
On Thu, Feb 12, 2015 at 09:16:28PM +0100, Clément Bœsch wrote: On Thu, Feb 12, 2015 at 09:06:54PM +0100, Michael Niedermayer wrote: Hi all ubitux pushed me into thinking about $subj, so heres some suggestions Commits which are security relevant must be backported Other (important

Re: [FFmpeg-devel] Color quantization for GIF v2

2015-02-10 Thread Clément Bœsch
On Mon, Feb 09, 2015 at 06:35:08PM +0100, Clément Bœsch wrote: [...] • I added many debug utils (understand: dead code) in palettegen which is very useful for debugging and error checking. I'd like to keep them if no one mind. For example, it allows generating pictures

Re: [FFmpeg-devel] Color quantization for GIF v2

2015-02-10 Thread Clément Bœsch
On Mon, Feb 09, 2015 at 06:35:08PM +0100, Clément Bœsch wrote: [...] • we might still want to consider a per frame palette approach To elaborate on this point, what I meant was to define a per frame palette only for the part that change. I originally dismissed that idea for 2 reasons

Re: [FFmpeg-devel] [PATCH] tests: drop bc dependency

2015-02-10 Thread Clément Bœsch
On Tue, Feb 10, 2015 at 04:02:53AM +0100, Reimar Döffinger wrote: On 08.02.2015, at 10:32, Clément Bœsch u...@pkh.me wrote: --- a/tests/fate-run.sh +++ b/tests/fate-run.sh @@ -38,7 +38,7 @@ target_path(){ # $1=value1, $2=value2, $3=threshold # prints 0 if absolute difference between

[FFmpeg-devel] [PATCH 3/6] avcodec/gif: support crop and transparency with PAL8

2015-02-09 Thread Clément Bœsch
--- libavcodec/gif.c | 53 ++- tests/ref/fate/gifenc-pal8 | 346 ++--- 2 files changed, 220 insertions(+), 179 deletions(-) diff --git a/libavcodec/gif.c b/libavcodec/gif.c index 27d054e..12a039e 100644 --- a/libavcodec/gif.c +++

[FFmpeg-devel] [PATCH 4/6] avfilter: add palettegen filter

2015-02-09 Thread Clément Bœsch
--- doc/filters.texi| 45 libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/vf_palettegen.c | 523 4 files changed, 570 insertions(+) create mode 100644 libavfilter/vf_palettegen.c diff --git

[FFmpeg-devel] Color quantization for GIF v2

2015-02-09 Thread Clément Bœsch
Hi folks, TL;DR: http://lucy.pkh.me/ffgif/outputs/ (note: this page is heavy; over 200M) So here is the new version of the patchset. Many changes since previous time, here is a summary: palettegen filter: • added max_colors and stats_mode options • RGB 5:5:5 to full resolution RGB (24 bits)

[FFmpeg-devel] [PATCH 6/6] avfilter: bump minor and Changelog document the new filters

2015-02-09 Thread Clément Bœsch
--- Changelog | 1 + libavfilter/version.h | 4 ++-- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/Changelog b/Changelog index 8e55969..ae4340c 100644 --- a/Changelog +++ b/Changelog @@ -19,6 +19,7 @@ version next: - Twofish symmetric block cipher - Support DNx100

[FFmpeg-devel] [PATCH 5/6] avfilter: add paletteuse filter

2015-02-09 Thread Clément Bœsch
--- doc/filters.texi| 50 +++ libavfilter/Makefile| 1 + libavfilter/allfilters.c| 1 + libavfilter/vf_paletteuse.c | 791 4 files changed, 843 insertions(+) create mode 100644 libavfilter/vf_paletteuse.c diff --git

[FFmpeg-devel] [PATCH 1/6] avformat/gif: simplify gif_image_write_header() prototype

2015-02-09 Thread Clément Bœsch
--- libavformat/gif.c | 16 ++-- 1 file changed, 6 insertions(+), 10 deletions(-) diff --git a/libavformat/gif.c b/libavformat/gif.c index e817121..b4c5e8b 100644 --- a/libavformat/gif.c +++ b/libavformat/gif.c @@ -28,13 +28,12 @@ #include libavutil/log.h #include libavutil/opt.h

[FFmpeg-devel] [PATCH 2/6] avformat/gif: use first packet palette as global for PAL8

2015-02-09 Thread Clément Bœsch
This will allow the payload in PAL8 packets to not contain 768B of local palette (which is not LZW compressed). --- libavformat/gif.c | 70 +++ 1 file changed, 50 insertions(+), 20 deletions(-) diff --git a/libavformat/gif.c b/libavformat/gif.c

Re: [FFmpeg-devel] [PATCH] tests: drop bc dependency

2015-02-08 Thread Clément Bœsch
On Tue, Jan 20, 2015 at 09:58:33PM +0100, Reimar Döffinger wrote: On Mon, Jan 19, 2015 at 10:58:02PM +0100, Clément Bœsch wrote: -echo scale=2; v = $1 - $2; if (v 0) v = -v; if (v $3) r = 1; r | bc +awk BEGIN { v=$1-$2; printf \%d\\n\, ((v0?v:-v) $3) ? 1 : 0 } I'd suggest

Re: [FFmpeg-devel] [PATCH] tests: drop bc dependency

2015-02-08 Thread Clément Bœsch
On Sun, Feb 08, 2015 at 10:27:14AM +0100, Clément Bœsch wrote: On Tue, Jan 20, 2015 at 09:58:33PM +0100, Reimar Döffinger wrote: On Mon, Jan 19, 2015 at 10:58:02PM +0100, Clément Bœsch wrote: -echo scale=2; v = $1 - $2; if (v 0) v = -v; if (v $3) r = 1; r | bc +awk BEGIN { v

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/srtdec: attempt to correct SubRip positioning

2015-02-08 Thread Clément Bœsch
On Sun, Feb 08, 2015 at 12:40:19PM +0100, Clément Bœsch wrote: The positioning was completely wrong. First, the coordinates are expressed in ASS playback resolution (which is by default 384x288). Secondly, the coordinates define a drawing rectangle, not a moving area. The previous code

[FFmpeg-devel] [PATCH 1/2] avcodec/ass: make default playback resolution available to decoders

2015-02-08 Thread Clément Bœsch
--- libavcodec/ass.c | 5 +++-- libavcodec/ass.h | 3 +++ 2 files changed, 6 insertions(+), 2 deletions(-) diff --git a/libavcodec/ass.c b/libavcodec/ass.c index ea247f8..468b8bb 100644 --- a/libavcodec/ass.c +++ b/libavcodec/ass.c @@ -36,8 +36,8 @@ int ff_ass_subtitle_header(AVCodecContext

[FFmpeg-devel] [PATCH 2/2] avcodec/srtdec: attempt to correct SubRip positioning

2015-02-08 Thread Clément Bœsch
The positioning was completely wrong. First, the coordinates are expressed in ASS playback resolution (which is by default 384x288). Secondly, the coordinates define a drawing rectangle, not a moving area. The previous code was making subtitles move from a random position to another random

Re: [FFmpeg-devel] Adding Force Style option in Subtitles Filter

2015-02-08 Thread Clément Bœsch
On Fri, Feb 06, 2015 at 10:47:09AM +0100, Stefano Sabatini wrote: On date Thursday 2015-02-05 22:12:08 +0530, Eejya Singh encoded: [...] From ed526a03c939055e2b9f931a0cb4e0e22b7b5b04 Mon Sep 17 00:00:00 2001 From: Eejya Singh singh.ee...@gmail.com Date: Wed, 28 Jan 2015 17:41:42 +0530

Re: [FFmpeg-devel] [PATCH] ffprobe: Force string_validation to int type, its accessed via AVOption as int

2015-02-08 Thread Clément Bœsch
On Fri, Feb 06, 2015 at 10:10:22PM +0100, Michael Niedermayer wrote: Signed-off-by: Michael Niedermayer michae...@gmx.at --- ffprobe.c |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/ffprobe.c b/ffprobe.c index d352bb6b..8617c96 100644 --- a/ffprobe.c +++

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-07 Thread Clément Bœsch
On Sat, Feb 07, 2015 at 04:32:02PM +0100, wm4 wrote: On Sat, 7 Feb 2015 10:34:16 + (UTC) Carl Eugen Hoyos ceho...@ag.or.at wrote: Carl Eugen Hoyos cehoyos at ag.or.at writes: wm4 nfxjfg at googlemail.com writes: I will fix this later if nobody beats me. How do you

Re: [FFmpeg-devel] [RFC] Exporting the alpha mode from decoders

2015-02-06 Thread Clément Bœsch
On Fri, Feb 06, 2015 at 12:32:14PM +0100, wm4 wrote: This is a proposal for an API extension. Currently, some pixel formats support alpha, but whether the alpha component contains something useful or just garbage is not part of the pixel format definition. This applies at least to packed RGB

Re: [FFmpeg-devel] [PATCH] tests: add spp test

2015-02-06 Thread Clément Bœsch
On Fri, Feb 06, 2015 at 12:14:32PM +0100, Stefano Sabatini wrote: On date Thursday 2015-02-05 22:57:31 +0100, Clément Bœsch encoded: On Thu, Feb 05, 2015 at 06:04:56PM +0100, Michael Niedermayer wrote: On Thu, Feb 05, 2015 at 12:49:20PM +0100, Stefano Sabatini wrote: On date Wednesday

Re: [FFmpeg-devel] [PATCH] Revert Autodetect libxcb.

2015-02-05 Thread Clément Bœsch
On Thu, Feb 05, 2015 at 10:33:38PM +0100, wm4 wrote: On Thu, 5 Feb 2015 22:11:22 +0100 Clément Bœsch u...@pkh.me wrote: On Thu, Feb 05, 2015 at 04:55:37PM +0100, Nicolas George wrote: Le sextidi 16 pluviôse, an CCXXIII, Clement Boesch a écrit : Linux is not only used by desktop

<    7   8   9   10   11   12   13   14   15   16   >