Re: [FFmpeg-devel] [PATCH v2 7/9] lavc/ccaption_dec: implement musical glyph

2016-01-12 Thread Clément Bœsch
On Tue, Jan 12, 2016 at 05:42:58PM -0800, Aman Gupta wrote: > From: Aman Gupta > > This is the most commonly used character from the special north-american > character set. All the non-standard charsets are "optional" according to > the spec, and we currently implement none of

Re: [FFmpeg-devel] [PATCH v2 8/9] lavc/ccaption_dec: implement positioning for closed captions

2016-01-12 Thread Clément Bœsch
On Tue, Jan 12, 2016 at 05:42:59PM -0800, Aman Gupta wrote: > From: Aman Gupta > > Positioning math is based on the guidelines in > https://dvcs.w3.org/hg/text-tracks/raw-file/default/608toVTT/608toVTT.html#positioning-in-cea-608 > --- > libavcodec/ccaption_dec.c | 29

Re: [FFmpeg-devel] [PATCH 2/2] lavc/WIP: allow subtitle text format to be ASS without timing

2016-01-10 Thread Clément Bœsch
On Sun, Jan 10, 2016 at 02:03:46PM +0100, wm4 wrote: > On Sat, 9 Jan 2016 14:46:52 +0100 > Clément Bœsch <u...@pkh.me> wrote: > > > From: Clément Bœsch <clem...@stupeflix.com> > > > > --- > > TODO > > - ass_split needs to be able to handl

[FFmpeg-devel] [PATCH 2/2] lavc/WIP: allow subtitle text format to be ASS without timing

2016-01-09 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- TODO - ass_split needs to be able to handle dialog event without "Dialogue: ..." so our encoding chain can handle the sane decoded subtitles - zvbi needs testing - option sub_text_format needs to be documented and default ready

[FFmpeg-devel] [PATCH 1/2] Kill timed SSA

2016-01-09 Thread Clément Bœsch
--- libavcodec/Makefile | 4 ++-- libavcodec/assdec.c | 60 +++- libavcodec/assenc.c | 14 ++-- libavformat/assenc.c | 14 libavformat/nut.c| 1 - 5 files changed, 24 insertions(+), 69 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-08 Thread Clément Bœsch
On Fri, Jan 08, 2016 at 05:24:15PM +0530, Anshul wrote: > > > On 6 January 2016 1:55:27 am IST, "Clément Bœsch" <u...@pkh.me> wrote: > >On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: > >[...] > >> This indeed LGTM, but I'm not the ma

Re: [FFmpeg-devel] [PATCH] lavc/ccaption_dec: fix always true condition

2016-01-07 Thread Clément Bœsch
On Wed, Jan 06, 2016 at 01:39:30AM +0100, Michael Niedermayer wrote: > On Tue, Jan 05, 2016 at 09:54:54PM +0100, Clément Bœsch wrote: > > No idea why this wasn't ever detected by a static analyzer. > > --- > > libavcodec/ccaption_dec.c | 2 +- > > 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/3] lavc/ccaption_dec: use ff_parity()

2016-01-07 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 11:11:03PM +0100, Michael Niedermayer wrote: > On Sun, Jan 03, 2016 at 08:21:01PM +0100, Clément Bœsch wrote: > > --- > > libavcodec/ccaption_dec.c | 38 ++ > > 1 file changed, 2 insertions(+), 36 deletions(-) >

Re: [FFmpeg-devel] [PATCH 3/3] lavc/g729dec: use ff_parity()

2016-01-07 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 11:09:01PM +0100, Michael Niedermayer wrote: > On Sun, Jan 03, 2016 at 08:21:02PM +0100, Clément Bœsch wrote: > > --- > > libavcodec/g729dec.c | 10 +- > > 1 file changed, 1 insertion(+), 9 deletions(-) > > LGTM > thx > pushe

Re: [FFmpeg-devel] [PATCH 1/3] common: add ff_parity()

2016-01-07 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 08:25:38PM +0100, Clément Bœsch wrote: > On Sun, Jan 03, 2016 at 08:21:00PM +0100, Clément Bœsch wrote: > > --- > > configure | 2 ++ > > libavutil/x86/intmath.h | 9 + > > 2 files changed, 11 insertions(+) > > >

Re: [FFmpeg-devel] [FFmpeg-cvslog] mips: display a warning message when using an unknown CPU

2016-01-06 Thread Clément Bœsch
On Wed, Jan 06, 2016 at 09:28:33PM +0100, Vicente Olivert Riera wrote: > ffmpeg | branch: master | Vicente Olivert Riera | > Wed Jan 6 16:55:29 2016 +| [6282bdc2bf36ce492d233db38bce219a1a976cfe] | > committer: Michael Niedermayer > > mips: display a warning

Re: [FFmpeg-devel] [PATCH 2/3] libavcodec/ccaption_dec: clean up and standardize white space

2016-01-05 Thread Clément Bœsch
On Mon, Jan 04, 2016 at 07:28:02PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 98 > ++- > 1 file changed, 45 insertions(+), 53 deletions(-) > There are much more garbage formatting in that file

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: rewrite packet handler as case statement; remove COR3 macro

2016-01-05 Thread Clément Bœsch
On Mon, Jan 04, 2016 at 07:28:03PM -0800, Aman Gupta wrote: > From: Aman Gupta > > --- > libavcodec/ccaption_dec.c | 92 > +++ > 1 file changed, 53 insertions(+), 39 deletions(-) > > diff --git a/libavcodec/ccaption_dec.c

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-05 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 01:07:15PM +0100, Clément Bœsch wrote: [...] > This indeed LGTM, but I'm not the maintainer. > OK I finally understood why it's done that way: validate_cc_data_pair() alters the pkt data, but the decoder isn't supposed to do that. So this patch is actually inc

[FFmpeg-devel] [PATCH] lavc/ccaption_dec: fix always true condition

2016-01-05 Thread Clément Bœsch
No idea why this wasn't ever detected by a static analyzer. --- libavcodec/ccaption_dec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 4e478e0..94771d5 100644 --- a/libavcodec/ccaption_dec.c +++

Re: [FFmpeg-devel] [PATCH 3/3] libavcodec/ccaption_dec: rewrite packet handler as case statement; remove COR3 macro

2016-01-05 Thread Clément Bœsch
On Tue, Jan 05, 2016 at 09:35:41PM +0100, Clément Bœsch wrote: > On Mon, Jan 04, 2016 at 07:28:03PM -0800, Aman Gupta wrote: > > From: Aman Gupta <a...@tmm1.net> [...] > > } else if ( (hi == 0x10 && (lo >= 0x40 || lo <= 0x5f)) || > >(

Re: [FFmpeg-devel] [PATCH]lavf/decimate: Fix total difference for the first frame

2016-01-04 Thread Clément Bœsch
On Mon, Jan 04, 2016 at 05:32:32PM +, Derek Buitenhuis wrote: > On 1/4/2016 5:17 PM, Carl Eugen Hoyos wrote: > > I wish I would understand;-( > > > > Since this fixes a reported issue here, I will > > commit my patch if nobody objects. > > [17:30] * Daemon404 pokes ubitux > [17:30]

Re: [FFmpeg-devel] [PATCH]lavf/decimate: Fix total difference for the first frame

2016-01-04 Thread Clément Bœsch
On Mon, Jan 04, 2016 at 08:53:24PM +, Carl Eugen Hoyos wrote: > Clément Bœsch pkh.me> writes: > > > +if (cyclestart == 0) { > > +vdm->vmi[0].maxbdiff = vdm->vmi[1].maxbdiff; > > +vdm->vmi[0].totdiff = vdm->scthresh + 1; > >

Re: [FFmpeg-devel] [PATCH 1/2] lavc/pcm_tablegen: slight speedup of table generation

2016-01-04 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 09:49:33PM -0800, Ganesh Ajjanagadde wrote: > On Sun, Jan 3, 2016 at 1:30 PM, Carl Eugen Hoyos wrote: > > Carl Eugen Hoyos ag.or.at> writes: > > > >> Ganesh Ajjanagadde mit.edu> writes: > >> > >> > No one has told me what is interesting > >> > >> Did

Re: [FFmpeg-devel] [PATCH 1/3] common: add ff_parity()

2016-01-03 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 05:56:41PM -0300, James Almer wrote: [...] > >> +static av_always_inline av_const int ff_parity(uint32_t v) > >> +{ > >> +#if HAVE_PARITY > >> +return __builtin_parity(v); > >> +#else > >> +return av_popcount(v) & 1; > >> +#endif > > > > Do compilers really

Re: [FFmpeg-devel] [PATCH 1/3] common: add ff_parity()

2016-01-03 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 05:54:34PM -0300, James Almer wrote: > On 1/3/2016 4:22 PM, Clément Bœsch wrote: > > On Sun, Jan 03, 2016 at 08:21:00PM +0100, Clément Bœsch wrote: > > [...] > >> +static av_always_inline av_const int ff_parity(uint32_t v) > >> +{ >

Re: [FFmpeg-devel] [PATCH] libavcodec/ccaption_dec: remove unnecessary buffering of closed caption packets

2016-01-03 Thread Clément Bœsch
On Fri, Jan 01, 2016 at 04:40:06PM -0800, Aman Gupta wrote: > From: Aman Gupta > > CC data is fed to in small chunks (usually 60 bytes at a time) > and is parsed fully by the eia608 decoder. There is no reason to copy it > into a secondary buffer first. > --- >

Re: [FFmpeg-devel] [PATCH] lavc/ccaption_dec: simplify parity check

2016-01-03 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 06:53:34PM +0100, Clément Bœsch wrote: > On Sun, Jan 03, 2016 at 05:43:26PM +, Derek Buitenhuis wrote: > > On 1/3/2016 5:33 PM, Clément Bœsch wrote: > > > +return (0x6996966996696996ULL >> (x & 63) ^ (x>>7) ^ (x>>6))

Re: [FFmpeg-devel] [PATCH] lavc/ccaption_dec: simplify parity check

2016-01-03 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 05:43:26PM +, Derek Buitenhuis wrote: > On 1/3/2016 5:33 PM, Clément Bœsch wrote: > > +return (0x6996966996696996ULL >> (x & 63) ^ (x>>7) ^ (x>>6)) & 1; > > I mean, I see how it works, but it's incredibly non-obvious w

[FFmpeg-devel] [PATCH] lavc/ccaption_dec: simplify parity check

2016-01-03 Thread Clément Bœsch
--- libavcodec/ccaption_dec.c | 43 +++ 1 file changed, 7 insertions(+), 36 deletions(-) diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c index 9f67caa..1fdf7ed 100644 --- a/libavcodec/ccaption_dec.c +++ b/libavcodec/ccaption_dec.c @@

[FFmpeg-devel] [PATCH 3/3] lavc/g729dec: use ff_parity()

2016-01-03 Thread Clément Bœsch
--- libavcodec/g729dec.c | 10 +- 1 file changed, 1 insertion(+), 9 deletions(-) diff --git a/libavcodec/g729dec.c b/libavcodec/g729dec.c index 99053ad..7265883 100644 --- a/libavcodec/g729dec.c +++ b/libavcodec/g729dec.c @@ -181,14 +181,6 @@ static inline uint16_t g729_prng(uint16_t

[FFmpeg-devel] [PATCH 1/3] common: add ff_parity()

2016-01-03 Thread Clément Bœsch
--- configure | 2 ++ libavutil/x86/intmath.h | 9 + 2 files changed, 11 insertions(+) diff --git a/configure b/configure index 6710f85..610be92 100755 --- a/configure +++ b/configure @@ -1738,6 +1738,7 @@ BUILTIN_LIST=" machine_rw_barrier MemoryBarrier

Re: [FFmpeg-devel] [PATCH 1/3] common: add ff_parity()

2016-01-03 Thread Clément Bœsch
On Sun, Jan 03, 2016 at 08:21:00PM +0100, Clément Bœsch wrote: > --- > configure | 2 ++ > libavutil/x86/intmath.h | 9 + > 2 files changed, 11 insertions(+) > > diff --git a/configure b/configure > index 6710f85..610be92 100755 > --- a/con

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add showspectrumpic filter

2016-01-01 Thread Clément Bœsch
On Fri, Jan 01, 2016 at 10:00:31AM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > doc/filters.texi | 106 +++ > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/avf_showspectrum.c |

Re: [FFmpeg-devel] [PATCHv2] lavf/srtdec: rewrite parsing logic

2016-01-01 Thread Clément Bœsch
On Sat, Dec 26, 2015 at 06:51:00PM +0100, Clément Bœsch wrote: > Fixes Ticket #5032 > > The samples in Ticket #5032 is using \r\r\n as line breaks. Since we > already are handling \r, or \n, or \r\n as line breaks, \r\n\n will be > considered as a double line breaks. This is a

Re: [FFmpeg-devel] [PATCH] avfilter/trim: support all channel numbers in atrim filter

2015-12-30 Thread Clément Bœsch
On Wed, Dec 30, 2015 at 09:17:56AM +0100, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavfilter/trim.c | 27 +++ > 1 file changed, 27 insertions(+) > > diff --git a/libavfilter/trim.c b/libavfilter/trim.c > index b2d9c6f..9d040dd 100644

Re: [FFmpeg-devel] [PATCH] avfilter/trim: support all channel numbers in atrim filter

2015-12-30 Thread Clément Bœsch
On Wed, Dec 30, 2015 at 09:14:23AM +, Paul B Mahol wrote: > > Q: why is it not the default? > > > > The all channel counts layout? > Yes; why ff_default_query_formats() is doing a query with all_channel_layouts and is not actually ff_query_formats_all (which is doing ff_all_channel_counts)?

Re: [FFmpeg-devel] [PATCH] lavc/cook: get rid of wasteful pow in init_pow2table

2015-12-29 Thread Clément Bœsch
On Tue, Dec 29, 2015 at 09:28:34AM -0800, Ganesh Ajjanagadde wrote: > The table is highly structured, so pow (or exp2 for that matter) can entirely > be avoided, yielding a ~ 40x speedup with no loss of accuracy. > > sample benchmark (Haswell, GNU/Linux): > new: > 4449 decicycles in

[FFmpeg-devel] [PATCHv2] lavf/srtdec: rewrite parsing logic

2015-12-26 Thread Clément Bœsch
Fixes Ticket #5032 The samples in Ticket #5032 is using \r\r\n as line breaks. Since we already are handling \r, or \n, or \r\n as line breaks, \r\n\n will be considered as a double line breaks. This is an issue because ff_subtitles_read_text_chunk() will as a result stop extracting a chunk

Re: [FFmpeg-devel] [PATCH] lavf/srtdec: rewrite parsing logic

2015-12-24 Thread Clément Bœsch
On Thu, Dec 24, 2015 at 01:11:49PM +0100, Clément Bœsch wrote: > Fixes Ticket #5032 OK I was a bit lazy in writing a longer description, so here are some more explanations: The samples in Ticket #5032 is basically composed of \r\r\n line breaks. So we already are handling \r, or \n, or \

[FFmpeg-devel] [PATCH] lavf/srtdec: rewrite parsing logic

2015-12-24 Thread Clément Bœsch
Fixes Ticket #5032 --- libavformat/srtdec.c | 165 ++- tests/fate/subtitles.mak |6 + tests/ref/fate/sub-srt-madness-timeshift | 36 + tests/ref/fate/sub-srt-rrn-remux | 2113 ++ 4 files changed, 2270 insertions(+), 50

Re: [FFmpeg-devel] [PATCH 03/15] lavfi/f_ebur128: replace pow(10, x) by exp10(x)

2015-12-23 Thread Clément Bœsch
On Wed, Dec 23, 2015 at 10:47:23AM -0800, Ganesh Ajjanagadde wrote: > exp10, recently introduced, is superior for the purpose. > > Signed-off-by: Ganesh Ajjanagadde > --- > libavfilter/f_ebur128.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] libavformat: palettized QuickTime video in Matroska, round 4

2015-12-23 Thread Clément Bœsch
On Wed, Dec 23, 2015 at 11:25:44AM +0100, Mats Peterson wrote: [...] > From: Mats Peterson So are you the sole author of this? > Date: Wed, 23 Dec 2015 11:19:06 +0100 > Subject: [PATCH] libavformat: palettized QuickTime video in Matroska, round 4 > Use "[PATCH v4]" instead

Re: [FFmpeg-devel] Comments about patch

2015-12-23 Thread Clément Bœsch
On Wed, Dec 23, 2015 at 11:54:28AM +0100, Mats Peterson wrote: > Clement, can you please repeat what you said. I don't know where the hell > your post went. > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/185664.html -- Clément B. signature.asc Description: PGP signature

Re: [FFmpeg-devel] Comments about patch

2015-12-23 Thread Clément Bœsch
On Wed, Dec 23, 2015 at 12:04:15PM +0100, Mats Peterson wrote: [...] > OK. Regarding being the sole author, well I'm the one who has made the > patch. I don't understand what you mean. > It was a real question; I remember Martin being mentioned in the ticket, and Carl Eugen working on a patch.

Re: [FFmpeg-devel] Comments about patch

2015-12-23 Thread Clément Bœsch
On Wed, Dec 23, 2015 at 12:04:15PM +0100, Mats Peterson wrote: [...] > I don't know what you mean by "a << 24" is undefined if a msb is set. I'm > doing exactly as it was done in mov.c before. my bad, didn't see a was unsigned, you can ignore. [...] -- Clément B. signature.asc Description:

[FFmpeg-devel] [PATCH] lavu: add pthread asserts if ASSERT_LEVEL>1

2015-12-22 Thread Clément Bœsch
--- libavutil/thread.h | 96 ++ 1 file changed, 96 insertions(+) diff --git a/libavutil/thread.h b/libavutil/thread.h index 3d15737..0bb745e 100644 --- a/libavutil/thread.h +++ b/libavutil/thread.h @@ -30,6 +30,102 @@ #if HAVE_PTHREADS

Re: [FFmpeg-devel] Question about FATE

2015-12-21 Thread Clément Bœsch
On Mon, Dec 21, 2015 at 07:39:40PM +0100, Mats Peterson wrote: > The following configuration causes the FATE tests to fail (not so when using > a plain './configure' without anything else): > > #!/bin/sh > PKG_CONFIG_PATH='/home/mats/lib/pkgconfig' \ > CPPFLAGS='-I/home/mats/include' \ >

Re: [FFmpeg-devel] [PATCH] lavf/img2enc: add atomic_writing option

2015-12-21 Thread Clément Bœsch
On Tue, Dec 08, 2015 at 07:01:40PM +0100, Michael Niedermayer wrote: > On Tue, Dec 08, 2015 at 10:47:23AM +0100, Clément Bœsch wrote: > > From: Clément Bœsch <clem...@stupeflix.com> > > > > This behaviour change caused a regression on our side recently, we might >

Re: [FFmpeg-devel] [PATCHv2] lavu/libm: add erf hack and make dynaudnorm available everywhere

2015-12-21 Thread Clément Bœsch
On Mon, Dec 21, 2015 at 08:31:47PM -0800, Ganesh Ajjanagadde wrote: [...] > I unfortunately do not see an easy solution to avfilter testing in > general: Paul [...] The problem with testing filters is not even remotely close to Paul; the main issue is that many filters are actually using floats,

Re: [FFmpeg-devel] [PATCH] lavfi/scale: add nb_slices debug option

2015-12-21 Thread Clément Bœsch
On Sat, Dec 19, 2015 at 11:00:53AM +0100, Nicolas George wrote: > L'octidi 28 frimaire, an CCXXIV, Clement Boesch a écrit : > > +}else if (scale->nb_slices) { > > +int i; > > +const int nb_slices = FFMIN(scale->nb_slices, link->h); > > +for (i = 0; i < nb_slices; i++) {

Re: [FFmpeg-devel] [PATCH] lavc: add text encoder

2015-12-21 Thread Clément Bœsch
On Thu, Dec 17, 2015 at 12:30:27PM +0100, Clément Bœsch wrote: > --- > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 2 +- > libavcodec/srtenc.c| 37 +++- > libavcodec/version.h | 2 +- > tests/fate/subtitles.mak | 3 + > tests

Re: [FFmpeg-devel] [PATCH] Some minor fixes of my "patchset" for palettized QuickTime video in Matroska

2015-12-21 Thread Clément Bœsch
On Mon, Dec 21, 2015 at 05:16:36PM +0100, Mats Peterson wrote: [...] > As if that wasn't enough, here is another update. This time it's passing the > FATE tests, unlike the old one. In order to refresh your memories, this > patch fixes the long-standing issue regarding not recognizing palettized >

[FFmpeg-devel] [PATCH] lavfi/scale: add nb_slices debug option

2015-12-18 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- libavfilter/vf_scale.c | 8 1 file changed, 8 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index f2f475e..d8f5f77 100644 --- a/libavfilter/vf_scale.c +++ b/libavfilter/vf_scale.c @@ -110,6 +110,8 @@ t

Re: [FFmpeg-devel] [PATCH] lavfi/scale: add nb_slices debug option

2015-12-18 Thread Clément Bœsch
On Fri, Dec 18, 2015 at 04:33:18PM +0100, Nicolas George wrote: > L'octidi 28 frimaire, an CCXXIV, Clement Boesch a écrit : > > +const int slice_h = FFMAX(1, link->h / scale->nb_slices); > > +for (i = 0; i < scale->nb_slices; i++) > > +scale_slice(link, out, in,

Re: [FFmpeg-devel] [PATCH] lavu/intmath: add faster clz support

2015-12-17 Thread Clément Bœsch
On Thu, Dec 17, 2015 at 09:23:53AM -0800, Ganesh Ajjanagadde wrote: > On Thu, Dec 17, 2015 at 9:20 AM, Kieran Kunhya wrote: > >>> +static av_always_inline av_const unsigned ff_clz_c(unsigned v) > >>> +{ > >>> +unsigned i = sizeof(x) * 8; > >>> + > >>> +while (x) { > >>> +

[FFmpeg-devel] [PATCH] lavc: add text encoder

2015-12-17 Thread Clément Bœsch
--- libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 2 +- libavcodec/srtenc.c| 37 +++- libavcodec/version.h | 2 +- tests/fate/subtitles.mak | 3 + tests/ref/fate/sub-textenc | 213 + 6 files changed, 253

Re: [FFmpeg-devel] [PATCH 2/2] lavf: use a video frame pool for each link of the filtergraph

2015-12-11 Thread Clément Bœsch
On Fri, Dec 11, 2015 at 01:32:47PM +0100, Matthieu Bouron wrote: [...] > diff --git a/libavfilter/video.c b/libavfilter/video.c > index 0274fc1..5b0b7f9 100644 > --- a/libavfilter/video.c > +++ b/libavfilter/video.c > @@ -32,6 +32,8 @@ > #include "internal.h" > #include "video.h" > > +#define

Re: [FFmpeg-devel] Add a frame/buffer pool to AVFilter

2015-12-11 Thread Clément Bœsch
On Fri, Dec 11, 2015 at 01:32:45PM +0100, Matthieu Bouron wrote: > --- > > Hello, > > The following two commits aim to add a video frame pool to AVFilter. > This feature was originally introduced by commit > 39f66edbeae5ccabefe38b2fcb25d6c242d868c0 but was removed later on when the > AVFilter

[FFmpeg-devel] [PATCH] lavf/img2enc: add atomic_writing option

2015-12-08 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> This behaviour change caused a regression on our side recently, we might want to disable the option by default. --- libavformat/img2enc.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/img2enc.c b/libav

Re: [FFmpeg-devel] [PATCH 2/2] configure: libbsd support for arc4random()

2015-12-08 Thread Clément Bœsch
On Tue, Dec 08, 2015 at 07:34:51AM -0500, Ganesh Ajjanagadde wrote: > On Tue, Dec 8, 2015 at 7:27 AM, wm4 wrote: > > On Sun, 6 Dec 2015 22:56:33 -0500 > > Ganesh Ajjanagadde wrote: > > > >> On non-BSD machines, there exists a package libbsd for

Re: [FFmpeg-devel] [PATCH] avcodec: avutil: use avutil/thread.h instead of redundant conditional includes

2015-12-07 Thread Clément Bœsch
On Mon, Dec 07, 2015 at 10:22:10AM -0500, Ronald S. Bultje wrote: > Hi, > > On Mon, Dec 7, 2015 at 10:15 AM, Clément Bœsch <u...@pkh.me> wrote: > > > On Mon, Dec 07, 2015 at 04:13:11PM +0100, Nicolas George wrote: > > > Le septidi 17 frimaire, an CCXXIV, Clem

[FFmpeg-devel] [PATCH] avcodec: avutil: use avutil/thread.h instead of redundant conditional includes

2015-12-07 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- libavcodec/frame_thread_encoder.c | 9 + libavcodec/pthread_frame.c| 10 ++ libavcodec/utils.c| 9 + libavcodec/vp8.h | 9 + libavutil/opencl.c

Re: [FFmpeg-devel] [PATCH] avcodec: avutil: use avutil/thread.h instead of redundant conditional includes

2015-12-07 Thread Clément Bœsch
On Mon, Dec 07, 2015 at 04:13:11PM +0100, Nicolas George wrote: > Le septidi 17 frimaire, an CCXXIV, Clement Boesch a écrit : > > From: Clément Bœsch <clem...@stupeflix.com> > > > > --- > > libavcodec/frame_thread_encoder.c | 9 + > >

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-07 Thread Clément Bœsch
On Mon, Dec 07, 2015 at 08:26:40AM -0500, Ganesh Ajjanagadde wrote: > On Sun, Dec 6, 2015 at 8:28 AM, Ganesh Ajjanagadde <gajja...@mit.edu> wrote: > > On Sat, Dec 5, 2015 at 6:40 AM, Clément Bœsch <u...@pkh.me> wrote: > >> On Fri, Dec 04, 2015 at 05:56:12PM -

Re: [FFmpeg-devel] [PATCH] avcodec: avutil: use avutil/thread.h instead of redundant conditional includes

2015-12-07 Thread Clément Bœsch
On Mon, Dec 07, 2015 at 03:12:19PM +0100, Clément Bœsch wrote: [...] Applied -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: avutil: use avutil/thread.h instead of redundant conditional includes

2015-12-07 Thread Clément Bœsch
On Mon, Dec 07, 2015 at 10:53:58AM -0500, Ganesh Ajjanagadde wrote: > On Mon, Dec 7, 2015 at 10:25 AM, Clément Bœsch <u...@pkh.me> wrote: > > On Mon, Dec 07, 2015 at 10:22:10AM -0500, Ronald S. Bultje wrote: > >> Hi, > >> > >> On Mon, Dec 7, 2015 at 1

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-07 Thread Clément Bœsch
On Sun, Dec 06, 2015 at 12:20:28PM +0100, Nicolas George wrote: [...] > > +static void free_func_wrap(void *arg, void *msg, int size) > > +{ > > +void (*free_func)(void *msg) = arg; > > Technically, this is not legal: void* is a data pointer, it could be smaller > than a function pointer

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-07 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 03:57:31PM +0100, Clément Bœsch wrote: > From: Clément Bœsch <clem...@stupeflix.com> > > Fix a dead lock under certain conditions. Let's assume we have a queue of 1 > message max, 2 senders, and 1 receiver. [...] Pushed with commit message adjus

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-07 Thread Clément Bœsch
On Mon, Dec 07, 2015 at 11:35:34AM +0100, Clément Bœsch wrote: > On Sun, Dec 06, 2015 at 12:20:28PM +0100, Nicolas George wrote: > [...] > > > +static void free_func_wrap(void *arg, void *msg, int size) > > > +{ > > > +void (*free_func)(void *msg) = arg; > &

Re: [FFmpeg-devel] [PATCH 2/3] fate/api: test threadmessage

2015-12-07 Thread Clément Bœsch
On Sun, Dec 06, 2015 at 12:38:09PM +0100, Nicolas George wrote: [...] > > +/* same as worker_data but shuffled for testing purpose */ > > Is it really useful? If you merge both, you can probably get rid of the > macros below with just a conditional for the function on pthread_create(). > I

Re: [FFmpeg-devel] [PATCH] diracdec: Move strides to bytes, and pointer types to uint8_t.

2015-12-06 Thread Clément Bœsch
On Sun, Dec 06, 2015 at 12:36:24PM +, Kieran Kunhya wrote: > Start templating functions for move to support 10-bit > Parts of this patch were written by Rostislav Pehlivanov "Signed-off-by:"? [...] -- Clément B. signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-05 Thread Clément Bœsch
On Sat, Dec 05, 2015 at 01:19:16PM +0100, Nicolas George wrote: > Le quintidi 15 frimaire, an CCXXIV, Clement Boesch a écrit : > > ping, I'd like to apply this fix soon > > I have already answered: > > http://ffmpeg.org/pipermail/ffmpeg-devel/2015-December/184285.html > This was before

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

2015-12-05 Thread Clément Bœsch
On Sat, Dec 05, 2015 at 06:38:47PM +0100, Paul B Mahol wrote: [...] > +{ "input", "set input projection", OFFSET(in), AV_OPT_TYPE_INT, > {.i64=SPHERE}, 0, NB_PROJECTIONS-1, FLAGS, "in" }, > +{ "s", "spheric", 0, AV_OPT_TYPE_CONST, > {.i64=SPHERE}, 0,

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

2015-12-05 Thread Clément Bœsch
On Sat, Dec 05, 2015 at 01:20:40PM -0500, Ganesh Ajjanagadde wrote: [...] > >> + > >> +AVFilterFormats *fmts_list = ff_make_format_list(pix_fmts); > >> +if (!fmts_list) > >> +return AVERROR(ENOMEM); > >> +return ff_set_common_formats(ctx, fmts_list); > > still leaky - when

Re: [FFmpeg-devel] [PATCH 2/2] avfilter: add sidechaingate filter

2015-12-05 Thread Clément Bœsch
On Sat, Dec 05, 2015 at 06:20:29AM +, Paul B Mahol wrote: [...] > Yes, it was and still is wasted time, to find out that there is no > leaking at all. There is an allocation, so it could fail under certain context/system conditions. There is also branching in that code assuming it could fail,

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-05 Thread Clément Bœsch
On Fri, Dec 04, 2015 at 05:56:12PM -0500, Ganesh Ajjanagadde wrote: > On Fri, Dec 4, 2015 at 5:29 PM, Marton Balint wrote: > if ((ret = ff_formats_ref(in , >inputs[0]->out_formats)) < 0 > || > (ret = ff_formats_ref(out, >outputs[0]->in_formats)) < 0) >

Re: [FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-05 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 03:57:31PM +0100, Clément Bœsch wrote: [...] > This second solution replaces the condition with two: one to notify the > senders, and one to notify the receivers. This prevents senders from > notifying other senders instead of a reader, and the other way around.

Re: [FFmpeg-devel] [PATCH] avfilter/codecview/WIP: add QP support

2015-12-05 Thread Clément Bœsch
On Sat, Dec 05, 2015 at 03:52:42AM +0100, Michael Niedermayer wrote: > On Fri, Dec 04, 2015 at 05:06:34PM +0100, Clément Bœsch wrote: > > On Mon, Aug 31, 2015 at 04:43:15PM +0200, Michael Niedermayer wrote: > > > On Mon, Aug 31, 2015 at 03:29:03PM +0200, Clément Bœsch wrote: >

Re: [FFmpeg-devel] [PATCH] avfilter/codecview/WIP: add QP support

2015-12-04 Thread Clément Bœsch
On Mon, Aug 31, 2015 at 04:43:15PM +0200, Michael Niedermayer wrote: > On Mon, Aug 31, 2015 at 03:29:03PM +0200, Clément Bœsch wrote: > > From: Clément Bœsch <clem...@stupeflix.com> > > > > --- > > I'm not sure I'm doing the correct thing here, but maybe that's

Re: [FFmpeg-devel] [PATCH 6/8] avfilter/show_palette: fix memory leak

2015-12-04 Thread Clément Bœsch
On Fri, Dec 04, 2015 at 09:39:41AM -0500, Ganesh Ajjanagadde wrote: > Recent commits 6aaac24d72a7da631173209841a3944fcb4a3309 and > 3835554bf8ed78539a3492c239f979c0ab03a15f made progress towards cleaning > up usage of the formats API, and in particular fixed possible NULL pointer > dereferences. >

Re: [FFmpeg-devel] use AV_OPT_TYPE_BOOL in most places

2015-12-04 Thread Clément Bœsch
On Sat, Nov 21, 2015 at 10:17:49PM +0100, Clément Bœsch wrote: [...] Patchset applied -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-04 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- libavutil/threadmessage.c | 31 +++ libavutil/threadmessage.h | 16 2 files changed, 47 insertions(+) diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c index b7fcbe2..a5f1507

Re: [FFmpeg-devel] [PATCH] avcodec/mpegvideo: use constants for rc_strategy

2015-12-04 Thread Clément Bœsch
On Mon, Nov 23, 2015 at 01:37:00PM +0100, Michael Niedermayer wrote: > On Mon, Nov 23, 2015 at 11:06:14AM +0100, Clément Bœsch wrote: > > On Sat, Nov 21, 2015 at 10:26:17PM +0100, Michael Niedermayer wrote: > > > On Sat, Nov 21, 2015 at 09:28:31PM +0100, C

Re: [FFmpeg-devel] [PATCH] ffmpeg: enable echoing with command and debug modes

2015-12-04 Thread Clément Bœsch
On Fri, Nov 20, 2015 at 03:35:35AM +0100, Michael Niedermayer wrote: > On Thu, Nov 19, 2015 at 11:23:38PM +0100, Clément Bœsch wrote: > > On Thu, Nov 19, 2015 at 11:16:46PM +0100, Michael Niedermayer wrote: > > > On Thu, Nov 19, 2015 at 10:54:45PM +0100, Clément Bœsch wrote: &g

Re: [FFmpeg-devel] [PATCH] ass_split: fix handling of streams with no [Events] or Format: line

2015-12-04 Thread Clément Bœsch
Wasn't at least the lack for "Format:" line handled by 3e86ead3 or did I forget something? -- Clément B. signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/pgssubdec: Fix left shift of 255 by 24 places cannot be represented in type int

2015-12-04 Thread Clément Bœsch
On Fri, Dec 04, 2015 at 10:30:23PM +0100, Michael Niedermayer wrote: > ffmpeg | branch: master | Michael Niedermayer | Fri > Dec 4 21:38:12 2015 +0100| [4f2419888ba49245761f4ab343679c38e7880cfe] | > committer: Michael Niedermayer > > avcodec/pgssubdec: Fix left shift

Re: [FFmpeg-devel] avutil/crc: avoid needless space wastage of hardcoded crc table

2015-12-03 Thread Clément Bœsch
On Thu, Dec 03, 2015 at 10:08:50AM +0100, wm4 wrote: > On Thu, 3 Dec 2015 09:17:22 +0100 > Nicolas George wrote: > > > Le tridi 13 frimaire, an CCXXIV, wm4 a écrit : > > > You could just append them to the end, like all new constants. > > > > That does not prevent ABI

[FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- libavutil/threadmessage.c | 37 ++--- libavutil/threadmessage.h | 21 ++--- 2 files changed, 52 insertions(+), 6 deletions(-) diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c

[FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> Fix a dead lock under certain conditions. Let's assume we have a queue of 1 message max, 2 senders, and 1 receiver. Scenario (real record obtained with debug added): [...] SENDER #0: acquired lock SENDER #0: queue is full, wait

[FFmpeg-devel] threadmessage improvements v2

2015-12-02 Thread Clément Bœsch
Improvements & changes regarding last iteration: [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush() - the flushing function can be set through a dedicated function instead of a new constructor prototype - the flush function is now fixed regarding messages larger than a pointer...

[FFmpeg-devel] threadmessage improvements v2.1

2015-12-02 Thread Clément Bœsch
sorry wrong patchset. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- libavutil/threadmessage.c | 32 libavutil/threadmessage.h | 12 2 files changed, 44 insertions(+) diff --git a/libavutil/threadmessage.c b/libavutil/threadmessage.c index b7fcbe2..66b5fc6

[FFmpeg-devel] (no subject)

2015-12-02 Thread Clément Bœsch
___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 03:13:33PM +0100, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXIV, Clement Boesch a écrit : > > because concurrent read/write accesses on the fifo needs to be locked? > > No, of course not. I was talking about the fifo itself, not the threadmessage API. > > > I

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 05:09:23PM +0100, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXIV, Clement Boesch a écrit : > > What would be the difference? both av_fifo_generic_peek and > > av_fifo_generic_peek_at require a copy of the element in a destination > > buffer, unless I'm missing

[FFmpeg-devel] [PATCH 2/3] fate/api: test threadmessage

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- tests/api/Makefile | 1 + tests/api/api-threadmessage-test.c | 263 + tests/fate/api.mak | 6 + 3 files changed, 270 insertions(+) create mode 100644 tests/a

[FFmpeg-devel] [PATCH 2/3] fate/api: test threadmessage

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> --- tests/api/Makefile | 1 + tests/api/api-threadmessage-test.c | 202 + tests/fate/api.mak | 6 ++ 3 files changed, 209 insertions(+) create mode 100644 tests/a

[FFmpeg-devel] (no subject)

2015-12-02 Thread Clément Bœsch
GIT: [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush() GIT: [PATCH 2/3] fate/api: test threadmessage GIT: [PATCH 3/3] avutil/threadmessage: fix condition broadcasting ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 3/3] avutil/threadmessage: fix condition broadcasting

2015-12-02 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> Fix a dead lock under certain conditions. Let's assume we have a queue of 1 message max, 2 senders, and 1 receiver. Scenario (real record obtained with debug added): [...] SENDER #0: acquired lock SENDER #0: queue is full, wait

Re: [FFmpeg-devel] AAC experimental flag: the sequel

2015-12-02 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 12:37:00PM -0300, Claudio Freire wrote: > So, here comes the discussion again. > > This time, the AAC encoder is in good shape. It's not perfect. I have > a list of known bugs to address that still has some issues, but I'm > not really certain whether they should block the

Re: [FFmpeg-devel] threadmessage improvements v2

2015-12-02 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 04:01:40PM +0100, Nicolas George wrote: > Le duodi 12 frimaire, an CCXXIV, Clement Boesch a écrit : > > - the flushing function can be set through a dedicated function instead of a > > new constructor prototype > > If I read the patch correctly, you seem to have fumbled

Re: [FFmpeg-devel] [PATCH 1/3] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
On Wed, Dec 02, 2015 at 04:59:15PM +0100, Nicolas George wrote: [...] > > +av_fifo_generic_peek_at(mq->fifo, mq->tmp_msg, off, > > mq->elsize, NULL); > > +mq->free_func(mq->tmp_msg); > > Could this use av_fifo_generic_peek() to avoid the ugly extra allocation? > What

Re: [FFmpeg-devel] [PATCH 1/2] avutil/threadmessage: add av_thread_message_flush()

2015-12-02 Thread Clément Bœsch
On Tue, Dec 01, 2015 at 06:49:29PM +0100, Nicolas George wrote: > Le primidi 11 frimaire, an CCXXIV, Clement Boesch a écrit : > > Ah. Well then the user can not do it himself since he has no way of > > acquiring the queue lock (AVThreadMessageQueue is opaque) > > Yes, but why does it matter, if

[FFmpeg-devel] [PATCH] avutil/threadmessage: fix condition broadcasting

2015-12-01 Thread Clément Bœsch
From: Clément Bœsch <clem...@stupeflix.com> Fix a dead lock under certain conditions. Let's assume we have a queue of 1 message max, 2 senders, and 1 receiver. Scenario (real record obtained with debug added): [...] SENDER #0: acquired lock SENDER #0: queue is full, wait

<    3   4   5   6   7   8   9   10   11   12   >