Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-17 Thread Derek Buitenhuis
On 5/17/2024 2:49 PM, Michael Niedermayer wrote: > Also we need more cute girls on these events, everything i hear > its 100% male geeks/hackers. This is gross and sexist. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/

Re: [FFmpeg-devel] [RFC] STF 2025

2024-05-17 Thread Derek Buitenhuis
On 5/17/2024 7:50 PM, Michael Niedermayer wrote: > The people on the booth are predominantly male. Similarly ffmpeg-devel > is predominantly male. More gender diversity would be good. That I can agree with. - Derek ___ ffmpeg-devel mailing list ffmpeg-d

[FFmpeg-devel] [PATCH 0/5] Apple Spatial Metadata

2024-06-10 Thread Derek Buitenhuis
* I like the idea that the 'dadj' box sits inside a 'cmfy' box, it seems very wholesome. [1] https://developer.apple.com/av-foundation/HEVC-Stereo-Video-Profile.pdf Derek Buitenhuis (5): avutil/spherical: Add more spherical types avutil/stereo3d: Fill out stereo info

[FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types

2024-06-10 Thread Derek Buitenhuis
These originate from the Apple Vision Pro, and are documented here: https://developer.apple.com/documentation/coremedia/cmprojectiontype Signed-off-by: Derek Buitenhuis --- libavutil/spherical.c | 3 +++ libavutil/spherical.h | 16 2 files changed, 19 insertions(+) diff

[FFmpeg-devel] [PATCH 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-10 Thread Derek Buitenhuis
://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_horizontaldisparityadjustment * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis --- libavutil/stereo3d.c | 52

[FFmpeg-devel] [PATCH 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-10 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c | 8 1 file changed, 8 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 2d38e5dfdc..082cec8a64 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2544,6 +2544,14 @@ static void print_pkt_side_data

[FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-10 Thread Derek Buitenhuis
* https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye Signed-off-by: Derek Buitenhuis --- libavformat/mov.c | 279 ++ 1 file changed, 279 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 160e9626d7

[FFmpeg-devel] [PATCH 5/5] avformat/mov: Add support for reading and exporting horizontal field of view

2024-06-10 Thread Derek Buitenhuis
These boxes are created by the Apple Vision Pro and the iPhone 15+ when capture for the Vision Pro is enabled. Based off of the swift API: * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-10 Thread Derek Buitenhuis
On 6/10/2024 8:38 PM, James Almer wrote: >> +remaining = atom.size; >> +while (remaining > 0) { > > Maybe this loop should call mov_read_default, with proj and eyes added > to mov_default_parse_table[]. Although i don't know if eyes may show up > as child for other parent boxes or not. >

Re: [FFmpeg-devel] [PATCH 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-11 Thread Derek Buitenhuis
On 6/11/2024 7:09 PM, Michael Niedermayer wrote: > side_data_type=Stereo 3D > type=2D > inverted=0 > +view=packed > +primary_eye=none Hmm. This does make me think we need a better way to print 'view' and 'inverted' in FFprobe. Perhaps if type!=2D? - Derek

Re: [FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types

2024-06-14 Thread Derek Buitenhuis
On 6/11/2024 7:44 PM, James Almer wrote: > This should ideally be the enum with value 0, but until next major when > such a change can happen, it would be IMO a good idea if you set > spherical->projection to AV_SPHERICAL_RECTANGULAR in av_spherical_alloc(). I think setting it to 0 (AV_STEREO3D_

Re: [FFmpeg-devel] [PATCH 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-14 Thread Derek Buitenhuis
On 6/11/2024 7:43 PM, Derek Buitenhuis wrote: > Perhaps if type!=2D? Changed locally to this and updated the test. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vi

Re: [FFmpeg-devel] [PATCH 1/5] avutil/spherical: Add more spherical types

2024-06-17 Thread Derek Buitenhuis
On 6/14/2024 2:03 PM, Derek Buitenhuis wrote: > I think setting it to 0 (AV_STEREO3D_2D) is correct rather than this (and is > already > done), and I don't think we need to reorder. > > I had discussed this with Vittorio and it was decided that it was good to > disambi

[FFmpeg-devel] [PATCH v2 0/5] Vision Pro Spatial Data

2024-06-17 Thread Derek Buitenhuis
* All comments applied from previous review. * Renamed rectangular to more industry standard rectilinear. Derek Buitenhuis (5): avutil/spherical: Add more spherical types avutil/stereo3d: Fill out stereo info provided by Vision Pro files fftools/ffprobe: Print more Stereo 3D info from side

[FFmpeg-devel] [PATCH v2 1/5] avutil/spherical: Add more spherical types

2024-06-17 Thread Derek Buitenhuis
These originate from the Apple Vision Pro, and are documented here: https://developer.apple.com/documentation/coremedia/cmprojectiontype Signed-off-by: Derek Buitenhuis --- libavutil/spherical.c | 5 + libavutil/spherical.h | 16 libavutil/version.h | 2 +- 3 files

[FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_horizontaldisparityadjustment * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis --- libavutil/stereo3d.c | 52

[FFmpeg-devel] [PATCH v2 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-17 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c| 8 tests/ref/fate/matroska-spherical-mono | 2 ++ tests/ref/fate/matroska-spherical-mono-remux | 4 tests/ref/fate/matroska-stereo_mode | 8 tests/ref/fate/matroska-vp8-alpha

[FFmpeg-devel] [PATCH v2 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
* https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye Signed-off-by: Derek Buitenhuis --- libavformat/mov.c | 279 ++ 1 file changed, 279 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9016cd5ad0

[FFmpeg-devel] [PATCH v2 5/5] avformat/mov: Add support for reading and exporting horizontal field of view

2024-06-17 Thread Derek Buitenhuis
These boxes are created by the Apple Vision Pro and the iPhone 15+ when capture for the Vision Pro is enabled. Based off of the swift API: * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis

[FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
* https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye Signed-off-by: Derek Buitenhuis --- Only difference from v2 is s/RECTANGULAR/RECTILINEAR/. --- libavformat/mov.c | 279 ++ 1 file changed, 279 insertions(+) diff

Re: [FFmpeg-devel] [PATCH v2 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 2:41 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/mov.c | 279 ++ > 1 file changed, 279 insertions(+) Replaced by v3. - Derek ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 5:53 PM, James Almer wrote: > Maybe this should be an AVRational then. While that is probably 'more correct', it does mean that in 100% places this could be used, it'll have to be converted back to the -1 to 1 range. Is there a simple way to do that with an AVRational that doe

Re: [FFmpeg-devel] [PATCH v2 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 7:09 PM, James Almer wrote: > No, it's av_d2q(), av_q2d(), and av_rescale() as needed. Same as we do > for Mastering Display and Ambient Viewing Environment Metadata. > The reason to use AVRational is that in this specific spec the values > have a denominator of 1, but in others

[FFmpeg-devel] [PATCH v3 0/5] Vision Pro Spatial Data

2024-06-17 Thread Derek Buitenhuis
Changes since v2: * horizontal display adjustment is now a rational Derek Buitenhuis (5): avutil/spherical: Add more spherical types avutil/stereo3d: Fill out stereo info provided by Vision Pro files fftools/ffprobe: Print more Stereo 3D info from side data avformat/mov: Add support for

[FFmpeg-devel] [PATCH v3 1/5] avutil/spherical: Add more spherical types

2024-06-17 Thread Derek Buitenhuis
These originate from the Apple Vision Pro, and are documented here: https://developer.apple.com/documentation/coremedia/cmprojectiontype Signed-off-by: Derek Buitenhuis --- libavutil/spherical.c | 5 + libavutil/spherical.h | 16 libavutil/version.h | 2 +- 3 files

[FFmpeg-devel] [PATCH v3 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_horizontaldisparityadjustment * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis --- libavutil/stereo3d.c | 52

[FFmpeg-devel] [PATCH v3 3/5] fftools/ffprobe: Print more Stereo 3D info from side data

2024-06-17 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- fftools/ffprobe.c| 8 tests/ref/fate/matroska-spherical-mono | 2 ++ tests/ref/fate/matroska-spherical-mono-remux | 4 tests/ref/fate/matroska-stereo_mode | 8 tests/ref/fate/matroska-vp8-alpha

[FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
* https://developer.apple.com/documentation/videotoolbox/kvtcompressionpropertykey_heroeye Signed-off-by: Derek Buitenhuis --- libavformat/mov.c | 283 ++ 1 file changed, 283 insertions(+) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9016cd5ad0

[FFmpeg-devel] [PATCH v3 5/5] avformat/mov: Add support for reading and exporting horizontal field of view

2024-06-17 Thread Derek Buitenhuis
These boxes are created by the Apple Vision Pro and the iPhone 15+ when capture for the Vision Pro is enabled. Based off of the swift API: * https://developer.apple.com/documentation/coremedia/kcmformatdescriptionextension_horizontalfieldofview Signed-off-by: Derek Buitenhuis

Re: [FFmpeg-devel] [PATCH v3 2/5] avutil/stereo3d: Fill out stereo info provided by Vision Pro files

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 9:03 PM, James Almer wrote: > Missing APIChanges entry (no need to resend, you can just amend before > pushing). Done locally for this and previous commit. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/ma

Re: [FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 9:07 PM, James Almer wrote: > nit: { 0, 1 }. If we set it to 0, 1 here, should it be set to that in the alloc function too? It'll be 0, 0 at alloc time due to use of av_mallocz. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Add support for exporting Video Extension Usage info

2024-06-17 Thread Derek Buitenhuis
On 6/17/2024 9:33 PM, James Almer wrote: > Personally I'd say yes, but other similar lavu APIs (Mastering, Ambient > Viewing) don't seem to bother with it, so maybe just leave it as 0 > unless someone else has a strong opinion about it. I'll leave it for consistency then. - Derek __

Re: [FFmpeg-devel] [PATCH v3 0/5] Vision Pro Spatial Data

2024-06-18 Thread Derek Buitenhuis
On 6/17/2024 8:20 PM, Derek Buitenhuis wrote: > 12 files changed, 490 insertions(+), 1 deletion(-) Will push later today if there are no objections. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

[FFmpeg-devel] [PATCH] avformat/dump: Print all possible Stereo3D info

2024-06-18 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- As requested by James. --- libavformat/dump.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 059fb84522..8e8b9e1959 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -260,6 +260,15 @@ static

[FFmpeg-devel] [PATCH v2] avformat/dump: Print all possible Stereo3D info

2024-06-18 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavformat/dump.c | 11 ++- 1 file changed, 10 insertions(+), 1 deletion(-) diff --git a/libavformat/dump.c b/libavformat/dump.c index 059fb84522..61a2c6a29f 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -259,7 +259,16 @@ static void

Re: [FFmpeg-devel] [PATCH] avformat/dump: Print all possible Stereo3D info

2024-06-18 Thread Derek Buitenhuis
On 6/18/2024 7:34 PM, James Almer wrote: > nit: These three could be combined into a single av_log call. v2 sent. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-23 Thread Derek Buitenhuis
On 6/22/2024 9:11 PM, Lynne via ffmpeg-devel wrote: > The API was committed 2 days ago, so changing these fields now > is within the realms of acceptable. > --- You also had weeks to comment on 3 revisions of the set, and it would have been nice to hear about this then instead of changing it after

Re: [FFmpeg-devel] [PATCH] lavu/stereo3d: change baseline and horizontal FOV to rationals

2024-06-23 Thread Derek Buitenhuis
On 6/23/2024 12:05 PM, Derek Buitenhuis wrote: > If I sound grumpy, it's because I am... the set sat commentless. The tone was unnecessary, sorry about that. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2] lavu/stereo3d: change the horizontal FOV field to a rational

2024-06-24 Thread Derek Buitenhuis
On 6/24/2024 1:13 AM, James Almer wrote: > If Derek is also ok with this then LGTM. I do not object. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or ema

[FFmpeg-devel] [PATCH] lavf/movenc: Write 'dby1' minor brand if Dolby content is being muxed to MP4

2021-09-28 Thread Derek Buitenhuis
: Derek Buitenhuis --- The sole FATE change is just the brand being written for EAC-3. --- libavformat/movenc.c | 9 - tests/ref/fate/copy-trac3074 | 4 ++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7650ac5ed3

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Write 'dby1' minor brand if Dolby content is being muxed to MP4

2021-09-30 Thread Derek Buitenhuis
On 9/29/2021 8:30 PM, Jan Ekström wrote: > I do dislike it how outside of the DoVi pdf they don't really seem to > specify 'dby1', but the mp4 registration authority's description goes > all the way back to January 2017 with this identifier > (https://github.com/mp4ra/mp4ra.github.io/blob/a27f40265

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Write 'dby1' minor brand if Dolby content is being muxed to MP4

2021-09-30 Thread Derek Buitenhuis
On 9/30/2021 12:43 AM, Andreas Rheinhardt wrote: >> +AVDOVIDecoderConfigurationRecord *dovi = >> (AVDOVIDecoderConfigurationRecord *) >> + >> av_stream_get_side_data(st, AV_PKT_DATA_DOVI_CONF, NULL); > > If you checked for the existence

[FFmpeg-devel] [PATCH v2] lavf/movenc: Write 'dby1' minor brand if Dolby content is being muxed to MP4

2021-09-30 Thread Derek Buitenhuis
: Derek Buitenhuis --- libavformat/movenc.c | 9 - tests/ref/fate/copy-trac3074 | 4 ++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 7650ac5ed3..1a2f24c410 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH v2] lavf/movenc: Write 'dby1' minor brand if Dolby content is being muxed to MP4

2021-10-01 Thread Derek Buitenhuis
On 9/30/2021 3:51 PM, Derek Buitenhuis wrote: > This is as per: >* mp4ra: http://mp4ra.org/#/brands >* Dolby Vision muxing spec (which is public): > > https://professional.dolby.com/siteassets/content-creation/dolby-vision-for-c

[FFmpeg-devel] [PATCH] avformat/mov: Do not hard fail if bit rate calculation overflows unless in explode mode

2021-10-12 Thread Derek Buitenhuis
bit_rate is not a critical field, and we shouln't hard fail if we can't caluclate it due to a large timebase - it needlessly breaks valid files. Signed-off-by: Derek Buitenhuis --- libavformat/mov.c | 20 +++- 1 file changed, 11 insertions(+), 9 deletions(-) di

Re: [FFmpeg-devel] [PATCH] avformat/mov: Do not hard fail if bit rate calculation overflows unless in explode mode

2021-10-12 Thread Derek Buitenhuis
On 10/12/2021 3:43 PM, Michael Niedermayer wrote: > this should be using av_rescale() i think That seems unrelated to this patch - but I can send a second patch that does that, if you want. Is your intent something like this; if (sc->data_size > INT64_MAX / 8) { av_log(s, AV_LOG_WARN

Re: [FFmpeg-devel] [PATCH] libavcodec/libx264: add user data unregistered SEI encoding

2021-10-18 Thread Derek Buitenhuis
On 8/6/2021 10:16 AM, Brad Hards wrote: > MISB ST 0604 and ST 2101 require user data unregistered SEI messages > (precision timestamps and sensor identifiers) to be included. That > currently isn't supported for libx264. This patch adds support > for user data unregistered SEI messages in accordanc

Re: [FFmpeg-devel] [PATCH] avformat/mov: Do not hard fail if bit rate calculation overflows unless in explode mode

2021-10-18 Thread Derek Buitenhuis
Hi, Sorry for the slow reply. On 10/12/2021 8:18 PM, Michael Niedermayer wrote: > i was thinking of something like > st->codecpar->bit_rate = av_rescale(sc->data_size, c->time_scale * 8LL, > st->duration); > > because i thought that would fix the overflow > but i didnt look beyond the code in t

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavcodec/libx264: add user data unregistered SEI encoding

2021-10-18 Thread Derek Buitenhuis
On 10/18/2021 11:05 PM, Michael Niedermayer wrote: > This code breaks bitexact mode for some files, i have not looked into this > any deeper yet. [23:18] <@jamrial_> Daemon404: that libx264 patch conflicts with the closed caption code. it overwrites the extra_sei struct and leaks it ^ presumably

[FFmpeg-devel] [PATCH 0/2] mov: bit rate calculation fixes

2021-10-20 Thread Derek Buitenhuis
As per discussion here: https://patchwork.ffmpeg.org/project/ffmpeg/patch/20211012135040.764167-1-derek.buitenh...@gmail.com/ Derek Buitenhuis (2): avformat/mov: Use av_rescale when calculating bit rate avformat/mov: Do not hard fail if bit rate calculation overflows unless in explode

[FFmpeg-devel] [PATCH 1/2] avformat/mov: Use av_rescale when calculating bit rate

2021-10-20 Thread Derek Buitenhuis
It is less susceptible to overflows. Signed-off-by: Derek Buitenhuis --- libavformat/mov.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 57c67e3aac..431f430368 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c

[FFmpeg-devel] [PATCH 2/2 v2] avformat/mov: Do not hard fail if bit rate calculation overflows unless in explode mode

2021-10-20 Thread Derek Buitenhuis
bit_rate is not a critical field, and we shouln't hard fail if we can't caluclate it due to a large timebase - it needlessly breaks valid files. Signed-off-by: Derek Buitenhuis --- libavformat/mov.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavfo

[FFmpeg-devel] [PATCH 1/2 v2] avformat/mov: Use av_rescale when calculating bit rate

2021-10-20 Thread Derek Buitenhuis
It is less susceptible to overflows. Signed-off-by: Derek Buitenhuis --- libavformat/mov.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 57c67e3aac..841818b547 100644 --- a/libavformat/mov.c +++ b/libavformat/mov.c

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mov: Use av_rescale when calculating bit rate

2021-10-20 Thread Derek Buitenhuis
On 10/20/2021 7:30 PM, Michael Niedermayer wrote: > Does something ensure time_scale * 8 fits in int ? if not this needs a cast > to *int64_t You're right, this could break on systems with 32-bit int. v2 sent. - erek ___ ffmpeg-devel mailing list ffmp

Re: [FFmpeg-devel] [PATCH] avutil/mathematics: Document av_rescale_rnd() behavior on non int64 results

2021-10-20 Thread Derek Buitenhuis
On 10/20/2021 7:24 PM, Michael Niedermayer wrote: > * The operation is mathematically equivalent to `a * b / c`, but writing > that > * directly can overflow, and does not support different rounding methods. > + * If the result is not representable then INT64_MIN is returned. Seems reasonable

[FFmpeg-devel] [PATCH 1/3] avutil: Add Dolby Vision RPU side data type

2021-10-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- All known encoders, etc. expect RPUs in this format, to my knowledge. (There is no spec for parsing the RPUs, even privately, and not a single piece of software that would benefit from that - and it is a legal minefield which I am not going to touch.) The

[FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- * The NAL reordering approach is a result of discussions with Anton and James a few months ago. * I've put the NAL reordering in ff_h2645_packet_split, rather than a bitstream filter for a few reasons: * I don't think having a decoder's b

[FFmpeg-devel] [PATCH 3/3] fate: Add test for Dolby Vision RPU side data

2021-10-21 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- File: https://www.dropbox.com/s/tjnm3vggdc6s7v3/dv84.mov?dl=0 We generated this file ourselves with an iPhone; there is no copyright issue. --- tests/fate/hevc.mak| 3 + tests/ref/fate/hevc-dv-rpu | 512 + 2 files

[FFmpeg-devel] [PATCH 0/3] Dolby Vision RPU Side Data

2021-10-21 Thread Derek Buitenhuis
This patch set allows exporting Dolby Vision RPUs as side data, allowing them to be used in transcoding, etc. There are notes in each inividual patch. Derek Buitenhuis (3): avutil: Add Dolby Vision RPU side data type avcodec/hevcdec: Export Dolby Vision RPUs as side data fate: Add test for

Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add Dolby Vision RPU side data type

2021-10-23 Thread Derek Buitenhuis
On 10/22/2021 11:02 PM, Jan Ekström wrote: > DoVi Profile 5 and 7 rendering requires the data within these RPU > entities, AFAIK (as it contains various values to correctly configure > the custom color space). So software such as libplacebo where haasn > has made efforts towards implementing the no

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Derek Buitenhuis
On 10/23/2021 3:18 PM, James Almer wrote: > 0x7c01 is just the NAL header that signals type 62, nuh_layer_id 0 and > nuh_temporal_id 0. > > forbidden_zero_bit= 0 > nal_unit_type = 10 > nuh_layer_id = 00 > nuh_temporal_id_plus1 =001 > > So the last two checks

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Derek Buitenhuis
On 10/23/2021 7:15 PM, James Almer wrote: >> Do'h, will fix. > > That being said, would Dolby RPU NALUs like this using other values for > temporal and layer id be valid? Or can we just assume that's never > happening? They also use 63 for an EL, according to other codebases an docs. I didn't i

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Derek Buitenhuis
On 10/23/2021 7:25 PM, Jan Ekström wrote: > Since effectively D has taken over NAL unit 62 for this stuff, just > call it RPU_BUFFER or so, and take in everything NAL unit 62? Sounds OK to me if others are OK. - Derek ___ ffmpeg-devel mailing list ffmpe

[FFmpeg-devel] [PATCH][RFC] avformat/http: Add short_seek_size option

2021-10-26 Thread Derek Buitenhuis
igned-off-by: Derek Buitenhuis --- libavformat/http.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 476b9a8456..0dc1ce0f43 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -126,6 +126,7 @@ typedef struct HTTPContext {

Re: [FFmpeg-devel] [PATCH][RFC] avformat/http: Add short_seek_size option

2021-10-26 Thread Derek Buitenhuis
On 10/26/2021 4:14 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/http.c | 4 > 1 file changed, 4 insertions(+) As a further note, I'm unclear if it belongs in HTTP specifically, or should be added back as public to AVIO in general.

Re: [FFmpeg-devel] [PATCH][RFC] avformat/http: Add short_seek_size option

2021-11-01 Thread Derek Buitenhuis
On 10/26/2021 4:14 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavformat/http.c | 4 > 1 file changed, 4 insertions(+) Ping. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

[FFmpeg-devel] [PATCH 0/3 v2] Dolby Vision RPU Side Data

2021-11-01 Thread Derek Buitenhuis
v1 discussion: https://patchwork.ffmpeg.org/project/ffmpeg/list/?series=5130 All suggestions applied except the configuration record check, which can't be, because AVStream side data is not accessible in avcodec - discused on IRC with James and Jan. Derek Buitenhuis (3): avutil: Add

[FFmpeg-devel] [PATCH 1/3 v2] avutil: Add Dolby Vision RPU side data type

2021-11-01 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- doc/APIchanges | 3 +++ libavutil/frame.c | 1 + libavutil/frame.h | 7 +++ libavutil/version.h | 2 +- 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 99e185ee4e..86c7cae4bc 100644 --- a/doc

[FFmpeg-devel] [PATCH 2/3 v2] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-11-01 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavcodec/h2645_parse.c | 28 libavcodec/hevcdec.c | 29 + libavcodec/hevcdec.h | 2 ++ libavcodec/version.h | 2 +- 4 files changed, 60 insertions(+), 1 deletion(-) diff --git a

[FFmpeg-devel] [PATCH 3/3 v2] fate: Add test for Dolby Vision RPU side data

2021-11-01 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- tests/fate/hevc.mak| 3 + tests/ref/fate/hevc-dv-rpu | 512 + 2 files changed, 515 insertions(+) create mode 100644 tests/ref/fate/hevc-dv-rpu diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index

Re: [FFmpeg-devel] [PATCH 2/3 v2] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-11-09 Thread Derek Buitenhuis
On 11/6/2021 11:36 PM, Andreas Rheinhardt wrote: >> +/* >> + * Due to limitions in avcodec's current frame threading code, it cannot >> + * handle adding frame side data in any place except before the slice >> has >> + * started decoding. Since Dolby Vision RPUs (which appear as NA

[FFmpeg-devel] [PATCH v3 0/3] Dolby Vision RPU Side Data

2021-11-10 Thread Derek Buitenhuis
Only patch 2 ha`s changed, as per Andreas' review. Derek Buitenhuis (3): avutil: Add Dolby Vision RPU side data type avcodec/hevcdec: Export Dolby Vision RPUs as side data fate: Add test for Dolby Vision RPU side data doc/APIchanges | 3 + libavcodec/hevcdec.c

[FFmpeg-devel] [PATCH v3 1/3] avutil: Add Dolby Vision RPU side data type

2021-11-10 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- doc/APIchanges | 3 +++ libavutil/frame.c | 1 + libavutil/frame.h | 7 +++ libavutil/version.h | 2 +- 4 files changed, 12 insertions(+), 1 deletion(-) diff --git a/doc/APIchanges b/doc/APIchanges index 99e185ee4e..86c7cae4bc 100644 --- a/doc

[FFmpeg-devel] [PATCH v3 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-11-10 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- libavcodec/hevcdec.c | 39 +++ libavcodec/hevcdec.h | 2 ++ libavcodec/version.h | 2 +- 3 files changed, 42 insertions(+), 1 deletion(-) diff --git a/libavcodec/hevcdec.c b/libavcodec/hevcdec.c index 246ffd7d80

[FFmpeg-devel] [PATCH v3 3/3] fate: Add test for Dolby Vision RPU side data

2021-11-10 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis --- tests/fate/hevc.mak| 3 + tests/ref/fate/hevc-dv-rpu | 512 + 2 files changed, 515 insertions(+) create mode 100644 tests/ref/fate/hevc-dv-rpu diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index

Re: [FFmpeg-devel] [PATCH v3 0/3] Dolby Vision RPU Side Data

2021-11-14 Thread Derek Buitenhuis
On 11/10/2021 2:22 PM, Derek Buitenhuis wrote: > Only patch 2 ha`s changed, as per Andreas' review. > > Derek Buitenhuis (3): > avutil: Add Dolby Vision RPU side data type > avcodec/hevcdec: Export Dolby Vision RPUs as side data > fate: Add test for Dolby Vision R

Re: [FFmpeg-devel] [PATCH][RFC] avformat/http: Add short_seek_size option

2021-11-14 Thread Derek Buitenhuis
On 10/26/2021 4:14 PM, Derek Buitenhuis wrote: > In 45bfe8b838275235412777dd430206d9a24eb3ee, short_seek_threshold was removed > from the public AVIO struct. Although this option was private and not intended > to be used by public API users, it was nonetheless, because it provided > f

Re: [FFmpeg-devel] [PATCH] avformat/dhav: Limit get_duration() iterations

2021-11-15 Thread Derek Buitenhuis
On 11/15/2021 3:04 PM, Michael Niedermayer wrote: > i dont like it either > do you have a better idea ? Why is it seaching like this anyway? This is not even the only place in dhav.c it does this. Is the format documented somewhere by chance? There has to be a better early termination condition

Re: [FFmpeg-devel] [PATCH 05/15] lavc/videotoolbox: escape 0x00000[0-3]s in avcC PSs

2021-11-15 Thread Derek Buitenhuis
On 11/13/2021 9:09 PM, rcombs wrote: > --- > libavcodec/videotoolbox.c | 51 +-- > 1 file changed, 43 insertions(+), 8 deletions(-) Why reimplement NAL emulation bytes for the Nth time in the codebase? - Derek ___ ff

[FFmpeg-devel] [PATCH] avformat/http: Add short_seek_size option

2021-11-15 Thread Derek Buitenhuis
igned-off-by: Derek Buitenhuis --- Same as last version but I'm marking it as non-RFC. I think I prefer the AVOption approach. Comments welcome. --- libavformat/http.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/http.c b/libavformat/http.c index 476b9a8456..0dc1ce0

Re: [FFmpeg-devel] [PATCH] avformat/http: Add short_seek_size option

2021-11-15 Thread Derek Buitenhuis
On 11/15/2021 7:53 PM, James Almer wrote: > Don't forget to bump micro before you push. Yep. >> +{ "short_seek_size", "Threshold to favor readahead over seek.", >> OFFSET(short_seek_size), AV_OPT_TYPE_INT, { .i64 = -1 }, 1, INT64_MAX, D }, > > -1 default when the valid range is 1 to INT64_M

[FFmpeg-devel] [PATCH v2] avformat/http: Add short_seek_size option

2021-11-16 Thread Derek Buitenhuis
igned-off-by: Derek Buitenhuis --- libavformat/http.c| 4 libavformat/version.h | 2 +- 2 files changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/http.c b/libavformat/http.c index 476b9a8456..fdfbc69da1 100644 --- a/libavformat/http.c +++ b/libavformat/http.c @@ -126,6 +

Re: [FFmpeg-devel] [PATCH 05/15] lavc/videotoolbox: escape 0x00000[0-3]s in avcC PSs

2021-11-16 Thread Derek Buitenhuis
On 11/16/2021 3:30 AM, Ridley Combs wrote: > Because it was faster to write a trivial implementation than to track down an > existing one. Not a good reason... > Even now that I've found a couple, one's a static in videotoolboxenc and is > somewhat heavier than is warranted here, and one's in

Re: [FFmpeg-devel] [PATCH v2] avformat/http: Add short_seek_size option

2021-11-16 Thread Derek Buitenhuis
On 11/16/2021 2:57 PM, James Almer wrote: > Micro. > > LGTM otherwise if tested. Fixed locally. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email f

Re: [FFmpeg-devel] [PATCH v3 0/3] Dolby Vision RPU Side Data

2021-11-17 Thread Derek Buitenhuis
On 11/14/2021 2:04 PM, Derek Buitenhuis wrote: > I'll give this a few more days and then apply if there are no > other comments. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH v2] avformat/http: Add short_seek_size option

2021-11-17 Thread Derek Buitenhuis
On 11/16/2021 2:57 PM, James Almer wrote: > Micro. > > LGTM otherwise if tested. Double tested and micro bumped. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, vi

Re: [FFmpeg-devel] [PATCH 05/16] lavc/videotoolbox: escape 0x00000[0-3]s in avcC PSs

2021-11-24 Thread Derek Buitenhuis
On 11/22/2021 9:58 PM, rcombs wrote: > --- > libavcodec/videotoolbox.c | 53 +-- > 1 file changed, 45 insertions(+), 8 deletions(-) > > diff --git a/libavcodec/videotoolbox.c b/libavcodec/videotoolbox.c > index 49e726a75f..bd6e769207 100644 > --- a/libavcodec/v

Re: [FFmpeg-devel] [RFC] AG (GA?) VOTE

2023-10-10 Thread Derek Buitenhuis
On 10/10/2023 12:56 PM, Michael Niedermayer wrote: > a vote on the General Assembly composition was apparently initiated with > a duration of 6 days, i saw this in my inbox: > "1009 23:49 Jean-Baptiste K (3,4K) Poll: FFmpeg AG members rules" Without commenting on anything else, I thought it was im

Re: [FFmpeg-devel] [RFC] AG (GA?) VOTE

2023-10-10 Thread Derek Buitenhuis
On 10/10/2023 3:09 PM, James Almer wrote: > The email was sent from ffc...@gmx.de, a domain that some email > providers apparently dislike? Google at least is fine with it. I did not get it, not even in my spam. Neither did Vittorio. - Derek ___ ffmpeg

Re: [FFmpeg-devel] [ANNOUNCE] upcoming GA vote

2023-10-26 Thread Derek Buitenhuis
On 10/25/2023 2:14 PM, Thilo Borgmann via ffmpeg-devel wrote: > To test the voting beforehand this time, I created a test vote with a fake-GA > member list. All of the following people should have received a corresponding > mail. If you are part of this list, but did not receive an email, check y

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2023-11-01 Thread Derek Buitenhuis
On 11/1/2023 8:37 PM, Thilo Borgmann via ffmpeg-devel wrote: > We reiceived an anonymous corporate sponsorship for the booth, so there are > no > costs for the FFmpeg project to it (and no obligations, of course). This is certainly interesting considering we just had a giant thread about not us

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Derek Buitenhuis
Hi, I'm going to opine a bit here, and also comment on the mov/MP4 patch[0] that accompanies this set. This is for both historical purposes, and to distill IRC logs into something more digestible for others on the list to gain context on the issue, so apologies for re-treading ground. On 10/30

Re: [FFmpeg-devel] [PATCH 1/2] decode: add ff_decode_skip_samples function

2023-11-04 Thread Derek Buitenhuis
On 11/4/2023 4:22 PM, Derek Buitenhuis wrote: > the sample duration of the last packet in the stts box. Pre-roll is > store in the sgpb Bah. Please try and ignore my various typos of 'sgpd'. - Derek ___ ffmpeg-devel mailing l

[FFmpeg-devel] Fwd: Poll: Repeat vote: GA voters list updates

2023-11-12 Thread Derek Buitenhuis
This is an invalid do-over and I refuse to take part. Please enjoy my private URL. - Derek Forwarded Message Subject:Poll: Repeat vote: GA voters list updates Date: Sun, 12 Nov 2023 15:00:41 +0100 (CET) From: Thilo Borgmann (CIVS poll supervisor) Reply-To: t

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2023-11-19 Thread Derek Buitenhuis
Hi, Followup question... On 11/1/2023 9:25 PM, Derek Buitenhuis wrote: > This is certainly interesting considering we just had a giant thread about > not using > or using SPI, with multiple people accused of having corporate interests. I noticed FFmpeg is on the NAB floor plan. Thi

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2023-11-19 Thread Derek Buitenhuis
On 11/19/2023 2:05 PM, Derek Buitenhuis wrote: > So who signed? The "anonymous" corproate entity, on behalf of FFmpeg, with out > our consent? http://ffmpeg.org/pipermail/ffmpeg-devel/2023-November/317196.html Prob unrelated I a

Re: [FFmpeg-devel] FFmpeg at NAB 2024

2023-11-19 Thread Derek Buitenhuis
On 11/19/2023 2:19 PM, Derek Buitenhuis wrote: > http://ffmpeg.org/pipermail/ffmpeg-devel/2023-November/317196.html FFS. Here is the right link: http://ffmpeg.org/pipermail/ffmpeg-devel/2023-November/316603.html - Deek ___ ffmpeg-devel mailing l

Re: [FFmpeg-devel] [ANNOUNCE] Repeat vote: GA voters list updates

2023-11-20 Thread Derek Buitenhuis
On 11/20/2023 3:44 PM, Thilo Borgmann via ffmpeg-devel wrote: > the results are available at [1]. As they confirm the just updated GA list as > well as the update procedure twice a year on Jan 1st & Jul 1st, I think the > upcoming votes (extra GA members, TC/CC elections) can then proceed as > a

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC/CC elections

2023-11-28 Thread Derek Buitenhuis
On 11/28/2023 1:23 PM, Anton Khirnov wrote: > The system will assume you want to maximise the sum of weights of > selected candidates. E.g. if X is given a weight of 10 and Y and Z have > weights 8 and 6 respectively, then the voting algorithm will assume you > prefer a committee with both Y an

Re: [FFmpeg-devel] [ANNOUNCE] upcoming vote: TC/CC elections

2023-11-28 Thread Derek Buitenhuis
On 11/28/2023 2:25 PM, Paul B Mahol wrote: > Looks like average IQ dropped bellow room temperature. Direct insults are unacceptable and I have forwarded this to CC, which can hopefully look after the vote. - Derek ___ ffmpeg-devel mailing list ffmpeg-de

  1   2   3   4   5   6   7   8   9   10   >