Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/9/2017 1:00 AM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/5/2017 5:27 PM, Derek Buitenhuis wrote: > Probably OK, if FATE changes have been confirmed to be benign. Woops, replied to the wrong patch version. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 9:35 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > and ISO-IEC-14496-12 Section 10.1.1.1 and 10.1.1.3 > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 7:46 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 70 >

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 8:50 PM, Sasi Inguva wrote: > [...] Thanks for the reference, please add the section numbers alongside the QTFF doc in the commit message. > This patch sets the sgpd and sbgp atoms irrespective of whether it's > fragmented or not. So the byte addresses for some atoms will change for

Re: [FFmpeg-devel] [PATCH] lavf/movenc.c: Set sgpd and sbgp atoms to represent decoder delay for AAC.

On 8/4/2017 7:46 PM, Sasi Inguva wrote: > According to > https://developer.apple.com/library/content/documentation/QuickTime/QTFF/QTFFAppenG/QTFFAppenG.html > > Signed-off-by: Sasi Inguva > --- > libavformat/movenc.c| 70 >

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: support fmp4 single file mode

On 8/1/2017 4:57 PM, Steven Liu wrote: > add byterange mode of the hls fmp4 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 83 > +--- > 1 file changed, 53 insertions(+), 30 deletions(-) [...] > +if

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: support fmp4 single file mode

On 7/31/2017 5:03 AM, Steven Liu wrote: > add byterange mode of the hls fmp4 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 72 > > 1 file changed, 44 insertions(+), 28 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

On 7/21/2017 2:55 PM, Clément Bœsch wrote: > It's basically the same layout for every stsd sample description. Check > the other tags that extend that layout, the also have that data ref idx to > 1. I think I copied from the rtp code, but it's the same for the other as > well. This gpmd atom just

Re: [FFmpeg-devel] [PATCH 1/2] lavu/frame: add new side data type for ICC profiles

On 7/21/2017 12:55 AM, Rostislav Pehlivanov wrote: >> All this could apply to a dedicated field. Using side data only brings a >> type pruning of the actual type. Except: >> >> > Yes, it could. However I still think having it as a side data is better > since its the easiest way and that's what all

Re: [FFmpeg-devel] [PATCH] movenc: support GPMF track (gpmd) remuxing

On 7/21/2017 9:30 AM, Clément Bœsch wrote: > +avio_wb16(pb, 1); /* Data-reference index */ Why is this whole atom hardcoded (i.e. with is '1'). - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

On 7/18/2017 3:48 PM, Nicolas George wrote: > The reasons are exactly the same as the commit that it restores. I will > include that and the other comments you request once I can access my > work tree comfortably. OK. - Derek ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

On 7/18/2017 3:30 PM, Paul B Mahol wrote: > I actually like this 'design', as its more like VS one. I wasn't commenting on the code/design itself, but the commit message, or rather, lack thereof. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 6/7] lavfi/framesync2: implement activate design.

On 7/17/2017 3:19 PM, Nicolas George wrote: > Signed-off-by: Nicolas George > --- > libavfilter/framesync2.c | 166 > +++ > libavfilter/framesync2.h | 77 -- > 2 files changed, 82 insertions(+), 161 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

On 7/17/2017 3:19 PM, Nicolas George wrote: > This reverts commit 04aa09c4bcf2d5a634a35da3a3ae3fc1abe30ef8. > > The fate-ffm change is caused by field_order now being set > on the output format because the first frame arrives earlier. > The fate-mxf change is assumed to be the same. > >

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 4:33 PM, Ashish Pratap Singh wrote: > Hi, sorry for that. > I will open a pull request soon (to libvmaf) for the pkg-config file. Thanks! - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 3:15 PM, Matt Oliver wrote: > Im getting the same error. The patch had an error in it as this line is > wrong: > +vmaf_filter_deps="libvmaf" > > It should be: > +libvmaf_filter_deps="libvmaf" > > As the filter is registered as libvmaf_filter not vmaf_filter in > allfilters.cpp I've

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 2:35 PM, Ronald S. Bultje wrote: > I tested on OSX and it works fine. I'm OK with pkg-config, but since > libvmaf doesn't currently have one, we cannot rely on it. It will work fine (but link to libstdc++ unnecessarily) if you have build libvmaf as a shared library, but it will fail

Re: [FFmpeg-devel] [PATCH] Add FITS Encoder

On 7/16/2017 1:31 PM, Paras Chadha wrote: > Signed-off-by: Paras Chadha > --- > doc/general.texi | 2 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/fitsenc.c | 238 > + >

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 1:49 PM, Derek Buitenhuis wrote: > Students should learn to reply to reviews instead of sending new patches > with no changelog and having them pushed anyway. Furthermore: Missing a version bump. - Derek ___ ffmpeg-devel mailin

Re: [FFmpeg-devel] [PATCH] avfilter: add LIBVMAF filter

On 7/16/2017 1:29 PM, Ronald S. Bultje wrote: > Pushed. > > Ronald I am going to quote myself here, because it was never address, was not even replied to, and is outright incorrect on some OSes: >> +enabled libvmaf && { check_lib libvmaf "libvmaf.h" "compute_vmaf" >> -lvmaf -lstdc++

Re: [FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

On 7/14/2017 3:38 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> > --- > libavformat/webmdashenc.c | 38 ++ > 1 file changed, 30 insertions(+), 8 deletions(-) Pushing today, unless there are ob

[FFmpeg-devel] [PATCH] webmdashenc: Fix memory leak

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/webmdashenc.c | 38 ++ 1 file changed, 30 insertions(+), 8 deletions(-) diff --git a/libavformat/webmdashenc.c b/libavformat/webmdashenc.c index 550ad72e4d..1280d8a763

Re: [FFmpeg-devel] [PATCH] avformat/riff.h : remove unused function parameter "const AVCodecTag *tags" of "void ff_put_bmp_header()"

On 7/14/2017 12:12 PM, Александр Слободенюк wrote: > It was left by the history Probably OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

On 7/13/2017 3:11 PM, wm4 wrote: > We definitely use some C99 constructs in FFmpeg, but normally we don't > use stdbool.h. Yeah, but we disallow others (like VLAs), so, yeah. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avfilter: add motion filter

Quick scan / review follows. > +#include Do we allow C99 bool in FFmpeg? I thought we didn't. > +#define FORCE_INLINE __attribute__((always_inline)) > +#define RESTRICT __restrict av_restrict av_always_inline > +static inline int floorn(int n, int m) > +{ > +return n - n % m; > +} > + >

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

On 7/11/2017 8:01 PM, Kieran O Leary wrote: > Thanks for taking a look. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] movenc:adds keywords metadata

On 7/10/2017 11:04 PM, Kieran O Leary wrote: > A user mentioned in ffmpeg-user ( > http://ffmpeg.org/pipermail/ffmpeg-user/2017-July/036571.html) that they > couldn't write the 'keywords' metadata tag. I tested this patch and it > appears to add the metadata value when using MOV and MP4 as

Re: [FFmpeg-devel] [PATCH 10/12] rtspdec: Fix return error

On 7/6/2017 7:28 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> > --- > libavformat/rtspdec.c | 1 - > 1 file changed, 1 deletion(-) Pushing this today if nobody objects. - Derek ___ ff

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

On 7/7/2017 10:13 PM, James Almer wrote: > Isn't this necessary only for files with raw video? As is, this box > would be written on any mov file with a video stream. This was addressed a previous email: http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2017-July/213350.html I guess the spec

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

On 7/7/2017 4:32 PM, Derek Buitenhuis wrote: > Patch itself LGTM. Just realized, this will change a bunch of FATE tests, won't it? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 02/12] hdsenc: Add missing goto statement

On 7/6/2017 11:38 PM, Steven Liu wrote: > Maybe there have no video stream, but have audio stream, so just give > user a warning and continue? Not an expert on the HDS code, but how can you fragment audio with no min frag size set, and no video stream? - Derek

Re: [FFmpeg-devel] [PATCH] avformat: remove obsolete commented-out DEBUG define

On 7/7/2017 8:43 AM, Tobias Rapp wrote: > Signed-off-by: Tobias Rapp > --- > libavformat/avienc.c | 2 -- > libavformat/segment.c | 2 -- > 2 files changed, 4 deletions(-) LGTM. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] movenc: write clap tag

On 7/7/2017 3:20 AM, Dave Rice wrote: > Resolves https://trac.ffmpeg.org/ticket/6145 and writes a clap atom that is > coincident with the frames width and height. > > > From 23d80d0d47829fed61e817b1e7c3f6d420c9ab5c Mon Sep 17 00:00:00 2001 > From: Dave Rice > Date: Thu, 6 Jul

Re: [FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

On 7/7/2017 2:34 AM, Louis O'Bryan wrote: > That is fair. If that is a requirement / everyone else thinks the same, > then I will push on the team making the spec to have it public before I > submit a patch to FFmpeg. Cool; I'll wait for others' opinions, of course. Perfectly fine if you still

Re: [FFmpeg-devel] [RFC][PATCH] movenc: write clap tag

On 7/7/2017 2:20 AM, Dave Rice wrote: > Currently this patch writes the clap atom under this condition > "track->par->codec_id == AV_CODEC_ID_RAWVIDEO & track->mode == MODE_MOV”; > however, AV_CODEC_ID_RAWVIDEO isn’t quite what the spec asks for. Any advice > on how to write this condition for

Re: [FFmpeg-devel] [PATCH 0/1] Add new encoder for camera sensor metadata

On 7/7/2017 1:36 AM, Louis O'Bryan wrote: > I am adding a new encoder for camera sensor metadata. This is an > implementation of a not-yet-published open standard for adding camera > sensor data to mp4 containers, including the GPS, acceleration, gyro, > and camera orientation. > After this change

Re: [FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

On 7/6/2017 10:07 PM, Rostislav Pehlivanov wrote: > Just remove setting and checking the return value altogether, > ff_lpc_calc_ref_coeffs returns the order which you give it and can't error > out. Would look good to me if you did that, so feel free to push once done. OK. - Derek

Re: [FFmpeg-devel] [PATCH v3] configure: require pkg-config for libvorbis

On 7/4/2017 8:38 PM, Paul B Mahol wrote: > This one works, so OK from me. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/2 v2] mpegtsenc: Don't pass NULL to memcpy

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/mpegtsenc.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index acea2e93a6..fdfa544ee2 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegt

Re: [FFmpeg-devel] [PATCH 04/12] scpr: Added missing error check

On 7/6/2017 7:33 PM, Paul B Mahol wrote: >> +if (ret < 0) >> +return ret; > > Hmm? Seems I forgot to amend this one properly. v2 sent. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH 04/12 v2] scpr: Added missing error check

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/scpr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index f6d1e45692..37fbe7a106 100644 --- a/libavcodec/scpr.c +++ b/libavcodec/scpr.c @@ -582,6 +582,8 @@ stat

[FFmpeg-devel] [PATCH 12/12] bitstream_filter: Add missing error check

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/bitstream_filter.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/bitstream_filter.c b/libavcodec/bitstream_filter.c index e9291aba19..8599b90d4a 100644 --- a/libavcodec/bitstream_filter.c

[FFmpeg-devel] [PATCH 07/12] cngenc: Add missing error check

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/cngenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/cngenc.c b/libavcodec/cngenc.c index 302c703f72..b7207fd5f6 100644 --- a/libavcodec/cngenc.c +++ b/libavcodec/cngenc.c @@ -92,6 +92,8 @@ stat

[FFmpeg-devel] [PATCH 08/12] hlsenc: Add missing error check

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/hlsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index dd6a62b13c..b3b52da369 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -602,6

[FFmpeg-devel] [PATCH 10/12] rtspdec: Fix return error

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/rtspdec.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/rtspdec.c b/libavformat/rtspdec.c index 0cb8f53a4c..fdf75a0979 100644 --- a/libavformat/rtspdec.c +++ b/libavformat/rtspdec.c @@ -498,7

[FFmpeg-devel] [PATCH 06/12] ffmpeg_opt: Make get_timecode actually return errors

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- ffmpeg_opt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index 9b7e8c74b9..989391bb34 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -3072,7 +3072,7 @@ static int opt_ti

[FFmpeg-devel] [PATCH 05/12] opusdec: Remove dead code

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/opusdec.c | 9 + 1 file changed, 1 insertion(+), 8 deletions(-) diff --git a/libavcodec/opusdec.c b/libavcodec/opusdec.c index 1110302f9c..5a7ba9dbb4 100644 --- a/libavcodec/opusdec.c +++ b/libavcodec/opu

[FFmpeg-devel] [PATCH 09/12] rtmpproto: Fix error return

Mistake was added in 5840473890440dbe0bd2cce530ebb3d93e187ae6. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/rtmpproto.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/rtmpproto.c b/libavformat/rtmpproto.c index ae55

[FFmpeg-devel] [PATCH 04/12] scpr: Added missing error check

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/scpr.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index f6d1e45692..29ee70d521 100644 --- a/libavcodec/scpr.c +++ b/libavcodec/scpr.c @@ -311,6 +311,8 @@ stat

[FFmpeg-devel] [PATCH 03/12] af_tempo: Add missing error check

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavfilter/af_atempo.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavfilter/af_atempo.c b/libavfilter/af_atempo.c index 76410221d6..944df1dd32 100644 --- a/libavfilter/af_atempo.c +++ b/libavfilter/af_at

[FFmpeg-devel] [PATCH 02/12] hdsenc: Add missing goto statement

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/hdsenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/hdsenc.c b/libavformat/hdsenc.c index 347df83a51..c362a75d8b 100644 --- a/libavformat/hdsenc.c +++ b/libavformat/hdsenc.c @@ -421,6

[FFmpeg-devel] [PATCH 01/12] bitpacked: Remove dead store

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/bitpacked.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/bitpacked.c b/libavcodec/bitpacked.c index 12174d6007..f0b417d595 100644 --- a/libavcodec/bitpacked.c +++ b/libavcodec/bitpacked.c @@

[FFmpeg-devel] [PATCH 00/12] Dead code and missing checks

FATE passes. Derek Buitenhuis (12): bitpacked: Remove dead store hdsenc: Add missing goto statement af_tempo: Add missing error check scpr: Added missing error check opusdec: Remove dead code ffmpeg_opt: Make get_timecode actually return errors cngenc: Add missing error check

[FFmpeg-devel] [PATCH 2/2] mpegtsenc: Don't pass NULL to memcpy

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/mpegtsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/mpegtsenc.c b/libavformat/mpegtsenc.c index acea2e93a6..f62ed55dea 100644 --- a/libavformat/mpegtsenc.c +++ b/libavformat/mpegt

[FFmpeg-devel] [PATCH 1/2] concatdec: Do not pass NULL to memcmp

Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/concatdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/concatdec.c b/libavformat/concatdec.c index e57e5ce0ec..e8b37d6a08 100644 --- a/libavformat/concatdec.c +++ b/libav

[FFmpeg-devel] [PATCH 0/2] Needlessly (?) Anal C Spec Adherence Fixe

on such a call shall still have valid values, as described in 7.1.4. Derek Buitenhuis (2): concatdec: Do not pass NULL to memcmp mpegtsenc: Don't pass NULL to memcpy libavformat/concatdec.c | 2 +- libavformat/mpegtsenc.c | 2 ++ 2 files changed, 3 insertions(+), 1 deletion

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add warning message when use fmp4 and byte range mode

On 7/6/2017 3:55 AM, Steven Liu wrote: > +if (hls->segment_type == SEGMENT_TYPE_FMP4 && byterange_mode) { > +av_log(s, AV_LOG_WARNING, "Have not support fmp4 byterange mode yet > now, patch " > + "welcome or wait to support it, change the hls_segment_type > to mpegts

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

On 7/5/2017 4:01 PM, Derek Buitenhuis wrote: > Going to push the last four today, unless someone objects. Pushed. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

On 7/5/2017 5:36 PM, wm4 wrote: > These pkg-config flag additions in the Ubuntu instructions are pretty > unusual. Passing --static to pkg-config is the de-facto way to build FFmpeg with static libraries. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] avfomat/hlsenc: support fmp4 format in hls

On 7/3/2017 1:22 PM, Steven Liu wrote: > Pushed! Seems this patch has unexpected behavior when 'hls_segment_type=fmp4' and 'hls_flags=single_file'. It should probably create a self indexed file (sidx boxes at the start) and a byte range m3u8, no? At the very least it should fail or warn the

Re: [FFmpeg-devel] [PATCH v12] - Added Turing codec interface for ffmpeg

On 7/5/2017 3:56 PM, Saverio Blasi wrote: > RUN cmake -DCMAKE_INSTALL_PREFIX="/source/ffmpeg/ffmpeg_build" .. && \ > make && \ > make install > WORKDIR /source/ffmpeg > COPY 0001-Added-Turing-codec-interface-for-ffmpeg.patch /source/ffmpeg > RUN git apply

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

On 6/28/2017 4:41 PM, Derek Buitenhuis wrote: > Apple software and devices requrie hvc1. This patchset was originally > sent to Libav for this same purpose. > > John Stebbins (5): > movenc: use correct tag list for AVOutputFormat.codec_tag > movenc: simplify codec_tag looku

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

On 7/5/2017 12:15 AM, Hendrik Leppkes wrote: > The patch seems fine to me, mid-stream extradata should be populated > to avctx when its used by a frame, not when its parsed. > The export during parsing should only be done on codec open so initial > values are populated to the context right away.

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

On 7/4/2017 11:09 PM, Michael Niedermayer wrote: > do you have some testcases that you are concerned about ? > can you add them to fate ? I can make some and test tomorrow morning if you're fine with waiting half a day. - Derek ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: do not let updated extradata corrupt state

On 7/4/2017 9:33 PM, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: 2451/clusterfuzz-testcase-minimized-4781613957251072 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > Signed-off-by: Michael Niedermayer

Re: [FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

On 7/4/2017 4:58 PM, Derek Buitenhuis wrote: > I guess 'unchanged output' is as good of a result as any, for now... Pushed patches 0.5 and 1. Any comments on the other four? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

On 7/4/2017 4:52 PM, James Almer wrote: > According to mp4ra.org, DTS core should have a dtsc codec tag. The rest > are for the extensions. A quick test changing mp4a to dtsc on top of > your patchset resulted in a wildly different output file, among other > reasons because the esds box isn't

Re: [FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

On 7/4/2017 4:31 PM, Hendrik Leppkes wrote: > "dtsc" appears to be the base DTS codec, according to > http://www.mp4ra.org/codecs.html > "mp4a" only applies to codecs defined in the official MP4 specification. Oh, I missed that. Still not sure if we need to handle the extra layered stuff inside

Re: [FFmpeg-devel] [PATCH] avfilter: add VMAF filter

On 7/3/2017 5:38 PM, Ashish Singh wrote: > +enabled libvmaf && { check_lib libvmaf "libvmaf.h" "compute_vmaf" > -lvmaf -lstdc++ -lpthread -lm || > + die "ERROR: libvmaf must be installed"; } This won't work on, for example, OS X, which uses libc++ instead

Re: [FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

On 7/3/2017 3:00 AM, James Almer wrote: > Doesn't DTS have a bunch of unique tags? The ones listed in > ff_codec_movaudio_tags and http://www.mp4ra.org/codecs.html It looks like those only cover DTS extensions, which we all mark s AV_CODEC_ID_DTS. Is the DTS base layer 'mp4a'? I don't have a

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

On 7/4/2017 9:19 AM, Moritz Barsnick wrote: > A user confirms that this patchset helps them play ffmpeg created HEVC > videos in (a newer) Mac OS X's QT Player: > http://ffmpeg.org/pipermail/ffmpeg-user/2017-July/036527.html Great. Will send new version of patch 1 today. - Derek

Re: [FFmpeg-devel] [PATCH 2/5] movenc: simplify codec_tag lookup

On 7/3/2017 2:18 AM, Michael Niedermayer wrote: > breaks fate I'll look into it tonight; busy today. . . . Aside: I'll just add, though, that these two word 'breaks fate' emails are kind of obnoxious when the test in question was added days after I sent the set, so I couldn't have possibly

Re: [FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

On 7/3/2017 3:00 AM, James Almer wrote: >> +{ AV_CODEC_ID_EAC3, MKTAG('a', 'c', '-', '3') }, > Should be ec-3. Changing it fixes fate-copy-trac3074 as pointed by > Michael in a reply to patch 2/5. OK, this was my bug; Libav does't have that entry at all. > >> +{ AV_CODEC_ID_DTS

Re: [FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

On 6/28/2017 4:41 PM, Derek Buitenhuis wrote: > Apple software and devices requrie hvc1. This patchset was originally > sent to Libav for this same purpose. > > John Stebbins (5): > movenc: use correct tag list for AVOutputFormat.codec_tag > movenc: simplify codec_tag looku

[FFmpeg-devel] [PATCH 0.5/5] lavf: Remove codec_tag from dashend and smoothstreamingenc

From: Martin Storsjö <mar...@martin.st> Skip the codec_tag altogether here, to let the user (try to) set whichever codec/tag he wants; the individual chained muxer will reject invalid codecs anyway. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavform

Re: [FFmpeg-devel] [PATCH] Revert "avcodec/alsdec: check predictor order against block length"

On 6/30/2017 4:58 PM, Paul B Mahol wrote: > Thanks, but I do not see important variables. There are line numbers and dates, though, pointing at: 931:*raw_samples++ -= y >> 20; Better than nothing. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Revert "avcodec/alsdec: check predictor order against block length"

On 6/30/2017 4:44 PM, Thilo Borgmann wrote: > Yes but I cannot share, unfortunately. There are two backtraces in the mail thread from before that could be helpful. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Revert "avcodec/alsdec: check predictor order against block length"

On 6/30/2017 4:31 PM, Paul B Mahol wrote: > This reverts commit 18f94df8af04f2c02a25a7dec512289feff6517f. > > Signed-off-by: Paul B Mahol > --- > libavcodec/alsdec.c | 6 +- http://ffmpeg.org/pipermail/ffmpeg-devel/2016-November/202513.html - Derek

Re: [FFmpeg-devel] [PATCH 1/5 v3] movenc: use correct tag list for AVOutputFormat.codec_tag

On 6/29/2017 10:31 PM, James Almer wrote: >> dashenc is also using ff_mp4_obj_type. Guess it should be a matter of >> changing that as well. It would require making the new codec_mp4_tags[] >> shared in isom.c > For the record, this also affects libav. dashenc is currently broken > there because

Re: [FFmpeg-devel] [PATCH v11] - Added Turing codec interface for ffmpeg

On 6/29/2017 9:09 PM, wm4 wrote: > On Thu, 29 Jun 2017 20:45:10 +0100 > Derek Buitenhuis <derek.buitenh...@gmail.com> wrote: > >> Keep in mind that C99 bool and C++ >> bool are not compatible. >>

Re: [FFmpeg-devel] [PATCH 3/3] avformat: add SMPTE 337M demuxer

On 6/27/2017 10:59 AM, foo86 wrote: > +static int s337m_get_offset_and_codec(AVFormatContext *s, > + uint64_t state, > + int data_type, int data_size, > + int *offset, int *codec) NIT:

Re: [FFmpeg-devel] [PATCH v11] - Added Turing codec interface for ffmpeg

On 6/29/2017 3:06 PM, Saverio Blasi wrote: > --- > LICENSE.md | 1 + > configure | 6 + > libavcodec/Makefile| 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/libturing.c | 313 > + > 5 files changed, 322

[FFmpeg-devel] [PATCH 1/5 v3] movenc: use correct tag list for AVOutputFormat.codec_tag

upport same list of codecs found in ff_mp4_obj_type. psp uses the same tag list as mp4 since these both use mp4_get_codec_tag to look up tags. (cherry picked from commit 713efb2c0d013a42be4051adb7cd90a7c2cbbb4f) Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- Wit

Re: [FFmpeg-devel] [PATCH 1/5 v2] movenc: use correct tag list for AVOutputFormat.codec_tag

On 6/29/2017 7:51 AM, Paul B Mahol wrote: > EVRC is audio codec. Shouldn't be mp4a. Yes. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/5 v2] movenc: use correct tag list for AVOutputFormat.codec_tag

upport same list of codecs found in ff_mp4_obj_type. psp uses the same tag list as mp4 since these both use mp4_get_codec_tag to look up tags. (cherry picked from commit 713efb2c0d013a42be4051adb7cd90a7c2cbbb4f) Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/m

Re: [FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

On 6/29/2017 2:03 AM, Michael Niedermayer wrote: > Fails to build > > src/libavformat/movenc.c:6450:7: error: ‘AV_CODEC_ID_EVR’ undeclared here > (not in a function) > { AV_CODEC_ID_EVR , MKTAG('m', 'p', '4', 'v') }, Looks like I forgot to regenerate the .patch files after I fixed

[FFmpeg-devel] [PATCH 3/5] movenc: move tags definitions to where they are used

From: John Stebbins <stebb...@jetheaddev.com> (cherry picked from commit 1c64bae648eeb39c8d8a8d81ee142b9eec9fae7b) Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/movenc.c | 62 ++-- 1 file changed, 31 inser

[FFmpeg-devel] [PATCH 5/5] movenc: allow alternative hvc1 h.265 codec tag

From: John Stebbins <stebb...@jetheaddev.com> If AVCodecParameters.codec_tag is 'hvc1' use it instead of 'hev1' for h.265 streams. QuickTime (and other Apple software) requires 'hvc1'. (cherry picked from commit 84ab1cc437fa47a00532f305b9fe15b5b66c8c5e) Signed-off-by: Derek Buit

[FFmpeg-devel] [PATCH 4/5] movenc: write correct format hvcc when tag is hvc1

From: John Stebbins <stebb...@jetheaddev.com> (cherry picked from commit 1ea9b7fdf99b60c0db95a2ce97b2108469bbb245) Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/movenc.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavforma

[FFmpeg-devel] [PATCH 2/5] movenc: simplify codec_tag lookup

ed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/movenc.c | 68 1 file changed, 15 insertions(+), 53 deletions(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index 2a07e00..3ca23de 100644 --- a/libavformat/mo

[FFmpeg-devel] [PATCH 0/5] hvc1 Support Cherry-Picks

Apple software and devices requrie hvc1. This patchset was originally sent to Libav for this same purpose. John Stebbins (5): movenc: use correct tag list for AVOutputFormat.codec_tag movenc: simplify codec_tag lookup movenc: move tags definitions to where they are used movenc: write

[FFmpeg-devel] [PATCH 1/5] movenc: use correct tag list for AVOutputFormat.codec_tag

upport same list of codecs found in ff_mp4_obj_type. psp uses the same tag list as mp4 since these both use mp4_get_codec_tag to look up tags. (cherry picked from commit 713efb2c0d013a42be4051adb7cd90a7c2cbbb4f) Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/m

Re: [FFmpeg-devel] [PATCH 2/3] avcodec: add Dolby E decoder

On 6/27/2017 10:59 AM, foo86 wrote: > +init_tables(); This should be run under ff_thread_once() and thread-safe init flag added to the internal caps. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

On 4/23/2017 4:28 PM, wm4 wrote: > Possibly you could CC the original author if you want to have more eyes > on it. I CC'd him on the other patch already, but I'll loop him in here. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix UB in cue timestamp string code and make it actually work

On 4/20/2017 3:02 PM, Derek Buitenhuis wrote: > --- > libavformat/matroskadec.c | 14 +++--- > 1 file changed, 11 insertions(+), 3 deletions(-) Ping. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.or

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix initialization range for files with cues at the front

On 4/21/2017 4:40 PM, Derek Buitenhuis wrote: > The WebM DASH spec states: > The Initialization Segment shall not contain Clusters or Cues. > The Segment Index corresponds to the Cues. > > Previously, it included the cues if they were at the front. > > Signed-off

[FFmpeg-devel] [PATCH] webm_dash_manifest_demuxer: Fix initialization range for files with cues at the front

The WebM DASH spec states: The Initialization Segment shall not contain Clusters or Cues. The Segment Index corresponds to the Cues. Previously, it included the cues if they were at the front. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/matrosk

Re: [FFmpeg-devel] [PATCH 1/2] webmdashenc: Require the 'adaptation_sets' option to be ste

On 4/20/2017 4:58 PM, James Almer wrote: > EINVAL IMO, since it's an user option. AVERROR_INVALIDDATA was defined as AVERROR(EINVAL) for years, I guess I forgot it changed to something else... git blame puts it at 72af5d8a020e4dca1118b3ede67be983b33e27c5 in 2010... My memory was seriously

[FFmpeg-devel] [PATCH 2/2 v2] webmdashenc: Validate the 'streams' adaptation sets parameter

It should not be a value larger than the number of streams we have, or it will cause invalid reads and/or SIGSEGV. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/webmdashenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libav

<    5   6   7   8   9   10   11   12   13   14   >