Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 6:52 PM, Michael Niedermayer wrote: When and where ? Example: http://thread.gmane.org/gmane.comp.video.ffmpeg.devel/179883 And also *constantly* on IRC, although I am sure IRC doesn't count or somesuch. My argument then is the same as now: this does not belong in libav*. It

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 9:15 PM, Mariusz Szczepańczyk wrote: Thank you for clarification. I understand there are people who are not happy with additions like this. However, there are also people who think these changes are needed and trying to stop them just because we don't want this here or worse,

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 11:58 PM, Mariusz Szczepańczyk wrote: I don't think it's fair to say Lukasz is the only one standing for these changes. But let's not make it personal and hold on any grudges for a moment. I hold no ill will against anyone, as long as no ill will is held against me. I do,

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 10:24 PM, Derek Buitenhuis wrote: You may also recall I brought up the fact that the GSOC qualification task was mostly reworking the patch set from Lukasz, and thinking that was a bit sketchy. I went and looked. It wad *directly* brought up by Keiran on ffmpeg-mentors. He

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/23/2015 12:46 AM, Reynaldo H. Verdejo Pinochet wrote: Not really getting into the whole discussion on blocking remarks to a running (sponsored) project. I sincerely hope we all agree that once work has started on these, we should try to be constructive and let the student do their job

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 11:18 PM, Michael Niedermayer wrote: Please stop the finger pointing and work toward a resolution of this its not just one man, iam not even sure he intended to use it himself. I agree I was a too aggressive. However, I am not aware of a single person. As for working towards a

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 10:31 PM, Derek Buitenhuis wrote: That is not on you though, and I apologize for dragging your GSOC application into it. To follow up on this, I do understand how GSOC works, and it is too late to say 'no' to this, and I feel bad for you having negatives dumped on you like this. I

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: Extend API with avio_move() and avio_delete()

2015-06-22 Thread Derek Buitenhuis
On 6/21/2015 8:04 PM, Mariusz Szczepańczyk wrote: Anyway, this is a part of my GSoC task that has been accepted and I'm compelled to implement it so I won't be getting into further discussion. Let's just say a large portion of the community didn't and don't think this idea has any place in

Re: [FFmpeg-devel] [PATCH] libavformat: Add H264 API test

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 10:50 AM, Ludmila Glinskih wrote: +#include libavformat/internal.h What is this for? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] libavformat: Add H264 API test

2015-06-22 Thread Derek Buitenhuis
On 6/22/2015 1:32 PM, Vittorio Giovara wrote: video_decode_example can return -1 on error, and this is lost, so you'd better do return video_decode_example(argv[1]); to return the value to the caller. Also sometimes you exit(1) and sometimes you return -1, maybe you could go with only one of

Re: [FFmpeg-devel] [PATCH]asfdec: Reduce minimum header size (was: New asf demuxer)

2015-06-29 Thread Derek Buitenhuis
On 6/29/2015 11:01 AM, Hendrik Leppkes wrote: Just on code quality alone, I think it would be much more productive if you look for the opposite and fix those. Trying to juke the stats after-the-fact by fixing the old one now is not going to change anything. :p But then how can he hate on

[FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Derek Buitenhuis
Currently, when forcing an I frame, via API, or via the ffmpeg cli, using -force_key_frames, we still let x264 decide what sort of keyframe to user. In some cases, it is useful to be able to force an IDR frame, e.g. for cutting streams. Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com

Re: [FFmpeg-devel] [PATCH 1/2] libx265: 4:2:2 and 4:4:4 are no longer experimental

2015-08-23 Thread Derek Buitenhuis
On 8/22/2015 7:17 PM, Stephen Hutchinson wrote: x265 itself removed its warnings about these a while ago. --- libavcodec/libx265.c | 8 1 file changed, 8 deletions(-) Are they ratified in the standard now? - Derek ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH 2/2] libx265: Enable 12-bit encoding

2015-08-23 Thread Derek Buitenhuis
On 8/22/2015 7:17 PM, Stephen Hutchinson wrote: This was introduced in x265 in July, and the experimental warnings about it in libx265 were recently removed, so there shouldn't be any reason to have it as experimental here. The configure detection is bumped to X265_BUILD = 60, as the

Re: [FFmpeg-devel] [PATCH] libx264: Add option to force IDR frames

2015-08-18 Thread Derek Buitenhuis
On 8/18/2015 4:05 PM, Hendrik Leppkes wrote: Whats the other reason for forcing a keyframe, ie. why don't we always set IDR? The other reason would be seek points I guess? - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] Offering to help out - keeping the merges going and ML patch handling

2015-08-01 Thread Derek Buitenhuis
On 8/1/2015 4:07 PM, Hendrik Leppkes wrote: Hey, I've offered on IRC already, but I figured doing it formally on the ML is probably best. I would be willing to take over doing the merges from Libav for the time being, until we decide otherwise, and on top I can probably spare some time

Re: [FFmpeg-devel] [PATCH] [RFC] use a wrapper script to call MS link.exe to avoid mixing with /usr/bin/link.exe

2015-07-23 Thread Derek Buitenhuis
On 7/23/2015 6:11 PM, Steve Lhomme wrote: You're welcome. I just hope I don't have to create 2 sets of patches when they don't merge in one of the repo. The MSVC stuff shouldn't have any merge conflicts. It's the same in both. - Derek ___

Re: [FFmpeg-devel] [libav-devel] [PATCH] [RFC] use a wrapper script to call MS link.exe to avoid mixing with /usr/bin/link.exe

2015-07-23 Thread Derek Buitenhuis
On 7/23/2015 6:02 PM, Derek Buitenhuis wrote: On 7/23/2015 5:41 PM, Steve Lhomme wrote: Looping in the other list, cause I forgot. -- favor link over link.exe in case some wrapper script already exists fallback to link in the path if the one next to cl is not found --- configure | 2

[FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis derek.buitenh...@gmail.com --- The design is how ubitux requested. Use trim with it or risk using ALL THEM MEMORY. --- doc/filters.texi | 4 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/version.h| 2

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Derek Buitenhuis
On Thu, Jul 16, 2015 at 7:43 PM, Clément Bœsch u...@pkh.me wrote: +Reverses a clip. Requires memory to buffer the entire clip, so trimming is suggested. We use infinitive form, so Reverse. Done locally. You might want to print Warning: this filter requires ... Is there any reasonable way

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-16 Thread Derek Buitenhuis
Missing Changelog entry. Added locally. +typedef struct ReverseContext { +const AVClass *class; Apparently not needed. Woops. Yeah. Obviously. Removed. +AVFilterContext *ctx = inlink-dst; +ReverseContext *s= ctx-priv; + + Extra newline. Fixed. Rest looks

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-17 Thread Derek Buitenhuis
The design is how ubitux requested. Use trim with it or risk using ALL THEM MEMORY. I always wondered if these kind of filters should require an option like -i_dont_care_about_oom but I am not saying it changes much... Wasn't my idea. ;) - Derek

Re: [FFmpeg-devel] [PATCH] avfilter: Add reverse filter

2015-07-19 Thread Derek Buitenhuis
On Sun, Jul 19, 2015 at 1:13 PM, Clément Bœsch u...@pkh.me wrote: Is there any reasonable way to determine when to print such a warning? Seems silly to warn over e.g. 40 frames. I meant in the documentation. I don't know for the code. OK. How does this look: -vf trim=end=10,reverse

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-23 Thread Derek Buitenhuis
On 10/23/2015 12:35 PM, wm4 wrote: > There are 2 possibilities: > 1. Using ff_thread_once() > 2. Not using global tables, but moving them to per-instance contexts > > Both should be fine, but I think 2. is preferred. I think 1 makes more sense in this case, since sin and cos are widely used, and

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:56 AM, Michael Niedermayer wrote: > the problem that causes the slowdown should be due to initializing all > table sizes when only 1 or a few small ones are needed > making the init more fine grained (as it was) should solve this > that could be done with a single mutex (not of

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:44 AM, Michael Niedermayer wrote: >> One could argue this is not a representative sample. It's a single small >> file, >> which must always init (as opposed to a longer running process such as >> Chrome. >> Whereas if you have a longer sample, it wouldn't even be within the

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:09 AM, Michael Niedermayer wrote: > on ARM (cubox) this changes > time ./ffmpeg -i ~/fate-suite/qt-surge-suite/surge-2-16-B-QDM2.mov > from > real0m0.028s > user0m0.010s > sys 0m0.010s > > real0m0.028s > user0m0.020s > sys 0m0.000s > > > to > > real

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 12:06 PM, wm4 wrote: > I think we don't need to block the patch on this issue anymore, because: > 1. We don't have any workarounds in place this patch could use, > 2. Lots of other code is probably affected anyway I agree, it is beyond the scope of this patch. - Derek

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-25 Thread Derek Buitenhuis
On 10/23/2015 7:41 PM, Tinglin Liu wrote: > ​ > http://stackoverflow.com/questions/3457968/snprintf-simple-way-to-force-as-radix > ​ > Here it mentioned using the setlocale() function, but I didn't find any > examples elsewhere though > > Derek, would you do the amend and push? Let me know if

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-25 Thread Derek Buitenhuis
On 10/25/2015 11:56 AM, Ronald S. Bultje wrote: > So this is likely because we init all tables instead of just these that we > need, right? So how about having one ff_once per table? That should be > trivial to implement. Yep. > Obviously anyone using shell scripts and calls to CLI ffmpeg

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-22 Thread Derek Buitenhuis
On 10/20/2015 7:29 PM, Tinglin Liu wrote: > The Apple dev specification: > https://developer.apple.com/library/mac/documentation/QuickTime/QTFF/Metadata/Metadata.html > --- > libavformat/isom.h | 3 +++ > libavformat/mov.c | 77 > +- > 2

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-22 Thread Derek Buitenhuis
On 10/22/2015 11:04 PM, Tinglin Liu wrote: > +} else if (data_type == 23 && str_size >= 4) { // BE float32 > +union av_intfloat32 val; > +val.i = avio_rb32(pb); I found we have a function to to this: av_int2float(). > +if (snprintf(str,

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-22 Thread Derek Buitenhuis
On 10/22/2015 11:28 PM, Tinglin Liu wrote: > 2) The key and value are stored separately for each key-value pair. 'keys' > atom stores the key name table, while 'ilst' atom stores the values > corresponding to the indices in the key table. And since they are stored in > two different atoms, I have

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-22 Thread Derek Buitenhuis
On 10/23/2015 12:19 AM, wm4 wrote: > Wrong, snprintf() always returns the number of characters the string > would have been, even if the buffer size is smaller. That'll teach me to reply past midnight. I am dumb at night. > Also, shouldn't this use some av_ wrapper? What about locale issues? >

Re: [FFmpeg-devel] [PATCH] avformat: implement SChannel SSP TLS protocol

2015-10-28 Thread Derek Buitenhuis
Enjoy my half-assed / useless review. > +#ifndef SECBUFFER_ALERT > +#define SECBUFFER_ALERT17 > +#endif Why? > +SecPkgContext_StreamSizes Sizes; Accidental capital? > +if (c->enc_buf == NULL) { > +c->enc_buf_offset = 0; > +c->enc_buf_size =

Re: [FFmpeg-devel] [PATCH] Adds support parsing the QuickTime Metadata Keys.

2015-10-26 Thread Derek Buitenhuis
On 10/23/2015 7:41 PM, Tinglin Liu wrote: > Derek, would you do the amend and push? Let me know if you need me to > resend an amended patch. Thanks. Amended and pushed. As before: Is there a sample somewhere we can add a FATE test for? - Derek ___

Re: [FFmpeg-devel] [PATCH] swr: do not reject channel layouts that use channel 63

2015-10-26 Thread Derek Buitenhuis
On 10/25/2015 5:31 PM, wm4 wrote: > Channel layouts are essentially uint64_t, and every value is valid. > --- > libswresample/options.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) Probably needs a micro version bump. - Derek ___

Re: [FFmpeg-devel] [PATCH] libavformat/riff.c: Adding support of PCM_S24LE in WAVEFORMATEXTENSIBLE

2015-10-26 Thread Derek Buitenhuis
On 10/22/2015 11:27 PM, Thierry Foucu wrote: > here is another version to fix the file. This looks no more hacky than what already exists in the file, I guess... I'm sure Hendrik has an opinion. - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-08 Thread Derek Buitenhuis
On 11/7/2015 10:42 PM, Ganesh Ajjanagadde wrote: > This is what I felt - it is an internal struct, and there are explicit > comments in the header saying that the struct's fields are meant to be > manipulated via the options API unlike e.g libavcodec. The types were > IMHO not part of the ABI/API

[FFmpeg-devel] [PATCH] movenc-test: Pad the packet data start with 0s

2015-11-17 Thread Derek Buitenhuis
This way, it never starts with 0xFFF0, and never trips the ADTS "Detection" code in movenc.c. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/movenc-test.c | 4 ++-- tests/ref/fate/movenc | 40 2 f

[FFmpeg-devel] [PATCH] hlsenc: Only write PAT/PMT once per segment

2015-11-01 Thread Derek Buitenhuis
This saves a lot of muxing overhead, especially on lower bitrate segments. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/hlsenc.c | 10 +- 1 file changed, 9 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 8

Re: [FFmpeg-devel] possible farewell; dev policy clarification

2015-10-30 Thread Derek Buitenhuis
Hi, I'll chime in on a few points. On 10/30/2015 11:34 AM, Ganesh Ajjanagadde wrote: > 1. "Sloppy" patches - I tend to give more verbose commit messages to > explain rationale than many here. I also outlined why I did not post > benchmarks initially. I myself still think they are unnecessary and

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Derek Buitenhuis
On 11/7/2015 4:47 PM, Paul B Mahol wrote: > I'm afraid that this can't be done this way. Perhaps providing more detail than HAL 9000 could help Ganesh here. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] swresample: allow double precision beta value for the Kaiser window

2015-11-07 Thread Derek Buitenhuis
On 11/7/2015 7:35 PM, Paul B Mahol wrote: > AFAIK changing option from int to double will break programs which > assume opttions is int. Not really sure how it could. The original range allowed was [2,16], and using any of the av_opt_set functions should still work with that, no? - Derek

[FFmpeg-devel] [PATCH 0/3] mpegts: Fix range and check for pat and sdt periods

2015-10-16 Thread Derek Buitenhuis
float rounding was causing some values to not work, and there was an undocumented upper limit. Derek Buitenhuis (3): mpegts: Make the pat_period a double mpegts: Make the sdt_period a double doc/muxers: Document range for mpegts periods doc/muxers.texi | 4 ++-- libavformat

[FFmpeg-devel] [PATCH 3/3] doc/muxers: Document range for mpegts periods

2015-10-16 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- doc/muxers.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 06483fa..cef04e1 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -802,9 +802,9 @@ Set a co

[FFmpeg-devel] [PATCH 2/3] mpegts: Make the sdt_period a double

2015-10-16 Thread Derek Buitenhuis
Having it as a float didn't even allow enough precision to check for INT_MAX/2. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/mpegtsenc.c | 4 ++-- libavformat/version.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libav

[FFmpeg-devel] [PATCH 1/3] mpegts: Make the pat_period a double

2015-10-16 Thread Derek Buitenhuis
Having it as a float didn't even allow enough precision to check for INT_MAX/2. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/mpegtsenc.c | 4 ++-- libavformat/version.h | 2 +- 2 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libav

[FFmpeg-devel] [PATCH] aac: Make codec init run under ff_thread_once

2015-10-14 Thread Derek Buitenhuis
This makes AAC init threadsafe. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- This relies on the latest merge from Libav, which hasn't happened yet. --- libavcodec/aacdec.c | 2 ++ libavcodec/aacdec_fixed.c| 1 + libavcodec/aacdec_template.

Re: [FFmpeg-devel] [PATCH] configure, avutil/libm: add fmax, fmaxf, fmin, fminf support

2015-10-15 Thread Derek Buitenhuis
On 10/15/2015 1:18 PM, Ganesh Ajjanagadde wrote: > It has been demonstrated that using libc provided floating point > functions is beneficial, in the context of fabs() vs FFABS. > > Unfortunately, MSVC 2012 (and earlier) lack the ISO C99 fmax, fmaxf, > fmin, fminf functions. This patch adds them,

[FFmpeg-devel] [PATCH] avcodec: Don't lock on init for codecs without an init function

2015-10-12 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/utils.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 1751067..0e4f3c0 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -3266,7 +

[FFmpeg-devel] [PATCH 1/3] Revert "cabac: Allow hardcoding CABAC table."

2015-10-07 Thread Derek Buitenhuis
This becomes unuseful in the following commit. This reverts commit 092d1977cc7146f20c8db2155e7d648afb300de7. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/Makefile | 4 +- libavcodec/cabac.c | 74 - liba

Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
On 10/7/2015 5:05 PM, Matt Oliver wrote: > Couldnt all the above if/includes be simplified by just using a single > include libavutil/thread.h (which has all the above checks in it. So, I included "thread.h", which is from avcodec, and it failed. I think it's pretty non-obvious I need the

[FFmpeg-devel] [PATCH 3/3 v2] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
This makes the h.264 decoder threadsafe to initialize. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/h264.c | 9 - libavcodec/h264.h | 7 +++ 2 files changed, 15 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c

[FFmpeg-devel] [PATCH 2/3] cabac: Make cabac starts hardcoded

2015-10-07 Thread Derek Buitenhuis
From: Anton Khirnov <an...@khirnov.net> There's not much reason to generate such a small table at runtime. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/cabac.c | 207 ++- libavcodec/cabac.h

[FFmpeg-devel] [PATCH 0/3] h264: Threadsafe initialization

2015-10-07 Thread Derek Buitenhuis
Towards a glorious non-locking future. Obviously requires Hendrik's phread_once patch. Anton Khirnov (1): cabac: Make cabac starts hardcoded Derek Buitenhuis (2): Revert "cabac: Allow hardcoding CABAC table." h264: Run VLC init under pthread_once libavcodec/Makefile

Re: [FFmpeg-devel] [PATCH 3/3] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
On 10/7/2015 4:39 PM, Derek Buitenhuis wrote: > +static pthread_once_t ff_h264_vlc_init = PTHREAD_ONCE_INIT; I've added av_unused here locally. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

Re: [FFmpeg-devel] [PATCH 3/3 v2] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
On 10/7/2015 5:24 PM, Derek Buitenhuis wrote: > This makes the h.264 decoder threadsafe to initialize. > > Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> > --- > libavcodec/h264.c | 9 - > libavcodec/h264.h | 7 +++ > 2 files changed, 1

[FFmpeg-devel] [PATCH 3/3 v3] h264: Run VLC init under pthread_once

2015-10-07 Thread Derek Buitenhuis
This makes the h.264 decoder threadsafe to initialize. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/h264.c | 9 - libavcodec/h264.h | 1 + 2 files changed, 9 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264.c b/libavcodec/h264.c index 3

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: allow 12bit input formats, update warnings

2015-07-09 Thread Derek Buitenhuis
Hi, Apologies if this comes through as HTML. I am internet-less and using the Gmail web interface. On Wed, Jul 8, 2015 at 11:54 PM, Steve Borho st...@borho.org wrote: The range extension profiles have been fully ratified so there is no reason to require -strict experimental for them. However

Re: [FFmpeg-devel] [PATCH] movenc-test: Pad the packet data start with 0s

2015-11-18 Thread Derek Buitenhuis
On 11/18/2015 3:15 PM, Michael Niedermayer wrote: > this looks a bit strange > doesnt this write the PTS into bytes which are never used or read? Uh, yep. Need to update size too. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH v2] movenc-test: Pad the packet data start with 0s

2015-11-18 Thread Derek Buitenhuis
This way, it never starts with 0xFFF0, and never trips the ADTS "Detection" code in movenc.c. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavformat/movenc-test.c | 6 +++--- tests/ref/fate/movenc | 40 2 f

Re: [FFmpeg-devel] QuickTime Edit List Support

2015-09-08 Thread Derek Buitenhuis
On 9/8/2015 11:52 AM, Alex M wrote: > Could somebody please confirm that this issue is still considered > outstanding and that a working patch has not been submitted? In which case > I’ll start work on this asap. Working this cleanly into the API is no small feat. Clément was working on this

Re: [FFmpeg-devel] [PATCH] avformat/avienc: add muxer option "write_channel_mask"

2015-09-10 Thread Derek Buitenhuis
On 9/10/2015 1:25 PM, Tobias Rapp wrote: > My use-case is handling recorded AVI files which have an > unknown/empty/unsupported channel layout. Instead of writing the guessed > channel layout into the output file, using "-write_channel_mask off" > allows to write an empty channel mask instead.

[FFmpeg-devel] [PATCH][RFC] avcodec: Don't lock during open if the codec has threadsafe init

2015-10-01 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/internal.h | 2 +- libavcodec/utils.c| 19 --- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 52b8917..324f099

[FFmpeg-devel] [PATCH][RFC] avcodec: Don't lock during open if the codec has threadsafe init

2015-10-01 Thread Derek Buitenhuis
Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- libavcodec/internal.h | 2 +- libavcodec/utils.c| 19 --- 2 files changed, 13 insertions(+), 8 deletions(-) diff --git a/libavcodec/internal.h b/libavcodec/internal.h index 52b8917..324f099

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: Don't lock during open if the codec has threadsafe init

2015-10-01 Thread Derek Buitenhuis
On 10/1/2015 3:37 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> > --- > libavcodec/internal.h | 2 +- > libavcodec/utils.c| 19 --- > 2 files changed, 13 insertions(+), 8 deletions(-) Sorry for the double-em

Re: [FFmpeg-devel] [PATCH][RFC] avcodec: Don't lock during open if the codec has threadsafe init

2015-10-02 Thread Derek Buitenhuis
On 10/1/2015 3:38 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> > --- > libavcodec/internal.h | 2 +- > libavcodec/utils.c| 19 --- > 2 files changed, 13 insertions(+), 8 deletions(-) OK'd by wm4 and nev on I

[FFmpeg-devel] [PATCH] movenc: Don't require a global sidx box to write the dash brand

2015-09-23 Thread Derek Buitenhuis
There's no reason this should be required. Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- As far as I know, anyway. --- libavformat/movenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index af03d1e..1

Re: [FFmpeg-devel] [WIP][RFC][PATCH] avfilter: add zscale filter

2015-09-22 Thread Derek Buitenhuis
On 9/21/2015 8:22 PM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > configure| 4 + > libavfilter/Makefile | 1 + > libavfilter/allfilters.c | 1 + > libavfilter/vf_zscale.c | 546 > +++ > 4

Re: [FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

2015-12-15 Thread Derek Buitenhuis
On 12/15/2015 10:44 AM, Jean Delvare wrote: > Originally I proposed this patch for performance reasons and also > because I think it makes the code more readable. But seeing how the > same cast is already present everywhere in the ffmpeg code, I would now > also invoke consistency. There's no

Re: [FFmpeg-devel] [PATCH] lavu/frame: Optimize frame_copy_video

2015-12-15 Thread Derek Buitenhuis
On 12/15/2015 5:23 PM, Jean Delvare wrote: > Looks like something different from what we were discussing here. In which way? That patch fixes pointer aliasing in the same way yours breaks it, AFAICT? - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] Cyrillic devices name support in libavdevice/dshow

2015-12-16 Thread Derek Buitenhuis
On 12/16/2015 4:29 PM, Roger Pack wrote: > Still mulling over why this would be needed...hm It makes sense that CP_OEMCP is needed for device names, in my mind, after reading https://support.microsoft.com/en-us/kb/108450 - however, I don't think changing the generic functions in cmdutils.c is

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 6:05 PM, Ganesh Ajjanagadde wrote: > Personally, I think it should be ok to use rename here for now, > especially since even projects like Python had trouble with this > aspect: https://bugs.python.org/issue8828. Someone with greater > Windows expertise can then examine the validity of

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 7:54 PM, Hendrik Leppkes wrote: > rename is used unconditionally in ff_rename as far as I can tell, so it > would probably be OK to remove the unistd.h check in file.c for rename? I would git blame and ask the author if possible first. - Derek

Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 8:18 PM, Thilo Borgmann wrote: > I'm quite sure that changing the number of channels is invalid for ALS > so there is no sense in implementing it. Ah, OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-06 Thread Derek Buitenhuis
On 1/5/2016 9:58 AM, Carl Eugen Hoyos wrote: > So perhaps libstagefright should be removed once your > patch hits the git repo? I would like to push this today if people are OK with it. Personally I think it's better to push it before, since, as per paragraph #2, it promotes incorrect info /

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-06 Thread Derek Buitenhuis
On 1/6/2016 3:51 PM, Matthieu Bouron wrote: > I'm OK with that. Pushed with commit message changed, as per Martin. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/decimate: Fix total difference for the first frame

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 5:17 PM, Carl Eugen Hoyos wrote: > I wish I would understand;-( > > Since this fixes a reported issue here, I will > commit my patch if nobody objects. [17:30] * Daemon404 pokes ubitux [17:30] <@ubitux> yup? [17:30] <@Daemon404> do you have a comment on carl's decimate change

Re: [FFmpeg-devel] [PATCH] alsdec: error out if channel number changes

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 3:18 PM, Andreas Cadhalpun wrote: > Supporting this would require re-initialization to change buffer sizes. I may be mistaken, but don't we already support some codecs which do this, properly? - Derek ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] Enable dash output to work when the output isn't a local file

2016-01-04 Thread Derek Buitenhuis
On 1/4/2016 4:46 PM, Ganesh Ajjanagadde wrote: > Yes, this is strange. url_move points to file_move, and the only > system functionality it relies on is rename, available in stdio.h. The > semantics vary from system to system, with some details specified in > POSIX, but rename itself is standard

Re: [FFmpeg-devel] [PATCH] avcodec/utils: Add case for mp3 to av_get_audio_frame_duration()

2016-01-01 Thread Derek Buitenhuis
On 1/1/2016 6:29 PM, Ronald S. Bultje wrote: > Please, no more codec-specific hacks in generic code. Eh, how is being generic even possible for audio frame size? What defines an audio "frame", if not the codec? - Derek ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-03 Thread Derek Buitenhuis
to a lot of misinformation, like these sorts of comments (in [1]) that are absolutely incorrect. [1] http://stackoverflow.com/a/29362353/3115956 Signed-off-by: Derek Buitenhuis <derek.buitenh...@gmail.com> --- I am certain there are many more reasons to remvoe this as well. I know its own

Re: [FFmpeg-devel] [PATCH] lavc/ccaption_dec: simplify parity check

2016-01-03 Thread Derek Buitenhuis
On 1/3/2016 6:05 PM, Clément Bœsch wrote: > Now that I think a bit about, I could just do return av_popcount(x) & 1... Sounds like a plan. - derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH]lavf/decimate: Fix total difference for the first frame

2016-01-03 Thread Derek Buitenhuis
On 1/3/2016 3:11 PM, Carl Eugen Hoyos wrote: > With the patch, the frame with the lowest diff is actually dropped > instead of the first frame that indicates a scene change without > the patch (iiuc). Is this for all scene changes or just frame 0? If for all scene changes, ignore the lower

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-03 Thread Derek Buitenhuis
On 1/3/2016 6:47 PM, Rostislav Pehlivanov wrote: > I see no reason why this should not be dropped from Git master > and the next stable release. I was unsure if this should be dropped in a minor or major bump, actually. - Derek ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH] avcodec: Remove libstagefright

2016-01-03 Thread Derek Buitenhuis
On 1/3/2016 6:37 PM, Derek Buitenhuis wrote: > Both stagefright itself, and MediaCodec, have > avcodec backends already, and this is the correct way to use it. This bit is wrong. The correct way is to use MediaCodecs API, since stagefright is not a public API, I have been informed. I

Re: [FFmpeg-devel] [PATCH]lavf/decimate: Fix total difference for the first frame

2016-01-03 Thread Derek Buitenhuis
On 1/3/2016 7:04 PM, Carl Eugen Hoyos wrote: > "dm->scthresh+1" is equivalent to INT_MAX afaict and > makes the given sample fail with our decimate filter. I think it should be OK, then. Perhaps Clement can comment if not. - Derek ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/ccaption_dec: simplify parity check

2016-01-03 Thread Derek Buitenhuis
On 1/3/2016 5:33 PM, Clément Bœsch wrote: > +return (0x6996966996696996ULL >> (x & 63) ^ (x>>7) ^ (x>>6)) & 1; I mean, I see how it works, but it's incredibly non-obvious without the patch context (table removal). - Derek ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] [PATCH]lavfi/drawtext: Fix microsecond display

2016-01-03 Thread Derek Buitenhuis
On 1/3/2016 1:00 PM, Carl Eugen Hoyos wrote: > Attached patch fixes ticket #4792 for me, please comment. Looks OK. - Derek ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] phasing out asyntcs, resample

2015-12-21 Thread Derek Buitenhuis
On 12/21/2015 10:32 PM, Ganesh Ajjanagadde wrote: > If aresample indeed subsumes asyncts, why not mark asyncts > deprecated, issue a warning telling users to switch to aresample, and > phase it out after some time. asyncts provides some features currently that aresample does not, such as the

Re: [FFmpeg-devel] phasing out asyntcs, resample

2015-12-21 Thread Derek Buitenhuis
On 12/22/2015 1:44 AM, Ganesh Ajjanagadde wrote: > May be missing something, but "See the ffmpeg-resampler manual for the > complete list of supported options. " followed by man ffmpeg-resampler > shows first_pts as a supported option. Oh, indeed; never used to be. Apologies. Looks like the

Re: [FFmpeg-devel] [PATCH 1/3] lavu/error: add AVERROR_REDO.

2015-11-27 Thread Derek Buitenhuis
On 11/27/2015 7:07 AM, Nicolas George wrote: > So basically, the question boils down to what people consider the better > design: adding a loop in every demuxer that needs it, or have the loop in > the framework. I'm erring on the latter approach, for one reason: This changes beavior, but does

Re: [FFmpeg-devel] [PATCH 1/4] avutil/tablegen: add tablegen libm compatibility shims

2015-11-28 Thread Derek Buitenhuis
On 11/28/2015 5:03 PM, Ganesh Ajjanagadde wrote: > +static inline double ff_cbrt(double x) > +{ > +return x < 0 ? -pow(-x, 1.0 / 3.0) : pow(x, 1.0 / 3.0); > +} > +#define cbrt ff_cbrt Didn't Clément say to not pollute the global namespace like this? - Derek

Re: [FFmpeg-devel] [PATCH 1/4] avutil/tablegen: add tablegen libm compatibility shims

2015-11-28 Thread Derek Buitenhuis
On 11/28/2015 7:51 PM, Ganesh Ajjanagadde wrote: > In principle of course, e.g with more ifdefry, configure, or something > of that sort. I do not believe this is what he meant. I will await his reply to clarify, then. Perhaps do not write so matter-of-factly. > In any case, the point is moot -

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegaudio_tablegen: more dynamic table creation speedups

2015-11-28 Thread Derek Buitenhuis
On 11/28/2015 5:03 PM, Ganesh Ajjanagadde wrote: > +if (i % 4 == 0) I doubt it particularly matters in this case, but you can avoid a modulo operator here with i & 3, like elsewhere in the file. I doubt the compiler is that dumb, though. Same for other occurrences. - Derek

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegaudio_tablegen: more dynamic table creation speedups

2015-11-28 Thread Derek Buitenhuis
On 11/28/2015 9:19 PM, Ganesh Ajjanagadde wrote: > I actually prefer keeping all at i % 4, since that conveys intent > better IMHO, and would change uniformly to that. It takes a reader a > couple of seconds extra to register what i & 3 is doing for no gain in > C code. No compiler I know of in

Re: [FFmpeg-devel] [PATCH 1/4] avutil/tablegen: add tablegen libm compatibility shims

2015-11-28 Thread Derek Buitenhuis
On 11/28/2015 7:33 PM, Ganesh Ajjanagadde wrote: > 2. Clement's idea AFAIK does not work, since the names must be > identical to the standard C names for the build to work with/without > hardcoded tables. ... yes it can. It doesn't work without more work, but it it sure can work. Anyway,

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/mpegaudio_tablegen: more dynamic table creation speedups

2015-11-28 Thread Derek Buitenhuis
On 11/28/2015 9:26 PM, Derek Buitenhuis wrote: > Changing all of them sounds fine to me. [21:31] <@ubitux> re: i%4 vs i&3; you should ask him to make sure the compiler is smart enough regarding the signess of i - Derek ___ ffmpeg-devel

Re: [FFmpeg-devel] VS 2015 patch

2015-11-25 Thread Derek Buitenhuis
On 11/25/2015 12:05 AM, Bruce Dawson wrote: > This would make ffmpeg fail on VS versions prior to VS 2013, for those > using the BUILD.gn file, which I assume is not many. It would be easy to > add additional conditionals for earlier versions, but if it's just for > Chromium then 2013/2015 is

<    1   2   3   4   5   6   7   8   9   10   >