Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

2018-03-12 Thread Hazem Ashmawy
So, I spend few hours trying to incorporate the partial change. I'm not sure that the video sent by earlier follows the faces order here https://github.com/google/spatial-media/blob/master/docs/spherical-video-v2-rfc.md#semantics-3 Because when I made this change, I got a reasonable equirectangu

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

2018-03-12 Thread Hazem Ashmawy
On 3/12/18, Paul B Mahol wrote: > On 3/12/18, Hazem Ashmawy wrote: >> So, I spend few hours trying to incorporate the partial change. >> >> I'm not sure that the video sent by earlier follows the >> faces order here >> https://github.com/google/spatial-med

[FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

2018-03-12 Thread Hazem Ashmawy
Specifications can be found here: https://github.com/google/spatial-media/blob/master/docs/spherical-video-v2-rfc.md Signed-off-by: Hazem Ashmawy --- libavfilter/vf_panorama.c | 32 1 file changed, 16 insertions(+), 16 deletions(-) diff --git a/libavfilter

Re: [FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

2018-03-12 Thread Hazem Ashmawy
Sorry about that! Here is github branch https://github.com/FFmpeg/FFmpeg/compare/master...HazemSamir:panorama_youtube On 3/12/18, Paul B Mahol wrote: > On 3/12/18, wm4 wrote: >> On Mon, 12 Mar 2018 11:26:26 +0100 >> Paul B Mahol wrote: >> >>> On

Re: [FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

2018-03-12 Thread Hazem Ashmawy
On 3/12/18, Paul B Mahol wrote: > On 3/12/18, Hazem Ashmawy wrote: >> Sorry about that! Here is github branch >> >> https://github.com/FFmpeg/FFmpeg/compare/master...HazemSamir:panorama_youtube > > Good, now can you look at how to use bilinear instead of nearest >

Re: [FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

2018-03-14 Thread Hazem Ashmawy
systematic way to evaluate the quality? https://github.com/HazemSamir/FFmpeg/commit/fcd82b9782b5f32072d9b0516b275fe3d4f4a163 On 3/12/18, Paul B Mahol wrote: > On 3/12/18, Hazem Ashmawy wrote: >> On 3/12/18, Paul B Mahol wrote: >>> On 3/12/18, Hazem Ashmawy wrote: >>&

Re: [FFmpeg-devel] [PATCH v2] Change cube faces order to match Youtube's

2018-04-01 Thread Hazem Ashmawy
Please find another implementation for bilinear https://github.com/HazemSamir/FFmpeg/commit/6a62f6db30bed37323d70eb7d66d6c33fa8f00c3 Please let me know your thoughts. On 3/14/18, Paul B Mahol wrote: > On 3/14/18, Hazem Ashmawy wrote: >> So I'm still looking into using bilin

[FFmpeg-devel] [PATCH 1/1] avfilter: add panorama filter

2018-03-08 Thread Hazem Ashmawy
[PATCH 1/1] avfilter: add panorama filter Hello there, This is my first message and patch to ffmpeg so I'm sorry if there are any mistaks in formating the patch or the email. It's my first time to use git send-email too. This patch is part of the qualification task for GSoC 2018. The project is

[FFmpeg-devel] [PATCH 1/1] avfilter: add panorama filter

2018-03-08 Thread Hazem Ashmawy
Add filter to convert between various panorama projections. It supports Equirectangular and Cubemaps (3x2 and 6x1 cubemap layouts). commit a8d80408bd9d99542cc29f30d7e6b00771846029 Author: Hazem Ashmawy Date: Thu Mar 8 10:09:36 2018 +0200 avfilter: add convertion to/from cubemap 6x1

[FFmpeg-devel] [PATCH] avfilter: add panorama filter

2018-03-08 Thread Hazem Ashmawy
[PATCH] avfilter: add panorama filter Sorry about that! I removed them now. For the future, any recommendation for a tool for linting / checking formating rules? ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffm

[FFmpeg-devel] [PATCH] avfilter: add panorama filter

2018-03-08 Thread Hazem Ashmawy
Add filter to convert between various panorama projections. It supports Equirectangular and Cubemaps (3x2 and 6x1 cubemap layouts). commit a8d80408bd9d99542cc29f30d7e6b00771846029 Author: Hazem Ashmawy Date: Thu Mar 8 10:09:36 2018 +0200 avfilter: add convertion to/from cubemap 6x1

Re: [FFmpeg-devel] [PATCH] avfilter: add panorama filter

2018-03-09 Thread Hazem Ashmawy
On 3/9/18, Paul B Mahol wrote: > On 3/9/18, Hazem Ashmawy wrote: >> Add filter to convert between various panorama projections. It supports >> Equirectangular and Cubemaps (3x2 and 6x1 cubemap layouts). >> >> commit a8d80408bd9d99542cc29f30d7e6b00771846029 >&g