Re: [FFmpeg-devel] [PATCH v3] avformat/concatdec: add support for setting input options

2021-02-10 Thread Jan Ekström
On Wed, Feb 10, 2021 at 8:33 PM Nicolas George wrote: > > Jan Ekström (12021-02-08): > > This way protocol or format related options can be set for all > > of the files opened during concatenation both globally as well > > as per-file. > > --- > > > > Ch

Re: [FFmpeg-devel] [PATCH] avformat/movenc: remove unnecessary HDR metadata log messages

2021-02-10 Thread Jan Ekström
On Wed, Feb 10, 2021 at 12:43 PM Paul B Mahol wrote: > > lgtm Cheers, applied as 752f14ff942576dd8697320fb6ba055593a2de9d . Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

[FFmpeg-devel] [PATCH v2] avfilter/vf_zscale: add support for setting scaling filter parameters

2021-02-11 Thread Jan Ekström
param_a/b are utilized for this. --- Changes from v1: * Documentation was added. * The author of the zimg library noted that the bicubic parameters technically can go negative. Thus the range is -DBL_MAX to DBL_MAX. --- doc/filters.texi| 7 +++ libavfilter/vf_zscale.c | 7 +++

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_zscale: add support for setting scaling filter parameters

2021-02-11 Thread Jan Ekström
On Thu, Feb 11, 2021 at 8:31 PM Paul B Mahol wrote: > > lgtm Thanks, applied as 58e59396f5fe93f0606dc458d84c609b5d23ea1c . Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

Re: [FFmpeg-devel] [PATCH] Increase MOV_TIMESCALE for higher precision

2021-03-24 Thread Jan Ekström
On Wed, Mar 24, 2021 at 7:30 AM Gyan Doshi wrote: > > > > On 2021-03-24 03:38, Andrey Rikunov wrote: > > --- > > libavformat/movenc.h | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavformat/movenc.h b/libavformat/movenc.h > > index cdbc407..8a152c0 100644 > >

[FFmpeg-devel] [PATCH 4/4] avcodec/ttmlenc: add support for region positioning and sizing

2021-03-30 Thread Jan Ekström
From: Jan Ekström The ASS margins are utilized to generate percentual values, as the usage of cell-based sizing and offsetting seems to be not too well supported by renderers. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 41 -- tests/ref/fate

[FFmpeg-devel] [PATCH 2/4] avformat/ttmlenc: enable writing out additional header values

2021-03-30 Thread Jan Ekström
From: Jan Ekström This way the encoder may pass on the following values to the muxer: 1) Additional root "tt" element attributes, such as the subtitle canvas reference size. 2) Anything before the body element of the document, such as regions in the head element, which can config

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/ttmlenc: add support for region positioning and sizing

2021-03-30 Thread Jan Ekström
On Tue, Mar 30, 2021 at 11:23 AM Jan Ekström wrote: > > +if (style->margin_l < 0 || style->margin_r < 0 || style->margin_v < 0) { > +av_log(avctx, AV_LOG_ERROR, > + "One or more negative margin values in subtitle style: " > +

[FFmpeg-devel] [PATCH 3/4] avcodec/ttmlenc: add initial support for regions and styles

2021-03-30 Thread Jan Ekström
From: Jan Ekström Attempts to utilize the TTML cell resolution as a mapping to the reference resolution, and maps font size to cell size. Additionally sets the display and text alignment according to the ASS alignment number. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 257

[FFmpeg-devel] [PATCH 1/4] avcodec/ttmlenc: split header writing into its own function

2021-03-30 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/libavcodec/ttmlenc.c b/libavcodec/ttmlenc.c index 3972b4368c..e3c155fdd1 100644 --- a/libavcodec/ttmlenc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 0/4] Initial region (styling) support for TTML

2021-03-30 Thread Jan Ekström
e verified against such renderers as http://sandflow.com/imsc1_1/index.html . Jan Jan Ekström (4): avcodec/ttmlenc: split header writing into its own function avformat/ttmlenc: enable writing out additional header values avcodec/ttmlenc: add initial support for regions and styles avcodec/tt

Re: [FFmpeg-devel] [PATCH 2/4] avformat/ttmlenc: enable writing out additional header values

2021-03-31 Thread Jan Ekström
On Tue, Mar 30, 2021 at 12:19 PM Andreas Rheinhardt wrote: > > Jan Ekström: > > From: Jan Ekström > > > > This way the encoder may pass on the following values to the muxer: > > 1) Additional root "tt" element attributes, such as the subtitle > >

Re: [FFmpeg-devel] 4.4 Release Name

2021-04-03 Thread Jan Ekström
On Fri, Apr 2, 2021 at 12:59 PM Michael Niedermayer wrote: > > Hi all > > We still need to choose the name for 4.4 > previous unused suggestions where: > Von Neumann, Lorentz, Poincaré, Desitter, De Broglie, Gauss, Galois, Viterbi, > Darwin > > Feel free to reply with name suggestions > If

Re: [FFmpeg-devel] [PATCH v2] libsvtav1: Add logical_processors option

2021-03-30 Thread Jan Ekström
On Sat, Feb 20, 2021 at 3:20 AM Christopher Degawa wrote: > > From: Christopher Degawa > > Used for limiting the size of memory buffers and threads for a target > logical processor count, but does not set thread affinity or limit the > amount of threads used, although thread affinities can be

Re: [FFmpeg-devel] Hardware purchase request

2021-03-29 Thread Jan Ekström
On Tue, Mar 23, 2021 at 12:47 AM Lynne wrote: > > As discussed during the last developer meeting, I am in need of new hardware > to > work on Vulkan filtering, hwcontext, AV1 VAAPI decoding, new assembly and > general development on FFmpeg and projects involving the FFmpeg libraries. > > I was

Re: [FFmpeg-devel] [PATCH] added parameter to dash encoder for start available time

2021-03-18 Thread Jan Ekström
On Thu, Mar 18, 2021, 17:01 Gyan Doshi wrote: > > > On 2021-03-18 20:12, Jan Ekström wrote: > > So right now we do have an option in ffmpeg.c called itsoffset. It > > lets you configure the input offset in time (seconds - such as > > "1337.123" or time forma

Re: [FFmpeg-devel] [PATCH] added parameter to dash encoder for start available time

2021-03-18 Thread Jan Ekström
On Thu, Mar 18, 2021 at 3:49 AM Jerome Berclaz wrote: > > --- > libavformat/dashenc.c | 28 > 1 file changed, 20 insertions(+), 8 deletions(-) So right now we do have an option in ffmpeg.c called itsoffset. It lets you configure the input offset in time (seconds -

Re: [FFmpeg-devel] [PATCH] added parameter to dash encoder for start available time

2021-03-18 Thread Jan Ekström
On Thu, Mar 18, 2021 at 5:07 PM Jan Ekström wrote: > > On Thu, Mar 18, 2021, 17:01 Gyan Doshi wrote: >> >> >> >> On 2021-03-18 20:12, Jan Ekström wrote: >> > So right now we do have an option in ffmpeg.c called itsoffset. It >> > lets

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-03 Thread Jan Ekström
On Tue, Mar 2, 2021 at 11:00 AM Jan Ekström wrote: > > I've intentionally kept this initial version simple (no styling etc) to focus > on the basics. As this goes through review, additional features can be added > (I had initial PoC for styling implemented some time around

Re: [FFmpeg-devel] [PATCH v5 3/4] avcodec: enable usage of AV_EF_EXPLODE for subtitle encoders

2021-02-28 Thread Jan Ekström
On Mon, Feb 22, 2021 at 3:19 PM Jan Ekström wrote: > > From: Jan Ekström > > As currently it is the responsibility of the following subtitle > encoder to validate the correctness of the incoming ASS dialog line. > > Signed-off-by: Jan Ekström Requesting comments on this

[FFmpeg-devel] [PATCH v6 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-03-02 Thread Jan Ekström
From: Stefano Sabatini Base escaping only escapes values required for base character data according to part 2.4 of XML, and if additional flags are added single and double quotes can additionally be escaped in order to handle single and double quoted attributes. Co-Authored-By: Jan Ekström

[FFmpeg-devel] [PATCH v6 4/4] {avcodec, avformat}: add TTML encoder and muxer

2021-03-02 Thread Jan Ekström
From: Jan Ekström Enables encoding of other subtitle formats into TTML and writing them out as such documents. Signed-off-by: Jan Ekström --- Changelog | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1

[FFmpeg-devel] [PATCH v6 2/4] ffprobe: switch to av_bprint_escape for XML escaping

2021-03-02 Thread Jan Ekström
From: Jan Ekström Additionally update the result of the ffprobe XML writing test. Signed-off-by: Jan Ekström --- fftools/ffprobe.c | 32 +++- tests/ref/fate/ffprobe_xml | 2 +- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/fftools

[FFmpeg-devel] [PATCH v6 3/4] avcodec: enable usage of err_recognition for encoders

2021-03-02 Thread Jan Ekström
From: Jan Ekström Enables the usage of such values as AV_EF_EXPLODE in encoders, which can be useful in cases such as subtitle encoders where they have the responsibility to validate the correctness of an incoming ASS dialog line. Signed-off-by: Jan Ekström --- doc/APIchanges | 3

[FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-02 Thread Jan Ekström
support for muxing TTML into MP4. Changes from the fifth version: - Fixed a stupid mistake in tools/ffescape. - Reworked the err_recognition commit based on comments from James and Anton. Jan Jan Ekström (3): ffprobe: switch to av_bprint_escape for XML escaping avcodec: enable usage

Re: [FFmpeg-devel] [PATCH v5 0/4] Initial implementation of TTML encoding/muxing

2021-02-25 Thread Jan Ekström
On Mon, Feb 22, 2021, 15:32 Jan Ekström wrote: > On Mon, Feb 22, 2021 at 3:19 PM Jan Ekström wrote: > > > > I've intentionally kept this initial version simple (no styling etc) to > focus > > on the basics. As this goes through review, additional features can be > a

Re: [FFmpeg-devel] [PATCH] mov.c log qt ref extenal essence metadata

2021-03-06 Thread Jan Ekström
On Sat, Mar 6, 2021 at 10:38 AM emcodem wrote: > > --- > libavformat/mov.c | 8 > 1 file changed, 8 insertions(+) > > In quicktime reference files, exposing the parsed info for external essences > location can be very handy for users > Unfortunately, as per the discussion we had

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021 at 11:57 AM Moritz Barsnick wrote: > > On Wed, Mar 03, 2021 at 22:09:12 +0200, Jan Ekström wrote: > > Thus, I will be pulling this set in Soon (probably tomorrow). Thus if > > anyone still wishes to have a say, I recommend doing it earlier than > > la

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021, 16:43 Moritz Barsnick wrote: > On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: > > I... just am not so sure in this case splitting the TTML writer and > > the TTML encoder from each other makes sense. > > I agree. In very many cases, muxer an

Re: [FFmpeg-devel] [PATCH v6 0/4] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
On Thu, Mar 4, 2021 at 4:52 PM Jan Ekström wrote: > > On Thu, Mar 4, 2021, 16:43 Moritz Barsnick wrote: >> >> On Thu, Mar 04, 2021 at 15:52:13 +0200, Jan Ekström wrote: >> > I... just am not so sure in this case splitting the TTML writer and >> > the TTML

[FFmpeg-devel] [PATCH v7 4/5] avcodec: add TTML encoder

2021-03-04 Thread Jan Ekström
From: Jan Ekström Enables encoding of other subtitle formats into TTML paragraphs. Signed-off-by: Jan Ekström --- Changelog | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile | 1 + libavcodec/allcodecs.c| 1 + libavcodec/ttmlenc.c | 210

[FFmpeg-devel] [PATCH v7 3/5] avcodec: enable usage of err_recognition for encoders

2021-03-04 Thread Jan Ekström
From: Jan Ekström Enables the usage of such values as AV_EF_EXPLODE in encoders, which can be useful in cases such as subtitle encoders where they have the responsibility to validate the correctness of an incoming ASS dialog line. Signed-off-by: Jan Ekström --- doc/APIchanges | 3

[FFmpeg-devel] [PATCH v7 2/5] ffprobe: switch to av_bprint_escape for XML escaping

2021-03-04 Thread Jan Ekström
From: Jan Ekström Additionally update the result of the ffprobe XML writing test. Signed-off-by: Jan Ekström --- fftools/ffprobe.c | 32 +++- tests/ref/fate/ffprobe_xml | 2 +- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/fftools

[FFmpeg-devel] [PATCH v7 0/5] Initial implementation of TTML encoding/muxing

2021-03-04 Thread Jan Ekström
support for muxing TTML into MP4. Changes from the sixth version: - Split the lavc and lavf bits. Jan Jan Ekström (4): ffprobe: switch to av_bprint_escape for XML escaping avcodec: enable usage of err_recognition for encoders avcodec: add TTML encoder avformat: add TTML muxer Stefano

[FFmpeg-devel] [PATCH v7 1/5] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-03-04 Thread Jan Ekström
From: Stefano Sabatini Base escaping only escapes values required for base character data according to part 2.4 of XML, and if additional flags are added single and double quotes can additionally be escaped in order to handle single and double quoted attributes. Co-authored-by: Jan Ekström

[FFmpeg-devel] [PATCH v7 5/5] avformat: add TTML muxer

2021-03-04 Thread Jan Ekström
From: Jan Ekström Enables writing TTML documents or encoded TTML paragraphs as such documents. Additionally, a test for the combined TTML encoder and muxer has been added to validate that the components still work. Signed-off-by: Jan Ekström --- Changelog | 2 +- doc

Re: [FFmpeg-devel] [PATCH v7 0/5] Initial implementation of TTML encoding/muxing

2021-03-05 Thread Jan Ekström
On Thu, Mar 4, 2021 at 7:48 PM Jan Ekström wrote: > > I've intentionally kept this initial version simple (no styling etc) to focus > on the basics. As this goes through review, additional features can be added > (I had initial PoC for styling implemented some time around

Re: [FFmpeg-devel] [PATCH v5 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-26 Thread Jan Ekström
On Fri, Feb 26, 2021 at 7:54 PM Michael Niedermayer wrote: > > On Mon, Feb 22, 2021 at 03:19:11PM +0200, Jan Ekström wrote: > > From: Stefano Sabatini > > > > Base escaping only escapes values required for base character data > > according to part 2.4 of XML, and

Re: [FFmpeg-devel] [PATCH v5 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-26 Thread Jan Ekström
On Fri, Feb 26, 2021 at 9:00 PM Jan Ekström wrote: > > On Fri, Feb 26, 2021 at 7:54 PM Michael Niedermayer > wrote: > > > > On Mon, Feb 22, 2021 at 03:19:11PM +0200, Jan Ekström wrote: > > > From: Stefano Sabatini > > > > > > Base escaping only

[FFmpeg-devel] [PATCH] avformat/img2dec: set r_frame_rate in addition to avg_frame_rate

2021-04-07 Thread Jan Ekström
Apparently for various image sequences libavformat/utils.c can calculate rather fancy r_frame_rate values, such as `186/1921`, and since ffmpeg.c utilizes r_frame_rate for the filter chain time base, this can quite deteriorate the output frame timing - even though the user has requested the image

Re: [FFmpeg-devel] [PATCH] libavdevice/gdigrab: fix capture window title contain non-ASCII chars

2021-04-12 Thread Jan Ekström
On Sat, Mar 20, 2021 at 5:34 PM <1160386...@qq.com> wrote: > > From: He Yang <1160386...@qq.com> > > Signed-off-by: He Yang <1160386...@qq.com> Sorry for taking a while to respond, and thank you for the contribution. I have verified that this conversion and FindWindowW usage indeed fixes issues

Re: [FFmpeg-devel] [PATCH v2 0/4] Initial region (styling) support for TTML

2021-04-19 Thread Jan Ekström
On Wed, Apr 14, 2021 at 9:57 AM Jan Ekström wrote: > > Now sets alignment, font size, font family and the region's position > and size according to the ASS styles passed to the encoder. Regions are > relatively important in TTML, since the spec-defined default region is in >

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-19 Thread Jan Ekström
On Tue, Apr 20, 2021 at 12:11 AM Marton Balint wrote: > > > > On Mon, 19 Apr 2021, zheng qian wrote: > > > Is there anyone who could review this patch? > > Jan was interested in this, so preferably he should also comment, but it > looks fine to me. > OK, this explains why I didn't see my

Re: [FFmpeg-devel] [PATCH] libavdevice/gdigrab: fix capture window title contain non-ASCII chars

2021-04-13 Thread Jan Ekström
On Tue, Apr 13, 2021 at 12:35 AM Jan Ekström wrote: > > On Sat, Mar 20, 2021 at 5:34 PM <1160386...@qq.com> wrote: > > > > From: He Yang <1160386...@qq.com> > > > > Signed-off-by: He Yang <1160386...@qq.com> > > Sorry for taking a while to

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread Jan Ekström
On Tue, Apr 20, 2021 at 3:03 PM zheng qian wrote: > > On Tue, Apr 20, 2021 at 6:46 AM Jan Ekström wrote: > > > > On Tue, Apr 20, 2021 at 12:11 AM Marton Balint wrote: > > > > > > > > > > > > On Mon, 19 Apr 2021, zheng qian wrote: >

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-20 Thread Jan Ekström
On Tue, Apr 20, 2021 at 8:16 PM Jan Ekström wrote: > > On Tue, Apr 20, 2021 at 3:03 PM zheng qian wrote: > > > > On Tue, Apr 20, 2021 at 6:46 AM Jan Ekström wrote: > > > > > > On Tue, Apr 20, 2021 at 12:11 AM Marton Balint wrote: > > > > > &g

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread Jan Ekström
On Sun, Apr 11, 2021 at 4:25 PM magic xqq wrote: > > I have already tried to use st->stream_identifier directly in mpegtsenc.c > while handling arib_caption stream in mpegts_write_pmt() function. > > But in mpegtsenc.c, st->stream_identifier always provides > an incorrect value of 0, which should

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread Jan Ekström
On Sun, Apr 11, 2021 at 4:58 PM Jan Ekström wrote: > > On Sun, Apr 11, 2021 at 4:25 PM magic xqq wrote: > > > > I have already tried to use st->stream_identifier directly in mpegtsenc.c > > while handling arib_caption stream in mpegts_write_pmt() function. >

Re: [FFmpeg-devel] [PATCH] avformat/img2dec: set r_frame_rate in addition to avg_frame_rate

2021-04-11 Thread Jan Ekström
On Sun, Apr 11, 2021 at 1:16 PM Anton Khirnov wrote: > > Quoting Jan Ekström (2021-04-07 20:25:03) > > Apparently for various image sequences libavformat/utils.c can > > calculate rather fancy r_frame_rate values, such as `186/1921`, > > and since ffmpeg.c utilizes r_f

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread Jan Ekström
On Sun, Apr 11, 2021 at 6:17 PM zheng qian wrote: > > Consider the remuxed stream could be handled by other clients rather > than FFmpeg, > e.g. I'm working on HTML5 playback for ISDB television with ARIB > captions through > mpegts.js + b24.js/aribb24.js. Other ISDB TV clients may also have >

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread Jan Ekström
On Sun, Apr 11, 2021 at 5:51 PM Jan Ekström wrote: > > On Sun, Apr 11, 2021 at 4:58 PM Jan Ekström wrote: > > > > On Sun, Apr 11, 2021 at 4:25 PM magic xqq wrote: > > > > > > I have already tried to use st->stream_identifier directly in mpegtsenc.c &

[FFmpeg-devel] [PATCH v2 4/4] avcodec/ttmlenc: add support for region positioning and sizing

2021-04-14 Thread Jan Ekström
From: Jan Ekström The ASS margins are utilized to generate percentual values, as the usage of cell-based sizing and offsetting seems to be not too well supported by renderers. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 44 -- tests/ref/fate

[FFmpeg-devel] [PATCH v2 1/4] avcodec/ttmlenc: split header writing into its own function

2021-04-14 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/libavcodec/ttmlenc.c b/libavcodec/ttmlenc.c index 3972b4368c..e3c155fdd1 100644 --- a/libavcodec/ttmlenc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH v2 3/4] avcodec/ttmlenc: add initial support for regions and styles

2021-04-14 Thread Jan Ekström
From: Jan Ekström Attempts to utilize the TTML cell resolution as a mapping to the reference resolution, and maps font size to cell size. Additionally sets the display and text alignment according to the ASS alignment number. Signed-off-by: Jan Ekström --- libavcodec/ttmlenc.c | 210

[FFmpeg-devel] [PATCH v2 0/4] Initial region (styling) support for TTML

2021-04-14 Thread Jan Ekström
ult_region_v1..ttml_add_default_region_v2 (more easily readable due to file limiting with the following command: git diff ttml_add_default_region_v1..ttml_add_default_region_v2 -- libavcodec/ttmlenc.* libavformat/ttmlenc.* ) Jan Jan Ekström (4): avcodec/ttmlenc: split header writing into its own functi

[FFmpeg-devel] [PATCH v2 2/4] avformat/ttmlenc: enable writing out additional header values

2021-04-14 Thread Jan Ekström
From: Jan Ekström This way the encoder may pass on the following values to the muxer: 1) Additional root "tt" element attributes, such as the subtitle canvas reference size. 2) Anything before the body element of the document, such as regions in the head element, which can config

Re: [FFmpeg-devel] [PATCH] avcodec/mediacodecdec: Do not abort when H264/HEVC extradata extraction fails

2021-02-12 Thread Jan Ekström
On Fri, Feb 12, 2021 at 12:36 PM Matthieu Bouron wrote: > > On Mon, Jan 25, 2021 at 06:38:36PM +0100, sfan5 wrote: > > Although rare, extradata can be present but empty and extraction will fail. > > However Android also supports passing codec-specific data inline and > > will likely play such a

Re: [FFmpeg-devel] [PATCH v3] avcodec/mediacodecdec: Do not abort when H264/HEVC extradata extraction fails

2021-02-14 Thread Jan Ekström
On Sat, Feb 13, 2021 at 4:31 PM Jan Ekström wrote: > > On Sat, Feb 13, 2021 at 12:48 AM sfan5 wrote: > > > > 12.02.21 - 21:43 - Andreas Rheinhardt: > > > sfan5: > > >> Hi, > > >> > > >> > > >> attached

Re: [FFmpeg-devel] [PATCH v3] avcodec/mediacodecdec: Do not abort when H264/HEVC extradata extraction fails

2021-02-13 Thread Jan Ekström
On Sat, Feb 13, 2021 at 12:48 AM sfan5 wrote: > > 12.02.21 - 21:43 - Andreas Rheinhardt: > > sfan5: > >> Hi, > >> > >> > >> attached v2 patch after discussion on IRC with JEEB (as he already > >> mentioned). > >> > >> Only change is that the log level turns to debug when missing parameter > >>

Re: [FFmpeg-devel] [PATCH v6 4/9] avcodec: add cbs for h266/vvc

2021-02-19 Thread Jan Ekström
On Fri, Feb 19, 2021 at 3:52 PM Nuo Mi wrote: > > >> > > >> The current logic is that we are writing an AU, so the first NAL unit in > > >> it is necessarily an AU start and subsequent NAL units are not? > > >> > > > H.266 AU contains one or more PU(3.105). One PU contains one coded > > picture.

Re: [FFmpeg-devel] [PATCH v2] Add support for the new key & value API in libaom.

2021-02-13 Thread Jan Ekström
On Wed, Feb 10, 2021 at 9:16 AM Bohan Li wrote: > > Hi Jan, > > Yes the modified patch looks good to me. > Please let me know if there is anything needed from my end. > > Thank you very much! > > Bohan > FYI, apparently the symbol is not exported in shared builds of libaom. I did test that

[FFmpeg-devel] [PATCH v5 4/4] {avcodec, avformat}: add TTML encoder and muxer

2021-02-22 Thread Jan Ekström
From: Jan Ekström Enables encoding of other subtitle formats into TTML and writing them out as such documents. Signed-off-by: Jan Ekström --- Changelog | 1 + doc/general_contents.texi | 1 + libavcodec/Makefile| 1 + libavcodec/allcodecs.c | 1

Re: [FFmpeg-devel] [PATCH v5 0/4] Initial implementation of TTML encoding/muxing

2021-02-22 Thread Jan Ekström
On Mon, Feb 22, 2021 at 3:19 PM Jan Ekström wrote: > > I've intentionally kept this initial version simple (no styling etc) to focus > on the basics. As this goes through review, additional features can be added > (I had initial PoC for styling implemented some time around

[FFmpeg-devel] [PATCH v5 3/4] avcodec: enable usage of AV_EF_EXPLODE for subtitle encoders

2021-02-22 Thread Jan Ekström
From: Jan Ekström As currently it is the responsibility of the following subtitle encoder to validate the correctness of the incoming ASS dialog line. Signed-off-by: Jan Ekström --- libavcodec/avcodec.h | 5 - libavcodec/options_table.h | 4 ++-- libavcodec/version.h | 2 +- 3

[FFmpeg-devel] [PATCH v5 0/4] Initial implementation of TTML encoding/muxing

2021-02-22 Thread Jan Ekström
vutil/internal.h" were added. Jan Jan Ekström (3): ffprobe: switch to av_bprint_escape for XML escaping avcodec: enable usage of AV_EF_EXPLODE for subtitle encoders {avcodec,avformat}: add TTML encoder and muxer Stefano Sabatini (1): avutil/{avstring,bprint}: add XML escaping from ffprobe

[FFmpeg-devel] [PATCH v5 2/4] ffprobe: switch to av_bprint_escape for XML escaping

2021-02-22 Thread Jan Ekström
From: Jan Ekström Additionally update the result of the ffprobe XML writing test. Signed-off-by: Jan Ekström --- fftools/ffprobe.c | 32 +++- tests/ref/fate/ffprobe_xml | 2 +- 2 files changed, 12 insertions(+), 22 deletions(-) diff --git a/fftools

[FFmpeg-devel] [PATCH v5 1/4] avutil/{avstring, bprint}: add XML escaping from ffprobe to avutil

2021-02-22 Thread Jan Ekström
From: Stefano Sabatini Base escaping only escapes values required for base character data according to part 2.4 of XML, and if additional flags are added single and double quotes can additionally be escaped in order to handle single and double quoted attributes. --- libavutil/avstring.h | 14

[FFmpeg-devel] [PATCH] avfilter/vf_scale: reset color matrix in case of identity & non-RGB

2021-08-22 Thread Jan Ekström
Fixes passing through mismatching metadata from the input side when RGB input (from f.ex. H.264 or HEVC) gets converted to YCbCr. Fixes #9132 --- libavfilter/vf_scale.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index

Re: [FFmpeg-devel] [PATCH] dox/examples/encode_video: add explanations in comments.

2021-08-20 Thread Jan Ekström
On Mon, Aug 16, 2021 at 4:07 PM Nicolas George wrote: > > Signed-off-by: Nicolas George > --- Looks good to me with the dox->doc fixup you've already done in the commit message. Generally I've become accustomed to trying to push people to look at the transcode* examples since I've seen people

Re: [FFmpeg-devel] [PATCH v4 0/2] TTML in MP4, part 1

2021-08-23 Thread Jan Ekström
On Mon, Aug 16, 2021 at 3:26 PM Jan Ekström wrote: > > To keep it simpler this first part includes only non-fragmented use > cases if the built-in sample squashing is utilized. Contains the basic > mapping code as well as the function that writes out the squashed documents. > &g

[FFmpeg-devel] [PATCH 2/2] avcodec/libx265: improve full range flag setting logic

2021-08-17 Thread Jan Ekström
Unlike libx264, libx265 does not have a separate "unspecified"/"auto" default for color range, so we do always have to specify it. Thus, we are required to handle the RGB case on the libavcodec side to enable the correct value to be written out in in case of RGB content with unspecified color

[FFmpeg-devel] [PATCH 1/2] avcodec/libx264: leave full range flag unchanged if unknown

2021-08-17 Thread Jan Ekström
By default the x264 full range flag is set to -1. By not setting it to something else, we can let libx264 handle the RGB case. Additionally, change the preference order to user-specified range first, and then any fall-back logic left for the YUVJ pix_fmts. Fixes the capture part of #9374 ---

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: reset color matrix in case of identity & non-RGB

2021-08-26 Thread Jan Ekström
On Sun, Aug 22, 2021 at 11:55 PM Jan Ekström wrote: > > Fixes passing through mismatching metadata from the input side > when RGB input (from f.ex. H.264 or HEVC) gets converted to YCbCr. > > Fixes #9132 > --- > libavfilter/vf_scale.c | 9 + > 1 file changed,

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libx264: add support for setting chroma sample location

2021-08-26 Thread Jan Ekström
On Tue, Aug 24, 2021 at 12:47 AM Jan Ekström wrote: > > --- > libavcodec/libx264.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c > index d48e142e41..379c167e6f 100644 > --- a/libavcodec/libx264.c > +++ b/libav

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: reset color matrix in case of identity & non-RGB

2021-08-27 Thread Jan Ekström
On Sat, Aug 28, 2021 at 12:03 AM Michael Niedermayer wrote: > > On Fri, Aug 27, 2021 at 01:02:31AM +0300, Jan Ekström wrote: > > On Sun, Aug 22, 2021 at 11:55 PM Jan Ekström wrote: > > > > > > Fixes passing through mismatching metadata from the input side > >

[FFmpeg-devel] [PATCH] avfilter/vf_scale: set the RGB matrix coefficients in case of RGB

2021-08-28 Thread Jan Ekström
This fixes the passing through of non-RGB matrix from input to output when conversion from YCbCr to RGB happens. --- libavfilter/vf_scale.c | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/libavfilter/vf_scale.c b/libavfilter/vf_scale.c index

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libx265: add support for setting chroma sample location

2021-08-31 Thread Jan Ekström
On Tue, Aug 31, 2021 at 12:52 AM Jan Ekström wrote: > > On Sun, Aug 29, 2021 at 7:43 PM Jan Ekström wrote: > > > > Unlike libx264, libx265 does not handle the chroma format check > > on its own side, so in order to not write out values which are > > su

Re: [FFmpeg-devel] [PATCH v4 0/2] TTML in MP4, part 1

2021-08-25 Thread Jan Ekström
On Mon, Aug 23, 2021 at 11:31 AM Jan Ekström wrote: > > On Mon, Aug 16, 2021 at 3:26 PM Jan Ekström wrote: > > > > To keep it simpler this first part includes only non-fragmented use > > cases if the built-in sample squashing is utilized. Contains the basic

[FFmpeg-devel] [PATCH] avformat/{isom, mov, movenc}: add support for CMAF DASH roles

2021-08-23 Thread Jan Ekström
From: Jan Ekström This information is coded in a standard MP4 KindBox and utilizes the scheme and values as per the DASH role scheme defined in MPEG-DASH. Other schemes are technically allowed, but where multiple schemes define the same concepts, the DASH scheme should be utilized

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libx264: add support for setting chroma sample location

2021-08-29 Thread Jan Ekström
On Fri, Aug 27, 2021 at 12:58 AM Jan Ekström wrote: > > On Tue, Aug 24, 2021 at 12:47 AM Jan Ekström wrote: > > > > --- > > libavcodec/libx264.c | 2 ++ > > 1 file changed, 2 insertions(+) > > > > diff --git a/libavcodec/libx264.c b/libavcodec/libx264

[FFmpeg-devel] [PATCH v2 2/2] avcodec/libx265: add support for setting chroma sample location

2021-08-29 Thread Jan Ekström
Unlike libx264, libx265 does not handle the chroma format check on its own side, so in order to not write out values which are supposed to be ignored according to the specification, we limit the writing out of chroma sample location to 4:2:0 only. --- libavcodec/libx265.c | 13 + 1

[FFmpeg-devel] [PATCH 1/2] avcodec/libx265: only call av_pix_fmt_desc_get once in init

2021-08-29 Thread Jan Ekström
Now both current usages utilize an already found descriptor. --- libavcodec/libx265.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index b5c94b64a3..71affbf61b 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: set the RGB matrix coefficients in case of RGB

2021-08-29 Thread Jan Ekström
On Sun, Aug 29, 2021 at 9:21 PM Paul B Mahol wrote: > > probably fine if fate passes Yea, FATE passes :) . I think this stuff not being noticed until now is due to nothing checking the metadata values returned by vf_scale (since pix_fmt and actual logic is not changed at all with these output

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libx265: only call av_pix_fmt_desc_get once in init

2021-08-29 Thread Jan Ekström
On Sun, Aug 29, 2021 at 8:12 PM Paul B Mahol wrote: > > LGTM Thanks, applied this patch as 06ce821bc7622c1394c5179fb69cabf02dd24869 . Now it's just the chroma location coding bits. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libx265: add support for setting chroma sample location

2021-08-30 Thread Jan Ekström
On Sun, Aug 29, 2021 at 7:43 PM Jan Ekström wrote: > > Unlike libx264, libx265 does not handle the chroma format check > on its own side, so in order to not write out values which are > supposed to be ignored according to the specification, we limit > the writing out of chroma

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: set the RGB matrix coefficients in case of RGB

2021-08-30 Thread Jan Ekström
On Sun, Aug 29, 2021 at 10:05 PM Jan Ekström wrote: > > On Sun, Aug 29, 2021 at 9:21 PM Paul B Mahol wrote: > > > > probably fine if fate passes > > Yea, FATE passes :) . I think this stuff not being noticed until now > is due to nothing checking the metadata values re

[FFmpeg-devel] [PATCH v2 1/2] avformat/{isom, mov, movenc}: add support for CMAF DASH roles

2021-08-30 Thread Jan Ekström
From: Jan Ekström This information is coded in a standard MP4 KindBox and utilizes the scheme and values as per the DASH role scheme defined in MPEG-DASH. Other schemes are technically allowed, but where multiple schemes define the same concepts, the DASH scheme should be utilized

[FFmpeg-devel] [PATCH v2 0/2] Support for stream dispositions in MP4

2021-08-30 Thread Jan Ekström
unused variables causing additional warnings were removed. Best regards, Jan Jan Ekström (2): avformat/{isom,mov,movenc}: add support for CMAF DASH roles avformat/{isom,movenc}: add kind box compatibility mode for Unified Origin libavformat/isom.c| 32

[FFmpeg-devel] [PATCH v2 2/2] avformat/{isom, movenc}: add kind box compatibility mode for Unified Origin

2021-08-30 Thread Jan Ekström
From: Jan Ekström Unfortunately the current production versions of this software do not 100% adhere to the CMAF specification, and have decided to utilize the HTML5 media track identifier for audio descriptions. This way the default mode of operation is according to the CMAF specification

[FFmpeg-devel] [PATCH v4 0/2] TTML in MP4, part 1

2021-08-16 Thread Jan Ekström
to deduplicate AVFormatContext cleanup. Jan Jan Ekström (2): avformat/ttml: split TTML paragraph based or not check into header avformat/movenc: add support for TTML muxing libavformat/Makefile | 2 +- libavformat/isom.h | 3 + libavformat

[FFmpeg-devel] [PATCH v4 1/2] avformat/ttml: split TTML paragraph based or not check into header

2021-08-16 Thread Jan Ekström
From: Jan Ekström This way it can be re-utilized in movenc. Signed-off-by: Jan Ekström --- libavformat/ttmlenc.c | 9 ++--- libavformat/ttmlenc.h | 39 +++ 2 files changed, 41 insertions(+), 7 deletions(-) create mode 100644 libavformat/ttmlenc.h

[FFmpeg-devel] [PATCH v4 2/2] avformat/movenc: add support for TTML muxing

2021-08-16 Thread Jan Ekström
From: Jan Ekström Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') methods. This initial version also foregoes fragmentation support in case the built-in sample squashing is to be utilized, as this eases the initial review. Additionally, add basic tests for both muxing modes

[FFmpeg-devel] [PATCH] avformat/isom_tags: prefer in24 for 24bit PCM in MOV

2021-08-14 Thread Jan Ekström
In 1c42fd93236e7869ef4d9fe3650dd3e951387321 the ipcm identifier was added in order to demux additional raw audio from Sony MP4 files. Unfortunately, it was not noticed that this same list is utilized for muxing as well, thus causing ipcm to get preferred compared to the identifier officially

Re: [FFmpeg-devel] [PATCH] avformat/isom_tags: prefer in24 for 24bit PCM in MOV

2021-08-14 Thread Jan Ekström
On Sat, Aug 14, 2021 at 8:25 PM Paul B Mahol wrote: > > Patch is OK, apply at will. Thanks, applied as 087fbfe5bc2272aa1cfd9f4c49438436b68a1ddc . Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavformat/isom_tags.c: add ipcm to list of tags

2021-08-14 Thread Jan Ekström
On Sat, Aug 14, 2021 at 7:43 PM Andriy Gelman wrote: > > On Sat, 14. Aug 12:14, Stephen Hutchinson wrote: > > ffmpeg | branch: master | Stephen Hutchinson | Wed Jul > > 14 20:16:41 2021 -0400| [1c42fd93236e7869ef4d9fe3650dd3e951387321] | > > committer: Paul B Mahol > > > >

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libx265: improve full range flag setting logic

2021-08-18 Thread Jan Ekström
On Wed, Aug 18, 2021 at 4:36 AM myp...@gmail.com wrote: > > On Wed, Aug 18, 2021 at 5:01 AM Jan Ekström wrote: > > > > Unlike libx264, libx265 does not have a separate "unspecified"/"auto" > > default for color range, so we do always have to spe

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/libx264: leave full range flag unchanged if unknown

2021-08-18 Thread Jan Ekström
On Wed, Aug 18, 2021 at 10:00 AM Paul B Mahol wrote: > > lgtm Thanks, applied as 7ca71b79f2b3256a0eef1a099b857ac9e4017e36 . Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe,

[FFmpeg-devel] [PATCH 2/2] avcodec/libx265: add support for setting chroma sample location

2021-08-23 Thread Jan Ekström
--- libavcodec/libx265.c | 8 1 file changed, 8 insertions(+) diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c index b5c94b64a3..c58882170b 100644 --- a/libavcodec/libx265.c +++ b/libavcodec/libx265.c @@ -210,6 +210,14 @@ static av_cold int libx265_encode_init(AVCodecContext

[FFmpeg-devel] [PATCH 1/2] avcodec/libx264: add support for setting chroma sample location

2021-08-23 Thread Jan Ekström
--- libavcodec/libx264.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/libx264.c b/libavcodec/libx264.c index d48e142e41..379c167e6f 100644 --- a/libavcodec/libx264.c +++ b/libavcodec/libx264.c @@ -870,6 +870,8 @@ static av_cold int X264_init(AVCodecContext *avctx)

[FFmpeg-devel] [PATCH] tests/fate: move TTML-in-MP4 tests from subtitles.mak to mov.mak

2021-08-25 Thread Jan Ekström
subtitles.mak utilizes a more strict comparator and - to be honest - the tests feel more at home in this location. --- tests/fate/mov.mak | 4 tests/fate/subtitles.mak| 4 tests/ref/fate/{sub-ttml-mp4-dfxp =>

<    2   3   4   5   6   7   8   9   10   11   >