Re: [FFmpeg-devel] [PATCH] tests/fate: move TTML-in-MP4 tests from subtitles.mak to mov.mak

2021-08-25 Thread Jan Ekström
On Wed, Aug 25, 2021 at 10:58 PM Martin Storsjö wrote: > > On Wed, 25 Aug 2021, Jan Ekström wrote: > > > subtitles.mak utilizes a more strict comparator and - to be honest - > > the tests feel more at home in this location. > > --- > > LGTM, although your co

Re: [FFmpeg-devel] [PATCH v2 2/2] avcodec/libx265: add support for setting chroma sample location

2021-09-01 Thread Jan Ekström
On Wed, Sep 1, 2021 at 12:11 AM Jan Ekström wrote: > > On Tue, Aug 31, 2021 at 12:52 AM Jan Ekström wrote: > > > > On Sun, Aug 29, 2021 at 7:43 PM Jan Ekström wrote: > > > > > > Unlike libx264, libx265 does not handle the chroma format check > > >

Re: [FFmpeg-devel] [PATCH] avfilter/vf_scale: set the RGB matrix coefficients in case of RGB

2021-09-01 Thread Jan Ekström
On Tue, Aug 31, 2021 at 1:14 AM Jan Ekström wrote: > > On Sun, Aug 29, 2021 at 10:05 PM Jan Ekström wrote: > > > > On Sun, Aug 29, 2021 at 9:21 PM Paul B Mahol wrote: > > > > > > probably fine if fate passes > > > > Yea, FATE passes :) . I think t

Re: [FFmpeg-devel] [PATCH v2 0/2] Support for stream dispositions in MP4

2021-09-06 Thread Jan Ekström
On Mon, Aug 30, 2021 at 2:14 PM Jan Ekström wrote: > > First patch implements the CMAF specified way of flagging what in FFmpeg > are are called stream dispositions. Other identifiers such as HTML media track > kinds are allowed, but if there is a DASH identifier for somethin

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/libsvtav1: support constant quality mode

2021-09-16 Thread Jan Ekström
On Thu, Sep 16, 2021 at 1:55 PM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- For the record, Christopher Degawa also posted something similar (https://patchwork.ffmpeg.org/project/ffmpeg/patch/20210310224859.1726693-1-c...@randomderp.com/), and I finally recently had gotten

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/libsvtav1: make intra_refresh_type configurable

2021-09-16 Thread Jan Ekström
Hi On Thu, Sep 16, 2021 at 1:54 PM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- I think something like: avcodec/libsvtav1: make coded GOP type configurable Might be a bit better as a commit message? > libavcodec/libsvtav1.c | 4 +++- > 1 file changed, 3 insertions(+), 1

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/ttml: split TTML paragraph based or not check into header

2021-08-09 Thread Jan Ekström
On Mon, Aug 2, 2021 at 3:54 PM Andreas Rheinhardt wrote: > > Jan Ekström: > > From: Jan Ekström > > > > This way it can be re-utilized in movenc. > > > > Signed-off-by: Jan Ekström > > --- > > libavformat/ttmlenc.

Re: [FFmpeg-devel] [PATCH v3 2/2] avformat/movenc: add support for TTML muxing

2021-08-09 Thread Jan Ekström
On Thu, Aug 5, 2021 at 10:33 PM Andreas Rheinhardt wrote: > > Jan Ekström: > > From: Jan Ekström > > > > Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') > > methods. This initial version also foregoes fragmentation support > > i

Re: [FFmpeg-devel] [PATCH] libsvtav1: pass color description info

2021-07-30 Thread Jan Ekström
On Fri, Jul 23, 2021 at 5:02 AM Christopher Degawa wrote: > > these fields are only available past svt-av1 0.8.7 > > Signed-off-by: Christopher Degawa > --- > libavcodec/libsvtav1.c | 20 > 1 file changed, 20 insertions(+) > > diff --git a/libavcodec/libsvtav1.c

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse 3gpp titl from media or track udta

2021-08-01 Thread Jan Ekström
On Sat, Jul 24, 2021 at 9:48 PM Jan Ekström wrote: > > On Wed, Jul 21, 2021 at 8:30 PM Jan Ekström wrote: > > > > On Wed, Jul 21, 2021 at 8:28 PM Jan Ekström wrote: > > > > > > Seems to be: > > > * Utilized by Handbrake for track titling >

Re: [FFmpeg-devel] [PATCH] libsvtav1: pass color description info

2021-08-02 Thread Jan Ekström
On Fri, Jul 30, 2021 at 9:51 PM Christopher Degawa wrote: > > On Fri, Jul 30, 2021 at 4:48 AM Jan Ekström wrote: > > > On Fri, Jul 23, 2021 at 5:02 AM Christopher Degawa > > wrote: > > > +#ifndef SVTAV1_MAKE_VERSION > > > +#define SVTAV1_MAKE_V

[FFmpeg-devel] [PATCH v3 3/5] avformat/{aviobuf, avio_internal}: add max_len argument to ff_read_string_to_bprint_overwrite

2021-09-20 Thread Jan Ekström
From: Jan Ekström This is especially useful when reading things such as null-terminated strings from MOV/MP4-likes, where the size of the box is known, but not the exact size of the string. Signed-off-by: Jan Ekström --- libavformat/avio_internal.h | 13 ++--- libavformat/aviobuf.c

[FFmpeg-devel] [PATCH v3 2/5] avformat/{aviobuf, avio_internal}: add ff_read_string_to_bprint_overwrite

2021-09-20 Thread Jan Ekström
From: Jan Ekström For now, same as ff_read_line_to_bprint_overwrite, but reads until the end of a null-terminated string. Signed-off-by: Jan Ekström --- libavformat/avio_internal.h | 12 libavformat/aviobuf.c | 5 + 2 files changed, 17 insertions(+) diff --git

[FFmpeg-devel] [PATCH v3 0/5] Support for stream dispositions in MP4

2021-09-20 Thread Jan Ekström
e can drop it from being upstreamed, but at least I wanted to bring it up :) . The compatibility mode is not the default, so it should also not proliferate such behavior. Best regards, Jan Jan Ekström (5): avformat/aviobuf: add a full string reading mode to read_line_to_bprint avforma

[FFmpeg-devel] [PATCH v3 4/5] avformat/{isom, mov, movenc}: add support for CMAF DASH roles

2021-09-20 Thread Jan Ekström
From: Jan Ekström This information is coded in a standard MP4 KindBox and utilizes the scheme and values as per the DASH role scheme defined in MPEG-DASH. Other schemes are technically allowed, but where multiple schemes define the same concepts, the DASH scheme should be utilized

[FFmpeg-devel] [PATCH v3 1/5] avformat/aviobuf: add a full string reading mode to read_line_to_bprint

2021-09-20 Thread Jan Ekström
From: Jan Ekström Additionally: * rename it to read_string_to_bprint * split most of ff_read_line_to_bprint_overwrite into an internal function which can then be utilized to implement other functionality without duplicating code. Signed-off-by: Jan Ekström --- libavformat/aviobuf.c | 24

[FFmpeg-devel] [PATCH v3 5/5] avformat/{isom, movenc}: add kind box compatibility mode for Unified Origin

2021-09-20 Thread Jan Ekström
From: Jan Ekström Unfortunately the current production versions of this software do not 100% adhere to the CMAF specification, and have decided to utilize the HTML5 media track identifier for audio descriptions. This way the default mode of operation is according to the CMAF specification

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-23 Thread Jan Ekström
On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa wrote: > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > wrote: > > > > > > > On Fri, Sep 17, 2021 at 9:28 PM wrote: > > > >> From: Limin Wang > >> > >> Signed-off-by: Limin Wang > >> > > As a note, I personally favor this patch over

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread Jan Ekström
On Sat, Sep 25, 2021 at 4:06 AM wrote: > > On Thu, Sep 23, 2021 at 09:45:48AM -0400, Christopher Degawa wrote: > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > > wrote: > > > > > > > > > > > On Fri, Sep 17, 2021 at 9:28 PM wrote: > > > > > >> From: Limin Wang > > >> > > >>

Re: [FFmpeg-devel] [PATCH v2 4/6] avcodec/libsvtav1: Fix CQP mode doesn't work as expection

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- Commit message should probably be something along the lines of """ avcodec/libsvtav1: properly enforce CQP mode when set in wrapper SVT-AV1 seems to have switched their default from CQP to CRF in

Re: [FFmpeg-devel] [PATCH v2 5/6] avcodec/libsvtav1: Fix the max range for rc_mode

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- Probably something like "avcodec/libsvtav1: fix value range for rc_mode" is a bit better as a commit message? > libavcodec/libsvtav1.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >

Re: [FFmpeg-devel] [PATCH v2 2/6] avcodec/libsvtav1: make coded GOP type configurable

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Reviewed-by: Jan Ekström > Signed-off-by: Limin Wang I still hate how SVT-AV1 has no enum/defines for these, but so be it :) LGTM. Jan ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

2021-09-25 Thread Jan Ekström
On Sat, Sep 25, 2021 at 3:49 PM wrote: > > On Sat, Sep 25, 2021 at 01:00:20PM +0300, Jan Ekström wrote: > > On Sat, Sep 18, 2021 at 4:27 AM wrote: > > > > > > From: Limin Wang > > > > > > Signed-off-by: Limin Wang > > > > I'd p

Re: [FFmpeg-devel] [PATCH v2 1/6] avcodec/libsvtav1: Fix override setting of caps_internal

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang I'd prefer the wording "fix duplicate definition of caps_internal", but otherwise this patch is LGTM. Good catch. Jan ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2 3/6] doc: update for libsvtav1 encoder

2021-09-25 Thread Jan Ekström
On Sat, Sep 18, 2021 at 4:27 AM wrote: > > From: Limin Wang > > Signed-off-by: Limin Wang > --- Hi, "doc/encoders: add available values for libsvtav1 options" would possibly be better as a commit message? > doc/encoders.texi | 44 > 1 file

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread Jan Ekström
On Thu, Sep 23, 2021 at 6:08 PM wrote: > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > > On Thu, Sep 23, 2021 at 4:46 PM Christopher Degawa > > wrote: > > > > > > On Sun, Sep 19, 2021 at 2:02 PM Christopher Degawa > > > wrote:

Re: [FFmpeg-devel] [PATCH v2 6/6] avcodec/libsvtav1: support constant quality mode

2021-09-25 Thread Jan Ekström
On Sat, Sep 25, 2021 at 4:35 PM wrote: > > On Sat, Sep 25, 2021 at 03:35:53PM +0300, Jan Ekström wrote: > > On Thu, Sep 23, 2021 at 6:08 PM wrote: > > > > > > On Thu, Sep 23, 2021 at 05:11:49PM +0300, Jan Ekström wrote: > > > > On Thu, Sep 23, 2021 at

Re: [FFmpeg-devel] [PATCH 1/1] mov: read track title

2021-10-11 Thread Jan Ekström
On Mon, Oct 11, 2021 at 6:23 AM Dong Nguyen wrote: > > this change fix issue [9438](https://trac.ffmpeg.org/ticket/9438) > > after commit da9cc22d5bd5f59756c2037b02966376da2cf323 > ffmpeg is able to write track title metadata to mov/mp4 format file > but it is not able to read back the metadata >

Re: [FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-10-11 Thread Jan Ekström
On Mon, Oct 4, 2021 at 12:12 PM Jan Ekström wrote: > > On Mon, Oct 4, 2021 at 1:06 AM Michael Niedermayer > wrote: > > > > On Mon, Oct 04, 2021 at 12:25:26AM +0300, Jan Ekström wrote: > > > On Sat, Oct 2, 2021 at 2:51 PM Michael Niedermayer > > > wrot

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Jan Ekström
On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer wrote: > > On Wed, Oct 20, 2021 at 12:02:13AM +0300, Jan Ekström wrote: > > On Mon, Oct 18, 2021 at 3:47 PM Jan Ekström wrote: > > > > > > Originally added as a private entry in commit > > > 3f75e5116b

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Jan Ekström
On Thu, Oct 21, 2021 at 11:49 PM Michael Niedermayer wrote: > > On Thu, Oct 21, 2021 at 08:48:35PM +0300, Jan Ekström wrote: > > On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer > > wrote: > > > > > > On Wed, Oct 20, 2021 at 12:02:13AM +0300, Jan Ekström

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-21 Thread Jan Ekström
On Fri, Oct 22, 2021 at 12:21 AM Jan Ekström wrote: > > On Thu, Oct 21, 2021 at 11:49 PM Michael Niedermayer > wrote: > > > > On Thu, Oct 21, 2021 at 08:48:35PM +0300, Jan Ekström wrote: > > > On Thu, Oct 21, 2021 at 8:26 PM Michael Niedermayer > > > wrot

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-19 Thread Jan Ekström
On Mon, Oct 18, 2021 at 3:47 PM Jan Ekström wrote: > > Originally added as a private entry in commit > 3f75e5116b900f1428aa13041fc7d6301bf1988a, but its grouping with > the comment noting its private state was missed during merging of > the field from Libav (most likely due to an a

[FFmpeg-devel] [PATCH v3 3/3] avformat/avio{, buf}: introduce public AVIOContext::bytes_{read, written}

2021-10-18 Thread Jan Ekström
Such fields can be seen as generally useful in cases where the API user is not implementing custom AVIO callbacks, but still would like to know if data is being read or written out, such as in case data is being read from input but no AVPacket has been received yet. --- doc/APIchanges

[FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-18 Thread Jan Ekström
Originally added as a private entry in commit 3f75e5116b900f1428aa13041fc7d6301bf1988a, but its grouping with the comment noting its private state was missed during merging of the field from Libav (most likely due to an already existing field in between). --- doc/APIchanges| 6 ++

[FFmpeg-devel] [PATCH v3 1/3] avformat/avio: privatize point of truth for AVIOContext::written

2021-10-18 Thread Jan Ekström
Looking at 3f75e5116b900f1428aa13041fc7d6301bf1988a, the field was supposed to be private, but during merging the field and the group that had the comment about it got separated. Thus, move the actual privately utilized state of this variable into the private FFIOContext. Additionally, name the

[FFmpeg-devel] [PATCH v3 0/3] introduce public AVIOContext::bytes_{read, written}

2021-10-18 Thread Jan Ekström
regards, Jan Jan Ekström (3): avformat/avio: privatize point of truth for AVIOContext::written avformat/avio{,buf}: deprecate AVIOContext::written avformat/avio{,buf}: introduce public AVIOContext::bytes_{read,written} doc/APIchanges | 9 + libavformat/avio.h

[FFmpeg-devel] [PATCH v2 2/3] avformat/avio{, buf}: introduce public AVIOContext::bytes_{read, written}

2021-10-13 Thread Jan Ekström
Such fields can be seen as generally useful in cases where the API user is not implementing custom AVIO callbacks, but still would like to know if data is being read or written out, such as in case data is being read from input but no AVPacket has been received yet. --- doc/APIchanges| 3

[FFmpeg-devel] [PATCH v2 1/3] avformat/avio: privatize point of truth for AVIOContext::written

2021-10-13 Thread Jan Ekström
Looking at 3f75e5116b900f1428aa13041fc7d6301bf1988a, the field was supposed to be private, but during merging the field and the group that had the comment about it got separated. Thus, move the actual privately utilized state of this variable into the private FFIOContext. ---

[FFmpeg-devel] [PATCH v2 0/3] introduce public AVIOContext::bytes_{read, written}

2021-10-13 Thread Jan Ekström
that instead. [1] http://git.videolan.org/?p=ffmpeg.git;a=commit;h=3f75e5116b900f1428aa13041fc7d6301bf1988a Best regards, Jan Jan Ekström (3): avformat/avio: privatize point of truth for AVIOContext::written avformat/avio{,buf}: introduce public AVIOContext::bytes_{read,written} avformat/avio

[FFmpeg-devel] [PATCH v2 3/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-13 Thread Jan Ekström
Originally added as a private entry in commit 3f75e5116b900f1428aa13041fc7d6301bf1988a, but its grouping with the comment noting its private state was missed during merging of the field from Libav (most likely due to an already existing field in between). Users should migrate to the public field

[FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-09-26 Thread Jan Ekström
Such a field can be seen as generally useful in cases where the API user is not implementing custom AVIO callbacks, but still would like to know if data is being read even if AVPackets are not being returned. --- Originally I thought about making an accessor for the private field, to not grow the

[FFmpeg-devel] [PATCH] avformat/isom: enable TTML demuxing from MP4-likes

2021-09-26 Thread Jan Ekström
As ff_codec_movsubtitle_tags is shared between demuxing and muxing, the muxing parts have to go in before demuxing in order to not generate invalid media, as adding an identifier to this list enables muxing into QTFF/MOV. --- libavformat/isom.c | 2 ++

Re: [FFmpeg-devel] [PATCH v2] avformat/aacdec: enable probesize-sized resyncs mid-stream

2021-09-28 Thread Jan Ekström
On Tue, Sep 28, 2021 at 10:55 PM James Almer wrote: > > On 9/27/2021 7:47 PM, Jan Ekström wrote: > > Before adts_aac_resync would always bail out after probesize amount > > of bytes had been progressed from the start of the input. > > > > Now just query the current

Re: [FFmpeg-devel] [PATCH v3 0/5] Support for stream dispositions in MP4

2021-09-27 Thread Jan Ekström
On Mon, Sep 20, 2021 at 6:00 PM Jan Ekström wrote: > > Compared to v2: > * aviobuf changes to make a function useful in MP4 null-delimited string > parsing into AVBPrint. > ** Extended read_line_to_bprint to be a more generic read_string_to_bprint. > ** Added a maxim

Re: [FFmpeg-devel] [PATCH] lavf/movenc: Write 'dby1' minor brand if Dolby content is being muxed to MP4

2021-09-29 Thread Jan Ekström
On Tue, Sep 28, 2021 at 5:31 PM Derek Buitenhuis wrote: > > This is as per: >* mp4ra: http://mp4ra.org/#/brands >* Dolby Vision muxing spec (which is public): > >

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Jan Ekström
On Thu, Oct 7, 2021 at 12:13 PM Jan Ekström wrote: > > On Thu, Oct 7, 2021 at 11:09 AM Steven Liu wrote: > > > > Steven Liu 于2021年10月7日周四 上午10:41写道: > > > > > > Michael Niedermayer 于2021年10月6日周三 下午5:35写道: > > > > > > > > Hi all >

Re: [FFmpeg-devel] point releases

2021-10-07 Thread Jan Ekström
On Thu, Oct 7, 2021 at 11:09 AM Steven Liu wrote: > > Steven Liu 于2021年10月7日周四 上午10:41写道: > > > > Michael Niedermayer 于2021年10月6日周三 下午5:35写道: > > > > > > Hi all > > > > > > I do plan to make releases from > > > 4.4, 4.2, 4.1, 4.0, 3.4, 3.2, 2.8 branches > > Why not include 4.3 or have some

Re: [FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-10-02 Thread Jan Ekström
On Sat, Oct 2, 2021 at 1:32 PM Michael Niedermayer wrote: > > On Sun, Sep 26, 2021 at 06:48:18PM +0300, Jan Ekström wrote: > > Such a field can be seen as generally useful in cases where the > > API user is not implementing custom AVIO callbacks, but still would > > like

Re: [FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-10-03 Thread Jan Ekström
On Mon, Oct 4, 2021 at 12:25 AM Jan Ekström wrote: > > On Sat, Oct 2, 2021 at 2:51 PM Michael Niedermayer > wrote: > > > > On Sat, Oct 02, 2021 at 02:42:52PM +0300, Jan Ekström wrote: > > > On Sat, Oct 2, 2021 at 1:32 PM Michael Niedermayer > > > wrot

Re: [FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-10-03 Thread Jan Ekström
On Sat, Oct 2, 2021 at 2:51 PM Michael Niedermayer wrote: > > On Sat, Oct 02, 2021 at 02:42:52PM +0300, Jan Ekström wrote: > > On Sat, Oct 2, 2021 at 1:32 PM Michael Niedermayer > > wrote: > > > > > > On Sun, Sep 26, 2021 at 06:48:18PM +0300, Jan Ekström wro

Re: [FFmpeg-devel] [PATCH v3 0/5] Support for stream dispositions in MP4

2021-10-04 Thread Jan Ekström
On Mon, Sep 27, 2021 at 1:53 PM Jan Ekström wrote: > > On Mon, Sep 20, 2021 at 6:00 PM Jan Ekström wrote: > > > > Compared to v2: > > * aviobuf changes to make a function useful in MP4 null-delimited string > > parsing into AVBPrint. > > ** Extended read

Re: [FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-10-01 Thread Jan Ekström
On Sun, Sep 26, 2021 at 6:48 PM Jan Ekström wrote: > > Such a field can be seen as generally useful in cases where the > API user is not implementing custom AVIO callbacks, but still would > like to know if data is being read even if AVPackets are not being > returned. &g

Re: [FFmpeg-devel] [PATCH] avformat/avio{, buf}: introduce public AVIOContext::bytes_read

2021-10-04 Thread Jan Ekström
On Mon, Oct 4, 2021 at 1:06 AM Michael Niedermayer wrote: > > On Mon, Oct 04, 2021 at 12:25:26AM +0300, Jan Ekström wrote: > > On Sat, Oct 2, 2021 at 2:51 PM Michael Niedermayer > > wrote: > > > > > > On Sat, Oct 02, 2021 at 02:42:52PM +0300, Jan Ekström wro

[FFmpeg-devel] [PATCH] avformat/aacdec: enable probesize-sized resyncs mid-file

2021-09-27 Thread Jan Ekström
Before adts_aac_resync would always bail out after probesize amount of bytes had been progressed from the start of the input. Add an argument for the start position, and set it to zero when reading the header (which should happen in the beginning) to mimic previous behavior of going only up to

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: enable probesize-sized resyncs mid-file

2021-09-27 Thread Jan Ekström
On Tue, Sep 28, 2021 at 1:34 AM James Almer wrote: > > On 9/27/2021 6:31 PM, Jan Ekström wrote: > > Before adts_aac_resync would always bail out after probesize amount > > of bytes had been progressed from the start of the input. > > > > Add an argument for the star

[FFmpeg-devel] [PATCH v2] avformat/aacdec: enable probesize-sized resyncs mid-stream

2021-09-27 Thread Jan Ekström
Before adts_aac_resync would always bail out after probesize amount of bytes had been progressed from the start of the input. Now just query the current position when entering resync, and at most advance probesize amount of data from that start position. Fixes #9433 --- libavformat/aacdec.c | 4

Re: [FFmpeg-devel] [PATCH v2 1/4] avcodec/mmaldec: use decoupled dataflow

2021-09-24 Thread Jan Ekström
On Fri, Sep 24, 2021 at 12:06 PM Ho Ming Shun wrote: > > MMAL is an fundamentally an asynchronous decoder, which was a bad fit > for the legacy dataflow API. Often multiple packets are enqueued before > a flood of frames are returned from MMAL. > > The previous lockstep dataflow meant that any

Re: [FFmpeg-devel] [PATCH v3 0/3] introduce public AVIOContext::bytes_{read, written}

2021-10-24 Thread Jan Ekström
On Mon, Oct 18, 2021 at 3:47 PM Jan Ekström wrote: > > Changes compared to v2: > * Written was actually written_size, so it did not take into account any > writes after a seek-back. Thus an initial attempt at implementing > bytes_written was made. > > After a brief di

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-22 Thread Jan Ekström
On Fri, Oct 22, 2021 at 1:13 AM Michael Niedermayer wrote: > > On Fri, Oct 22, 2021 at 12:32:18AM +0300, Jan Ekström wrote: > > On Fri, Oct 22, 2021 at 12:21 AM Jan Ekström wrote: > > > > > > On Thu, Oct 21, 2021 at 11:49 PM Michael Niedermayer > > > wrot

[FFmpeg-devel] [PATCH] tests: add test for ffmpeg's fix_sub_duration feature

2021-12-20 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- tests/fate/ffmpeg.mak | 8 ++ tests/ref/fate/ffmpeg-fix_sub_duration | 40 ++ 2 files changed, 48 insertions(+) create mode 100644 tests/ref/fate/ffmpeg-fix_sub_duration diff --git a/tests/fate

[FFmpeg-devel] [PATCH v2] tests: add test for ffmpeg's fix_sub_duration feature

2021-12-20 Thread Jan Ekström
From: Jan Ekström Signed-off-by: Jan Ekström --- tests/fate/ffmpeg.mak | 11 + tests/ref/fate/ffmpeg-fix_sub_duration | 31 ++ 2 files changed, 42 insertions(+) create mode 100644 tests/ref/fate/ffmpeg-fix_sub_duration diff --git a/tests/fate

[FFmpeg-devel] [PATCH 1/2] ffmpeg: refactor post-decoding steps for subtitles into a function

2021-12-20 Thread Jan Ekström
From: Jan Ekström This enables us to later call this when generating additional subtitles for splitting purposes. Signed-off-by: Jan Ekström --- fftools/ffmpeg.c | 50 1 file changed, 29 insertions(+), 21 deletions(-) diff --git a/fftools

[FFmpeg-devel] [PATCH 2/2] ffmpeg: add video heartbeat capability to fix_sub_duration

2021-12-20 Thread Jan Ekström
From: Jan Ekström Splits the currently handled subtitle at random access point packets that can be configured to follow a specific output stream. This way the subtitle - which is known to be shown at this time can be split and passed to muxer before its full duration is yet known. Signed-off

[FFmpeg-devel] [PATCH v3] tests: add test for ffmpeg's fix_sub_duration feature

2021-12-21 Thread Jan Ekström
From: Jan Ekström This long-existing feature calculates subtitle durations by keeping it around until the following subtitle is decoded, and then utilizes the following subtitle's pts as the end point of the previous one. Signed-off-by: Jan Ekström --- tests/fate/ffmpeg.mak

Re: [FFmpeg-devel] [PATCH] lavf/tls_mbedtls: fix handling of tls_verify=0

2021-12-30 Thread Jan Ekström
On Mon, Dec 13, 2021 at 10:55 PM sfan5 wrote: > > If ca_file was set, setting tls_verify=0 would not actually disable > verification. Applied to master as 65197e9c98f46a79dd02c993cfcb0e70f65878cf . Jan ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] lavc/mediacodecdec: set codec profile and level from extradata for H264+HEVC

2021-12-30 Thread Jan Ekström
On Mon, Dec 13, 2021 at 10:56 PM sfan5 wrote: > > This value is later passed to MediaCodec and checked at decoder init. > Notably decoding of 10-bit streams before this commit would "work" without > returning errors but only return garbage output (on most Android devices). Applied as

Re: [FFmpeg-devel] [PATCH 16/17] fftools/ffmpeg_opt: Fix copyinkf option name in warning message

2021-11-10 Thread Jan Ekström
On Tue, Nov 9, 2021 at 8:05 PM Andreas Rheinhardt wrote: > > Signed-off-by: Andreas Rheinhardt LGTM. Jan ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or

Re: [FFmpeg-devel] [PATCH 17/17] fftools/ffmpeg_opt: Apply copyinkf for all stream types

2021-11-10 Thread Jan Ekström
On Tue, Nov 9, 2021 at 8:05 PM Andreas Rheinhardt wrote: > > The earlier code has ignored it for all stream types except > video and subtitles, probably because audio was presumed > to only consist of keyframes. Yet this assumption is not true > for e.g. TrueHD. > > Signed-off-by: Andreas

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_zscale: fix mapping of zimg_chroma_location_e to AVChromaLocation

2021-10-27 Thread Jan Ekström
The AVChromaLocation values are one higher than zimg's, not one lower as the undefined value is set to zero (as opposed to zimg's -1). --- libavfilter/vf_zscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_zscale.c b/libavfilter/vf_zscale.c index

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_zscale: deduplicate output color information setting

2021-10-27 Thread Jan Ekström
This way a piece of logic is not missed in one location or the other, such as the case with chroma location outside the if. --- libavfilter/vf_zscale.c | 45 ++--- 1 file changed, 20 insertions(+), 25 deletions(-) diff --git a/libavfilter/vf_zscale.c

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/vf_zscale: fix mapping of zimg_chroma_location_e to AVChromaLocation

2021-10-28 Thread Jan Ekström
On Thu, Oct 28, 2021 at 1:25 AM Paul B Mahol wrote: > > probably fine This can be verified by specifying - say - chromal topleft, and seeing that the ffmpeg.c Output: bit right now would end up being "left" (most likely). While if you apply this, you should get "topleft". Technically if the

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zscale: deduplicate output color information setting

2021-10-28 Thread Jan Ekström
On Thu, Oct 28, 2021 at 1:24 AM Paul B Mahol wrote: > > lgtm Thanks for the reviews, applied these patches as cd1d09e81b53d47380b494acd3432fd4abb3c17b and 27c0dd55609daf440a7744e96ac20c119bbeb80f . Jan ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-22 Thread Jan Ekström
On Sat, Oct 23, 2021 at 12:11 AM Jan Ekström wrote: > > On Fri, Oct 22, 2021 at 11:26 PM Michael Niedermayer > wrote: > > > > On Fri, Oct 22, 2021 at 08:42:14PM +0300, Jan Ekström wrote: > > > On Fri, Oct 22, 2021 at 6:16 PM Michael Niedermayer > > > wrot

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-22 Thread Jan Ekström
On Fri, Oct 22, 2021 at 11:26 PM Michael Niedermayer wrote: > > On Fri, Oct 22, 2021 at 08:42:14PM +0300, Jan Ekström wrote: > > On Fri, Oct 22, 2021 at 6:16 PM Michael Niedermayer > > wrote: > > > > > > On Fri, Oct 22, 2021 at 12:20:19PM +0300, Jan Ekström

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-22 Thread Jan Ekström
On Sat, Oct 23, 2021 at 12:13 AM Jan Ekström wrote: > > On Sat, Oct 23, 2021 at 12:11 AM Jan Ekström wrote: > > > > On Fri, Oct 22, 2021 at 11:26 PM Michael Niedermayer > > wrote: > > > > > > On Fri, Oct 22, 2021 at 08:42:14PM +0300, Jan Ekström wrot

Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add Dolby Vision RPU side data type

2021-10-22 Thread Jan Ekström
On Thu, Oct 21, 2021 at 4:49 PM Derek Buitenhuis wrote: > > Signed-off-by: Derek Buitenhuis > --- > All known encoders, etc. expect RPUs in this format, to my knowledge. > (There is no spec for parsing the RPUs, even privately, and not a single > piece of software that would benefit from that

Re: [FFmpeg-devel] [PATCH v3 2/3] avformat/avio{, buf}: deprecate AVIOContext::written

2021-10-22 Thread Jan Ekström
On Fri, Oct 22, 2021 at 6:16 PM Michael Niedermayer wrote: > > On Fri, Oct 22, 2021 at 12:20:19PM +0300, Jan Ekström wrote: > > On Fri, Oct 22, 2021 at 1:13 AM Michael Niedermayer > > wrote: > > > > > > On Fri, Oct 22, 2021 at 12:32:18AM +0300, Jan Ekström

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

2021-10-27 Thread Jan Ekström
On Thu, Oct 14, 2021 at 5:31 PM wrote: > > On Thu, Oct 14, 2021 at 10:12:05AM -0400, quietvoid wrote: > > On Thu, Oct 14, 2021 at 9:52 AM wrote: > > > > > On Thu, Oct 14, 2021 at 09:45:45AM -0400, quietvoid wrote: > > > > On Thu, Oct 14, 2021 at 9:36 AM wrote: > > > > > > > > > On Thu, Oct 14,

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/hevcdec: Export Dolby Vision RPUs as side data

2021-10-23 Thread Jan Ekström
On Sat, Oct 23, 2021 at 9:16 PM James Almer wrote: > > On 10/23/2021 2:52 PM, Derek Buitenhuis wrote: > > On 10/23/2021 3:18 PM, James Almer wrote: > >> 0x7c01 is just the NAL header that signals type 62, nuh_layer_id 0 and > >> nuh_temporal_id 0. > >> > >> forbidden_zero_bit= 0 > >>

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse 3gpp titl from media or track udta

2021-07-21 Thread Jan Ekström
On Wed, Jul 21, 2021 at 12:10 AM Jan Ekström wrote: > > Seems to be: > * Utilized by Handbrake for track titling > * Actually defined as "title for the media" > > Definition from 3GPP TS 26.244 follows: > > Field TypeDetails

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/movenc: add support for TTML muxing

2021-07-21 Thread Jan Ekström
On Mon, Jul 19, 2021 at 2:40 PM Jan Ekström wrote: > +int ret = AVERROR_BUG; > +int64_t start_ts = track->start_dts == AV_NOPTS_VALUE ? > + 0 : (track->start_dts + track->track_duration);; The trailing second semicolon which I missed is the cause

Re: [FFmpeg-devel] [PATCH 2/2] avformat/movenc: add support for TTML muxing

2021-07-19 Thread Jan Ekström
On Mon, Jul 12, 2021 at 4:20 PM Martin Storsjö wrote: > > On Tue, 22 Jun 2021, Jan Ekström wrote: > > > From: Jan Ekström > > > > Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') > > methods. This initial version also foregoes fragmentation supp

[FFmpeg-devel] [PATCH v2 0/2] TTML in MP4, part 1

2021-07-19 Thread Jan Ekström
. This will become required when fragmentation support is added (as the fragmentation will have to be matched against A/V tracks), but for now a track should only be interested of its own state. Jan Jan Ekström (2): avformat/ttml: split TTML paragraph based or not check into header avformat/movenc

[FFmpeg-devel] [PATCH v2 2/2] avformat/movenc: add support for TTML muxing

2021-07-19 Thread Jan Ekström
From: Jan Ekström Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') methods. This initial version also foregoes fragmentation support in case the built-in sample squashing is to be utilized, as this eases the initial review. Additionally, add basic tests for both muxing modes

[FFmpeg-devel] [PATCH v2 1/2] avformat/ttml: split TTML paragraph based or not check into header

2021-07-19 Thread Jan Ekström
From: Jan Ekström This way it can be re-utilized in movenc. Signed-off-by: Jan Ekström --- libavformat/ttmlenc.c | 9 ++--- libavformat/ttmlenc.h | 39 +++ 2 files changed, 41 insertions(+), 7 deletions(-) create mode 100644 libavformat/ttmlenc.h

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse 3gpp titl from media or track udta

2021-07-21 Thread Jan Ekström
On Wed, Jul 21, 2021 at 8:28 PM Jan Ekström wrote: > > Seems to be: > * Utilized by Handbrake for track titling > * Actually defined as "title for the media" > > Definition from 3GPP TS 26.244 follows: > > Field TypeDetails

[FFmpeg-devel] [PATCH] avformat/mov: parse 3gpp titl from media or track udta

2021-07-21 Thread Jan Ekström
Seems to be utilized by Handbrake for track titling and is actually defined as "title for the media" as per the specification. Definition from 3GPP TS 26.244 follows: Field TypeDetails Value BoxHeader.Size Unsigned int(32)

[FFmpeg-devel] [PATCH] avformat/mov: parse 3gpp titl from media or track udta

2021-07-21 Thread Jan Ekström
Seems to be: * Utilized by Handbrake for track titling * Actually defined as "title for the media" Definition from 3GPP TS 26.244 follows: Field TypeDetails Value BoxHeader.Size Unsigned int(32)

[FFmpeg-devel] [PATCH] ffmpeg: fix order between field order autodetection and override

2021-07-21 Thread Jan Ekström
Somehow I missed this in fbb44bc51a647862eb05ae3f9d7d49a0be9bed57 , even though the lines were within the context. Probably the code originally being after the this logic had something to do with it, but previously it only touched the avformat context's codecpar, which did not affect the encoder

Re: [FFmpeg-devel] [PATCH] tools/graph2dot: Don't use sizeof(AVFilterGraph), check allocation

2021-07-23 Thread Jan Ekström
On Thu, Jul 22, 2021 at 10:05 AM Andreas Rheinhardt wrote: > > Use avfilter_graph_alloc() instead of av_mallocz(sizeof(AVFilterGraph)) > to allocate an AVFilterGraph; this also properly allocates the graph's > internal. The current code just happened to work because it did not > make any use of

Re: [FFmpeg-devel] [PATCH] avformat/mov: parse 3gpp titl from media or track udta

2021-07-24 Thread Jan Ekström
On Wed, Jul 21, 2021 at 8:30 PM Jan Ekström wrote: > > On Wed, Jul 21, 2021 at 8:28 PM Jan Ekström wrote: > > > > Seems to be: > > * Utilized by Handbrake for track titling > > * Actually defined as "title for the media" > > > > D

Re: [FFmpeg-devel] Patch JPEG2000 Parser: Fix parsing of tile-part header

2021-07-24 Thread Jan Ekström
On Wed, Jul 21, 2021 at 7:02 PM Shaun Simpson wrote: > > Please find my patch attached. > > libavcodec/jpeg2000_parser: Fix parsing of tile-part header, and frames > where the end of frame marker is at the end of the buffer. > > Fixes playback of Sol Levante MXF JPEG2000 file: >

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix order between field order autodetection and override

2021-07-24 Thread Jan Ekström
On Wed, Jul 21, 2021 at 8:29 PM Jan Ekström wrote: > > Somehow I missed this in fbb44bc51a647862eb05ae3f9d7d49a0be9bed57 , > even though the lines were within the context. Probably the code > originally being after the this logic had something to do with it, > but previously

Re: [FFmpeg-devel] [PATCH] ffmpeg: fix order between field order autodetection and override

2021-07-25 Thread Jan Ekström
On Sun, Jul 25, 2021 at 10:38 PM Paul B Mahol wrote: > > On Wed, Jul 21, 2021 at 7:29 PM Jan Ekström wrote: > > > Somehow I missed this in fbb44bc51a647862eb05ae3f9d7d49a0be9bed57 , > > even though the lines were within the context. Probably the code > > originally bei

[FFmpeg-devel] [PATCH v3 1/2] avformat/ttml: split TTML paragraph based or not check into header

2021-07-26 Thread Jan Ekström
From: Jan Ekström This way it can be re-utilized in movenc. Signed-off-by: Jan Ekström --- libavformat/ttmlenc.c | 9 ++--- libavformat/ttmlenc.h | 39 +++ 2 files changed, 41 insertions(+), 7 deletions(-) create mode 100644 libavformat/ttmlenc.h

[FFmpeg-devel] [PATCH v3 0/2] TTML in MP4, part 1

2021-07-26 Thread Jan Ekström
ree the muxer's dynamic buffer in movenc_ttml. ** movenc_ttml::mov_write_ttml_document_from_queue now utilizes a passed AVPacket instead of allocating its own. Jan Jan Ekström (2): avformat/ttml: split TTML paragraph based or not check into header avformat/movenc: add support for TTML mux

[FFmpeg-devel] [PATCH v3 2/2] avformat/movenc: add support for TTML muxing

2021-07-26 Thread Jan Ekström
From: Jan Ekström Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp') methods. This initial version also foregoes fragmentation support in case the built-in sample squashing is to be utilized, as this eases the initial review. Additionally, add basic tests for both muxing modes

[FFmpeg-devel] [PATCH v4] tests: add test for ffmpeg's fix_sub_duration feature

2022-01-10 Thread Jan Ekström
From: Jan Ekström This long-existing feature calculates subtitle durations by keeping it around until the following subtitle is decoded, and then utilizes the following subtitle's pts as the end point of the previous one. Signed-off-by: Jan Ekström --- tests/fate/ffmpeg.mak

Re: [FFmpeg-devel] [PATCH] mlp_parser: fetch a new timestamp when major sync is found

2022-03-07 Thread Jan Ekström
On Mon, Mar 7, 2022 at 7:10 PM Michael Niedermayer wrote: > > On Mon, Mar 07, 2022 at 12:32:59AM +0200, Jan Ekström wrote: > > From: Hendrik Leppkes > > > > Decoding can only start on a major sync > > > and the parser discards > > any data received un

<    3   4   5   6   7   8   9   10   11   12   >