On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote:
From: Limin Wang
For high/main profile, user can choose to use cavlc by specify "-coder cavlc",
for default, it'll will use cabac, if it's baseline, we'll use cavlc by specs
anyway.
ffmpeg -y -f lavfi -i testsrc -c:v libopenh264 -profile:v m
On Fri, 14 Jan 2022, lance.lmw...@gmail.com wrote:
From: Limin Wang
due to the limitations set in d3a7bdd4ac54349aea9150a234478635d50ebd87,
you weren't able to use main profile with OpenH264 1.8, or high profile
with older versions
Reviewed-by: Martin Storsjö
Signed-off-by: Limin
Clang warns about unused -D parameters when operating on .s
files (or if invoked with "-x assembler") while GCC doesn't.
---
As noobdy else than me essentially maintains gas-preprocessor, I'll
go ahead and push this after a couple days if nobody speaks up.
---
gas-preprocessor.pl | 4
1 file
On Sat, 9 Dec 2023, Kalev Lember wrote:
With the way the runtime checks are currently set up, every single
openh264 release, no matter how minor, is considered an ABI break and
requires ffmpeg recompilation. This is unnecessarily strict because it
doesn't allow downstream distributions to ship a
On Mon, 18 Dec 2023, Stefano Sabatini wrote:
On date Monday 2023-12-18 19:05:17 -0300, James Almer wrote:
On 12/18/2023 5:54 AM, Martin Storsjö wrote:
Converting from an integer to HWND (which is a pointer) requires
an explicit cast, otherwise Clang errors out like this:
src/libavdevice
On Mon, 18 Dec 2023, Martin Storsjö wrote:
This can be used to run tests multple times, with e.g. differing
QEMU settings, by adding something like this to the FATE configuration
file:
target_exec="qemu-aarch64-static"
fate_targets="fate-checkasm fate-cpu"
fate_
This replaces the riscv specific handling from
7212466e735aa187d82f51dadbce957fe3da77f0 (which essentially is
reverted, together with 286d6742218ba0235c32876b50bf593cb1986353)
with a different implementation of the same (plus a bit more), based
on the corresponding feature in dav1d's checkasm, supp
On Mon, 18 Dec 2023, Martin Storsjö wrote:
The ffmpeg coding style doesn't usually use const on scalar
parameters (or on the pointer values - as opposed to the type
that is pointed to, where it has a semantic meaning), contrary
to the dav1d coding style (where this was imported from).
On Fri, 15 Dec 2023, Martin Storsjö wrote:
This disables regenerating ffversion.h whenever the checked out
git commit changes, speeding up development rebuilds.
Whenever this option is set, force the version to be printed as
"unknown" rather than showing potentially stale i
The file libavcodec/x86/mlpdsp_init.c uses inline assembly with
nonlocal labels that are referenced outside of the assembly in C.
This fails to link with LTO when built with Clang when targeting
Windows.
The root cause has been reported upstream at
https://github.com/llvm/llvm-project/issues/76046
This fixes the following build error:
src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for function
'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes]
49 | unsigned ff_d3d12va_get_surface_index(const AVCodecContext *avctx,
| ^
---
libavcodec/d3d12v
On Thu, 21 Dec 2023, Martin Storsjö wrote:
This fixes the following build error:
src/libavcodec/d3d12va_decode.c:49:10: error: no previous prototype for function
'ff_d3d12va_get_surface_index' [-Werror,-Wmissing-prototypes]
49 | unsigned ff_d3d12va_get_surface_index(const AVCo
On Thu, 21 Dec 2023, Tong Wu wrote:
Signed-off-by: Tong Wu
---
libavutil/hwcontext_d3d12va.c | 9 -
1 file changed, 9 deletions(-)
diff --git a/libavutil/hwcontext_d3d12va.c b/libavutil/hwcontext_d3d12va.c
index 1600d94cb0..4995518dbd 100644
--- a/libavutil/hwcontext_d3d12va.c
+++ b/lib
On Thu, 21 Dec 2023, Tong Wu wrote:
It caused lacking a public declaration build error with
-Werror=missing-prototypes.
Since DXGI_FORMAT is moved to public since patch set V10, this function
is no longer useful. Now remove it.
Signed-off-by: Tong Wu
---
libavutil/hwcontext_d3d12va.c | 9
On Thu, 21 Dec 2023, Rémi Denis-Courmont wrote:
diff --git a/tests/checkasm/checkasm.c b/tests/checkasm/checkasm.c
index 6318d9296b..668034c67f 100644
--- a/tests/checkasm/checkasm.c
+++ b/tests/checkasm/checkasm.c
@@ -23,8 +23,10 @@
#include "config.h"
#include "config_components.h"
-#ifndef _
On Thu, 21 Dec 2023, James Almer wrote:
Removes -Wunused-variable warnings.
Signed-off-by: James Almer
---
Were this meant to be used? Or are just a remnant of a previous interation of
the set?
libavutil/hwcontext_d3d12va.c | 4
1 file changed, 4 deletions(-)
diff --git a/libavutil/hwcon
The check for UWP mode was duplicated from right above, in
d54127c41a81cf2078a3504f78e0e4232cfe11b7.
Also, instead of several lines with "enabled uwp && ...", make one
"if enabled uwp; then" block.
---
configure | 30 +++---
1 file changed, 11 insertions(+), 19 deletions(-
---
configure | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/configure b/configure
index 69b755f274..18fe8eaa5c 100755
--- a/configure
+++ b/configure
@@ -3922,7 +3922,7 @@ swscale_suggest="libm stdatomic"
avcodec_extralibs="pthreads_extralibs iconv_extralibs dxva2_extral
The check for this option does succeed - MSVC accepts the option,
but prints a warning about it being unknown and ignored, for
each compiled object file:
cl : Command line warning D9002 : ignoring unknown option
'-mfp16-format=ieee'
The configure script only attempts to add this option on AR
On Fri, 22 Dec 2023, Wu, Tong1 wrote:
Subject: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check for
UWP mode
The check for UWP mode was duplicated from right above, in
d54127c41a81cf2078a3504f78e0e4232cfe11b7.
Also, instead of several lines with "enabled uwp && ...", make one
"
On Mon, 18 Dec 2023, flow gg wrote:
+static void test_decorrelate_ls(TAKDSPContext *s) {
+#define BUF_SIZE 1024
+declare_func(void, int32_t *, int32_t *, int);
+
+if (check_func(s->decorrelate_ls, "decorrelate_ls")) {
+LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
+LOCAL
On Mon, 18 Dec 2023, flow gg wrote:
+static void test_decorrelate_sr(TAKDSPContext *s) {
+#define BUF_SIZE 1024
+declare_func(void, int32_t *, int32_t *, int);
+
+if (check_func(s->decorrelate_sr, "decorrelate_sr")) {
+LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
+LOCAL
On Mon, 18 Dec 2023, flow gg wrote:
+static void test_decorrelate_sm(TAKDSPContext *s) {
+#define BUF_SIZE 1024
+declare_func(void, int32_t *, int32_t *, int);
+
+if (check_func(s->decorrelate_sm, "decorrelate_sm")) {
+LOCAL_ALIGNED_32(int32_t, p1, [BUF_SIZE]);
+LOCAL
For memcpy and memcmp, we need to multiply by the element size,
otherwise we're copying and comparing only a fraction of the buffer.
For decorrelate_sr, the buffer p1 is the one that is mutated;
copy and check p1 instead of p2.
For decorrelate_sm, both buffers are mutated, so copy and check
both
On Thu, 21 Dec 2023, James Almer wrote:
Signed-off-by: James Almer
---
tests/checkasm/takdsp.c | 36 +---
1 file changed, 33 insertions(+), 3 deletions(-)
@@ -113,6 +113,35 @@ static void test_decorrelate_sm(TAKDSPContext *s) {
report("decorrelate_sm");
}
On Fri, 22 Dec 2023, Wu, Tong1 wrote:
From: ffmpeg-devel On Behalf Of
Martin Storsjö
Sent: Friday, December 22, 2023 4:41 PM
To: FFmpeg development discussions and patches
Subject: Re: [FFmpeg-devel] [PATCH 1/2] configure: Remove a redundant check
for UWP mode
On Fri, 22 Dec 2023, Wu, Tong1
Hi Frank,
On Fri, 22 Dec 2023, Frank Plowman wrote:
The gcrypt definition of `bn_new` used to use `AVERROR`, however it is
called in `dh_generate_key` and `ff_dh_init` which return pointers. As a
result, compiling with gcrypt and the ffrtmpcrypt protocol resulted in an
int-conversion warning. G
On Fri, 22 Dec 2023, James Almer wrote:
Signed-off-by: James Almer
---
Fixes broken logic as reported by Martin.
tests/checkasm/takdsp.c | 35 ---
1 file changed, 32 insertions(+), 3 deletions(-)
+static void test_decorrelate_sf(TAKDSPContext *s) {
+declar
On Fri, 22 Dec 2023, James Almer wrote:
Signed-off-by: James Almer
---
libavcodec/riscv/takdsp_init.c | 4 ++--
libavcodec/takdsp.c| 6 +++---
libavcodec/takdsp.h| 6 +++---
libavcodec/x86/takdsp_init.c | 12 ++--
tests/checkasm/takdsp.c| 6 +++---
5 fil
On Fri, 29 Dec 2023, flow gg wrote:
Tests on x86 might fail, possibly due to a 16-bit sub overflow
If this only happens in checkasm but not in real life use, it means that
the checkasm test input is out of range, and we should try to mimic the
real input data.
If the issue is off-by-one du
On Fri, 29 Dec 2023, James Almer wrote:
On 12/29/2023 9:16 AM, Martin Storsjö wrote:
On Fri, 29 Dec 2023, flow gg wrote:
Tests on x86 might fail, possibly due to a 16-bit sub overflow
If this only happens in checkasm but not in real life use, it means
that
the checkasm test input is out
On Sun, 31 Dec 2023, Nuo Mi wrote:
vvc decoder plug-in to avcodec.
split frames into slices/tiles and send them to vvc_thread for further decoding
reorder and wait for the frame decoding to be done and output the frame
Features:
+ Support I, P, B frames
+ Support 8/10/12 bits, chroma 400,
On Mon, 1 Jan 2024, David Bohman wrote:
This is a build failure in the master branch as a result of commit
e37b15e26fbc7bc31a86a4a2c7c798e20d4f4c2c:
There is no type AVMediaType prior to macOS 10.13.
---
libavdevice/avfoundation.m | 4
1 file changed, 4 insertions(+)
diff --git a/libavdevi
On Thu, 4 Jan 2024, Nuo Mi wrote:
On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer
wrote:
On Tue, Jan 02, 2024 at 05:47:53PM +0800, Nuo Mi wrote:
[...]
> maintainer, and any HEVC code change requires a very long review time.
I think changes that just move code around or rename functions wo
On Fri, 22 Dec 2023, Frank Plowman wrote:
Hi Martin,
Thanks for the review.
On 22/12/2023 12:15, Martin Storsjö wrote:
The change LGTM, but the wording here is slightly confusing IMO. The
problem isn't with using per se AVERROR, that's just a macro for generating
suitable int
On Fri, 22 Dec 2023, Martin Storsjö wrote:
The check for this option does succeed - MSVC accepts the option,
but prints a warning about it being unknown and ignored, for
each compiled object file:
cl : Command line warning D9002 : ignoring unknown option
'-mfp16-format=ieee'
The
On Wed, 20 Dec 2023, Martin Storsjö wrote:
The file libavcodec/x86/mlpdsp_init.c uses inline assembly with
nonlocal labels that are referenced outside of the assembly in C.
This fails to link with LTO when built with Clang when targeting
Windows.
The root cause has been reported upstream at
On Thu, 4 Jan 2024, James Almer wrote:
On 1/4/2024 10:57 AM, Nuo Mi wrote:
On Thu, Jan 4, 2024 at 8:07 PM Martin Storsjö wrote:
On Thu, 4 Jan 2024, Nuo Mi wrote:
On Thu, Jan 4, 2024 at 2:38 AM Michael Niedermayer <
mich...@niedermayer.cc>
wrote:
On Tue, Jan 02, 2024 at 05:4
On Sat, 6 Jan 2024, Kieran Kunhya wrote:
On Sat, 6 Jan 2024 at 02:35, Nuo Mi wrote:
On Sat, Jan 6, 2024 at 9:13 AM James Almer wrote:
> On 1/5/2024 10:09 PM, Nuo Mi wrote:
> > On Sat, Jan 6, 2024 at 5:09 AM James Almer wrote:
> >
> > Here are the clips and their sources:
> > https://github
This replaces the riscv specific handling from
7212466e735aa187d82f51dadbce957fe3da77f0 (which essentially is
reverted, together with 286d6742218ba0235c32876b50bf593cb1986353)
with a different implementation of the same (plus a bit more), based
on the corresponding feature in dav1d's checkasm, supp
Whenever mmap is used, we include sys/mmap.h unconditionally
within HAVE_MMAP ifdefs.
When building for a system (e.g. mingw) that normally lacks the
mmap function, but if building with profiling enabled, the
profiling runtime which gets linked in in each test executable,
can contain a function na
On Thu, 11 Jan 2024, 徐福隆 wrote:
There maybe a spelling mistake, which in "check_func_headers sys/mman.h
mmap".
It looks like should be "sys/mmap.h"
No, this is not a mistake, this is the name of the header. Have a look at
libavutil/file.c or libswscale/utils.c, both which have this:
#if HAV
On Wed, 10 Jan 2024, Rémi Denis-Courmont wrote:
Looks OK (not tested).
Thanks, pushed now.
// Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
f
This should print a nicer error message than crashing due to
an illegal instruction, if direct cycle counter access isn't
allowed.
This matches the dav1d checkasm commit
95a192549a448b70d9542e840c4e34b60d09b093.
---
tests/checkasm/checkasm.c | 12 +++-
1 file changed, 11 insertions(+), 1
On Thu, 11 Jan 2024, Rémi Denis-Courmont wrote:
Le torstaina 11. tammikuuta 2024, 14.53.05 EET Martin Storsjö a écrit :
This should print a nicer error message than crashing due to
an illegal instruction, if direct cycle counter access isn't
allowed.
This matches the dav1d checkasm c
On some platforms (in particular, ARM/AArch64), the implementation
of AV_READ_TIME() may use a privileged instruction - in such
cases, benchmarking just fails with a SIGILL.
Instead of crashing, try executing AV_READ_TIME() once within
a region with the signal handler active, to allow gracefully
i
On Thu, 11 Jan 2024, Martin Storsjö wrote:
On some platforms (in particular, ARM/AArch64), the implementation
of AV_READ_TIME() may use a privileged instruction - in such
cases, benchmarking just fails with a SIGILL.
Instead of crashing, try executing AV_READ_TIME() once within
a region with
On Mon, 22 Jan 2024, Timo Rothenpieler wrote:
On 22/01/2024 07:51, Matthew White via ffmpeg-devel wrote:
Since glslang 14.0.0, OGLCompiler and HLSL stub libraries have been
fully removed from the build.
This fixes the configuration by detecting if the stub libraries are
still present (glslang
On Mon, 22 Jan 2024, Tomas Härdin wrote:
>>> - if (frame->quality)
> > - enc->lambda = frame->quality - 1;
> > - else
> > - enc->lambda = 2*ROQ_LAMBDA_SCALE;
> > + if (avctx->bit_rate <= ROQ_DEFAULT_MIN_BIT_RATE) {
> > + /* no specific bit rate desired, use frame
On Mon, 22 Jan 2024, Lynne wrote:
Jan 22, 2024, 07:52 by ffmpeg-devel@ffmpeg.org:
Since glslang 14.0.0, OGLCompiler and HLSL stub libraries have been
fully removed from the build.
This fixes the configuration by detecting if the stub libraries are
still present (glslang releases before versio
On Wed, 24 Jan 2024, J. Dekker wrote:
Signed-off-by: J. Dekker
---
tests/checkasm/hevc_deblock.c | 225 +-
1 file changed, 195 insertions(+), 30 deletions(-)
- added luma 10/12 bit
- supporting full (*_c) luma & chroma functions
- dynamically generating all test
about the need to call emms_c().
Just get rid of these dangerous inline assembly snippets; this
doesn't make any difference for 64 bit architectures anyway.
Signed-off-by: Martin Storsjö
---
libavcodec/dca_core.c| 16
libavutil/x86/intr
On Fri, 26 Jan 2024, Martin Storsjö wrote:
These inline implementations of AV_COPY64, AV_SWAP64 and AV_ZERO64
are known to clobber the FPU state - which has to be restored
with the 'emms' instruction afterwards.
This was known and signaled with the FF_COPY_SWAP_ZERO_USES_MMX
def
On Fri, 26 Jan 2024, James Almer wrote:
On 1/26/2024 1:44 PM, Vittorio Giovara wrote:
On Thu, Jan 25, 2024 at 2:48 PM James Almer wrote:
Signed-off-by: James Almer
---
doc/APIchanges| 2 +-
libavcodec/version.h | 2 +-
libavcodec/version_major.h| 2 +-
liba
On Fri, 26 Jan 2024, James Almer wrote:
On 1/26/2024 1:52 PM, Martin Storsjö wrote:
On Fri, 26 Jan 2024, James Almer wrote:
On 1/26/2024 1:44 PM, Vittorio Giovara wrote:
On Thu, Jan 25, 2024 at 2:48 PM James Almer wrote:
Signed-off-by: James Almer
---
doc/APIchanges | 2
By default the option "flv_metadata" (internally using the field
name "trust_metadata") is set to 0, meaning that we don't allocate
streams based on information in the metadata, only based on
actual streams we encounter. However the "datastream" metadata field
still would allocate a subtitle stream
On Fri, 26 Jan 2024, Martin Storsjö wrote:
On Fri, 26 Jan 2024, Martin Storsjö wrote:
These inline implementations of AV_COPY64, AV_SWAP64 and AV_ZERO64
are known to clobber the FPU state - which has to be restored
with the 'emms' instruction afterwards.
This was known and signale
On Fri, 9 Feb 2024, Nuo Mi wrote:
similar issue as in the previous commit
---
libavcodec/bsf/hevc_mp4toannexb.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
Keep in mind, that while the patches are posted together, they can end up
at different places further in review, and in co
On Fri, 9 Feb 2024, Connor Worley wrote:
The previous assumption that DXV needs to be aligned to 16x16 was
erroneous. 4x4 works just as well, and FATE decoder tests pass for all
texture formats.
On the encoder side, we should reject input that isn't 4x4 aligned,
like the HAP encoder does, and s
On Fri, 9 Feb 2024, Andreas Rheinhardt wrote:
Possible since 7ec2354c38978b918dc079b611393becb6c80bf7.
Signed-off-by: Andreas Rheinhardt
---
libavcodec/dca_core.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavcodec/dca_core.c b/libavcodec/dca_core.c
index 5dd727fc72..697fc74295 100644
On Mon, 26 Jul 2021, Jan Ekström wrote:
From: Jan Ekström
Includes basic support for both the ISMV ('dfxp') and MP4 ('stpp')
methods. This initial version also foregoes fragmentation support
in case the built-in sample squashing is to be utilized, as this
eases the initial review.
Additionall
---
libavfilter/af_afftfilt.c | 1 +
libavfilter/avf_showspectrum.c | 1 +
libavfilter/vaf_spectrumsynth.c | 1 +
3 files changed, 3 insertions(+)
diff --git a/libavfilter/af_afftfilt.c b/libavfilter/af_afftfilt.c
index 3e69c636c8..877ccc5be0 100644
--- a/libavfilter/af_afftfilt.c
+++ b/li
On Fri, 16 Jul 2021, Mikhail Nitenko wrote:
Benchmarks:A53 A72
pred8x8_dc_10_c: 64.249.5
pred8x8_dc_10_neon:62.754.5
pred8x8_dc_128_10_c: 26.015.5
pred8x8_dc_128_10_neon:28.216.0
pred8x8_horiz
These became unnecessary when the stride arguments were changed from
int to ptrdiff_t in bc26fe89275c267d169b468356c82ee59874407d
(0576ef466d8a631326d1d0a5ec2e4c4c81d25353) and
d5d699ab6e6f8a8290748d107416fd5c19757a1b
(aa844dc46f93182a63ec0b53267d19e7342c79b9).
Signed-off-by: Martin Storsjö
On Fri, 16 Jul 2021, Mikhail Nitenko wrote:
transpose_4x8H was declared in vp9lpf_16bpp_neon, however this macro is
not unique to vp9 and could be used elsewhere.
Signed-off-by: Mikhail Nitenko
---
libavcodec/aarch64/neon.S | 13 +
libavcodec/aarch64/vp9lpf_16bpp_neon.S
On Fri, 16 Jul 2021, Mikhail Nitenko wrote:
Benchmarks: A53A72
h264_h_loop_filter_chroma422_10bpp_c: 293.0 116.7
h264_h_loop_filter_chroma422_10bpp_neon: 283.7 126.2
h264_h_loop_filter_chroma_10bpp_c:
Signed-off-by: Martin Storsjö
---
libavcodec/aarch64/h264dsp_neon.S | 520 +++---
1 file changed, 260 insertions(+), 260 deletions(-)
diff --git a/libavcodec/aarch64/h264dsp_neon.S
b/libavcodec/aarch64/h264dsp_neon.S
index 997167ca88..997082498f 100644
--- a/libavcodec
Hi,
On Tue, 20 Jul 2021, 胡玮文 wrote:
After compile and run this code, run this command to inspect the dts (which
comes from the out of sync tfdt)
ffprobe -show_packets bug.mp4 | grep dts=
The output is:
dts=0
dts=1
dts=2
dts=2
dts=3
dts=4
With this patch applied, the output is:
dts=0
dts=1
If autoflushing on a new packet (e.g. due to the frag_every_frame
flag being set), there's no samples to be written in the new fragment,
so we can't overwrite the track duration in order to make it line
up with the next packet to be written.
Signed-off-by: Martin Storsjö
---
l
On Thu, 5 Aug 2021, J. Dekker wrote:
Also add to `make fate-checkasm' target.
Signed-off-by: J. Dekker
---
tests/checkasm/checkasm.c | 11 +--
tests/checkasm/checkasm.h | 11 +--
tests/checkasm/hevc_pel.c | 34 --
tests/fate/checkasm.mak | 1 +
4
On Thu, 5 Aug 2021, J. Dekker wrote:
Signed-off-by: J. Dekker
---
tests/checkasm/Makefile | 1 +
tests/checkasm/checkasm.c | 3 +
tests/checkasm/checkasm.h | 1 +
tests/checkasm/h264chroma.c | 109
tests/fate/checkasm.mak | 1 +
5 files change
On Thu, 5 Aug 2021, J. Dekker wrote:
Signed-off-by: J. Dekker
---
tests/checkasm/Makefile | 2 +-
tests/checkasm/checkasm.c | 1 +
tests/checkasm/checkasm.h | 1 +
tests/checkasm/hevc_deblock.c | 126 ++
tests/fate/checkasm.mak | 1 +
5 fil
On Thu, 5 Aug 2021, Martin Storsjö wrote:
These became unnecessary when the stride arguments were changed from
int to ptrdiff_t in bc26fe89275c267d169b468356c82ee59874407d
(0576ef466d8a631326d1d0a5ec2e4c4c81d25353) and
d5d699ab6e6f8a8290748d107416fd5c19757a1b
On Thu, 5 Aug 2021, Martin Storsjö wrote:
Signed-off-by: Martin Storsjö
---
libavcodec/aarch64/h264dsp_neon.S | 520 +++---
1 file changed, 260 insertions(+), 260 deletions(-)
Pushed this one too.
// Martin
___
ffmpeg-devel
Hi,
On Mon, 9 Aug 2021, Hu Weiwen wrote:
Even if FF_MOV_FLAG_FRAG_EVERY_FRAME is set, don't flush if no frame available.
This fixes an issue that we overwrite the track duration, causing it to be
out-of-sync with the last written packet in previous fragment.
Signed-off-by: Hu Weiwen
---
Hi M
On Tue, 10 Aug 2021, 胡玮文 wrote:
Thank you for your detailed explaination. Now I agree your patch is better.
Ok, I pushed that one then.
// Martin
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
On Thu, 12 Aug 2021, Hu Weiwen wrote:
track->mdat_buf can be not NULL while the track is still empty if the
last packet write failed.
Signed-off-by: Hu Weiwen
---
libavformat/movenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/movenc.c b/libavformat/movenc.c
On Thu, 12 Aug 2021, Hu Weiwen wrote:
"frag_start" is redundant, and every occurance can be replaced with
cluster[0].dts - start_dts
I think I can agree about this, so I think the patch should be fine,
thanks for taking the time to study it in detail!
My own mental model of the code, having
On Mon, 16 Aug 2021, Mikhail Nitenko wrote:
Benchmarks: A53 A72
h264_h_loop_filter_chroma422_10bpp_c: 277.5 114.2
h264_h_loop_filter_chroma422_10bpp_neon: 109.781.7
h264_h_loop_filter_chroma_10bpp_c:
On Mon, 16 Aug 2021, Mikhail Nitenko wrote:
Benchmarks:A53 A72
pred8x8_dc_10_c: 64.255.7
pred8x8_dc_10_neon:61.753.7
pred8x8_dc_128_10_c: 26.020.7
pred8x8_dc_128_10_neon:30.724.5
pred8x8_horiz
On Tue, 17 Aug 2021, Christopher Degawa wrote:
Fixes https://trac.ffmpeg.org/ticket/8903
relevant https://github.com/msys2/MINGW-packages/discussions/9258
Signed-off-by: Christopher Degawa
---
libavcodec/x86/cabac.h | 9 +++--
1 file changed, 7 insertions(+), 2 deletions(-)
diff --git a/l
On Tue, 17 Aug 2021, James Almer wrote:
On 8/17/2021 12:35 PM, Christopher Degawa wrote:
Fixes https://trac.ffmpeg.org/ticket/8903
relevant https://github.com/msys2/MINGW-packages/discussions/9258
Signed-off-by: Christopher Degawa
---
libavcodec/x86/cabac.h | 9 +++--
1 file changed,
On Tue, 17 Aug 2021, James Almer wrote:
On 8/17/2021 12:35 PM, Christopher Degawa wrote:
Fixes https://trac.ffmpeg.org/ticket/8903
relevant https://github.com/msys2/MINGW-packages/discussions/9258
Signed-off-by: Christopher Degawa
---
libavcodec/x86/cabac.h | 9 +++--
1 file changed,
On Thu, 12 Aug 2021, Martin Storsjö wrote:
On Thu, 12 Aug 2021, Hu Weiwen wrote:
"frag_start" is redundant, and every occurance can be replaced with
cluster[0].dts - start_dts
I think I can agree about this, so I think the patch should be fine, thanks
for taking the time to s
On Thu, 12 Aug 2021, Martin Storsjö wrote:
On Thu, 12 Aug 2021, Hu Weiwen wrote:
track->mdat_buf can be not NULL while the track is still empty if the
last packet write failed.
Signed-off-by: Hu Weiwen
---
libavformat/movenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --
On Fri, 20 Aug 2021, Mikhail Nitenko wrote:
there is a function that is not covered by tests, but I tested it with
sample videos, not sure what to do with it
If there are asm functions that lack checkasm tests, then please do add a
test for it while working on that function. Asm functions th
On Fri, 20 Aug 2021, Mikhail Nitenko wrote:
Benchmarks:A53 A72
pred8x8_dc_10_c: 64.249.5
pred8x8_dc_10_neon:62.053.7
pred8x8_dc_128_10_c: 26.014.0
pred8x8_dc_128_10_neon:30.717.5
pred8x8_horiz
On Fri, 20 Aug 2021, Mikhail Nitenko wrote:
Benchmarks: A53 A72
h264_h_loop_filter_chroma422_10bpp_c: 282.7 114.2
h264_h_loop_filter_chroma422_10bpp_neon: 109.578.5
h264_h_loop_filter_chroma_10bpp_c:
Therefore, we could alternatively fix the test
to only test things that the real decoder does, and this modification
could be reverted.
Signed-off-by: Martin Storsjö
---
libavcodec/arm/hevcdsp_qpel_neon.S | 18 +-
1 file changed, 9 insertions(+), 9 deletions(-)
diff --
Override the fate-sub-* wide comparison function of CMP=rawdiff
back to the default, CMP=diff, which ignores line ending differences
(where the ffprobe output contains CRLF line endings).
Signed-off-by: Martin Storsjö
---
tests/fate/subtitles.mak | 2 ++
1 file changed, 2 insertions(+)
diff
On Wed, 25 Aug 2021, Jan Ekström wrote:
subtitles.mak utilizes a more strict comparator and - to be honest -
the tests feel more at home in this location.
---
LGTM, although your commit message forgets to point out the relevant
effect of it - we're not just doing this for sorting things in th
On Wed, 25 Aug 2021, Martin Storsjö wrote:
This unbreaks the fate-checkasm-hevc_pel test on arm targets.
The assembly assumed that the width passed to the DSP functions is
a multiple of 8, while the checkasm test used other widths too.
This wasn't noticed before, because the hevc_pel che
> On Aug 23, 2021, at 17:41, Nicolas George wrote:
>
> Michael Niedermayer (12021-08-23):
>> Please make sure you use g...@git.ffmpeg.org:fateserver not
>> g...@source.ffmpeg.org:fateserver
>
> My bad. I fixed it and it worked.
Thanks for looking into these issues and bringing the fate site bac
On Thu, 2 Sep 2021, Andreas Rheinhardt wrote:
The earlier code did not properly check these initializations:
It only recorded whether the part of init where these initializations
are has been reached, but it did not check whether the initializations
were successful, although destroying them woul
On Fri, 20 Aug 2021, Mikhail Nitenko wrote:
transpose_4x4S and transpose_8x8S were declared in vp9itxfm_16bpp_neon, however
these macros are
not unique to vp9 and could be used elsewhere.
Signed-off-by: Mikhail Nitenko
---
libavcodec/aarch64/neon.S| 49
On Thu, 19 Aug 2021, Mikhail Nitenko wrote:
diff --git a/libavcodec/aarch64/h264qpel_neon.S
b/libavcodec/aarch64/h264qpel_neon.S
index d27cfac494..eb18469b7f 100644
--- a/libavcodec/aarch64/h264qpel_neon.S
+++ b/libavcodec/aarch64/h264qpel_neon.S
@@ -932,3 +932,518 @@ endfunc
h264_qpel
This gives rather big speedups on these functions:
Before:
put_h264_qpel_8_mc01_8_neon: 241.0 131.5 138.7
put_h264_qpel_8_mc02_8_neon: 214.7 121.2 127.5
put_h264_qpel_8_mc03_8_neon: 242.5 131.2 135.7
put_h264_qpel_8_mc11_8_neon: 421.2 218.7 251.0
put_h264_qpel_8_mc1
Don't use the loaded registers directly, avoiding stalls on in
order cores. Use vrhadd.u8 with q registers where easily possible.
---
libavcodec/aarch64/h264qpel_neon.S | 60 +++---
libavcodec/arm/h264qpel_neon.S | 57
2 files changed, 54 in
On Fri, 3 Sep 2021, Martin Storsjö wrote:
+function \type\()_h264_qpel8_v_lowpass_neon_10
+ld1 {v16.8H}, [x1], x3
+ld1 {v18.8H}, [x1], x3
+ld1 {v20.8H}, [x1], x3
+ld1 {v22.8H}, [x1], x3
+ld1
On Fri, 20 Aug 2021, Mikhail Nitenko wrote:
Benchmarks: A53 A72
h264_idct4_add_10bpp_c:187.7 115.2
h264_idct4_add_10bpp_neon: 72.545.0
h264_idct4_add_dc_10bpp_c:
901 - 1000 of 1467 matches
Mail list logo
