Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-17 Thread Marton Balint
On Sat, 17 Aug 2019, Gyan wrote: On 17-08-2019 08:42 PM, Marton Balint wrote: On Wed, 14 Aug 2019, Marton Balint wrote: On Wed, 14 Aug 2019, Gyan wrote: On 09-08-2019 04:59 PM, Ilinca Tudose wrote: Hi Marton, The issue with the out of sync TC was reproducible on all tapes and

Re: [FFmpeg-devel] [PATCH v3] avfilter/f_select: yuv will use Y plane only for scenecut detect

2019-08-17 Thread Marton Balint
On Sat, 17 Aug 2019, Limin Wang wrote: ping, please help to merge the code if it's OK. On Tue, Aug 13, 2019 at 09:39:47AM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_select.c | 6 +- tests/ref/fate/filter-me

Re: [FFmpeg-devel] [PATCH v1] fftools/ffmpeg_opt: avoid to display the hwaccels name twice

2019-08-17 Thread Marton Balint
On Sat, 17 Aug 2019, Limin Wang wrote: On Sat, Aug 17, 2019 at 05:21:33PM +0200, Marton Balint wrote: On Sat, 17 Aug 2019, Limin Wang wrote: > > >ping, please help to merge the code if it's OK. > >On Thu, Aug 15, 2019 at 09:23:45AM +0800, lance.lmw...@gmail.com wrote

Re: [FFmpeg-devel] [PATCHv2 1/3] avformat/avio: add avio_print_string_array and avio_print

2019-08-17 Thread Marton Balint
On Wed, 14 Aug 2019, Paul B Mahol wrote: LGTM Thanks for all the comments, patchset finally applied. Regards, Marton On Mon, Aug 12, 2019 at 10:32 AM Marton Balint wrote: These functions can be used to print a variable number of strings consecutively to the IO context. Unlike

[FFmpeg-devel] EOF and IO error checking

2019-08-17 Thread Marton Balint
Hi, As you might now avio_feof() returns true both in case of actual EOF and in case of IO errors. Some demuxers (matroska) have special handling for this exact reason, e.g.: if (avio_feof(pb)) { if (pb->error) { return pb->error; } else { return AVERROR_EOF; } }

[FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: do not ignore bad size errors

2019-08-17 Thread Marton Balint
The return value was unintentionally lost after 00a2652df3bf25a27d174cc67ed508b5317cb115. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index bb72fb9841..397f820b3f 100644

[FFmpeg-devel] [PATCH 3/3] avcodec: remove some dead assignments

2019-08-17 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/bsf.c| 1 - libavcodec/decode.c | 1 - 2 files changed, 2 deletions(-) diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index 5081307603..71915dea85 100644 --- a/libavcodec/bsf.c +++ b/libavcodec/bsf.c @@ -306,7 +306,6 @@ static int

[FFmpeg-devel] [PATCH 2/3] avutil/imgutils: remove dead assignment

2019-08-17 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/imgutils.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavutil/imgutils.c b/libavutil/imgutils.c index c733cb5cf5..7f9c1b632c 100644 --- a/libavutil/imgutils.c +++ b/libavutil/imgutils.c @@ -519,7 +519,6 @@ static void memset_bytes(uint8_t *dst

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-21 Thread Marton Balint
On Tue, 20 Aug 2019, Devin Heitmueller wrote: A couple of follow-up Qs: Is auto-detection available for all Decklink devices? No, but AFAIK it is for all devices which support SDI. Generally it's the older analog capture devices which don't support it. For those for which it is available

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: do not ignore bad size errors

2019-08-21 Thread Marton Balint
On Sun, 18 Aug 2019, Tomas Härdin wrote: lör 2019-08-17 klockan 21:41 +0200 skrev Marton Balint: The return value was unintentionally lost after 00a2652df3bf25a27d174cc67ed508b5317cb115. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-21 Thread Marton Balint
On Tue, 20 Aug 2019, Carl Eugen Hoyos wrote: Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol : I kindly ask that following commit: d702769213487923c0fb0abe4b61f4d9ebddb88b I still believe what the patch does is a very good idea and a revert would hurt FFmpeg. If the patch is kept

Re: [FFmpeg-devel] EOF and IO error checking

2019-08-22 Thread Marton Balint
On Sun, 18 Aug 2019, Michael Niedermayer wrote: On Sat, Aug 17, 2019 at 09:10:59PM +0200, Marton Balint wrote: Hi, As you might now avio_feof() returns true both in case of actual EOF and in case of IO errors. Some demuxers (matroska) have special handling for this exact reason, e.g.: if

Re: [FFmpeg-devel] [PATCH 2/3] avutil/imgutils: remove dead assignment

2019-08-22 Thread Marton Balint
On Sun, 18 Aug 2019, Michael Niedermayer wrote: On Sat, Aug 17, 2019 at 09:41:04PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/imgutils.c | 1 - 1 file changed, 1 deletion(-) LGTM Applied, thanks. Marton ___ ffmpeg

Re: [FFmpeg-devel] [PATCH 1/3] avformat/mxfdec: do not ignore bad size errors

2019-08-22 Thread Marton Balint
On Thu, 22 Aug 2019, Tomas Härdin wrote: ons 2019-08-21 klockan 21:54 +0200 skrev Marton Balint: On Sun, 18 Aug 2019, Tomas Härdin wrote: > lör 2019-08-17 klockan 21:41 +0200 skrev Marton Balint: > > The return value was unintentionally l

Re: [FFmpeg-devel] [PATCH 3/3] avcodec: remove some dead assignments

2019-08-22 Thread Marton Balint
On Sat, 17 Aug 2019, Marton Balint wrote: Signed-off-by: Marton Balint --- libavcodec/bsf.c| 1 - libavcodec/decode.c | 1 - 2 files changed, 2 deletions(-) Applied this as well, as it was trivial enough. Regards, Marton diff --git a/libavcodec/bsf.c b/libavcodec/bsf.c index

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-22 Thread Marton Balint
On Thu, 22 Aug 2019, Anthony Delannoy wrote: Hi fails to build on MIPS Seems to be because of these two structs within EPGTable and EPGSubTable: +struct { +int nb_descriptors; +void **descriptors; +}; I made modifications to avoid issues you encountered and put fa

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

2019-08-22 Thread Marton Balint
On Fri, 16 Aug 2019, Andreas Håkon wrote: Hi Marton, Very good work with your series of patches on the mpegtsenc! ‐‐‐ Original Message ‐‐‐ On Thursday, 15 de August de 2019 1:51, Marton Balint wrote: Also document the algorithm for the default PCR interval. [...] + if (ts

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

2019-08-23 Thread Marton Balint
On Fri, 23 Aug 2019, Marton Balint wrote: On Fri, 16 Aug 2019, Andreas Håkon wrote: Hi Marton, Very good work with your series of patches on the mpegtsenc! ‐‐‐ Original Message ‐‐‐ On Thursday, 15 de August de 2019 1:51, Marton Balint wrote: Also document the algorithm for

[FFmpeg-devel] [PATCH] avformat/mpegts: fix teletext PTS when selecting teletext streams only

2019-08-23 Thread Marton Balint
tream discard value, which may be different. Also fixes ticket #7567, which was caused by the fact that teletext PTS values were not touched if the PCR pid was discarded even before a1b4f120c031e6697bac9fd8c725d9c37ee36d13. Signed-off-by: Marton Balint --- libavformat/mpegts.c | 8 +--- 1

[FFmpeg-devel] [PATCH] avformat/avidec: add support for recognizing HEVC fourcc when demuxing

2019-08-23 Thread Marton Balint
Some security cams generate this, as well as some versions of VirtualDub so support for _reading_ such files is justified. Fixes ticket #7110. See also this discussion: https://patchwork.ffmpeg.org/patch/8744/ Signed-off-by: Marton Balint --- libavformat/avidec.c | 4 libavformat/riff.c

Re: [FFmpeg-devel] [PATCH] avformat/avidec: add support for recognizing HEVC fourcc when demuxing

2019-08-24 Thread Marton Balint
On Sat, 24 Aug 2019, Carl Eugen Hoyos wrote: Am Sa., 24. Aug. 2019 um 01:47 Uhr schrieb Marton Balint : Some security cams generate this, as well as some versions of VirtualDub so support for _reading_ such files is justified. Please also mention vlc. Ok. Fixes ticket #7110. See

Re: [FFmpeg-devel] [PATCH v3] libavformat: Add ZeroMQ as a protocol option

2019-08-24 Thread Marton Balint
On Fri, 23 Aug 2019, Andriy Gelman wrote: On Mon, 19. Aug 17:28, Andriy Gelman wrote: Minor changes in v3: 1. Removed tab character from as per feedback 2. Removed unused timeout variable from ZMQContext Andriy From 66c11c12fcfa8a7fbb3c8c09d23c017992229a99 Mon Sep 17 00:00:00 2001 From

Re: [FFmpeg-devel] [PATCH v3 3/3] FATE: add a test for freeezedetect

2019-08-24 Thread Marton Balint
On Sat, 24 Aug 2019, Limin Wang wrote: On Fri, Aug 23, 2019 at 08:27:22PM +0200, Michael Niedermayer wrote: On Fri, Aug 23, 2019 at 08:17:09PM +0800, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > tests/fate/filter-video.mak | 4 +

Re: [FFmpeg-devel] [PATCH] DVB EPG decoder

2019-08-24 Thread Marton Balint
On Fri, 23 Aug 2019, Anthony Delannoy wrote: I think we should only merge the part of this patchset which makes the EIT available as a data stream. Parsing the whole EIT or dumping the data as ASCII is not libavcodec's or libavutil's job. The EPG decoder does not change the table's data, it j

[FFmpeg-devel] [PATCH] avformat/utils: return pending IO error on EOF in av_read_frame()

2019-08-24 Thread Marton Balint
errors happened, but not even ffmpeg.c does this. It should be more intuitive to the API user if we simply return the IO error as the return value of av_read_frame() instead of AVERROR_EOF. Signed-off-by: Marton Balint --- libavformat/utils.c | 5 + 1 file changed, 5 insertions(+) diff -

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread Marton Balint
On Mon, 26 Aug 2019, James Almer wrote: Used to signal frames that can be safely discarded without losing any picture data, side data, or metadata other than timing info. Signed-off-by: James Almer --- This implements the "disposable frame" solution to allow library users to drop duplicate f

[FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-27 Thread Marton Balint
ut2]" \ -flags +bitexact -fflags +bitexact -sws_flags +accurate_rnd+bitexact \ -codec:v libx264 -codec:a mp2 -b:a 32k -pix_fmt yuv420p \ -map '0:v:0' \ -map '0:v:1' \ -map '0:a:0' \ -muxrate 80 \ -program st=0:st=2 -program st=1:st=2 -program st=2

[FFmpeg-devel] [PATCH 1/2] docs/formats: fix max_interleave_delta default

2019-08-27 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/formats.texi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/formats.texi b/doc/formats.texi index 729c77b01d..d689fbadfa 100644 --- a/doc/formats.texi +++ b/doc/formats.texi @@ -139,7 +139,7 @@ Consider things that a sane encoder

Re: [FFmpeg-devel] [PATCH 1/3][RFC] avutil/frame: add AV_FRAME_FLAG_DISPOSABLE

2019-08-27 Thread Marton Balint
On Tue, 27 Aug 2019, Michael Niedermayer wrote: On Tue, Aug 27, 2019 at 09:12:53AM +0200, Marton Balint wrote: On Mon, 26 Aug 2019, James Almer wrote: Used to signal frames that can be safely discarded without losing any picture data, side data, or metadata other than timing info

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-27 Thread Marton Balint
On Tue, 27 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 9:34, Marton Balint wrote: Fixes DTS < PCR errors with this command line: ./ffmpeg -loglevel verbose -y -f lavfi -i \ "testsrc=s=64x64:d=20,split=2[out0][tmp

Re: [FFmpeg-devel] libavformat/mpegtsenc: new interleaved mux mode [v3]

2019-08-27 Thread Marton Balint
the fix of the incorrect PCR with multiple programs (fixed in collaboration with Marton Balint). Supersedes: https://patchwork.ffmpeg.org/patch/13745/ How to check it: (Note: I use for all the tests the file https://samples.ffmpeg.org/HDTV/bshi01.tp ) - To check the new interlaced mode you can pe

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-28 Thread Marton Balint
On Wed, 28 Aug 2019, Andreas Håkon wrote: Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 23:33, Marton Balint wrote: > Please, note that the main problem at time with the mpegts muxer is that all PES packets are > written sequentially. And this gener

Re: [FFmpeg-devel] [PATCH v3] libavformat: Add ZeroMQ as a protocol option

2019-08-28 Thread Marton Balint
On Wed, 28 Aug 2019, Andriy Gelman wrote: > > +h->is_streamed = 1; > > + > > +av_strstart(uri, "zmq:", &uri); > > + > > +/*publish during write*/ > > +if (h->flags & AVIO_FLAG_WRITE) { > > +s->socket = zmq_socket(s->context, ZMQ_PUB); > > +if (!s->socket) { > >

Re: [FFmpeg-devel] [PATCH v1] avformat/mxfenc: fix warning: unused function 'klv_ber_length' [-Wunused-function]

2019-08-29 Thread Marton Balint
On Thu, 29 Aug 2019, lance.lmw...@gmail.com wrote: From: Limin Wang See https://patchwork.ffmpeg.org/patch/14141/ Thanks, Marton Signed-off-by: Limin Wang --- libavformat/mxfenc.c | 8 1 file changed, 8 deletions(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index

Re: [FFmpeg-devel] [PATCH v4] Add ZeroMQ as protocol option

2019-08-29 Thread Marton Balint
On Thu, 29 Aug 2019, Andriy Gelman wrote: Changes in v4: - Use polling instead of non-blocking option for socket read/write operations. - Added pkt_size, timeout_send, timeout_recv options. Updated documentation for new options. No, timeout_send and timeout_recv is not needed. The UR

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_enc: print preroll and buffer size

2018-08-23 Thread Marton Balint
On Thu, 23 Aug 2018, Gyan Doshi wrote: Plan to push tomorrow. Ok, LGTM. Thanks: Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] make work (live) libsrt

2018-08-23 Thread Marton Balint
On Thu, 23 Aug 2018, myp...@gmail.com wrote: On Wed, Aug 22, 2018 at 4:30 AM Tudor Suciu wrote: Hello, I get errors when I try to send a live srt stream that the first packet is too big: 21:30:39.896626/ffmpeg*E: SRT.c: LiveSmoother: payload size: 1504 exceeds maximum allowed 1316 Here ar

Re: [FFmpeg-devel] make work (live) libsrt

2018-08-25 Thread Marton Balint
, Aug 24, 2018 at 2:55 AM Marton Balint wrote: On Thu, 23 Aug 2018, myp...@gmail.com wrote: On Wed, Aug 22, 2018 at 4:30 AM Tudor Suciu wrote: Hello, I get errors when I try to send a live srt stream that the first packet is too big: 21:30:39.896626/ffmpeg*E: SRT.c: LiveSmoother: payload

Re: [FFmpeg-devel] make work (live) libsrt

2018-08-25 Thread Marton Balint
On Sat, 25 Aug 2018, Marton Balint wrote: On Sat, 25 Aug 2018, Tudor Suciu wrote: Hello, Is this patch in a better shape for inclusion? The code seems OK, please resend the patch with a docs/protocols.texi update for the new option. On the second look, there are some strange things

Re: [FFmpeg-devel] [PATCH] Support 64-bit integers for av_get_frame_filename2()

2018-08-25 Thread Marton Balint
On Sat, 25 Aug 2018, Michael Niedermayer wrote: On Fri, Aug 24, 2018 at 04:33:18PM -0300, James Almer wrote: On 8/24/2018 3:56 PM, Devin Heitmueller wrote: Create a new av_get_frame_filename3() API which is just like the previous version but accepts a 64-bit integer for the "number" argument

[FFmpeg-devel] [PATCH] avfilter/f_cue: add cue and acue filters

2018-08-25 Thread Marton Balint
To delay filtering until a given wallclock timestamp. Signed-off-by: Marton Balint --- doc/filters.texi | 36 ++ libavfilter/Makefile | 2 + libavfilter/allfilters.c | 2 + libavfilter/f_cue.c | 182 +++ libavfilter

Re: [FFmpeg-devel] [PATCH] avfilter/f_cue: add cue and acue filters

2018-08-25 Thread Marton Balint
On Sat, 25 Aug 2018, Nicolas George wrote: Marton Balint (2018-08-25): +FFFrameQueue queue; There is already a frame queue in the link, it would be much better to use it rather than having a second one. For that, you need to use a "activate" callback instead of filter_

[FFmpeg-devel] [PATCH] ffplay: do not drain existing filters when seeking

2018-08-25 Thread Marton Balint
After a seek we drop all frames from the filter anyway. Audio filters already had a similar approach. Signed-off-by: Marton Balint --- fftools/ffplay.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 368e262123..5d9121e5b7 100644 --- a/fftools

Re: [FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-08-26 Thread Marton Balint
done by libklvanc. Libklvanc can be found at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos , Aaron Levinson , and Moritz Barsnick Thanks, I have a few minor (mostly code style) comments below: Signed-off-by: Devin Heitmueller

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-26 Thread Marton Balint
On Wed, 22 Aug 2018, Devin Heitmueller wrote: Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Updated to reflect feedback from Marton Balint , Carl Eugen

[FFmpeg-devel] [PATCH] avformat/mxfdec: do not use sound essence descriptor quantization bits for bits_per_coded_sample

2018-08-26 Thread Marton Balint
It refers to the uncompressed quantization, therefore is not correct for AAC. Also change mxf_set_pts to work based on current edit unit if bits_per_coded_sample is not available. Fixes error messages in the sample of ticket #7366. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 11

Re: [FFmpeg-devel] [PATCH] ffmpeg: block output == input for files

2018-08-27 Thread Marton Balint
On Tue, 28 Aug 2018, Gyan Doshi wrote: With some regularity, we have users trying to update input files using ffmpeg, usually for the purposes of tagging, but occasionally for changing the encoding or something else. Other apps like mp4box or taggers edit the files in-place i.e. destinatio

[FFmpeg-devel] [PATCH] avfilter/vf_framerate: switch to activate

2018-08-28 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/vf_framerate.c | 119 - 1 file changed, 63 insertions(+), 56 deletions(-) diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c index 3e2615be5e..fb65381923 100644 --- a/libavfilter

Re: [FFmpeg-devel] make work (live) libsrt

2018-08-28 Thread Marton Balint
00:00:00 2001 From: Tudor Suciu Date: Sat, 25 Aug 2018 14:06:57 +0200 Subject: [PATCH] avformat/libsrt: add pkt_size parameter to libsrt Also make sure we set the URL context max packet size accordingly. Signed-off-by: Marton Balint --- configure| 2 +- doc/protocols.tex

Re: [FFmpeg-devel] make work (live) libsrt

2018-08-29 Thread Marton Balint
On Wed, 29 Aug 2018, Tudor Suciu wrote: Hello Marton, And should simply set SRTO_PACKETSIZE to our pkt_size parameter if we don't want the libsrt default 1356. At least for the specific case of mpegts I believe it's much better to have fixed size packets(188x*). It helps error recovery if

Re: [FFmpeg-devel] [PATCH] ffmpeg: block output == input for files

2018-08-30 Thread Marton Balint
On Thu, 30 Aug 2018, Paul B Mahol wrote: On 8/30/18, Gyan Doshi wrote: On 29-08-2018 09:48 AM, Gyan Doshi wrote: On 29-08-2018 02:43 AM, Michael Niedermayer wrote: On Tue, Aug 28, 2018 at 08:31:51AM +0200, Marton Balint wrote: Instead of this, maybe we should add support to write lock

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-01 Thread Marton Balint
On Sat, 1 Sep 2018, Gyan Doshi wrote: From aab52de703302d26d0bd83fb28eb1a033fa57d14 Mon Sep 17 00:00:00 2001 From: Gyan Doshi Date: Sat, 1 Sep 2018 11:33:17 +0530 Subject: [PATCH] ffplay: add option to allow custom jump interval At present, left and right keys are hardcoded to jump by 10 seco

Re: [FFmpeg-devel] [PATCH] ffplay: do not drain existing filters when seeking

2018-09-01 Thread Marton Balint
On Sun, 26 Aug 2018, Marton Balint wrote: After a seek we drop all frames from the filter anyway. Audio filters already had a similar approach. Signed-off-by: Marton Balint --- fftools/ffplay.c | 2 ++ 1 file changed, 2 insertions(+) Pushed. Regards, Marton

Re: [FFmpeg-devel] make work (live) libsrt

2018-09-01 Thread Marton Balint
e srt clients like gstreamer I pushed the patch which adds the pkt_size option and also fixes the error you were seeing. I cannot comment on the other things. Regards, Marton Regards, On Wed, Aug 29, 2018 at 10:48 AM Marton Balint wrote: On Wed, 29 Aug 2018, Tudor Suciu wrote: > Hell

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not use sound essence descriptor quantization bits for bits_per_coded_sample

2018-09-01 Thread Marton Balint
On Sun, 26 Aug 2018, Marton Balint wrote: It refers to the uncompressed quantization, therefore is not correct for AAC. Also change mxf_set_pts to work based on current edit unit if bits_per_coded_sample is not available. Fixes error messages in the sample of ticket #7366. Ping, will push

Re: [FFmpeg-devel] [PATCH] avfilter/f_cue: add cue and acue filters

2018-09-01 Thread Marton Balint
On Sat, 25 Aug 2018, Marton Balint wrote: On Sat, 25 Aug 2018, Nicolas George wrote: Marton Balint (2018-08-25): +FFFrameQueue queue; There is already a frame queue in the link, it would be much better to use it rather than having a second one. For that, you need to use a "act

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-02 Thread Marton Balint
On Sun, 2 Sep 2018, Gyan Doshi wrote: On 01-09-2018 10:25 PM, Marton Balint wrote: In the descriptive text write "seeking" instead of jumping. @item -nodisp Disable graphical display. @item -noborder diff --git a/fftools/ffplay.c b/fftools/ffplay.c index 368e262123..83eef17

[FFmpeg-devel] [PATCH] avformat/libsrt: fix merge of payload_size option

2018-09-02 Thread Marton Balint
Fixes a compile error and re-adds pkt_size as a url?option as well. Signed-off-by: Marton Balint --- libavformat/libsrt.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/libsrt.c b/libavformat/libsrt.c index 9795e279e8..fbfd6ace83 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/libsrt: fix merge of payload_size option

2018-09-03 Thread Marton Balint
On Sun, 2 Sep 2018, James Almer wrote: On 9/2/2018 8:58 PM, Marton Balint wrote: Fixes a compile error and re-adds pkt_size as a url?option as well. Sorry about that. I made sure to keep the logic as you added it a few days ago instead of adopting the one from libav, including keeping the

Re: [FFmpeg-devel] [PATCH] ffplay: add option to allow custom jump interval

2018-09-05 Thread Marton Balint
On Wed, 5 Sep 2018, Gyan Doshi wrote: On 03-09-2018 11:03 AM, Gyan Doshi wrote: On 02-09-2018 02:57 PM, Marton Balint wrote: I don't think the guards are necessary, it might make sense for somebody to reverse the meaning of left and right keys, therefore use a negative value.

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: do not use sound essence descriptor quantization bits for bits_per_coded_sample

2018-09-05 Thread Marton Balint
On Sat, 1 Sep 2018, Marton Balint wrote: On Sun, 26 Aug 2018, Marton Balint wrote: It refers to the uncompressed quantization, therefore is not correct for AAC. Also change mxf_set_pts to work based on current edit unit if bits_per_coded_sample is not available. Fixes error messages in

Re: [FFmpeg-devel] [PATCH] fix MXF audio PTS calculation for compressed audio (ADTS/AAC)

2018-09-05 Thread Marton Balint
On Tue, 4 Sep 2018, Markus Schumann wrote: --- libavformat/mxfdec.c | 67 +++- 1 file changed, 66 insertions(+), 1 deletion(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 8e1089620f..adfffd954a --- a/libavformat/mxfdec.c +++ b/libavfor

Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: switch to activate

2018-09-05 Thread Marton Balint
On Tue, 28 Aug 2018, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/vf_framerate.c | 119 - 1 file changed, 63 insertions(+), 56 deletions(-) Ping, will push soon. Regards, Marton diff --git a/libavfilter/vf_framerate.c b

[FFmpeg-devel] [PATCH 1/2] avutil/file: do not request PROT_WRITE in av_file_map

2018-09-06 Thread Marton Balint
The documentation states that av_file_map can only be used for reading and for WIN32 we are already requesting a read only mapping. Signed-off-by: Marton Balint --- libavutil/file.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavutil/file.c b/libavutil/file.c index

[FFmpeg-devel] [PATCH 2/2] avutil/file: allow mapping 0 byte files with av_file_map

2018-09-06 Thread Marton Balint
Signed-off-by: Marton Balint --- libavutil/file.c | 8 libavutil/file.h | 2 ++ 2 files changed, 10 insertions(+) diff --git a/libavutil/file.c b/libavutil/file.c index 2153e51379..64f11fed76 100644 --- a/libavutil/file.c +++ b/libavutil/file.c @@ -85,6 +85,11 @@ int av_file_map(const

Re: [FFmpeg-devel] [PATCH] avfilter/f_cue: add cue and acue filters

2018-09-06 Thread Marton Balint
On Sat, 1 Sep 2018, Bodecs Bela wrote: Hi Balint, 2018.08.25. 20:35 keltezéssel, Marton Balint írta: To delay filtering until a given wallclock timestamp. Signed-off-by: Marton Balint --- doc/filters.texi | 36 ++ libavfilter/Makefile | 2 + libavfilter

[FFmpeg-devel] [PATCH] avdevice/decklink_enc: add support for setting duplex mode

2018-09-06 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/outdevs.texi | 4 libavdevice/decklink_enc.cpp | 1 + libavdevice/decklink_enc_c.c | 4 libavdevice/version.h| 2 +- 4 files changed, 10 insertions(+), 1 deletion(-) diff --git a/doc/outdevs.texi b/doc/outdevs.texi index

Re: [FFmpeg-devel] [PATCH] avfilter/f_cue: add cue and acue filters

2018-09-06 Thread Marton Balint
On Thu, 6 Sep 2018, Bodecs Bela wrote: Hi Balint, 2018.09.06. 22:20 keltezéssel, Marton Balint írta: On Sat, 1 Sep 2018, Bodecs Bela wrote: Hi Balint, 2018.08.25. 20:35 keltezéssel, Marton Balint írta: To delay filtering until a given wallclock timestamp. Signed-off-by: Marton

Re: [FFmpeg-devel] segment: Create missing directories

2018-09-07 Thread Marton Balint
On Thu, 6 Sep 2018, Julien Gaulmin wrote: I find this patch very useful. Here is a version against master as recommended by Ricardo. Works well for me. Thanks Georgi. Le 20/02/2018 à 12:17, Georgi Chorbadzhiyski a écrit : The attached patch allows segment muxer to be used for file archiving

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_enc: add support for setting duplex mode

2018-09-09 Thread Marton Balint
On Thu, 6 Sep 2018, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/outdevs.texi | 4 libavdevice/decklink_enc.cpp | 1 + libavdevice/decklink_enc_c.c | 4 libavdevice/version.h| 2 +- 4 files changed, 10 insertions(+), 1 deletion(-) Applied. Regards

Re: [FFmpeg-devel] [PATCH 2/2] avutil/file: allow mapping 0 byte files with av_file_map

2018-09-09 Thread Marton Balint
On Fri, 7 Sep 2018, Michael Niedermayer wrote: On Thu, Sep 06, 2018 at 08:58:37PM +0200, Marton Balint wrote: Signed-off-by: Marton Balint --- libavutil/file.c | 8 libavutil/file.h | 2 ++ 2 files changed, 10 insertions(+) probably ok Thanks, applied. Regards, Marton

Re: [FFmpeg-devel] [PATCH] avfilter/vf_framerate: switch to activate

2018-09-09 Thread Marton Balint
On Wed, 5 Sep 2018, Marton Balint wrote: On Tue, 28 Aug 2018, Marton Balint wrote: Signed-off-by: Marton Balint --- libavfilter/vf_framerate.c | 119 - 1 file changed, 63 insertions(+), 56 deletions(-) Ping, will push soon. Pushed

Re: [FFmpeg-devel] [PATCH] avfilter/f_cue: add cue and acue filters

2018-09-09 Thread Marton Balint
2018.08.25. 20:35 keltezéssel, Marton Balint írta: To delay filtering until a given wallclock timestamp. Signed-off-by: Marton Balint ---   doc/filters.texi |  36 ++   libavfilter/Makefile |   2 +   libavfilter/allfilters.c |   2 +   libavfilter/f_cue.c  | 182

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

2018-09-09 Thread Marton Balint
On Fri, 7 Sep 2018, Devin Heitmueller wrote: The following patches add support for output of 708 and AFD over the Decklink SDI interface. This series is a subset of a series submitted in early January, with the hope of getting the less controversial parts merged upstream. Note compared to th

Re: [FFmpeg-devel] [PATCH] avfilter/f_cue: add cue and acue filters

2018-09-09 Thread Marton Balint
On Sun, 9 Sep 2018, Nicolas George wrote: Marton Balint (2018-09-09): And finally applied. If Nicolas or anybody can provide some pointers on how to get rid of the extra frame queue, then I will be more than happy to work on it. I am sorry, I am currently having a very annoying trouble

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

2018-09-10 Thread Marton Balint
On Sun, 9 Sep 2018, Devin Heitmueller wrote: On Sun, Sep 9, 2018 at 4:59 PM, Marton Balint wrote: Thanks, I applied patches 1-4. decklink: Add support for output of Active Format Description (AFD) Regarding this one, I noticed you always set the AFD in line 12. Are you sure that it

Re: [FFmpeg-devel] FFmpeg 4.1

2018-09-19 Thread Marton Balint
On Fri, 14 Sep 2018, Michael Niedermayer wrote: Hi all its almost 5 months since 4.0 so its time to make a new release. Are there any suggestions for a name ? If not ill pick something from unused past suggestions. If there are no objections i will likely make that release in the next week

[FFmpeg-devel] [PATCH] avdevice/decklink: add support for selecting devices based on their unique ID

2018-09-20 Thread Marton Balint
Also bump the API version requirement to 10.9.5, because on olders versions there were some reports of crashes using the undocumented, yet available BMDDeckLinkDeviceHandle. Signed-off-by: Marton Balint --- configure | 2 +- doc/indevs.texi | 3 ++- doc

[FFmpeg-devel] [PATCH 3/4] avformat/rtpproto: use factorized ip functions

2018-09-20 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/Makefile | 2 +- libavformat/rtpproto.c | 126 - 2 files changed, 11 insertions(+), 117 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 467ae2d87e..e0222535c1 100644

[FFmpeg-devel] [PATCH 2/4] avformat/udp: use factorized ip functions

2018-09-20 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/Makefile | 4 +- libavformat/udp.c| 123 +-- 2 files changed, 23 insertions(+), 104 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index ccb39b5469..467ae2d87e 100644 --- a

[FFmpeg-devel] [PATCH 1/4] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-20 Thread Marton Balint
These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint --- libavformat/ip.c | 165 +++ libavformat/ip.h | 70 +++ 2 files changed, 235 insertions(+) create mode 100644 libavformat

[FFmpeg-devel] [PATCH 4/4] avformat/udp: add support for generic source filtering

2018-09-20 Thread Marton Balint
This allows getting data only from a specific source IP. This is useful not only for unicast but for multicast as well because multicast source subscriptions do not act as source filters for the incoming packets. Signed-off-by: Marton Balint --- doc/protocols.texi | 8 libavformat

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add support for selecting devices based on their unique ID

2018-09-21 Thread Marton Balint
On Fri, 21 Sep 2018, Jeyapal, Karthick wrote: On 9/21/18 3:35 AM, Marton Balint wrote: Also bump the API version requirement to 10.9.5, because on olders versions there were some reports of crashes using the undocumented, yet available BMDDeckLinkDeviceHandle. If we are using an

Re: [FFmpeg-devel] [PATCH 1/4] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-22 Thread Marton Balint
On Sat, 22 Sep 2018, Michael Niedermayer wrote: On Fri, Sep 21, 2018 at 12:11:59AM +0200, Marton Balint wrote: These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint [...] Thanks, I will resubmit the patch series with some extra docs

[FFmpeg-devel] [PATCH 2/7] avformat/udp: use factorized ip functions

2018-09-22 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/Makefile | 4 +- libavformat/udp.c| 123 +-- 2 files changed, 23 insertions(+), 104 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index ccb39b5469..467ae2d87e 100644 --- a

[FFmpeg-devel] [PATCH 1/7] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-22 Thread Marton Balint
These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint --- libavformat/ip.c | 165 +++ libavformat/ip.h | 74 + 2 files changed, 239 insertions(+) create mode 100644

[FFmpeg-devel] [PATCH 3/7] avformat/rtpproto: use factorized ip functions

2018-09-22 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/Makefile | 2 +- libavformat/rtpproto.c | 126 - 2 files changed, 11 insertions(+), 117 deletions(-) diff --git a/libavformat/Makefile b/libavformat/Makefile index 467ae2d87e..e0222535c1 100644

[FFmpeg-devel] [PATCH 5/7] avformat/udp: specify the local address for some source filtered multicast joins

2018-09-22 Thread Marton Balint
, and that interface might be different from the one set in localaddr. For blocked sources this even casues EINVAL because we joined the multicast group on a different interface. Signed-off-by: Marton Balint --- libavformat/udp.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions

[FFmpeg-devel] [PATCH 7/7] doc/protocols: simplify and clarify UDP localaddr option

2018-09-22 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/protocols.texi | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 7173bb173a..b34f29eebf 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi @@ -1544,9 +1544,8 @@ packet bursts

[FFmpeg-devel] [PATCH 4/7] avformat/udp: add support for generic source filtering

2018-09-22 Thread Marton Balint
This allows getting data only from a specific source IP. This is useful not only for unicast but for multicast as well because multicast source subscriptions do not act as source filters for the incoming packets. Signed-off-by: Marton Balint --- doc/protocols.texi | 8 libavformat

[FFmpeg-devel] [PATCH 6/7] avformat/udp: always use IP_ADD_SOURCE_MEMBERSHIP for subscribing to an UDP multicast source group in IPv4

2018-09-22 Thread Marton Balint
That alone supports specifying the interface based on its address. Getting the interface index from the local address seems quite a bit of work in a platform independent way... Obviously for IPv6 we still always use MCAST_JOIN_SOURCE_GROUP. Signed-off-by: Marton Balint --- libavformat/udp.c

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: add support for selecting devices based on their unique ID

2018-09-23 Thread Marton Balint
On Sat, 22 Sep 2018, Jeyapal, Karthick wrote: On 9/21/18 5:10 PM, Marton Balint wrote: On Fri, 21 Sep 2018, Jeyapal, Karthick wrote: On 9/21/18 3:35 AM, Marton Balint wrote: Also bump the API version requirement to 10.9.5, because on olders versions there were some reports of crashes

Re: [FFmpeg-devel] libavdevice/decklink trivial patch for SDI input/output

2018-09-23 Thread Marton Balint
On Thu, 6 Sep 2018, Baldur Gislason wrote: Sending this again as the mime type was wrong for the patch on the last message. I have prepared a patch that adds two things. On the Decklink input side, it adds a parameter called 'passthrough' which makes it possible to change from the default beha

Re: [FFmpeg-devel] [PATCH 1/7] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-23 Thread Marton Balint
On Sun, 23 Sep 2018, Michael Niedermayer wrote: On Sat, Sep 22, 2018 at 11:53:22PM +0200, Marton Balint wrote: These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint --- libavformat/ip.c | 165

Re: [FFmpeg-devel] [PATCH 1/7] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-23 Thread Marton Balint
On Sun, 23 Sep 2018, James Almer wrote: On 9/23/2018 7:04 PM, Marton Balint wrote: On Sun, 23 Sep 2018, Michael Niedermayer wrote: On Sat, Sep 22, 2018 at 11:53:22PM +0200, Marton Balint wrote: These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton

[FFmpeg-devel] [PATCHv2 1/7] avformat/ip: factorize some IP filtering and resolving functions to a new file

2018-09-23 Thread Marton Balint
These are based on the very similar UDP and RTP protocol functions. Signed-off-by: Marton Balint --- libavformat/ip.c | 159 +++ libavformat/ip.h | 72 + 2 files changed, 231 insertions(+) create mode 100644

Re: [FFmpeg-devel] [PATCH V1 1/3] lavu: Add alpha blending API based on row.

2018-09-25 Thread Marton Balint
On Tue, 25 Sep 2018, Jun Zhao wrote: Add alpha blending API based on row, support global alpha blending/ per-pixel blending, and add SSSE3/AVX2 optimizations of the functions. You might want to take a look at libavfilter/vf_framerate.c and libavfilter/x86/vf_framerate.asm as well, they do

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Add option to align Capture start time

2018-09-26 Thread Marton Balint
On Tue, 25 Sep 2018, Jeyapal, Karthick wrote: On 9/24/18 7:42 PM, Devin Heitmueller wrote: Hello Karthick, On Sep 24, 2018, at 7:49 AM, Karthick J wrote: From: Karthick Jeyapal This option is useful for maintaining input synchronization across N different hardware devices deployed for

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Add option to align Capture start time

2018-09-27 Thread Marton Balint
On Mon, 24 Sep 2018, Karthick J wrote: From: Karthick Jeyapal This option is useful for maintaining input synchronization across N different hardware devices deployed for 'N-way' redundancy. The system time of different hardware devices should be synchronized with protocols such as NTP or PT

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/libzvbi-teletextdec: formatted ass output

2018-09-29 Thread Marton Balint
On Thu, 17 May 2018, Aman Gupta wrote: On Sun, May 6, 2018 at 2:05 PM, Marton Balint wrote: Inspired by the VideoLAN text decoder and its port to FFmpeg made by Aman Gupta. This got kind of forgotten, but now I pushed it after a rebase and a minor fix

<    1   2   3   4   5   6   7   8   9   10   >