Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/mpegts: Extract arib_caption descriptor data into codecpar->extradata

2021-04-11 Thread Marton Balint
On Sat, 10 Apr 2021, zheng qian wrote: Changes since v1: If desc_len < 3, break the switch statement instead of return AVERROR_INVALIDDATA to make it more robust. For arib_caption, data_component_descriptor should contains at least 3 bytes: data_component_id: uint16, additional_arib_capti

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/muxers: add entries for raw muxers

2021-04-11 Thread Marton Balint
On Sun, 11 Apr 2021, Anton Khirnov wrote: Quoting Gyan Doshi (2021-04-11 12:52:18) On 2021-04-11 15:27, Carl Eugen Hoyos wrote: > Am So., 11. Apr. 2021 um 08:41 Uhr schrieb Gyan Doshi : >> ffmpeg | branch: master | Gyan Doshi | Sat Apr 10 16:35:53 2021 +0530| [47b8871ca6f9da4c0467466a43d2

Re: [FFmpeg-devel] [PATCH 2/2] avfilter/af_mcompand: check allocation results

2021-04-18 Thread Marton Balint
On Sat, 10 Apr 2021, Marton Balint wrote: On Sat, 10 Apr 2021, Andreas Rheinhardt wrote: Marton Balint: Fixes the only remaining part of ticket #8931. Signed-off-by: Marton Balint --- libavfilter/af_mcompand.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavfilter

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: private_stream_1 is not asynchronous KLV

2021-04-18 Thread Marton Balint
On Sat, 17 Apr 2021, Mao Hata wrote: According to ISO/IEC 13818-1, private_stream_1 is a synchronous (has PTS/DTS) stream. Asynchronous one is private_stream_2. Which section describes this? Also keep in mind that code was added so that AV_CODEC_ID_SMPTE_KLV is handled in mpegts, and SMPT

Re: [FFmpeg-devel] [PATCH] avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD

2021-04-18 Thread Marton Balint
On Fri, 16 Apr 2021, Brad Smith wrote: ping. Will apply, thanks. Marton On 4/3/2021 2:49 PM, Brad Smith wrote: avutil/cpu: Use HW_NCPUONLINE to detect # of online CPUs with OpenBSD Signed-off-by: Brad Smith --- libavutil/cpu.c | 6 ++ 1 file changed, 6 insertions(+) diff --gi

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: Fix mpegts_write_pes() for private_stream_2 and other types

2021-04-19 Thread Marton Balint
On Tue, 20 Apr 2021, zheng qian wrote: According to the PES packet definition defined in Table 2-17 of ISO_IEC_13818-1 specification, some fields like PTS/DTS or pes_extension could only appears if the stream_id meets the condition: if (stream_id != 0xBC && // program_stream_map stream_id !

Re: [FFmpeg-devel] [PATCH v3 1/1] avformat/mpegtsenc: Write necessary descriptors into PMT for arib_caption muxing

2021-04-19 Thread Marton Balint
On Mon, 19 Apr 2021, zheng qian wrote: Is there anyone who could review this patch? Jan was interested in this, so preferably he should also comment, but it looks fine to me. Thanks, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Marton Balint
On Wed, 29 Apr 2020, leozhang wrote: In some applications, it is required to add delay to live streaming. In what applications? And if you do this, why not run sleep 20; ffmpeg I don't see how this is useful at all. And what is -paced? What it is used for? Isn't it the same as using

Re: [FFmpeg-devel] [PATCH] avutil/opt: only skip evaluation for rational options

2020-04-29 Thread Marton Balint
On Sat, 18 Apr 2020, Marton Balint wrote: Fixes problems when non-rational options were set using rational expressions, causing rounding errors and the option range limits not to be enforced properly. ffmpeg -f lavfi -i "sine=r=96000/2" This caused an assertion failure with asse

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add support for microseconds since epoch based sequence number

2020-04-29 Thread Marton Balint
On Sat, 18 Apr 2020, Marton Balint wrote: Sequence numbers of segments should be unique, if an encoder is using shorter than 1 second segments and it is restarted, then future segments will be using already used sequence numbers if initial sequence number is based on the number of seconds

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-29 Thread Marton Balint
On Thu, 30 Apr 2020, Tao Zhang wrote: Marton Balint 于2020年4月30日周四 上午12:03写道: On Wed, 29 Apr 2020, leozhang wrote: > In some applications, it is required to add delay to live streaming. In what applications? And if you do this, why not run sleep 20; ffmpeg In live stream

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-04-30 Thread Marton Balint
On Thu, 30 Apr 2020, Tao Zhang wrote: Marton Balint 于2020年4月30日周四 上午4:55写道: On Thu, 30 Apr 2020, Tao Zhang wrote: > Marton Balint 于2020年4月30日周四 上午12:03写道: >> >> >> >> On Wed, 29 Apr 2020, leozhang wrote: >> >> > In some applications, it

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-05-01 Thread Marton Balint
On Fri, 1 May 2020, lance.lmw...@gmail.com wrote: On Sat, Apr 04, 2020 at 08:25:31AM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/encoders.texi | 8 libavcodec/mpeg12enc.c | 22 +- libavcodec/mpegvideo.h | 1 +

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-05-01 Thread Marton Balint
On Fri, 1 May 2020, lance.lmw...@gmail.com wrote: On Fri, May 01, 2020 at 12:32:44PM +0200, Marton Balint wrote: On Fri, 1 May 2020, lance.lmw...@gmail.com wrote: > On Sat, Apr 04, 2020 at 08:25:31AM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > >

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-05-01 Thread Marton Balint
On Thu, 30 Apr 2020, Tao Zhang wrote: Andreas Rheinhardt 于2020年4月30日周四 下午4:23写道: Tao Zhang: > Marton Balint 于2020年4月30日周四 下午3:26写道: >> >> >> >> On Thu, 30 Apr 2020, Tao Zhang wrote: >> >>> Marton Balint 于2020年4月30日周四 上午4:55写道: >>>&g

Re: [FFmpeg-devel] [PATCH v3 2/2] avcodec/mpeg12enc: Support mpeg2 encoder profile with const options

2020-05-01 Thread Marton Balint
On Fri, 1 May 2020, lance.lmw...@gmail.com wrote: On Fri, May 01, 2020 at 03:22:32PM +0200, Marton Balint wrote: On Fri, 1 May 2020, lance.lmw...@gmail.com wrote: > On Fri, May 01, 2020 at 12:32:44PM +0200, Marton Balint wrote: > > > > > > On Fri, 1 May 2020, l

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add support for microseconds since epoch based sequence number

2020-05-01 Thread Marton Balint
On Thu, 30 Apr 2020, Steven Liu wrote: 2020年4月30日 上午12:29,Marton Balint 写道: On Sat, 18 Apr 2020, Marton Balint wrote: Sequence numbers of segments should be unique, if an encoder is using shorter than 1 second segments and it is restarted, then future segments will be using already

Re: [FFmpeg-devel] [PATCH] avutil/opt: only skip evaluation for rational options

2020-05-01 Thread Marton Balint
On Wed, 29 Apr 2020, Marton Balint wrote: On Sat, 18 Apr 2020, Marton Balint wrote: Fixes problems when non-rational options were set using rational expressions, causing rounding errors and the option range limits not to be enforced properly. ffmpeg -f lavfi -i "sine=r=96000/2&q

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/decode: use a single list bsf for codec decode bsfs

2020-05-01 Thread Marton Balint
On Tue, 28 Apr 2020, Marton Balint wrote: On Sun, 26 Apr 2020, James Almer wrote: On 4/26/2020 5:34 AM, Marton Balint wrote: void avcodec_flush_buffers(AVCodecContext *avctx) { AVCodecInternal *avci = avctx->internal; @@ -2117,7 +2001,7 @@ void avcodec_flush_buffers(AVCodecCont

Re: [FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_opt: use av_bsf_list_parse_str for parsing bsf lists

2020-05-01 Thread Marton Balint
On Sun, 26 Apr 2020, James Almer wrote: On 4/25/2020 3:55 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffmpeg_opt.c | 57 +++- 1 file changed, 3 insertions(+), 54 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: Don't use heap allocated array to store pids

2020-05-01 Thread Marton Balint
On Thu, 30 Apr 2020, Andriy Gelman wrote: From: Andriy Gelman A temporary heap array currently stores pids from all streams. It is used to make sure there are no duplicated pids. However, this array is not needed because the pids from past streams are stored in the MpegTSWriteStream structs

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: Remove two duplicated fields

2020-05-01 Thread Marton Balint
On Thu, 30 Apr 2020, Andriy Gelman wrote: From: Andriy Gelman ts->{tsid,onid} stores the values of ts->{transport_stream_id,original_network_id} Signed-off-by: Andriy Gelman --- libavformat/mpegtsenc.c | 10 +++--- 1 file changed, 3 insertions(+), 7 deletions(-) LGTM, thanks. Marton

Re: [FFmpeg-devel] [PATCH 1/1] ensure closed caption info which is visible in default stream dump is also available in results when -show_streams is used

2020-05-01 Thread Marton Balint
On Wed, 29 Apr 2020, vectronic wrote: Signed-off-by: vectronic --- doc/ffprobe.xsd | 1 + fftools/ffprobe.c | 2 ++ tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +- tests/ref/fate/concat-demuxer-ex

Re: [FFmpeg-devel] fix:?==?utf-8?q? rtsp/transport parser should accept comma for parameters

2020-05-01 Thread Marton Balint
On Fri, 1 May 2020, abalam wrote: I needed this fix to make [Shinobi](https://github.com/ShinobiCCTV/Shinobi) works with recent chinese cameras. We can read that FFmpeg is perfectly following the [RTSP specs](https://tools.ietf.org/html/rfc2326#page-58) :  `Transports are comma separated,

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-05-02 Thread Marton Balint
On Sat, 2 May 2020, Tao Zhang wrote: Marton Balint 于2020年5月1日周五 下午9:35写道: On Thu, 30 Apr 2020, Tao Zhang wrote: > Andreas Rheinhardt 于2020年4月30日周四 下午4:23写道: >> >> Tao Zhang: >> > Marton Balint 于2020年4月30日周四 下午3:26写道: >> >> >> >>

Re: [FFmpeg-devel] [PATCH v1 1/3] doc/protocols: clarify timeout and latency unit of measurement for SRT

2020-05-02 Thread Marton Balint
On Sat, 2 May 2020, Nicolas George wrote: lance.lmw...@gmail.com (12020-05-02): will apply the patch set tomorrow if no comments. I lost track of all these patches, I thought the options were to be changed to AV_OPT_TYPE_DURATION. That would break existing command lines... Regards, Marto

Re: [FFmpeg-devel] [PATCH v2 1/2] avcodec/decode: use a single list bsf for codec decode bsfs

2020-05-02 Thread Marton Balint
On Fri, 1 May 2020, Marton Balint wrote: On Tue, 28 Apr 2020, Marton Balint wrote: On Sun, 26 Apr 2020, James Almer wrote: On 4/26/2020 5:34 AM, Marton Balint wrote: void avcodec_flush_buffers(AVCodecContext *avctx) { AVCodecInternal *avci = avctx->internal; @@ -2117,7 +200

Re: [FFmpeg-devel] [PATCH 3/3] fftools/ffmpeg_opt: use av_bsf_list_parse_str for parsing bsf lists

2020-05-02 Thread Marton Balint
On Fri, 1 May 2020, Marton Balint wrote: On Sun, 26 Apr 2020, James Almer wrote: On 4/25/2020 3:55 PM, Marton Balint wrote: Signed-off-by: Marton Balint --- fftools/ffmpeg_opt.c | 57 +++- 1 file changed, 3 insertions(+), 54 deletions

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/proresenc_anatoliy: support for more color matrix for proresenc

2020-05-03 Thread Marton Balint
On Tue, 5 Nov 2019, lance.lmw...@gmail.com wrote: From: Limin Wang Please tested with below command: ./ffmpeg -i ../fate-suite/mpeg2/t.mpg -c:v prores_aw -color_primaries bt2020 -colorspace bt2020_ncl -color_trc smpte2084 -an output.mov mediainfo outout.mov ... Color primaries

Re: [FFmpeg-devel] [PATCH v1 2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

2020-05-03 Thread Marton Balint
On Fri, 15 Nov 2019, Limin Wang wrote: ping, the patchset is for HDR/HLG color support for prores. On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang It's based on the following specs: RDD 36:2015 - SMPTE Registered Disclosure Doc - Apple ProRes Bitst

Re: [FFmpeg-devel] [PATCH v1 4/4] avcodec/proresenc_anatoliy: support for more color matrix for proresenc

2020-05-03 Thread Marton Balint
On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: On Sun, May 03, 2020 at 09:53:09AM +0200, Marton Balint wrote: On Tue, 5 Nov 2019, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Please tested with below command: > ./ffmpeg -i ../fate-suite/mpeg2/t.mpg -c

Re: [FFmpeg-devel] [PATCH v1 2/4] avcodec/prores_metadata_bsf: add smpte2084 format support

2020-05-03 Thread Marton Balint
On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: On Sun, May 03, 2020 at 10:01:31AM +0200, Marton Balint wrote: On Fri, 15 Nov 2019, Limin Wang wrote: > > ping, the patchset is for HDR/HLG color support for prores. > > On Mon, Nov 04, 2019 at 07:10:00PM +0800, lance.lmw.

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-05-03 Thread Marton Balint
On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: On Tue, Mar 17, 2020 at 06:55:00PM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang The following command will attempt to create the input and overlay test sequence for you. ./ffmpeg -f lavfi -i color=white:duration=100:r=25:size=1280

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-05-04 Thread Marton Balint
On Mon, 4 May 2020, lance.lmw...@gmail.com wrote: On Sun, May 03, 2020 at 07:10:07PM +0200, Marton Balint wrote: On Sun, 3 May 2020, lance.lmw...@gmail.com wrote: > On Tue, Mar 17, 2020 at 06:55:00PM +0800, lance.lmw...@gmail.com wrote: > > From: Limin Wang > > > >

Re: [FFmpeg-devel] [PATCH] avcodec/prores_metadata_bsf: Use AVCOL_TRC_NB - 1 for the valid max range

2020-05-04 Thread Marton Balint
On Mon, 4 May 2020, lance.lmw...@gmail.com wrote: On Mon, May 04, 2020 at 05:50:32AM +0800, lance.lmw...@gmail.com wrote: From: Limin Wang Report by Marton after commit. Reviewed-by: Marton Balint Signed-off-by: Limin Wang --- libavcodec/prores_metadata_bsf.c | 2 +- 1 file changed, 1

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-05-04 Thread Marton Balint
On Sat, 2 May 2020, Tao Zhang wrote: Marton Balint 于2020年5月2日周六 下午7:05写道: [...] I see. But you could add an option to the fifo muxer to only write header when the first packet arrives. This way you will be able to use a bitstream filter to buffer packets and the fifo muxer will only

Re: [FFmpeg-devel] [PATCH v4 1/8] avformat/mux: move interleaved packet functions upwards

2020-05-04 Thread Marton Balint
On Tue, 28 Apr 2020, Marton Balint wrote: Will be needed later to avoid a forward declaration. Will apply the series soon, this has been delayed for a very long time now... Regards, Marton Signed-off-by: Marton Balint --- libavformat/mux.c | 208

Re: [FFmpeg-devel] [PATCH v4 4/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-05-05 Thread Marton Balint
On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: Previously only 1:1 bitstream filters were supported, the end of the stream was not signalled to the bitstream filters and time base changes were ignored. This change also allows muxers to set up bitstream filters regardless of

Re: [FFmpeg-devel] [PATCH v4 5/8] avcodec/pcm_rechunk_bsf: add bitstream filter to rechunk pcm audio

2020-05-05 Thread Marton Balint
On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: Signed-off-by: Marton Balint --- Changelog | 1 + doc/bitstream_filters.texi | 30 ++ libavcodec/Makefile| 1 + libavcodec/bitstream_filters.c | 1 + libavcodec/pcm_rechunk_bsf.c

Re: [FFmpeg-devel] [PATCH v4 4/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-05-05 Thread Marton Balint
On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: Previously only 1:1 bitstream filters were supported, the end of the stream was not signalled to the bitstream filters and time base changes were ignored. This

Re: [FFmpeg-devel] [PATCH v4 4/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-05-05 Thread Marton Balint
On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: Previously only 1:1 bitstream filters were supported, the end of the stream was not signalled to

Re: [FFmpeg-devel] [PATCH 0/3] Patch set to delay output live stream

2020-05-05 Thread Marton Balint
On Tue, 5 May 2020, Tao Zhang wrote: Marton Balint 于2020年5月5日周二 上午3:48写道: On Sat, 2 May 2020, Tao Zhang wrote: > Marton Balint 于2020年5月2日周六 下午7:05写道: [...] >> I see. But you could add an option to the fifo muxer to only write header >> when the first packet arrives. Th

Re: [FFmpeg-devel] [PATCH v4 4/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-05-05 Thread Marton Balint
On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: Previously only 1:1 bitstream filters were supported, the end of the stream was not signalled to the bitstream filters and time base changes were ignored. This

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-05-06 Thread Marton Balint
On Tue, 21 Apr 2020, lance.lmw...@gmail.com wrote: From: Limin Wang The patch will make audio and subtitle packets be marked as AV_PKT_FLAG_KEY. Why the subtitles? Is it possible that the patch description is outdated? I don't see from the code how would this apply to subtitles, after all

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/mux: Set AV_PKT_FLAG_KEY for is_intra_only packet

2020-05-06 Thread Marton Balint
On Wed, 6 May 2020, lance.lmw...@gmail.com wrote: On Wed, May 06, 2020 at 10:11:22AM +0200, Marton Balint wrote: On Tue, 21 Apr 2020, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The patch will make audio and subtitle packets be marked as AV_PKT_FLAG_KEY. Why the subt

Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles

2020-05-06 Thread Marton Balint
On Wed, 6 May 2020, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of lance.lmw...@gmail.com Sent: Wednesday, May 6, 2020 22:57 To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH, RFC] lavc/options_table: Add basic candidate h264 profiles On Wed, May 06, 2020 at 06:13:10PM +0800,

Re: [FFmpeg-devel] [PATCH v1] avfilter/src_movie: Fix the loop function of dynamic logo

2020-05-06 Thread Marton Balint
On Tue, 5 May 2020, lance.lmw...@gmail.com wrote: On Mon, May 04, 2020 at 09:34:02PM +0200, Marton Balint wrote: On Mon, 4 May 2020, lance.lmw...@gmail.com wrote: > On Sun, May 03, 2020 at 07:10:07PM +0200, Marton Balint wrote: > > > > > > On Sun, 3 May 2020, l

Re: [FFmpeg-devel] [PATCH v2 1/3] avformat/fifo: add options to slow down writing packets to match real time approximately

2020-05-07 Thread Marton Balint
On Thu, 7 May 2020, leozhang wrote: Suggested-by: Nicolas George Reviewed-by: Nicolas George Reviewed-by: Marton Balint Reviewed-by: Andreas Rheinhardt You seem to misunderstand the use of this tag. You should only add these if you received an explict LGTM for your patches. This has

Re: [FFmpeg-devel] [PATCH v2 4/5] avcodec/mpegvideo: return more specific error codes for ff_mpv_common_init()

2020-05-07 Thread Marton Balint
On Thu, 7 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index 22cab28..b5ddb1b 100644 --- a/libav

Re: [FFmpeg-devel] [PATCH v2 5/5] avcodec/mpegvideo: return more specific error codes for init_duplicate_context()

2020-05-07 Thread Marton Balint
On Thu, 7 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/mpegvideo.c b/libavcodec/mpegvideo.c index b5ddb1b..8a74a45 100644 --- a/libavcodec/mpegv

Re: [FFmpeg-devel] [PATCH v4 4/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-05-07 Thread Marton Balint
On Tue, 5 May 2020, Marton Balint wrote: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: Previously only 1:1 bitstream filters were supported, the end of the stream was not signalled to the bitstream filters

Re: [FFmpeg-devel] [WIP] XComposite window capture demuxer (Linux)

2020-05-07 Thread Marton Balint
On Thu, 7 May 2020, Emanuele Oriani wrote: Hi FFMPEG devel, I have been writing a simple XComposite window capture demuxer, heavily inspired from x11grab sources and OBS Window capture logic/code. Have you compared performance to x11grab for various resolutions and frame rates? Do you hav

[FFmpeg-devel] [RFC][PATCH] avformat/fifo: add timeshift option to delay output

2020-05-07 Thread Marton Balint
Signed-off-by: Marton Balint --- libavformat/fifo.c | 59 +- 1 file changed, 58 insertions(+), 1 deletion(-) diff --git a/libavformat/fifo.c b/libavformat/fifo.c index d11dc6626c..17748e94ce 100644 --- a/libavformat/fifo.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH v4 4/8] avformat/mux: add proper support for full N:M bitstream filtering

2020-05-07 Thread Marton Balint
On Thu, 7 May 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 5 May 2020, Marton Balint wrote: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: On Tue, 5 May 2020, Andreas Rheinhardt wrote: Marton Balint: Previously only 1:1 bitstream filters were supported

Re: [FFmpeg-devel] [PATCH] avcodec: Add MediaFoundation encoder wrapper

2020-05-10 Thread Marton Balint
On Sun, 10 May 2020, Martin Storsjö wrote: From: wm4 This contains encoder wrappers for H264, HEVC, AAC, AC3 and MP3. This is based on top of an original patch by wm4 . The original patch supported both encoding and decoding, but this patch only includes encoding. The patch contains furthe

Re: [FFmpeg-devel] [PATCH] libavformat/internal.h - Adjust MAX_URL_SIZE to 8k

2020-05-10 Thread Marton Balint
On Sun, 10 May 2020, Joey Smith wrote: Some real-world sites use an authorization header with a bearer token; when combined with lengthy request parameters to identify the video segment, it's rather trivial these days to have a request body of more than 4k bytes. Because MAX_URL_SIZE is hard-

Re: [FFmpeg-devel] [PATCH] libavformat/internal.h - Adjust MAX_URL_SIZE to 8k

2020-05-10 Thread Marton Balint
rs to be defined but then never used. Do you want a new patch for that, or is it easier for you guys to just go ahead and do that on your end? Please send an updated patch. Thanks, Marton On Sun, May 10, 2020 at 2:17 AM Marton Balint wrote: On Sun, 10 May 2020, Joey Smith wrote: > S

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: prefer to use variable instead of type for sizeof

2020-05-10 Thread Marton Balint
On Sun, 10 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavcodec/mpegvideo.c | 48 1 file changed, 24 insertions(+), 24 deletions(-) If you find these cosmetics interesting, then I suggest you intr

Re: [FFmpeg-devel] [PATCH] avformat/mux: Check pkt->stream_index before using it

2020-05-10 Thread Marton Balint
On Sun, 10 May 2020, Anton Khirnov wrote: Quoting Andreas Rheinhardt (2020-05-08 00:55:00) This commit fixes two recent regressions both of which are about using pkt->stream_index as index in an AVFormatContext's streams array before actually comparing the value with the count of streams in s

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: prefer to use variable instead of type for sizeof

2020-05-10 Thread Marton Balint
On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: On Sun, May 10, 2020 at 06:30:41PM +0200, Marton Balint wrote: On Sun, 10 May 2020, lance.lmw...@gmail.com wrote: > From: Limin Wang > > Signed-off-by: Limin Wang > --- > libavcodec/m

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpegvideo: prefer to use variable instead of type for sizeof

2020-05-11 Thread Marton Balint
On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: On Mon, May 11, 2020 at 01:22:24AM +0200, Marton Balint wrote: On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: > On Sun, May 10, 2020 at 06:30:41PM +0200, Marton Balint wrote: > > > > > > On Sun, 10 May 2020, l

Re: [FFmpeg-devel] [PATCH v2 1/4] avutil/internal: add FF_ALLOC_TYPED_ARRAY_OR_GOTO & FF_ALLOCZ_TYPED_ARRAY_OR_GOTO

2020-05-11 Thread Marton Balint
On Mon, 11 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang These are similar to the existing FF_ALLOC_ARRAY_OR_GOTO & FF_ALLOCZ_ARRAY_OR_GOTO, but the elsize is calcuated by sizeof(*p) Signed-off-by: Limin Wang --- libavutil/internal.h | 18 ++ 1 file changed, 18 i

[FFmpeg-devel] [PATCH 1/6] avutil/opt: add AV_OPT_FLAG_CHILD_CONSTS

2020-05-11 Thread Marton Balint
This will be used for AVCodecContext->profile. By specifying constants in the encoders we won't have to use the common AVCodecContext options table and different encoders can use the same profile name even with different values. Signed-off-by: Marton Balint --- doc/APIchanges

[FFmpeg-devel] [PATCH 2/6] avcodec/options_table: make AVCodecContext->profile search for child constants

2020-05-11 Thread Marton Balint
This change makes it possible for child encoders to define custom profile option names which can be used for setting the AVCodecContext->profile. Also rename unit name to something rather unique, so it won't be used elsewhere. Signed-off-by: Marton Balint --- doc/codecs.texi

[FFmpeg-devel] [PATCH 3/6] avcodec: move aacenc profiles to profiles.h

2020-05-11 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/codecs.texi| 20 libavcodec/aacenc.c| 2 ++ libavcodec/libfdk-aacenc.c | 2 ++ libavcodec/options_table.h | 10 -- libavcodec/profiles.h | 16 5 files changed, 20 insertions(+), 30

[FFmpeg-devel] [PATCH 6/6] avcodec: move mpeg4 profiles to profiles.h

2020-05-11 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/codecs.texi| 17 ++--- libavcodec/mpeg4videoenc.c | 2 ++ libavcodec/options_table.h | 4 libavcodec/profiles.h | 6 ++ libavcodec/v4l2_m2m_enc.c | 34 ++ 5 files changed, 32 insertions

[FFmpeg-devel] [PATCH 5/6] avcodec: move msbc profile to encoder

2020-05-11 Thread Marton Balint
Signed-off-by: Marton Balint --- libavcodec/options_table.h | 1 - libavcodec/sbcenc.c| 1 + 2 files changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/options_table.h b/libavcodec/options_table.h index cc3224b01a..4c7dca696b 100644 --- a/libavcodec/options_table.h +++ b

[FFmpeg-devel] [PATCH 4/6] avcodec/options_table: remove dts profiles

2020-05-11 Thread Marton Balint
We don't have a dts encoder. Signed-off-by: Marton Balint --- doc/codecs.texi| 10 -- libavcodec/options_table.h | 5 - 2 files changed, 15 deletions(-) diff --git a/doc/codecs.texi b/doc/codecs.texi index 8f62cfaace..c08229ba7e 100644 --- a/doc/codecs.texi +++

Re: [FFmpeg-devel] [PATCH 4/6] avcodec/options_table: remove dts profiles

2020-05-11 Thread Marton Balint
On Mon, 11 May 2020, James Almer wrote: On 5/11/2020 4:35 PM, Marton Balint wrote: We don't have a dts encoder. We do, but it's called dca, same as the decoder. Indeed. But as far as I see it does not use avctx->profile, so it still seems OK to remove these, right? T

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mpegtsenc: Don't use heap allocated array to store pids

2020-05-12 Thread Marton Balint
On Mon, 11 May 2020, Andriy Gelman wrote: On Fri, 01. May 17:54, Marton Balint wrote: On Thu, 30 Apr 2020, Andriy Gelman wrote: > From: Andriy Gelman > > A temporary heap array currently stores pids from all streams. It is > used to make sure there are no duplicated p

Re: [FFmpeg-devel] [PATCH v2 1/4] avutil/internal: add FF_ALLOC_TYPED_ARRAY_OR_GOTO & FF_ALLOCZ_TYPED_ARRAY_OR_GOTO

2020-05-12 Thread Marton Balint
On Tue, 12 May 2020, Nicolas George wrote: lance.lmw...@gmail.com (12020-05-12): No, it's not hard-coded, you can name your own goto label. The label is not hard-coded. The goto is hard-coded. It should not be. Frequently, a return would be enough. You mean this? #define FF_ALLOC_ARRAY

Re: [FFmpeg-devel] [PATCH] avcodec: improve the function of FF_ALLOC{Z}{_ARRAY}_OR_GOTO

2020-05-12 Thread Marton Balint
On Wed, 13 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Please refer to the details here: https://patchwork.ffmpeg.org/project/ffmpeg/patch/1589212343-8334-1-git-send-email-lance.lmw...@gmail.com/ Suggested-by: Nicolas George Signed-off-by: Limin Wang --- libavcodec/aacenc.c

Re: [FFmpeg-devel] [PATCH 1/6] avutil/opt: add AV_OPT_FLAG_CHILD_CONSTS

2020-05-12 Thread Marton Balint
On Tue, 12 May 2020, Michael Niedermayer wrote: On Mon, May 11, 2020 at 09:35:17PM +0200, Marton Balint wrote: This will be used for AVCodecContext->profile. By specifying constants in the encoders we won't have to use the common AVCodecContext options table and different encoders

Re: [FFmpeg-devel] [PATCH] avcodec: improve the function of FF_ALLOC{Z}{_ARRAY}_OR_GOTO

2020-05-12 Thread Marton Balint
On Tue, 12 May 2020, Nicolas George wrote: Marton Balint (12020-05-12): -FF_ALLOCZ_ARRAY_OR_GOTO(avctx, s->buffer.samples, s->channels, 3 * 1024 * sizeof(s->buffer.samples[0]), alloc_fail); -FF_ALLOCZ_ARRAY_OR_GOTO(avctx, s->cpe, s->chan_map[0], sizeof(ChannelEleme

Re: [FFmpeg-devel] [PATCH] avcodec: improve the function of FF_ALLOC{Z}{_ARRAY}_OR_GOTO

2020-05-12 Thread Marton Balint
On Tue, 12 May 2020, Nicolas George wrote: Marton Balint (12020-05-12): And you assume that I want to assign the error code to ret. Wrong. What if I want to return it as is? Assign it to ret and forward ret. Or what if I want to return NULL beacuse the function

Re: [FFmpeg-devel] [PATCH] avcodec: improve the function of FF_ALLOC{Z}{_ARRAY}_OR_GOTO

2020-05-12 Thread Marton Balint
On Tue, 12 May 2020, Nicolas George wrote: Marton Balint (12020-05-12): I think you want to force your preferred pattern to cases which clearly do not benefit from it. I want to prevent any pattern where the error code is lost or invented. We already had enough work old cases where we were

Re: [FFmpeg-devel] [PATCH v2 4/4] avfilter/vf_drawbox: support draw specific face by facedetect metadata

2020-05-13 Thread Marton Balint
On Wed, 13 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- doc/filters.texi | 10 ++ libavfilter/vf_drawbox.c | 27 +++ 2 files changed, 37 insertions(+) diff --git a/doc/filters.texi b/doc/filters.texi index 76e1

Re: [FFmpeg-devel] [RFC]separation of multiple outputs' encoding

2020-05-14 Thread Marton Balint
On Thu, 14 May 2020, Tao Zhang wrote: Hi, FFmpeg supports multiple outputs created out of the same input in the same process like ffmpeg -i input -filter_complex '[0:v]yadif,split=3[out1][out2][out3]' \ -map '[out1]' -s 1280x720 -acodec … -vcodec … output1 \ -map '[out2]' -s 640x

Re: [FFmpeg-devel] [PATCH v6 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

2020-05-14 Thread Marton Balint
On Thu, 14 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Paul B Mahol Signed-off-by: Limin Wang --- libavfilter/vf_framerate.c | 15 +++ 1 file changed, 11 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c

Re: [FFmpeg-devel] [PATCH v6 3/4] avfilter/vf_minterpolate: if metadata lavfi.scd.mafd exists, we'll use it first

2020-05-14 Thread Marton Balint
On Thu, 14 May 2020, lance.lmw...@gmail.com wrote: From: Limin Wang Reviewed-by: Paul B Mahol Signed-off-by: Limin Wang --- libavfilter/vf_minterpolate.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_minterpolate.c b/libavfilter/vf_mint

Re: [FFmpeg-devel] [PATCH v6 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

2020-05-14 Thread Marton Balint
On Thu, 14 May 2020, Nicolas George wrote: Marton Balint (12020-05-14): I am not a huge fan of this patch, mafd refers to a score between this frame and the previous frame, we cannot ensure that there were no additional frame processing between scdet and this filter which may have duplicated

Re: [FFmpeg-devel] [PATCH v6 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

2020-05-14 Thread Marton Balint
On Thu, 14 May 2020, Marton Balint wrote: On Thu, 14 May 2020, Nicolas George wrote: Marton Balint (12020-05-14): I am not a huge fan of this patch, mafd refers to a score between this frame and the previous frame, we cannot ensure that there were no additional frame processing

Re: [FFmpeg-devel] [PATCH v6 2/4] avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first

2020-05-14 Thread Marton Balint
On Thu, 14 May 2020, Paul B Mahol wrote: On 5/14/20, Marton Balint wrote: On Thu, 14 May 2020, Marton Balint wrote: On Thu, 14 May 2020, Nicolas George wrote: Marton Balint (12020-05-14): I am not a huge fan of this patch, mafd refers to a score between this frame and the

[FFmpeg-devel] [PATCH 1/2] Revert "avfilter/vf_minterpolate: if metadata lavfi.scd.mafd exists, we'll use it first"

2020-05-14 Thread Marton Balint
This reverts commit d88e1c9838dbcfe29d7835f2705ffc9ee6a36bf3. Fixes null pointer dereference. Signed-off-by: Marton Balint --- libavfilter/vf_minterpolate.c | 16 1 file changed, 4 insertions(+), 12 deletions(-) diff --git a/libavfilter/vf_minterpolate.c b/libavfilter

[FFmpeg-devel] [PATCH 2/2] Revert "avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first"

2020-05-14 Thread Marton Balint
This reverts commit 339593ca90cb3e05d659ec99a1479904ec742294. Fixes null pointer dereference. Signed-off-by: Marton Balint --- libavfilter/vf_framerate.c | 15 --- 1 file changed, 4 insertions(+), 11 deletions(-) diff --git a/libavfilter/vf_framerate.c b/libavfilter/vf_framerate.c

Re: [FFmpeg-devel] [PATCH 2/2] Revert "avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first"

2020-05-14 Thread Marton Balint
On Thu, 14 May 2020, Carl Eugen Hoyos wrote: Am Do., 14. Mai 2020 um 23:04 Uhr schrieb Marton Balint : This reverts commit 339593ca90cb3e05d659ec99a1479904ec742294. Fixes null pointer dereference. I did not look into the patches, and maybe you could add how the null pointer dereferences

Re: [FFmpeg-devel] [PATCH 2/2] Revert "avfilter/vf_framerate: if metadata lavfi.scd.mafd exists, we'll use it first"

2020-05-15 Thread Marton Balint
On Fri, 15 May 2020, Limin Wang wrote: On Thu, May 14, 2020 at 11:03:49PM +0200, Marton Balint wrote: This reverts commit 339593ca90cb3e05d659ec99a1479904ec742294. Fixes null pointer dereference. Signed-off-by: Marton Balint --- libavfilter/vf_framerate.c | 15 --- 1 file

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Check the next sync byte to avoid incorrectt detected raw packet size

2020-05-15 Thread Marton Balint
On Fri, 15 May 2020, lance.lmw...@gmail.com wrote: On Fri, May 15, 2020 at 08:02:44PM +0800, myp...@gmail.com wrote: On Fri, May 15, 2020 at 6:23 PM wrote: > > From: Limin Wang > > reanalyze() may misdetect the new packet size as 204, but it's 188 still actualy, > it'll cause many cc error

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Check the next sync byte to avoid incorrectt detected raw packet size

2020-05-16 Thread Marton Balint
On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: On Fri, May 15, 2020 at 06:52:55PM +0200, Marton Balint wrote: On Fri, 15 May 2020, lance.lmw...@gmail.com wrote: > On Fri, May 15, 2020 at 08:02:44PM +0800, myp...@gmail.com wrote: > > On Fri, May 15, 2020 at 6:23

[FFmpeg-devel] [RFC] encoder profile validation

2020-05-16 Thread Marton Balint
Hi, As you may know, a recent patchset enabled AVCodecContext->profile constants to reside in encoders. In order to make a full transition to avctx->profile even in existing encoders which might use a private profile setting, we have to make sure only supported avctx->profile values are pass

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Check the next sync byte to avoid incorrectt detected raw packet size

2020-05-16 Thread Marton Balint
On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: On Sat, May 16, 2020 at 11:44:01AM +0200, Marton Balint wrote: On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: > On Fri, May 15, 2020 at 06:52:55PM +0200, Marton Balint wrote: > > > > > > On Fri, 15 May 2020, l

Re: [FFmpeg-devel] [RFC] encoder profile validation

2020-05-16 Thread Marton Balint
On Sat, 16 May 2020, Fu, Linjie wrote: From: ffmpeg-devel On Behalf Of Marton Balint Sent: Saturday, May 16, 2020 21:52 To: ffmpeg-devel@ffmpeg.org Subject: [FFmpeg-devel] [RFC] encoder profile validation Hi, As you may know, a recent patchset enabled AVCodecContext->profile constants

[FFmpeg-devel] [PATCH] fftools/ffmpeg: add new abort_on flag which aborts if there is a stream which received no packets

2020-05-16 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/ffmpeg.texi | 2 ++ fftools/ffmpeg.c | 4 fftools/ffmpeg.h | 3 ++- fftools/ffmpeg_opt.c | 5 +++-- 4 files changed, 11 insertions(+), 3 deletions(-) diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi index ed437bb16f..76fafdcf7e 100644 --- a

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Shuffle avio_seek

2020-05-17 Thread Marton Balint
On Thu, 7 May 2020, Michael Niedermayer wrote: On Thu, May 07, 2020 at 02:09:43PM +0200, Anton Khirnov wrote: Quoting Michael Niedermayer (2020-05-07 12:38:26) This avoids accessing an old, no longer valid buffer. Fixes: out of array access Fixes: crash_audio-2020 Found-by: le wu Signed-of

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: Check the next sync byte to avoid incorrectt detected raw packet size

2020-05-17 Thread Marton Balint
On Sun, 17 May 2020, lance.lmw...@gmail.com wrote: On Sat, May 16, 2020 at 07:36:45PM +0200, Marton Balint wrote: On Sat, 16 May 2020, lance.lmw...@gmail.com wrote: > On Sat, May 16, 2020 at 11:44:01AM +0200, Marton Balint wrote: > > > > > > On Sat, 16 May 2020, l

Re: [FFmpeg-devel] [RFC] encoder profile validation

2020-05-18 Thread Marton Balint
On Mon, 18 May 2020, Anton Khirnov wrote: Quoting Marton Balint (2020-05-16 15:52:22) Hi, As you may know, a recent patchset enabled AVCodecContext->profile constants to reside in encoders. In order to make a full transition to avctx->profile even in existing encoders which might

Re: [FFmpeg-devel] [PATCH 6/6] avcodec: move mpeg4 profiles to profiles.h

2020-05-18 Thread Marton Balint
On Mon, 18 May 2020, Fu, Linjie wrote: diff --git a/libavcodec/profiles.h b/libavcodec/profiles.h index d950971875..e414ea77a7 100644 --- a/libavcodec/profiles.h +++ b/libavcodec/profiles.h @@ -37,6 +37,12 @@ FF_AVCTX_PROFILE_OPTION("mpeg2_aac_low", NULL, AUDIO, FF_PROFILE_MPEG2_AAC_LOW)\

Re: [FFmpeg-devel] [PATCH 1/6] avutil/opt: add AV_OPT_FLAG_CHILD_CONSTS

2020-05-18 Thread Marton Balint
On Mon, 11 May 2020, Marton Balint wrote: This will be used for AVCodecContext->profile. By specifying constants in the encoders we won't have to use the common AVCodecContext options table and different encoders can use the same profile name even with different values. Signed-off-by

Re: [FFmpeg-devel] [WIP] XComposite window capture demuxer (Linux)

2020-05-18 Thread Marton Balint
On Mon, 18 May 2020, Emanuele Oriani wrote: Hi Marton/ffmpeg devs/all, Haven't seen any response to the proposed XComposite windows capture. As per below the reasoning for adding this code to libav*/ffmpeg is that seems to be better in quality than x11grab, although it uses more CPU in its

Re: [FFmpeg-devel] [WIP] XComposite window capture demuxer (Linux)

2020-05-19 Thread Marton Balint
On Tue, 19 May 2020, Lynne wrote: May 19, 2020, 09:23 by e...@fastwebnet.it: Hi Marton, Thanks very much for the feedback; below answers to your points - let me know further feedback if any. And sorry, I cannot say how useful this would be, maybe now is the time for people to speak up if

<    4   5   6   7   8   9   10   11   12   13   >