Re: [FFmpeg-devel] [PATCH 1/8] aacdec: move from scalefactor ranged arrays to flat arrays

On Thu, May 16, 2024 at 12:08:11PM +0200, Lynne via ffmpeg-devel wrote: > AAC uses an unconventional system to send scalefactors > (the volume+quantization value for each band). > Each window is split into either 1 or 8 blocks (long vs short), > and transformed separately from one another, with the

[FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext()

Helps: CID1548380 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/rv34.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/rv34.c b/libavcodec/rv34.c index 23a570bb807..4ce0cc58d05 100644 --- a/libavcodec/rv34.c

[FFmpeg-devel] [PATCH 2/5] avcodec/scpr3: unify adding 127

Untested, i have no testcase nor does fate Signed-off-by: Michael Niedermayer --- libavcodec/scpr3.c | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c index 5271717ac79..79106ddcff8 100644 --- a/libavcodec/scpr3.c +++ b

[FFmpeg-devel] [PATCH 3/5] avcodec/scpr3: Check add_dec() for failure

Fixes: CID1441459 Improper use of negative value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/scpr3.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c index 79106ddcff8..45706123db0

[FFmpeg-devel] [PATCH 4/5] avcodec/sga: Check non constant init_get_bits8()

Fixes: CID1473562 Unchecked return value Fixes: CID1473592 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/sga.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/sga.c b/libavcodec/sga.c index

[FFmpeg-devel] [PATCH 5/5] avcodec/tests/dct: Use 64bit in intermediate for error computation

Fixes: CID1500284 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/dct.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/tests/dct.c b/libavcodec/tests/dct.c index 010d0c1ac35..17a08144597

[FFmpeg-devel] [RFC] STF 2025

Hi all Before this is forgotten again, better start some dicsussion too early than too late I propose that if we have the oppertunity again next year to receive a grant from STF. That we use it to fund: * Paul to work on FFmpeg full time. My idea here is that he can work on whatever he likes

Re: [FFmpeg-devel] [RFC] STF 2025

On Fri, May 17, 2024 at 04:26:55PM +0100, Derek Buitenhuis wrote: > On 5/17/2024 2:49 PM, Michael Niedermayer wrote: > > Also we need more cute girls on these events, everything i hear > > its 100% male geeks/hackers. > > This is gross and sexist. This was definitly not

Re: [FFmpeg-devel] [RFC] STF 2025

On Fri, May 17, 2024 at 11:08:17AM -0400, Vittorio Giovara wrote: > On Fri, May 17, 2024 at 9:50 AM Michael Niedermayer > wrote: > > > Hi all > > > > Before this is forgotten again, better start some dicsussion too early > > than too late > > > > I

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/sga: Check non constant init_get_bits8()

On Fri, May 17, 2024 at 09:53:21AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1473562 Unchecked return value > > Fixes: CID1473592 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer &

Re: [FFmpeg-devel] [PATCH] avcodec/tiff: Fix leak on error

On Fri, May 17, 2024 at 09:51:05PM +0200, Andreas Rheinhardt wrote: > Fixes Coverity issue #1516957. Please mark issues that you fixed in coverity accordingly so that others (like me) see it and know what issues remain outstanding by well looking at the list of outstanding issues thx [...] -- M

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/vc1_loopfilter: Factor duplicate code in vc1_b_h_intfi_loop_filter()

On Wed, May 25, 2022 at 05:53:12PM +0200, Michael Niedermayer wrote: > On Tue, May 24, 2022 at 08:50:51PM +0200, Andreas Rheinhardt wrote: > > Michael Niedermayer: > > > Fixes: CID1435168 > > > > > > Signed-off-by: Michael Niedermayer > > &g

[FFmpeg-devel] [PATCH 1/9] avcodec/tiff: Assert init_get_bits8() success in horizontal_fill()

Helps: CID1441167 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index 19301d9e490..ca7e9f6aba9 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 2/9] avcodec/tiff: Assert init_get_bits8() success in unpack_gray()

Helps: CID1441939 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tiff.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavcodec/tiff.c b/libavcodec/tiff.c index ca7e9f6aba9..31de6ad7308 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 3/9] avcodec/vble: Check av_image_get_buffer_size() for failure

Fixes: CID1461482 Improper use of negative value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vble.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/vble.c b/libavcodec/vble.c index 32157913c77..c585b1ed9fc 100644 --- a/libavcodec/vble.c

[FFmpeg-devel] [PATCH 4/9] avcodec/vc1_block: remove unused off from vc1_decode_p_mb_intfr()

Fixes: CID1435166 Unused value Fixes: CID1529221 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c | 4 1 file changed, 4 deletions(-) diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c index a6ee4922f95..1e8e294ad89

[FFmpeg-devel] [PATCH 5/9] avcodec/vc1_block: remove unneeded store to off in vc1_decode_p_mb_intfi()

Found while reviewing code related to coverity Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavcodec/vc1_block.c b/libavcodec/vc1_block.c index 1e8e294ad89..322acebfe50 100644 --- a

[FFmpeg-devel] [PATCH 6/9] avcodec/vc1_parser: Assert init_get_bits success

The buffer used is a fixed size buffer from the context, it cannot be too large nor can it be NULL Helps: CID1441935 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vc1_parser.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH 7/9] avcodec/vlc: Cleanup on multi table alloc failure in ff_vlc_init_multi_from_lengths()

Fixes: CID1544630 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vlc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vlc.c b/libavcodec/vlc.c index ee09d96fd61..f46ecbb55e9 100644 --- a/libavcodec/vlc.c +++ b

[FFmpeg-devel] [PATCH 8/9] avcodec/vp8: Forward return of ff_vpx_init_range_decoder()

Fixes: CID1507483 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 19f32b34006..8e91613068a 100644 --- a/libavcodec/vp8

[FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert

Fixes: CID1452425 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vp3.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavcodec/vp3.c b/libavcodec/vp3.c index 09527607767..d03a1c9dbc1 100644 --- a/libavcodec/vp3.c

Re: [FFmpeg-devel] [PATCH] avcodec/jpeg2000dec: fix HT block decoder issue #10905

On Fri, May 17, 2024 at 08:00:16PM +, WATANABE Osamu wrote: > Signed-off-by: Pierre-Anthony Lemieux > --- > libavcodec/jpeg2000htdec.c | 122 --- > tests/ref/fate/jpeg2000dec-ds0_ht_01_b11 | 2 +- > 2 files changed, 63 insertions(+), 61 deletions(-) > > diff

Re: [FFmpeg-devel] [PATCH] avcodec/vc1_parser: Check init_get_bits8()

On Fri, May 17, 2024 at 10:16:27PM +0200, Andreas Rheinhardt wrote: > Addresses Coverity issue #1441935. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vc1_parser.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) seems i didnt see this one, as i send a patch for this too a

Re: [FFmpeg-devel] [PATCH 2/9] avcodec/tiff: Assert init_get_bits8() success in unpack_gray()

On Sat, May 18, 2024 at 08:02:28AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Helps: CID1441939 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/tiff.c | 3 ++-

Re: [FFmpeg-devel] [PATCH 4/6] lavf/tls_mbedtls: fix handling of certification validation failures

On Fri, May 17, 2024 at 10:34:41AM +0200, Sfan5 wrote: > We manually check the verification status after the handshake has completed > using mbedtls_ssl_get_verify_result(). However with VERIFY_REQUIRED > mbedtls_ssl_handshake() already returns an error, so this code is never > reached. > Fix that

Re: [FFmpeg-devel] [PATCH] lavd/v4l2: Use proper field type for second parameter of ioctl() with BSD's

On Sat, May 18, 2024 at 07:27:35AM -0400, Brad Smith wrote: > Can this be backported to 7, 6, 5 and 4.4 releases? yes and everyone who has write access to master also has write access to the releases branches! thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB

Re: [FFmpeg-devel] [PATCH 1/5] fftools/ffmpeg_demux: also set -ch_layout avcodec option for -ch_layout CLI param

On Sat, May 18, 2024 at 06:11:12PM +0200, Marton Balint wrote: > The code only set the channel layout of the AVFormatContext, so the user could > not override the channel layout if the demuxer did not have such parameter. > Let's set the specified channel layouts as codec options as well. > > Fixe

[FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure

Fixes: CID1516090 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vqcdec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vqcdec.c b/libavcodec/vqcdec.c index 5c6cab3c1ab..bb69844327d 100644 --- a

[FFmpeg-devel] [PATCH 2/9] avcodec/vvc/ctu: Simplify code at the end of pred_mode_decode()

This simplification assumes that the code is correct Fixes: CID1560036 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vvc/ctu.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec

[FFmpeg-devel] [PATCH 3/9] avcodec/vvc/ctu: Simplify pred_mode_plt_flag

Fixes: CID1560039 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vvc/ctu.c | 23 ++- 1 file changed, 6 insertions(+), 17 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c index 7495ced0d5a

[FFmpeg-devel] [PATCH 4/9] avcodec/vvc/ctu: Remove dead ret check

Fixes: CID1560040 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vvc/ctu.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/libavcodec/vvc/ctu.c b/libavcodec/vvc/ctu.c index b7089b9a004..89eb9d338c7 100644 --- a/libavcodec/vvc/ctu.c

[FFmpeg-devel] [PATCH 5/9] avcodec/vvc/dec: Remove constant eos_at_start

Fixes: CID1560041 'Constant' variable guards dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vvc/dec.c | 6 +- 1 file changed, 1 insertion(+), 5 deletions(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index 2

[FFmpeg-devel] [PATCH 6/9] avcodec/vvc/dec: Check init_get_bits8() for failure

Fixes: CID1560042 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vvc/dec.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/vvc/dec.c b/libavcodec/vvc/dec.c index d262d310125..f2ede490c8b 100644 --- a

[FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf

This might not be needed for correctness but it could help general reproducability of issues Related to: CID1560037 Uninitialized scalar variable Related to: CID1560044 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vvc/mvs.c

[FFmpeg-devel] [PATCH 8/9] avcodec/wavpack: Remove dead assignments

Fixes: CID1442018 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/wavpack.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/wavpack.c b/libavcodec/wavpack.c index d4cf489c0fa..bf9aa0cdcec 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 9/9] avcodec/wavpackenc: Use unsigned for potential 31bit shift

Fixes: CID1465481 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/wavpackenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/wavpackenc.c b/libavcodec/wavpackenc.c index ba0371592d9

Re: [FFmpeg-devel] [PATCH 3/9] avcodec/vvc/ctu: Simplify pred_mode_plt_flag

On Sun, May 19, 2024 at 10:40:57PM +0800, Nuo Mi wrote: > On Sun, May 19, 2024 at 10:49 AM Michael Niedermayer > wrote: > > > Fixes: CID1560039 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/vqcdec: Check init_get_bits8() for failure

On Sun, May 19, 2024 at 01:18:09PM +1000, Peter Ross wrote: > On Sun, May 19, 2024 at 04:49:07AM +0200, Michael Niedermayer wrote: > > Fixes: CID1516090 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > >

Re: [FFmpeg-devel] [PATCH 6/9] avcodec/vvc/dec: Check init_get_bits8() for failure

On Sun, May 19, 2024 at 10:31:50PM +0800, Nuo Mi wrote: > On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer > wrote: > > > Fixes: CID1560042 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer >

Re: [FFmpeg-devel] [PATCH 7/9] avcodec/vvc/mvs: Initialize mvf

On Sun, May 19, 2024 at 10:28:49PM +0800, Nuo Mi wrote: > On Sun, May 19, 2024 at 10:50 AM Michael Niedermayer > wrote: > > > This might not be needed for correctness but it could > > help general reproducability of issues > > > > Related to: CID1560037 Uninitia

Re: [FFmpeg-devel] [PATCH 8/9] avcodec/vp8: Forward return of ff_vpx_init_range_decoder()

On Sat, May 18, 2024 at 11:07:15AM -0400, Ronald S. Bultje wrote: > Hi, > > On Fri, May 17, 2024 at 11:59 PM Michael Niedermayer > wrote: > > > Fixes: CID1507483 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael N

Re: [FFmpeg-devel] [PATCH 9/9] avcodec/vp3: Replace check by assert

On Sat, May 18, 2024 at 06:33:12PM +1000, Peter Ross wrote: > On Sat, May 18, 2024 at 05:57:43AM +0200, Michael Niedermayer wrote: > > Fixes: CID1452425 Logically dead code > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > &

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/rv34: assert that size is not 0 in rv34_gen_vlc_ext()

On Sun, May 19, 2024 at 06:05:20PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Helps: CID1548380 Uninitialized scalar variable > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/rv34.c |

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/qsvdec: Check av_image_get_buffer_size() for failure

On Mon, May 13, 2024 at 01:47:36AM +, Xiang, Haihao wrote: > On Ma, 2024-05-13 at 03:20 +0200, Michael Niedermayer wrote: > > Fixes: CID1477406 Improper use of negative value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > >

[FFmpeg-devel] [PATCH 1/2] avcodec/tests/jpeg2000dwt: Use 64bit in err2 computation

This issue cannot happen with the current function parameters Fixes: CID1500309 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/jpeg2000dwt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec

[FFmpeg-devel] [PATCH 2/2] avcodec/tests/jpeg2000dwt: Use 64bit in comparission

Found while reviewing: CID1500309 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/jpeg2000dwt.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tests/jpeg2000dwt.c b/libavcodec/tests

Re: [FFmpeg-devel] [PATCH] Added alpha layer support v2

On Fri, May 17, 2024 at 12:42:28AM +0200, Andrea Mastroberti via ffmpeg-devel wrote: > doc/filters.texi | 20 +++- > libavfilter/version.h |3 ++- > libavfilter/vf_smartblur.c | 43 +++ > 3 files changed, 56 insertions

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/mpeg12dec: Use 64bit in bit computation

On Sun, May 12, 2024 at 02:03:46AM +0200, Michael Niedermayer wrote: > I dont think this can actually overflow but 64bit seems reasonable to use > > Fixes: CID1521983 Unintentional integer overflow > > Sponsored-by: Sovereign Tech Fund > Signed-off-by: Michael Niedermayer &

Re: [FFmpeg-devel] [PATCH] tests/ref/fate/source: Add exceptions for riscv startcode files

On Sun, May 19, 2024 at 10:49:52AM +0200, Andreas Rheinhardt wrote: > Fixes fate-source. LGTM it can be debated after test targets are fixed what is the best solution thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB I know you won't believe me, but the high

Re: [FFmpeg-devel] [PATCH v2 8/8] aacdec: add a decoder for AAC USAC (xHE-AAC)

On Sun, May 19, 2024 at 06:54:44PM +0200, Lynne via ffmpeg-devel wrote: > This commit adds a decoder for the frequency-domain part of USAC. > > What works: > - Mono > - Stereo (no prediction) > - Stereo (mid/side coding) > - Stereo (complex prediction) > > What's left: > - Speech coding > >

[FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure

Fixes: CID1583742 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/hwcontext_drm.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/hwcontext_drm.c b/libavutil/hwcontext_drm.c index 0847db09a08

Re: [FFmpeg-devel] [PATCH] avutil/hwcontext_drm: Check ioctl in drm_map_frame() for failure

On Mon, May 20, 2024 at 11:33:41AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1583742 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > > libavutil/hwcontext

[FFmpeg-devel] [PATCH 1/7] avutil/random_seed: Avoid dead returns

Fixes: CID1538296 Structurally dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/random_seed.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavutil/random_seed.c b/libavutil/random_seed.c index 6d399cee49c..8a4e4f1fc0b

[FFmpeg-devel] [PATCH 2/7] avutil/tests/dict: Check av_dict_set() before get for failure

Failure is possible due to strdup() Fixes: CID1516764 Dereference null return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/tests/dict.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/libavutil/tests/dict.c b/libavutil

[FFmpeg-devel] [PATCH 3/7] avutil/tests/opt: Check av_set_options_string() for failure

This is test code after all so it should test things Fixes: CID1518990 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavutil/tests/opt.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavutil/tests/opt.c b/libavutil

[FFmpeg-devel] [PATCH 4/7] swscale/x86/swscale: use a clearer name for INPUT_PLANER_RGB_A_FUNC_CASE

related: CID1497114 Missing break in switch Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libswscale/x86/swscale.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libswscale/x86/swscale.c b/libswscale/x86/swscale.c index ff16398988a

[FFmpeg-devel] [PATCH 5/7] swscale/yuv2rgb: Use 64bit for brightness computation

This will not overflow for normal values Fixes: CID1500280 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libswscale/yuv2rgb.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/yuv2rgb.c b/libswscale/yuv2rgb.c

[FFmpeg-devel] [PATCH 6/7] tools/decode_simple: Check avcodec_send_packet() for errors on flushing

This will not error but the API allows errors so we should check it Fixes: CID148 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- tools/decode_simple.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/tools

[FFmpeg-devel] [PATCH 7/7] tools/enc_recon_frame_test: Assert that av_image_get_linesize() succeeds

Helps: CID1524598 Improper use of negative value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- tools/enc_recon_frame_test.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/tools/enc_recon_frame_test.c b/tools/enc_recon_frame_test.c index c099beb3f4b

Re: [FFmpeg-devel] [PATCH 13/13] avformat/flvdec: support all multi-track modes

On Tue, May 21, 2024 at 11:02:22AM +0200, Timo Rothenpieler wrote: > --- > libavformat/flvdec.c | 570 +++ > 1 file changed, 306 insertions(+), 264 deletions(-) infinite loops [flv @ 0x555e803d2940] Video codec (0) is not implemented. Update your FFmpeg v

[FFmpeg-devel] [PATCH 1/7] avdevice/pulse_audio_enc: Use av_rescale() to avoid integer overflow

Fixes: CID1503075 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/pulse_audio_enc.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/libavdevice/pulse_audio_enc.c b/libavdevice/pulse_audio_enc.c

[FFmpeg-devel] [PATCH 2/7] avformat/ac4dec: Check remaining space in ac4_probe()

Fixes: CID1538298 Untrusted loop bound Fixes: undefined behavior Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/ac4dec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/ac4dec.c b/libavformat/ac4dec.c index f647f557ccd..dc6638de3a4 100644

[FFmpeg-devel] [PATCH 3/7] avformat/ape: Use 64bit for final frame size

Fixes: CID1505963 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/ape.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/ape.c b/libavformat/ape.c index c0e3e9f4fe6..f86ca5e894c 100644 --- a

[FFmpeg-devel] [PATCH 4/7] avformat/argo_asf: Use 64bit in offset intermediate

Fixes: CID1467435 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/argo_asf.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/argo_asf.c b/libavformat/argo_asf.c index 61bfc6de1fc..e08f029f80c

[FFmpeg-devel] [PATCH 5/7] avformat/asfdec_f: Use 64bit for preroll computation

Fixes: CID1500342 Unintentional integer overflow Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/asfdec_f.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/asfdec_f.c b/libavformat/asfdec_f.c index fcc2b98a2c4..2441cadb444

[FFmpeg-devel] [PATCH 6/7] avcodec/sga: Make it clear that the return is intentionally not checked

Related: CID1473496 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/sga.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/sga.c b/libavcodec/sga.c index 0f42cf912b2..618df000ada 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 7/7] avcodec/tests/bitstream_template: Make it clear that the return is intentionally not checked

Helps: CID1518967 Unchecked return value Helps: CID1518968 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/tests/bitstream_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/tests

[FFmpeg-devel] [PATCH] avformat/demux: Remove dead stores

Fixes: CID1473512 Unused value Fixes: CID1529228 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/demux.c | 5 - 1 file changed, 5 deletions(-) diff --git a/libavformat/demux.c b/libavformat/demux.c index ecefe7e0a74..d0a5a39d052 100644

Re: [FFmpeg-devel] [PATCH 7/7] avcodec/tests/bitstream_template: Make it clear that the return is intentionally not checked

On Thu, May 23, 2024 at 10:22:56AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Helps: CID1518967 Unchecked return value > > Helps: CID1518968 Unchecked return value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermay

Re: [FFmpeg-devel] [PATCH v5 0/4] Explain what "context" means

On Thu, May 23, 2024 at 09:00:39PM +0100, Andrew Sayers wrote: > NOTE: this patchset depends on [1], and should not be applied before that. > > I think it's important to guide readers between parts of FFmpeg, because > learning how the pieces of the puzzle fit together is a big part of the > newbi

[FFmpeg-devel] [PATCH] web/contact: relink code of conduct

Found-by: John Hawkinson Signed-off-by: Michael Niedermayer --- src/contact | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/contact b/src/contact index 982e9da..537ca9d 100644 --- a/src/contact +++ b/src/contact @@ -11,7 +11,7 @@ avoid https

Re: [FFmpeg-devel] [PATCH v5 1/2] lavu/hashtable: create generic robin hood hash table

On Thu, May 23, 2024 at 03:10:04PM -0700, Connor Worley wrote: > Signed-off-by: Connor Worley > --- > libavutil/Makefile | 2 + > libavutil/hashtable.c | 192 > libavutil/hashtable.h | 91 + > libavutil/tests/hashtable.c

Re: [FFmpeg-devel] [PATCH 2/4] fftools/ffmpeg: rewrite checking whether codec AVOptions have been used

On Thu, May 23, 2024 at 11:03:37AM +0200, Anton Khirnov wrote: > Share the code between encoding and decoding. Instead of checking every > stream's options dictionary (which is also used for other purposes), > track all used options in a dedicated dictionary. > --- > fftools/cmdutils.c| 17

Re: [FFmpeg-devel] [PATCH] avformat/demux: Remove dead stores

On Fri, May 24, 2024 at 08:21:05AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Fixes: CID1473512 Unused value > > Fixes: CID1529228 Unused value > > > > Sponsored-by: Sovereign Tech Fund > > Signed-off-by: Michael Niedermayer > > --- > &g

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/signature_lookup: fix possible division by zero

On Fri, May 24, 2024 at 12:33:11PM +0200, Gerion Entrup wrote: > Am Dienstag, 7. Mai 2024, 19:46:28 MESZ schrieb Michael Niedermayer: > > On Mon, May 06, 2024 at 12:30:39AM +0200, Gerion Entrup wrote: > > > --- > > > libavfilter/signature_lookup.c | 2 +- > > >

Re: [FFmpeg-devel] [RFC] STF 2025

Hi On Mon, May 20, 2024 at 09:51:25PM +0300, Rémi Denis-Courmont wrote: > Le sunnuntaina 19. toukokuuta 2024, 14.29.43 EEST Thilo Borgmann via ffmpeg- > devel a écrit : > > [...] > > > > >> * Fund administrative / maintainance work (one example is the mailman > > >> upgrade that is needed>> > >

Re: [FFmpeg-devel] FFmpeg 7.0.1

On Fri, Apr 05, 2024 at 02:15:58AM +0200, Michael Niedermayer wrote: > Hi all > > i intend to make a 7.0.1 in a few weeks for all the bug fixes that didnt > make it in 7.0 i intend to make 7.0.1 in the next days (maybe tomorrow) and 6.1.2 soon after that thx [..] -- Micha

[FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure

Fixes: CID1559855 Unchecked return value from library Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/file.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 0ed4cff266c..e2ef85aa705

[FFmpeg-devel] [PATCH 2/3] avformat/fwse: Remove always false expression

Fixes: CID1460758 Operands don't affect result Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/fwse.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/fwse.c b/libavformat/fwse.c index 6c1103da146..dc4750d946a 100644

[FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Remove dead ret stores

Fixes: CID1529222 Unused value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavformat/hlsenc.c | 4 1 file changed, 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 0e2843c6bc5..8a43ef6232a 100644 --- a/libavformat/hlsenc.c +++ b

Re: [FFmpeg-devel] [PATCH 1/3] avformat/file: check for lseek() failure

On Sat, May 25, 2024 at 02:38:07PM +0300, Rémi Denis-Courmont wrote: > Le lauantaina 25. toukokuuta 2024, 14.18.12 EEST Michael Niedermayer a écrit : > > Fixes: CID1559855 Unchecked return value from library > > This is again very misleading. Logging an error (that most people wo

Re: [FFmpeg-devel] [PATCH] lpc: rewrite lpc_compute_autocorr in external asm

On Sat, May 25, 2024 at 10:57:21PM +0200, Lynne via ffmpeg-devel wrote: > The inline asm function had issues running under checkasm. > So I came to finish what I started, and wrote the last part > of LPC computation in assembly. > > autocorr_10_c: 135525.8 > autocorr_10_sse2: 50729.8 > autocorr_10

Re: [FFmpeg-devel] [PATCH 01/12] avutil/avassert: Add av_unreachable and av_assume() macros

Hi On Fri, May 24, 2024 at 11:58:21PM +0200, Andreas Rheinhardt wrote: > Useful to let the compiler and static analyzers know that > something is unreachable without adding an av_assert > (which would be either dead for the compiler or add runtime > overhead) for this. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH] web/contact: relink code of conduct

On Fri, May 24, 2024 at 07:36:07PM +0200, Michael Niedermayer wrote: > Found-by: John Hawkinson > > Signed-off-by: Michael Niedermayer > --- > src/contact | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) will apply [...] -- Michael

Re: [FFmpeg-devel] [PATCH 1/2] libavfilter/signature_lookup: fix possible division by zero

On Sun, May 26, 2024 at 05:08:09PM +0200, Gerion Entrup wrote: > Am Freitag, 24. Mai 2024, 23:03:37 MESZ schrieb Michael Niedermayer: > > On Fri, May 24, 2024 at 12:33:11PM +0200, Gerion Entrup wrote: > > > Am Dienstag, 7. Mai 2024, 19:46:28 MESZ schrieb Michael Niedermayer: >

Re: [FFmpeg-devel] [PATCH 01/12] avutil/avassert: Add av_unreachable and av_assume() macros

Hi On Sun, May 26, 2024 at 02:59:35AM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > Hi > > > > On Fri, May 24, 2024 at 11:58:21PM +0200, Andreas Rheinhardt wrote: > >> Useful to let the compiler and static analyzers know that > >> som

Re: [FFmpeg-devel] [PATCH v2] lpc: rewrite lpc_compute_autocorr in external asm

On Sun, May 26, 2024 at 03:42:01AM +0200, Lynne via ffmpeg-devel wrote: > The inline asm function had issues running under checkasm. > So I came to finish what I started, and wrote the last part > of LPC computation in assembly. > --- > libavcodec/x86/lpc.asm| 91 ++

[FFmpeg-devel] [PATCH 01/17] avcodec/dxva2: Initialize dxva_size and check it

Fixes: CID1591878 Uninitialized scalar variable Fixes: CID1591928 Uninitialized pointer read Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dxva2.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2

[FFmpeg-devel] [PATCH 02/17] avcodec/dxva2: Initialize ConfigBitstreamRaw

Fixes: CID1591894 Uninitialized scalar variable Fixes: CID1591906 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dxva2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c

[FFmpeg-devel] [PATCH 03/17] avcodec/dxva2: initialize validate

Fixes: CID1591915 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dxva2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c index 550369ba51f..1a33c8bbac7 100644 --- a

[FFmpeg-devel] [PATCH 04/17] avcodec/dxva2: initialize hr in ff_dxva2_common_end_frame()

Fixes: CID1591924 Uninitialized scalar variable Fixes: CID1591938 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dxva2.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/dxva2.c b/libavcodec/dxva2.c

[FFmpeg-devel] [PATCH 05/17] avcodec/dxva2_*: Initialize dxva_data_ptr

Fixes: CID1591888 Uninitialized scalar variable Fixes: CID1591925 Uninitialized pointer read Fixes: CID1591933 Uninitialized scalar variable Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/dxva2_av1.c | 4 ++-- libavcodec/dxva2_hevc.c | 5 - libavcodec

[FFmpeg-devel] [PATCH 11/17] avdevice/dshow: fix badly indented line

Signed-off-by: Michael Niedermayer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 8942c0c499a..fd9027b1787 100644 --- a/libavdevice/dshow.c +++ b/libavdevice/dshow.c @@ -1370,7 +1370,7

[FFmpeg-devel] [PATCH 06/17] avcodec/mfenc: check IMFSample_ConvertToContiguousBuffer() for failure

Fixes: CID1591911 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/mfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/mfenc.c b/libavcodec/mfenc.c index 2c68adbdc73..b8f8a25f434 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 12/17] avdevice/dshow: Check device_filter_unique_name before use

Fixes: CID1591931 Explicit null dereferenced Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index fd9027b1787..911b0ecc078 100644 --- a

[FFmpeg-devel] [PATCH 07/17] qsv: Initialize impl_value

Fixes: The warnings from CID1598553 Uninitialized scalar variable Passing partly initialized structs is ugly and asking for hard to reproduce bugs, I do not know if this actually fixes a bug or just avoids the uninitialized fields Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael

[FFmpeg-devel] [PATCH 13/17] avdevice/dshow: Check ICaptureGraphBuilder2_SetFiltergraph() for failure

Fixes: CID1591939 Logically dead code Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 911b0ecc078..557cf33161e 100644 --- a

[FFmpeg-devel] [PATCH 08/17] avcodec/vp8: Check mutex init

Fixes: CID1598556 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 8e91613068a..3e1f67172ae 100644 --- a/libavcodec

[FFmpeg-devel] [PATCH 14/17] avdevice/dshow: Cleanup also on av_log case

Fixes: CID1598550 Resource leak Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavdevice/dshow.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavdevice/dshow.c b/libavdevice/dshow.c index 557cf33161e..645c33ea2e6 100644 --- a/libavdevice

[FFmpeg-devel] [PATCH 09/17] avcodec/vp8: Check cond init

Fixes: CID1598563 Unchecked return value Sponsored-by: Sovereign Tech Fund Signed-off-by: Michael Niedermayer --- libavcodec/vp8.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 3e1f67172ae..d6df018655c 100644 --- a/libavcodec

  1   2   3   4   5   6   7   8   9   10   >