[FFmpeg-devel] [PATCH 2/3] avcodec/simple_idct_template: Fix integer overflow in idctSparseCol()

2019-06-25 Thread Michael Niedermayer
-off-by: Michael Niedermayer --- libavcodec/simple_idct_template.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/simple_idct_template.c b/libavcodec/simple_idct_template.c index 35c31321c6..90d1c21355 100644 --- a/libavcodec/simple_idct_template.c

[FFmpeg-devel] [PATCH 1/3] avcodec/svq3: Use ff_set_dimension()

2019-06-25 Thread Michael Niedermayer
Fixes: OOM Fixes: 15410/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-5659464805384192 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/svq3.c | 36

[FFmpeg-devel] [PATCH 3/3] avcodec/simple_idct_template: Fix integer overflow in idctSparseColAdd()

2019-06-25 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/simple_idct_template.c | 18 +- 1 file changed, 9 insertions(+), 9 deletions(-) diff --git a/libavcodec/simple_idct_template.c b/libavcodec/simple_idct_template.c index 90d1c21355..d8fcfd7c53 100644 --- a/libavcodec/simple_idct_template.c

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/motionpixels: Check for vlc error in mp_get_vlc()

2019-06-25 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 12:00:52AM +0200, Michael Niedermayer wrote: > Fixes: > 15246/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MOTIONPIXELS_fuzzer-5168534407086080 > Fixes: runtime error: index -1 out of bounds for type 'HuffCode [16]' > > Found-by: continuous fuzzing p

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/loco: Limit lossy parameter so it is sane and does not overflow

2019-06-25 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 12:00:54AM +0200, Michael Niedermayer wrote: > Fixes: > 15248/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LOCO_fuzzer-5087440458481664 > Fixes: signed integer overflow: 3 + 2147483647 cannot be represented in type > 'int' > > Found-by: continuo

Re: [FFmpeg-devel] [PATCH] avformat/mov: Set fragment.found_tfhd only after TFHD has been parsed

2019-06-25 Thread Michael Niedermayer
On Sat, Jun 15, 2019 at 03:51:54PM +0200, Michael Niedermayer wrote: > Fixes: Assertion failure > Fixes: crbug971646.mp4 > > Reported-by: Matt Wolenetz > Reviewed-by: Matt Wolenetz > Signed-off-by: Michael Niedermayer > --- > libavformat/mov.c | 3 +-- > 1 file

[FFmpeg-devel] [PATCH] avcodec/fitsdec: Check data_min/max

2019-06-25 Thread Michael Niedermayer
Fixes: division by 0 Fixes: 15206/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FITS_fuzzer-5657260212092928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/fitsdec.c | 8 1 file

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/fitsdec: Check data_min/max

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 04:29:54PM +0200, Moritz Barsnick wrote: > On Thu, Jun 13, 2019 at 01:20:20 +0200, Michael Niedermayer wrote: > > +if (header->data_min == header->data_max) { > > Just a note: > Equality comparison of floats/doubles may trigger a wa

[FFmpeg-devel] [PATCH 2/2] avcodec/hevc_ps: Change num_tile_rows/columns checks to sps->ctb_height/weight

2019-06-25 Thread Michael Niedermayer
Suggested-by: James Almer Signed-off-by: Michael Niedermayer --- libavcodec/hevc_ps.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index 07d220a5c8..f6e80e1609 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec/hevc_ps.c

Re: [FFmpeg-devel] [PATCH 2/4] avformat/img2dec: Fix probe_buffer leak in ff_img_read_header()

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 01:20:18AM +0200, Michael Niedermayer wrote: > Fixes: memleak > Fixes: > 15171/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5683881644130304 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/f

[FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-25 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/hevc_ps.c | 23 +-- libavcodec/hevc_ps.h | 4 ++-- 2 files changed, 15 insertions(+), 12 deletions(-) diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc_ps.c index 80df417e4f..07d220a5c8 100644 --- a/libavcodec/hevc_ps.c +++ b/libavcodec

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/xpmdec: Do not use context dimensions as temporary variables

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 01:20:17AM +0200, Michael Niedermayer wrote: > Fixes: Integer overflow > Fixes: > 15134/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XPM_fuzzer-5722635939348480 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH] avformat/vividas: check length in read_vblock()

2019-06-25 Thread Michael Niedermayer
On Wed, Jun 12, 2019 at 03:23:59PM +0200, Michael Niedermayer wrote: > Fixes: out of array access > Fixes: > 15166/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5731062396747776 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/fitsdec: Fix division be 0 in size check

2019-06-25 Thread Michael Niedermayer
On Fri, Jun 14, 2019 at 09:46:17AM +0200, Moritz Barsnick wrote: > On Thu, Jun 13, 2019 at 20:32:35 +0200, Michael Niedermayer wrote: > > > avcodec/fitsdec: Fix division be 0 in size check > Nit:^ by will push without the typo thanks [...] -- Mi

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 01:04:45AM -0300, James Almer wrote: > On 6/19/2019 3:59 PM, James Almer wrote: > > On 6/19/2019 3:13 PM, Michael Niedermayer wrote: > >> On Wed, Jun 19, 2019 at 12:54:25PM -0300, James Almer wrote: > >>> On 6/19/2019 6:22 AM, Michael Niederm

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-25 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 03:59:47PM -0300, James Almer wrote: > On 6/19/2019 3:13 PM, Michael Niedermayer wrote: > > On Wed, Jun 19, 2019 at 12:54:25PM -0300, James Almer wrote: > >> On 6/19/2019 6:22 AM, Michael Niedermayer wrote: > >>> On Mon, Jun 17, 2019 at 07:55

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/aacpsdsp_template: Fix integer overflow in ps_hybrid_analysis_c()

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 08:32:33PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1539565182 + -798086761 cannot be > represented in type 'int' > Fixes: > 14807/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_FIXED_fuzzer-564925382682214 > > Fo

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/truemotion2: Fix integer overflow in last loop in tm2_update_block()

2019-06-25 Thread Michael Niedermayer
On Thu, Jun 13, 2019 at 08:32:36PM +0200, Michael Niedermayer wrote: > Fixes: signed integer overflow: -1727985666 - 538976288 cannot be represented > in type 'int' > Fixes: > 15031/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TRUEMOTION2_fuzzer-5100228035739648 > > Sign

Re: [FFmpeg-devel] [PATCH] Add DICOM Support

2019-06-24 Thread Michael Niedermayer
On Mon, Jun 24, 2019 at 09:18:13PM +0530, Shivam wrote: > Hi! > >     The code is to add DICOM Support. The patch is only for uncompressed > dicom files using explicit value representation. I would extend it, once i > clarify some doubts. As dicom image files contain lots of metadata about >

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bink: Fix integer overflow in unquantize_dct_coeffs()

2019-06-24 Thread Michael Niedermayer
On Sat, Jun 22, 2019 at 08:46:20AM +0200, Michael Niedermayer wrote: > On Fri, Jun 21, 2019 at 09:12:36AM +0200, Reimar Döffinger wrote: > > > > > > On 18.06.2019, at 14:55, Michael Niedermayer wrote: > > > > > Fixes: signed integer overflow: -

[FFmpeg-devel] [PATCH 3/3] avcodec/qdm2: Check checksum_size for 0

2019-06-23 Thread Michael Niedermayer
Fixes: Infinite loop Fixes: 15337/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_QDM2_fuzzer-5757428949319680 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/qdm2.c | 4 ++-- 1 file

[FFmpeg-devel] [PATCH 2/3] avcodec/qdm2: error out of qdm2_fft_decode_tones() before entering endless loop

2019-06-23 Thread Michael Niedermayer
/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/qdm2.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c index 52c7cc73a0..42e10829e9 100644 --- a/libavcodec/qdm2.c +++ b/libavcodec/qdm2.c @@ -1288,6 +1288,10 @@ static void qdm2_fft_decode_tones

[FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Do not read out of array in fix_coding_method_array()

2019-06-23 Thread Michael Niedermayer
/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/qdm2.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c index 1397218bdd..52c7cc73a0 100644 --- a/libavcodec/qdm2.c +++ b/libavcodec/qdm2.c @@ -408,6 +408,10 @@ static int

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check ham vs bpp

2019-06-23 Thread Michael Niedermayer
On Sun, Jun 23, 2019 at 06:33:02PM +1000, Peter Ross wrote: > On Sun, Jun 23, 2019 at 12:30:54AM +0200, Michael Niedermayer wrote: > > This checks the ham value much stricter and avoids hitting cases which > > cannot be reached > > with data from the libavformat demuxer

[FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check ham vs bpp

2019-06-22 Thread Michael Niedermayer
-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5630765833912320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git

[FFmpeg-devel] [PATCH 3/3] avcodec/iff: finetune the palette size check in the mask case

2019-06-22 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15381/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5668057826983936 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 1/3] avcodec/iff: Fix mask_buf / mask_palbuf leak

2019-06-22 Thread Michael Niedermayer
Fixes: 15372/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5708881759567872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/iff.c | 2 ++ 1 file changed, 2 insertions

[FFmpeg-devel] [PATCH 2/2] avcodec/vc1_block: Fix invalid shifts in vc1_decode_i_blocks()

2019-06-22 Thread Michael Niedermayer
Fixes: left shift of negative value -9 Fixes: 15299/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MSS2_fuzzer-5660922678345728 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c

[FFmpeg-devel] [PATCH 1/2] avcodec/vc1_block: fix invalid shift in vc1_decode_p_mb()

2019-06-22 Thread Michael Niedermayer
Fixes: left shift of negative value -5 Fixes: 15294/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5733921754447872 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1_block.c

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 05:55:23AM +, Jacob Siddall wrote: > > doesnt apply with git > > > > > Applying: avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation > > Using index info to reconstruct a base tree... > > error: patch failed: libavformat/rtpdec_rfc4175.c:206 > > error:

Re: [FFmpeg-devel] [PATCH] add FF_DECODE_ERROR_DECODE_SLICES flag for AVFrame.decode_error_flags

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote: > FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with > error(s) but the returned value from > avcodec_receive_frame is zero The first line of the commit message needs a "avutil:" prefix or similar also the first line

Re: [FFmpeg-devel] [PATCH] add FF_DECODE_ERROR_DECODE_SLICES flag for AVFrame.decode_error_flags

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 07:15:55AM -0700, Amir Pauker wrote: > FF_DECODE_ERROR_DECODE_SLICES is set when decoding slices result with > error(s) but the returned value from > avcodec_receive_frame is zero > > Signed-off-by: Amir Pauker > --- > doc/APIchanges | 3 +++ > libavutil/frame.h

Re: [FFmpeg-devel] [PATCH] libavformat/mux: Fix audio_preload

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 06:51:54PM +0200, Andreas Rheinhardt wrote: > Commit 31f9032b added the audio_preload feature; its goal is to > interleave audio earlier than the rest. Unfortunately, it has never ever > worked, because the check for whether a packet should be interleaved > before or after

Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 02:53:09PM +0200, Nicolas George wrote: > greg Luce (12019-06-21): > > I had them in a single patch before but split them as requested here > > http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html > > Is there something I'm missing that allows me to split the

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/bink: Fix integer overflow in unquantize_dct_coeffs()

2019-06-22 Thread Michael Niedermayer
On Fri, Jun 21, 2019 at 09:12:36AM +0200, Reimar Döffinger wrote: > > > On 18.06.2019, at 14:55, Michael Niedermayer wrote: > > > Fixes: signed integer overflow: -3447 * 2883584 cannot be represented in > > type 'int' > > Fixes: > >

[FFmpeg-devel] [PATCH 3/6] avcodec/ffwavesynth: use uint32_t to compute difference, it is enough

2019-06-21 Thread Michael Niedermayer
/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ffwavesynth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ffwavesynth.c b/libavcodec/ffwavesynth.c index b2cc7c8fc1..793eada7a5 100644 --- a/libavcodec/ffwavesynth.c +++ b/libavcodec/ffwavesynth.c

[FFmpeg-devel] [PATCH 2/6] avcodec/ffwavesynth: Simplify lcg_seek(), avoid negative case

2019-06-21 Thread Michael Niedermayer
://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ffwavesynth.c | 12 +++- 1 file changed, 3 insertions(+), 9 deletions(-) diff --git a/libavcodec/ffwavesynth.c b/libavcodec/ffwavesynth.c index cf8c780f3e..b2cc7c8fc1 100644

[FFmpeg-devel] [PATCH 6/6] avcodec/flicvideo: More strictly check chunk size for FLI_COPY

2019-06-21 Thread Michael Niedermayer
Fixes: Timeout (40sec -> 13sec) Fixes: 15417/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FLIC_fuzzer-5679812615602176 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flicvideo.c

[FFmpeg-devel] [PATCH 5/6] avcodec/flicvideo: Fix off by 1 error in flic_decode_frame_24BPP()

2019-06-21 Thread Michael Niedermayer
/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/flicvideo.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/flicvideo.c b/libavcodec/flicvideo.c index cd9cd089af..2474a9ca72 100644 --- a/libavcodec/flicvideo.c +++ b/libavcodec/flicvideo.c @@ -900,7

[FFmpeg-devel] [PATCH 1/6] avcodec/ffwavesynth: Fix backward lcg_seek()

2019-06-21 Thread Michael Niedermayer
Signed-off-by: Michael Niedermayer --- libavcodec/ffwavesynth.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/ffwavesynth.c b/libavcodec/ffwavesynth.c index a66113972b..cf8c780f3e 100644 --- a/libavcodec/ffwavesynth.c +++ b/libavcodec/ffwavesynth.c @@ -122,7

[FFmpeg-devel] [PATCH 4/6] avcodec/flicvideo: Make line_packets int

2019-06-21 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/flicvideo.c | 14 +++--- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/libavcodec/flicvideo.c b/libavcodec/flicvideo.c index ba5bda48c4..cd9cd089af 100644 --- a/libavcodec/flicvideo.c +++ b/libavcodec/flicvideo.c @@ -175,7 +175,7 @@ static

Re: [FFmpeg-devel] [PATCH 3/3] avformat/vividas: reduce keybits to require half the space

2019-06-21 Thread Michael Niedermayer
On Sat, Jun 08, 2019 at 08:23:22AM +0200, Reimar Döffinger wrote: > > > On 07.06.2019, at 23:56, Michael Niedermayer wrote: > > > Signed-off-by: Michael Niedermayer > > --- > > libavformat/vividas.c | 12 ++-- > > 1 file changed, 6 insertions(+

Re: [FFmpeg-devel] [PATCH 3/4] avformat/wsddec: Fix undefined shift

2019-06-21 Thread Michael Niedermayer
On Sat, Jun 08, 2019 at 06:11:02PM +0200, Reimar Döffinger wrote: > > > On 08.06.2019, at 11:28, Michael Niedermayer wrote: > > > Fixes: left shift of 1 by 31 places cannot be represented in type 'int' > > Fixes: > > 15123/clusterfuzz-testcase-minimized-ffmpeg_D

Re: [FFmpeg-devel] [PATCH] avcodec/fmvc: Check if header fields are available before allocating the image

2019-06-21 Thread Michael Niedermayer
On Mon, Jun 03, 2019 at 10:55:20AM +0200, Paul B Mahol wrote: > On 6/2/19, Michael Niedermayer wrote: > > Fixes: Timeout (15sec -> 0.5sec) > > Fixes: > > 14846/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FMVC_fuzzer-5068322120400896 > > > > Found-by:

Re: [FFmpeg-devel] [PATCH] avcodec/wcmv: check remaining space vs. blocks

2019-06-21 Thread Michael Niedermayer
On Sun, Jun 02, 2019 at 01:25:32AM +0200, Michael Niedermayer wrote: > Fixes: Timeout (18sec -> 7sec) > Fixes: > 14835/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5646714897170432 > > Found-by: continuous fuzzing process > https://github.com/google

Re: [FFmpeg-devel] [PATCH V1 2/3] ffmpeg_opt: Respect default disposition when select audio/video

2019-06-21 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 12:50:33PM +0800, Jun Zhao wrote: > From: Jun Zhao > > Respect default disposition when select audio/video > > Signed-off-by: Jun Zhao > --- > fftools/ffmpeg_opt.c |6 -- > 1 files changed, 4 insertions(+), 2 deletions(-) this is probably ok some testcase in

Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-21 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 12:06:38PM -0400, greg Luce wrote: > Info at https://trac.ffmpeg.org/ticket/7947 > C code in file 0001, documentation and version tick in file 0002 > Documentation written with help from Gyan and Moritz Barsnick > Documentation patch has info in what I hope is the commit

Re: [FFmpeg-devel] [PATCH] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-06-20 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 06:21:53AM +, Jacob Siddall wrote: > The previous calculation code did not account for the fact that the > copy_offset for the start of the frame array is at index 0, yet the > scan line number from the rfc4175 RTP header starts at 1. > This caused 2 issues to appear: >

[FFmpeg-devel] [PATCH 6/7] avcodec/alsdec: Fix another integer overflow in INTERLEAVE_OUTPUT()

2019-06-20 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/alsdec.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index 57d558c1c6..8d68fa24e6 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -1805,11 +1805,11 @@ static int decode_frame

[FFmpeg-devel] [PATCH 3/7] avcodec/alsdec: Fix integer overflow with buffer number

2019-06-20 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/alsdec.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index 79d22b7c2b..8e0d3e5f83 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -1990,6 +1990,8 @@ static av_cold int decode_init(AVCodecContext *avctx

[FFmpeg-devel] [PATCH 5/7] avcodec/alsdec: Add FF_CODEC_CAP_INIT_CLEANUP

2019-06-20 Thread Michael Niedermayer
Fixes: multiple memleaks Fixes: 15293/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5642409288925184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 7/7] avcodec/4xm: Fix vlc memleak

2019-06-20 Thread Michael Niedermayer
Fixes: memleak Fixes: 15297/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FOURXM_fuzzer-5746203548975104 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/4xm.c | 1 + 1 file changed, 1

[FFmpeg-devel] [PATCH 2/7] avcodec/alsdec: Fixes signed integer overflow in LSB addition

2019-06-20 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/alsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index 279d4fed6e..79d22b7c2b 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -867,7 +867,7 @@ static int read_var_block_data

[FFmpeg-devel] [PATCH 4/7] avcodec/alsdec: Fix invalid shift in multiply()

2019-06-20 Thread Michael Niedermayer
Fixes: shift exponent -24 is negative Fixes: 15292/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5768533318828032 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 3

[FFmpeg-devel] [PATCH 1/7] avcodec/alsdec: Check opt_order / sb_length in ra_block handling

2019-06-20 Thread Michael Niedermayer
/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index e50a287f19..279d4fed6e 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -789,14

Re: [FFmpeg-devel] [PATCH] avcodec/alsdec: Consider frame_size in ra_block handling

2019-06-20 Thread Michael Niedermayer
On Thu, Jun 20, 2019 at 06:06:29PM +0200, Thilo Borgmann wrote: > Am 20.06.19 um 16:17 schrieb Michael Niedermayer: > > Fixes: out of array access > > Fixes: > > 15277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5184853437317120 > > > > Fou

[FFmpeg-devel] [PATCH] avcodec/alsdec: Consider frame_size in ra_block handling

2019-06-20 Thread Michael Niedermayer
Fixes: out of array access Fixes: 15277/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5184853437317120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 9 + 1

[FFmpeg-devel] [PATCH 1/3] avcodec/alsdec: Fixes invalid shifts in read_var_block_data() and INTERLEAVE_OUTPUT()

2019-06-19 Thread Michael Niedermayer
Fixes: left shift of negative value -6 Fixes: 15275/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5742361767837696 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alsdec.c | 12

[FFmpeg-devel] [PATCH 2/3] avcodec/alsdec: Fix undefined behavior in decode_rice()

2019-06-19 Thread Michael Niedermayer
Fixes: left shift of 72 by 26 places cannot be represented in type 'int' Fixes: 15279/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ALS_fuzzer-5700665621348352 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 3/3] avcodec/alsdec: Fix integer overflow with shifting samples

2019-06-19 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/alsdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alsdec.c b/libavcodec/alsdec.c index b7ce5c7844..e50a287f19 100644 --- a/libavcodec/alsdec.c +++ b/libavcodec/alsdec.c @@ -1033,7 +1033,7 @@ static int decode_block(ALSDecContext

Re: [FFmpeg-devel] [PATCH] libavcodec: Reduce the size of some arrays

2019-06-19 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 04:39:47AM +0200, Andreas Rheinhardt wrote: > This commit uses smaller types for some static const arrays to reduce > their size in case the entries can be represented in the smaller type. > The biggest savings came from inv_map_table in vp9.c. > > Signed-off-by: Andreas

Re: [FFmpeg-devel] [PATCH]Fix build with --enable-hardcoded-tables

2019-06-19 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 01:43:28PM +0200, Carl Eugen Hoyos wrote: > Hi! > > Attached patch fixes ticket #7962 for me, please comment. > > Thank you, Carl Eugen > tableprint_vlc.h |1 + > 1 file changed, 1 insertion(+) > 9d5e5217e6a19d8e203da311a0cf108daf66129d >

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check bpp for validity

2019-06-19 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 08:11:50PM +1000, Peter Ross wrote: > On Wed, Jun 19, 2019 at 11:44:36AM +0200, Michael Niedermayer wrote: > > On Wed, Jun 19, 2019 at 07:34:19PM +1000, Peter Ross wrote: > > > On Wed, Jun 19, 2019 at 01:53:02AM +0200, Michael Niedermayer wrote: &g

[FFmpeg-devel] [PATCH] avcodec/utils: Check bits_per_coded_sample

2019-06-19 Thread Michael Niedermayer
://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/utils.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index cc04b73471..1b1feca38c 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c

Re: [FFmpeg-devel] [PATCH] avformat/oggdec: only parse headers before data

2019-06-19 Thread Michael Niedermayer
On Mon, Jun 17, 2019 at 05:59:40PM -0700, Chris Cunningham wrote: > This behavior was added in 2010 to suport some old (and invalid) ogm > files. > https://github.com/FFmpeg/FFmpeg/commit/81b743eb1026547270b88ac6a5cb451a3907ee94 > > But this makes it possible to change the codec in the later

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-19 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 12:54:25PM -0300, James Almer wrote: > On 6/19/2019 6:22 AM, Michael Niedermayer wrote: > > On Mon, Jun 17, 2019 at 07:55:45PM -0300, James Almer wrote: > >> On 6/17/2019 6:54 PM, Michael Niedermayer wrote: > >>> On Sun, Jun 16, 2019 at 11:10

Re: [FFmpeg-devel] [FFmpeg-cvslog] av_format/hlsenc: fix %v handling by format_name function

2019-06-19 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 10:03:51AM +, Bodecs Bela wrote: > ffmpeg | branch: master | Bodecs Bela | Mon Jun 17 > 23:05:21 2019 +0200| [09a4853930e7950f423e9161004871afe659ed84] | committer: > Steven Liu > > av_format/hlsenc: fix %v handling by format_name function > > Hi All, > > When

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-19 Thread Michael Niedermayer
On Mon, Jun 17, 2019 at 07:55:45PM -0300, James Almer wrote: > On 6/17/2019 6:54 PM, Michael Niedermayer wrote: > > On Sun, Jun 16, 2019 at 11:10:43PM -0300, James Almer wrote: > >> On 6/13/2019 3:32 PM, Michael Niedermayer wrote: > >>> Fixes: signed integer ov

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check bpp for validity

2019-06-19 Thread Michael Niedermayer
On Wed, Jun 19, 2019 at 07:34:19PM +1000, Peter Ross wrote: > On Wed, Jun 19, 2019 at 01:53:02AM +0200, Michael Niedermayer wrote: > > Fixes: shift exponent -100663046 is negative > > Fixes: out of array access > > Fixes: > > 15270/clusterfuzz-testcase-minimized-ffmpeg_

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags to FF_DECODE_ERROR_CONCEALMENT_ACTIVE in case of concealed errors

2019-06-19 Thread Michael Niedermayer
On Tue, Jun 18, 2019 at 03:14:47PM +0300, Amir Z wrote: > Thanks Michael, > > The reason I set the flag before the log line in ff_er_frame_end is because > the code might never get there even though the return value is set to zero. > > Should we use two different values ? if there are 2

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: enhanced %v handling with variant names

2019-06-19 Thread Michael Niedermayer
On Tue, Jun 18, 2019 at 11:09:12PM +0200, Bodecs Bela wrote: > Dear All, > > When multiple variant streams are specified by var_stream_map option, %v > placeholder in various names ensures that each variant has its unique > names. Currently %v is substituted by its variant index value (0, 1, 2 >

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-19 Thread Michael Niedermayer
On Mon, Jun 17, 2019 at 07:55:45PM -0300, James Almer wrote: > On 6/17/2019 6:54 PM, Michael Niedermayer wrote: > > On Sun, Jun 16, 2019 at 11:10:43PM -0300, James Almer wrote: > >> On 6/13/2019 3:32 PM, Michael Niedermayer wrote: > >>> Fixes: signed integer ov

[FFmpeg-devel] [PATCH 2/3] avcodec/iff: Check bpp for validity

2019-06-18 Thread Michael Niedermayer
Fixes: shift exponent -100663046 is negative Fixes: out of array access Fixes: 15270/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IFF_ILBM_fuzzer-5727829913763840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 3/3] avcodec/alac: Check lpc_quant

2019-06-18 Thread Michael Niedermayer
/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/alac.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/alac.c b/libavcodec/alac.c index 2f44340661..c234d7153b 100644 --- a/libavcodec/alac.c +++ b/libavcodec/alac.c @@ -306,7 +306,7

[FFmpeg-devel] [PATCH 1/3] avformat/vqf: Check header_size

2019-06-18 Thread Michael Niedermayer
Fixes: 15271/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-5735262606327808 Fixes: signed integer overflow: -2147483648 - 8 cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH] avcodec/videodsp_template: Fix overflow of addition

2019-06-18 Thread Michael Niedermayer
Fixes: addition of unsigned offset to 0x7f56fc26a9b6 overflowed to 0x7f56fc26a8be* Fixes: clusterfuzz-testcase-minimized-mediasource_MP4_AVC1_pipeline_integration_fuzzer-4917949056679936 Reported-by: Matt Wolenetz Reviewed-by: Matt Wolenetz Signed-off-by: Michael Niedermayer --- libavcodec

[FFmpeg-devel] [PATCH 1/2] avcodec/bink: Fix integer overflow in unquantize_dct_coeffs()

2019-06-18 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/bink.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/bink.c b/libavcodec/bink.c index 8392bbeeb0..d18c0ceae4 100644 --- a/libavcodec/bink.c +++ b/libavcodec/bink.c @@ -702,15 +702,15 @@ static int read_dct_coeffs(BinkContext *c

[FFmpeg-devel] [PATCH 2/2] avcodec/binkdsp: Fix integer overflows in idct

2019-06-18 Thread Michael Niedermayer
process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/binkdsp.c | 12 +++- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/libavcodec/binkdsp.c b/libavcodec/binkdsp.c index 9d70e2326f..a357d31672 100644

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-17 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 11:10:43PM -0300, James Almer wrote: > On 6/13/2019 3:32 PM, Michael Niedermayer wrote: > > Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in > > type 'int' > > Fixes: > > 14880/clusterfuzz-testcase-minimized-ffm

Re: [FFmpeg-devel] [PATCH v2 1/2] libavformat/utils: Interpolate missing timestamps in H264 and HEVC when no b-frames observed

2019-06-17 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 01:09:45AM -0400, Andriy Gelman wrote: > Michael, > > On Thu, 16. May 00:43, Michael Niedermayer wrote: > > On Tue, May 14, 2019 at 05:54:21PM -0400, Andriy Gelman wrote: > > > From: Andriy Gelman > > > > > > Fixes Ticke

[FFmpeg-devel] [PATCH 3/3] avcodec/libvorbisdec: Check extradata size

2019-06-17 Thread Michael Niedermayer
Fixes: out of array read Fixes: 15261/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LIBVORBIS_fuzzer-5764908467093504 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/libvorbisdec.c | 8

[FFmpeg-devel] [PATCH 2/3] avcodec/m101: Fix off be 2 error

2019-06-17 Thread Michael Niedermayer
Fixes: out of array read Fixes: 15263/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_M101_fuzzer-5728999453491200 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/m101.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 1/3] avcodec/qdm2: Move fft_order check up

2019-06-17 Thread Michael Niedermayer
-off-by: Michael Niedermayer --- libavcodec/qdm2.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavcodec/qdm2.c b/libavcodec/qdm2.c index 88b6b19d11..1397218bdd 100644 --- a/libavcodec/qdm2.c +++ b/libavcodec/qdm2.c @@ -1702,6 +1702,12 @@ static av_cold int

[FFmpeg-devel] [PATCH 1/2] avcodec/atrac9dec: Check that the reused block has succeeded initilization

2019-06-16 Thread Michael Niedermayer
Fixes: global-buffer-overflow Fixes: 15247/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5671602181636096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/atrac9dec.c | 8

[FFmpeg-devel] [PATCH 2/2] avcodec/atrac9dec: Check q_unit_cnt in parse_band_ext()

2019-06-16 Thread Michael Niedermayer
Fixes: global-buffer-overflow Fixes: 15247/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ATRAC9_fuzzer-5671602181636096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/atrac9dec.c | 2

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/apedec: Fix multiple integer overflows in filter_3800()

2019-06-16 Thread Michael Niedermayer
eger overflow: 1898547155 + 453967445 cannot be > >>>> represented in type 'int' > >>>> Fixes: > >>>> 15258/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5759095564402688 > >>>> > >>>> Found-by: continuous fuzzing process > >&g

Re: [FFmpeg-devel] [PATCH 2/5] avcodec/atrac9dec: Check conditions before apply_band_extension() to avoid out of array read in initialization of unused variables

2019-06-16 Thread Michael Niedermayer
Found-by: continuous fuzzing process > > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg > > Signed-off-by: Michael Niedermayer > > --- > > libavcodec/atrac9dec.c | 7 +++ > > 1 file changed, 3 insertions(+), 4 deletions(-) > > > > dif

[FFmpeg-devel] [PATCH 2/6] avcodec/qdmc: Fix integer overflows in PRNG

2019-06-16 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/qdmc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/qdmc.c b/libavcodec/qdmc.c index 8f5b7b920d..8bea1552e1 100644 --- a/libavcodec/qdmc.c +++ b/libavcodec/qdmc.c @@ -577,9 +577,9 @@ static void add_noise(QDMCContext *s, int ch

[FFmpeg-devel] [PATCH 3/6] avcodec/tta: Fix undefined shift

2019-06-16 Thread Michael Niedermayer
Fixes: left shift of negative value -4483 Fixes: 15256/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_TTA_fuzzer-5738691617619968 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/tta.c | 2

[FFmpeg-devel] [PATCH 6/6] avcodec/vc1dsp: Avoid undefined shifts in vc1_v_s_overlap_c / vc1_h_s_overlap_c

2019-06-16 Thread Michael Niedermayer
Fixes: left shift of negative value -13 Fixes: 15260/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC1_fuzzer-5702076048343040 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vc1dsp.c

[FFmpeg-devel] [PATCH 5/6] avcodec/ffwavesynth: Check ts_end - ts_start for overflow

2019-06-16 Thread Michael Niedermayer
/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ffwavesynth.c | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/ffwavesynth.c b/libavcodec/ffwavesynth.c index 9d055e4019..a66113972b 100644 --- a/libavcodec/ffwavesynth.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 4/6] avcodec/bintext: Check font height

2019-06-16 Thread Michael Niedermayer
Fixes: division by zero Fixes: 15257/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINTEXT_fuzzer-5757352881422336 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/bintext.c | 4 1

[FFmpeg-devel] [PATCH 1/6] avcodec/rv10: Avoid calculating undefined value that is unused

2019-06-16 Thread Michael Niedermayer
Fixes: shift exponent 64 is too large for 32-bit type 'int' Fixes: 15253/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RV10_fuzzer-5671114300194816 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer

[FFmpeg-devel] [PATCH 2/4] avcodec/apedec: Add k < 24 check to the only k++ case which lacks such a check

2019-06-16 Thread Michael Niedermayer
Fixes: 15255/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_APE_fuzzer-5718831688843264 Fixes: left shift of 1 by 31 places cannot be represented in type 'int' Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael

[FFmpeg-devel] [PATCH 3/4] avcodec/apedec: Fix various integer overflows

2019-06-16 Thread Michael Niedermayer
://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 3558a5b708..61ebfdafd5 100644 --- a/libavcodec/apedec.c

[FFmpeg-devel] [PATCH 4/4] avcodec/apedec: Fix multiple integer overflows in filter_3800()

2019-06-16 Thread Michael Niedermayer
-5759095564402688 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/apedec.c | 16 1 file changed, 8 insertions(+), 8 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c

[FFmpeg-devel] [PATCH 1/4] avcodec/apedec: Fix multiple integer overflows in predictor_update_filter()

2019-06-16 Thread Michael Niedermayer
-by: Michael Niedermayer --- libavcodec/apedec.c | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/libavcodec/apedec.c b/libavcodec/apedec.c index 15eb416ba4..2428c3cb64 100644 --- a/libavcodec/apedec.c +++ b/libavcodec/apedec.c @@ -1124,10 +1124,10

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/bink: Reorder operations in init to avoid memleak on error

2019-06-16 Thread Michael Niedermayer
On Sun, Jun 16, 2019 at 12:37:32PM +1000, Peter Ross wrote: > On Sun, Jun 16, 2019 at 12:00:55AM +0200, Michael Niedermayer wrote: > > Fixes: Direct leak of 536 byte(s) in 1 object(s) > > Fixes: > > 15266/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fu

Re: [FFmpeg-devel] [PATCH] add FF_DECODE_ERROR_CONCEALMENT_ACTIVE flag for AVFrame.decode_error_flags

2019-06-16 Thread Michael Niedermayer
On Fri, Jun 14, 2019 at 07:35:44AM -0700, Amir Pauker wrote: > FF_DECODE_ERROR_CONCEALMENT_ACTIVE is set when the decoded frame has error(s) > but the returned value from > avcodec_receive_frame is zero i.e. concealed errors > > Signed-off-by: Amir Pauker > --- > doc/APIchanges | 3 +++ >

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags to FF_DECODE_ERROR_CONCEALMENT_ACTIVE in case of concealed errors

2019-06-16 Thread Michael Niedermayer
On Fri, Jun 14, 2019 at 07:43:46AM -0700, Amir Pauker wrote: > set AVFrame decode_error_flags to FF_DECODE_ERROR_CONCEALMENT_ACTIVE in case > h->slice_ctx->er.error_occurred is set after the call to > ff_h264_execute_decode_slices. > This allows the user to detect concealed decoding errors in the

  1   2   3   4   5   6   7   8   9   10   >