[FFmpeg-devel] Get rid of magic number in dsicinvideo.c

2015-11-23 Thread Mohammad G
Greetings, File of interest is: libavcodec/dsicinvideo.c Line 103: memcpy(huff_code_table, src, 15); Magic number 15 triggers some source code analysis tools to detect it as a potential issue. I'm requesting a change to: memcpy(huff_code_table, src, sizeof(huff_code_table)); Which is equivalen

Re: [FFmpeg-devel] [PATCH] replace magic number with size of array

2015-11-23 Thread Mohammad G
On Tue, Nov 24, 2015 at 4:10 AM, Ganesh Ajjanagadde wrote: > On Mon, Nov 23, 2015 at 12:03 PM, wrote: > > From: Mohammad Ghasembeigi > > > > --- > > libavcodec/dsicinvideo.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/dsicinvideo.c b/libavcodec/ds