Re: [FFmpeg-devel] [PATCH 3/9] lavfi: use AVFrame.duration instead of AVFrame.pkt_duration

2022-07-13 Thread Nicolas George
ghtly bogus. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ff

Re: [FFmpeg-devel] [PATCH] Add metadatareader filter.

2022-07-07 Thread Nicolas George
Raymond Cheng (12022-07-06): > FFmpeg has a handy set of filters, metadata/ametadata, which allow us > to add, print or save per-frame metadata to a file. I will use these > filters when I want to save the results from speech transcription, > for instance. What is missing is a way to round-trip

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-03 Thread Nicolas George
as would > > be desirable. > Actually, the newer entry will overwrite the older entry; if you want > multiple keys with the same value, you have to use the AV_DICT_MULTIKEY > flag. I stand corrected, thanks. This is still not the most logical behavior, though. Regards, -- Nico

Re: [FFmpeg-devel] [PATCH] avformat/concat: fix missing metadata

2022-07-03 Thread Nicolas George
er that top-posting is forbidden on this mailing-list. If you do not know what it mean, look it up. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mail

Re: [FFmpeg-devel] [PATCH v3 3/3] avfilter/avfiltergraph: add an auto hwmap filter

2022-07-03 Thread Nicolas George
g the feature you wanted to add, please? To do that without too much hassle, I would: first, start again from a new branch, make the "move to a function" commit; second, take the code with the extra feature from the other branch and let git turn it into a commit; third, clean up that

Re: [FFmpeg-devel] [RFC] avdevice/lavfi: output wrapped AVFrames

2022-07-03 Thread Nicolas George
oto fail; > -memcpy(pkt->data, frame->data[0], size); > -} > > frame_metadata = frame->metadata; > if (frame_metadata) { > @@ -465,13 +409,23 @@ static int lavfi_read_packet(AVFormatContext *avctx, > AVPacket *pkt) > goto fail; > } >

Re: [FFmpeg-devel] [PATCH] avutil/channel_layout: don't error out on truncated strings

2022-07-03 Thread Nicolas George
ix is to find where the input is improperly validated, and then revert this change. I do not know how to exploit the "48099/clusterfuzz-testcase-minimized-ffmpeg_dem_MATROSKA_fuzzer-6754782204788736" information to reproduce the bug and investigate. Regards, -- Nicolas George signatu

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
SW's work to be a good step in that direction. It might seem so from the point of view of a user. From my point of view of the person who maintains the framework of libavfilter, support for subtitles is desirable, but SW's patches make my work later significantly harder. -- Nicolas George sig

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
e considering adding more media types for libavfilter. They have been rudely ignored. Are you here to help, or are you here to pour oil on the flame? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-dev

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Soft Works (12022-07-02): > This can easily be done AFTER my patchset has been merged. With exponentially more work. Out of question. This is all I have to say to you on the subject. -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
e than you could chew and reverted to a quick and dirty solution. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ff

Re: [FFmpeg-devel] [ANNOUNCEMENT] New fork

2022-07-02 Thread Nicolas George
Paul B Mahol (12022-07-02): > W} will fork FFmpeg code under new project as current situation is > unbearable. Who are "we"? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Paul B Mahol (12022-07-02): > Could you please mention in relevant thread of those subtitle work where > duplication in code happened? No. Currently, there is no solution, with or without code duplication. -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [RFC] avdevice/lavfi: output wrapped AVFrames

2022-07-02 Thread Nicolas George
has been explained time and again that libavdevice is useful for users of applications that are designed to expect a demuxer, to make them use something more exotic than a demuxer. -- Nicolas George signature.asc Description: PGP signature ___ ffm

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-02 Thread Nicolas George
Paul B Mahol (12022-07-02): > Can this be properly finally be fully reviewed and accepted? As long as the patch does not have a solution to have all the utility filters (setpts, trim, concat, etc.) working with subtitles too without more code duplication, the review is just "NAK".

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe.c: Add new Function: The peak bit rate of video streams can be queried

2022-06-23 Thread Nicolas George
essary, including the XML schema. Please take care to document over what period the bit rate is computed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

Re: [FFmpeg-devel] The case for a good string API

2022-06-17 Thread Nicolas George
ed / referenced. But later. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

Re: [FFmpeg-devel] The case for a good string API

2022-06-16 Thread Nicolas George
o have all useful features of BPrint in the dynamic buffer AVWriter and deprecate BPrint, since that was written in part to learn and do BPrint better. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmp

Re: [FFmpeg-devel] [PATCH 1/2] lavf/avio: add avio_vprintf()

2022-06-12 Thread Nicolas George
ric writers from ffprobe (JSON, XML) in lavu to be used by diagnostic filters. But I will not be doing that with pedestrian strings. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [RFC] User-defined default enc/dec/mux/dem/etc

2022-06-08 Thread Nicolas George
uge configure line. Even from a usability perspective I thin it is not good: just because a BOFH or a quirky package maintainer chose to select different defaults, many examples, many stackoverflow answers stop working. Better teach users to write explicit settings. They can write shell scripts to make it

Re: [FFmpeg-devel] [PATCH v3] avutil/frame: add av_frame_replace

2022-06-07 Thread Nicolas George
ore, but either way, Anton asked > me to resurrect this patch since he intends to use this function too. Ok, thanks for pointing it, I have no objection then. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH v3] avutil/frame: add av_frame_replace

2022-06-07 Thread Nicolas George
ults in several cases in a function that is not really useful because of a small design flaw. Can you update other parts of the code to make use of the new function? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-dev

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Nicolas George
look it up. You are likely to receive no useful reply if you continue. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

Re: [FFmpeg-devel] Weird cross platform support in ffmpeg

2022-05-31 Thread Nicolas George
> > So, how does it work? Please direct users questions to ffmpeg-users and include the exact procedure you have used to try to build and the output it produced, trimmed if necessary. Regards, -- Nicolas George signature.asc Descript

[FFmpeg-devel] [WIP] [PATCH] libavutil: add a limited XML parser

2022-05-06 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/Makefile | 3 + libavutil/tests/xmlparser.c | 93 ++ libavutil/xmlparser.c | 644 libavutil/xmlparser.h | 58 4 files changed, 798 insertions(+) create mode 100644 libavutil/tests

[FFmpeg-devel] [PATCH] lavu/common: fix PUT_UTF8() length

2022-05-06 Thread Nicolas George
ely. Signed-off-by: Nicolas George --- libavutil/common.h | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavutil/common.h b/libavutil/common.h index fd1404be6c..7a71be3c81 100644 --- a/libavutil/common.h +++ b/libavutil/common.h @@ -505,7 +505,9 @@ static av_always_inl

Re: [FFmpeg-devel] [PATCH 00/12] I added text to bitmap subtitle conversion functionality!

2022-05-03 Thread Nicolas George
ocumentation, from having self-contained clean commits to the wording of the commit messages. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/lis

Re: [FFmpeg-devel] Need help submitting a patch

2022-05-03 Thread Nicolas George
Traian Coza (12022-05-03): > Sorry about the "top posting" my client does it automatically. It's a poor craftsman who blames their tools. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] Need help submitting a patch

2022-05-03 Thread Nicolas George
ant 1. Look at how other people submit patches: several commits means several mails. > The source.err file seems to be empty, however. Should I be concerned about > this? It seems to do with the fact that I've added some files. Yes, you need to fix it. > On Tue, May 3, 2022 at 3:54 AM

Re: [FFmpeg-devel] Need help submitting a patch

2022-05-03 Thread Nicolas George
you thought of making a branch: then you just need to specify the name of the branch from which you branched. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.or

Re: [FFmpeg-devel] PATCH - libmad MP3 decoding support

2022-05-02 Thread Nicolas George
Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@f

Re: [FFmpeg-devel] Guidance needed for a semi-breaking change

2022-04-27 Thread Nicolas George
hanges that are unambiguously and exclusively an improvement are acceptable.) Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsub

Re: [FFmpeg-devel] proposal for a minor change in the behavior of the drawtext filter

2022-04-24 Thread Nicolas George
. The problem with line spacing is the tiniest of drawtext problems: look for right-to-left, ligatures and so much more. If you want to enhance the output of drawtext, I think it would be more efficient to choose a good layout engine library, Libre and portable, and to make it use it optionally. Reg

Re: [FFmpeg-devel] [RFC] Switching ffmpeg.c to a threaded architecture

2022-04-13 Thread Nicolas George
tly works. You made your bed. -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] warning about configuration mismatch between ff* binaries and libraries

2022-04-11 Thread Nicolas George
Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

Re: [FFmpeg-devel] [PATCH] avfilter/f_realtime: add support for commands

2022-03-29 Thread Nicolas George
Paul B Mahol (12022-03-29): > will apply No objection. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: make the ac option set the demuxer's ch_layout AVOption

2022-03-20 Thread Nicolas George
p.str, 0); > +av_bprint_finalize(, NULL); You do not need a BPrint for that, the size of the expansion of %d is very limited, especially the values that can be relevant here. > } > } > if (o->nb_audio_ch_layouts) { Regards, -- Nicolas George signature.

Re: [FFmpeg-devel] [PATCH 7/7] ffmpeg: deprecate the ac option

2022-03-20 Thread Nicolas George
ith the "short" alias in the previous patch. Also, there are many occurrences of "-ac" in the documentation, they need to be updated too. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH] avfilter: add Audio Video Sync Test filter

2022-03-16 Thread Nicolas George
.0 * (2.0 + pi - 16.0 / pi) * (1 << 24); > +int64_t x2, result; > +int32_t t1, t2; Can you consider reuse the code from asrc_sine to generate a bit-exact sin table? Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH v3 7/7] avformat/concat: refactor to use ff_rescale_interval()

2022-03-08 Thread Nicolas George
p...@sandflow.com (12022-03-07): > From: Pierre-Anthony Lemieux > > --- > libavformat/concatdec.c | 18 -- > 1 file changed, 4 insertions(+), 14 deletions(-) This patch still LGTM. Regards, -- Nicolas George signature.asc Description

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-06 Thread Nicolas George
t you would rather be rude than wait a few days? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or e

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-05 Thread Nicolas George
won by being so annoying is that I cannot consider looking into it right now because I am too annoyed and angry. This is all I have to say to you. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-05 Thread Nicolas George
g to activate to work, including EOF. There is a bug somewhere, and your analysis is not enough to know exactly where. Until I understand what is going on exactly and if there is a framework bug that needs fixing, I demand you hold. -- Nicolas George signature.asc Descr

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-04 Thread Nicolas George
ing wrong going on there, and I want to understand what before this change makes it go away: otherwise, we might be missing other similar bugs. It has waited several months, a few days more will not hurt. Regards, -- Nicolas George signature.asc Description

Re: [FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation

2022-03-03 Thread Nicolas George
to cover all the logic in >> pick_format() and the logic in swap_*(). And having submodule-specific fate targets is convenient even if there are only one test. Please read the code assuming there are several tests, including tests using aresample rather than scale. Regards, -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH] avfilter/split: switch to activate()

2022-03-03 Thread Nicolas George
t behaves different than WAV please let me know. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit lin

[FFmpeg-devel] [PATCH 5/5] tests: add coverage for libavfilter's format negotiation

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- tests/Makefile | 1 + tests/fate-run.sh| 4 tests/fate/libavfilter.mak | 9 + tests/ref/fate/libavfilter-negotiation-alpha | 20 4 files changed, 34

[FFmpeg-devel] [PATCH 4/5] lavfi/(a)format: support slash as a delimiter

2022-03-02 Thread Nicolas George
Unlike pipe, slash does not require escaping. Signed-off-by: Nicolas George --- doc/filters.texi | 8 libavfilter/internal.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) Same as sent earlier today. diff --git a/doc/filters.texi b/doc/filters.texi index 8cba7f744d

[FFmpeg-devel] [PATCH 3/5] lavfi/(a)format: factor finding the delimiter

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_aformat.c | 8 +--- libavfilter/internal.h | 9 + libavfilter/vf_format.c | 9 - 3 files changed, 18 insertions(+), 8 deletions(-) Same as sent earlier today. diff --git a/libavfilter/af_aformat.c b/libavfilter

[FFmpeg-devel] [PATCH 1/5] lavfi/graphdump: add plain listing output

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avfilter.h | 5 ++- libavfilter/graphdump.c | 79 +++-- 2 files changed, 80 insertions(+), 4 deletions(-) Unchanged since last summer. The last patch is what this is needed for. diff --git a/libavfilter

[FFmpeg-devel] [PATCH 2/5] fftools: add -lavfi_dump option

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/ffmpeg.texi | 4 fftools/ffmpeg.h| 1 + fftools/ffmpeg_filter.c | 14 ++ fftools/ffmpeg_opt.c| 3 +++ 4 files changed, 22 insertions(+) Unchanged since last summer. diff --git a/doc/ffmpeg.texi b/doc/ffmpeg.texi

[FFmpeg-devel] [PATCH 2/2] lavfi/(a)format: support slash as a delimiter

2022-03-02 Thread Nicolas George
Unlike pipe, slash does not require escaping. Signed-off-by: Nicolas George --- doc/filters.texi | 8 libavfilter/internal.h | 2 +- 2 files changed, 5 insertions(+), 5 deletions(-) Especially in makefiles, escaping is annoying. diff --git a/doc/filters.texi b/doc

[FFmpeg-devel] [PATCH 1/2] lavfi/(a)format: factor finding the delimiter

2022-03-02 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/af_aformat.c | 8 +--- libavfilter/internal.h | 9 + libavfilter/vf_format.c | 9 - 3 files changed, 18 insertions(+), 8 deletions(-) diff --git a/libavfilter/af_aformat.c b/libavfilter/af_aformat.c index d2599431dc

Re: [FFmpeg-devel] [PATCH] lavfi/af_aformat: remove support for comma-separated lists

2022-03-02 Thread Nicolas George
reviewing in the future. > LGTM. Thanks, pushed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visi

[FFmpeg-devel] [PATCH] lavfi/af_aformat: remove support for comma-separated lists

2022-03-02 Thread Nicolas George
It has been deprecated for nine years. Signed-off-by: Nicolas George --- libavfilter/af_aformat.c | 11 ++- 1 file changed, 2 insertions(+), 9 deletions(-) I want to share the delimiter-seeking function with vf_format and add support for '/'. diff --git a/libavfilter/af_aformat.c b

Re: [FFmpeg-devel] [PATCH] libavformat/concatdev.c: Add unified_time_base opt

2022-03-01 Thread Nicolas George
w versions of this patch every few minutes. Please take your time. And before next time: > int segment_time_metadata; > +int unified_time_base; Mangled indentation. Missing documentation. Spelling mistake in the title of the commit message. Re

Re: [FFmpeg-devel] [PATCH v2 1/2] tools: add general_assembly.pl

2022-02-24 Thread Nicolas George
ere not counted, now they are. - Cosmetic patches are counted. - It does not take the size of the changes. Using an imperfect solution for bootstrap is one thing, using it permanently is another. Regards, -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH v2 7/7] avformat/concat: refactor to use av_rescale_interval()

2022-02-21 Thread Nicolas George
p...@sandflow.com (12022-02-20): > From: Pierre-Anthony Lemieux > > --- > libavformat/concatdec.c | 19 +-- > 1 file changed, 5 insertions(+), 14 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: add ff_inoutlink_check_flow()

2022-02-20 Thread Nicolas George
Paul B Mahol (12022-02-19): > OK for the set. Thanks, pushed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-de

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output

2022-02-19 Thread Nicolas George
Nicolas George (12022-02-19): > This would break input-driven filtering I think. I am looking into it. See: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293240.html https://ffmpeg.org/pipermail/ffmpeg-devel/2022-February/293241.html Regards, -- Nicolas George signature.

[FFmpeg-devel] [PATCH 2/2] lavfi/vf_fps: check flow before sending more frames

2022-02-19 Thread Nicolas George
Analyzed by Paul B Mahol . Fixes OOM in #9081. Signed-off-by: Nicolas George --- libavfilter/vf_fps.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/vf_fps.c b/libavfilter/vf_fps.c index 99e679441e..0e5a1fec35 100644 --- a/libavfilter/vf_fps.c +++ b/libavfilter

[FFmpeg-devel] [PATCH 1/2] lavfi: add ff_inoutlink_check_flow()

2022-02-19 Thread Nicolas George
Signed-off-by: Nicolas George --- libavfilter/avfilter.c | 8 libavfilter/filters.h | 8 2 files changed, 16 insertions(+) diff --git a/libavfilter/avfilter.c b/libavfilter/avfilter.c index 7362bcdab5..1f37a70179 100644 --- a/libavfilter/avfilter.c +++ b/libavfilter

Re: [FFmpeg-devel] [PATCH] avfilter/vf_fps: only give frame as soon as possible if really requested by output

2022-02-19 Thread Nicolas George
Paul B Mahol (12022-02-19): > Fixes OOM in #9081. > > Signed-off-by: Paul B Mahol > --- > libavfilter/vf_fps.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) This would break input-driven filtering I think. I am looking into it. Regards, -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-31 Thread Nicolas George
Thilo Borgman (12022-01-31): > > v10 attached. > > Also going to apply soon if there are no more comments. I think you neglected to attach the file. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-d

Re: [FFmpeg-devel] [PATCH 001/293 v8] avutil/channel_layout: Add a new channel layout API

2022-01-27 Thread Nicolas George
cribed by the given string, or a negative > AVERROR > + * value. > + */ > +int av_channel_layout_index_from_string(const AVChannelLayout > *channel_layout, > + const char *name); > + > +/** > + * Get a c

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
ything else... needs more work. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-deve

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > Like you said below, the functions must be reciprocal, so they can't take > that field into account. A serializaion function is supposed to serialize the whole structure. I will not accept less. -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
ise. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subj

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > -map_channel works perfectly with the current bitmask API, and the new one. Not if there are several times the same channel with different labels. It should. -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
James Almer (12022-01-17): > Yes, which is why I'll make describe() stop looking at the name field. Unacceptable. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
designation, but av_channel_layout_from_string() > expects the designations only, never the custom label. Oh, excellent point. av_channel_layout_from_string() should be able to parse the output of av_channel_layout_describe_bprint() in all cases. And it should be covered by FATE. Regards, --

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-17 Thread Nicolas George
e the parsing belongs in a common API. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or em

Re: [FFmpeg-devel] [PATCH 001/281] Add a new channel layout API

2022-01-16 Thread Nicolas George
nel_from_string(layout, "FC[piano]#2"); (I think it would be acceptable to limit the name, for example "names with non-alphanumeric ASCII characters are not supported.) And this need to go in the user documentation. I am not sure if we also need a function to extract "all the FL

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-16 Thread Nicolas George
econds or centiseconds (%6N, %2N). - It is somewhat compatible with GNU date and possibly a few others. And I do not think it is harder to implement. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing lis

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Nicolas George
om the point of view of the user? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2022-01-14 Thread Nicolas George
actually implement it. Sorry, I completely missed you reply. No, I do not think it is best: your solution requires the user to use a different function, I find this inelegant and not user friendly. I like the solution where the option is enabled by the format string itself much more user friendly. Bu

Re: [FFmpeg-devel] 5.0 blocking issues

2022-01-12 Thread Nicolas George
is shared by the majority of > contributors on this mailing list? I do not need to: if we are a minority thinking that way, then the majority can step in and do the work that "needs" to be done. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] 5.0 blocking issues

2022-01-12 Thread Nicolas George
se FFmpeg, who need it. We already give good, free code, and they want more, API stability and backports and security maintenance. I say: if you want it, pay somebody to do it. (Not me, I am not interested, that is my point.) This is reminiscent of the reaction of corporate drones to the log4j bugs:

Re: [FFmpeg-devel] 5.0 blocking issues

2022-01-12 Thread Nicolas George
step in for the role of release manager. And if nobody steps in, let us not make releases. After all, WE do not need to make releases: it is the other projects who need us to make releases. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-12-29 Thread Nicolas George
lisecond. It can later be expanded to support %xN at any place in the format for any value of x. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/f

[FFmpeg-devel] The case for a good string API

2021-12-22 Thread Nicolas George
string API? If not, please explain why? 2. Assuming we agree ‘yes’ on the previous question, do you think AVWriter is a good candidate? If not, what else would you propose? Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/mov: add validate_box_size

2021-12-22 Thread Nicolas George
!size_fit; > +} > + > static int mov_metadata_track_or_disc_number(MOVContext *c, AVIOContext *pb, > unsigned len, const char *key) > { I think the changes belong in a single patch. Regards, -- Nicolas George signature.asc Descri

Re: [FFmpeg-devel] [PATCH] libavformat: add side_data copy in concat demuxer

2021-12-22 Thread Nicolas George
at-demuxer-simple1-lavf-mxf_d10 | 1 + > tests/ref/fate/concat-demuxer-simple2-lavf-ts | 1 + > 8 files changed, 24 insertions(+), 2 deletions(-) Applied, thanks, and again sorry for the delay. Regards, -- Nicolas George signature.asc Description: PGP signature

Re: [FFmpeg-devel] [PATCH] libavformat: add side_data copy in concat demuxer

2021-12-15 Thread Nicolas George
at-demuxer-simple1-lavf-mxf_d10 | 1 + > tests/ref/fate/concat-demuxer-simple2-lavf-ts | 1 + > 8 files changed, 24 insertions(+), 2 deletions(-) Sorry. I was about to apply it but something else came up. This version looks even better. I will try to find time in the next few days. R

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-15 Thread Nicolas George
knows the label, then the user can write: pan='stereo=0.3*.oboe+0.7*.piano' and the system automatically pick the channels from the oboe and the piano and figure out the matrix (if the oboe is recorded in mono for example). Regards, -- Nicolas George _

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-15 Thread Nicolas George
nnel_layout_channel_from_string(), including tests. Thanks. Now we need the user interface: how does the user say “the left channel with label "oboe"”? Probably something like "FL.oboe". The parsing functions need to be adapted. Regards, -- Nicolas George __

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Nicolas George
rings between layouts that are similar but not equal is worth the added complexity. (We may consider a ref-counted string type at some point, maybe, but that is another story.) Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmp

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Nicolas George
u propose, and other people are allowed to weigh in when it is posted here, too. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Nicolas George
, but that's the case either way. You are still neglecting the user interface side of things. Please try to consider actual scenarios with the example Marton and I gave from the point of view of users using the generic command-line tool. -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Nicolas George
ve people who come a little late deserve to know what the arguments were and even to weigh in. IRC is a terrible medium for this kind of discussion. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Nicolas George
) know about these strange layouts, and most components only look at the standard part of the layout and behave as they do now or with the straightforward extension to the more powerful API. -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-14 Thread Nicolas George
we leave two thirds of the uses cases for something else in side data, I would object to. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-14 Thread Nicolas George
is too narrow. Currently, channel layouts are also used to compute matrix coefficients for remixing, for example. But even if we adopt this definition, mapping (oboe left, oboe right, piano left, piano right) onto stereo is perfectly in scope. Regards, -- Nicolas George signature.asc D

Re: [FFmpeg-devel] [PATCH 001/279] Add a new channel layout API

2021-12-14 Thread Nicolas George
ref-counted. Remember that I proposed a template to make ref-counted structures easily: https://ffmpeg.org/pipermail/ffmpeg-devel/2020-June/265227.html (Notice that it was soon after the first version of this API was posted: I was thinking of it already then.) Regards, -- Nicolas George s

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-13 Thread Nicolas George
d devices can flag the channel layout they need, which they could not because of the limitation of the current API, seems 100% in scope to me. What is your definition of the scope of a channel layout API? I hope it is not "we did it that way, anything it cannot do is beyond the scope".

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Nicolas George
string, even with a hard limit, would be fine. I want a real string API for the layout→string function, and that can be done later. What I consider blocking is the ability to have several times the same layout with a proper user interface. Regards, -- Nicolas George signature.asc Descriptio

Re: [FFmpeg-devel] 5.0 release

2021-12-13 Thread Nicolas George
eep the current API. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-req

Re: [FFmpeg-devel] [PATCH v2] lavfi/drawtext: Add localtime_ms for millisecond precision

2021-12-12 Thread Nicolas George
of 21:12:42.1234+0100. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-d

Re: [FFmpeg-devel] [PATCH 000/279] New channel layout API

2021-12-12 Thread Nicolas George
USER_SPECIFIED channel is the oboe, this USER_SPECIFIED is the piano", and the user must be able to tell the API "the second USER_SPECIFIED channel" or "the USER_SPECIFIED channel relating to the piano". B. Possibly, I do not personally insist on it like A: groups of channels

Re: [FFmpeg-devel] Politics

2021-12-12 Thread Nicolas George
y ignored. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

<    1   2   3   4   5   6   7   8   9   10   >