Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Nicolas George
about the libav split? Do you have a point, or are you just trying to make the discussion more unpleasant than it already is? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpe

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Nicolas George
s kind of question a simple one person = one vote system would be a grave mistake. This kind of decision has to be taken by weighing opinions by how much developers are impacted. Regards, -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Nicolas George
ointed that you would make a judgement like that without reading carefully and realizing that Soft Works has turned my position on its head. My statement is: newbies ⇒ like newfangled tools. My statement never was: like newfangled tools ⇒ newbies. Regards, -- Nicolas George signature.asc Descr

Re: [FFmpeg-devel] Subject: [PATCH] Cleanup code in truemotion1 decoder

2021-08-14 Thread Nicolas George
be extra-respectful of your peers and trim your quote, just like I did. > Hence why top-posting was invented Top-posting was not invented, it originally was just laziness and ignorance by people discovering e-mail without being taught. -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] Subject: [PATCH] Cleanup code in truemotion1 decoder

2021-08-14 Thread Nicolas George
ffmpegandmahanstreamer (12021-08-14): > Once again this proves the superioity of the graphical stuff. Start with not top-posting and we may take your opinion on the superiority of stuff seriously. -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Nicolas George
considering any deep change, it would be necessary to actively poll the silent individual-minority-work-majority. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://

Re: [FFmpeg-devel] [PATCH 2/4] avfilter/avfilter: Add numbers of (in|out)pads directly to AVFilter

2021-08-14 Thread Nicolas George
.nb_inputs = FF_ARRAY_ELEMS(array) Also, I am rather not for using these fields directly. Keeping them private and leaving avfilter_pad_count() gives us more freedom, including the freedom to change the type from uint16_t to unsigned later without break. Regards, -- Nicolas George signatur

Re: [FFmpeg-devel] [PATCH 2/5] lavf/concatdec: support per-file options.

2021-08-14 Thread Nicolas George
TRDUP_KEY | > > AV_DICT_DONT_STRDUP_VAL); > > +if (ret < 0) { > > +av_freep(); > > +av_freep(); > > Double free. Uh? Oh, I had the logic backwards. Fixed. Will send a new series soon. Regards, -- Nicolas George

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Nicolas George
ths. I have no qualms saying this, since I have not been very active in the recent months, so by this measure my opinion should count for rather little. But this is important: the choice should not be a matter of democracy, it should be a matter of efficiency. Regards, -- Nicolas George sig

[FFmpeg-devel] Third opinion? (was: lavf/avio: remove support for proto, , opt, val, , syntax.)

2021-08-14 Thread Nicolas George
Nicolas George (12021-07-30): > Andreas Rheinhardt (12021-07-29): > > The latter statement is not true: This is public API; anyone can have > > used it for any purpose. Your 2/5 adds a replacement for using it with > > dvd2concat, but there are other usages, too; e.g.

Re: [FFmpeg-devel] [PATCH 09/10] lavf/file: handle standard file:// URLs.

2021-08-14 Thread Nicolas George
percent encoded form can be used for all the cases. > > This way eventually the file: handling can be fully RFC compliant. This is the ultimate goal, of course. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpe

[FFmpeg-devel] Third opinion anybody?: (was: lavu/internal: add hex to int functions.)

2021-08-14 Thread Nicolas George
Nicolas George (12021-07-28): > You mean make it public? I am not against it, but I would wait for a > third opinion. If there are no third opinion, I will stick with the conservative stance and keep it private. Regards, -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [PATCH 1/2] lavu/internal: add FF_FIELD_AT().

2021-08-14 Thread Nicolas George
Nicolas George (12021-07-24): > Signed-off-by: Nicolas George > --- > libavutil/internal.h | 5 + > 1 file changed, 5 insertions(+) Patch series pushed after more time than expected. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Nicolas George
t "Thanks for a reasonable reply this time.", as it implies my other replies were unreasonable. I have used irony and imaged language, but at no point have I being unreasonable. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg

Re: [FFmpeg-devel] [FFmpeg-cvslog] Fix for bug #9231: B-frames parameter is ignored in videotoolboxenc

2021-08-13 Thread Nicolas George
ext before a colon, and then what the patch does, not what was wrong before. And "Fix track ticket #9231" somewhere below. It is not a grave mistake, but please be more careful next time. Regards, -- Nicolas George signature.asc Description:

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-13 Thread Nicolas George
t. > It's about developers being unwilling to participate due to > the outdated and inferior (from their pov) tooling. ... But honestly, I doubt somebody who refuses to consider the merits of our work-flow would be qualified to help newbies to adapt to our work-flow. Regar

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
re you a rant about what e-mail is, please have the decency not to provoke it with that kind of dishonesty. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/li

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
is all I have to say on the matter. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-dev

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
Jean-Baptiste Kempf (12021-08-12): > No, but you can talk to people nicely. Fair enough. Can you call out Kieran too for his passive-aggressive "thank you for confirming [the opposite of what I wrote]", please? It was not nice either. Regards, -- Nicolas George signature.as

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
Kieran Kunhya (12021-08-12): > And how do the 1.5 billion Gmail users use SMTP without disabling security > features? Do I need to do tech support for Google too? https://support.google.com/mail/answer/7126229?hl=en https://support.google.com/accounts/answer/185833?hl=en -- Nicolas

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
Kieran Kunhya (12021-08-12): > Can you first clarify where this SMTP server comes from as you conveniently > ignored this point? I already wrote: "the SMTP server of your mail provider". -- Nicolas George signature.asc Descriptio

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
s long? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with s

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
it evolve for the better while retaining the parts that work well. If you want the project to change its way of working to accommodate you before we even know if you will be submitting quality patches for the long run... go grok some PHP or something. -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
; and look if... oh, it's there, there a whole section about connecting to a SMTP server directly. In short, you could check your facts before wasting everybody's time with misinformation. -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-12 Thread Nicolas George
alued contributor to this # project. If you cannot, then please go grok some PHP or something. Then feel free to set-up a Discourse or Discord or whatever kids use these days to help each other pass the bar. As long as what we get on the mailing-list are patches that are already in good shape for revie

Re: [FFmpeg-devel] [PATCH 0/3] libavformat/protocols.c: avio_enum_protocols(): Cleanup

2021-08-11 Thread Nicolas George
This is my my opinion, but better squash related changes: what matters is the final code, how readable it is. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg

Re: [FFmpeg-devel] [PATCH 10/10] avfilter/avfilter: Hide most internal AVFilterLink fields

2021-08-11 Thread Nicolas George
rivate. I wrote it the way it is precisely to avoid these two drawbacks. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To u

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/avfilter: Make ff_update_link_current_pts static

2021-08-11 Thread Nicolas George
to avoid the forward declaration if you want later. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link a

Re: [FFmpeg-devel] [PATCH 07/10] avfilter/internal: Factor out executing a filter's execute_func

2021-08-11 Thread Nicolas George
Andreas Rheinhardt (12021-08-11): > The current way of doing it involves writing the ctx parameter twice. > > Signed-off-by: Andreas Rheinhardt LGTM, but it is not my area of expertise. Regards, -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH 04/10] avfilter/formats: Factor common function combinations out

2021-08-11 Thread Nicolas George
l filters, although I can take the time to look at them more carefully if you want. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: Use av_memdup where appropriate

2021-08-11 Thread Nicolas George
Andreas Rheinhardt (12021-08-11): > Signed-off-by: Andreas Rheinhardt > --- > libavfilter/avfilter.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) LGTM. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 1/3] avfilter/avfilter: Fix leaks upon filter creation error

2021-08-11 Thread Nicolas George
eady found out is that libvamf > is buggy (even without calling avfilter_free), because it just presumes > that a mutex and a condition variable have always been properly > initialized. Useful work, thanks. Regards, -- Nicolas George s

Re: [FFmpeg-devel] Mail quoting (was: libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Nicolas George
r own rules for how to color the mails > I would assume any half decent MUA should be able to do something similar Mutt also has a short-cut (S by default) to skip until the first line of non-quoted text. It is a life-saver when you all do not trim your mails. Regards, -- Nicolas George

[FFmpeg-devel] Mail quoting (was: 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time)

2021-08-10 Thread Nicolas George
ble in mail archives, of course, nobody can prevent that, especially if you have full archives of your own somewhere. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-10 Thread Nicolas George
Soft Works (12021-08-10): > I'm not sure whether it's OK to strip all content when there's nothing > new inside..? I do not understand what you are talking about, sorry. Regards, -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [PATCH 1/2] lavfi: Add vf_ssim360 filter

2021-08-09 Thread Nicolas George
hy do you do this with a test in each activate() rather than in init() or one of the config_props()? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailm

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)segment filters

2021-08-09 Thread Nicolas George
} > +}; > +#undef FLAGS > + > +AVFILTER_DEFINE_CLASS(segment); > + > +static const AVFilterPad segment_inputs[] = { > +{ > +.name = "default", > +.type = AVMEDIA_TYPE_VIDEO, > +.config_

Re: [FFmpeg-devel] [PATCH v4 1/2] libavutil/log: Add capability to prefix loglines with current time or current date+time

2021-08-09 Thread Nicolas George
> *fmt, va_list vl, > */ > #define AV_LOG_PRINT_LEVEL 2 > > +/** > + * Include system time in log output. "local time" > + */ > +#define AV_LOG_PRINT_TIME 4 > + > +/** > + * Include system date and time in log output. Ditto. > + */ > +#defi

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)segment filters

2021-08-08 Thread Nicolas George
I intend to look at this today. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

[FFmpeg-devel] [PATCH] [fateserver] Cleanup and security strengthening

2021-08-08 Thread Nicolas George
to work correctly on the real or beta server and it is confirmed that the recent issue is avoided, please feel free to apply without waiting for me. Regards, -- Nicolas George From 14230b19cd3b194888a070905a8b7301d9f8980f Mon Sep 17 00:00:00 2001 From: Nicolas George Date: Sun, 8 Aug 2021 15:12:17

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
too, does not cause another ref change, but I will leave it there. Please just be more careful about which patches were approved and which were not. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
Linjie Fu (12021-08-05): > Where is supposed to be the right placement? In the commit that makes the results change. Just do this: checkout the first commit, build, run FATE. Does it pass? Regards, -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
maintain the fftools part and did not approve it. Since nobody approved it, you should not have pushed. At a glance, it was wrong about the placement of the FATE change. Be ready to revert if there is any objection, and in the future be more careful. Regards, -- Nicolas George signature.asc De

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools: Don't set default swscale flags in ffmpeg/ffprobe/ffplay

2021-08-05 Thread Nicolas George
d somebody approve the fftools patches? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or em

Re: [FFmpeg-devel] [PATCH 2/3] avfilter/avfilter: update sample_count_in/out

2021-08-05 Thread Nicolas George
isabled = !ff_inlink_evaluate_timeline_at_frame(link, > frame); > link->frame_count_out++; > +link->sample_count_out += frame->nb_samples; > } > > int ff_inlink_consume_frame(AVFilterLink *link, AVFrame **rframe) LGTM if you squash 1 and 2 together. -- Nicolas Geo

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: add sample_count_in and sample_count_out

2021-08-05 Thread Nicolas George
Paul B Mahol (12021-08-05): > Signed-off-by: Paul B Mahol > --- > libavfilter/avfilter.h | 5 + > 1 file changed, 5 insertions(+) Ok for the principle, but you seem to have forgotten to update avfilter.c to make these fields useful. Regards, -- Nicolas George s

Re: [FFmpeg-devel] [PATCH 9/9] avfilter/avfilter: Remove unused partial_buf

2021-08-05 Thread Nicolas George
Andreas Rheinhardt (12021-08-05): > It is unused since 02aa0701ae0dc2def8db640c9e3c06dc1b5de70c. > The corresponding size field is write-only since then. > > Signed-off-by: Andreas Rheinhardt > --- > I was quite surprised to find this. LGTM, good catch. Regards, --

Re: [FFmpeg-devel] Mailing List Delay

2021-08-04 Thread Nicolas George
Michael Niedermayer (12021-08-04): > yes it looks like it is dnsbl & greylisting Greylisting should whitelist known full mail servers, since they'll retry later anyway. Regards, -- Nicolas George signature.asc Description: PGP si

Re: [FFmpeg-devel] [PATCH v3 1/2] lavfi/vf_scale: use default swscale flags for simple and complex filter graph

2021-08-04 Thread Nicolas George
what I am talking about. The application can set scale->flags to NULL. If it does, *scale->flags_str crashes. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/codec: Reorder elements to make AVCodec smaller

2021-08-04 Thread Nicolas George
erall a more > important part for readability of the headers, then a few bytes saved. It seems drastic, but it is not really: almost all the fields are pointers, we can group them any way we want. Regards, -- Nicolas George signature.asc Description

Re: [FFmpeg-devel] [PATCH 4/4] avformat/avio: Move internal AVIOContext field to the end

2021-08-04 Thread Nicolas George
Andreas Rheinhardt (12021-08-04): > Good. Because I intend to send another patchset that breaks ABI (but > only the avpriv-ABI, not the public ABI). If we lock all libraries version together, we never have to worry about avpriv ABI. Regards, -- Nicolas George signature.asc Descriptio

Re: [FFmpeg-devel] [PATCH 5/5] avutil/log: Reorder elements of AVClass to make it smaller

2021-08-04 Thread Nicolas George
ight as well order fields by size. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 3/4] avcodec/codec: Reorder elements to make AVCodec smaller

2021-08-04 Thread Nicolas George
than fortuitously: move capabilities and max_lowres after all the pointers. For reference, the robust way of avoiding padding in structures is to order fields by decreasing size. Since the public part of AVCodec changes rarely, once it is done, it should mostly hold. Regards, -- Nicolas Geor

Re: [FFmpeg-devel] [PATCH v3 1/2] lavfi/vf_scale: use default swscale flags for simple and complex filter graph

2021-08-04 Thread Nicolas George
; -0, 1, 1,1,57600, > e6fbdabaf1bb0d28afc648ed4d27e9f0 > -0, 2, 2,1,57600, > 52924ed0a751214c50fb2e7a626c8cc5 > -0, 3, 3,1,57600, > 67d5fd6ee71793f1cf8794d1c27afdce > -0, 4, 4,1,

Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet get exceptions

2021-08-04 Thread Nicolas George
Steven Liu (12021-08-04): > Ok, "avformat/hls: return ret when read_packet return error codes." "forward error code" is the idiomatic wording, according to git log. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet get exceptions

2021-08-04 Thread Nicolas George
Steven Liu (12021-08-04): > Subject: Re: [FFmpeg-devel] [PATCH] avformat/hls: return ret when read_packet > get exceptions Nit: FFmpeg does not have exceptions, it has error codes. Regards, -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/internal: Don't include libavcodec/(avcodec|internal).h

2021-08-03 Thread Nicolas George
Andreas Rheinhardt (12021-08-03): > Does this LGTM also pertain to the preceding two patches (which remove > the reasons for including these headers)? No. Patch #7 looks ok, but I do not maintain that file. I do not have expertise to judge #6. Regards, -- Nicolas George signatu

Re: [FFmpeg-devel] [PATCH 09/10] avfilter/internal: Don't include framepool.h, thread.h

2021-08-03 Thread Nicolas George
| 1 + > libavfilter/internal.h | 2 -- > libavfilter/video.c| 1 + > 4 files changed, 3 insertions(+), 2 deletions(-) Ok. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 08/10] avfilter/internal: Don't include libavcodec/(avcodec|internal).h

2021-08-03 Thread Nicolas George
yout.h libavutil/fifo.h > libavcodec/bsf.h LGTM. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH] avfilter/avfilter: use av_frame_copy() to copy frame data

2021-08-03 Thread Nicolas George
James Almer (12021-08-02): > Signed-off-by: James Almer > --- > libavfilter/avfilter.c | 17 - > 1 file changed, 4 insertions(+), 13 deletions(-) imgutils.h is probably now unneeded. LGTM otherwise. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH v2 4/4] fftools/cmdutils: pass sws_flags to scale filter in simple filter graph

2021-08-02 Thread Nicolas George
the 'flags=' part > +fg->graph->scale_sws_opts = av_strdup(args+4); > +} What? This code does not seem to match the commit message. More explanation needed. > > args[0] = 0; > while ((e = av_dict_get(ost->swr_opts, "", e, Regards

Re: [FFmpeg-devel] [PATCH v2 2/4] lavfi/vf_scale: use single default swscale flags for simple and complex filter graph

2021-08-02 Thread Nicolas George
libswscale", OFFSET(flags_str), > AV_OPT_TYPE_STRING, { .str = "bicubic" }, .flags = FLAGS }, This is wrong: still overriding swscale's default. > { "interl", "set interlacing", OFFSET(interlaced), AV_OPT_TYPE_BOOL, > {.i64 = 0 }, -1, 1, FLAGS }, >

Re: [FFmpeg-devel] [PATCH v2 3/4] libswscale/utils: simplify the default scaler logic

2021-08-02 Thread Nicolas George
Linjie Fu (12021-08-03): > From: Linjie Fu > > Signed-off-by: Linjie Fu > --- > libswscale/utils.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) Nack. The original logic needs to be evaluated to see if the others scalers are better. Regards, --

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)separate filters

2021-08-02 Thread Nicolas George
" appear in the first sentence of the documentation, to make searching easy. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsu

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)separate filters

2021-08-02 Thread Nicolas George
lter_frame(ctx->outputs[s->current_point], frame); > +} > + > +if (ret < 0) { > +return ret; > +} else if (ff_inlink_acknowledge_status(ctx->inputs[0], , )) { > +for (int i = s->current_point; i < s->nb_points; i++) > +

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)separate filters

2021-08-01 Thread Nicolas George
matter of definition, it is a matter of connotations. You do not find those in a dictionary. You are even less a native speaker than me, are you not? Let us have the opinion from a native speaker. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)separate filters

2021-08-01 Thread Nicolas George
ffmpegandmahanstreamer@e.email (12021-08-01): > Seperate is best word No, it is not, I have explained why. Chemists separate. Do you have arguments? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffm

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)separate filters

2021-08-01 Thread Nicolas George
be timesplit. Or segment. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-

Re: [FFmpeg-devel] [PATCH] avfilter: add (a)separate filters

2021-08-01 Thread Nicolas George
ffmpegandmahanstreamer@e.email (12021-08-01): > LGTM, as always. Who are you? What qualifications do you have to review patches? -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: make the default swscale flags identical for simple and complex filter graph

2021-08-01 Thread Nicolas George
710f55e490d0c3cf7348b3ca91c8c0fe4274be2. "The default is left at bicubic until someone has compared the scalers properly speed and quality wise." But eight years later nobody did. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH 1/2] fftools/cmdutils: make the default swscale flags identical for simple and complex filter graph

2021-08-01 Thread Nicolas George
Linjie Fu (12021-08-01): > From: Linjie Fu > > Currently the default swscale flags for simple filter graph is bicubic, > however for complex filter graph it uses bilinear as decleared in scale > filter. Why does ffmpeg set a default different from swscale? Regards, --

Re: [FFmpeg-devel] [PATCH][libavcodec] Adding sprite support to duck truemotion1

2021-07-31 Thread Nicolas George
ffmpegandmahanstreamer@e.email (12021-07-31): > In my next patch how about "This patch adds sprite support to the Duck > TrueMotion1 decoder." Have you considered looking at what other people do, especially regular developers? https://git.ffmpeg.org/ffmpeg.git Regards, --

Re: [FFmpeg-devel] [PATCH 5/5] lavf/avio: remove support for proto, , opt, val, , syntax.

2021-07-30 Thread Nicolas George
nating subfiles is useful? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

Re: [FFmpeg-devel] [PATCH 01/10] lavu/internal: add hex to int functions.

2021-07-28 Thread Nicolas George
t, no problem. Good idea. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmp

Re: [FFmpeg-devel] [PATCH 5/5] lavf/avio: remove support for proto, , opt, val, , syntax.

2021-07-28 Thread Nicolas George
Gyan Doshi (12021-07-28): > > > On 2021-07-28 17:45, Nicolas George wrote: > > It was only still supported for subfile and only used by dvd2concat. > > Examples at http://www.ffmpeg.org/ffmpeg-protocols.html#subfile should be > updated. Good catch, thanks. Locally com

[FFmpeg-devel] [PATCH 5/5] lavf/avio: remove support for proto, , opt, val, , syntax.

2021-07-28 Thread Nicolas George
It was only still supported for subfile and only used by dvd2concat. Signed-off-by: Nicolas George --- libavformat/avio.c| 34 +- libavformat/dashdec.c | 2 +- libavformat/hls.c | 2 +- 3 files changed, 3 insertions(+), 35 deletions(-) diff --git

[FFmpeg-devel] [PATCH 4/5] tools/dvd2concat: use option keyword.

2021-07-28 Thread Nicolas George
subfile,,start,X,end,Y,,: is ugly and will be gone. Signed-off-by: Nicolas George --- tools/dvd2concat | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/tools/dvd2concat b/tools/dvd2concat index 0280838a6b..ef04a87d05 100755 --- a/tools/dvd2concat +++ b/tools/dvd2concat

[FFmpeg-devel] [PATCH 3/5] tools/dvd2concat: document that -protocol_whitelist is needed.

2021-07-28 Thread Nicolas George
Signed-off-by: Nicolas George --- tools/dvd2concat | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/tools/dvd2concat b/tools/dvd2concat index 8effee86b9..0280838a6b 100755 --- a/tools/dvd2concat +++ b/tools/dvd2concat @@ -37,7 +37,8 @@ normally contains a directory named B

[FFmpeg-devel] [PATCH 2/5] lavf/concatdec: support per-file options.

2021-07-28 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/demuxers.texi | 4 libavformat/concatdec.c | 37 - 2 files changed, 40 insertions(+), 1 deletion(-) I intend to refactor the parser some time later. diff --git a/doc/demuxers.texi b/doc/demuxers.texi index

[FFmpeg-devel] [PATCH 1/5] libavformat/concatdec: remove support for unsafe=-1.

2021-07-28 Thread Nicolas George
It only makes sense as the default value, but it is not the default since 689211d5727231c3fe92762d224dbadebdbf4e30. Signed-off-by: Nicolas George --- doc/demuxers.texi | 9 +++-- libavformat/concatdec.c | 6 ++ 2 files changed, 5 insertions(+), 10 deletions(-) diff --git a/doc

Re: [FFmpeg-devel] [PATCH] lavfi/formats: describe conversion in negotiation structure.

2021-07-28 Thread Nicolas George
Nicolas George (12021-07-24): > Signed-off-by: Nicolas George > --- > libavfilter/avfiltergraph.c | 45 ++--- > libavfilter/formats.c | 4 > libavfilter/formats.h | 2 ++ > 3 files changed, 18 insertions(+), 33 deletions(-)

Re: [FFmpeg-devel] [PATCH 1/2] lavu/internal: add FF_FIELD_AT().

2021-07-28 Thread Nicolas George
Nicolas George (12021-07-24): > Signed-off-by: Nicolas George > --- > libavutil/internal.h | 5 + > 1 file changed, 5 insertions(+) Will push soon unless somebody wants to comment. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 09/10] lavf/file: handle standard file:// URLs.

2021-07-28 Thread Nicolas George
the question of relative resolution comes to mind, there is some code > in libavformat/url.c which also handles file path specially, that should > also be updated, right? Good catch. I added this patch in the series. It passes FATE. I will re-send the full series after giving more time fo

Re: [FFmpeg-devel] [PATCH 01/10] lavu/internal: add hex to int functions.

2021-07-28 Thread Nicolas George
ernal.h. I do not think these simple functions are worth it. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] avfilter/avf_concat: fix EOF timestamp

2021-07-27 Thread Nicolas George
s; > + > +eof_pts = cat->delta_ts; You could merge these two lines. > +eof_pts += av_rescale_q(pts, inlink->time_base, > ctx->outputs[i]->time_base); > +ff_outlink_set_status(ctx->outputs[i], status, eof_pts); >

Re: [FFmpeg-devel] [PATCH] avformat/concat: check the terminating character returned by av_get_token()

2021-07-27 Thread Nicolas George
James Almer (12021-07-27): > Don't attempt to increase the cursor pointer if it was \0. > Fixes invalid reads. > > Signed-off-by: James Almer > --- > libavformat/concat.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) LGTM, but I do not maintain this file. Re

[FFmpeg-devel] [PATCH 10/10] doc: document fs: and file: changes.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- doc/protocols.texi | 40 +++- 1 file changed, 31 insertions(+), 9 deletions(-) diff --git a/doc/protocols.texi b/doc/protocols.texi index 726e5f1c44..d341d93914 100644 --- a/doc/protocols.texi +++ b/doc/protocols.texi

[FFmpeg-devel] [PATCH 09/10] lavf/file: handle standard file:// URLs.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/file.c | 54 +- 1 file changed, 53 insertions(+), 1 deletion(-) diff --git a/libavformat/file.c b/libavformat/file.c index 2fb93c23fd..82d9e7bab4 100644 --- a/libavformat/file.c +++ b/libavformat/file.c

[FFmpeg-devel] [PATCH 08/10] lavf/avio: use fs: by default instead of file:.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/avio.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 13bba52e73..ebfecac893 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -260,7 +260,7 @@ static const struct

[FFmpeg-devel] [PATCH 07/10] lavf/hls: treat fs: the same way as file:.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/hls.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3c1b80f60c..e1928b6db3 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -646,7 +646,7 @@ static int open_url

[FFmpeg-devel] [PATCH 06/10] fftools/ffmpeg_opt: treat fs: the same way as file:.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- fftools/ffmpeg_opt.c | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/fftools/ffmpeg_opt.c b/fftools/ffmpeg_opt.c index 1b43bab9fc..23b4e981c7 100644 --- a/fftools/ffmpeg_opt.c +++ b/fftools/ffmpeg_opt.c @@ -1004,7 +1004,9 @@ static void

[FFmpeg-devel] [PATCH 05/10] lavf/avio: treat fs: the same way as file:.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/avio.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavformat/avio.c b/libavformat/avio.c index 4846bbd8c6..13bba52e73 100644 --- a/libavformat/avio.c +++ b/libavformat/avio.c @@ -217,7 +217,9 @@ int ffurl_connect

[FFmpeg-devel] [PATCH 04/10] lavf: add fs to default_whitelist when file present.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/concat.c | 2 +- libavformat/subfile.c | 2 +- libavformat/teeproto.c | 2 +- 3 files changed, 3 insertions(+), 3 deletions(-) diff --git a/libavformat/concat.c b/libavformat/concat.c index aec1f52d8e..66ee792b20 100644 --- a/libavformat/concat.c

[FFmpeg-devel] [PATCH 03/10] lavfi: add fs protocol as synonym for file.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/file.c | 47 - libavformat/protocols.c | 1 + 2 files changed, 43 insertions(+), 5 deletions(-) diff --git a/libavformat/file.c b/libavformat/file.c index 8303436be0..2fb93c23fd 100644 --- a/libavformat

[FFmpeg-devel] [PATCH 02/10] lavu/opt: use ff_hexpair2int().

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/opt.c | 18 -- 1 file changed, 4 insertions(+), 14 deletions(-) diff --git a/libavutil/opt.c b/libavutil/opt.c index 41284d4ecd..c7844d6241 100644 --- a/libavutil/opt.c +++ b/libavutil/opt.c @@ -167,16 +167,6 @@ static int write_number

[FFmpeg-devel] [PATCH 01/10] lavu/internal: add hex to int functions.

2021-07-27 Thread Nicolas George
Signed-off-by: Nicolas George --- libavutil/internal.h | 34 ++ 1 file changed, 34 insertions(+) diff --git a/libavutil/internal.h b/libavutil/internal.h index a33e8700c3..ba221438ed 100644 --- a/libavutil/internal.h +++ b/libavutil/internal.h @@ -291,4 +291,38

[FFmpeg-devel] [PATCH] Support standard file:// URLs

2021-07-27 Thread Nicolas George
/hls: treat fs: the same way as file:. [PATCH 08/10] lavf/avio: use fs: by default instead of file:. [PATCH 09/10] lavf/file: handle standard file:// URLs. [PATCH 10/10] doc: document fs: and file: changes. Regards, -- Nicolas George ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/concat: finalize the AVBprint buffer immediately

2021-07-26 Thread Nicolas George
on states: * The string buffer grows as necessary and is always 0-terminated. And I checked: there is no obvious bug in the avio_read_to_bprint() code path, it ends with av_bprint_grow() adding the final 0. Regards, -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH] avfilter/avf_concat: fix EOF timestamp

2021-07-26 Thread Nicolas George
pts += cat->delta_ts; would be much nicer. > } > if (!cat->nb_in_active) { > ret = flush_segment(ctx); Regards, -- Nicolas George signature.asc Description: PGP signature _

<    4   5   6   7   8   9   10   11   12   13   >