[FFmpeg-devel] [PATCH] avfilter/vf_libvmaf: fix string comparison bug

2023-12-04 Thread Nil Fons Miret via ffmpeg-devel
The libvmaf filter was doing substring checks in place of string equality comparisons. This led to a bug when the user specified the pooling method "harmonic_mean", since "mean" was checked first and the substring comparison returned true. This patch changes all substring comparisons for string equ

[FFmpeg-devel] [PATCH] doc/filters: expand documentation on libvmaf filter

2023-12-08 Thread Nil Fons Miret via ffmpeg-devel
Attached. 0001-doc-filters-expand-documentation-on-libvmaf-filter.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-de

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-03 Thread Nil Fons Miret via ffmpeg-devel
Hi, any feedback on this? Thank you On Thu, Feb 20, 2025 at 7:31 PM Nil Fons Miret wrote: > > The return value of ff_draw_init and ff_draw_init2 are not checked in > most usages. However, if they return an error, they don't get to the > point where they set the attributes of the FFDrawContext. Th

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-03 Thread Nil Fons Miret via ffmpeg-devel
0, Nil Fons Miret via ffmpeg-devel > wrote: > > The return value of ff_draw_init and ff_draw_init2 are not checked in > > most usages. However, if they return an error, they don't get to the > > point where they set the attributes of the FFDrawContext. These > > funct

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-11 Thread Nil Fons Miret via ffmpeg-devel
Thanks for the clarification, attaching an updated patch. The only change is the one comment on qrencode.c. Thank you, Nil On Fri, Mar 7, 2025 at 7:28 PM Michael Niedermayer wrote: > > On Tue, Mar 04, 2025 at 10:17:25AM -0800, Nil Fons Miret via ffmpeg-devel > wrote: > >

Re: [FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-03-04 Thread Nil Fons Miret via ffmpeg-devel
can easily become outdated. In any case, once I understand your request I'm happy to add any more documentation. Thank you, Nil On Mon, Mar 3, 2025 at 5:09 PM Michael Niedermayer wrote: > > On Mon, Mar 03, 2025 at 05:05:58PM -0800, Nil Fons Miret via ffmpeg-devel > wrote: > >

[FFmpeg-devel] [PATCH] libavfilter: guard against ff_draw_init/ff_draw_init2 failures

2025-02-20 Thread Nil Fons Miret via ffmpeg-devel
The return value of ff_draw_init and ff_draw_init2 are not checked in most usages. However, if they return an error, they don't get to the point where they set the attributes of the FFDrawContext. These functions are typically used in conjunction with ff_draw_color, which checks draw->desc->flags,

[FFmpeg-devel] [PATCH] avformat/demux: avoid unconditional ID3v2 tag consumption

2025-07-08 Thread Nil Fons Miret via ffmpeg-devel
--- Begin Message --- I have found a few instances of rawvideo files that coincidentally start with a header matching the ID3v2 header format, and ffmpeg consumes the header before demuxing, causing a decoding error. This happens even if "-f rawvideo" is specified. This patch limits the formats fo

Re: [FFmpeg-devel] [PATCH] avformat/demux: avoid unconditional ID3v2 tag consumption

2025-07-23 Thread Nil Fons Miret via ffmpeg-devel
Hi, Pinging this patch from a couple weeks ago. To be clear, I am not sure how people typically use ffmpeg's ID3v2 support, so please let me know if the patch is missing something and I'm happy to iterate on it, but it does seem to me that trying to parse it from rawvideo inputs is wrong. Thank y