[FFmpeg-devel] [PATCH 4/4] lavf/movdec: request probing for an ambiguous codec tag

2017-10-19 Thread Rodger Combs
--- libavformat/isom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index 77983c5eaa..8b3f88ce74 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -519,6 +519,8 @@ FF_ENABLE_DEPRECATION_WARNINGS codec_id=

[FFmpeg-devel] [PATCH 1/4] lavf: add MP1 muxer

2017-10-19 Thread Rodger Combs
--- libavformat/Makefile | 1 + libavformat/allformats.c | 1 + libavformat/rawenc.c | 13 + 3 files changed, 15 insertions(+) diff --git a/libavformat/Makefile b/libavformat/Makefile index d955a8b12a..2522a3e768 100644 --- a/libavformat/Makefile +++ b/libavformat/Makefile

[FFmpeg-devel] [PATCH 3/4] lavf/utils: add MP2 to the probing list

2017-10-19 Thread Rodger Combs
--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index a54687d239..416152eb39 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -329,6 +329,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH] tools/libav-merge-next-commit: run properly on a branch that isn't master

2017-09-26 Thread Rodger Combs
--- tools/libav-merge-next-commit | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tools/libav-merge-next-commit b/tools/libav-merge-next-commit index 9bd03fabf8..e2674008f6 100755 --- a/tools/libav-merge-next-commit +++ b/tools/libav-merge-next-commit @@ -7,7 +7,7 @@ fi [

[FFmpeg-devel] [PATCH 3/3] lavf/dashenc: unset codec_tag when it doesn't match the underlying muxer

2017-09-26 Thread Rodger Combs
--- libavformat/dashenc.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 7ed48905f5..3a4b6478d1 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -763,6 +763,11 @@ static int dash_init(AVFormatContext *s)

[FFmpeg-devel] [PATCH 2/3] lavf/dashenc: add format_options option, mirroring segment.c

2017-09-26 Thread Rodger Combs
--- libavformat/dashenc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 92d398ab50..7ed48905f5 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -100,6 +100,7 @@ typedef struct DASHContext { AVRational

[FFmpeg-devel] [PATCH 1/3] lavf/dashenc: fix merge error (write_header vs init_output)

2017-09-26 Thread Rodger Combs
--- libavformat/dashenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 240ff41380..92d398ab50 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -785,7 +785,7 @@ static int dash_init(AVFormatContext *s)

Re: [FFmpeg-devel] [PATCH] lavu/file: fix build on Android NDK with unified headers

2017-09-26 Thread Rodger Combs
re. > On Sep 26, 2017, at 06:27, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-09-26 3:52 GMT+02:00 Rodger Combs <rodger.co...@gmail.com>: > >> +# if defined(__USE_FILE_OFFSET64) && __ANDROID_API__ < 21 && >> !defined(__LP64__) >>

[FFmpeg-devel] [PATCH] lavf/movdec: flag chapter streams as such, even when not reading them

2017-09-25 Thread Rodger Combs
This allows the use of the `ignore_chapters` option to avoid performing extra seeks at startup without producing "subtitle" chapter streams. --- libavformat/mov.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index

[FFmpeg-devel] [PATCH] lavf/dashenc: add format_options option, mirroring segment.c

2017-09-25 Thread Rodger Combs
--- libavformat/dashenc.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 6471649eb7..5e5bea54c4 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -90,6 +90,7 @@ typedef struct DASHContext { AVRational

[FFmpeg-devel] [PATCH] lavu/file: fix build on Android NDK with unified headers

2017-09-25 Thread Rodger Combs
--- libavdevice/fbdev_enc.c | 1 + libavformat/os_support.h | 6 ++ libavutil/file.c | 1 + 3 files changed, 8 insertions(+) diff --git a/libavdevice/fbdev_enc.c b/libavdevice/fbdev_enc.c index b4e5f84975..a9be608383 100644 --- a/libavdevice/fbdev_enc.c +++ b/libavdevice/fbdev_enc.c

Re: [FFmpeg-devel] [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-30 Thread Rodger Combs
o check this condition :P */ > +if (*ptr != '0') { > + // Unknown format add log here > +goto finish; > +} > +} > format_len = end - start - marker_len - 1 + strlen(PRId64); > *o_format = av_mallocz(format_le

Re: [FFmpeg-devel] [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-28 Thread Rodger Combs
ng "something like > `"%0*"PRId64`"? > > Dnia 28 sierpnia 2017 03:30 Rodger Combs <rodger.co...@gmail.com> napisał(a): > > If you know of such a vulnerability, report it to > <mailto:ffmpeg-secur...@ffmpeg.org>ffmpeg-secur...@ffmpeg.org > &

Re: [FFmpeg-devel] Odp: Re: [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-27 Thread Rodger Combs
about safety but parser for mp4 atoms missing checking > and there is quite easy to make segfault of the libavformat when try to > prepared mp4 file. > > I understand that you want to have maximum safety with new code but I hope > you know that ffmpeg at all is not safety. >

Re: [FFmpeg-devel] [PATCH v15] avformat/dashdec: add dash demuxer base version

2017-08-27 Thread Rodger Combs
d: > 1. play youtube link: ffmpeg -i $(youtube-dl -J > "https://www.youtube.com/watch?v=XmL19DOP_Ls; | jq -r > ".requested_formats[0].manifest_url") > 2. code refine for timeline living stream > > Reviewed-by: Clément Bœsch <u...@pkh.me> > Reviewe

[FFmpeg-devel] [PATCH] lavf/mov: initial support for reading HEIF images

2017-08-19 Thread Rodger Combs
There's a decent chance this doesn't work on [pretty much anything other than the samples I tested it with], but I haven't found very many samples, and don't want to implement the rest of the features blind with nothing but a spec, and most of it's pretty over-the-top anyway. For some reason my

Re: [FFmpeg-devel] [PATCH 3/3] lavf/tls: verify TLS connections by default whenever possible

2017-08-18 Thread Rodger Combs
> On Aug 16, 2017, at 06:29, wm4 <nfx...@googlemail.com> wrote: > > On Wed, 16 Aug 2017 02:19:18 -0500 > Rodger Combs <rodger.co...@gmail.com <mailto:rodger.co...@gmail.com>> wrote: > >> This makes a reasonable effort to set the default configuration t

[FFmpeg-devel] [PATCH 3/3] lavf/tls: verify TLS connections by default whenever possible

2017-08-16 Thread Rodger Combs
This makes a reasonable effort to set the default configuration to behave securely, while maintaining the ability for consumers to produce builds using the old behavior without making changes to their runtime code. On Secure Transport and Secure Channel, we use a system-provided trust store, so

[FFmpeg-devel] [PATCH 1/3] lavf/tls_openssl: add support for verifying the server hostname on >=1.1.0

2017-08-16 Thread Rodger Combs
--- libavformat/tls_openssl.c | 14 +++--- 1 file changed, 11 insertions(+), 3 deletions(-) diff --git a/libavformat/tls_openssl.c b/libavformat/tls_openssl.c index 38af8a21c0..50361d30e2 100644 --- a/libavformat/tls_openssl.c +++ b/libavformat/tls_openssl.c @@ -256,8 +256,6 @@ static

[FFmpeg-devel] [PATCH 2/3] lavf/tls: use AV_OPT_TYPE_BOOL

2017-08-16 Thread Rodger Combs
--- libavformat/tls.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/tls.h b/libavformat/tls.h index 0326ef7924..53d0634f49 100644 --- a/libavformat/tls.h +++ b/libavformat/tls.h @@ -47,10 +47,10 @@ typedef struct TLSShared { #define

[FFmpeg-devel] [PATCH] lavf/movdec: flag chapter streams as such, even when not reading them

2017-08-11 Thread Rodger Combs
This allows the use of the `ignore_chapters` option to avoid performing extra seeks at startup without producing "subtitle" chapter streams. --- libavformat/mov.c | 16 1 file changed, 12 insertions(+), 4 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-04 Thread Rodger Combs
+sc->ctts_data = av_fast_realloc(sc->ctts_data, >ctts_allocated_size, request_size); ^ this line is incorrect; setting realloc's first arg to its return value leaks the existing allocation in the OOM case. Since you're doing your own calculation for the desired new size here, you

[FFmpeg-devel] [PATCH 7/7] lavf/flacenc: generate timestamps internally

2017-08-02 Thread Rodger Combs
--- libavformat/flacenc.c| 87 ++-- tests/ref/acodec/flac| 4 +- tests/ref/acodec/flac-exact-rice | 4 +- tests/ref/seek/acodec-flac | 36 - 4 files changed, 106 insertions(+), 25 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-08-02 Thread Rodger Combs
--- libavformat/flacenc.c | 285 +++--- 1 file changed, 250 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b894f9e..9768b6a 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-08-02 Thread Rodger Combs
--- libavformat/flacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 9768b6a..1906aee 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -322,7 +322,7 @@ static int flac_write_trailer(struct

[FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-08-02 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 94472ce..23ef2e7 100644 ---

[FFmpeg-devel] [PATCH 3/7] lavf/segment: copy stream dispositions in output

2017-08-02 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 590f62b..ef0a915 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -182,6 +182,7 @@ static int segment_mux_init(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-08-02 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 40 +--- 2 files changed, 33 insertions(+), 11 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 23ef2e7..93147e1 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1576,6

[FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-08-02 Thread Rodger Combs
Software + * Foundation, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/** + * @file + * Cue sheet demuxer + * @author Rodger Combs <rodger.co...@gmail.com> + */ + +#include "avformat.h" +#include "internal.h" +#include "subtitles.h" +#

Re: [FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-08-02 Thread Rodger Combs
> On Aug 1, 2017, at 02:58, Nicolas George <geo...@nsup.org> wrote: > > Le quartidi 14 thermidor, an CCXXV, Rodger Combs a écrit : >> --- >> Changelog| 2 + >> doc/demuxers.texi| 8 ++ >> libavformat/Makefile |

Re: [FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-08-01 Thread Rodger Combs
> On Aug 1, 2017, at 18:25, James Almer <jamr...@gmail.com> wrote: > > On 8/1/2017 3:33 AM, Rodger Combs wrote: >> --- >> libavformat/flacenc.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavformat/flacenc.c b/li

Re: [FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-08-01 Thread Rodger Combs
Variables may be declared at the top of a scope block in ffmpeg. > On Aug 1, 2017, at 01:50, Steven Liu <lingjiujia...@gmail.com> wrote: > > 2017-08-01 14:33 GMT+08:00 Rodger Combs <rodger.co...@gmail.com > <mailto:rodger.co...@gmail.com>>: >&g

Re: [FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-08-01 Thread Rodger Combs
This was pretty confusing whether it uses strlcpy or strncpy, so I'm switching it to AVBPrintf. > On Aug 1, 2017, at 01:54, Steven Liu <lingjiujia...@gmail.com> wrote: > > 2017-08-01 14:33 GMT+08:00 Rodger Combs <rodger.co...@gmail.com > <mailto:rodger.co...@gm

[FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-08-01 Thread Rodger Combs
Floor, Boston, MA 02110-1301 USA + */ + +/** + * @file + * Cue sheet demuxer + * @author Rodger Combs <rodger.co...@gmail.com> + */ + +#include "avformat.h" +#include "internal.h" +#include "subtitles.h" +#include "url.h" +#include "libavutil/intread

[FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-08-01 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 94472ce..23ef2e7 100644 ---

[FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-08-01 Thread Rodger Combs
--- libavformat/flacenc.c | 285 +++--- 1 file changed, 250 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b894f9e..9768b6a 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 3/7] lavf/segment: copy stream dispositions in output

2017-08-01 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 590f62b..ef0a915 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -182,6 +182,7 @@ static int segment_mux_init(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-08-01 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 24 2 files changed, 28 insertions(+) diff --git a/doc/muxers.texi b/doc/muxers.texi index 23ef2e7..93147e1 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@ -1576,6 +1576,10 @@ argument must be a time

[FFmpeg-devel] [PATCH 7/7] lavf/flacenc: generate timestamps internally

2017-08-01 Thread Rodger Combs
--- libavformat/flacenc.c | 88 +-- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 1906aee..f569c14 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -30,6 +30,7 @@

[FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-08-01 Thread Rodger Combs
--- libavformat/flacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 9768b6a..1906aee 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -322,7 +322,7 @@ static int flac_write_trailer(struct

[FFmpeg-devel] [PATCH 1/7] lavf: add cue sheet demuxer

2017-05-07 Thread Rodger Combs
, Inc., 51 Franklin Street, Fifth Floor, Boston, MA 02110-1301 USA + */ + +/** + * @file + * Cue sheet demuxer + * @author Rodger Combs <rodger.co...@gmail.com> + */ + +#include "avformat.h" +#include "internal.h" +#include "subtitles.h" +#include "u

[FFmpeg-devel] [PATCH 7/7] lavf/flacenc: generate timestamps internally

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 88 +-- 1 file changed, 85 insertions(+), 3 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b8800cc..0e948ac 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -30,6 +30,7 @@

[FFmpeg-devel] [PATCH 6/7] lavf/flacenc: avoid buffer overread with unexpected extradata sizes

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index 9bb4947..b8800cc 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -315,7 +315,7 @@ static int flac_write_trailer(struct

[FFmpeg-devel] [PATCH 4/7] lavf/segment: write attached pictures to all segments by default

2017-05-07 Thread Rodger Combs
--- doc/muxers.texi | 4 libavformat/segment.c | 24 libavformat/version.h | 2 +- 3 files changed, 29 insertions(+), 1 deletion(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index b80bc68..3707d05 100644 --- a/doc/muxers.texi +++ b/doc/muxers.texi @@

[FFmpeg-devel] [PATCH 3/7] lavf/segment: copy stream dispositions in output

2017-05-07 Thread Rodger Combs
--- libavformat/segment.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/segment.c b/libavformat/segment.c index 8575d32..9c6ce73 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -184,6 +184,7 @@ static int segment_mux_init(AVFormatContext *s) }

[FFmpeg-devel] [PATCH 5/7] lavf/flacenc: support writing attached pictures

2017-05-07 Thread Rodger Combs
--- libavformat/flacenc.c | 271 +++--- 1 file changed, 236 insertions(+), 35 deletions(-) diff --git a/libavformat/flacenc.c b/libavformat/flacenc.c index b894f9e..9bb4947 100644 --- a/libavformat/flacenc.c +++ b/libavformat/flacenc.c @@ -21,10 +21,13

[FFmpeg-devel] [PATCH 2/7] lavf/segment: add option to segment by chapter

2017-05-07 Thread Rodger Combs
--- doc/muxers.texi | 6 + libavformat/segment.c | 65 +++ libavformat/version.h | 2 +- 3 files changed, 67 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index 0866142..b80bc68 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-02 Thread Rodger Combs
> On May 2, 2017, at 03:59, Matthias Hunstock <a...@fem.tu-ilmenau.de> wrote: > > Am 02.05.2017 um 03:42 schrieb Rodger Combs: >> +max_empty_analyze_duration = max_analyze_duration; >> if (!max_analyze_duration) { >> +

[FFmpeg-devel] [PATCH 2/2] lavf/utils: bail early if we don't see any packets in an MPEGTS stream

2017-05-01 Thread Rodger Combs
--- libavformat/utils.c | 18 +- 1 file changed, 17 insertions(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index ba82a766dc..4028d8dbcb 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -3505,6 +3505,8 @@ int

[FFmpeg-devel] [PATCH 1/2] ffmpeg: treat audio streams with no parsed packets like unknown streams

2017-05-01 Thread Rodger Combs
--- ffmpeg_opt.c | 8 1 file changed, 8 insertions(+) diff --git a/ffmpeg_opt.c b/ffmpeg_opt.c index d1fe8742ff..5ed29d717e 100644 --- a/ffmpeg_opt.c +++ b/ffmpeg_opt.c @@ -2255,6 +2255,14 @@ loop_end: if(o->data_disable && ist->st->codecpar->codec_type ==

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix CID 1405135

2017-04-26 Thread Rodger Combs
> On Apr 25, 2017, at 18:47, Steven Liu wrote: > > CID: 1405135 I have no idea what this message is supposed to mean. > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 8 > 1 file changed, 4 insertions(+), 4 deletions(-) > > diff

[FFmpeg-devel] [PATCH 5/5] lavu/bprint: add URL escaping

2017-04-12 Thread Rodger Combs
--- libavutil/avstring.h | 1 + libavutil/bprint.c | 11 +++ libavutil/version.h | 2 +- 3 files changed, 13 insertions(+), 1 deletion(-) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index 68b753a569..cce210 100644 --- a/libavutil/avstring.h +++

[FFmpeg-devel] [PATCH 3/5] ffprobe: switch xml_escape_str to use av_bprint_escape

2017-04-12 Thread Rodger Combs
This now escapes single-quotes, so the test reference is updated. --- ffprobe.c | 25 ++--- tests/ref/fate/ffprobe_xml | 2 +- 2 files changed, 7 insertions(+), 20 deletions(-) diff --git a/ffprobe.c b/ffprobe.c index 0a9ba14d8d..5c5bdaf3b1 100644 ---

[FFmpeg-devel] [PATCH 4/5] lavc/webvttenc: XML-escape text output

2017-04-12 Thread Rodger Combs
The test output was previously incorrect, so the reference is updated. --- libavcodec/webvttenc.c | 7 ++- tests/ref/fate/sub-webvttenc | 20 ++-- 2 files changed, 16 insertions(+), 11 deletions(-) diff --git a/libavcodec/webvttenc.c b/libavcodec/webvttenc.c index

[FFmpeg-devel] [PATCH 2/5] lavu/bprint: add XML escaping

2017-04-12 Thread Rodger Combs
--- libavutil/avstring.h | 28 libavutil/bprint.c | 43 +++ 2 files changed, 71 insertions(+) diff --git a/libavutil/avstring.h b/libavutil/avstring.h index 04d2695640..68b753a569 100644 --- a/libavutil/avstring.h +++

[FFmpeg-devel] [PATCH 1/5] lavu/bprint: reorder cases to match enum order

2017-04-12 Thread Rodger Combs
--- libavutil/bprint.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavutil/bprint.c b/libavutil/bprint.c index 2f059c5ba6..652775bef9 100644 --- a/libavutil/bprint.c +++ b/libavutil/bprint.c @@ -271,19 +271,8 @@ void av_bprint_escape(AVBPrint

[FFmpeg-devel] [PATCH 1/5] lavu/bprint: reorder cases to match enum order

2017-04-12 Thread Rodger Combs
--- libavutil/bprint.c | 25 + 1 file changed, 13 insertions(+), 12 deletions(-) diff --git a/libavutil/bprint.c b/libavutil/bprint.c index 2f059c5ba6..652775bef9 100644 --- a/libavutil/bprint.c +++ b/libavutil/bprint.c @@ -271,19 +271,8 @@ void av_bprint_escape(AVBPrint

Re: [FFmpeg-devel] [PATCH v14] avformat/dashdec: add dash demuxer base version

2017-04-12 Thread Rodger Combs
ead by av_strreplace > > v13 fixed: > 1. fix bug: cannot play: > http://dash.edgesuite.net/akamai/bbb_30fps/bbb_30fps.mpd > > v14 fixed: > 1. fix bug: TLS connection was non-properly terminated > 2. fix bug: No trailing CRLF found in HTTP header > > Reviewed

Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-27 Thread Rodger Combs
> On Mar 27, 2017, at 01:52, Steven Liu <lingjiujia...@gmail.com> wrote: > > 2017-03-27 8:39 GMT+08:00 Rodger Combs <rodger.co...@gmail.com > <mailto:rodger.co...@gmail.com>>: > >> >>> On Mar 26, 2017, at 19:10, Steven Liu <l...@chi

Re: [FFmpeg-devel] [PATCH v9] avformat/dashdec: add dash demuxer base version

2017-03-26 Thread Rodger Combs
2. from free to av_free > > v7 fixed: > 1. remove the -lxml2 from configure when require_pkg_config > > v8 fixed: > 1. fix replace filename template by av_asprintf secure problem > > v9 modified: > 1. make manifest parser clearly > > Reviewed-by: Clément Bœsch

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-22 Thread Rodger Combs
> On Mar 22, 2017, at 09:31, Steven Liu <lingjiujia...@gmail.com> wrote: > > 2017-03-22 22:01 GMT+08:00 Rodger Combs <rodger.co...@gmail.com > <mailto:rodger.co...@gmail.com>>: > >> >>> On Mar 21, 2017, at 08:16, Steven Liu <l...@chi

Re: [FFmpeg-devel] [PATCH v6] avformat/dashdec: add dash demuxer base version

2017-03-22 Thread Rodger Combs
gt; 2. from free to av_free > > Reviewed-by: Clément Bœsch <u...@pkh.me> > Reviewed-by: Michael Niedermayer <mich...@niedermayer.cc> > Reviewed-by: Carl Eugen Hoyos <ceho...@ag.or.at> > Reviewed-by: Rodger Combs <rodger.co...@gmail.com> > Reviewed-by: Moritz Ba

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: add dash demuxer base version

2017-03-19 Thread Rodger Combs
A few initial comments inline: > On Mar 19, 2017, at 04:05, Steven Liu wrote: > > ffmpeg need a dash demuxer for demux the dash formats > base on > https://github.com/samsamsam-iptvplayer/exteplayer3/blob/master/tmp/ffmpeg/patches/3.2.2/01_add_dash_demux.patch > >

[FFmpeg-devel] [PATCH 1/3] lavf: identify MP1 and MP2 as distinct containers from MP3

2017-03-18 Thread Rodger Combs
This allows us to report the correct codec ID here --- libavformat/allformats.c | 3 ++- libavformat/mp3dec.c | 66 +++- libavformat/rawenc.c | 13 ++ libavformat/utils.c | 4 +-- libavformat/version.h| 4 +-- 5 files

[FFmpeg-devel] [PATCH 2/3] lavf/utils: add MP2 to the probing list

2017-03-18 Thread Rodger Combs
--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 84acb9c795..8bf34e8f6f 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -329,6 +329,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH 3/3] lavf/movdec: request probing for an ambiguous codec tag

2017-03-18 Thread Rodger Combs
--- libavformat/isom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index 7da2700842..9589f42741 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -514,6 +514,8 @@ FF_ENABLE_DEPRECATION_WARNINGS codec_id=

[FFmpeg-devel] [PATCH] lavf/movdec: downgrade "shifted frame pts" log line to trace

2017-03-08 Thread Rodger Combs
This gets pretty chatty in files that use edit lists, so it fits a bit better at the trace level with similar messages. --- libavformat/mov.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d5c3949050..06f84f9f8e 100644 ---

[FFmpeg-devel] [PATCH] lavf/segment: fix crash when failing to open segment list

2017-01-20 Thread Rodger Combs
This happens because segment_end() returns an error, so seg_write_packet never proceeds to segment_start(), and seg->avf->pb is never re-set, so we crash with a null pb when av_write_trailer flushes the packet queue. This doesn't seem to be clearly recoverable, so I'm just failing more

Re: [FFmpeg-devel] [PATCH 1/9] avutil: add FF_RETURN_ON_OVERFLOW

2017-01-07 Thread Rodger Combs
On 1/6/2017 4:46 PM, Andreas Cadhalpun wrote: >>>> Suggested-by: Rodger Combs <rodger.co...@gmail.com> >>>> Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> >>>> --- >>>> >>>> Changed the name as suggested by wm4 and the

[FFmpeg-devel] [PATCH] lavf: identify MP1 and MP2 as distinct containers from MP3

2016-12-22 Thread Rodger Combs
This allows us to report the correct codec ID here --- libavformat/allformats.c | 3 ++- libavformat/mp3dec.c | 66 +++- libavformat/rawenc.c | 13 ++ libavformat/utils.c | 4 +-- libavformat/version.h| 2 +- 5 files changed,

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Rodger Combs
> On Dec 21, 2016, at 13:50, compn <te...@mi.rr.com> wrote: > > On Wed, 21 Dec 2016 12:51:18 -0600 > Rodger Combs <rodger.co...@gmail.com> wrote: > >> >>> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos <ceffm...@gmail.com> >>> wrote: &

Re: [FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-21 Thread Rodger Combs
> On Dec 21, 2016, at 02:27, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2016-12-21 5:48 GMT+01:00 Rodger Combs <rodger.co...@gmail.com>: >> This allows us to report the correct codec ID here > > Just curious: What does this fix? Reporting in ffprobe, or w

[FFmpeg-devel] [PATCH 3/3] lavf/movdec: request probing for an ambiguous codec tag

2016-12-20 Thread Rodger Combs
--- libavformat/isom.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/isom.c b/libavformat/isom.c index ae10cb7d3f..37bfd5af30 100644 --- a/libavformat/isom.c +++ b/libavformat/isom.c @@ -509,6 +509,8 @@ FF_ENABLE_DEPRECATION_WARNINGS codec_id=

[FFmpeg-devel] [PATCH 2/3] lavf/utils: add MP2 to the probing list

2016-12-20 Thread Rodger Combs
--- libavformat/utils.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/utils.c b/libavformat/utils.c index 50a30f6942..738211dd54 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -329,6 +329,7 @@ static int set_codec_from_probe_data(AVFormatContext *s, AVStream *st,

[FFmpeg-devel] [PATCH 1/3] lavf: identify MP2 as a distinct container from MP3

2016-12-20 Thread Rodger Combs
This allows us to report the correct codec ID here --- libavformat/allformats.c | 2 +- libavformat/mp3dec.c | 62 +++- libavformat/version.h| 2 +- 3 files changed, 42 insertions(+), 24 deletions(-) diff --git a/libavformat/allformats.c

Re: [FFmpeg-devel] [PATCH 2/7] 4xm: prevent overflow during block alignment calculation

2016-12-15 Thread Rodger Combs
> On Dec 15, 2016, at 20:32, Andreas Cadhalpun > wrote: > > Signed-off-by: Andreas Cadhalpun > --- > libavformat/4xm.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/4xm.c b/libavformat/4xm.c > index

Re: [FFmpeg-devel] [PATCH 1/3] 4xm: prevent overflow during bit rate calculation

2016-12-15 Thread Rodger Combs
> On Dec 15, 2016, at 19:21, Andreas Cadhalpun > wrote: > > On 15.12.2016 14:02, Ronald S. Bultje wrote: >> On Wed, Dec 14, 2016 at 7:11 PM, Andreas Cadhalpun < >> andreas.cadhal...@googlemail.com> wrote: >>> On 14.12.2016 02:46, Ronald S. Bultje wrote:

Re: [FFmpeg-devel] [PATCH] lavc: report frame field order in avctx

2016-11-18 Thread Rodger Combs
> On Nov 17, 2016, at 18:47, Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Thu, Nov 17, 2016 at 04:48:07AM -0600, Rodger Combs wrote: >> >>> On Nov 15, 2016, at 03:43, Michael Niedermayer <mich...@niedermayer.cc> >>> wrote: >>>

Re: [FFmpeg-devel] [PATCH] lavc: report frame field order in avctx

2016-11-17 Thread Rodger Combs
> On Nov 15, 2016, at 03:43, Michael Niedermayer <mich...@niedermayer.cc> wrote: > > On Mon, Nov 14, 2016 at 05:19:25PM -0600, Rodger Combs wrote: >> --- >> libavcodec/utils.c | 13 + >> tests/api/api-codec-param-test.c |

[FFmpeg-devel] [PATCH] lavc: report frame field order in avctx

2016-11-14 Thread Rodger Combs
--- libavcodec/utils.c | 13 + tests/api/api-codec-param-test.c | 3 +++ tests/fate/matroska.mak | 2 +- tests/ref/fate/api-mjpeg-codec-param | 2 +- tests/ref/fate/api-png-codec-param | 2 +- tests/ref/fate/mov-zombie| 2 +- 6

[FFmpeg-devel] [PATCH] lavf/mux: don't warn about missing timestamps on attached pictures

2016-11-12 Thread Rodger Combs
--- libavformat/mux.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/mux.c b/libavformat/mux.c index 77823a4..963d006 100644 --- a/libavformat/mux.c +++ b/libavformat/mux.c @@ -575,6 +575,7 @@ static int compute_muxer_pkt_fields(AVFormatContext *s, AVStream *st, AVPacket *

[FFmpeg-devel] [PATCH] tests/fate/avformat: add segment.c tests

2016-10-29 Thread Rodger Combs
--- tests/fate/avformat.mak | 56 +++ tests/ref/fate/segment-adts-to-mkv-header-000 | 21 tests/ref/fate/segment-adts-to-mkv-header-001 | 22 + tests/ref/fate/segment-adts-to-mkv-header-002 | 9 ++ tests/ref/fate/segment-adts-to-mkv-header-all | 40

Re: [FFmpeg-devel] [PATCH 1/4] lavf/segment: fix autobsf

2016-10-27 Thread Rodger Combs
> On Oct 27, 2016, at 02:07, Steven Liu <lingjiujia...@gmail.com> wrote: > > 2016-10-27 15:01 GMT+08:00 Steven Liu <lingjiujia...@gmail.com > <mailto:lingjiujia...@gmail.com>>: > >> >> >> 2016-10-27 14:52 GMT+08:00 Rodger Combs <rodger.

Re: [FFmpeg-devel] [PATCH 1/4] lavf/segment: fix autobsf

2016-10-27 Thread Rodger Combs
> On Oct 27, 2016, at 01:41, Steven Liu <lingjiujia...@gmail.com> wrote: > > 2016-10-27 14:16 GMT+08:00 Rodger Combs <rodger.co...@gmail.com>: > >> --- >> libavformat/segment.c | 40 +++- >> 1 file changed, 39 inse

[FFmpeg-devel] [PATCH 4/4] tests/fate/avformat: add segment.c tests

2016-10-27 Thread Rodger Combs
--- tests/fate/avformat.mak | 56 +++ tests/ref/fate/segment-adts-to-mkv-header-000 | 20 tests/ref/fate/segment-adts-to-mkv-header-001 | 21 + tests/ref/fate/segment-adts-to-mkv-header-002 | 8 ++ tests/ref/fate/segment-adts-to-mkv-header-all | 39

[FFmpeg-devel] [PATCH 2/4] lavf/matroskaenc: fix uninitialized read

2016-10-27 Thread Rodger Combs
--- libavformat/matroskaenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index d91055f..c94a490 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -1547,7 +1547,7 @@ static int

[FFmpeg-devel] [PATCH 1/4] lavf/segment: fix autobsf

2016-10-27 Thread Rodger Combs
--- libavformat/segment.c | 40 +++- 1 file changed, 39 insertions(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 868f0a8..9b3dc17 100644 --- a/libavformat/segment.c +++ b/libavformat/segment.c @@ -798,9 +798,26 @@ static

[FFmpeg-devel] [PATCH 3/4] lavf/matroskaenc: don't try to modify the header when live-streaming

2016-10-27 Thread Rodger Combs
--- libavformat/matroskaenc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavformat/matroskaenc.c b/libavformat/matroskaenc.c index c94a490..4f5948d 100644 --- a/libavformat/matroskaenc.c +++ b/libavformat/matroskaenc.c @@ -1783,7 +1783,7 @@ static int

[FFmpeg-devel] [PATCH] lavfi/vf_overlay: support NV12 and NV21

2016-10-25 Thread Rodger Combs
--- libavfilter/vf_overlay.c| 22 +- tests/fate/filter-video.mak | 10 ++ tests/filtergraphs/overlay_nv12 | 5 + tests/filtergraphs/overlay_nv21 | 5 + 4 files changed, 37 insertions(+), 5 deletions(-) create mode 100644

[FFmpeg-devel] [PATCH] lavfi/vf_overlay: support NV12 and NV21

2016-10-25 Thread Rodger Combs
--- libavfilter/vf_overlay.c| 22 +- tests/fate/filter-video.mak | 10 ++ tests/filtergraphs/overlay_nv12 | 5 + tests/filtergraphs/overlay_nv21 | 5 + 4 files changed, 37 insertions(+), 5 deletions(-) create mode 100644

[FFmpeg-devel] [PATCH] lavf/segment: decide whether to rename based on list URI

2016-10-06 Thread Rodger Combs
This fixes the case of writing segments to local files, but the list over a network protocol. --- libavformat/segment.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/segment.c b/libavformat/segment.c index 33a5cf0..55dcaf0 100644 --- a/libavformat/segment.c +++

[FFmpeg-devel] [PATCH 2/2] lavf/utils: avoid using programs for duration when there's only one

2016-10-05 Thread Rodger Combs
This allows us to be more selective about the streams we derive durations from (specifically, ignoring text streams with outlier end times) in the common case --- libavformat/utils.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/utils.c b/libavformat/utils.c

[FFmpeg-devel] [PATCH 1/2] lavf/utils: ignore outlier subtitle and data stream end times as well

2016-10-05 Thread Rodger Combs
--- libavformat/utils.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libavformat/utils.c b/libavformat/utils.c index 3acb260..d19cc5e 100644 --- a/libavformat/utils.c +++ b/libavformat/utils.c @@ -2524,7 +2524,7 @@ static int has_duration(AVFormatContext

[FFmpeg-devel] [PATCH] lavf/segment: provide a virtual AVIOContext representing all the segments

2016-10-04 Thread Rodger Combs
This allows the use of muxers like matroska, which attempt to seek even when an AVIOContext doesn't set `seekable`, without concern for a rouge seek leading the muxer to overwrite the wrong data in a later segment. --- doc/muxers.texi | 17 libavformat/segment.c | 276

[FFmpeg-devel] [PATCH 2/3] lavf/mov: improve `tref/chap` chapter handling

2016-10-04 Thread Rodger Combs
3 parts: - Supports multiple chapter streams - Exports regular text chapter streams as opaque data. This prevents consumers from showing chapters as if they were regular subtitle streams. - Exports video chapter streams as thumbnails, and provides the first one as an attached_pic. ---

[FFmpeg-devel] [PATCH 3/3] lavf/mov: reindent

2016-10-04 Thread Rodger Combs
Reviewed-By: Michael Niedermayer --- libavformat/mov.c | 156 +++--- 1 file changed, 78 insertions(+), 78 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index d0f1316..c9fef8a 100644 --- a/libavformat/mov.c

[FFmpeg-devel] [PATCH 1/3] lavf: add AV_DISPOSITION_TIMED_THUMBNAILS

2016-10-04 Thread Rodger Combs
Reviewed-By: Michael Niedermayer --- ffprobe.c | 1 + libavformat/avformat.h | 12 +--- tests/ref/fate/concat-demuxer-extended-lavf-mxf | 2 +-

[FFmpeg-devel] [PATCH 1/4] lavc/parser: export field order if not already set

2016-10-03 Thread Rodger Combs
Some codecs set this in the parser, but not the decoder --- libavcodec/parser.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/parser.c b/libavcodec/parser.c index 2c8fc69..30cfc55 100644 --- a/libavcodec/parser.c +++ b/libavcodec/parser.c @@ -182,6 +182,11 @@ int

[FFmpeg-devel] [PATCH 2/4] lavc/h264_parser: export field order in more cases

2016-10-03 Thread Rodger Combs
--- libavcodec/h264_parser.c | 16 +++- 1 file changed, 15 insertions(+), 1 deletion(-) diff --git a/libavcodec/h264_parser.c b/libavcodec/h264_parser.c index 3ed7d77..bca0071 100644 --- a/libavcodec/h264_parser.c +++ b/libavcodec/h264_parser.c @@ -61,6 +61,7 @@ typedef struct

[FFmpeg-devel] [PATCH 3/4] lavc/utils: avcodec_string: dump field order when known

2016-10-03 Thread Rodger Combs
--- libavcodec/utils.c | 15 +++ 1 file changed, 15 insertions(+) diff --git a/libavcodec/utils.c b/libavcodec/utils.c index 6f4df93..a0931c6 100644 --- a/libavcodec/utils.c +++ b/libavcodec/utils.c @@ -3228,6 +3228,21 @@ void avcodec_string(char *buf, int buf_size, AVCodecContext

<    1   2   3   4   5   6   7   8   >