Re: [FFmpeg-devel] Let us review and collebrate on vvc native decoder.

2023-01-14 Thread Ronald S. Bultje
Hi, On Sat, Jan 14, 2023 at 8:32 AM Nuo Mi wrote: > On Sat, Jan 14, 2023 at 9:13 PM Nuo Mi wrote: > > I am happy to send out the first draft of vvc decoder. > > It's not ready for upstream yet, but it's a good base ground for review > > and future improvement. > > > > It has the following

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-29 Thread Ronald S. Bultje
Hi, On Wed, Dec 28, 2022 at 11:14 AM Mark Gaiser wrote: > On Wed, Dec 28, 2022 at 3:27 PM Ronald S. Bultje > wrote: > > > Hi Mark, > > > > On Tue, Dec 27, 2022 at 5:47 PM Mark Gaiser wrote: > > > > > The tricky part here is for anyone using this sch

Re: [FFmpeg-devel] Would a crypto file be acceptable?

2022-12-28 Thread Ronald S. Bultje
Hi Mark, On Tue, Dec 27, 2022 at 5:47 PM Mark Gaiser wrote: > The tricky part here is for anyone using this scheme to play this file. > Right now i'm doing this with a command line like: > ffplay crypto://encrypted_file -decryption_key $AES_KEY -decryption_iv > $AES_IV > > For brevity's sake,

Re: [FFmpeg-devel] [PATCH] avcodec/x86/Makefile: Don't build empty files

2022-12-13 Thread Ronald S. Bultje
Hi, On Tue, Dec 13, 2022 at 2:12 PM Carl Eugen Hoyos wrote: > It does. > (I did not consider this an issue when I saw it.) > > I consider this unmaintainable, an argument that in the past was > used to object significantly more important patches (in cases > where maintenance was imo no

Re: [FFmpeg-devel] [PATCH 1/2] av1dec: fix comment typo

2022-12-13 Thread Ronald S. Bultje
Hi, On Mon, Nov 28, 2022 at 10:39 AM Tristan Matthews wrote: > --- > libavcodec/av1dec.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > index 0c24eac842..80da0943d4 100644 > --- a/libavcodec/av1dec.c > +++

Re: [FFmpeg-devel] [PATCH 2/2] av1dec: fix typo in logged error

2022-12-13 Thread Ronald S. Bultje
Hi, On Mon, Dec 12, 2022 at 7:54 PM Tristan Matthews wrote: > On Mon, Nov 28, 2022 at 10:39 AM Tristan Matthews > wrote: > > > > --- > > libavcodec/av1dec.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/libavcodec/av1dec.c b/libavcodec/av1dec.c > > index

Re: [FFmpeg-devel] [PATCH v14 9/9] avcodec/evc: Changes in Changelog and MAINTAINERS files

2022-12-13 Thread Ronald S. Bultje
Hi David, On Tue, Dec 13, 2022 at 7:22 AM Dawid Kozinski/Multimedia (PLT) /SRPOL/Staff Engineer/Samsung Electronics wrote: > Should I leave the following lines: > + libxevd.c Dawid Kozinski > + libxeve.c,Dawid Kozinski > + evc.c, evc.h

Re: [FFmpeg-devel] AVX512 NUCs for FATE and development

2022-12-08 Thread Ronald S. Bultje
Hi, On Sun, Dec 4, 2022 at 1:08 PM Kieran Kunhya wrote: > Hello, > > As discussed at the developer meeting it would be good to have an AVX-512 > (ICL) FATE machine and also a development machine. > What I didn't realise until a few weeks ago is that 11th Generation NUCs > have AVX512ICL

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check

2022-11-19 Thread Ronald S. Bultje
Hi, On Fri, Nov 18, 2022 at 8:37 AM Ronald S. Bultje wrote: > From: Hirokazu Honda > > The check of vpx_rac_is_end check(s) are added originally from > 1afd246960202917e244c844c534e9c1e3c323f5. It causes a regression > of some vp8 stream. b6b9ac5698c8f911841b469af771991

[FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check

2022-11-18 Thread Ronald S. Bultje
: b6b9ac5698c8f911841b469af77199153278c55c Co-authored-by: Ronald S. Bultje Signed-off-by: Hirokazu Honda Signed-off-by: Ronald S. Bultje --- libavcodec/vp8.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 67f36d8933..db2419deaf

[FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check

2022-11-18 Thread Ronald S. Bultje
: b6b9ac5698c8f911841b469af77199153278c55c Signed-off-by: Hirokazu Honda Signed-off-by: Ronald S. Bultje --- libavcodec/vp8.c | 14 +- 1 file changed, 9 insertions(+), 5 deletions(-) diff --git a/libavcodec/vp8.c b/libavcodec/vp8.c index 67f36d8933..db2419deaf 100644 --- a/libavcodec/vp8.c +++ b

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check

2022-11-16 Thread Ronald S. Bultje
Hi, On Wed, Nov 16, 2022 at 8:20 AM Ronald S. Bultje wrote: > On Wed, Nov 16, 2022 at 3:44 AM Hirokazu Honda wrote: > >> @@ -2471,7 +2472,7 @@ static av_always_inline int >> decode_mb_row_no_filter(AVCodecContext *avctx, void >> prefetch_motion(

Re: [FFmpeg-devel] [PATCH] avcodec/vp8: Fix wrong vpx_rac_is_end() check

2022-11-16 Thread Ronald S. Bultje
Hi, On Wed, Nov 16, 2022 at 3:44 AM Hirokazu Honda wrote: > The check of vpx_rac_is_end check(s) are added originally from > 1afd246960202917e244c844c534e9c1e3c323f5. It causes a regression > of some vp8 stream. b6b9ac5698c8f911841b469af77199153278c55c fixes > the regression by a sort of

Re: [FFmpeg-devel] [Question] Technical reason why FFmpeg sets a mstack-alignment value on compile time?

2022-11-13 Thread Ronald S. Bultje
Hi, On Sun, Nov 13, 2022 at 8:47 AM Nomis101 wrote: > Am 12.11.22 um 23:09 schrieb Ronald S. Bultje: > > Hi, > > > > On Sat, Nov 12, 2022 at 1:57 PM Nomis101 wrote: > > > >> Hi.If building FFmpeg, configure does set a value for mstack-alignment, > >>

Re: [FFmpeg-devel] [Question] Technical reason why FFmpeg sets a mstack-alignment value on compile time?

2022-11-12 Thread Ronald S. Bultje
Hi, On Sat, Nov 12, 2022 at 1:57 PM Nomis101 wrote: > Hi.If building FFmpeg, configure does set a value for mstack-alignment, > for example on macOS > -mstack-alignment=16. On HandBrake we found there is an issue with current > Clang in Xcode about > conflicting 'override-stack-alignment'

Re: [FFmpeg-devel] Rework color quantization in palette{gen,use}

2022-11-06 Thread Ronald S. Bultje
Hi, On Sat, Nov 5, 2022 at 2:54 PM Clément Bœsch wrote: > On Sat, Nov 05, 2022 at 04:44:39PM +0100, Paul B Mahol wrote: > [...] > > > Finally, I do believe a lot of other color filters could at least > benefit > > > from > > > fixing their gamma handling (I know I'm guilty of this in various

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: add an option to set max frame delay

2022-10-14 Thread Ronald S. Bultje
Hi, On Tue, Oct 11, 2022 at 11:34 AM James Almer wrote: > Signed-off-by: James Almer > --- > libavcodec/libdav1d.c | 11 ++- > 1 file changed, 10 insertions(+), 1 deletion(-) > LGTM, thanks. (And sorry for review delay, I was offline for a few days.) Ronald

Re: [FFmpeg-devel] [PATCH 8/9] checkasm/vp8dsp: Use declare_func_emms only when needed

2022-10-07 Thread Ronald S. Bultje
Hi, On Fri, Oct 7, 2022 at 9:25 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > There is no MMX code for loop filters since commit > 6a551f14050674fb685920eb1b0640810cacccf9, so use declare_func > instead of declare_func_emms() to also test that we are not > in MMX mode after

Re: [FFmpeg-devel] [PATCH] lavc/libvpx: increase thread limit to 64

2022-09-27 Thread Ronald S. Bultje
Hi, On Tue, Sep 27, 2022 at 9:52 PM OvchinnikovDmitrii < ovchinnikov.dmit...@gmail.com> wrote: > +/* Increase max threads for libvpx from 16 to 64 to benefit 4K/8K video > encoding. */ > The "increase" and "from 16 to" are not very helpful. Just documenting the code that is, not what it was

Re: [FFmpeg-devel] [PATCH 1/7] lavu/cpu: add av_cpu_job_count()

2022-09-22 Thread Ronald S. Bultje
Hi, On Thu, Sep 22, 2022 at 9:49 AM Anton Khirnov wrote: > It is very nonobvious to me that it makes sense to define a global job > count that is independent of the task at hand. > I agree with Anton here. This is very heuristical and dependent on the type of job. This therefore belongs as an

Re: [FFmpeg-devel] [PATCH] tests/checkasm: add a test for VorbisDSPContext

2022-09-19 Thread Ronald S. Bultje
Hi, On Mon, Sep 19, 2022 at 1:05 PM James Almer wrote: > --- a/tests/checkasm/checkasm.c > +++ b/tests/checkasm/checkasm.c > @@ -165,6 +165,9 @@ static const struct { > #if CONFIG_VIDEODSP > { "videodsp", checkasm_check_videodsp }, > #endif > +#if CONFIG_VIDEODSP > +

Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

2022-09-11 Thread Ronald S. Bultje
Hi, On Sun, Sep 11, 2022 at 10:41 AM Ronald S. Bultje wrote: > Hi, > > On Sun, Sep 11, 2022 at 12:38 AM Andreas Rheinhardt < > andreas.rheinha...@outlook.com> wrote: > >> Peter Ross: >> > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt w

Re: [FFmpeg-devel] [PATCH 02/18] avcodec/vp8: Disable lf_delta for VP7

2022-09-11 Thread Ronald S. Bultje
Hi, On Sun, Sep 11, 2022 at 12:38 AM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Peter Ross: > > On Sat, Sep 10, 2022 at 03:07:13AM +0200, Andreas Rheinhardt wrote: > >> It is a VP8-only feature. > >> > >> Signed-off-by: Andreas Rheinhardt > >> --- > >> libavcodec/vp8.c | 3

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/mpegutils: add motion_vec debug mode

2022-09-03 Thread Ronald S. Bultje
Hi Chema, On Fri, Sep 2, 2022 at 11:12 AM Chema Gonzalez wrote: > So is there a filter that already dumps this information? > Yes, it's called codecview. We can help understand how it works if you ask more specific questions, but something like "git grep EXPORT_DATA_MVS ../libavcodec/mpeg*.c"

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/mpegutils: add motion_vec debug mode

2022-09-01 Thread Ronald S. Bultje
Hi, On Wed, Aug 31, 2022 at 7:10 PM Chema Gonzalez wrote: > Add a new debug mode ("motion_vec") that prints the values of the > motion vectors (MV). > Isn't this super-hacky? In a well-designed system, a codec might export its MVs using designated structs (which we already have) and then use

Re: [FFmpeg-devel] [PATCH] ipfsgateway: Remove default gateway

2022-08-23 Thread Ronald S. Bultje
Hi, On Mon, Aug 22, 2022 at 5:52 AM Nicolas George wrote: > Tomas Härdin (12022-08-22): > > I'd actually argue that in that case we should link a library that > > implements IPFS, not split developer effort by trying to implement it > > ourselves. > > Is FFmpeg meant to be just a convenient set

Re: [FFmpeg-devel] [PATCH 2/2] checkasm: sw_scale: Reduce range of test data in the yuv2yuvX test to get closer to real data

2022-08-17 Thread Ronald S. Bultje
Hi, On Wed, Aug 17, 2022 at 4:32 PM Martin Storsjö wrote: > This avoids overflows on some inputs in the x86 case, where the > assembly version would clip/overflow differently from the > C reference function. > > This doesn't seem to be a real issue with actual input data, but > only with the

Re: [FFmpeg-devel] [FFmpeg-cvslog] doc/filters: clarify behaviour of weights in amix

2022-08-09 Thread Ronald S. Bultje
On Tue, Aug 9, 2022 at 5:36 PM Gyan Doshi wrote: > > > On 2022-08-09 02:57 pm, Anton Khirnov wrote: > > Quoting Gyan Doshi (2022-08-09 11:22:39) > >> I am a docs maintainer so I push these directly. > > All patches should go through the mailing list, so other people get the > > opportunity to

Re: [FFmpeg-devel] [PATCH v3 2/2] ffmpeg_opt: consider HW acceleration method when selecting decoder

2022-07-29 Thread Ronald S. Bultje
Hi, On Fri, Jul 29, 2022 at 4:38 PM Xiang, Haihao < haihao.xiang-at-intel@ffmpeg.org> wrote: > libdav1d is the preferred AV1 decoder in FFmpeg, libdav1d is always used > when > running the command below even if user expects vaapi or other HW > acceleration > methods. > I think that is a

Re: [FFmpeg-devel] [PATCH 05/39] avcodec/vp9dec: Constify VP9TileData->VP9Context pointer target

2022-07-27 Thread Ronald S. Bultje
Hi, On Wed, Jul 27, 2022 at 5:32 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > This is possible now that ff_thread_await_progress() accepts > a const ThreadFrame*. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vp9_mc_template.c | 2 +- > libavcodec/vp9block.c

Re: [FFmpeg-devel] [PATCH 07/39] avcodec/vp8: Constify slice threads' ptr to main context

2022-07-27 Thread Ronald S. Bultje
Hi, On Wed, Jul 27, 2022 at 5:31 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Modifying the main context from a slice thread is (usually) > a data race, so it must not happen. So only use a pointer to const > to access the main context. > > Signed-off-by: Andreas Rheinhardt

Re: [FFmpeg-devel] [PATCH v5 00/25] Subtitle Filtering 2022

2022-07-25 Thread Ronald S. Bultje
Hi, On Sun, Jul 24, 2022 at 11:10 PM Nicolas George wrote: > I do not recognize the project I started contributing to more than > fifteen years ago. I do not even recognize the project that boasted the > clever optimization framework that made FFVP9 possible, it has become > increasingly

Re: [FFmpeg-devel] [PATCH 5/5] avcodec/vp8, vp9: Avoid using VP56mv and VP56Frame in VP8/9

2022-07-23 Thread Ronald S. Bultje
Hi, On Sat, Jul 23, 2022 at 1:16 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Instead replace VP56mv by new and identical structures VP8mv and VP9mv. > Also replace VP56Frame by VP8FrameType in vp8.h and use that > in VP8 code. Also remove VP56_FRAME_GOLDEN2, as this has only

Re: [FFmpeg-devel] [PATCH 5/5] aarch64: me_cmp: Don't do uaddlv once per iteration

2022-07-16 Thread Ronald S. Bultje
Hi, On Sat, Jul 16, 2022 at 7:23 PM Michael Niedermayer wrote: > What i meant was that newly added functions should be more flexible than > these old rules. That is 2 sets of rules > 1. What a caller ATM can do and expect to work (thats whats written there) > 2. What an implementor of new

Re: [FFmpeg-devel] [PATCH 05/41] avcodec/videodsp: Make ff_emulated_edge_mc_16 static

2022-06-10 Thread Ronald S. Bultje
Hi, On Thu, Jun 9, 2022 at 7:56 PM Andreas Rheinhardt < andreas.rheinha...@outlook.com> wrote: > Only ff_emulated_edge_mc_8() is used outside of lavc/videodsp.c. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/videodsp.c | 4 > libavcodec/videodsp.h | 1 - >

Re: [FFmpeg-devel] [PATCH] vp9: don't overread by 4 pixels in ff_vp9_avg4_mmxext().

2022-06-01 Thread Ronald S. Bultje
Hi, On Tue, May 31, 2022 at 9:21 AM Ronald S. Bultje wrote: > If the block is at the end of the allocated buffer and there is no > padding, this will over-read, which may cause crashes. Reported by > Firefox. > --- > libavcodec/x86/vp9mc.asm | 5 + > 1 file cha

Re: [FFmpeg-devel] [PATCH v7 1/1] avutil/csp: create public API for colorspace structs

2022-06-01 Thread Ronald S. Bultje
Hi, On Tue, May 31, 2022 at 10:26 AM Ronald S. Bultje wrote: > On Sat, May 28, 2022 at 9:30 AM Leo Izen wrote: > >> This commit moves some of the functionality from avfilter/colorspace >> into avutil/csp and exposes it as a public API so it can be used by >> libav

Re: [FFmpeg-devel] [PATCH] Add YCOCG colorspace to input arguments of vf_colorspace.

2022-05-31 Thread Ronald S. Bultje
Hi, On Thu, May 19, 2022 at 4:42 PM Mohammad Izadi < izadi-at-google@ffmpeg.org> wrote: > ffmpeg support YCOCG (YCOCG=YCGCO). However, vf_colorspace is only support > YCGCO as input. Added YCOCG to the inputs. > --- > libavfilter/vf_colorspace.c | 1 + > 1 file changed, 1 insertion(+) > >

Re: [FFmpeg-devel] [PATCH v7 1/1] avutil/csp: create public API for colorspace structs

2022-05-31 Thread Ronald S. Bultje
Hi, On Sat, May 28, 2022 at 9:30 AM Leo Izen wrote: > This commit moves some of the functionality from avfilter/colorspace > into avutil/csp and exposes it as a public API so it can be used by > libavcodec and/or libavformat. It also converts those structs from > double values to AVRational to

[FFmpeg-devel] [PATCH] vp9: don't overread by 4 pixels in ff_vp9_avg4_mmxext().

2022-05-31 Thread Ronald S. Bultje
If the block is at the end of the allocated buffer and there is no padding, this will over-read, which may cause crashes. Reported by Firefox. --- libavcodec/x86/vp9mc.asm | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/x86/vp9mc.asm b/libavcodec/x86/vp9mc.asm index

[FFmpeg-devel] [PATCH] vp9: don't overread by 4 pixels in ff_vp9_avg4_mmxext().

2022-05-31 Thread Ronald S. Bultje
If the block is at the end of the allocated buffer and there is no padding, this will over-read, which may cause crashes. Reported by Firefox. --- libavcodec/x86/vp9mc.asm | 5 - 1 file changed, 4 insertions(+), 1 deletion(-) diff --git a/libavcodec/x86/vp9mc.asm b/libavcodec/x86/vp9mc.asm

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: ipred_hd_16x16_16 avx2 implementation

2022-05-31 Thread Ronald S. Bultje
Hi, On Thu, May 26, 2022 at 12:43 AM FacelessLake wrote: > From: Semen Belozerov > > --- > libavcodec/x86/vp9dsp_init_16bpp.c| 2 + > libavcodec/x86/vp9intrapred_16bpp.asm | 54 +++ > 2 files changed, 56 insertions(+) > Apologies for forgetting about this, this

Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs

2022-05-20 Thread Ronald S. Bultje
Hi, On Fri, May 20, 2022 at 9:11 AM Michael Niedermayer wrote: > On Fri, May 20, 2022 at 07:26:56AM -0400, Ronald S. Bultje wrote: > > On Fri, May 20, 2022 at 6:28 AM Michael Niedermayer < > mich...@niedermayer.cc> > > > 1. exactly representing values > > >

Re: [FFmpeg-devel] [PATCH v4] avutil/csp: create avpriv API for colorspace structs

2022-05-20 Thread Ronald S. Bultje
Hi Michael, On Fri, May 20, 2022 at 6:28 AM Michael Niedermayer wrote: > 1. exactly representing values > This isn't actually what I meant when I made the argument. If the spec says "0.137", I'd expect to be able to git grep the source code for "0.137" and find where it's defined. This is lost

Re: [FFmpeg-devel] [PATCH] avutil/csp: create public API for colorspace structs

2022-05-15 Thread Ronald S. Bultje
> > libavcodec and/or libavformat. > [...] > > diff --git a/libavutil/csp.h b/libavutil/csp.h > > new file mode 100644 > > index 00..1bcde7ddd3 > > --- /dev/null > > +++ b/libavutil/csp.h > > @@ -0,0 +1,49 @@ > > +/* > > + *

Re: [FFmpeg-devel] [PATCH] avutil/csp: create public API for colorspace structs

2022-05-13 Thread Ronald S. Bultje
Hi, On Fri, May 13, 2022 at 11:42 AM Leo Izen wrote: > This commit moves some of the functionality from avfilter/colorspace > into avutil/csp and exposes it as a public API so it can be used by > libavcodec and/or libavformat. > --- > libavfilter/colorspace.c| 88

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: ipred_vl_16x16_16 avx2 implementation

2022-05-12 Thread Ronald S. Bultje
Hi, On Wed, May 4, 2022 at 8:57 AM FacelessLake wrote: > From: Semen Belozerov > > --- > libavcodec/x86/vp9dsp_init_16bpp.c| 2 ++ > libavcodec/x86/vp9intrapred_16bpp.asm | 51 +++ > 2 files changed, 53 insertions(+) > Merged. Ronald

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: free the Dav1dData packet on dav1d_send_data() failure

2022-02-01 Thread Ronald S. Bultje
Hi, On Tue, Feb 1, 2022 at 10:07 AM James Almer wrote: > We still own it on failure, and there's no point trying to feed it again. > > Signed-off-by: James Almer > --- > libavcodec/libdav1d.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libdav1d.c

Re: [FFmpeg-devel] http: honor response headers in redirect caching

2022-01-31 Thread Ronald S. Bultje
Hi, On Mon, Jan 31, 2022 at 9:37 AM Ronald S. Bultje wrote: > Hi, > > On Sun, Jan 30, 2022 at 1:15 AM Eran Kornblau > wrote: > >> > >> > -Original Message- >> > From: Eran Kornblau >> > Sent: Wednesday, 19 January 2022 9:14

Re: [FFmpeg-devel] http: honor response headers in redirect caching

2022-01-31 Thread Ronald S. Bultje
sponse headers in redirect > caching > > > > > > > > > > > Hi, > > > > > > On Mon, Jan 17, 2022 at 7:10 AM Ronald S. Bultje > wrote: > > > > > > > Hi, > > > > > > > > On Tue, Jan 11, 2022 at 9:43 AM

Re: [FFmpeg-devel] http: honor response headers in redirect caching

2022-01-18 Thread Ronald S. Bultje
Hi, On Mon, Jan 17, 2022 at 7:10 AM Ronald S. Bultje wrote: > Hi, > > On Tue, Jan 11, 2022 at 9:43 AM Eran Kornblau > wrote: > >> Hi all, >> >> Recently I’ve submitted a patch that adds a config option to disable the >> caching of http redirects. >>

Re: [FFmpeg-devel] http: honor response headers in redirect caching

2022-01-17 Thread Ronald S. Bultje
Hi, On Tue, Jan 11, 2022 at 9:43 AM Eran Kornblau wrote: > Hi all, > > Recently I’ve submitted a patch that adds a config option to disable the > caching of http redirects. > We planned this as a workaround to the fact there’s a limit on the > expiration that can be set on S3 pre-signed URLs. >

Re: [FFmpeg-devel] AVFrame data alignment issues

2022-01-15 Thread Ronald S. Bultje
Hi, On Sat, Jan 15, 2022 at 7:59 PM Marton Balint wrote: > How this should be fixed? > The current state (I believe this is documented) is that libavfilter buffers are not guaranteed to be aligned, but libavcodec buffers are. If a libavfilter without alignment is input into avcodec without

Re: [FFmpeg-devel] [PATCH] http: make caching of redirect url optional

2021-12-31 Thread Ronald S. Bultje
Hi, On Mon, Dec 27, 2021 at 2:08 PM Ronald S. Bultje wrote: > Hi, > > On Mon, Dec 27, 2021 at 4:38 AM Eran Kornblau > wrote: > >> > -Original Message- >> > From: ffmpeg-devel On Behalf Of >> Ronald S. Bultje >> > Sent: Sunday, 26

Re: [FFmpeg-devel] [PATCH] http: make caching of redirect url optional

2021-12-27 Thread Ronald S. Bultje
Hi, On Mon, Dec 27, 2021 at 4:38 AM Eran Kornblau wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of > Ronald S. Bultje > > Sent: Sunday, 26 December 2021 16:07 > > To: FFmpeg development discussions and patches > > Subject: Re: [FFmpeg-

Re: [FFmpeg-devel] GitHub Integration

2021-12-26 Thread Ronald S. Bultje
Hi, On Sun, Dec 26, 2021 at 3:21 PM Soft Works wrote: > I'm not sure. My interpretation of Lance' and Steven's comments would > be that they'd prefer to stick to the ML. > No, it's not strictly related to that - they want something that is CLI accessible. Gitlab has this here:

Re: [FFmpeg-devel] [PATCH] http: make caching of redirect url optional

2021-12-26 Thread Ronald S. Bultje
Hi, (I was asked to respond since I'm listed as HTTP maintainer, not sure I should be since I'm mostly working on video codecs nowadays.) On Tue, Nov 2, 2021 at 9:00 AM Eran Kornblau wrote: > The motivation for this feature is S3 signatures – currently we have a > problem where S3 signatures

Re: [FFmpeg-devel] Politics

2021-12-12 Thread Ronald S. Bultje
Hi, On Sun, Dec 12, 2021 at 1:21 PM Nicolas George wrote: > I have told Soft Works they were going at it the wrong way when they > posted the very first patch > There is no one magic correct way to do it. People work on things differently, and that's OK. Now, if there's issues with his

Re: [FFmpeg-devel] python filter

2021-12-07 Thread Ronald S. Bultje
Hi, On Tue, Dec 7, 2021 at 12:53 PM Alex <3.1...@ukr.net> wrote: > Yes. > I wat to do filtering inside python script. > No, that is currently not possible. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 0/2]

2021-11-28 Thread Ronald S. Bultje
Hi John-Paul, On Sat, Nov 27, 2021 at 8:22 PM John-Paul Stewart < jpstew...@personalprojects.net> wrote: > On 2021-11-27 8:51 a.m., Ronald S. Bultje wrote: > > Hi, > > > > On Fri, Nov 26, 2021 at 4:52 PM John-Paul Stewart < > > jpstew...@personalprojects.net&g

Re: [FFmpeg-devel] [PATCH 0/2]

2021-11-27 Thread Ronald S. Bultje
Hi, On Fri, Nov 26, 2021 at 4:52 PM John-Paul Stewart < jpstew...@personalprojects.net> wrote: > There were no single channel examples and no 8 bit > examples. > > I have created four clips with SGI's original 'moviemaker' utility (so > they are guaranteed to be correctly formatted) to reverse

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-30 Thread Ronald S. Bultje
Hi, On Sat, Oct 30, 2021 at 4:57 AM Tomas Härdin wrote: > Maybe we should upgrade to C11 then? This gives us access to more > useful language features. Type-generic expressions look very useful > https://stackoverflow.com/a/7005988 (same thread, further down) appears to suggest the exact same

Re: [FFmpeg-devel] [PATCH] avfilter: add wpsnr video filter

2021-10-29 Thread Ronald S. Bultje
Hi Thomas, On Fri, Oct 29, 2021 at 9:12 AM Tomas Härdin wrote: > tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol: > > +const uint16_t *src = (const uint16_t *)ssrc; > > This is not -fstrict-aliasing safe > I don't believe that is correct. It's true we're not allowed to cast between

Re: [FFmpeg-devel] [PATCH] avcodec/wma: handle run_level_decode error

2021-08-24 Thread Ronald S. Bultje
Hi, On Tue, Aug 24, 2021 at 9:07 AM Olivier Crête wrote: > Hi Andreas, > > > Generally, one should forward error codes and not make up some on the > > fly; in this case, the callee does not return proper error codes, so > > this should be fixed, too (but not in the same commit and not > >

Re: [FFmpeg-devel] [PATCH] avcodec/av1dec: Adjust incorrect error output

2021-08-23 Thread Ronald S. Bultje
Hi, On Mon, Aug 23, 2021 at 9:39 PM Soft Works wrote: > The current message "Your platform doesn't suppport > hardware accelerated AV1 decoding." is inaccurate and > misleading. When a user doesn't specify a hwcaccel, > this doesn't tell anything about what is actually > supported on that

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

2021-08-19 Thread Ronald S. Bultje
Hi Jianhua, On Wed, Aug 18, 2021 at 7:31 AM qs xw wrote: > So what should I do? Feel free to let me know. > My personal slight preference would be to continue allowing Skylake-style asm, i.e. add a new runtime flag for ICL-style avx512. Then, people on skylake can at their choice disable

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

2021-08-18 Thread Ronald S. Bultje
Hi, On Tue, Aug 17, 2021 at 10:13 PM Wu, Jianhua wrote: > The reason why we set the icelake-avx512 as the minimum baseline is that > we don't want FFmpeg run on a processor downclocking heavily, hence, keep > the current flag and add a new AVX512ICL make no sense. > I don't think you can make

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

2021-08-17 Thread Ronald S. Bultje
Hi, On Tue, Aug 17, 2021 at 3:27 PM James Almer wrote: > On 8/17/2021 4:24 PM, James Almer wrote: > > On 8/17/2021 12:25 PM, Ronald S. Bultje wrote: > >> On Tue, Aug 17, 2021 at 2:33 AM Hendrik Leppkes > >> wrote: > >>> On Tue, Aug 17, 2021 at 8:

Re: [FFmpeg-devel] [PATCH] configure: set IceLake-AVX512 as the minimum baseline

2021-08-17 Thread Ronald S. Bultje
Hi, On Tue, Aug 17, 2021 at 2:33 AM Hendrik Leppkes wrote: > On Tue, Aug 17, 2021 at 8:30 AM Wu Jianhua wrote: > > Based on IceLake-AVX512 and newer architecture, a broad > > range of the subsets of AVX512 could be supported. > [..] > > -enabled avx512 && check_x86asm avx512_external

Re: [FFmpeg-devel] Optimised math functions in FFMPEG?

2021-08-15 Thread Ronald S. Bultje
Hi Paul, On Sun, Aug 15, 2021 at 9:25 AM Paul Buxton wrote: > Specifically any of > pow() > exp() > log() > pow(a, b) = exp(log(a) * b), so you only need exp/log. As for exp/log optimized versions, there's two approaches that may work for you. First, integer operation is critical (e.g. 16-bit

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-14 Thread Ronald S. Bultje
Hi, On Sat, Aug 14, 2021 at 1:13 PM ffmpegandmahanstreamer wrote: > August 14, 2021 1:01 PM, "Nicolas George" wrote: > > > ffmpegandmahanstreamer (12021-08-14): > > > >> The real person winning here is Soft Works. He must be laughing right > now. > >> > >> Ah, your math degree coming into work

Re: [FFmpeg-devel] [RFC] Suggestion for a Nicer Integration with GitHub

2021-08-13 Thread Ronald S. Bultje
Hi, On Thu, Aug 12, 2021 at 4:51 AM Nicolas George wrote: > Paul Buxton (12021-08-12): > > From the point of view of someone who is currently developing a filter > for > > ffmpeg and will be submitting a patch to the list for the first time, I > > think this is a great idea.Whilst following

Re: [FFmpeg-devel] [PATCH 2/2] libswscale: Adds ff_hscale8to15_4_avx2 and ff_hscale8to15_X4_avx2 for all filter sizes.

2021-06-25 Thread Ronald S. Bultje
Hi Alan, On Fri, Jun 25, 2021 at 7:53 AM Alan Kelly wrote: > > > On Fri, Jun 25, 2021 at 1:26 PM Ronald S. Bultje > wrote: > >> Hi Alan, >> >> On Fri, Jun 25, 2021 at 3:59 AM Alan Kelly < >> alankelly-at-google@ffmpeg.org> wrote: >> >

Re: [FFmpeg-devel] [PATCH 2/2] libswscale: Adds ff_hscale8to15_4_avx2 and ff_hscale8to15_X4_avx2 for all filter sizes.

2021-06-25 Thread Ronald S. Bultje
Hi Alan, On Fri, Jun 25, 2021 at 3:59 AM Alan Kelly < alankelly-at-google@ffmpeg.org> wrote: > These functions replace all ff_hscale8to15_*_ssse3 when avx2 is available. > Re-asking a question I asked before in the other thread: Also, what is the cycle count of ssse3/avx2 implementation

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/cpu: Adds av_cpu_has_fast_gather to detect cpus with avx fast gather instruction

2021-06-14 Thread Ronald S. Bultje
Hi Alan, On Mon, Jun 14, 2021 at 7:20 AM Alan Kelly < alankelly-at-google@ffmpeg.org> wrote: > Broadwell and later have fast gather instructions. > --- > This is so that the avx2 version of ff_hscale8to15X which uses gather > instructions is only selected on machines where it will actually

Re: [FFmpeg-devel] [PATCH 2/3] checkasm/vp9dsp: rename the iszero function to is_zero

2021-06-07 Thread Ronald S. Bultje
Hi, On Sun, Jun 6, 2021 at 10:42 PM James Almer wrote: > From: Matthieu Patou > > The function name iszero() may collide with a function in glibc. > > Suggested-by: ffm...@fb.com > Signed-off-by: James Almer > --- > tests/checkasm/vp9dsp.c | 6 +++--- > 1 file changed, 3 insertions(+), 3

Re: [FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-03 Thread Ronald S. Bultje
Hi, On Tue, Mar 2, 2021 at 1:59 PM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Ronald S. Bultje: > > --- > > libavformat/ivfenc.c | 10 +++--- > > 1 file changed, 7 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/iv

[FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Ronald S. Bultje
--- libavformat/ivfenc.c | 10 +++--- 1 file changed, 7 insertions(+), 3 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 0951f56..889c004 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@ -23,7 +23,7 @@ typedef struct IVFEncContext { unsigned

Re: [FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Ronald S. Bultje
Hi, On Tue, Mar 2, 2021 at 11:20 AM Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Ronald S. Bultje: > > --- > > libavformat/ivfenc.c | 11 --- > > 1 file changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/libavformat/iv

[FFmpeg-devel] [PATCH] ivfenc: write duration for frame_cnt=1.

2021-03-02 Thread Ronald S. Bultje
--- libavformat/ivfenc.c | 11 --- 1 file changed, 8 insertions(+), 3 deletions(-) diff --git a/libavformat/ivfenc.c b/libavformat/ivfenc.c index 0951f56..e22625b 100644 --- a/libavformat/ivfenc.c +++ b/libavformat/ivfenc.c @@ -23,7 +23,7 @@ typedef struct IVFEncContext {

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Ronald S. Bultje
On Mon, Jan 18, 2021 at 3:33 PM Anton Khirnov wrote: > Quoting Ronald S. Bultje (2021-01-18 21:12:50) > > Hi, > > > > On Mon, Jan 18, 2021 at 2:55 PM Anton Khirnov wrote: > > > > > I have at some point touched most major pieces of code in the project. &g

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Ronald S. Bultje
Hi, On Mon, Jan 18, 2021 at 2:55 PM Anton Khirnov wrote: > I have at some point touched most major pieces of code in the project. > I also have opinions on how many things should be done. So according to > your definition, that makes me biased and disqualified from voting on > almost anything,

Re: [FFmpeg-devel] [PATCH] [RFC][v2] Tech Resolution Process

2021-01-18 Thread Ronald S. Bultje
Hi, On Mon, Jan 18, 2021 at 1:25 PM Nicolas George wrote: > What we are talking about is called conflict of interest. Every > functioning institution has rules to prevent them. +1 on this. Ronald ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] Next developer meeting

2020-11-11 Thread Ronald S. Bultje
Hi, On Wed, Nov 11, 2020 at 10:45 AM Anton Khirnov wrote: > Quoting James Almer (2020-11-11 14:13:07) > > I don't recall anything about splitting IO, but what does it achieve > > beyond making lavf lighter? Are there users out there that could care > > about linking to an hypothetical lavio

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-11-07 Thread Ronald S. Bultje
Hi, On Fri, Nov 6, 2020 at 11:10 AM Joakim Tjernlund < joakim.tjernl...@infinera.com> wrote: > We unbundle the ffmpeg/mesa and use system mesa/ffmpeg That's the answer to my earlier question also, thank you. I'm fine with applying this, I would suggest that the "new" (correct) behaviour should

Re: [FFmpeg-devel] [PATCH v4] Unbreak av_malloc_max(0) API/ABI

2020-11-04 Thread Ronald S. Bultje
Hi Joakim, On Tue, Nov 3, 2020 at 8:57 AM Joakim Tjernlund < joakim.tjernl...@infinera.com> wrote: > On Tue, 2020-11-03 at 14:38 +0100, Andreas Rheinhardt wrote: > > > > Timo Rothenpieler: > > > Given the multitude of recent serious security issues in Chromium-Based > > > Browsers, is this even

Re: [FFmpeg-devel] [PATCH] Unbreak av_malloc_max(0) API/ABI

2020-10-13 Thread Ronald S. Bultje
Hi, On Tue, Oct 13, 2020 at 6:30 AM Joakim Tjernlund < joakim.tjernl...@infinera.com> wrote: > From https://bugs.chromium.org/p/chromium/issues/detail?id=1095962 > > This seems to be caused by the custom handling of "av_max_alloc(0)" in > Chromium's ffmpeg fork to

Re: [FFmpeg-devel] [PATCH] vf_colorspace: Added linear trc.

2020-09-27 Thread Ronald S. Bultje
Hi, On Thu, Sep 24, 2020 at 3:01 PM Andrew Klaassen < clawsoon-at-yahoo@ffmpeg.org> wrote: > This patch adds the coefficients for the linear gamma function (1,0,1,0) > to the colorspace filter. > > Signed-off-by: Andrew Klaassen > --- > libavfilter/vf_colorspace.c | 2 ++ > 1 file changed,

Re: [FFmpeg-devel] [PATCH v3] libavcodec/vp8dec: fix the multi-thread HWAccel decode error

2020-09-23 Thread Ronald S. Bultje
Hi, On Wed, Sep 23, 2020 at 1:48 PM Eoff, Ullysses A wrote: > > -Original Message- > > From: ffmpeg-devel On Behalf Of Eoff, > Ullysses A > > Sent: Wednesday, September 23, 2020 10:33 AM > > To: Xiang, Haihao ; ffmpeg-devel@ffmpeg.org > > Subject: Re: [FFmpeg-devel] [PATCH v3]

Re: [FFmpeg-devel] Uploaded sample file to 'help'

2020-08-12 Thread Ronald S. Bultje
Hi, On Tue, Aug 11, 2020 at 4:57 PM Nathanael Newton wrote: > This is a video from a genie wireless security camera. > They claimed it was encrypted, in fact this was a lie, it's just obfuscated > by being renamed to .data Both could be true at the same time. It could be both renamed as well

Re: [FFmpeg-devel] [PATCH] x86/yuv2rgb: fix crashes when storing data on unaligned buffers

2020-07-13 Thread Ronald S. Bultje
On Mon, Jul 13, 2020 at 3:10 AM Carl Eugen Hoyos wrote: > > > > Am 13.07.2020 um 02:33 schrieb James Almer : > > > > Regression since fc6a5883d6af8cae0e96af84dda0ad74b360a084 on SSSE3 > enabled > > CPUs. > > FFmpeg does not require aligned output buffers on x86_64? Not in swscale/avfilter,

Re: [FFmpeg-devel] MPEG-2 FLAGS2_FAST benchmarks

2020-06-14 Thread Ronald S. Bultje
Hi, On Sat, Jun 13, 2020 at 12:11 PM Kieran Kunhya wrote: > Hello, > > I have run the following commands on the following CPU which is 7 years > old: > Intel(R) Xeon(R) CPU E3-1265L v3 > > ffmpeg_g -i matrixbench_mpeg2.mpg -f null - > and > ffmpeg_g -flags2 fast -i matrixbench_mpeg2.mpg -f null

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-05-05 Thread Ronald S. Bultje
Hi, On Wed, Apr 29, 2020 at 8:08 AM Fu, Linjie wrote: > > From: ffmpeg-devel On Behalf Of Fu, > > Linjie > > Sent: Friday, March 20, 2020 09:49 > > To: Ronald S. Bultje ; FFmpeg development > > discussions and patches > > Subject: Re: [FFmpeg-devel] [PATC

Re: [FFmpeg-devel] [PATCH 8/9] vp9dec: factorise freeing per-tile allocated data

2020-04-18 Thread Ronald S. Bultje
Hi, On Sat, Apr 18, 2020 at 6:15 AM Anton Khirnov wrote: > --- > libavcodec/vp9.c | 36 > 1 file changed, 16 insertions(+), 20 deletions(-) ok. Ronald ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH, v4] lavc/vp9: fix reference frame dimensions check for SINGLE_REFERENCE mode

2020-03-19 Thread Ronald S. Bultje
Hi, On Tue, Mar 17, 2020 at 10:59 AM Linjie Fu wrote: > With the description in frame size with refs semantics (SPEC 7.2.5), > it is a requirement of bitstream conformance that for at least one > reference frame has the valid dimensions. > > Modify the check to make sure the decoder works well

Re: [FFmpeg-devel] [PATCH 1/3] avutil/frame: add use_last_roi

2020-02-14 Thread Ronald S. Bultje
Hi, On Thu, Feb 13, 2020 at 10:41 PM Guo, Yejun wrote: > For some cases, the regions of interest do not change, it is not > convenient to always prepare the roi data for every frame. Since side-data is refcounted, can't you just keep the "last" one in memory and refcount it? That way, if you

Re: [FFmpeg-devel] [PATCH V7 1/2] libswscale/x86/yuv2rgb: Change inline assembly into nasm code

2020-01-19 Thread Ronald S. Bultje
Hi, On Sat, Jan 18, 2020 at 9:49 PM Fu, Ting wrote: > Since NASM function will get only the address of SwsConext c ( in order to > be compatible with yuv2rgb_c function in parameters), not the address of > c->redDither nor the c->dstW. I have no way to get the value of c->dstW by > using

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_av1: fix array size for ar_coeffs_cb_plus_128 and ar_coeffs_cr_plus_128

2019-12-11 Thread Ronald S. Bultje
Hi, On Wed, Dec 11, 2019 at 5:00 PM James Almer wrote: > Taking into account the code > > fb(2, ar_coeff_lag); > num_pos_luma = 2 * current->ar_coeff_lag * (current->ar_coeff_lag + 1); > if (current->num_y_points) > num_pos_chroma = num_pos_luma + 1; > else > num_pos_chroma =

[FFmpeg-devel] FFmpeg developer meeting 2019/12/9 notes

2019-12-10 Thread Ronald S. Bultje
Dear all, below are the notes I took of the 2019/12/9 FFmpeg developer meeting. The meeting was held on a Google Meet, and there was an IRC proxy channel (#ffmpeg-meeting) also. Kind regards, Ronald - jb opens, agenda for this meeting o what happened at last meeting (at VDD) o various next

Re: [FFmpeg-devel] [aarch64] improve performance of ff_hscale_8_to_15_neon

2019-11-27 Thread Ronald S. Bultje
Hi, On Thu, Nov 28, 2019 at 2:08 AM Ronald S. Bultje wrote: > Hi, > > On Wed, Nov 27, 2019 at 3:28 PM Sebastian Pop wrote: > >> On Wed, Nov 27, 2019 at 2:13 PM Clément Bœsch wrote: >> > Yeah I will by the end of the week. I wrote that a few years ago so I >> n

<    1   2   3   4   5   6   7   8   9   10   >