Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/hlsenc: write temp file for append single file by encryption mode

2020-08-02 Thread Steven Liu
Steven Liu 于2020年7月25日周六 上午10:49写道: > > Steven Liu 于2020年7月22日周三 下午5:16写道: > > > > fix ticket: 8783 > > Because in single file by encryption mode, it cannot get the last one > > block of the file, it need ff_format_io_close for get full file size, > >

Re: [FFmpeg-devel] [PATCH 1/3] test: hlsenc: Make the hls_fmp4 sample file name match the target

2020-08-02 Thread Steven Liu
Martin Storsjö 于2020年8月2日周日 下午3:06写道: > > Previously, with the file name not matching the target, the files > were regenerated every time fate is rerun - contrary to the other > test targets in the same file. (While regenerating it every time > might be desireable, as that's what the test is

Re: [FFmpeg-devel] [PATCH 2/3] test: hlsenc: Make fate-hls-fmp4 actually use the right segment type

2020-08-02 Thread Steven Liu
Martin Storsjö 于2020年8月2日周日 下午2:49写道: > > Since this test was added in ac22835db947e, it actually has been > using segment type mpegts, contrary to what the test looks like > it is supposed to test. > --- > tests/fate/hlsenc.mak | 2 +- > tests/ref/fate/hls-fmp4 | 384

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

2020-07-30 Thread Steven Liu
Zong, Wei 于2020年7月30日周四 下午6:00写道: > > Someone opened an issue https://github.com/intel/libxcam/issues/729 they > want to use a FFmpeg video filter pipeline to do multiple decoder, stitching > and encoder. > > Those 3rd party libs are not necessary for stitching and most image > processing

Re: [FFmpeg-devel] [PATCH] avfilter/vf_xcam: add xcam video filter

2020-07-30 Thread Steven Liu
zongwave 于2020年7月30日周四 下午5:06写道: > > From: Yinhang Liu > > xcam filter is a wrapper of libxcam project which supports 360 video > stitching, > automotive surround view stitching, digital video stabilization (DVS), > Wide dynamic range (WDR), wavelet noise reduction, 3D noise reduction, etc. > >

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Steven Liu
Zlomek, Josef 于2020年7月28日周二 下午6:58写道: > > see version 3 Isn't this version? or maybe your mean is version 4? > > On Tue, Jul 28, 2020 at 12:37 PM Steven Liu wrote: > > > Josef Zlomek 于2020年7月28日周二 下午12:11写道: > > > > > > Fixes: 8814 > > > &

Re: [FFmpeg-devel] [PATCH v3 1/2] avformat/url: fix logic for removing ".." path components

2020-07-28 Thread Steven Liu
Josef Zlomek 于2020年7月28日周二 下午12:11写道: > > Fixes: 8814 > > The logic for removing ".." path components and their corresponding > upper directories was reworked. > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: > - if the

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/tests/url: add test cases for handling of double dot

2020-07-27 Thread Steven Liu
Josef Zlomek 于2020年7月27日周一 下午8:15写道: > > Signed-off-by: Josef Zlomek > --- > libavformat/tests/url.c | 6 ++ > tests/ref/fate/url | 6 ++ > 2 files changed, 12 insertions(+) > > diff --git a/libavformat/tests/url.c b/libavformat/tests/url.c > index 1d961a1b43..a27a875892 100644 >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: increase initial program date time precision

2020-07-27 Thread Steven Liu
Marton Balint 于2020年7月28日周二 上午4:15写道: > > > > On Sun, 19 Jul 2020, Marton Balint wrote: > > > > > > > On Sun, 19 Jul 2020, Steven Liu wrote: > > > >> Zhao Zhili 于2020年7月19日周日 下午6:26写道: > >>> > >>> > >>> > >

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: fix logic for removing ".." path components

2020-07-27 Thread Steven Liu
Josef Zlomek 于2020年7月27日周一 下午8:15写道: > > Fixes: 8814 > > The logic for removing ".." path components and their corresponding > upper directories was reworked. > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: > - if the

[FFmpeg-devel] [PATCH v3 2/2] avformat/tests/url: add test cases for .. and last node is ..

2020-07-27 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/tests/url.c | 14 ++ tests/ref/fate/url | 12 2 files changed, 26 insertions(+) diff --git a/libavformat/tests/url.c b/libavformat/tests/url.c index 1d961a1b43..0de511caf9 100644 --- a/libavformat/tests/url.c +++ b

[FFmpeg-devel] [PATCH v3 1/2] avformat/url: rework for trim_double_dot_url

2020-07-27 Thread Steven Liu
use two buffer for storage the path and node of URI remove the last node of the path if the next node is .. change the static strings to dynamic alloc space by size argument. Signed-off-by: Steven Liu --- libavformat/url.c | 83 --- 1 file changed, 64

Re: [FFmpeg-devel] [PATCH 1/3] avformat/url: fix logic for removing ".." path components

2020-07-27 Thread Steven Liu
Zlomek, Josef 于2020年7月27日周一 下午7:45写道: > > Hi Steven, > > ".." is always a directory. > > your tests (diff starting with -) are not correct. > My results (lines starting with +) are correct. > > Josef > > On Mon, Jul 27, 2020 at 1:36 PM Steven Liu wrote:

Re: [FFmpeg-devel] [PATCH 3/3] avformat/url: remove duplicate call to strstr

2020-07-27 Thread Steven Liu
Josef Zlomek 于2020年7月27日周一 下午6:57写道: > > Signed-off-by: Josef Zlomek > --- > libavformat/url.c | 13 + > 1 file changed, 5 insertions(+), 8 deletions(-) > > diff --git a/libavformat/url.c b/libavformat/url.c > index ccaa28a1ed..28d12fd3de 100644 > --- a/libavformat/url.c > +++

Re: [FFmpeg-devel] [PATCH 1/3] avformat/url: fix logic for removing ".." path components

2020-07-27 Thread Steven Liu
Josef Zlomek 于2020年7月27日周一 下午6:57写道: > > Fixes: 8814 > > The logic for removing ".." path components and their corresponding > upper directories was reworked. > > Now, the function trim_double_dot_url splits the path by "/" into > components, and processes the components one ny one: > - if the

Re: [FFmpeg-devel] [PATCH] lavc/libxavs2.c: mark key-frame packets

2020-07-27 Thread Steven Liu
hwren 于2020年7月27日周一 下午3:59写道: > > > > 在 2020-07-27 15:26:24,"Steven Liu" 写道: > > 于2020年7月27日周一 下午2:22写道: > >> > >> From: hwren > >> > >> Signed-off-by: hwren > >> --- > >> libavcodec/libxavs2.c | 6 ++ &g

Re: [FFmpeg-devel] AVWriter again (was: v2 1/2] avformat/url: check double dot is not to parent directory)

2020-07-27 Thread Steven Liu
Nicolas George 于2020年7月25日周六 下午7:03写道: > > Marton Balint (12020-07-25): > > And I also would like to point out that using static strings with > > MAX_URL_SIZE is not OK. This function supports an arbitrary buffer size, so > > limiting it to MAX_URL_SIZE is a bug. > > Excellent point. That would

Re: [FFmpeg-devel] [PATCH] lavc/libxavs2.c: mark key-frame packets

2020-07-27 Thread Steven Liu
于2020年7月27日周一 下午2:22写道: > > From: hwren > > Signed-off-by: hwren > --- > libavcodec/libxavs2.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavcodec/libxavs2.c b/libavcodec/libxavs2.c > index 76b57e731e..8519f6925a 100644 > --- a/libavcodec/libxavs2.c > +++

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-27 Thread Steven Liu
Marton Balint 于2020年7月25日周六 下午5:40写道: > > > > On Sat, 25 Jul 2020, Zlomek, Josef wrote: > > > Hi Steven, > > > > It is better but still not correct. Consider this test: > > > > test("http://server/foo/bar;, > > "a/b/../c/d/../e../.../..f/g../h../other/url/a.mp3/..."); > > It should give " > >

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Steven Liu
Marton Balint 于2020年7月25日周六 下午5:40写道: > And I also would like to point out that using static strings with > MAX_URL_SIZE is not OK. This function supports an arbitrary buffer size, > so limiting it to MAX_URL_SIZE is a bug. Okay, get it, i'm reworking. Thanks Steven

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Steven Liu
Nicolas George 于2020年7月25日周六 下午4:44写道: > > Steven Liu (12020-07-25): > > > And I think you would better rework the complete logic of the test: > > agreed, I think need lots of testcase for the logic, ../ .../.. > > dummy../... .../..dummy and so on, > > maybe

Re: [FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-25 Thread Steven Liu
Nicolas George 于2020年7月25日周六 下午4:31写道: > > Steven Liu (12020-07-25): > > fix ticket: 8814 > > if get ".." in the url, check next byte and lead byte by double dot, > > it there have no '/' and not root node, it is not used go to directory &quo

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/hlsenc: write temp file for append single file by encryption mode

2020-07-24 Thread Steven Liu
Steven Liu 于2020年7月22日周三 下午5:16写道: > > fix ticket: 8783 > Because in single file by encryption mode, it cannot get the last one > block of the file, it need ff_format_io_close for get full file size, > then hlsenc can get the total size of the encryption content, > so write the

[FFmpeg-devel] [PATCH v2 1/2] avformat/url: check double dot is not to parent directory

2020-07-24 Thread Steven Liu
fix ticket: 8814 if get ".." in the url, check next byte and lead byte by double dot, it there have no '/' and not root node, it is not used go to directory ".." Signed-off-by: Steven Liu --- libavformat/url.c | 12 1 file changed, 12 insertions(+) diff --git a

[FFmpeg-devel] [PATCH v2 2/2] avformat/tests/url: add test cases of double dot is not goto directory

2020-07-24 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/tests/url.c | 5 + tests/ref/fate/url | 5 + 2 files changed, 10 insertions(+) diff --git a/libavformat/tests/url.c b/libavformat/tests/url.c index 1d961a1b43..0201217109 100644 --- a/libavformat/tests/url.c +++ b/libavformat/tests/url.c

[FFmpeg-devel] [PATCH 2/2] libavformat/tests/url: add test case of double dot is not directory

2020-07-24 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/tests/url.c | 2 ++ tests/ref/fate/url | 2 ++ 2 files changed, 4 insertions(+) diff --git a/libavformat/tests/url.c b/libavformat/tests/url.c index 1d961a1b43..3e4e5c4247 100644 --- a/libavformat/tests/url.c +++ b/libavformat/tests/url.c @@ -67,6

[FFmpeg-devel] [PATCH 1/2] avformat/url: check double dot is not directory

2020-07-24 Thread Steven Liu
fix ticket: 8814 if get double dot in the url, check next byte by double dot, it there have no '/', it is not directory double dot Signed-off-by: Steven Liu --- libavformat/url.c | 4 1 file changed, 4 insertions(+) diff --git a/libavformat/url.c b/libavformat/url.c index 20463a6674

[FFmpeg-devel] [PATCH v2 1/2] avformat/hls: support avio_seek in encryption mode

2020-07-22 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index ba17c4ed96..5bc775cd8b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1291,7 +1291,7 @@ static int open_input(HLSContext *c

[FFmpeg-devel] [PATCH v2 2/2] avformat/hlsenc: write temp file for append single file by encryption mode

2020-07-22 Thread Steven Liu
the temp file content into append to single file, then hlsenc can get the correct file/content size and offset. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 70 ++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: write temp file for append single file by encryption mode

2020-07-22 Thread Steven Liu
the temp file content into append to single file, then hlsenc can get the correct file/content size and offset. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 70 ++-- 1 file changed, 68 insertions(+), 2 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/hls: support avio_seek in encryption mode

2020-07-22 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hls.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index ba17c4ed96..5bc775cd8b 100644 --- a/libavformat/hls.c +++ b/libavformat/hls.c @@ -1291,7 +1291,7 @@ static int open_input(HLSContext *c

Re: [FFmpeg-devel] [PATCH] avformat/hls: add supporting EXT-X-DISCONTINUITY tag

2020-07-19 Thread Steven Liu
김동원님(Dongwon Kim) 于2020年7月17日周五 上午8:43写道: > > Signed-off-by: Dongwon Kim > --- > libavformat/hls.c | 4 +++- > 1 file changed, 3 insertions(+), 1 deletion(-) > > diff --git a/libavformat/hls.c b/libavformat/hls.c index > ba17c4ed96..5e331ab68f 100644 > --- a/libavformat/hls.c > +++

Re: [FFmpeg-devel] [PATCH 2/3] lavf/hls: enable custom interrup callback in sub-demuxer

2020-07-19 Thread Steven Liu
Jun Zhao 于2020年7月18日周六 下午7:56写道: > > From: Jun Zhao > > Enable the custom callback in sub-demuxer > > Signed-off-by: Jun Zhao > --- > libavformat/hls.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/hls.c b/libavformat/hls.c > index ba17c4e..cf0b71d 100644 > ---

Re: [FFmpeg-devel] [PATCH 3/3] lavf/dashdec: enable custom interrup callback in sub-demuxer

2020-07-19 Thread Steven Liu
Jun Zhao 于2020年7月18日周六 下午8:19写道: > > From: Jun Zhao > > Enable the custom callback in sub-demuxer > > Signed-off-by: Jun Zhao > --- > libavformat/dashdec.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c > index 694782c..c5a5ff6 100644 >

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: increase initial program date time precision

2020-07-19 Thread Steven Liu
Zhao Zhili 于2020年7月19日周日 下午6:26写道: > > > > > On Jul 19, 2020, at 5:20 PM, Steven Liu wrote: > > > > Marton Balint 于2020年7月19日周日 上午6:04写道: > >> > >> Also query time only once, not for every variant stream, otherwise variant > >> streams mi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: increase initial program date time precision

2020-07-19 Thread Steven Liu
Marton Balint 于2020年7月19日周日 上午6:04写道: > > Also query time only once, not for every variant stream, otherwise variant > streams might get a slightly different initial program date time. And we can > set this unconditionally because HLS_PROGRAM_DATE_TIME flag is checked > elsewhere. > >

Re: [FFmpeg-devel] [PATCH v2] avformat/crypto.c: remove unnecessary code

2020-07-15 Thread Steven Liu
Tomas Härdin 于2020年7月14日周二 下午4:48写道: > > tis 2020-07-14 klockan 14:23 +0800 skrev Steven Liu: > > Because the newpos variable is set value before use it. > > The newpos variable declared at the head partition of crypto_seek. > > Make the code clean. > >

Re: [FFmpeg-devel] [RFC][GSoC][PATCH v1 4/6] ffplay: add an option to enable abr

2020-07-15 Thread Steven Liu
Hongcheng Zhong 于2020年7月15日周三 下午4:38写道: > > From: spartazhc > > Add abr option, ffplay can play hls using abr by: > ffplay -i http://xxx/master.m3u8 -abr > > Structure ABRList is added to save stream type and index, it is > used to allow packet_queue_put function to put pkt which from same >

Re: [FFmpeg-devel] [RFC][GSoC][PATCH v1 5/6] avformat/utils: add av_packet_buffer_filter to filter packet_buffer

2020-07-15 Thread Steven Liu
Hongcheng Zhong 于2020年7月15日周三 下午4:38写道: > > From: spartazhc > > Add av_packet_buffer_filter to remove AVPackets whose stream_index is not > in st_index list. st_index has length of AVMEDIA_TYPE_NB, contains > the stream_index of all these media types. > > Generally s->internal->packet_buffer may

Re: [FFmpeg-devel] [RFC][GSoC][PATCH v1 3/6] avformat/hls: use abr to switch streams

2020-07-15 Thread Steven Liu
Hongcheng Zhong 于2020年7月15日周三 下午4:38写道: > > From: spartazhc > > When abr is enable, it will take over the task to call http to > download segments, and will return a switch-request for hls to > switch streams. > For reason not to waste segments that have been downloaded, > switch will become

Re: [FFmpeg-devel] [RFC][GSoC][PATCH v1 1/6] avformat/abr: Adaptive Bitrate support

2020-07-15 Thread Steven Liu
Hongcheng Zhong 于2020年7月15日周三 下午4:37写道: > > From: spartazhc > > Add abr module for hls/dash. > > v1 fixed: > 1. add an "ff" prefix to the protocol name to mark it internal. > 2. use 1.2f for float constant 1.2. > 3. simplify abr_seek for we just need AVSEEK_SIZE only. > > Signed-off-by:

[FFmpeg-devel] [PATCH v2] avformat/crypto.c: remove unnecessary code

2020-07-14 Thread Steven Liu
Because the newpos variable is set value before use it. The newpos variable declared at the head partition of crypto_seek. Make the code clean. Signed-off-by: Steven Liu --- libavformat/crypto.c | 12 1 file changed, 4 insertions(+), 8 deletions(-) diff --git a/libavformat

[FFmpeg-devel] [PATCH] avformat/crypto.c: remove unnecessary code

2020-07-11 Thread Steven Liu
Because the newpos variable is set value before use it. The newpos variable declared at the head partition of crypto_seek. Signed-off-by: Steven Liu --- libavformat/crypto.c | 11 --- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/libavformat/crypto.c b/libavformat

[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: use VariantStream basename when use output single file mode

2020-07-10 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index df84e6487d..1d816a61e6 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1723,7 +1723,7 @@ static int hls_start

[FFmpeg-devel] [PATCH 2/2] avformat/hlsenc: support single file mode encryption

2020-07-10 Thread Steven Liu
fix ticket: 8783 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 9 + 1 file changed, 9 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 1d816a61e6..cce6b2faa5 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1722,6 +1722,15 @@ static

Re: [FFmpeg-devel] [PATCH] [GSoC 3/6] avformat/hls: use abr to switch streams

2020-07-06 Thread Steven Liu
Hongcheng Zhong 于2020年7月5日周日 下午7:35写道: > > From: spartazhc > > When abr is enable, it will take over the task to call http to > download segments, and will return a switch-request for hls to > switch streams. > For reason not to waste segments that have been downloaded, > switch will become

Re: [FFmpeg-devel] [PATCH] [GSoC 1/6] avformat/abr: Adaptive Bitrate support

2020-07-06 Thread Steven Liu
Hongcheng Zhong 于2020年7月5日周日 下午7:35写道: > > From: spartazhc > > Add abr module for hls/dash. > > Signed-off-by: spartazhc > --- > doc/protocols.texi | 7 + > libavformat/Makefile| 1 + > libavformat/abr.c | 282 >

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: Remove duplicate close of the output stream.

2020-07-05 Thread Steven Liu
Andrey Semashev 于2020年7月5日周日 下午8:25写道: > > Ping? > > On 2020-07-01 17:59, Andrey Semashev wrote: > > The result of the first close attempt is ignored and may be lost. By > > removing > > it we ensure the close result code is properly analyzed. > > --- > > libavformat/hlsenc.c | 1 - > > 1

Re: [FFmpeg-devel] [PATCH 2/3] lavf/hls: Add missed side data/disposition

2020-06-18 Thread Steven Liu
> 在 2020年6月4日,22:12,Jun Zhao 写道: > > From: vacingfang > > hls demuxer get the strem info form sub-stream, but missed sida > data/disposition part, e,g, missed the DOVI sida data when the > stream is Dolby Vision streams. > > Signed-off-by: vacingfang > --- > libavformat/hls.c | 14

[FFmpeg-devel] [PATCH v2 2/2] tests/fate/hlsenc: add testcase of ac3 surround sound input in hlsenc

2020-06-15 Thread Steven Liu
add probeaudiostream for get audio stream's codec_name,codec_time_base, sample_fmt,channels and channel_layout. Signed-off-by: Steven Liu --- tests/fate-run.sh | 4 tests/fate/hlsenc.mak | 14 +- tests/ref/fate/hls-fmp4_ac3 | 9 + 3 files changed, 26

[FFmpeg-devel] [PATCH v2 1/2] avformat/hlsenc: check fragment size plus start_pos large than hls_segment_size

2020-06-15 Thread Steven Liu
if vs->size + vs->start_pos > hls->max_seg_size, should split segment. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 71fa3db060..ca2e1bb4a8 100644 --- a

[FFmpeg-devel] [PATCH 2/2] tests/fate/hlsenc: add testcase of ac3 surround sound input in hlsenc

2020-06-15 Thread Steven Liu
add probeaudiostream for get audio stream's codec_name,codec_time_base, sample_fmt,channels and channel_layout. Signed-off-by: Steven Liu --- tests/fate-run.sh | 4 tests/fate/hlsenc.mak | 14 +- 2 files changed, 17 insertions(+), 1 deletion(-) diff --git a/tests/fate

[FFmpeg-devel] [PATCH 1/2] avformat/hlsenc: check fragment size plus start_pos large than hls_segment_size

2020-06-15 Thread Steven Liu
if vs->size + vs->start_pos > hls->max_seg_size, should split segment. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 7 --- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 71fa3db060..ca2e1bb4a8 100644 --- a

[FFmpeg-devel] [PATCH] avformat/hls: check segment duration value of EXTINF

2020-05-28 Thread Steven Liu
fix ticket: 8673 set the default EXTINF duration to 1ms if duration is smaller than 1ms Signed-off-by: Steven Liu --- libavformat/hls.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3e35d157ad..8c4126b880 100644

Re: [FFmpeg-devel] aubmit Verisilicon VPE hardware codec implementation

2020-05-28 Thread Steven Liu
Zhang, Guiyong 于2020年5月28日周四 上午10:12写道: > > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject

[FFmpeg-devel] [PATCH 1/2] avformat/url: check return value of strchr

2020-05-27 Thread Steven Liu
fix ticket: 8687 workflow should return if there have no value of strchr Signed-off-by: Steven Liu --- libavformat/url.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/url.c b/libavformat/url.c index 6956f6dc10..20463a6674 100644 --- a/libavformat/url.c +++ b/libavformat

[FFmpeg-devel] [PATCH 2/2] avformat/hls: check output string is usable of ff_make_absolute_url

2020-05-27 Thread Steven Liu
fix ticket: 8688 should goto failed workflow if cannot get usable string by ff_make_absolute_url Signed-off-by: Steven Liu --- libavformat/hls.c | 23 +++ 1 file changed, 23 insertions(+) diff --git a/libavformat/hls.c b/libavformat/hls.c index 3e35d157ad..a9592dea5e 100644

Re: [FFmpeg-devel] [PATCH 1/4] avformat/hlsplaylist: Add const where appropriate

2020-05-27 Thread Steven Liu
const char *baseurl /* Ignored if NULL */, > +const char *filename, double *prog_date_time, > int64_t video_keyframe_size, int64_t > video_keyframe_pos, int iframe_mode); > void ff_hls_write_end_list (AVIOContext *out); &

Re: [FFmpeg-devel] [PATCH 3/3] lavf/dashdec: avoid reading the first data segment in read_header

2020-05-22 Thread Steven Liu
pb; > pls->ctx->io_open = nested_io_open; > > +if (pls->init_sec_data_len > 0) > +av_dict_set_int(_fmt_opts, "header_size", pls->init_sec_data_len, > 0); > + > // provide additional information from mpd if available > r

Re: [FFmpeg-devel] [PATCH] avformat/url: check the result of the strrchr

2020-05-17 Thread Steven Liu
> 2020年5月17日 上午10:35,Steven Liu 写道: > > > >> 2020年5月15日 下午6:26,Steven Liu 写道: >> >> >> >>> 2020年5月15日 下午6:01,Steven Liu 写道: >>> >>> because it need be check for success, is should not >>> change the old w

Re: [FFmpeg-devel] [PATCH] avformat/url: check the result of the strrchr

2020-05-16 Thread Steven Liu
> 2020年5月15日 下午6:26,Steven Liu 写道: > > > >> 2020年5月15日 下午6:01,Steven Liu 写道: >> >> because it need be check for success, is should not >> change the old way if it failure. > Change the comments: > because it need be checked for success

Re: [FFmpeg-devel] [PATCH] avformat/hls: check target duration in the playlist

2020-05-16 Thread Steven Liu
> 2020年5月16日 下午8:21,Carl Eugen Hoyos 写道: > > Am Sa., 16. Mai 2020 um 14:12 Uhr schrieb Steven Liu : >> >> fix ticket: 8673 >> reference rfc8216 4.3.3.1 said: >> The EXT-X-TARGETDURATION tag is REQUIRED. > >> in ticket 8673, the EXT-X-TARGETDURATION i

[FFmpeg-devel] [PATCH] avformat/hls: check target duration in the playlist

2020-05-16 Thread Steven Liu
fix ticket: 8673 reference rfc8216 4.3.3.1 said: The EXT-X-TARGETDURATION tag is REQUIRED. in ticket 8673, the EXT-X-TARGETDURATION is incorrect, so hls should return error. Signed-off-by: Steven Liu --- libavformat/hls.c | 7 +++ 1 file changed, 7 insertions(+) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH] avformat/url: check the result of the strrchr

2020-05-15 Thread Steven Liu
Steven Liu 于2020年5月15日周五 下午6:02写道: > > because it need be check for success, is should not > change the old way if it failure. Change the comments: because it need be checked for success status, it should not change the old way if it failure. > > Signed-off-by: Steven Liu >

[FFmpeg-devel] [PATCH] avformat/url: check the result of the strrchr

2020-05-15 Thread Steven Liu
because it need be check for success, is should not change the old way if it failure. Signed-off-by: Steven Liu --- libavformat/url.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/url.c b/libavformat/url.c index 7cd9e0c705..6956f6dc10 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH 5/6] avformat/hlsenc: Simplify setting basename with av_asprintf()

2020-05-09 Thread Steven Liu
(vs->basename, pattern, basename_size); > -} > +*p = '.'; > } > > if (hls->segment_type == SEGMENT_TYPE_FMP4) { > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". LGTM Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 4/6] avformat/hlsenc: Simplify setting subtitle basename with av_asprintf

2020-05-09 Thread Steven Liu
trlcat(vs->vtt_basename, vtt_pattern, vtt_basename_size); > +if (p) > + *p = '.'; > } > > if (hls->baseurl) { > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 6/6] avformat/hlsenc: Simplify setting base_output_dirname

2020-05-09 Thread Steven Liu
rname) > + return AVERROR(ENOMEM); > } > } > > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". LGTM Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH 2/6] avformat/hlsenc: Remove redundant initializations

2020-05-09 Thread Steven Liu
> -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject

Re: [FFmpeg-devel] [PATCH 3/6] avformat/hlsenc: Don't cast const away

2020-05-09 Thread Steven Liu
ARATOR, > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "

Re: [FFmpeg-devel] [PATCH 1/6] avformat/hlsenc: Don't reset AVIOContext pointer manually a second time

2020-05-09 Thread Steven Liu
av_freep(_filename); > return ret; > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscri

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: move init file write code block to hls_write_header

2020-05-09 Thread Steven Liu
> 2020年5月10日 上午3:21,Andreas Rheinhardt 写道: > > Steven Liu: >> Signed-off-by: Steven Liu >> --- >> libavformat/hlsenc.c | 37 - >> 1 file changed, 20 insertions(+), 17 deletions(-) >> >> diff --git a/libavfo

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-05-08 Thread Steven Liu
> 2020年5月8日 下午7:07,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年4月9日 下午8:58,Andreas Rheinhardt 写道: >>> >>> Steven Liu: >>>> >>>> >>>>> 2020年4月9日 下午5:55,Steven Liu 写道: >>

[FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: free options fix memleak in hls_write_trailer

2020-05-08 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 307aba2efa..eb12b4a7f8 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2679,9 +2679,10 @@ static int

[FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: move number out of hls_start

2020-05-08 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 6 ++ 1 file changed, 2 insertions(+), 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index a1eddade7b..bcc67b1159 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -1679,7 +1679,6 @@ static int

[FFmpeg-devel] [PATCH 2/3] avformat/hlsenc: fix filename memleak in hls_write_packet

2020-05-08 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index bcc67b1159..307aba2efa 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2447,6 +2447,7 @@ static int hls_write_packet

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: compute the segment size use current pos minus offset plus one

2020-05-07 Thread Steven Liu
> 2020年5月6日 下午3:09,myp...@gmail.com 写道: > > On Wed, May 6, 2020 at 2:53 PM Steven Liu wrote: >> >> because the offset should use one byte >> >> Reported-by: Zhao Jun > >> Signed-off-by: Steven Liu >> --- >> libavformat/dashdec.

[FFmpeg-devel] [PATCH] avformat/hlsenc: move init file write code block to hls_write_header

2020-05-07 Thread Steven Liu
Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 37 - 1 file changed, 20 insertions(+), 17 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 5695c6cc95..a1eddade7b 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c

[FFmpeg-devel] [PATCH] avformat/dashdec: compute the segment size use current pos minus offset plus one

2020-05-06 Thread Steven Liu
because the offset should use one byte Reported-by: Zhao Jun > Signed-off-by: Steven Liu --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 5ba7feb245..04a1baea15 100644 --- a/libavformat/dashde

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: Improve checks for invalid stream mappings

2020-05-05 Thread Steven Liu
for (i = 0; nb_streams > 0 && i < nb_streams; i++) { > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". LGTM Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] lavf/dashdec: support larger manifests

2020-05-04 Thread Steven Liu
lose_in) { > avio_close(in); > } > -- > 2.24.1 > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". LGTM Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH] avformat/hlsenc: resend full url of the init fragment mp4

2020-05-03 Thread Steven Liu
fix ticket: 8651 because the init fragment mp4 file name is without base url name, so just modify it use the full url which splice after init function. Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b

Re: [FFmpeg-devel] [PATCH v5] avformat/url: check url root node when rel include double dot and trim double dot

2020-05-01 Thread Steven Liu
> 2020年4月29日 下午12:50,Steven Liu 写道: > > fix ticket: 8625 > and add testcase into url for double dot corner case > > Signed-off-by: Steven Liu > --- > libavformat/tests/url.c | 5 +++ > libavformat/url.c | 77 ++--- >

Re: [FFmpeg-devel] [PATCH 0/1] avformat hls check discard state of streams always

2020-05-01 Thread Steven Liu
e changed, 3 insertions(+), 3 deletions(-) > > -- > 2.24.2 (Apple Git-127) > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit lin

Re: [FFmpeg-devel] [PATCH 1/1] avformat hls restore options dict when retrying with a new connection

2020-04-30 Thread Steven Liu
devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". LGTM Thanks Steven Liu ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH] libavformat/hlsenc: Allow usage of 'periodic-rekey' with multi-variant streams

2020-04-30 Thread Steven Liu
AVFormatContext *s) > return AVERROR(ENOMEM); > } > if (hls->key_info_file || hls->encrypt) { > -av_dict_set(, "encryption_key", hls->key_string, 0); > -av_dict_set(, "encryption_iv", hls->iv_stri

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add support for microseconds since epoch based sequence number

2020-04-29 Thread Steven Liu
0,E}, >> diff --git a/libavformat/version.h b/libavformat/version.h >> index 18c2f5fec2..719cda6b98 100644 >> --- a/libavformat/version.h >> +++ b/libavformat/version.h >> @@ -33,7 +33,7 @@ >> // Also please add any ticket numbers that you believe migh

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: compute segment duration use current pts minus last segment end pts

2020-04-29 Thread Steven Liu
-by: Steven Liu --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d75684741f..4a83db04e9 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2460,7 +2460,8 @@ static int hls_write_packet

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: compute segment duration use current pts minus last segment end pts

2020-04-29 Thread Steven Liu
> 2020年4月29日 下午3:07,myp...@gmail.com 写道: > > On Wed, Apr 29, 2020 at 12:44 PM Steven Liu wrote: >> >> segment duration is using vs duration which compute by frame per second, >> that can not fix problem of VFR video stream, so compute the duration >> when s

[FFmpeg-devel] [PATCH v5] avformat/url: check url root node when rel include double dot and trim double dot

2020-04-28 Thread Steven Liu
fix ticket: 8625 and add testcase into url for double dot corner case Signed-off-by: Steven Liu --- libavformat/tests/url.c | 5 +++ libavformat/url.c | 77 ++--- tests/ref/fate/url | 5 +++ 3 files changed, 83 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH] avformat/hlsenc: compute segment duration use current pts minus last segment end pts

2020-04-28 Thread Steven Liu
-by: Zhao Jun Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index d75684741f..9e8b34d83c 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2460,7 +2460,8 @@ static

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_fmp4_init_refresh option

2020-04-28 Thread Steven Liu
Ignore this patch please. > 2020年4月29日 下午12:33,Steven Liu 写道: > > add option for refresh init file after m3u8 refresh everytime. > > Reported-by: Zhao Jun > Signed-off-by: Steven Liu > --- > doc/muxers.texi | 3 +++ >

[FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_fmp4_init_refresh option

2020-04-28 Thread Steven Liu
add option for refresh init file after m3u8 refresh everytime. Reported-by: Zhao Jun Signed-off-by: Steven Liu --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 41 - 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/doc/muxers.texi

[FFmpeg-devel] [PATCH v4] avformat/url: check url root node when rel include double dot and trim double dot

2020-04-28 Thread Steven Liu
fix ticket: 8625 and add testcase into url for double dot corner case Signed-off-by: Steven Liu --- libavformat/tests/url.c | 5 +++ libavformat/url.c | 80 ++--- tests/ref/fate/url | 5 +++ 3 files changed, 86 insertions(+), 4 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:35,Nicolas George 写道: > > Steven Liu (12020-04-27): >> I need one example to understand about the security issue after this patch. > > Use ff_make_absolute_url() on a trusted base and an un-trusted path; > check the result starts with the allowed

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:22,Nicolas George 写道: > > Steven Liu (12020-04-27): >> /../../../../../other/url, this is the absolute path, so just concat and >> don’t process, >> Or what do you want to say? > > This is not an absolute path, since it contain

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:14,Nicolas George 写道: > > Steven Liu (12020-04-27): >> fix ticket: 8625 >> and add testcase into url for double dot corner case >> >> Signed-off-by: Steven Liu >> --- >> libavformat/tests/url.c | 3 +++ >> libavformat/url.c

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:10,Nicolas George 写道: > > Steven Liu (12020-04-27): >> Do you mean you don’t want in the cc list? >> I think can remove you from cc list if you don’t want in it. > > I want you to do exactly as the headers direct you to do. Inner p

[FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
fix ticket: 8625 and add testcase into url for double dot corner case Signed-off-by: Steven Liu --- libavformat/tests/url.c | 3 +++ libavformat/url.c | 21 +++-- tests/ref/fate/url | 3 +++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
t. > > Regards, > > -- > Nicolas George Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

<    1   2   3   4   5   6   7   8   9   10   >