Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: set the options when open the key info files

2020-03-06 Thread Steven Liu
> 2020年3月7日 上午11:06,Andreas Rheinhardt 写道: > > Steven Liu: >> make the options same as segments for the http put method >> >> Signed-off-by: Steven Liu >> --- >> libavformat/hlsenc.c | 11 --- >> 1 file changed, 8 insertions(+), 3 deletion

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: set the options when open the key info files

2020-03-06 Thread Steven Liu
make the options same as segments for the http put method Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 18 ++ 1 file changed, 14 insertions(+), 4 deletions(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index f6dd894343..4b28c412fa 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: set the options when open the key info files

2020-03-06 Thread Steven Liu
> 2020年3月7日 上午11:51,Andreas Rheinhardt 写道: > > Steven Liu: >> make the options same as segments for the http put method >> >> Signed-off-by: Steven Liu >> --- >> libavformat/hlsenc.c | 18 ++ >> 1 file changed, 14 insertions(+), 4

Re: [FFmpeg-devel] Reimbursement request

2020-03-10 Thread Steven Liu
> 2020年3月10日 上午9:59,Lou Logan 写道: > > On Mon, Mar 9, 2020, at 5:49 PM, Carl Eugen Hoyos wrote: >> >> Given that travel to Germany is in no way restricted, I don't see how. > > There is no travel restriction in the US either, but here's what the main > airline in my region offers: > > * No ch

Re: [FFmpeg-devel] Reimbursement request

2020-03-10 Thread Steven Liu
> 2020年3月11日 上午2:02,Lou Logan 写道: > > On Tue, Mar 10, 2020, at 4:40 AM, Steven Liu wrote: >> >> Some travel ticket site can buy the cheapest ticket but cannot >> cancel it. > > In an off-list discussion he indicated that the process would be more > time c

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Fix initial setting for start_pts

2020-03-10 Thread Steven Liu
> 2020年3月7日 上午11:26,Steven Liu 写道: > > > >> 2020年3月6日 上午11:58,Hongcheng Zhong 写道: >> >> This patch fixes Bug #8469 >> If x264 baseline profile is used with other profiles, >> start_pts will be initialized to audio stream's first pts, >

[FFmpeg-devel] [PATCH] avformat/hlsenc: remove redundant hlsenc_io_close in hls_write_trailer

2020-03-11 Thread Steven Liu
fix ticket: 8566 Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 1 - 1 file changed, 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index 4b28c412fa..75e75ff57a 100644 --- a/libavformat/hlsenc.c +++ b/libavformat/hlsenc.c @@ -2587,7 +2587,6 @@ static int

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: remove redundant hlsenc_io_close in hls_write_trailer

2020-03-11 Thread Steven Liu
> 2020年3月12日 上午11:02,Steven Liu 写道: > > fix ticket: 8566 > > Signed-off-by: Steven Liu > --- > libavformat/hlsenc.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c > index 4b28c412fa..75e75ff57a 100644 >

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: Fix initial setting for start_pts

2020-03-11 Thread Steven Liu
> 2020年3月11日 上午7:06,Steven Liu 写道: > >> >> 2020年3月7日 上午11:26,Steven Liu 写道: >> >> >> >>> 2020年3月6日 上午11:58,Hongcheng Zhong 写道: >>> >>> This patch fixes Bug #8469 >>> If x264 baseline profile is used with other

[FFmpeg-devel] [PATCH] web/generate-doc.sh: fix generate-doc warning for configure ffmpeg part

2020-03-12 Thread Steven Liu
Signed-off-by: Steven Liu --- generate-doc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generate-doc.sh b/generate-doc.sh index d8d01d3..e316c05 100755 --- a/generate-doc.sh +++ b/generate-doc.sh @@ -34,7 +34,7 @@ export FA_ICONS=true rm -rf build-doc mkdir build

[FFmpeg-devel] [PATCH v2] web/generate-doc.sh: use --enable-x86asm instead of --disable-yasm

2020-03-13 Thread Steven Liu
Reviewed-by: Lou Logan Signed-off-by: Steven Liu --- generate-doc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generate-doc.sh b/generate-doc.sh index d8d01d3..e316c05 100755 --- a/generate-doc.sh +++ b/generate-doc.sh @@ -34,7 +34,7 @@ export FA_ICONS=true rm -rf

Re: [FFmpeg-devel] [PATCH v2] web/generate-doc.sh: use --enable-x86asm instead of --disable-yasm

2020-03-14 Thread Steven Liu
> 2020年3月14日 下午3:08,Hendrik Leppkes 写道: > > On Sat, Mar 14, 2020 at 2:37 AM Steven Liu wrote: >> >> Reviewed-by: Lou Logan >> Signed-off-by: Steven Liu >> --- >> generate-doc.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >>

[FFmpeg-devel] [PATCH v3] web/generate-doc.sh: use --disable-x86asm instead of --disable-yasm

2020-03-14 Thread Steven Liu
Reviewed-by: Lou Logan Signed-off-by: Steven Liu --- generate-doc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generate-doc.sh b/generate-doc.sh index d8d01d3..2da5e64 100755 --- a/generate-doc.sh +++ b/generate-doc.sh @@ -34,7 +34,7 @@ export FA_ICONS=true rm -rf

Re: [FFmpeg-devel] [PATCH v3] web/generate-doc.sh: use --disable-x86asm instead of --disable-yasm

2020-03-14 Thread Steven Liu
> 2020年3月14日 下午6:58,Carl Eugen Hoyos 写道: > > Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu : >> >> Reviewed-by: Lou Logan >> Signed-off-by: Steven Liu >> --- >> generate-doc.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) &

Re: [FFmpeg-devel] [PATCH v3] web/generate-doc.sh: use --disable-x86asm instead of --disable-yasm

2020-03-14 Thread Steven Liu
> 2020年3月14日 下午6:58,Carl Eugen Hoyos 写道: > > Am Sa., 14. März 2020 um 09:08 Uhr schrieb Steven Liu : >> >> Reviewed-by: Lou Logan >> Signed-off-by: Steven Liu >> --- >> generate-doc.sh | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) &

[FFmpeg-devel] [PATCH v4] web/generate-doc.sh: use --disable-asm instead of --disable-yasm

2020-03-14 Thread Steven Liu
Suggested-by: Carl Eugen Hoyos Reviewed-by: Lou Logan Signed-off-by: Steven Liu --- generate-doc.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/generate-doc.sh b/generate-doc.sh index d8d01d3..45a9901 100755 --- a/generate-doc.sh +++ b/generate-doc.sh @@ -34,7 +34,7

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-16 Thread Steven Liu
> 2020年3月14日 上午3:14,Andreas Rheinhardt 写道: > > Since commit e134c203 strdups of several elements of a manifest are kept > in the DASHContext; but said commit completely forgot to free these > strings again (with xmlFree()). Given that these strings are never used > at all, this commit closes th

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-16 Thread Steven Liu
> 2020年3月16日 下午9:19,Nicolas George 写道: > > Steven Liu (12020-03-16): >> No this is used for fix some problem about full specification support, >> you can fix the memleak but I don’t think remove them is a good way. > > How can they fix a problem if they are un

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-16 Thread Steven Liu
> 2020年3月16日 下午9:26,Nicolas George 写道: > > Steven Liu (12020-03-16): >>> How can they fix a problem if they are unused? >> As Andreas said, just xmlFree them at the end of the parse method is ok, >> I think i will use them for full support do that if you guys

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-16 Thread Steven Liu
> 2020年3月16日 下午9:32,Nicolas George 写道: > > Steven Liu (12020-03-16): >> Let me do it now, don’t remove the code, ok? >> Keep the code now or add xmlFree them. > > There is a leak right now, and adding the xmlFree() is more work than > reverting. > > A

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-16 Thread Steven Liu
> 2020年3月16日 下午9:42,Nicolas George 写道: > > Steven Liu (12020-03-16): >> I think you can rewrite a dashdec if you have interested in it, there >> have lots of bug in it, ok? >> I don’t think just remove some code for it is a good idea, if you want >> to do s

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-16 Thread Steven Liu
> 2020年3月16日 下午9:48,Nicolas George 写道: > > Steven Liu (12020-03-16): >> Patch welcome for rewrite dashdec. > > Irrelevant. This particular commit is bad in and by itself. That's what > happens when you push without review. That is not without review, that is all

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-16 Thread Steven Liu
> 2020年3月16日 下午9:54,Nicolas George 写道: > > Steven Liu (12020-03-16): >> That is not without review, that is all of you have no interested in >> it, and I’m the maintainer of it. >> So I know what I want to do. > > This commit was bad. Take your responsibiliti

[FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-16 Thread Steven Liu
These member will be used for get more correct information of the MPD Signed-off-by: Steven Liu --- libavformat/dashdec.c | 134 +- 1 file changed, 107 insertions(+), 27 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-18 Thread Steven Liu
Thanks Steven Liu > 2020年3月19日 上午12:48,Andreas Rheinhardt 写道: > > Hello, > > before the actual review I want to tell you that I actually agree with > Nicholas. I don't see the point of already parsing stuff that is not > used yet, especially if it involves alloc

[FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-19 Thread Steven Liu
These member will be used for get more correct information of the MPD Suggested-by: Andreas Rheinhardt Suggested-by: Nicolas George Signed-off-by: Steven Liu --- libavformat/dashdec.c | 180 +++--- 1 file changed, 151 insertions(+), 29 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Steven Liu
> 2020年3月20日 下午4:34,Anton Khirnov 写道: > > Quoting Steven Liu (2020-03-19 00:30:52) >> >> Thanks >> >> Steven Liu >> >>> 2020年3月19日 上午12:48,Andreas Rheinhardt 写道: >>> >>> Hello, >>> >>> before the actua

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Steven Liu
> 2020年3月20日 下午6:51,Nicolas George 写道: > > Steven Liu (12020-03-20): >> Why the specification add these attributes into the documents if these >> attributes not useful, just kidding? >> I said I’m not the specification author. > > What Anton and I are trying

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Steven Liu
> 2020年3月20日 下午7:05,Nicolas George 写道: > > Steven Liu (12020-03-20): >> Do you mean, > > I mean you should only propose code that actually does something. That > should be easy to understand: if you store into a variable without using > the value, remove it;

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Steven Liu
> 2020年3月20日 下午7:19,Nicolas George 写道: > > Steven Liu (12020-03-20): >> These member will be used for get more correct information of the MPD >> >> Suggested-by: Andreas Rheinhardt >> Suggested-by: Nicolas George >> Signed-off-by: Steven Liu

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-20 Thread Steven Liu
t in mpd, the result maybe does not >> accord with the expected result. >> User should check the mpd file content is correct. > > Which user knows about the mpd? I think you are right , let me think how to do it. Thanks Steven Liu

Re: [FFmpeg-devel] [PATCH 2/2] avformat/hls: Don't strdup non-null-terminated string

2020-03-21 Thread Steven Liu
info->uri; >> } else { >> ff_make_absolute_url(tmp_str, sizeof(tmp_str), url_base, info->uri); >> } >> -sec->url = av_strdup(tmp_str); >> +sec->url = av_strdup(ptr); >> if (!sec->url) { >> av_free(sec); >

Re: [FFmpeg-devel] [PATCH 4/4] avfilter/vf_derain.c: put all the calculation in model file.

2020-03-22 Thread Steven Liu
ad_size * 3; > -out->data[0][k] = CLIP((int)float > *)dr_context->input.data)[t_in] - ((float *)dr_context->output.data)[t]) * > 255), 0, 255); > +out->data[0][k] = CLIP((int)float > *)dr_context->output.data)[t]) * 255), 0, 255)

[FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-23 Thread Steven Liu
These member will be used for get more correct information of the MPD Suggested-by: Andreas Rheinhardt Suggested-by: Nicolas George Signed-off-by: Steven Liu --- libavformat/dashdec.c | 244 -- 1 file changed, 214 insertions(+), 30 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-26 Thread Steven Liu
> 2020年3月26日 下午11:46,Nicolas George 写道: > > Steven Liu (12020-03-24): >> These member will be used for get more correct information of the MPD >> >> Suggested-by: Andreas Rheinhardt >> Suggested-by: Nicolas George >> Signed-off-by: Steven Liu

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-27 Thread Steven Liu
> 2020年3月28日 上午9:37,Andreas Rheinhardt 写道: > > Steven Liu: >> These member will be used for get more correct information of the MPD >> >> Suggested-by: Andreas Rheinhardt >> Suggested-by: Nicolas George >> Signed-off-by: Steven Liu

Re: [FFmpeg-devel] [PATCH v3] avformat/dashdec: fix memleak for commit commit e134c203

2020-03-27 Thread Steven Liu
> 2020年3月28日 上午10:15,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月28日 上午9:37,Andreas Rheinhardt 写道: >>> >>> Steven Liu: >>>> These member will be used for get more correct information of the MPD >>>>

Re: [FFmpeg-devel] [PATCH v3 3/3] libavcodec/jpeb2000dec.c: Handle non EOC streams

2020-03-27 Thread Steven Liu
t; comments. > > -- > ----- > Gautam | > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v4 2/2] avformat/dashdec: refine adaptionset attribute members

2020-03-28 Thread Steven Liu
all the members is used check all the representation useable. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 203 +- 1 file changed, 199 insertions(+), 4 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 271202b0a5

[FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. Signed-off-by: Steven Liu --- libavformat/dashdec.c | 27 --- 1 file changed, 27 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index 5bbe5d3985..271202b0a5 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: > > Steven Liu: >> This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. >> >> Signed-off-by: Steven Liu >> --- >> libavformat/dashdec.c | 27 --- >> 1 file changed, 27

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >>> >>> Steven Liu: >>>> This reverts commit e134c20374ee3cbc6d04885d306b02c9871683a2. >>>>

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:05,Steven Liu 写道: > > >> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> >>>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >>>> >>>> Steven Liu: >>>>> This

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:12,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: >>> >>> Steven Liu: >>>> >>>> >>>>> 2020年3月29日 上午7:48,Andreas Rheinhardt 写道: >&

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:20,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:05,Steven Liu 写道: >>> >>> >>>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: >>>> >>>> Steven Liu: >>>>&g

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:24,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:12,Andreas Rheinhardt 写道: >>> >>> Steven Liu: >>>> >>>> >>>>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: &g

Re: [FFmpeg-devel] [PATCH v4 1/2] Revert "avformat/dashdec: refine adaptionset attribute members"

2020-03-28 Thread Steven Liu
> 2020年3月29日 上午8:24,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年3月29日 上午8:12,Andreas Rheinhardt 写道: >>> >>> Steven Liu: >>>> >>>> >>>>> 2020年3月29日 上午8:03,Andreas Rheinhardt 写道: &g

Re: [FFmpeg-devel] [PATCH] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-28 Thread Steven Liu
tionset_node, > "bitstreamSwitching"); > > node = xmlFirstElementChild(adaptionset_node); > while (node) { > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailm

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: Don't allocate and leak strings that are never used

2020-03-28 Thread Steven Liu
itstreamswitching_val = xmlGetProp(adaptionset_node, > "bitstreamSwitching"); > > node = xmlFirstElementChild(adaptionset_node); > while (node) { > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-

[FFmpeg-devel] [PATCH] avformat/dashdec: add attribute lang for audio and subtitle streams

2020-03-28 Thread Steven Liu
There should have lang in the metadata of streams which show to user Signed-off-by: Steven Liu --- libavformat/dashdec.c | 49 +++ 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index

[FFmpeg-devel] [PATCH] avformat/hlsenc: skip first char after compare path with path separator

2020-03-28 Thread Steven Liu
vc1.640028,mp4a.40.2" /c0.m3u8 this is incorrect. after patch: #EXTM3U #EXT-X-VERSION:3 #EXT-X-STREAM-INF:BANDWIDTH=2890800,RESOLUTION=1920x800,CODECS="avc1.640028,mp4a.40.2" c0.m3u8 Reported-by: Ibrahim Tachijian Signed-off-by: Steven Liu --- libavformat

Re: [FFmpeg-devel] [PATCH v1 1/4] avformat/hlsenc: remove the first slash of the relative path line in the master m3u8 file

2020-03-29 Thread Steven Liu
return media_url + base_len + 1; > } > > static int64_t get_stream_bit_rate(AVStream *stream) > -- > 2.21.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [PATCH v1 2/4] avformat/hlsplaylist: simplify code for checking whether the string is empty

2020-03-29 Thread Steven Liu
ccgroup[0]) > avio_printf(out, ",CLOSED-CAPTIONS=\"%s\"", ccgroup); > avio_printf(out, "\n%s\n\n", filename); > } > -- > 2.21.0 > > _______ > ffmpeg-devel mailing list > ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v1 3/4] avformat: add subtitle support in master playlist m3u8

2020-03-29 Thread Steven Liu
const char *filename, char *language, int > name_id, int is_default); > +void ff_hls_write_subtitle_rendition(AVIOContext *out, char *sgroup, > + const char *filename, char *language, int > name_id, int is_default); > void ff_hls_write_stream_info(AVStream *st, AVIOContext *out, > int bandwidth, const char *filename, char > *agroup, > - char *codecs, char *ccgroup); > + char *codecs, char *ccgroup, char *sgroup); > void ff_hls_write_playlist_header(AVIOContext *out, int version, int > allowcache, > int target_duration, int64_t sequence, > uint32_t playlist_type, int iframe_mode); > -- > 2.21.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-03-29 Thread Steven Liu
-- > 2.21.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject &qu

[FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_fmp4_init_refresh option

2020-03-30 Thread Steven Liu
add option for refresh init file after m3u8 refresh everytime. Signed-off-by: Steven Liu --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 44 ++-- 2 files changed, 41 insertions(+), 6 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: add hls_fmp4_init_refresh option

2020-03-30 Thread Steven Liu
> 2020年3月31日 上午10:06,Andreas Rheinhardt 写道: > > Steven Liu: >> add option for refresh init file after m3u8 refresh everytime. >> >> Signed-off-by: Steven Liu >> --- >> doc/muxers.texi | 3 +++ >> libavformat/hlsenc.c | 44 ++

[FFmpeg-devel] [PATCH v2] avformat/dashdec: add attribute lang for audio and subtitle streams

2020-03-31 Thread Steven Liu
There should have language in the metadata of streams which show to user Signed-off-by: Steven Liu --- libavformat/dashdec.c | 49 +++ 1 file changed, 45 insertions(+), 4 deletions(-) diff --git a/libavformat/dashdec.c b/libavformat/dashdec.c index

Re: [FFmpeg-devel] [PATCH] avformat/matroskaenc: add matroska subtitle muxer (.mks)

2020-04-03 Thread Steven Liu
://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". Looks bad to me Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-06 Thread Steven Liu
add option for resend init file after m3u8 refresh everytime. Signed-off-by: Steven Liu --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 41 - 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

Re: [FFmpeg-devel] [PATCH v2] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-07 Thread Steven Liu
Ignore this patch please, I will submit v3 to modify all the refresh to resend. > 2020年4月7日 下午1:46,Steven Liu 写道: > > add option for resend init file after m3u8 refresh everytime. > > Signed-off-by: Steven Liu > --- > doc/muxers.texi | 3 +++ > l

[FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-07 Thread Steven Liu
add option for resend init file after m3u8 refresh everytime. Signed-off-by: Steven Liu --- doc/muxers.texi | 3 +++ libavformat/hlsenc.c | 41 - 2 files changed, 39 insertions(+), 5 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

Re: [FFmpeg-devel] [PATCH 3/3] avformat/hlsenc: Factor out deleting files from deleting segments

2020-04-08 Thread Steven Liu
ff_format_io_close(vs->vtt_avf, &out); > -} else if (unlink(path.str) < 0) { > -av_log(hls, AV_LOG_ERROR, "failed to delete old segment %s: > %s\n", > - path.str, strerror(errno)); > -} >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Fix memleak when deleting old segments

2020-04-08 Thread Steven Liu
_stream_idx) < 1) { > ret = AVERROR(EINVAL); > -- > 2.20.1 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link abo

Re: [FFmpeg-devel] [PATCH 2/3] avformat/hlsenc: Use AVBPrint to avoid allocations of strings

2020-04-08 Thread Steven Liu
sub_path, strerror(errno)); > + path.str, strerror(errno)); > } > -av_freep(&sub_path); > } > -av_freep(&path); > +av_bprint_clear(&path); > previous_segment = segment; >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/hlsenc: Fix memleak when deleting old segments

2020-04-08 Thread Steven Liu
+} else if (unlink(path.str) < 0) { > av_log(hls, AV_LOG_ERROR, "failed to delete old segment %s: > %s\n", > - sub_path, strerror(errno)); > + path.str, strerror(errno)); > } > -

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
ename, vtt_pattern, vtt_basename_size); > } > -- > 2.21.0 > > ___ > ffmpeg-devel mailing list > ffmpeg-devel@ffmpeg.org > https://ffmpeg.org/mailman/listinfo/ffmpeg-devel > > To unsubscribe, visit link above, or email &

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午10:32,Nicolas George 写道: > > Steven Liu (12020-04-08): >> As mkver suggestion, perhaps use bprint is better, is it? > > It does not seem like a situation where BPrint is beneficial. I cannot get the mean of BPrint where should or when should use it, maybe

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: add attribute lang for audio and subtitle streams

2020-04-08 Thread Steven Liu
> 2020年3月31日 下午8:20,Steven Liu 写道: > > There should have language in the metadata of streams which show to user > > Signed-off-by: Steven Liu > --- > libavformat/dashdec.c | 49 +++ > 1 file changed, 45 insertions(+), 4 deleti

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年4月8日 下午10:48,Nicolas George 写道: > > Steven Liu (12020-04-08): >> I cannot get the mean of BPrint where should or when should use it, maybe >> you can introduce it, >> I always think BPrint is used to instead of av_[a]sprintf, >> because I saw mkve

Re: [FFmpeg-devel] [PATCH v1 4/4] avformat/hlsenc: use av_asprintf()

2020-04-08 Thread Steven Liu
> 2020年3月29日 下午4:32,Steven Liu 写道: > > >> 2020年3月26日 下午9:57,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavformat/hlsenc.c | 4 +--- >> 1 file changed, 1 insertion(+), 3 deletions(

Re: [FFmpeg-devel] [PATCH v1 1/4] avformat/hlsenc: remove the first slash of the relative path line in the master m3u8 file

2020-04-08 Thread Steven Liu
> 2020年3月29日 下午4:20,Steven Liu 写道: > > >> 2020年3月26日 下午9:56,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Please testing with the following command: >> ./ffmpeg -y -i input.mkv \ >> -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profi

Re: [FFmpeg-devel] [PATCH v1 1/4] avformat/hlsenc: remove the first slash of the relative path line in the master m3u8 file

2020-04-08 Thread Steven Liu
> 2020年3月29日 下午4:20,Steven Liu 写道: > > >> 2020年3月26日 下午9:56,lance.lmw...@gmail.com 写道: >> >> From: Limin Wang >> >> Please testing with the following command: >> ./ffmpeg -y -i input.mkv \ >> -b:v:0 5250k -c:v h264 -pix_fmt yuv420p -profi

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-08 Thread Steven Liu
me, i, > vs->varname); > } else { > ret = append_postfix(vs->fmp4_init_filename, > fmp4_init_filename_len, i); > } > -- > 2.20.1 > > ___ > ffmpeg-de

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午4:49,Nicolas George 写道: > > Steven Liu (12020-04-09): >> It’s unnecessary here, >> I have checked all strdup return checker in hlsenc some month ago, and >> double check the workflow in update_master_pl_info, >> It's the safe whether you

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午5:33,Nicolas George 写道: > > Steven Liu (12020-04-09): >> I think every body have themselves reason to checking memory and remove the >> checking at here. >> Whatever for me you can add them here for somebody copy, other body remove >> them &

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: >>> >>> Signed-off-by: Andreas Rheinhardt >>> --- >>> libavformat/hlsenc.c | 13 - >>> 1 file

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午5:55,Steven Liu 写道: > > > >> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: >> >> Steven Liu: >>> >>> >>>> 2020年2月28日 下午5:53,Andreas Rheinhardt 写道: >>>> >>>> Signed-off-by: Andreas Rhein

Re: [FFmpeg-devel] [PATCH v2 3/7] avformat/hlsenc: Check some unchecked allocations

2020-04-09 Thread Steven Liu
> 2020年4月9日 下午8:58,Andreas Rheinhardt 写道: > > Steven Liu: >> >> >>> 2020年4月9日 下午5:55,Steven Liu 写道: >>> >>> >>> >>>> 2020年4月9日 下午5:48,Andreas Rheinhardt 写道: >>>> >>>> Steven Liu: >>

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: add attribute lang for audio and subtitle streams

2020-04-10 Thread Steven Liu
> 2020年4月8日 下午10:39,Steven Liu 写道: > > > >> 2020年3月31日 下午8:20,Steven Liu 写道: >> >> There should have language in the metadata of streams which show to user >> >> Signed-off-by: Steven Liu >> --- >> libavformat/dashdec.c | 49 +++

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-12 Thread Steven Liu
> 2020年4月7日 下午5:31,Steven Liu 写道: > > add option for resend init file after m3u8 refresh everytime. > > Signed-off-by: Steven Liu > --- > doc/muxers.texi | 3 +++ > libavformat/hlsenc.c | 41 - > 2 files changed, 39

Re: [FFmpeg-devel] [PATCH v3] avformat/hlsenc: add hls_fmp4_init_resend option

2020-04-14 Thread Steven Liu
> 2020年4月12日 下午9:38,Steven Liu 写道: > > > >> 2020年4月7日 下午5:31,Steven Liu 写道: >> >> add option for resend init file after m3u8 refresh everytime. >> >> Signed-off-by: Steven Liu >> --- >> doc/

Re: [FFmpeg-devel] [PATCH v2] avformat/dashdec: add attribute lang for audio and subtitle streams

2020-04-14 Thread Steven Liu
> 2020年4月11日 上午9:55,Steven Liu 写道: > > > >> 2020年4月8日 下午10:39,Steven Liu 写道: >> >> >> >>> 2020年3月31日 下午8:20,Steven Liu 写道: >>> >>> There should have language in the metadata of streams which show to user >>>

[FFmpeg-devel] [PATCH] tests/fate/hlsenc: rename fate macro define from FATE_AFILTER to FATE_HLSENC

2020-04-14 Thread Steven Liu
and add fate-hlsenc for test all of the testcase Signed-off-by: Steven Liu --- tests/fate/hlsenc.mak | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/tests/fate/hlsenc.mak b/tests/fate/hlsenc.mak index ff58094252..43f93c8c5b 100644 --- a/tests/fate

Re: [FFmpeg-devel] [PATCH] tests/fate/hlsenc: rename fate macro define from FATE_AFILTER to FATE_HLSENC

2020-04-20 Thread Steven Liu
> 2020年4月15日 下午2:58,Steven Liu 写道: > > and add fate-hlsenc for test all of the testcase > Signed-off-by: Steven Liu > --- > tests/fate/hlsenc.mak | 18 ++ > 1 file changed, 10 insertions(+), 8 deletions(-) > > diff --git a/tests/fate/hlsenc.mak b/te

[FFmpeg-devel] [PATCH] avfilter/vf_v360: check the limit of in_pad and out_pad

2020-04-21 Thread Steven Liu
When i set out_pad=1 it will Segmentation fault so i think it should check the limit value of the in_pad and out_pad Signed-off-by: Steven Liu --- libavfilter/vf_v360.c | 4 1 file changed, 4 insertions(+) diff --git a/libavfilter/vf_v360.c b/libavfilter/vf_v360.c index ebc281dfca

Re: [FFmpeg-devel] [PATCH] avfilter/vf_v360: check the limit of in_pad and out_pad

2020-04-21 Thread Steven Liu
> 2020年4月21日 下午10:28,Paul B Mahol 写道: > > On 4/21/20, Steven Liu wrote: >> When i set out_pad=1 it will Segmentation fault >> so i think it should check the limit value of the in_pad and out_pad > > So huge pads do not make sense. Yes, just don’t know how to use

[FFmpeg-devel] [PATCH v2] avfilter/vf_v360: adjustment out_pad and in_pad maximum value to 1/10

2020-04-21 Thread Steven Liu
Because not every user know about in_pad and out_pad reasonable value range so maybe try to set 1.0, but setting 1.0 is so hugh to get an fatal error. Suggested-by: Paul B Mahol Signed-off-by: Steven Liu --- doc/filters.texi | 1 + libavfilter/vf_v360.c | 4 ++-- 2 files changed, 3

Re: [FFmpeg-devel] [PATCH v2] avfilter/vf_v360: adjustment out_pad and in_pad maximum value to 1/10

2020-04-26 Thread Steven Liu
> 2020年4月21日 下午10:54,Steven Liu 写道: > > Because not every user know about in_pad and out_pad reasonable value range > so maybe try to set 1.0, but setting 1.0 is so hugh to get an fatal error. > > Suggested-by: Paul B Mahol > Signed-off-by: Steven Liu > --- >

[FFmpeg-devel] [PATCH] libavformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
fix ticket: 8625 Signed-off-by: Steven Liu --- libavformat/url.c | 22 -- 1 file changed, 20 insertions(+), 2 deletions(-) diff --git a/libavformat/url.c b/libavformat/url.c index 596fb49cfc..e5003f795a 100644 --- a/libavformat/url.c +++ b/libavformat/url.c @@ -81,6 +81,8

Re: [FFmpeg-devel] [PATCH] libavformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午6:30,Martin Storsjö 写道: > > On Mon, 27 Apr 2020, Steven Liu wrote: > >> fix ticket: 8625 >> >> Signed-off-by: Steven Liu >> --- >> libavformat/url.c | 22 -- >> 1 file changed, 20 insertions(+), 2 dele

[FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
fix ticket: 8625 and add testcase into url for double dot corner case Suggested-by: Martin Storsjö Signed-off-by: Steven Liu --- libavformat/tests/url.c | 3 +++ libavformat/url.c | 21 +++-- 2 files changed, 22 insertions(+), 2 deletions(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午6:54,Nicolas George 写道: > > Steven Liu (12020-04-27): >> and add testcase into url for double dot corner case > > Did you run FATE? Haha, Patchwork returned it, will fix that. > > Regards, > > -- >

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:04,lance.lmw...@gmail.com 写道: > > On Mon, Apr 27, 2020 at 06:51:47PM +0800, Steven Liu wrote: >> fix ticket: 8625 >> and add testcase into url for double dot corner case > > I think you need update ./tests/ref/fate/url also. > > make fate-u

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
want in it. > > Regards, > > -- > Nicolas George Thanks Steven Liu ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

[FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
fix ticket: 8625 and add testcase into url for double dot corner case Signed-off-by: Steven Liu --- libavformat/tests/url.c | 3 +++ libavformat/url.c | 21 +++-- tests/ref/fate/url | 3 +++ 3 files changed, 25 insertions(+), 2 deletions(-) diff --git a/libavformat

Re: [FFmpeg-devel] [PATCH v2] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:10,Nicolas George 写道: > > Steven Liu (12020-04-27): >> Do you mean you don’t want in the cc list? >> I think can remove you from cc list if you don’t want in it. > > I want you to do exactly as the headers direct you to do. Inner p

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:14,Nicolas George 写道: > > Steven Liu (12020-04-27): >> fix ticket: 8625 >> and add testcase into url for double dot corner case >> >> Signed-off-by: Steven Liu >> --- >> libavformat/tests/url.c | 3 +++ >> libavformat/url.c

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:22,Nicolas George 写道: > > Steven Liu (12020-04-27): >> /../../../../../other/url, this is the absolute path, so just concat and >> don’t process, >> Or what do you want to say? > > This is not an absolute path, since it contains ".

Re: [FFmpeg-devel] [PATCH v3] avformat/url: check url root node when rel include double dot

2020-04-27 Thread Steven Liu
> 2020年4月27日 下午7:35,Nicolas George 写道: > > Steven Liu (12020-04-27): >> I need one example to understand about the security issue after this patch. > > Use ff_make_absolute_url() on a trusted base and an un-trusted path; > check the result starts with the allowed

<    1   2   3   4   5   6   7   8   9   10   >