Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

Hi Mark, Such APP controlled frame-skipping feature is required by our vaapi lib users. Could we get it merged please? Regards, SUN, Jing -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sun, Jing A Sent: Monday, December 10, 2018 3:19 PM

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

Hi Mark, May I have your comments on this please? Regards, SUN, Jing -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sun, Jing A Sent: Tuesday, December 18, 2018 4:23 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

Hi Mark, Is there any issue that I need to fix for this patch please? Regards, SUN, Jing -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Sun, Jing A Sent: Friday, November 23, 2018 5:37 PM To: FFmpeg development discussions and patches

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

, SUN, Jing -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark Thompson Sent: Wednesday, December 5, 2018 7:50 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func On 04/12/2018 01:46

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

, and the distributer wants to just skip such frames, without stopping the encoding process. Regards, SUN, Jing -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark Thompson Sent: Tuesday, November 20, 2018 4:07 AM To: ffmpeg-devel@ffmpeg.org Subject

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/vaapi_encode: add frame-skip func

and the vaapi lib, which informs the latter that a frame shall be skipped. Regards, SUN, Jing -Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Mark Thompson Sent: Monday, December 10, 2018 2:40 AM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: Li, Zhong Sent: Friday, March 29, 2019 6:59 PM To: FFmpeg development discussions and patches Cc: Sun, Jing A ; Huang, Zhengxu ; Jun Zhao ; Tmar, Hassene Subject: RE: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper > F

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

The one made the below change: - if (avctx->pix_fmt == AV_PIX_FMT_YUV420P10LE) { +if (avctx->pix_fmt == AV_PIX_FMT_YUV420P10) { No special handling for 10 bit anymore. Regards, SUN, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

On Fri, Mar 29, 2019 at 5:28 AM Jing Sun wrote: +static int config_enc_params(EB_H265_ENC_CONFIGURATION *param, +                             AVCodecContext *avctx) +{ +    SvtContext *svt_enc = avctx->priv_data; +    int ret; + +    param->sourceWidth = avctx->width; +    param->sourceHeight =

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

The one made the below change: ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v9 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

Friday, March 22, 2019 5:54 PM, Carl Eugen Hoyos: >What I meant is: >I don't understand the comment (and your mail), it says above the >functionality has to be disabled but you write it works fine. >The comment is (still) unclear imo. >Carl Eugen Hi Carl, it works functionally, but there is

Re: [FFmpeg-devel] [PATCH v9 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

On Thursday, March 28, 2019 5:20 AM, Mark Thompson wrote: >Looking at what the highDynamicRangeInput field actually does >, > I don't think it makes sense for this external "hdr"

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: Li, Zhong Sent: Monday, April 1, 2019 1:21 PM To: FFmpeg development discussions and patches Cc: Sun, Jing A ; Huang, Zhengxu ; Jun Zhao ; Tmar, Hassene Subject: RE: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper > F

Re: [FFmpeg-devel] [PATCH v2 1/1] avcodec/vaapi_encode: add frame-skip func

e keep both and let users decide which way they want to use? Regards, SUN, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

On Monday, March 11, 2019 10:50 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: >On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A wrote: >I just searched my inbox again but failed to find that email of question you >mentioned. > >Yeah I often see my mail bounced wi

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

posted. In the meantime, I think it is not blocking the first version of this plugin’s merging , is it? VideoUsabilityInfo Enables or disables sending a vui structure in the HEVC Elementary bitstream. 0 = OFF, 1 = ON Regards, SUN, Jing From: Vittorio Giovara [mailto:vittorio.giov...@gmail.com

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

On Monday, March 11, 2019 10:50 PM Vittorio Giovara vittorio.giov...@gmail.com wrote: >On Mon, Mar 11, 2019 at 12:50 AM Sun, Jing A wrote: >I just searched my inbox again but failed to find that email of question you >mentioned. > >Yeah I often see my mail bounced wi

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

. 2019-03-08 11:36 GMT+01:00, Jing SUN : > +static void free_buffer(SvtContext *svt_enc) { > +EB_H265_ENC_INPUT *in_data = > (EB_H265_ENC_INPUT *)svt_enc->in_buf.pBuffer; Is the cast necessary? Or actually: Can't in_data be whatever doesn't produce a warning? [SUN, Jing] Yes, it

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

I just searched my inbox again but failed to find that email of question you mentioned. Could you please elaborate your request? What is the preservation for and how is it expected to work? Regards, SUN, Jing From: Vittorio Giovara [mailto:vittorio.giov...@gmail.com] Sent: Saturday, March 9

Re: [FFmpeg-devel] [PATCH v6 2/2] doc: Add libsvt_hevc encoder docs

each P-frame can use. The range is from > @var{0-16}. > +Default is 0(disabled). Wouldn't 0 mean that P frames can't exist, so the whole stream must be intra-only? [SUN, Jing] To be modified in v7. > +@item g / @option{gop_size} > +Set the GOP size. Default is 64. This doesn't appear

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

. 2019-03-11 9:49 GMT+01:00, Moritz Barsnick : > On Mon, Mar 11, 2019 at 04:17:21 +0000, Sun, Jing A wrote: >> From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf >> Of Carl Eugen Hoyos >> > The condition is unnecessary. >> [SUN, Jing] If av_mallocz fai

Re: [FFmpeg-devel] [PATCH v6 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

_REACHED = 0, > +EOS_REACHED, > +EOS_TOTRIGGER > +}EOS_STATUS; > + > +typedef struct SvtContext { > +AVClass *class; > + > +EB_H265_ENC_CONFIGURATION enc_params; > +EB_COMPONENTTYPE *svt_handle; > + > +EB_BUFFERHEADERTYPE*

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Jing SUN Sent: Monday, March 11, 2019 6:38 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Jun Zhao ; Tmar, Hassene Subject: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add

Re: [FFmpeg-devel] [PATCH v7 2/2] doc: Add libsvt_hevc encoder docs

-Original Message- From: Sun, Jing A Sent: Monday, March 11, 2019 3:02 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Jun Zhao ; Huang, Zhengxu ; Tmar, Hassene Subject: [PATCH v7 2/2] doc: Add libsvt_hevc encoder docs Add docs for libsvt_hevc encoder in encoders.texi and general.texi

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

On Wed, Mar 13, 2019 at 8:29 PM Sun, Jing A wrote: > > > > On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > wrote: > > Hi Giovara, > > > > SVT HEVC has the interface to enable/disable sending a vui structure > in the HEVC bitstream, but supports no interface

Re: [FFmpeg-devel] [PATCH v9 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

Friday, March 22, 2019 7:52 AM, Carl Eugen: > +if (avctx->pix_fmt == AV_PIX_FMT_YUV420P10LE) { > +av_log(avctx, AV_LOG_DEBUG , "Encoder 10 bits depth > + input\n"); > + > +// Encoding the source frames of the compressed 10-bit format > +// supported by SVT-HEVC

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper.

> On Tue, Mar 12, 2019 at 11:40 PM Sun, Jing A > mailto:jing.a@intel.com>> wrote: Hi Giovara, SVT HEVC has the interface to enable/disable sending a vui structure in the HEVC bitstream, but supports no interface for setting the color properties before encoding yet. I wil

Re: [FFmpeg-devel] [PATCH v1 1/1] vaapi_encode: replace av_new_packet with ff_alloc_packet2

exist, or calls encode2 instead. Please correct me if I am wrong. And would you please review the other patch "[PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper" for another time? I have updated it again. Thanks a lot in adv

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

will submit the modification soon. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: Sun, Jing A Sent: Friday, May 31, 2019 11:37 AM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper Sorry I forgot to remove some debugging code lines

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

indly review again. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

. And thanks for the information on ff_alloc_packet2. I changed to use av_new_packet in v13 and hope it's OK. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH v1 1/1] vaapi_encode: replace av_new_packet with ff_alloc_packet2

ind this anywhere in the tree. Are you sure you're looking at > ffmpeg's libavcodec? I am so sorry for using out-of-date code base. Please ignore this patch. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/m

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of James Almer Sent: Friday, May 10, 2019 12:05 PM To: ffmpeg-devel@ffmpeg.org Subject: Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper >You used av_mallocz() to

Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of Li, Zhong Sent: Friday, May 10, 2019 1:23 PM To: FFmpeg development discussions and patches Subject: Re: [FFmpeg-devel] [PATCH v12 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper >The better

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

You add a new encoder, so you have to raise MINOR in libavcodec/version.h (and >reset MICRO). >Carl Eugen Hi Carl, I made the version change and submitted the v11 patches. Please kindly review if I am doing it correctly. Regards, Sun, Jing _

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

the SVT HEVC GitHub page. Is that OK not to add it? For versions, I increased it if big changes were submitted and kept it the same if only minor changes. I am new to the community and would you please guide me if that strategy is all right or not? If not, I will resubmit the

Re: [FFmpeg-devel] [PATCH] lavc: Add libsvt-av1 encoder wrapper

-Original Message- From: Li, Zhong Sent: Friday, July 12, 2019 6:32 PM To: ffmpeg-devel@ffmpeg.org Cc: Daryl Seah ; Li, Zhong ; Daryl; Seah; Sun, Jing A ; Tang, Zhizhen Subject: [PATCH] lavc: Add libsvt-av1 encoder wrapper From: Daryl Seah Signed-off-by: Daryl Seah Signed-off

Re: [FFmpeg-devel] [PATCH] lavc: Add libsvt-av1 encoder wrapper

-Original Message- From: Li, Zhong Sent: Saturday, July 13, 2019 1:23 AM To: Sun, Jing A ; ffmpeg-devel@ffmpeg.org Cc: Daryl Seah ; Tang, Zhizhen Subject: RE: [PATCH] lavc: Add libsvt-av1 encoder wrapper > I prefer to contribute on FFmpeg mainline instead of a forked branch. > H

Re: [FFmpeg-devel] [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: Sun, Jing A Sent: Monday, April 1, 2019 10:38 AM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v10 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper Signed-off-by: Zhengxu Huang Signed-off

Re: [FFmpeg-devel] [PATCH v14 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

>A minor bump is common for new codecs. >Carl Eugen Thanks Carl! It's modified. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH v17 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: Sun, Jing A Sent: Monday, August 19, 2019 1:55 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v17 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper Fixed memleak. Regards, Sun, Jing

Re: [FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

> again and again. I got started based on V5 and V6 is my first submission. Thanks for showing me the information. I am looking into it. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

s used for the bitstream optimized buffer read(32 or > 64 bit for minimal at least). If it's memcpy, do we need malloc with extra > AV_INPUT_BUFFER_PADDING_SIZE? Thanks for everyone's advices and I am considering on how to make this not confusing. Will update the patch later. BTW, it's

Re: [FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

oid* cast in the memset() line. "avctx->extradata + > avctx->extradata_size" is acceptable as an argument. Thanks James! It's modified and submitted as V16. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

Re: [FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

g if we shall add such a controlling interface to SVT HEVC lib and how. The code lines of handling avctx->thread_count in this avcodec is possible to get added in the future. Right now, adding an empty interface without implementation supported by SVT HEVC lib makes no sense. Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

This update corrected the rc_mode assignment position. It should get assigned before the if(). 264a265,269 > +if (param->rateControlMode) { > +param->maxQpAllowed = avctx->qmax; > +param->minQpAllowed = avctx->qmin; > +} > + 277,281d281 < +if (param->rateControlMode)

Re: [FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: Sun, Jing A Sent: Thursday, August 1, 2019 3:53 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper [Patch content] This update removed the code line

[FFmpeg-devel] Recall: [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

Sun, Jing A would like to recall the message, "[PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper". ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit

Re: [FFmpeg-devel] [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

-Original Message- From: Sun, Jing A Sent: Thursday, August 1, 2019 3:53 PM To: ffmpeg-devel@ffmpeg.org Cc: Sun, Jing A ; Huang, Zhengxu ; Tmar, Hassene ; Jun Zhao Subject: [PATCH v16 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper [Patch content] This update removed the code

Re: [FFmpeg-devel] [PATCH v15 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

, AV_PIX_FMT_NONE }, Regards, Sun, Jing ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject