[FFmpeg-devel] [PATCH] Add DECLARE_ASM_ALIGNED macro for DJGPP architecture.

2017-11-14 Thread Thomas Köppe
The macro was added in 43171a2a738f5114768d34a7278e56e5fde714bc, but I forgot to add it to the DJGPP architecture in that change. --- libavutil/mem.h | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil/mem.h b/libavutil/mem.h index 9e344bd2c3..7e0b12a8a7 100644 --- a/libavutil/mem.h

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-12 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-11 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-11-09 Thread Thomas Köppe
t;> Here the compiler has no easy vissibility of the use, it is part of >>> the asm string. >>> >>> and comparing this to DECLARE_ALIGNED(), the big difference is >>> that DECLARE_ALIGNED() is used by plain C code which never should need >>> "us

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
(I must have forgotten to rebase first!) On 30 October 2017 at 20:14, Thomas Köppe <tkoe...@google.com> wrote: > It should be under __GNUC__ -- something went wrong with the patch! I'll > make a new one. Sorry about that! > > On 30 October 2017 at 19:31, James Almer <jam

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Thomas Köppe
+Teresa, who drafted the patch initially. On 31 October 2017 at 15:38, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Tue, Oct 31, 2017 at 12:16:18PM +0000, Thomas Köppe wrote: > > Variables used in inline assembly need to be marked with > attribute((used)

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
It should be under __GNUC__ -- something went wrong with the patch! I'll make a new one. Sorry about that! On 30 October 2017 at 19:31, James Almer <jamr...@gmail.com> wrote: > On 10/30/2017 4:17 PM, Thomas Köppe wrote: > > Variables used in inline assembly need to be marked w

Re: [FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
ctober 2017 at 20:25, Thomas Köppe <tkoe...@google.com> wrote: > (I must have forgotten to rebase first!) > > On 30 October 2017 at 20:14, Thomas Köppe <tkoe...@google.com> wrote: > >> It should be under __GNUC__ -- something went wrong with the patch! I'll >> ma

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-31 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared

[FFmpeg-devel] [PATCH] Fix missing used attribute for inline assembly variables

2017-10-30 Thread Thomas Köppe
Variables used in inline assembly need to be marked with attribute((used)). Static constants already were, via the define of DECLARE_ASM_CONST. But DECLARE_ALIGNED does not add this attribute, and some of the variables defined with it are const only used in inline assembly, and therefore appeared

Re: [FFmpeg-devel] [PATCH] Add DECLARE_ASM_ALIGNED macro for DJGPP architecture.

2018-01-02 Thread Thomas Köppe
Oh, very true, I must have missed that -- thank you! On 2 January 2018 at 14:08, James Almer <jamr...@gmail.com> wrote: > On 1/2/2018 10:59 AM, Thomas Köppe wrote: > > Hello, > > > > Friendly ping, can I interest you in this patch? It seems like it fixes > an > &

Re: [FFmpeg-devel] [PATCH] Add DECLARE_ASM_ALIGNED macro for DJGPP architecture.

2018-01-02 Thread Thomas Köppe
Hello, Friendly ping, can I interest you in this patch? It seems like it fixes an oversight that would be annoying for anyone trying to build FFMPEG for DJGPP. Thanks! On 14 November 2017 at 18:26, Thomas Köppe <tkoe...@google.com> wrote: > The macro