Re: [FFmpeg-devel] [PATCH] avfilter: add unpremultiply filter

On 01.08.2017 13:03, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- doc/filters.texi | 13 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 + libavfilter/vf_premultiply.c | 307 --- 4 files

Re: [FFmpeg-devel] Possible minor bug found in AVI decoder

On 12.05.2017 11:33, Eric Beuque wrote: Hi, i'm not really sure but i think a found a bug in the avi decoder of avformat. In the following function of the avidec.c: static int avi_read_header(AVFormatContext *s) { ... switch (tag) { ... case MKTAG('s', 't',

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter: add arbitrary audio FIR filter

On 10.05.2017 09:12, Muhammad Faiz wrote: On Wed, May 10, 2017 at 1:55 AM, Paul B Mahol wrote: ffmpeg | branch: master | Paul B Mahol | Thu Jan 26 17:03:08 2017 +0100| [49bbfb9d13936ee8bb7fee9983ca3710dc683a2e] | committer: Paul B Mahol avfilter: add

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

On 31.05.2017 15:42, wm4 wrote: On Wed, 31 May 2017 14:49:19 +0200 Michael Niedermayer wrote: >> [...] >> Security fixes should be as simple as possible. Well, your fix isn't simple. It adds yet another exception with questionable effect. It makes it more complex

Re: [FFmpeg-devel] [PATCH] avformat/hls: Disallow local file access by default

On 31.05.2017 18:33, Michael Niedermayer wrote: On Wed, May 31, 2017 at 05:18:57PM +0200, Tobias Rapp wrote: On 31.05.2017 15:42, wm4 wrote: On Wed, 31 May 2017 14:49:19 +0200 Michael Niedermayer <mich...@niedermayer.cc> wrote: [...] Security fixes should be as simple as possible.

Re: [FFmpeg-devel] [PATCH 3/3] avformat: set the default whitelist to disable hls

may work as an alternative. But such solutions are fragile and tricky to implement portably and would not stop every possible attack nor would they work with all valid hls files. Found-by: Emil Lerner and Pavel Cheremushkin Reported-by: Thierry Foucu <tfo...@google.com> Fix inspired by: Tobia

Re: [FFmpeg-devel] [PATCH] cmdutils: add log time info into report log file

On 03.06.2017 08:41, Steven Liu wrote: 2017-06-03 0:30 GMT+08:00 Nicolas George : Le quintidi 15 prairial, an CCXXV, Steven Liu a écrit : add time info into every line of log report the time info can be used to find out error message occur time. Signed-off-by: Steven Liu

Re: [FFmpeg-devel] [PATCH] avformat/file: increase max packet size to 256k for written files

On 05.06.2017 19:16, Marton Balint wrote: Another huge performance improvement when using SMB/CIFS as output. Signed-off-by: Marton Balint --- libavformat/file.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

On 19.06.2017 10:28, wm4 wrote: On Mon, 19 Jun 2017 09:38:19 +0200 Tobias Rapp <t.r...@noa-archive.com> wrote: On 19.06.2017 02:04, 21na...@gmail.com wrote: Le 18/06/2017 à 00:57, Sasi Inguva a écrit : Hi, I was the one who made that change. We needed a way to obtain individual

Re: [FFmpeg-devel] Why the tag “DURATION” is a necessity in Matroska files?

On 19.06.2017 02:04, 21na...@gmail.com wrote: Le 18/06/2017 à 00:57, Sasi Inguva a écrit : Hi, I was the one who made that change. We needed a way to obtain individual stream durations from a Matroska file without reading the entire file. I don't think it adds to the file size greatly (< 50

Re: [FFmpeg-devel] [PATCH] tests/fate/fifo-muxer: update fifo-muxer dependencies

On 07.05.2017 22:30, Paul B Mahol wrote: On 5/4/17, Tobias Rapp <t.r...@noa-archive.com> wrote: Fixes fate when configured with --disable-network. --- tests/fate/fifo-muxer.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/fifo-muxer.mak b/tests/fat

[FFmpeg-devel] [PATCH] tests/fate/fifo-muxer: update fifo-muxer dependencies

Fixes fate when configured with --disable-network. --- tests/fate/fifo-muxer.mak | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate/fifo-muxer.mak b/tests/fate/fifo-muxer.mak index ef8b3b3..9c13954 100644 --- a/tests/fate/fifo-muxer.mak +++ b/tests/fate/fifo-muxer.mak

Re: [FFmpeg-devel] [RFC]lavu/opt: Use && instead of * in boolean expression

On 05.05.2017 09:26, Carl Eugen Hoyos wrote: 2017-05-05 3:12 GMT+02:00 Aaron Levinson : On 5/4/2017 4:32 PM, Carl Eugen Hoyos wrote: Hi! It may be better to disable the warning. Carl Eugen -num = den ? num * intnum / den : (num * intnum ? INFINITY : NAN); +

[FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: fix aspect ratio when writing 16:9 DV frames

Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 7289e0b..da4d7b4 100644 --- a/libavformat/mxfenc.c +++ b/libavformat/mxfenc.c @@ -1810,7 +

[FFmpeg-devel] [PATCH 2/2] fate: add mxf_dv25/dvcpro50 regression tests

Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tests/fate/avformat.mak | 2 ++ tests/fate/seek.mak | 4 +++ tests/lavf-regression.sh | 8 ++ tests/ref/lavf/mxf_dv25 | 3 +++ tests/ref/lavf/mxf_dvcpro50 | 3 +++ tests/ref/see

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: fix aspect ratio when writing 16:9 DV frames

On 14.09.2017 15:55, Tomas Härdin wrote: On 2017-09-14 15:44, Tobias Rapp wrote: Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> ---   libavformat/mxfenc.c | 2 +-   1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c index 7289e0b..d

[FFmpeg-devel] [PATCH v3] fate: add tests for psnr and ssim filter

Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g. x86-32 vs. x86-64). Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tested on Linux x86-32/64 and

Re: [FFmpeg-devel] [PATCH v3] fate: add tests for psnr and ssim filter

On 20.09.2017 01:38, Michael Niedermayer wrote: On Tue, Sep 19, 2017 at 09:48:45AM +0200, Tobias Rapp wrote: Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g.

[FFmpeg-devel] [PATCH v4] fate: add tests for psnr and ssim filter

Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g. x86-32 vs. x86-64). Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tested on Linux x86-32/64 and

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_fps: clean-up filter options

On 22.09.2017 01:58, Michael Niedermayer wrote: On Thu, Sep 21, 2017 at 04:55:51PM +0200, Tobias Rapp wrote: Align order of "start_time" option to documentation and add missing AV_OPT_FLAG_FILTERING_PARAM flag. Fix indent of "round" named constants and clear unused field va

[FFmpeg-devel] [PATCH 1/2] avfilter/vf_fps: clean-up filter options

Align order of "start_time" option to documentation and add missing AV_OPT_FLAG_FILTERING_PARAM flag. Fix indent of "round" named constants and clear unused field values. Also fix some documentation cosmetics. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> ---

[FFmpeg-devel] [PATCH 2/2] avfilter/vf_fps: add eof_action filter option

en reached yet. Examples using an input file with 25Hz, 1.4sec duration: - "fps=fps=1:round=near" generates an output file of 1sec - "fps=fps=1:round=near:eof_action=pass" generates an output file of 2sec Signed-off-by: Tobias Rapp <t.r...@noa-archive.com

Re: [FFmpeg-devel] [PATCH 1/2] avformat/mxfenc: fix aspect ratio when writing 16:9 DV frames

On 15.09.2017 20:44, Michael Niedermayer wrote: On Thu, Sep 14, 2017 at 03:44:41PM +0200, Tobias Rapp wrote: Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/mxfenc.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/mxfenc.c b/libav

Re: [FFmpeg-devel] [PATCH 2/2] fate: add mxf_dv25/dvcpro50 regression tests

On 15.09.2017 22:43, Michael Niedermayer wrote: On Thu, Sep 14, 2017 at 03:44:42PM +0200, Tobias Rapp wrote: Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tests/fate/avformat.mak | 2 ++ tests/fate/seek.mak | 4 +++ tests/lavf-regression.sh

Re: [FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_fps: clean-up filter options

On 04.10.2017 23:27, Michael Niedermayer wrote: On Mon, Sep 25, 2017 at 01:31:18PM +0200, Tobias Rapp wrote: Align order of "start_time" option within filter documentation to actual implementation and add missing AV_OPT_FLAG_FILTERING_PARAM flag. Fix indent of "round" named

Re: [FFmpeg-devel] [PATCH 1/2] avformat/wavenc: replace literal numbers with enum constants

On 30.09.2017 02:44, Michael Niedermayer wrote: On Fri, Sep 29, 2017 at 05:08:15PM +0200, Tobias Rapp wrote: Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/wavenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) LGTM Pushed, thanks for review. R

Re: [FFmpeg-devel] [PATCH 2/2] avformat/wavenc: skip writing peak-of-peaks position when writing peaks only

On 05.10.2017 00:05, Michael Niedermayer wrote: On Wed, Oct 04, 2017 at 10:33:11AM +0200, Tobias Rapp wrote: On 30.09.2017 02:48, Michael Niedermayer wrote: On Fri, Sep 29, 2017 at 05:08:16PM +0200, Tobias Rapp wrote: Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libav

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_fps: add eof_action filter option

On 04.10.2017 23:34, Michael Niedermayer wrote: On Mon, Sep 25, 2017 at 01:31:19PM +0200, Tobias Rapp wrote: Allows to specify the action to be performed when reading the last frame from the internal FIFO buffer. By default the last frame is written to filter output depending on the timestamp

Re: [FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_fps: add eof_action filter option

On 25.09.2017 13:31, Tobias Rapp wrote: Allows to specify the action to be performed when reading the last frame from the internal FIFO buffer. By default the last frame is written to filter output depending on the timestamp rounding method. When using "pass" action the last frame

Re: [FFmpeg-devel] [PATCH v5 2/2] fate: add tests for psnr and ssim filter

On 27.09.2017 17:20, Carl Eugen Hoyos wrote: 2017-09-27 15:30 GMT+02:00 Tobias Rapp <t.r...@noa-archive.com>: Metadata filter output is passed through an Awk script comparing floats Is awk needed on the host or the target system? Awk is started by fate-run.sh directly, so it is

Re: [FFmpeg-devel] [PATCH 2/7] decode: add a method for attaching lavc-internal data to frames

On 04.10.2017 11:34, wm4 wrote: On Wed, 4 Oct 2017 11:22:37 +0200 Michael Niedermayer wrote: On Wed, Oct 04, 2017 at 09:12:29AM +0200, wm4 wrote: On Tue, 3 Oct 2017 21:40:58 +0200 Michael Niedermayer wrote: On Tue, Oct 03, 2017 at

Re: [FFmpeg-devel] [PATCH 2/2] avformat/wavenc: skip writing peak-of-peaks position when writing peaks only

On 30.09.2017 02:48, Michael Niedermayer wrote: On Fri, Sep 29, 2017 at 05:08:16PM +0200, Tobias Rapp wrote: Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/wavenc.c | 5 - tests/ref/lavf/wav_peak_only | 2 +- 2 files changed, 5 insertions(+), 2 del

Re: [FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

On 17.07.2017 16:19, Nicolas George wrote: This reverts commit 04aa09c4bcf2d5a634a35da3a3ae3fc1abe30ef8. The fate-ffm change is caused by field_order now being set on the output format because the first frame arrives earlier. The fate-mxf change is assumed to be the same. Signed-off-by:

Re: [FFmpeg-devel] [PATCH] fate: add test for asetnsamples filter with padding disabled

On 08.09.2017 04:04, Michael Niedermayer wrote: On Tue, Sep 05, 2017 at 03:13:15PM +0200, Tobias Rapp wrote: Adds another test for asetnsamples filter where padding of the last frame is switched off. Renames the existing test to make the difference obvious. Signed-off-by: Tobias Rapp <

Re: [FFmpeg-devel] [PATCH v2] ffprobe: use consistent string for unspecified color_range value

On 05.09.2017 15:28, Paul B Mahol wrote: On 9/5/17, Tobias Rapp <t.r...@noa-archive.com> wrote: On 29.08.2017 16:07, Tobias Rapp wrote: Makes the handling of unspecified/unknown color_range values on stream level consistent to the value used on frame level. Signed-off-by: Tobias Rap

Re: [FFmpeg-devel] [PATCH v2] fate: add tests for psnr and ssim filter

On 30.08.2017 12:08, Nicolas George wrote: Le tridi 13 fructidor, an CCXXV, Tobias Rapp a écrit : Metadata output is passed through an Awk script reducing precision of floats to account for architecture differences (e.g x86-32 vs. x86-64). I do not like that approach at all: it will miss

[FFmpeg-devel] [PATCH v2] fate: add tests for psnr and ssim filter

Metadata output is passed through an Awk script reducing precision of floats to account for architecture differences (e.g x86-32 vs. x86-64). Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- v2: - removed CPUFLAGS work-around for ssim filter issue - added metadata float valu

Re: [FFmpeg-devel] [PATCH] avfilter: add vmafmotion filter

On 13.09.2017 15:10, Ronald S. Bultje wrote: Hi, On Wed, Sep 6, 2017 at 4:04 PM, Ashish Pratap Singh wrote: From: Ashish Singh Hi, this patch changes previous one to framesync2. SIMD is a work in progress for this filter. Signed-off-by: Ashish

Re: [FFmpeg-devel] [PATCH] fate: increase fuzz for refcmp filter tests

On 29.09.2017 00:10, Michael Niedermayer wrote: On Thu, Sep 28, 2017 at 09:27:23AM +0200, Tobias Rapp wrote: Should fix failing tests on GNU/kFreeBSD x86_32. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- Michael: Have put you on CC as you seem to be the owner of the af

[FFmpeg-devel] [PATCH 1/2] avformat/wavenc: replace literal numbers with enum constants

Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/wavenc.c | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c index 7f3059e..adb20cb 100644 --- a/libavformat/wavenc.c +++ b/libavformat/wavenc.c @@ -331,7

[FFmpeg-devel] [PATCH 2/2] avformat/wavenc: skip writing peak-of-peaks position when writing peaks only

Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/wavenc.c | 5 - tests/ref/lavf/wav_peak_only | 2 +- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/libavformat/wavenc.c b/libavformat/wavenc.c index adb20cb..7a4acf9 100644 --- a/libavformat/wa

Re: [FFmpeg-devel] [PATCH v4] fate: add tests for psnr and ssim filter

On 20.09.2017 11:01, Tobias Rapp wrote: Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g. x86-32 vs. x86-64). Signed-off-by: Tobias Rapp <t.r...@no

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_fps: clean-up filter options

On 23.09.2017 17:05, Michael Niedermayer wrote: On Fri, Sep 22, 2017 at 08:52:26AM +0200, Tobias Rapp wrote: On 22.09.2017 01:58, Michael Niedermayer wrote: On Thu, Sep 21, 2017 at 04:55:51PM +0200, Tobias Rapp wrote: Align order of "start_time" option to documentation and a

[FFmpeg-devel] [PATCH v2 1/2] avfilter/vf_fps: clean-up filter options

Align order of "start_time" option within filter documentation to actual implementation and add missing AV_OPT_FLAG_FILTERING_PARAM flag. Fix indent of "round" named constants and clear unused field values. Also fix some documentation cosmetics. Signed-off-by: Tobias Rapp <

[FFmpeg-devel] [PATCH v2 2/2] avfilter/vf_fps: add eof_action filter option

en reached yet. Examples using an input file with 25Hz, 1.4sec duration: - "fps=fps=1:round=near" generates an output file of 1sec - "fps=fps=1:round=near:eof_action=pass" generates an output file of 2sec Signed-off-by: Tobias Rapp <t.r...@noa-archive.com

[FFmpeg-devel] [PATCH] fate: increase fuzz for refcmp filter tests

Should fix failing tests on GNU/kFreeBSD x86_32. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- Michael: Have put you on CC as you seem to be the owner of the affected machines. tests/fate/filter-video.mak | 8 1 file changed, 4 insertions(+), 4 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v4] fate: add tests for psnr and ssim filter

On 26.09.2017 09:54, Tobias Rapp wrote: On 20.09.2017 11:01, Tobias Rapp wrote: Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g. x86-32 vs. x86-64).

[FFmpeg-devel] [PATCH v5 1/2] avfilter/f_metadata: avoid trailing whitespace in filter output

Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavfilter/f_metadata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/f_metadata.c b/libavfilter/f_metadata.c index 23bc254..523a94d 100644 --- a/libavfilter/f_metadata.c +++ b/libavfilter/f_meta

[FFmpeg-devel] [PATCH v5 2/2] fate: add tests for psnr and ssim filter

Metadata filter output is passed through an Awk script comparing floats against reference values with specified "fuzz" tolerance to account for architectural differences (e.g. x86-32 vs. x86-64). Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tested on Linux x86-32/64 and

Re: [FFmpeg-devel] [PATCH v5 1/2] avfilter/f_metadata: avoid trailing whitespace in filter output

On 27.09.2017 15:50, Paul B Mahol wrote: On 9/27/17, Tobias Rapp <t.r...@noa-archive.com> wrote: Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavfilter/f_metadata.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) lgtm Pushed both patches. Th

Re: [FFmpeg-devel] [PATCH v3] fate: add tests for some video source filters

On 31.08.2017 02:50, Michael Niedermayer wrote: On Tue, Aug 29, 2017 at 04:49:58PM +0200, Tobias Rapp wrote: On 25.07.2017 11:11, Tobias Rapp wrote: Adds FATE tests for the previously untested allrgb, allyuv, rgbtestsrc, smptebars, smptehdbars and yuvtestsrc filters. Also adds a test

Re: [FFmpeg-devel] [PATCH] libavcodec: fix field_order labelling

On 27.08.2017 19:13, Marton Balint wrote: On Sat, 12 Aug 2017, Dave Rice wrote: [..] Also utils.c associates these field order values with the following labels: AV_FIELD_TB  -> "top coded first (swapped)"; AV_FIELD_BT -> "bottom coded first (swapped)"; From my reading, I infer that

[FFmpeg-devel] [PATCH v2] ffprobe: use consistent string for unspecified color_range value

Makes the handling of unspecified/unknown color_range values on stream level consistent to the value used on frame level. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- ffprobe.c | 8 tests/ref/fate/ffprobe_compact | 4 ++-- tests/ref/fate/ffpro

Re: [FFmpeg-devel] [PATCH v2] ffprobe: use consistent string for unspecified color_range value

On 29.08.2017 16:07, Tobias Rapp wrote: Makes the handling of unspecified/unknown color_range values on stream level consistent to the value used on frame level. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- ffprobe.c | 8 tests/re

[FFmpeg-devel] [PATCH] fate: add test for asetnsamples filter with padding disabled

Adds another test for asetnsamples filter where padding of the last frame is switched off. Renames the existing test to make the difference obvious. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tests/fate/filter-audio.mak | 13 + ..

Re: [FFmpeg-devel] [PATCH v3] fate: add tests for some video source filters

On 25.07.2017 11:11, Tobias Rapp wrote: Adds FATE tests for the previously untested allrgb, allyuv, rgbtestsrc, smptebars, smptehdbars and yuvtestsrc filters. Also adds a test for testsrc2 filter with rgb+alpha. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tests/fate/

Re: [FFmpeg-devel] FFmpeg 3.4

On 08.10.2017 13:58, Reto Kromer wrote: Michael Niedermayer wrote: Of course if the majority wants me to wait with the release, its easy to wait for as long as people want me to wait ... Form an user's perspective, I would be delighted to have a new release. Thank you very much indeed! Reto

Re: [FFmpeg-devel] [PATCH 1/7] Revert "Revert "lavfi/buffersrc: push the frame deeper if requested.""

On 17.10.2017 20:12, Nicolas George wrote: Le sextidi 26 vendémiaire, an CCXXVI, Tobias Rapp a écrit : This commit seems to break transcoding of some input files on machines with a lot of CPU cores. See attached script that reproduces the problem ("-threads 32" is used to simulate the

[FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

he feature is implemented correctly. Previous version reviewed-by: Peter Bubestinger <p.bubestin...@av-rd.com> Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- v2: - added version micro bump - more code clean-up libavformat/version.h| 2 +- libavformat/wavenc.c |

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

On 23.11.2017 00:10, Derek Buitenhuis wrote: On 11/22/2017 10:52 PM, Carl Eugen Hoyos wrote: start_line = fields * (i ^ (par->field_order == AV_FIELD_BB || par->field_order == AV_FIELD_BT)); Which are imo less ugly. Can't agree. It's needlessly less readable bit fiddling. +1 It may save

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

On 21.11.2017 20:01, Michael Niedermayer wrote: On Tue, Nov 21, 2017 at 02:24:23PM +0100, Tobias Rapp wrote: On 20.11.2017 22:15, Michael Niedermayer wrote: On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: Tobias Rapp (2017-11-20): Would it be OK to backport the fix

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

On 22.11.2017 23:52, Carl Eugen Hoyos wrote: 2017-11-22 16:41 GMT+01:00 Tobias Rapp <t.r...@noa-archive.com>: Writes one set of field framing information for progressive streams and two sets for interlaced streams. Fixes ticket #6383. Unfortunately the OpenDML v1.02 document is no

[FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

0/1 depending on the field order as a best-effort guess. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/avienc.c | 38 +++--- libavformat/version.h| 2 +- tests/ref/fate/copy-trac2211-avi | 4 ++-- 3 files chang

Re: [FFmpeg-devel] AMD external header

On 28.11.2017 10:25, Timo Rothenpieler wrote: Your use-case looks like an argument for moving the external headers into some separate repository. Not that I personally care much about bundling or not bundling. To me the more important question seems to be whether to auto-enable the

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

On 22.11.2017 16:58, Derek Buitenhuis wrote: On 11/22/2017 3:41 PM, Tobias Rapp wrote: Writes one set of field framing information for progressive streams and two sets for interlaced streams. Fixes ticket #6383. Unfortunately the OpenDML v1.02 document is not very specific what value to use

Re: [FFmpeg-devel] [PATCH] lavr: deprecate the entire library

On 25.11.2017 18:31, Derek Buitenhuis wrote: On 11/25/2017 2:40 PM, Clément Bœsch wrote: Maybe "libavresample is not maintained by the FFmpeg project and will be dropped at the next major bump. Please use libswresample instead." And it probably needs a longer explanation somewhere

Re: [FFmpeg-devel] [PATCH 2/3] avformat/mux: stop delaying writing the header

On 26.11.2017 21:51, James Almer wrote: Every bitstream filter behaves as intended now, so there's no need to wait for the first packet of every stream. Signed-off-by: James Almer --- libavformat/avformat.h | 2 +- libavformat/internal.h | 6 -

Re: [FFmpeg-devel] AMD external header

On 27.11.2017 17:14, Pavel Koshevoy wrote: On Mon, Nov 27, 2017 at 8:25 AM, Nicolas George wrote: Mironov, Mikhail (2017-11-27): #1 policy: do not include external headers goal: minimize maintenance efforts and increase stability of the project action: remove

Re: [FFmpeg-devel] AMD external header

On 01.12.2017 00:32, Marton Balint wrote: On Wed, 29 Nov 2017, Mironov, Mikhail wrote: Hi, This conversation is very entertaining but leads us nowhere. May I suggest to go down to business of enabling HW encoders by default? Yesterday Mark submitted the initial implementation and I really

Re: [FFmpeg-devel] [PATCH] tests/fate/mov: Disable fate-mov-invalid-elst-entry-count, the test does not work reliable currently

On 05.12.2017 01:38, Michael Niedermayer wrote: Noone is known to work on fixing this, so it should be disabled Signed-off-by: Michael Niedermayer --- tests/fate/mov.mak | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/fate/mov.mak b/tests/fate/mov.mak index

[FFmpeg-devel] [PATCH][RFC] avcodec/dpxenc: add option to force color transfer characteristics

specification field? If yes, do we try to map the value from frame color_trc/color_primaries/...? Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- doc/encoders.texi | 43 libavcodec/dpxenc.c | 80 +++--

Re: [FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

On 20.11.2017 14:47, Tobias Rapp wrote: Fixes ticket #6383. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/avienc.c | 10 -- libavformat/version.h| 2 +- tests/ref/fate/copy-trac2211-avi | 2 +- 3 files changed, 10 insertions

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

On 19.11.2017 17:39, Nicolas George wrote: L'octidi 28 brumaire, an CCXXVI, Michael Roitzsch a écrit : Hi FFmpeg team, I was using af_pan to subtract one audio file from another. I first used an amerge filter and then configured the pan filter with a channel formula like c0=c0-c2|c1=c1-c3.

[FFmpeg-devel] [PATCH] avformat/avienc: fix fields-per-frame value for interlaced video streams

Fixes ticket #6383. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- libavformat/avienc.c | 10 -- libavformat/version.h| 2 +- tests/ref/fate/copy-trac2211-avi | 2 +- 3 files changed, 10 insertions(+), 4 deletions(-) diff --git a/libavformat/avie

Re: [FFmpeg-devel] [PATCH] fix bug in af_pan channel coefficient parser

On 20.11.2017 22:15, Michael Niedermayer wrote: On Mon, Nov 20, 2017 at 05:14:15PM +0100, Nicolas George wrote: Tobias Rapp (2017-11-20): Would it be OK to backport the fix into release/3.4? I can do the cherry-picking but am unsure about the policies and what other older releases should

Re: [FFmpeg-devel] [PATCH] configure: Allow users to disable all hwaccel libraries

On 07.12.2017 10:31, Gyan Doshi wrote: On 12/7/2017 12:59 PM, Tobias Rapp wrote: Why not add the HWACCEL_AUTODETECT_LIBRARY_LIST to --disable-hwaccels? That is a better choice but there wasn't a bespoke case for '--disable-hwaccels', so originally ignored that possibility. Added

Re: [FFmpeg-devel] [FFmpeg-cvslog] libavformat/hlsenc: Persistent HTTP connections supported as an option

On 29.11.2017 07:33, Jeyapal, Karthick wrote: ffmpeg | branch: master | Jeyapal, Karthick | Wed Nov 29 14:33:07 2017 +0800| [815e34b5b4ed8fbb6c9d7b7b042ae49848bc170c] | committer: Steven Liu libavformat/hlsenc: Persistent HTTP connections supported as an option

Re: [FFmpeg-devel] [PATCH] avformat/hlsenc: fix complie error when disable-network

On 04.12.2017 16:36, Steven Liu wrote: Signed-off-by: Steven Liu --- libavformat/hlsenc.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/hlsenc.c b/libavformat/hlsenc.c index aeeed5bcd2..7dc8f4237b 100644 --- a/libavformat/hlsenc.c

Re: [FFmpeg-devel] [PATCH] configure: Allow users to disable all hwaccel libraries

On 30.11.2017 11:58, Gyan Doshi wrote: On 11/30/2017 4:19 PM, Clément Bœsch wrote: Is --disable-autodetect broken/not complete for you? This disables more than just the hwaccel libs. I've tested my patch locally and configure lists no entries under External Libraries Providing Hardware

Re: [FFmpeg-devel] [PATCH 01/27] avcodec: add color_range to AVCodec struct and use it

On 11.12.2017 14:22, Paul B Mahol wrote: On 12/11/17, Hendrik Leppkes wrote: On Mon, Dec 11, 2017 at 12:07 PM, Paul B Mahol wrote: Fine, but it's inevitable that the encoder supports the J formats still for a while. Why are you all dismissive about

Re: [FFmpeg-devel] [PATCH v2] avformat/wavenc: skip writing incorrect peak-of-peaks position value

On 25.10.2017 20:01, Michael Niedermayer wrote: On Wed, Oct 25, 2017 at 07:55:52PM +0200, Michael Niedermayer wrote: On Tue, Oct 24, 2017 at 11:47:21AM +0200, Tobias Rapp wrote: According to EBU tech 3285 supplement 3 the dwPosPeakOfPeaks field should contain the absolute position

[FFmpeg-devel] [PATCH] fate: add more tests for hue video filter

Adds tests for the hue angle and brightness filter parameters. Renames the existing saturation parameter test for consistency. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- tests/fate/filter-video.mak | 10 -- tests/ref/fate/filter-hue | 1 - tests/ref/fate/filter-hue1

Re: [FFmpeg-devel] [PATCH 06/13] avformat/mxfenc: Add Sample width/height/x offset/y offset, Display x offset and F2 offset

On 08.05.2018 12:40, Tomas Härdin wrote: mån 2018-05-07 klockan 12:38 +0200 skrev Michael Niedermayer: Signed-off-by: Michael Niedermayer +if (sc->interlaced) { +//Display F2 Offset +mxf_write_local_tag(pb, 4, 0x3217); +avio_wb32(pb,

Re: [FFmpeg-devel] [PATCH] fate: add more tests for hue video filter

On 10.05.2018 23:04, Michael Niedermayer wrote: On Wed, May 09, 2018 at 12:05:48PM +0200, Tobias Rapp wrote: Adds tests for the hue angle and brightness filter parameters. Renames the existing saturation parameter test for consistency. Signed-off-by: Tobias Rapp <t.r...@noa-archive.

[FFmpeg-devel] [PATCH] avfilter/vsrc_testsrc: add pal75bars and pal100bars video filter sources

Generates color bar test patterns based on EBU PAL recommendations. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- Changelog| 1 + doc/filters.texi | 10 +++- libavfilter/Makefile | 2 + libavfilter/allfilters.c

Re: [FFmpeg-devel] [PATCH] avutil/error: document av_err2str

On 17.05.2018 11:24, Zhao Zhili wrote: --- libavutil/error.h | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavutil/error.h b/libavutil/error.h index 71df4da..b357bfa 100644 --- a/libavutil/error.h +++ b/libavutil/error.h @@ -115,6 +115,9 @@ static inline char

Re: [FFmpeg-devel] compound literal in public header file

On 16.05.2018 11:27, Tomas Härdin wrote: ons 2018-05-16 klockan 11:16 +0200 skrev Tobias Rapp: On 16.05.2018 10:29, Tomas Härdin wrote: ons 2018-05-16 klockan 10:18 +0800 skrev Zhao Zhili: The av_err2str macro in libavutil/error.h use compound literal: #define av_err2str(errnum

Re: [FFmpeg-devel] compound literal in public header file

On 16.05.2018 10:29, Tomas Härdin wrote: ons 2018-05-16 klockan 10:18 +0800 skrev Zhao Zhili: The av_err2str macro in libavutil/error.h use compound literal: #define av_err2str(errnum) \ av_make_error_string((char[AV_ERROR_MAX_STRING_SIZE]){0}, AV_ERROR_MAX_STRING_SIZE, errnum) C++

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Use the colour properties from the input stream when doing transcode

On 22.05.2018 00:07, Mark Thompson wrote: On 16/05/18 08:19, Haihao Xiang wrote: In lavc/hevec_vaapi, colour properties in AVCodecContext are needed to write the sequence header Tested by the command below: ffmpeg -hwaccel vaapi -hwaccel_device /dev/dri/renderD128 -hwaccel_output_format vaapi

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Use the colour properties from the input stream when doing transcode

On 25.05.2018 07:58, Xiang, Haihao wrote: On Thu, 2018-05-24 at 11:15 +0100, Mark Thompson wrote: For example: ffmpeg -i bt709_input.mkv -vf colorspace=bt2020 bt2020_output.mkv will have the output file marked as BT.709 after this patch, where previously it was "unspecified". (Explicitly

Re: [FFmpeg-devel] [PATCH] avfilter/vsrc_testsrc: add pal75bars and pal100bars video filter sources

On 18.05.2018 15:23, Paul B Mahol wrote: On 5/17/18, Tobias Rapp <t.r...@noa-archive.com> wrote: Generates color bar test patterns based on EBU PAL recommendations. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- Changelog| 1 + doc/

Re: [FFmpeg-devel] [FFmpeg-cvslog] avfilter/vsrc_testsrc: fix a preprocessor check

On 18.05.2018 22:43, James Almer wrote: ffmpeg | branch: master | James Almer | Fri May 18 17:42:57 2018 -0300| [79126ce80e21f2bc986fef7b8f0d6335136538da] | committer: James Almer avfilter/vsrc_testsrc: fix a preprocessor check Signed-off-by: James Almer

Re: [FFmpeg-devel] [PATCH 2/2] ffmpeg: Use the colour properties from the input stream when doing transcode

On 28.05.2018 09:30, Xiang, Haihao wrote: On Sat, 2018-05-26 at 17:29 +0100, Mark Thompson wrote: On 25/05/18 07:57, Tobias Rapp wrote: On 25.05.2018 07:58, Xiang, Haihao wrote: On Thu, 2018-05-24 at 11:15 +0100, Mark Thompson wrote: For example: ffmpeg -i bt709_input.mkv -vf colorspace

Re: [FFmpeg-devel] [PATCH] fftools/ffmpeg: properly initialize output stream field order

On 26.04.2018 16:06, Tobias Rapp wrote: Fixes stream field order written by avformat_write_header when "top" option is specified on the command-line. Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- fftools/ffmpeg.c | 6 ++ 1 file changed, 6 insertions(+) [...]

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

On 10.01.2018 18:18, Kyle Swanson wrote: Hi, For this to be a part of libavfilter the output needs to be more generic than the just the Soundcloud format. If we want this to be generally useful it should probably just output an array of floats between 0.0 and 1.0. The consumer of this data (JS

Re: [FFmpeg-devel] [PATCH] FFV1: make RGB48 support as non-experimental

On 05.01.2018 11:18, Jerome Martinez wrote: 0001-FFV1-make-RGB48-support-as-non-experimental.patch From cd1bfe68a1a809700f25e593ac21ca3876d265ad Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?J=C3=A9r=C3=B4me=20Martinez?= Date: Fri, 5 Jan 2018 11:09:01 +0100 Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] avfilter: add dumpwave filter.

On 10.01.2018 09:34, Дмитрий Гуменюк wrote: There is no existing dumping format for RMS. How to make it generic? Some of my applications use the following pattern to dump audio envelope data during transcoding: ffmpeg -i input-file -f [...] output-file \ -f wav -write_peak only peak-file

[FFmpeg-devel] [PATCH 1/2] examples/filtering_audio: added loop for draining the filtergraph

Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- doc/examples/filtering_audio.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/examples/filtering_audio.c b/doc/examples/filtering_audio.c index 18d6ca2..070d0cb3 100644 --- a/doc/examples/filtering_audio.c

[FFmpeg-devel] [PATCH 2/2] examples/filtering_video: added loop for draining the filtergraph

Signed-off-by: Tobias Rapp <t.r...@noa-archive.com> --- doc/examples/filtering_video.c | 19 +++ 1 file changed, 19 insertions(+) diff --git a/doc/examples/filtering_video.c b/doc/examples/filtering_video.c index 9b607ba..be00a1b 100644 --- a/doc/examples/filtering_video.c

Re: [FFmpeg-devel] [PATCH] add dumpwave filter

On 15.01.2018 13:48, Dmytro Humeniuk wrote: On 15 Jan 2018, at 09:14, Tobias Rapp <t.r...@noa-archive.com> wrote: On 13.01.2018 23:52, Дмитрий Гуменюк wrote: Hi, On 13 Jan 2018, at 01:37, Дмитрий Гуменюк <dmitry.gumen...@gmail.com> wrote: Hi On 12 Jan 2018, at 13:32, Дми

<    1   2   3   4   5   >