tis 2021-08-24 klockan 13:18 +0200 skrev Marc-Antoine Arnaud:
---
libavformat/mxfdec.c | 24
1 file changed, 12 insertions(+), 12 deletions(-)
Fine by me
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
tor 2021-08-12 klockan 14:38 +0200 skrev Marc-Antoine Arnaud:
@@ -177,6 +179,7 @@ typedef struct {
int body_sid;
MXFWrappingScheme wrapping;
int edit_units_per_packet; /* how many edit units to read at a
time (PCM, ClipWrapped) */
+ int* channel_ordering;
Is there a maximum
@@ -2681,6 +2845,88 @@ static int
mxf_parse_structural_metadata(MXFContext *mxf)
st->internal->need_parsing = AVSTREAM_PARSE_FULL;
}
st->codecpar->bits_per_coded_sample =
av_get_bits_per_sample(st->codecpar->codec_id);
+
+ current_channel = 0;
sön 2021-09-05 klockan 21:24 +0200 skrev Michael Niedermayer:
> Fixes: Out of array access
> Fixes: 37030/clusterfuzz-testcase-minimized-ffmpeg_DEMUXER_fuzzer-
> 5387719147651072
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
>
fre 2021-09-17 klockan 04:08 +0200 skrev Andreas Rheinhardt:
> Up until now, each call to avpriv_elbg_do() would result
> in at least six allocations. And this function is called a lot:
> A typical FATE run results in 52213653 calls to av_malloc; of these,
> 34974671 originate from av_malloc_array
fre 2021-09-17 klockan 04:08 +0200 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/cinepakenc.c | 28 ++--
> 1 file changed, 22 insertions(+), 6 deletions(-)
Gave this one a try with -vframes 100 -s 640x360 for some random clips
on my
fre 2021-09-17 klockan 04:02 +0200 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/elbg.c | 9 +++--
> 1 file changed, 3 insertions(+), 6 deletions(-)
>
> diff --git a/libavcodec/elbg.c b/libavcodec/elbg.c
> index d012d9a384..795fc83f16 100644
> ---
fre 2021-09-17 klockan 04:08 +0200 skrev Andreas Rheinhardt:
> This is possible because the number of elements needed in each
> recursion step decreases geometrically, so the geometric series
> provides an upper bound for the sum of number of elements of
> the needed buffers.
Looks like a thing
ons 2021-09-15 klockan 12:14 +0200 skrev Marc-Antoine Arnaud:
+static int mxf_read_mca_sub_descriptor(void *arg, AVIOContext *pb, int
tag, int size, UID uid, int64_t klv_offset)
+{
+ MXFMCASubDescriptor *mca_sub_descriptor = arg;
+
+ if (IS_KLV_KEY(uid, mxf_mca_prefix)) {
+ if
sön 2021-08-01 klockan 03:55 +0200 skrev Marton Balint:
> The code expects every kind of metadata set to start with the generic metadata
> set attributes.
>
> Signed-off-by: Marton Balint
> ---
> libavformat/mxfdec.c | 66 ++--
> 1 file changed, 21
arton Balint:
> > > > > On Sat, 3 Jul 2021, Tomas Härdin wrote:
> > > > >
> > > > > > lör 2021-07-03 klockan 15:13 +0200 skrev emco...@ffastrans.com:
> > > > > > > Unfortunately the wetransfer link for the fate samples expi
> -static int64_t mxf_write_cdci_common(AVFormatContext *s, AVStream *st, const
> UID key)
> +static int64_t mxf_write_generic_desc(AVFormatContext *s, AVStream *st,
> const UID key)
> {
> MXFStreamContext *sc = st->priv_data;
> AVIOContext *pb = s->pb;
> @@ -1115,7 +1133,7 @@ static
fre 2021-09-24 klockan 10:30 + skrev Soft Works:
> Hi,
>
> for a new filter, I want to rescale PAL8 subtitle bitmaps where the
> palette includes
> colors with alpha.
Isn't this typically done at the player level? What's your use case?
>
> From what I’ve seen, swscale doesn’t support
mån 2021-09-20 klockan 23:18 +0200 skrev Andreas Rheinhardt:
> This improves performance: For msvideo1, the performance improved by
> 4.8% when encoding the sample from the fate-vsynth1-msvideo1 test;
> when encoding the sample from fate-vsynth1-cinepak, performance
> improved by 2%. The compiler
tor 2021-09-23 klockan 00:02 +0200 skrev Marton Balint:
On Fri, 17 Sep 2021, Marc-Antoine Arnaud wrote:
> ---
> libavformat/mxf.h | 1 +
> libavformat/mxfdec.c | 277
> ++-
> 2 files changed, 272 insertions(+), 6 deletions(-)
I guess the questionable
mån 2021-10-11 klockan 18:32 +0200 skrev Marc-Antoine Arnaud:
> ---
> libavformat/mxf.h | 1 +
> libavformat/mxfdec.c | 276
> ++-
> 2 files changed, 271 insertions(+), 6 deletions(-)
Did we reach a consensus on this? While I think signalling ffmpeg
mån 2021-10-18 klockan 17:06 +0200 skrev Marc-Antoine Arnaud:
>
> +static int mxf_audio_remapping(int* channel_ordering, uint8_t* data,
> int size, int sample_size, int channels)
> +{
> + int sample_offset = channels * sample_size;
> + int number_of_samples = size / sample_offset;
> +
tis 2021-09-28 klockan 16:41 +0200 skrev Andreas Rheinhardt:
> ff_encode_preinit() already checked the pixel format via
> AVCodec.pix_fmts.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavcodec/zmbvenc.c | 3 ---
> 1 file changed, 3 deletions(-)
>
> diff --git a/libavcodec/zmbvenc.c
tis 2021-11-30 klockan 10:22 +0100 skrev Nicolas Gaullier:
Fix GC container ul.
Fix GC element type both for the generic case and for OPAtom.
Thanks to Philip de Nier
for checking the values, especially for OPAtom.
---
libavformat/mxfenc.c | 8 ++--
tests/ref/lavf/mxf_opatom | 2 +-
2
tis 2021-12-21 klockan 11:44 +0100 skrev Marc-Antoine ARNAUD:
> Le ven. 17 déc. 2021 à 19:12, Marton Balint a écrit :
>
> >
> >
> > On Fri, 17 Dec 2021, Marc-Antoine ARNAUD wrote:
> >
> > > Hi all,
> > >
> > > Can I have an update on this patch submission ?
> > > Is something required to be
tor 2021-12-16 klockan 02:29 +0100 skrev Andreas Rheinhardt:
> This removes the last usage of sizeof(AVPacket) in the generic
> muxing code.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mux.c | 8 +---
> libavformat/mxfenc.c | 8 ++--
> 2 files changed, 3 insertions(+),
ons 2021-12-22 klockan 23:24 + skrev Soft Works:
> Hi,
>
> holidays are approaching and I got a little present for all of you
> even though it won’t be something for everybody.
>
> A while ago I had committed to prepare a test setup for integrating
> GitHub in a similar way as the Git
tis 2021-12-21 klockan 21:24 +0100 skrev Marton Balint:
>
>
> On Tue, 21 Dec 2021, Tomas Härdin wrote:
>
> > tis 2021-12-21 klockan 11:44 +0100 skrev Marc-Antoine ARNAUD:
> > > Le ven. 17 déc. 2021 à 19:12, Marton Balint a
> > > écrit :
> > >
ons 2021-11-10 klockan 14:52 +0100 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> > > These tests exhibit two bugs: Instead of using the in-band
> > > extradata
> > > the demuxer makes up some ext
ons 2021-11-10 klockan 14:21 +0100 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > tis 2021-11-09 klockan 22:07 +0100 skrev Andreas Rheinhardt:
> > > Tomas Härdin:
> > > > tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt:
> > > > > The mxf
lör 2021-10-30 klockan 10:28 -0400 skrev Ronald S. Bultje:
> Hi,
>
> On Sat, Oct 30, 2021 at 4:57 AM Tomas Härdin
> wrote:
>
> > Maybe we should upgrade to C11 then? This gives us access to more
> > useful language features. Type-generic expressions look
fre 2021-10-29 klockan 21:17 -0400 skrev Ronald S. Bultje:
> Hi Thomas,
>
> On Fri, Oct 29, 2021 at 9:12 AM Tomas Härdin
> wrote:
>
> > tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol:
> > > + const uint16_t *src = (const uint16_t *)ssrc;
> >
&g
tor 2021-10-28 klockan 21:09 +0200 skrev Paul B Mahol:
>
> +FRAMESYNC_DEFINE_CLASS(wpsnr, WPSNRContext, fs);
> +
> +#define COMPUTE_HX(type, stype, depth) \
> +static void compute_hx##depth(const uint8_t *ssrc, \
> + int linesize, \
> +
fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol:
> On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin
> wrote:
> >
> > > +static double get_hx(const uint8_t *src, int linesize, int w,
> > > int h)
> > > +{
> > > + int64_t sum
Looks like you messed up the subject. You need two newlines between the
title of the patch and the description.
This patch also mixes a lot of different changes. Please split it up.
The bigger a patch is the more rounds of review it tends to have to go
through.
> + { 0x840B,
>
ons 2021-10-27 klockan 15:50 +0200 skrev Marc-Antoine Arnaud:
> +if(channel_ordering_ptr->service_type !=
> AV_AUDIO_SERVICE_TYPE_NB) {
> +ast = (enum
> AVAudioServiceType*)av_stream_new_side_data(st,
> AV_PKT_DATA_AUDIO_SERVICE_TYPE,
fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol:
> On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin
> wrote:
>
> > fre 2021-10-29 klockan 15:33 +0200 skrev Paul B Mahol:
> > > On Fri, Oct 29, 2021 at 3:12 PM Tomas Härdin
> > > wrote:
> > > >
>
fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol:
> On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin
> wrote:
>
> > fre 2021-10-29 klockan 17:00 +0200 skrev Paul B Mahol:
> > > On Fri, Oct 29, 2021 at 4:46 PM Tomas Härdin
> > > wrote:
> > >
> &
sön 2021-11-07 klockan 12:32 +0100 skrev Marton Balint:
>
> > +
> > + while (channel_ordering_ptr->uid[0]) {
> > + if (IS_KLV_KEY(channel_ordering_ptr->uid,
> > mca_sub_descriptor->mca_label_dictionary_id)) {
>
> You should check if current_channel <
tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt:
> The mxf and mxf_opatom muxer expect H.264 in Annex B format.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> The check here is taken from mpegtsenc.
You didn't think to make both muxers share code instead of copy-
pasting?
/Tomas
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index d1c4d43a50..3b6604d0d6 100644
> ---
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> Also covers writing mastering display metadata.
So you're merging the D-10 user comments test and ProRes remuxing? What
about remuxing D-10?
/Tomas
___
ffmpeg-devel mailing list
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> None of the muxers here has the AVFMT_NOSTREAMS flag set,
> so it is checked generically that there are streams.
Didn't know about AVFMT_NOSTREAMS
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 3 ---
> 1
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 16
> 1 file changed, 8 insertions(+), 8 deletions(-)
Aha, this one does exactly what I just suggested with return values.
D'oh!
Looks OK of course
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 10 +++---
> 1 file changed, 3 insertions(+), 7 deletions(-)
>
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index cf63340313..aa9857fcff 100644
>
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfdec.c | 13 +++--
> 1 file changed, 3 insertions(+), 10 deletions(-)
>
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index af9d33f796..4191e82474 100644
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> The MXF muxers only write the header after they have received
> a packet; the actual write_header function does not write anything.
> So make an init function out of it.
New API being put to good use. Patch looks OK
We could write
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> (Unless the packet has a size of zero, the packet will run afoul
> of the cbr_index check a few lines below.)
>
> Signed-off-by: Andreas Rheinhardt
> ---
> libavformat/mxfenc.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> It is just a flag per supported CID. So there is no reason to use
> an avpriv function for this purpose.
This is data duplication. Honestly these ULs should probably live in
dnxhddata.c.
>
> Signed-off-by: Andreas Rheinhardt
> ---
tis 2021-11-09 klockan 22:48 +0100 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> > > It is just a flag per supported CID. So there is no reason to use
> > > an avpriv function for this purpose.
> &
tis 2021-11-09 klockan 22:07 +0100 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > tis 2021-11-09 klockan 18:34 +0100 skrev Andreas Rheinhardt:
> > > The mxf and mxf_opatom muxer expect H.264 in Annex B format.
> > >
> > > Signed-off-by: Andreas Rheinhardt
&
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> The actual frame_size is no longer used since commit
> 3d38e45eb85c7a2420cb48a9cd45625c28644b2e; and the check for
> "< 0" is equivalent to the CID being valid. But this is already
> ensured by mxf_dnxhd_codec_uls containing this CID.
tis 2021-11-09 klockan 19:01 +0100 skrev Andreas Rheinhardt:
> These tests exhibit two bugs: Instead of using the in-band extradata
> the demuxer makes up some extradata designed for AVC intra tracks
> that lack in-band extradata; these files are nevertheless decodable
> because of the in-band
> + if(channel_ordering_ptr->service_type !=
> AV_AUDIO_SERVICE_TYPE_NB) {
> + ast = (enum
> AVAudioServiceType*)av_stream_new_side_data(st,
> AV_PKT_DATA_AUDIO_SERVICE_TYPE, sizeof(*ast));
ast == NULL still needs handling here
I don't
fre 2021-10-29 klockan 19:43 +0200 skrev Paul B Mahol:
> On Fri, Oct 29, 2021 at 7:26 PM Tomas Härdin
> wrote:
>
> > fre 2021-10-29 klockan 19:17 +0200 skrev Paul B Mahol:
> > > On Fri, Oct 29, 2021 at 6:59 PM Tomas Härdin
> > > wrote:
> > >
> &
lör 2021-12-04 klockan 22:32 +0100 skrev Michael Niedermayer:
> Fixes: shift exponent 4294967163 is too large for 32-bit type 'int'
> Fixes: 41449/clusterfuzz-testcase-minimized-ffmpeg_IO_DEMUXER_fuzzer-
> 6183636217495552
>
> Found-by: continuous fuzzing process
>
sön 2021-12-05 klockan 22:19 +0100 skrev Michael Niedermayer:
> Fixes: memleak
> Fixes: 41596/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-
> 6439060204290048
>
> Found-by: continuous fuzzing process
> https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg
> Signed-off-by: Michael
fre 2021-12-03 klockan 09:38 + skrev Nicolas Gaullier:
> > Please add a reference to the relevant SMPTE document in the
> > comment, or perhaps at the list of references at the start of the
> > file
> >
> > /Tomas
>
> I have added the reference to ST2019-4 for "VC3 mapping", so that
> should
ons 2021-12-08 klockan 02:18 +0100 skrev Marton Balint:
>
>
> On Wed, 8 Dec 2021, Tomas Härdin wrote:
>
> > fre 2021-12-03 klockan 09:38 + skrev Nicolas Gaullier:
> > > > Please add a reference to the relevant SMPTE document in the
> > > > com
tis 2021-12-14 klockan 16:27 +0100 skrev Nicolas Gaullier:
> Signed-off-by: Nicolas Gaullier
> ---
> libavformat/mxfenc.c | 2 +-
> tests/ref/lavf/mxf_opatom | 2 +-
> 2 files changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/libavformat/mxfenc.c b/libavformat/mxfenc.c
> index
tis 2021-12-14 klockan 16:27 +0100 skrev Nicolas Gaullier:
> The values for the essence element type were updated in the spec
> from 0x05/0x06 (ST2019-4 2008) to 0x0C/0x0D (ST2019-4 2009).
>
> Fixes ticket #6380.
>
> Thanks-to: Philip de Nier
> Thanks-to: Matthieu Bouron
>
> Signed-off-by:
fre 2021-12-10 klockan 08:54 +0100 skrev Paul B Mahol:
> This is the first warning to revert all patches that made cfr
> decoders vfr.
Would be good if you named said patches
/Tomas
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
tor 2022-03-03 klockan 10:44 -0500 skrev Jack Bruienne:
>
> From the wiki page (https://wiki.vexatos.com/dfpwm):
> > DFPWM (Dynamic Filter Pulse Width Modulation) is an audio codec
> > created by Ben “GreaseMonkey” Russell in 2012, originally to be
> > used
> > as a voice codec for asiekierka's
mån 2022-03-07 klockan 22:04 -0500 skrev Jack Bruienne:
> On 3/7/22 06:03, Tomas Härdin wrote:
>
> > tor 2022-03-03 klockan 10:44 -0500 skrev Jack Bruienne:
> > > From the wiki page (https://wiki.vexatos.com/dfpwm):
> > > > DFPWM (Dynamic Filter Pulse Wi
+static const AVOption dfpwm_options[] = {
+{ "sample_rate", "", offsetof(DFPWMAudioDemuxerContext,
sample_rate), AV_OPT_TYPE_INT, {.i64 = 48000}, 0, INT_MAX,
AV_OPT_FLAG_DECODING_PARAM },
+{ "channels","", offsetof(DFPWMAudioDemuxerContext, channels),
AV_OPT_TYPE_INT, {.i64 = 1}, 0,
mån 2022-03-14 klockan 10:56 +0100 skrev Paul B Mahol:
> On Mon, Mar 14, 2022 at 10:47 AM Tomas Härdin
> wrote:
>
> > +static const AVOption dfpwm_options[] = {
> > + { "sample_rate", "", offsetof(DFPWMAudioDemuxerContext,
> > sample_rat
tis 2022-03-15 klockan 21:05 +0100 skrev Andreas Rheinhardt:
> Returns better error messages in case of error and deduplicates
> the inflateInit() code.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> configure | 2 +-
> libavcodec/zmbv.c | 38 ++
> 2
ons 2022-03-16 klockan 20:32 +0100 skrev Andreas Rheinhardt:
> Tomas Härdin:
> > > +int ff_inflate_init(FFZStream *z, void *logctx)
> > > +{
> > > + z_stream *const zstream = >zstream;
> > > + int zret;
> > > +
> > &g
ons 2022-03-16 klockan 20:38 +0100 skrev Marton Balint:
>
>
> On Wed, 16 Mar 2022, Tomas Härdin wrote:
>
> > mån 2022-03-14 klockan 21:44 +0100 skrev Marton Balint:
> > >
> > >
> > > On Mon, 14 Mar 2022, Tomas Härdin wrote:
> > >
> >
tis 2022-03-15 klockan 21:06 +0100 skrev Andreas Rheinhardt:
> They emit better error messages (it does not claim that inflateInit
> failed upon an error from deflateInit!) and uses our allocation
> functions.
>
> Signed-off-by: Andreas Rheinhardt
> ---
> configure | 2 +-
>
> +int ff_inflate_init(FFZStream *z, void *logctx)
> +{
> + z_stream *const zstream = >zstream;
> + int zret;
> +
> + z->inited = 0;
> + zstream->next_in = Z_NULL;
> + zstream->avail_in = 0;
> + zstream->zalloc = Z_NULL;
> + zstream->zfree = Z_NULL;
> +
mån 2022-03-14 klockan 21:44 +0100 skrev Marton Balint:
>
>
> On Mon, 14 Mar 2022, Tomas Härdin wrote:
>
> > mån 2022-03-14 klockan 20:54 +0100 skrev Marton Balint:
> > >
> > >
> > > On Mon, 14 Mar 2022, Tomas Härdin wrote:
> > >
> >
mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint:
> Only index tables repeating previous index tables should use the same
> InstaceUID. Use the index start position when generating the
> InstanceUID to fix
> this.
>
> Signed-off-by: Marton Balint
> ---
> libavformat/mxfenc.c | 2 +-
> 1
sön 2022-03-13 klockan 00:52 +0100 skrev Michael Niedermayer:
> Signed-off-by: Michael Niedermayer
> ---
> libavformat/mxfdec.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index d7cdd22c8a..828fc0f9f1 100644
> ---
mån 2022-03-14 klockan 20:54 +0100 skrev Marton Balint:
>
>
> On Mon, 14 Mar 2022, Tomas Härdin wrote:
>
> > mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint:
> > > Only index tables repeating previous index tables should use the
> > > same
> >
sön 2022-03-13 klockan 00:52 +0100 skrev Michael Niedermayer:
> Signed-off-by: Michael Niedermayer
> ---
> libavformat/mxfdec.c | 8 +++-
> 1 file changed, 7 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c
> index b85c10bf19..d7cdd22c8a 100644
> ---
mån 2022-03-14 klockan 20:57 +0100 skrev Marton Balint:
>
>
> On Mon, 14 Mar 2022, Tomas Härdin wrote:
>
> > mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint:
> > > Also make sure we do not change the product UID.
> > >
> > > Signed-off-by
mån 2022-03-14 klockan 19:49 +0100 skrev Marton Balint:
> Also make sure we do not change the product UID.
>
> Signed-off-by: Marton Balint
> ---
> libavformat/mxfenc.c | 9 +
> tests/ref/fate/copy-trac4914 | 2 +-
> tests/ref/fate/mxf-d10-user-comments
> + // Test $IPFS_GATEWAY.
> + if (getenv("IPFS_GATEWAY") != NULL) {
> + snprintf(c->gateway_buffer, sizeof(c->gateway_buffer), "%s",
> + getenv("IPFS_GATEWAY"));
might want to error check this one
> + ret = 1;
> + goto err;
> + } else
> +
> + IPFSGatewayContext *c = h->priv_data;
> + char ipfs_full_data_folder[PATH_MAX];
> + char ipfs_gateway_file[PATH_MAX];
> + struct stat st;
> + int stat_ret = 0;
> + int ret = AVERROR(EINVAL);
> + FILE *gateway_file = NULL;
> +
> + // Set the first character of
tor 2022-02-17 klockan 15:26 +0100 skrev Mark Gaiser:
> >
> > > +
> > > + // Test $IPFS_GATEWAY.
> > > + if (getenv("IPFS_GATEWAY") != NULL) {
> > > + if (snprintf(c->gateway_buffer, sizeof(c-
> > > >gateway_buffer),
> > > "%s",
> > > + getenv("IPFS_GATEWAY")) >=
sön 2022-02-27 klockan 15:29 +0100 skrev Mark Gaiser:
> Ping 2
>
> I'd really like to get this merged!
> This kinda blocks me right now from proceeding with IPFS integration
> in
> Kodi, MPV and VLC. Implementations in those (who rely on ffmpeg) are
> significantly easier once this patch is
tor 2022-02-10 klockan 02:13 +0100 skrev Mark Gaiser:
> This patch adds support for:
> - ffplay ipfs://
> - ffplay ipns://
>
> IPFS data can be played from so called "ipfs gateways".
> A gateway is essentially a webserver that gives access to the
> distributed IPFS network.
>
> This protocol
ons 2022-02-09 klockan 18:36 +0100 skrev Mark Gaiser:
> >
> Thank you so much for all the valuable feedback! It's much
> appreciated :)
>
> I'll fix all the still open issues and send another patch mail
> somewhere
> later this week.
> Question though, as this seems to be heading towards the
/src/consulting
index 01e4995..96a5b28 100644
--- a/src/consulting
+++ b/src/consulting
@@ -106,6 +106,18 @@ E.g.:
+
+
+ Tomas Härdin
+
+Tomas is located in Umeå, Sweden.
+He has worked on FFmpeg since 2009 and has been a maintainer since 2010
ons 2022-03-23 klockan 16:26 +1100 skrev Peter Ross:
> on glibc memory.h drags in string.h, but codec2 does not use any
> str* or mem* functions. additionally, memory.h is not part of the
> C99 or POSIX standards.
> ---
> libavformat/codec2.c | 1 -
> 1 file changed, 1 deletion(-)
>
> diff --git
lör 2022-03-19 klockan 23:50 +0100 skrev Michael Niedermayer:
> On Mon, Mar 14, 2022 at 08:19:51PM +0100, Tomas Härdin wrote:
> > sön 2022-03-13 klockan 00:52 +0100 skrev Michael Niedermayer:
> > > Signed-off-by: Michael Niedermayer
> > > ---
> > > libavformat
sön 2022-03-27 klockan 10:02 +0530 skrev Gyan Doshi:
>
>
> On 2022-03-27 05:15 am, Michael Niedermayer wrote:
> > On Thu, Mar 24, 2022 at 03:53:56PM +0100, Tomas Härdin wrote:
> > > consulting | 12
> > >
Trying to keep my biz emails relatively free of spam
From 51071ad87c47e0231b3d364adfe78c2ccbf9ad6d Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=
Date: Tue, 29 Mar 2022 15:18:06 +0200
Subject: [PATCH] web/consulting: Obfuscate email a bit
---
src/consulting | 2 +-
1 file
sön 2022-03-20 klockan 15:06 +0100 skrev Michael Niedermayer:
> On Sun, Mar 20, 2022 at 02:05:41PM +0100, Tomas Härdin wrote:
> > lör 2022-03-19 klockan 23:50 +0100 skrev Michael Niedermayer:
> [...]
> > >
> > >
> > > >
> > > > > +
&
tis 2022-02-01 klockan 22:58 +0100 skrev Mark Gaiser:
>
> +typedef struct Context {
> + AVClass *class;
> + URLContext *inner;
> + char *gateway;
Is there not a maximum length that an HTTP URL can be? At least without
query parameters. That way you avoid dynamic allocations. You'd have
tis 2022-02-01 klockan 22:18 +0100 skrev Mark Gaiser:
>
> To give you an idea of how it looks. Kodi has so called strm (stream)
> files. They can contain an url that can be played.
>
> Without this patch an ipfs file would look like this:
>
>
mån 2022-01-31 klockan 23:00 +0100 skrev Mark Gaiser:
> On Mon, Jan 31, 2022 at 9:23 PM Tomas Härdin
> wrote:
>
> > mån 2022-01-31 klockan 17:31 +0100 skrev Mark Gaiser:
> > > On Mon, Jan 31, 2022 at 4:52 PM Tomas Härdin
> > > wrote:
> > >
> > &
tis 2022-02-01 klockan 11:06 +0100 skrev Michael Niedermayer:
> On Mon, Jan 31, 2022 at 09:22:52PM +0100, Tomas Härdin wrote:
> [...]
> > It strikes me that this borders on incorporating business logic
> > within
> > lavf. A user could achieve the same thing with
ons 2022-02-02 klockan 14:56 +0100 skrev Mark Gaiser:
> On Wed, Feb 2, 2022 at 2:21 PM Tomas Härdin
> wrote:
>
> > tis 2022-02-01 klockan 22:58 +0100 skrev Mark Gaiser:
> >
> > >
> > > +typedef struct Context {
> > > + AVClass *class;
> &
ons 2022-02-02 klockan 14:48 +0100 skrev Michael Niedermayer:
> On Tue, Feb 01, 2022 at 05:43:24PM +0100, Tomas Härdin wrote:
> > tis 2022-02-01 klockan 11:06 +0100 skrev Michael Niedermayer:
> > > On Mon, Jan 31, 2022 at 09:22:52PM +0100, Tomas Härdin wrote:
> > >
tor 2022-02-03 klockan 18:29 +0100 skrev Mark Gaiser:
>
> +typedef struct IPFSGatewayContext {
> + AVClass *class;
> + URLContext *inner;
> + char *gateway;
Consider two separate variables. One for AVOption and one for the
dynamically allocated string. Or put the latter on the stack.
>
mån 2022-01-31 klockan 14:51 +0100 skrev Mark Gaiser:
>
> There are multiple ways to access files on the IPFS network. This
> patch series
> uses the gateway driven way. An IPFS node - by default - exposes a
> local
> gateway (say http://localhost:8080) which is then used to get content
> from
mån 2022-01-31 klockan 17:31 +0100 skrev Mark Gaiser:
> On Mon, Jan 31, 2022 at 4:52 PM Tomas Härdin
> wrote:
>
> > mån 2022-01-31 klockan 14:51 +0100 skrev Mark Gaiser:
> > >
> > > There are multiple ways to access files on the IPFS network. This
> >
fre 2022-02-04 klockan 15:12 +0100 skrev Mark Gaiser:
> On Fri, Feb 4, 2022 at 12:10 PM Tomas Härdin
> wrote:
>
> > tor 2022-02-03 klockan 18:29 +0100 skrev Mark Gaiser:
> > >
> > > +typedef struct IPFSGatewayContext {
> > > + AVClass *class;
>
lör 2022-02-05 klockan 22:59 +1000 skrev Zane van Iperen:
> Signed-off-by: Zane van Iperen
> ---
> libavformat/Makefile | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/libavformat/Makefile b/libavformat/Makefile
> index 3dc6a479cc..6566e40cac 100644
> ---
ons 2022-01-12 klockan 22:55 -0300 skrev James Almer:
> From: Vittorio Giovara
>
> Signed-off-by: Vittorio Giovara
> Signed-off-by: James Almer
> ---
> libavformat/lxfdec.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/libavformat/lxfdec.c b/libavformat/lxfdec.c
ons 2022-01-12 klockan 22:56 -0300 skrev James Almer:
> From: Vittorio Giovara
>
> Signed-off-by: Vittorio Giovara
> Signed-off-by: Anton Khirnov
> Signed-off-by: James Almer
> ---
> libavformat/mxfdec.c | 34 +-
> libavformat/mxfenc.c | 20
From 442bf0fbba4e13aa7d05ff5c30b07d4c94a8182c Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=
Date: Sat, 9 Apr 2022 14:38:47 +0200
Subject: [PATCH 2/3] libavcodec/cinepakenc: Mark no-skip frames as keyframes
Reset curframe whenever we generate a keyframe.
Use -g instead of
From 3cca353f177b9b91e1472fa60a6295e576142c59 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Tomas=20H=C3=A4rdin?=
Date: Sat, 9 Apr 2022 10:21:31 +0200
Subject: [PATCH 1/3] doc/encoders.texi: Document cinepak encoder
---
doc/encoders.texi | 48 +++
1 file
601 - 700 of 1282 matches
Mail list logo
