Re: [FFmpeg-devel] [PATCH v2 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-23 Thread quietvoid
On 23/09/2021 01.33, Andreas Rheinhardt wrote: diff --git a/libavformat/dovi_isom.h b/libavformat/dovi_isom.h index 9d9a05bdb0..b58ab1bea0 100644 --- a/libavformat/dovi_isom.h +++ b/libavformat/dovi_isom.h @@ -23,7 +23,12 @@ #define AVFORMAT_DOVI_ISOM_H #include "avformat.h" +#include

[FFmpeg-devel] [PATCH v3 4/5] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-25 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 51 ++- 1 file changed, 10 insertions(+), 41 deletions(-) diff --git

[FFmpeg-devel] [PATCH v3 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-25 Thread quietvoid
The parsing was implemented in a new dovi_isom file for the unification of the mov/mpegts DOVI parsing into one function, in a following patch. Most of the Matroska elements implementation was done by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +- libavformat

[FFmpeg-devel] [PATCH v3 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-25 Thread quietvoid
, movenc uses MKTAG while matroskaenc uses MKBETAG. This would allow refactoring movenc in the future. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +- libavformat/dovi_isom.c | 40 libavformat/dovi_isom.h | 6 ++ libavformat/matroskaenc.c

[FFmpeg-devel] [PATCH v3 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-25 Thread quietvoid
Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid --- libavformat/matroska.h| 7 +++ libavformat/matroskadec.c | 44 +-- 2 files changed, 49 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h b

[FFmpeg-devel] [PATCH v3 5/5] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-25 Thread quietvoid
Also fixes incorrect parsing of dv_bl_signal_compatibility_id, which was often set to zero instead of the actual value, for mpegts only. Signed-off-by: quietvoid --- libavformat/mpegts.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

2021-10-14 Thread quietvoid
On Thu, Oct 14, 2021 at 9:52 AM wrote: > On Thu, Oct 14, 2021 at 09:45:45AM -0400, quietvoid wrote: > > On Thu, Oct 14, 2021 at 9:36 AM wrote: > > > > > On Thu, Oct 14, 2021 at 09:18:16AM -0400, f tcChlisop0 wrote: > > > > On Thu, Oct 14, 2021 at 9:10 AM

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

2021-10-14 Thread quietvoid
/mailman/listinfo/ffmpeg-devel > > > > > > To unsubscribe, visit link above, or email > > > ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe". > > > > > > > Hi, this is something I had fixed in this patchset: > > https://ffmpeg.

Re: [FFmpeg-devel] [PATCH v4 2/4] avformat/matroska{dec, enc} Parse BlockAdditionMapping elements

2021-09-27 Thread quietvoid
quietvoid: Adds handling of dvcC/dvvC block addition mappings. The parsing creates AVDOVIDecoderConfigurationRecord side data for the video track. The configuration block is written when muxing into MKV if DOVI side data is present for the track. In version 2.2 of the Dolby ISOM specification

[FFmpeg-devel] [PATCH v6 1/4] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-09-28 Thread quietvoid
supported. The new functions will be used to implement parsing/writing the DOVI config for Matroska, as well as to refactor MOV/MPEG TS to parse the DOVI box/descriptor using dovi_isom. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 133 libavformat/do

[FFmpeg-devel] [PATCH v6 3/4] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-28 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 50 +-- 1 file changed, 9 insertions(+), 41 deletions(-) diff --git

[FFmpeg-devel] [PATCH v6 2/4] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-09-28 Thread quietvoid
but it is not in the Matroska spec. Most of the Matroska element parsing was implemented by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 9 ++ libavformat/matroskadec.c | 58 +-- libavformat

[FFmpeg-devel] [PATCH v6 4/4] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-28 Thread quietvoid
Also fixes incorrect parsing of dv_bl_signal_compatibility_id, with correct skipping of dependency_pid in DOVI TS descriptor. Signed-off-by: quietvoid --- libavformat/mpegts.c | 43 +++ 1 file changed, 3 insertions(+), 40 deletions(-) diff --git

[FFmpeg-devel] [PATCH v4 1/4] avformat/dovi_isom Implement Dolby Vision configuration parsing/writing

2021-09-26 Thread quietvoid
supported. The new functions will be used to implement parsing/writing the DOVI config for Matroska. As well as to refactor MOV/MPEG TS to parse the DOVI box/descriptor using dovi_isom. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 120 libavformat/dov

[FFmpeg-devel] [PATCH v4 3/4] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-26 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 51 ++- 1 file changed, 10 insertions(+), 41 deletions(-) diff --git

[FFmpeg-devel] [PATCH v4 2/4] avformat/matroska{dec, enc} Parse BlockAdditionMapping elements

2021-09-26 Thread quietvoid
, there is also dvwC but it is not in the Matroska spec. Most of the Matroska element parsing was implemented by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 7 + libavformat/matroskadec.c | 59

[FFmpeg-devel] [PATCH v4 4/4] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-26 Thread quietvoid
Also fixes incorrect parsing of dv_bl_signal_compatibility_id, which was often set to zero instead of the actual value, for mpegts only. Signed-off-by: quietvoid --- libavformat/mpegts.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) diff

[FFmpeg-devel] [PATCH v5 2/4] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-09-27 Thread quietvoid
, there is also dvwC but it is not in the Matroska spec. Most of the Matroska element parsing was implemented by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 9 ++ libavformat/matroskadec.c | 58

[FFmpeg-devel] [PATCH v5 1/4] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-09-27 Thread quietvoid
supported. The new functions will be used to implement parsing/writing the DOVI config for Matroska. As well as to refactor MOV/MPEG TS to parse the DOVI box/descriptor using dovi_isom. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 120 libavformat/dov

[FFmpeg-devel] [PATCH v5 3/4] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-27 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 50 +-- 1 file changed, 9 insertions(+), 41 deletions(-) diff --git

[FFmpeg-devel] [PATCH v5 4/4] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-27 Thread quietvoid
Also fixes incorrect parsing of dv_bl_signal_compatibility_id, which was often set to zero instead of the actual value, for mpegts only. Signed-off-by: quietvoid --- libavformat/mpegts.c | 43 +++ 1 file changed, 3 insertions(+), 40 deletions(-) diff

Re: [FFmpeg-devel] [PATCH v3 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-26 Thread quietvoid
On 26/09/2021 07.13, myp...@gmail.com wrote: On Sat, Sep 25, 2021 at 11:58 PM quietvoid wrote: The parsing was implemented in a new dovi_isom file for the unification of the mov/mpegts DOVI parsing into one function, in a following patch. Most of the Matroska elements implementation

[FFmpeg-devel] [PATCH 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-22 Thread quietvoid
Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid --- libavformat/matroska.h| 7 ++ libavformat/matroskadec.c | 45 +-- 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h b

[FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
When muxing to Matroska, write the Block Additional Mapping if there is AV_PKT_DATA_DOVI_CONF side data present. Most of the code was implemented by Plex developers. Signed-off-by: quietvoid --- libavformat/isom.c| 42 +++ libavformat/isom.h

[FFmpeg-devel] [PATCH 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
The parsing was implemented in isom, for the unification of the mov/mpegts DOVI parsing into one function, in a later patch. Most of the implementation was done by Plex developers. Signed-off-by: quietvoid --- libavformat/isom.c| 51 +++ libavformat

[FFmpeg-devel] [PATCH 4/5] avformat/mov: Refactor DOVI box parsing to use ff_mov_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 48 +-- 1 file changed, 9 insertions(+), 39 deletions(-) diff --git

[FFmpeg-devel] [PATCH 5/5] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_mov_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Signed-off-by: quietvoid --- libavformat/mpegts.c | 41 +++-- 1 file changed, 3 insertions(+), 38 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index da8eee2414..19d26ef375 100644 --- a/libavformat/mpegts.c +++ b/libavformat/mpegts.c

[FFmpeg-devel] [PATCH v2 2/5] avformat/matroskadec: Parse dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
The parsing was implemented in a new dovi_isom file for the unification of the mov/mpegts DOVI parsing into one function, in a following patch. Most of the Matroska elements implementation was done by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +- libavformat

[FFmpeg-devel] [PATCH v2 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
When muxing to Matroska, write the Block Additional Mapping if there is AV_PKT_DATA_DOVI_CONF side data present. Most of the code was implemented by Plex developers. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +- libavformat/dovi_isom.c | 45

[FFmpeg-devel] [PATCH v2 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-22 Thread quietvoid
Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid --- libavformat/matroska.h| 7 ++ libavformat/matroskadec.c | 45 +-- 2 files changed, 50 insertions(+), 2 deletions(-) diff --git a/libavformat/matroska.h b

[FFmpeg-devel] [PATCH v2 4/5] avformat/mov: Refactor DOVI box parsing to use ff_isom_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Read at most 24 bytes, but in reality only 5 bytes are used for parsing. The rest of the bytes are reserved in the specification. Signed-off-by: quietvoid --- libavformat/mov.c | 51 ++- 1 file changed, 10 insertions(+), 41 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2 5/5] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-22 Thread quietvoid
Signed-off-by: quietvoid --- libavformat/mpegts.c | 44 1 file changed, 4 insertions(+), 40 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index da8eee2414..75ef59d186 100644 --- a/libavformat/mpegts.c +++ b/libavformat

Re: [FFmpeg-devel] [PATCH 1/5] avformat/matroskadec: Parse Block Additional Mapping elements

2021-09-22 Thread quietvoid
On 22/09/2021 20.55, Andreas Rheinhardt wrote: quietvoid: Most of the implementation was done by the Plex developers. Signed-off-by: quietvoid ---   libavformat/matroska.h    |  7 ++   libavformat/matroskadec.c | 45 +--   2 files changed, 50 insertions

Re: [FFmpeg-devel] [PATCH 3/5] avformat/matroskaenc: Write dvcC/dvvC block additional mapping

2021-09-22 Thread quietvoid
On 22/09/2021 22.03, Andreas Rheinhardt wrote: quietvoid: +put_ebml_string(pb, MATROSKA_ID_BLKADDIDNAME, "Dolby Vision configuration"); +put_ebml_uint(pb, MATROSKA_ID_BLKADDIDTYPE, type); +put_ebml_binary(pb, MATROSKA_ID_BLKADDIDEXTRADATA,

Re: [FFmpeg-devel] [PATCH v5 4/4] avformat/mpegts: Refactor DOVI descriptor parsing to use ff_isom_parse_dvcc_dvvc

2021-09-27 Thread quietvoid
On 27/09/2021 19.16, quietvoid wrote: Also fixes incorrect parsing of dv_bl_signal_compatibility_id, which was often set to zero instead of the actual value, for mpegts only. Signed-off-by: quietvoid --- libavformat/mpegts.c | 43 +++ 1 file changed

[FFmpeg-devel] [PATCH v8 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements

2021-12-03 Thread quietvoid
Tests the parsing and writing of AVDOVIDecoderConfigurationRecord, when it is present as a Dolby Vision configuration block addition mapping. Signed-off-by: quietvoid --- The required regression test file is available here: https://0x0.st/-hWK.mkv Should be moved to fate-suite/mkv/dovi-p5.mkv

Re: [FFmpeg-devel] [PATCH v8 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-12-03 Thread quietvoid
On Fri, Dec 3, 2021 at 8:19 PM wrote: > On Sat, Dec 04, 2021 at 02:09:04AM +0100, quietvoid wrote: > > From: quietvoid > > > > Improves code legibility by not using bit shifts. > > Also avoids duplicating the dvcC/dvvC ISOM box writing code. >

Re: [FFmpeg-devel] [PATCH v8 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-12-03 Thread quietvoid
On Fri, Dec 3, 2021 at 8:40 PM wrote: > On Fri, Dec 03, 2021 at 08:27:06PM -0500, quietvoid wrote: > > On Fri, Dec 3, 2021 at 8:19 PM wrote: > > > > > On Sat, Dec 04, 2021 at 02:09:04AM +0100, quietvoid wrote: > > > > From: quietvoid > > > > &

Re: [FFmpeg-devel] [PATCH v8 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-12-03 Thread quietvoid
On Fri, Dec 3, 2021 at 8:51 PM quietvoid wrote: > > On Fri, Dec 3, 2021 at 8:40 PM wrote: > >> On Fri, Dec 03, 2021 at 08:27:06PM -0500, quietvoid wrote: >> > On Fri, Dec 3, 2021 at 8:19 PM wrote: >> > >> > > On Sat, Dec 04, 2021 at 02:09:04AM +01

[FFmpeg-devel] [PATCH v8 2/5] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-12-03 Thread quietvoid
From: quietvoid Adds handling of dvcC/dvvC block addition mappings. The parsing creates AVDOVIDecoderConfigurationRecord side data. The configuration block is written when muxing into Matroska, if DOVI side data is present for the track. Most of the Matroska element parsing is based on Plex's

[FFmpeg-devel] [PATCH v8 1/5] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-12-03 Thread quietvoid
ing/writing the DOVI config for Matroska, as well as to refactor both mov/movenc to use dovi_isom functions. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 123 libavformat/dovi_isom.h | 35 2 files changed, 158 insertions(+)

[FFmpeg-devel] [PATCH v8 3/5] avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc

2021-12-03 Thread quietvoid
From: quietvoid To avoid duplicating code. The implementation in dovi_isom is identical. Signed-off-by: quietvoid --- libavformat/mov.c | 50 +-- 1 file changed, 9 insertions(+), 41 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c

[FFmpeg-devel] [PATCH v8 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-12-03 Thread quietvoid
From: quietvoid Improves code legibility by not using bit shifts. Also avoids duplicating the dvcC/dvvC ISOM box writing code. Signed-off-by: quietvoid --- libavformat/movenc.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavformat/movenc.c

[FFmpeg-devel] [PATCH v8 0/5] Add support for Matroska BlockAdditionMapping elements

2021-12-03 Thread quietvoid
implementation in the file header. - Added tests for reading/writing block addition mapping elements. quietvoid (5): avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements avformat/mov: Refactor

[FFmpeg-devel] [PATCH v11 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements

2021-12-31 Thread quietvoid
Tests the parsing and writing of AVDOVIDecoderConfigurationRecord, when it is present as a Dolby Vision configuration block addition mapping. Signed-off-by: quietvoid --- The required regression test file is available here: https://0x0.st/-hWK.mkv Should be moved to fate-suite/mkv/dovi-p5.mkv

[FFmpeg-devel] [PATCH v11 2/5] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-12-31 Thread quietvoid
. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 9 ++ libavformat/matroskadec.c | 58 +-- libavformat/matroskaenc.c | 37 + 4 files changed, 104 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH v11 1/5] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-12-31 Thread quietvoid
ing/writing the DOVI config for Matroska, as well as to refactor both mov/movenc to use dovi_isom functions. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 118 libavformat/dovi_isom.h | 35 2 files changed, 153 insertions(+)

[FFmpeg-devel] [PATCH v11 3/5] avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc

2021-12-31 Thread quietvoid
To avoid duplicating code. The implementation in dovi_isom is identical. Signed-off-by: quietvoid --- libavformat/mov.c | 50 +++ 1 file changed, 7 insertions(+), 43 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 351ecde770

[FFmpeg-devel] [PATCH v11 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-12-31 Thread quietvoid
Improves code legibility by not using bit shifts. Also avoids duplicating the dvcC/dvvC ISOM box writing code. Signed-off-by: quietvoid --- libavformat/movenc.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavformat/movenc.c b/libavformat

[FFmpeg-devel] [PATCH v11 0/5] Add support for Matroska BlockAdditionMapping elements

2021-12-31 Thread quietvoid
of bits. - matroskaenc: Corrected mkv_write_dovi to only allow profiles that are valid for dvcC/dvvC configurations. - mov: Improved code to be more concise. quietvoid (5): avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing avformat/matroska{dec, enc}: Parse

Re: [FFmpeg-devel] [PATCH v10 1/5] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-12-31 Thread quietvoid
On Fri, Dec 31, 2021 at 9:16 PM Andreas Rheinhardt wrote: > > quietvoid: > > Both parse/write implementations are based on mov/movenc. > > > > This only adds support for the "Dolby Vision configuration box". > > Other configuration boxes, such as > >

[FFmpeg-devel] [PATCH v12 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements

2022-01-01 Thread quietvoid
Tests the parsing and writing of AVDOVIDecoderConfigurationRecord, when it is present as a Dolby Vision configuration block addition mapping. Signed-off-by: quietvoid --- The required regression test file is available here: https://0x0.st/-hWK.mkv Should be moved to fate-suite/mkv/dovi-p5.mkv

[FFmpeg-devel] [PATCH v12 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2022-01-01 Thread quietvoid
Improves code legibility by not using bit shifts. Also avoids duplicating the dvcC/dvvC ISOM box writing code. Signed-off-by: quietvoid --- libavformat/Makefile | 3 ++- libavformat/movenc.c | 24 +++- 2 files changed, 9 insertions(+), 18 deletions(-) diff --git

[FFmpeg-devel] [PATCH v2] fate: Add regression tests for AVDOVIDecoderConfigurationRecord side data

2022-01-01 Thread quietvoid
Signed-off-by: quietvoid --- Files are available here (in a zip): https://0x0.st/osvi.zip Alternatively: https://drive.google.com/drive/folders/1NDhtSoJ-mP5Yi62V6j1wjjPJNq84nP3J They're all blank frames encoded with x265, remuxed with FFmpeg after the mov box is added by dlb_mp4base. MP4 files

Re: [FFmpeg-devel] [PATCH v11 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements

2022-01-01 Thread quietvoid
On Sat, Jan 1, 2022 at 2:57 AM Andreas Rheinhardt wrote: > > quietvoid: > > Tests the parsing and writing of AVDOVIDecoderConfigurationRecord, > > when it is present as a Dolby Vision configuration block addition mapping. > > > > Signed-off-by: quietvoid > >

[FFmpeg-devel] [PATCH v12 2/5] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2022-01-01 Thread quietvoid
. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 9 ++ libavformat/matroskadec.c | 58 +-- libavformat/matroskaenc.c | 37 + 4 files changed, 104 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH v12 0/5] Add support for Matroska BlockAdditionMapping elements

2022-01-01 Thread quietvoid
DEMUXER/MUXER. - fate/matroska: Fixed ffprobe test set name and requirements. As suggested here: https://ffmpeg.org/pipermail/ffmpeg-devel/2022-January/290621.html quietvoid (5): avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing avformat/matroska{dec, enc

[FFmpeg-devel] [PATCH v12 1/5] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2022-01-01 Thread quietvoid
ing/writing the DOVI config for Matroska, as well as to refactor both mov/movenc to use dovi_isom functions. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 118 libavformat/dovi_isom.h | 35 2 files changed, 153 insertions(+)

[FFmpeg-devel] [PATCH v12 3/5] avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc

2022-01-01 Thread quietvoid
To avoid duplicating code. The implementation in dovi_isom is identical. Signed-off-by: quietvoid --- libavformat/Makefile | 2 +- libavformat/mov.c| 50 +++- 2 files changed, 8 insertions(+), 44 deletions(-) diff --git a/libavformat/Makefile b

Re: [FFmpeg-devel] [PATCH v7 0/4] Add support for Matroska BlockAdditionMapping elements

2021-11-28 Thread quietvoid
ize validation in ff_isom_put_dvcc_dvvc. > - Added dvwC to the ff_isom_put_dvcc_dvvc logging. > > quietvoid (4): > avformat/dovi_isom: Implement Dolby Vision configuration > parsing/writing > avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements > avformat/mov: Refactor mov_rea

[FFmpeg-devel] [PATCH] fate: Add regression tests for AVDOVIDecoderConfigurationRecord side data

2021-11-26 Thread quietvoid
Signed-off-by: quietvoid --- Files are available here: https://drive.google.com/drive/folders/1NDhtSoJ-mP5Yi62V6j1wjjPJNq84nP3J They're all blank frames encoded with x265, remuxed with FFmpeg after the mov box is added by dlb_mp4base. Let me know if the hosting is not appropriate. I thought

[FFmpeg-devel] [PATCH v7 2/4] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-10-28 Thread quietvoid
. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 9 ++ libavformat/matroskadec.c | 58 +-- libavformat/matroskaenc.c | 45 ++ 4 files changed, 112 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH v7 0/4] Add support for Matroska BlockAdditionMapping elements

2021-10-28 Thread quietvoid
by Dolby. - Added a patch to refactor avformat/movenc to further reduce the duplicated code. The implementation in dovi_isom is the same. - Moved init_put_bits after the size validation in ff_isom_put_dvcc_dvvc. - Added dvwC to the ff_isom_put_dvcc_dvvc logging. quietvoid (4): avformat

[FFmpeg-devel] [PATCH v7 1/4] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-10-28 Thread quietvoid
ing/writing the DOVI config for Matroska, as well as to refactor both mov/movenc to use dovi_isom functions. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 121 libavformat/dovi_isom.h | 35 2 files changed, 156 insertions(+)

[FFmpeg-devel] [PATCH v7 3/4] avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc

2021-10-28 Thread quietvoid
To avoid duplicating code. The implementation in dovi_isom is identical. Signed-off-by: quietvoid --- libavformat/mov.c | 50 +-- 1 file changed, 9 insertions(+), 41 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 3fcb1dc908

[FFmpeg-devel] [PATCH v7 4/4] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-10-28 Thread quietvoid
Improves code legibility by not using bit shifts. Also avoids duplicating the dvcC/dvvC ISOM box writing code. Signed-off-by: quietvoid --- libavformat/movenc.c | 26 +- 1 file changed, 9 insertions(+), 17 deletions(-) diff --git a/libavformat/movenc.c b/libavformat

Re: [FFmpeg-devel] [PATCH 7/8] avformat/mpegts: Fix for the DOVI video stream descriptor

2021-10-27 Thread quietvoid
On Wed, Oct 27, 2021 at 10:26 AM wrote: > On Wed, Oct 27, 2021 at 11:50:04AM +0300, Jan Ekström wrote: > > On Thu, Oct 14, 2021 at 5:31 PM wrote: > > > > > > On Thu, Oct 14, 2021 at 10:12:05AM -0400, quietvoid wrote: > > > > On Thu, Oct 14, 2021 at 9:52 A

Re: [FFmpeg-devel] [PATCH v9 3/5] avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc

2021-12-07 Thread quietvoid
On Tue, Dec 7, 2021 at 9:37 AM wrote: > > On Sun, Dec 05, 2021 at 06:35:33PM +0100, quietvoid wrote: > > To avoid duplicating code. The implementation in dovi_isom is identical. > > > > Signed-off-by: quietvoid > > -

[FFmpeg-devel] [PATCH v9 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements

2021-12-05 Thread quietvoid
Tests the parsing and writing of AVDOVIDecoderConfigurationRecord, when it is present as a Dolby Vision configuration block addition mapping. Signed-off-by: quietvoid --- The required regression test file is available here: https://0x0.st/-hWK.mkv Should be moved to fate-suite/mkv/dovi-p5.mkv

[FFmpeg-devel] [PATCH v9 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-12-05 Thread quietvoid
Improves code legibility by not using bit shifts. Also avoids duplicating the dvcC/dvvC ISOM box writing code. Signed-off-by: quietvoid --- libavformat/movenc.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavformat/movenc.c b/libavformat

[FFmpeg-devel] [PATCH v9 3/5] avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc

2021-12-05 Thread quietvoid
To avoid duplicating code. The implementation in dovi_isom is identical. Signed-off-by: quietvoid --- libavformat/mov.c | 50 +-- 1 file changed, 9 insertions(+), 41 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 5c74d099da

[FFmpeg-devel] [PATCH v9 0/5] Add support for Matroska BlockAdditionMapping elements

2021-12-05 Thread quietvoid
the return type to void. The function always writes a constant number of bytes. quietvoid (5): avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements avformat/mov: Refactor mov_read_dvcc_dvvc to use

[FFmpeg-devel] [PATCH v9 1/5] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-12-05 Thread quietvoid
ing/writing the DOVI config for Matroska, as well as to refactor both mov/movenc to use dovi_isom functions. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 118 libavformat/dovi_isom.h | 35 2 files changed, 153 insertions(+)

[FFmpeg-devel] [PATCH v9 2/5] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-12-05 Thread quietvoid
. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 9 ++ libavformat/matroskadec.c | 58 +-- libavformat/matroskaenc.c | 40 +++ 4 files changed, 107 insertions(+), 4 deletions(-) diff

Re: [FFmpeg-devel] [PATCH] fate: Add regression tests for AVDOVIDecoderConfigurationRecord side data

2021-12-14 Thread quietvoid
On Fri, Nov 26, 2021 at 12:06 PM quietvoid wrote: > > Signed-off-by: quietvoid > --- > Files are available here: > https://drive.google.com/drive/folders/1NDhtSoJ-mP5Yi62V6j1wjjPJNq84nP3J > > They're all blank frames encoded with x265, remuxed with FFmpeg > af

[FFmpeg-devel] [PATCH v10 0/5] Add support for Matroska BlockAdditionMapping elements

2021-12-14 Thread quietvoid
. quietvoid (5): avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use

[FFmpeg-devel] [PATCH v10 5/5] fate/matroska: Add tests for reading/writing BlockAdditionMapping elements

2021-12-14 Thread quietvoid
Tests the parsing and writing of AVDOVIDecoderConfigurationRecord, when it is present as a Dolby Vision configuration block addition mapping. Signed-off-by: quietvoid --- The required regression test file is available here: https://0x0.st/-hWK.mkv Should be moved to fate-suite/mkv/dovi-p5.mkv

[FFmpeg-devel] [PATCH v10 2/5] avformat/matroska{dec, enc}: Parse BlockAdditionMapping elements

2021-12-14 Thread quietvoid
. Signed-off-by: quietvoid --- libavformat/Makefile | 4 +-- libavformat/matroska.h| 9 ++ libavformat/matroskadec.c | 58 +-- libavformat/matroskaenc.c | 37 + 4 files changed, 104 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH v10 4/5] avformat/movenc: Refactor mov_write_dvcc_dvvc_tag to use ff_isom_put_dvcc_dvvc

2021-12-14 Thread quietvoid
Improves code legibility by not using bit shifts. Also avoids duplicating the dvcC/dvvC ISOM box writing code. Signed-off-by: quietvoid --- libavformat/movenc.c | 24 +++- 1 file changed, 7 insertions(+), 17 deletions(-) diff --git a/libavformat/movenc.c b/libavformat

[FFmpeg-devel] [PATCH v10 3/5] avformat/mov: Refactor mov_read_dvcc_dvvc to use ff_isom_parse_dvcc_dvvc

2021-12-14 Thread quietvoid
To avoid duplicating code. The implementation in dovi_isom is identical. Signed-off-by: quietvoid --- libavformat/mov.c | 52 --- 1 file changed, 9 insertions(+), 43 deletions(-) diff --git a/libavformat/mov.c b/libavformat/mov.c index 9ebfa0bcc7

[FFmpeg-devel] [PATCH v10 1/5] avformat/dovi_isom: Implement Dolby Vision configuration parsing/writing

2021-12-14 Thread quietvoid
ing/writing the DOVI config for Matroska, as well as to refactor both mov/movenc to use dovi_isom functions. Signed-off-by: quietvoid --- libavformat/dovi_isom.c | 118 libavformat/dovi_isom.h | 35 2 files changed, 153 insertions(+)

Re: [FFmpeg-devel] [PATCH v3] avcodec/dovi_rpu: verify RPU data CRC32

2023-10-27 Thread quietvoid
On 26/10/2023 17.44, Michael Niedermayer wrote: On Wed, Aug 09, 2023 at 01:46:57PM -0400, quietvoid wrote: The Dolby Vision RPU contains a CRC32 to validate the payload against. The implementation is CRC32/MPEG-2. The CRC is only verified with the AV_EF_CRCCHECK flag. Signed-off

Re: [FFmpeg-devel] [PATCH v3] avcodec/dovi_rpu: verify RPU data CRC32

2023-10-26 Thread quietvoid
On 09/08/2023 13.46, quietvoid wrote: The Dolby Vision RPU contains a CRC32 to validate the payload against. The implementation is CRC32/MPEG-2. The CRC is only verified with the AV_EF_CRCCHECK flag. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 46

Re: [FFmpeg-devel] [PATCH v3 0/4] DOVI: Add NLQ pivots to AVDOVIDataMapping

2022-07-10 Thread quietvoid
On 17/06/2022 16.35, quietvoid wrote: The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. With the pivots parsed, the parsed values for num_{x,y}_partitions are correct and usually equal to 1

Re: [FFmpeg-devel] [PATCH v3 1/4] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-07-10 Thread quietvoid
On 10/07/2022 19.12, Andreas Rheinhardt wrote: quietvoid: The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 9 - libavutil

[FFmpeg-devel] [PATCH v3 1/4] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-06-17 Thread quietvoid
The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. Signed-off-by: quietvoid --- libavcodec/dovi_rpu.c | 9 - libavutil/dovi_meta.h | 1 + 2 files changed, 9 insertions(+), 1 deletion

[FFmpeg-devel] [PATCH v3 2/4] fftools/ffprobe: Add DOVI nlq_pivots logging

2022-06-17 Thread quietvoid
Signed-off-by: quietvoid --- fftools/ffprobe.c | 4 1 file changed, 4 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index 4e2fdbaec8..bc4f7ec0a1 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2001,6 +2001,10 @@ static void print_dovi_metadata(WriterContext *w

[FFmpeg-devel] [PATCH v3 0/4] DOVI: Add NLQ pivots to AVDOVIDataMapping

2022-06-17 Thread quietvoid
AVDOVIDataMapping end offset for copy. - Split logging patches and consolidated show_info logging into one call. quietvoid (4): libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping fftools/ffprobe: Add DOVI nlq_pivots logging libavfilter/vf_showinfo: Add DOVI nlq_pivots logging fate: Add test

Re: [FFmpeg-devel] [PATCH 1/2] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-06-17 Thread quietvoid
On Sat, Jun 11, 2022 at 12:48 PM Andreas Rheinhardt wrote: > > quietvoid: > > The NLQ pivots are not documented but should be present > > in the header for profile 7 RPU format. > > It has been verified using Dolby's verification toolkit. > > > > Also i

[FFmpeg-devel] [PATCH v2 0/2] DOVI: Add NLQ pivots to AVDOVIDataMapping

2022-06-17 Thread quietvoid
` field at the end of AVDOVIDataMapping. quietvoid (2): libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping fate: Add test to parse profile 7 DOVI RPU fftools/ffprobe.c | 4 + libavcodec/dovi_rpu.c | 7 + libavfilter/vf_showinfo.c | 8

[FFmpeg-devel] [PATCH v2 1/2] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-06-17 Thread quietvoid
The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. Also implemented the parsing in libavcodec/dovi_rpu.c. And added the info to ffprobe and showinfo. Signed-off-by: quietvoid --- fftools

[FFmpeg-devel] [PATCH v2 2/2] fate: Add test to parse profile 7 DOVI RPU

2022-06-17 Thread quietvoid
Signed-off-by: quietvoid --- tests/fate/hevc.mak | 3 + tests/ref/fate/hevc-dovi-profile7-rpu | 296 ++ 2 files changed, 299 insertions(+) create mode 100644 tests/ref/fate/hevc-dovi-profile7-rpu diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak

[FFmpeg-devel] [PATCH v3 4/4] fate: Add test to parse profile 7 DOVI RPU

2022-06-17 Thread quietvoid
Signed-off-by: quietvoid --- tests/fate/hevc.mak | 3 + tests/ref/fate/hevc-dovi-profile7-rpu | 296 ++ 2 files changed, 299 insertions(+) create mode 100644 tests/ref/fate/hevc-dovi-profile7-rpu diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak

[FFmpeg-devel] [PATCH v3 3/4] libavfilter/vf_showinfo: Add DOVI nlq_pivots logging

2022-06-17 Thread quietvoid
Signed-off-by: quietvoid --- libavfilter/vf_showinfo.c | 6 ++ 1 file changed, 6 insertions(+) diff --git a/libavfilter/vf_showinfo.c b/libavfilter/vf_showinfo.c index 6efcafce28..5dce46dbdf 100644 --- a/libavfilter/vf_showinfo.c +++ b/libavfilter/vf_showinfo.c @@ -535,6 +535,12 @@ static

Re: [FFmpeg-devel] [PATCH v2 1/2] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-06-17 Thread quietvoid
On Fri, Jun 17, 2022 at 4:20 PM Andreas Rheinhardt wrote: > > quietvoid: > > The NLQ pivots are not documented but should be present > > in the header for profile 7 RPU format. > > It has been verified using Dolby's verification toolkit. > > > > Also i

[FFmpeg-devel] [PATCH 1/2] libavutil/dovi_meta: Add nlq_pivots to AVDOVIDataMapping

2022-06-11 Thread quietvoid
The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. Also implemented the parsing in libavcodec/dovi_rpu.c. And added the info to ffprobe and showinfo. --- fftools/ffprobe.c | 4

[FFmpeg-devel] [PATCH 2/2] fate: Add test to parse profile 7 DOVI RPU

2022-06-11 Thread quietvoid
--- tests/fate/hevc.mak | 3 + tests/ref/fate/hevc-dovi-profile7-rpu | 296 ++ 2 files changed, 299 insertions(+) create mode 100644 tests/ref/fate/hevc-dovi-profile7-rpu diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak index

[FFmpeg-devel] [PATCH 0/2] DOVI: Add NLQ pivots to AVDOVIDataMapping

2022-06-11 Thread quietvoid
The NLQ pivots are not documented but should be present in the header for profile 7 RPU format. It has been verified using Dolby's verification toolkit. With the pivots parsed, the parsed values for num_{x,y}_partitions are correct and usually equal to 1. quietvoid (2): libavutil/dovi_meta

Re: [FFmpeg-devel] [PATCH v2 08/10] avcodec: add external encoder libvvenc for H266/VVC

2022-10-24 Thread quietvoid
On 24/10/2022 10.06, Thomas Siedel wrote: Add external encoder VVenC for H266/VVC encoding. Register new encoder libvvencc Add libvvenc to wrap the vvenc interface into ffmpeg libvvenc implements encoder option: preset,qp,period,subjopt,vvenc-params,levelidc,tier Enable encoder by adding

[FFmpeg-devel] [PATCH v4 4/4] fate: Add test to parse profile 7 DOVI RPU

2022-08-06 Thread quietvoid
Signed-off-by: quietvoid --- tests/fate/hevc.mak | 3 + tests/ref/fate/hevc-dovi-profile7-rpu | 296 ++ 2 files changed, 299 insertions(+) create mode 100644 tests/ref/fate/hevc-dovi-profile7-rpu diff --git a/tests/fate/hevc.mak b/tests/fate/hevc.mak

  1   2   >