[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: splice count [WIP]

2020-01-13 Thread Andreas Håkon
This patch is Work-In-Progess, and I need your help... The objective of this patch is to insert the Splicing Point Count data inside the MPEG-TS header. The current code does it for every video packet. But this is buggy as we need to insert this data at GOP boundaries. Then the code is prepared

Re: [FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-09-03 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 3 de September de 2019 9:57, Marton Balint wrote: > On Tue, 3 Sep 2019, Andreas Håkon wrote: > > > Hi, > > Ping, ping! (another time). > > Please take note of these three points: > > > > 1. Lip-S

Re: [FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-09-03 Thread Andreas Håkon
, for example, values expressed in nano-seconds), it's preferable to first add it and then improve it. ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 11:02, Andreas Håkon wrote: > Hi, > > Ping! > > ‐‐‐ Original Message ‐‐‐ > >> On Friday, 16 de August de 2

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-28 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 23:33, Marton Balint wrote: > > Please, note that the main problem at time with the mpegts muxer is that > > all PES packets are > > written sequentially. And this generates a lot of problems when the video > > PES

Re: [FFmpeg-devel] libavformat/mpegtsenc: new interleaved mux mode [v3]

2019-08-28 Thread Andreas Håkon
Hi Marton, Thank you very much for finally answering regarding this patch! ‐‐‐ Original Message ‐‐‐ On Wednesday, 28 de August de 2019 0:46, Marton Balint wrote: > On Mon, 26 Aug 2019, Andreas Håkon wrote: > > > To understand what this patch is doing, see these scree

Re: [FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-08-27 Thread Andreas Håkon
Hi, Ping! ‐‐‐ Original Message ‐‐‐ > On Friday, 16 de August de 2019 12:19, Andreas Håkon > wrote: > >> Hi, >> >> The latest version ready to merge of the bitstream filter "editpts". >> Implements all requests. >> >> This sup

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mpegtsenc: fix flushing of audio packets

2019-08-27 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Tuesday, 27 de August de 2019 9:34, Marton Balint wrote: > Fixes DTS < PCR errors with this command line: > > ./ffmpeg -loglevel verbose -y -f lavfi -i \ >

Re: [FFmpeg-devel] libavformat/mpegtsenc: new interleaved mux mode [v3]

2019-08-26 Thread Andreas Håkon
Hi, ‐‐‐ Original Message ‐‐‐ On Monday, 19 de August de 2019 21:16, Andreas Håkon wrote: > Hi, > > This is the third version of my patch for an "interleaved MPEG-TS muxer". > This new version includes all recommendations and rebases the fix of the > incorrect P

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

2019-08-26 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Friday, 23 de August de 2019 23:13, Marton Balint wrote: > On Fri, 23 Aug 2019, Marton Balint wrote: > > > On Fri, 16 Aug 2019, Andreas Håkon wrote: > > > > > Hi Marton, > > > Very good work with you

Re: [FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-08-20 Thread Andreas Håkon
Ping! ‐‐‐ Original Message ‐‐‐ On Friday, 16 de August de 2019 12:19, Andreas Håkon wrote: > Hi, > > The latest version ready to merge of the bitstream filter "editpts". > Implements all requests. > > This supersedes: > > https://patchwork

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-19 Thread Andreas Håkon
Hi Marton, Sent with ProtonMail Secure Email. ‐‐‐ Original Message ‐‐‐ On Friday, 16 de August de 2019 10:27, Andreas Håkon wrote: > Hi Marton, > > ‐‐‐ Original Message ‐‐‐ > On Wednesday, 14 de August de 2019 23:31, Marton Balint c...@passwd.hu wrote: &g

[FFmpeg-devel] libavformat/mpegtsenc: new interleaved mux mode [v3]

2019-08-19 Thread Andreas Håkon
Hi, This is the third version of my patch for an "interleaved MPEG-TS muxer". This new version includes all recommendations and rebases the fix of the incorrect PCR with multiple programs (fixed in collaboration with Marton Balint). Supersedes: https://patchwork.ffmpeg.org/patch/13745/ How to

[FFmpeg-devel] [PATCH] libavcodec: add editpts bitstream filter [v4]

2019-08-16 Thread Andreas Håkon
Hi, The latest version ready to merge of the bitstream filter "editpts". Implements all requests. This supersedes: https://patchwork.ffmpeg.org/patch/14302/ https://patchwork.ffmpeg.org/patch/14195/ https://patchwork.ffmpeg.org/patch/13743/ https://patchwork.ffmpeg.org/patch/13699/ I hope

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-16 Thread Andreas Håkon
Hi, ‐‐‐ Original Message ‐‐‐ On Saturday, 10 de August de 2019 20:05, Andreas Håkon wrote: > Hi Gyan and Nicolas, > > ‐‐‐ Original Message ‐‐‐ > On Saturday, 10 de August de 2019 17:13, Nicolas George geo...@nsup.org wrote: > > > Gyan (12019-08-10): >

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-16 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Wednesday, 14 de August de 2019 23:31, Marton Balint wrote: > I pushed this series, will post the patch which enables setting pcr period > for VBR. Great! I'll prepare my updated interleaved patch. Regards. A.H. ---

Re: [FFmpeg-devel] [PATCH 2/4] avformat/mpegtsenc: add support for setting PCR interval for VBR streams

2019-08-16 Thread Andreas Håkon
Hi Marton, Very good work with your series of patches on the mpegtsenc! ‐‐‐ Original Message ‐‐‐ On Thursday, 15 de August de 2019 1:51, Marton Balint wrote: > Also document the algorithm for the default PCR interval. > [...] > + if (ts->mux_rate > 1 || ts->pcr_period_ms >= 0) { >

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-12 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 11 de August de 2019 22:14, Marton Balint wrote: > > > +/* For VBR we select the highest multiple of frame duration > > > which is less than 100 ms. */ > > > > Don't you think it's a good idea to use the parameter "pcr_period"

Re: [FFmpeg-devel] [PATCHv2 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-11 Thread Andreas Håkon
Hi Marton, > > This new version LGTM. > Thanks. I did a slight change for VBR streams and tried to mimic the old > behaviour when selecting a PCR interval. Will post an updated version, but > that should only affect VBR. Regarding this new VBR patch I have one comment... ‐‐‐ Original

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-10 Thread Andreas Håkon
Hi Gyan and Nicolas, ‐‐‐ Original Message ‐‐‐ On Saturday, 10 de August de 2019 17:13, Nicolas George wrote: > Gyan (12019-08-10): > > > Since both pts and dts are altered, avoid pts only labels. > > Dissenting opinion: PTS is the important thing, and there are lot of > places where we

Re: [FFmpeg-devel] [PATCH 5/6] avformat/mpegtsenc: fix PCR generation intervals

2019-08-09 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 23:27, Marton Balint wrote: > PCR generation was based on counting packets for both CBR and VBR streams. > Couting packets might have worked for CBR streams (when muxrate was specified) > but it only took into account

Re: [FFmpeg-devel] [PATCH 1/6] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

2019-08-09 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 23:27, Marton Balint wrote: > The MPEG-TS muxer had a serious bug related to the use of multiple programs: > in that case, the PCR pid selection was incomplete for all services except > one. > This patch solves this

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-09 Thread Andreas Håkon
Hi Gyan, Nicolas and Alexander, ‐‐‐ Original Message ‐‐‐ On Friday, 9 de August de 2019 3:18, Alexander Strasser wrote: > > [...] > Gyan > > [...] > Nicolas George > > [...] > Alexander I appreciate your suggestions with the name. But, we need to select one. So I propose a

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-08 Thread Andreas Håkon
Hi Nicolas, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 10:46, Nicolas George wrote: > Alexander Strasser (12019-08-08): > > > Maybe others have better suggestions. > > setpts or setts, similar to lavfi. Then I proposse these two alternatives: 1) "editpts_bsf" 2)

Re: [FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-07 Thread Andreas Håkon
Hi Alexander, ‐‐‐ Original Message ‐‐‐ On Thursday, 8 de August de 2019 1:43, Alexander Strasser wrote: > On 2019-08-07 15:51 +0000, Andreas Håkon wrote: > > > Hi, > > This new version changes the name of the filter, and implements all > > suggestions.

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter [v2]

2019-08-07 Thread Andreas Håkon
Hi Alexander, ‐‐‐ Original Message ‐‐‐ On Wednesday, 7 de August de 2019 10:01, Andreas Håkon wrote: > Hi Alexander, > > ‐‐‐ Original Message ‐‐‐ > On Wednesday, 7 de August de 2019 0:24, Alexander Strasser eclip...@gmx.net > wrote: > > > Hi Andreas!

[FFmpeg-devel] libavcodec: add timeshift bitstream filter [v3]

2019-08-07 Thread Andreas Håkon
Hi, This new version changes the name of the filter, and implements all suggestions. Supersedes: https://patchwork.ffmpeg.org/patch/14195/ https://patchwork.ffmpeg.org/patch/13743/ https://patchwork.ffmpeg.org/patch/13699/ Regards. A.H. ---From 9e036e0a1dc20fd5c41686a48a5a0c2142f91de4 Mon Sep

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter [v2]

2019-08-07 Thread Andreas Håkon
Hi Alexander, ‐‐‐ Original Message ‐‐‐ On Wednesday, 7 de August de 2019 0:24, Alexander Strasser wrote: > Hi Andreas! > > On 2019-08-05 17:25 +, Andreas Håkon wrote: > > > On Monday, 5 de August de 2019 17:31, Moritz Barsnick barsn...@

Re: [FFmpeg-devel] [PATCH] avformat/mpegtsenc: fix PCR generation intervals

2019-08-05 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 4 de August de 2019 22:30, Marton Balint wrote: > PCR generation was based on counting packets for both CBR and VBR streams. > Couting packets might have worked for CBR streams (when muxrate was specified) > but it only took into account

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter [v2]

2019-08-05 Thread Andreas Håkon
Hi Moritz, ‐‐‐ Original Message ‐‐‐ On Monday, 5 de August de 2019 17:31, Moritz Barsnick wrote: > Hi Andreas, > > While trying to figure out how to add features I'd like to see into > this ;-), some remarks: > > > +Apply an offset to the PTS/DTS timestamps. > > + > > +@table @option >

Re: [FFmpeg-devel] [PATCHv2 1/4] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

2019-08-05 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Sunday, 4 de August de 2019 22:25, Marton Balint wrote: > On Sun, 4 Aug 2019, Andreas Håkon wrote: > > > Hi Marton, > > ‐‐‐ Original Message ‐‐‐ > > > > > v2: a video is stream is preferred if there are no

Re: [FFmpeg-devel] [PATCHv2 1/4] avformat/mpegtsenc: fix incorrect PCR selection with multiple programs

2019-08-04 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ > v2: a video is stream is preferred if there are no programs, just like before > the patch. Thank you for your effort! However, something is wrong with this patch regarding PCR intervals. First, try this example (using the file shared by Michael

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter

2019-08-02 Thread Andreas Håkon
Hi Paul, ‐‐‐ Original Message ‐‐‐ On Monday, 29 de July de 2019 21:19, Paul B Mahol wrote: > Documentation for bsf does document single option, thus is incomplete. Done: https://patchwork.ffmpeg.org/patch/14195/ Regards. A.H. --- ___

[FFmpeg-devel] libavcodec: add timer bitstream filter [v2]

2019-08-02 Thread Andreas Håkon
Hi, This new version completes the documentation. Supersedes: https://patchwork.ffmpeg.org/patch/13743/ Regards. A.H. ---From 9d115c9c049c5a1141ea83174794bf773359ebd0 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Fri, 2 Aug 2019 13:55:48 +0100 Subject: [PATCH] libavcodec: add timer

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-08-02 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Friday, 2 de August de 2019 10:09, Marton Balint wrote: > > > > > Maybe I miss something but as far as I see only this block needs to > > > > > be in > > > > > the loop, the rest is not. So you can actually write this: > > > > > > > > False! All

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v4]

2019-08-02 Thread Andreas Håkon
Hi Andriy, ‐‐‐ Original Message ‐‐‐ On Thursday, 1 de August de 2019 16:15, Andriy Gelman wrote: > > > If you are going to add pcr_st to MpegTSService then it would make sense > > > to move the > > > initialization to mpegts_add_service function. > > > > Good idea! Marton recommends

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-08-02 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Thursday, 1 de August de 2019 23:09, Marton Balint wrote: > On Thu, 1 Aug 2019, Andreas Håkon wrote: > > > Hi Marton, > > First of all, a new version [v4] is posted here: > > https://patchwork.ffmpeg.org/patch/14121/ > &

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-08-01 Thread Andreas Håkon
Hi Marton, First of all, a new version [v4] is posted here: https://patchwork.ffmpeg.org/patch/14121/ However, I'll comment on your suggestions, as they are reasonable. ‐‐‐ Original Message ‐‐‐ On Wednesday, 31 de July de 2019 23:58, Marton Balint wrote: > > +for (i = 0; i <

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v4]

2019-08-01 Thread Andreas Håkon
Hi Andriy, ‐‐‐ Original Message ‐‐‐ On Thursday, 1 de August de 2019 0:23, Andriy Gelman wrote: > > +for (i = 0; i < ts->nb_services; i++) { > > +service = ts->services[i]; > > +service->pcr_st = NULL; > > +} > > + > > If you are going to add pcr_st to

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter

2019-07-29 Thread Andreas Håkon
Ping ‐‐‐ Original Message ‐‐‐ On Wednesday, 24 de July de 2019 9:16, Andreas Håkon wrote: > Hi, > > ‐‐‐ Original Message ‐‐‐ > On Friday, 28 de June de 2019 10:44, Andreas Håkon > wrote: > >> Hi, >> This is a refined version of the initial v

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-07-29 Thread Andreas Håkon
Hi Juan, ‐‐‐ Original Message ‐‐‐ On Monday, 29 de July de 2019 20:12, Juan De León wrote: > Here is the second patch, I sent the first one twice accidentaly. > First patch is libavutil, this patch is libavcodec. > Interesting patch. But I have a question: Could you implement the

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-07-29 Thread Andreas Håkon
Hi Andriy, A new updated version here: https://patchwork.ffmpeg.org/patch/14121/ ‐‐‐ Original Message ‐‐‐ On Monday, 29 de July de 2019 8:46, Andriy Gelman wrote: > > The MPEG-TS muxer has a serious bug related to the PCR pid selection. > > This bug appears when more than one program

[FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v4]

2019-07-29 Thread Andreas Håkon
Hi, An updated version that fixes all previous bugs: https://patchwork.ffmpeg.org/patch/14109/ https://patchwork.ffmpeg.org/patch/14099/ https://patchwork.ffmpeg.org/patch/14036/ It passes the tests pointed by Michael Niedermayer (Sample_cut.ts) and Andriy Gelman (day_flight.mpg). I hope this

Re: [FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v2]

2019-07-28 Thread Andreas Håkon
Hi Michael, ‐‐‐ Original Message ‐‐‐ On Sunday, 28 de July de 2019 16:39, Michael Niedermayer wrote: > On Sat, Jul 27, 2019 at 08:41:02PM +0000, Andreas Håkon wrote: > > > Hi, > > This newversion fixes all the problems commented in > > https://patchwork.ffmpeg.

[FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v3]

2019-07-28 Thread Andreas Håkon
Hi, This last version fixes the small bug discovered by Michael Niedermayer: https://patchwork.ffmpeg.org/patch/14099/ This version is finally clean. Regards. A.H. ---From 08565b81aa2b6d75043e5e984da143480891c3b0 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Sun, 28 Jul 2019 19:59:51

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-27 Thread Andreas Håkon
Hi Andriy, ‐‐‐ Original Message ‐‐‐ On Saturday, 27 de July de 2019 20:06, Andreas Håkon wrote: > > Thank you for your comments! I'll write more later. Stay tuned. > > Regards. > A.H. > Check the new version https://patchwork.ffmpeg.org/patch/14

[FFmpeg-devel] libavformat/mpegtsenc: fix incorrect PCR with multiple programs [v2]

2019-07-27 Thread Andreas Håkon
Hi, This newversion fixes all the problems commented in https://patchwork.ffmpeg.org/patch/14036/ Now, it works with/without video streams. Regards. A.H. ---From c9b295c49828f31bba3879de887c7b2ed0e2641c Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Sat, 27 Jul 2019 21:28:32 +0100

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-27 Thread Andreas Håkon
Hi Andriy, I'm glad to read you! --- Original Message --- On Saturday, 27 de July de 2019 9:05, Andriy Gelman wrote: > > The MPEG-TS muxer has a serious bug related to the PCR pid selection. > > This bug appears when more than one program is used. The root cause is > > because > > the

[FFmpeg-devel] Patchwork: how to reset password?

2019-07-26 Thread Andreas Håkon
Hi, I'm sorry to post this on this mailing list. However, I need to clean my patches on the Patchwork's FFmpeg server, but the "Reset Password" service doesn't seem to work. After days of selecting the Reset Form with the correct email address (if I try to register again, the email address is in

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-25 Thread Andreas Håkon
Ping ‐‐‐ Original Message ‐‐‐ On Monday, 22 de July de 2019 14:22, Andreas Håkon wrote: > Hi, > > Based on the discussion of my previous patch > https://patchwork.ffmpeg.org/patch/13487/ > Here I publish a first part of the patch that only addresses

Re: [FFmpeg-devel] libavcodec: add timer bitstream filter

2019-07-24 Thread Andreas Håkon
Hi, ‐‐‐ Original Message ‐‐‐ On Friday, 28 de June de 2019 10:44, Andreas Håkon wrote: > Hi, > This is a refined version of the initial version for the new “timer” BSF. > Supersedes: https://patchwork.ffmpeg.org/patch/13699/ Still waiting to receive comments (or acceptance).

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-07-22 Thread Andreas Håkon
Hi Paul, Marton and Andriy, I have updated the patch following the comments. The first part that solves only the PCR bug with multiple programs is already published: https://patchwork.ffmpeg.org/patch/14036/ I hope it will soon be accepted. Regards. A.H. ---

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: fix incorrect PCR with multiple programs

2019-07-22 Thread Andreas Håkon
Hi, Based on the discussion of my previous patch https://patchwork.ffmpeg.org/patch/13487/ Here I publish a first part of the patch that only addresses the PCR problem. This supersedes too: https://patchwork.ffmpeg.org/patch/13745/ Regards. A.H. ---From

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-07-01 Thread Andreas Håkon
Hi Paul, > > I disagree. Based on your code the 4 modes do this: > > < -1 = 0 > > -1 = WRITE_HEADER > > 0 = WRITE_HEADER | ONE_PACKET_ONLY > > > > > 0 = ONE_PACKET_ONLY > > > > You documented the meaning of the "modes" in two places and created two > > helper functions to make sure you pass the

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-07-01 Thread Andreas Håkon
Hi Marton, > > > > > > - ts_st->payload = av_mallocz(ts->pes_payload_size); > > > > > > + ts_st->payload = av_mallocz(ts->parallel_mux ? > > > > > > MAX_PES_PAYLOAD : ts->pes_payload_size); > > > > > > > > > > > > > > > > Could you clarify why this needs to be changed?

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-28 Thread Andreas Håkon
Hi, > Thank you for reviewing! New version [v2] at: https://patchwork.ffmpeg.org/patch/13745/ Regards. A.H. --- ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

[FFmpeg-devel] libavformat/mpegtsenc: new interleaved mux mode [v2]

2019-06-28 Thread Andreas Håkon
Hi, This is the second version of my patch for an “interleaved mpeg-TS mux”. Supersedes: https://patchwork.ffmpeg.org/patch/13487/ Please, read the original thread for checks about the patch. Changes from the initial version: 1. Option name changed from “mpegts_extra_mux” to

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-28 Thread Andreas Håkon
Hi Marton, > Maybe it's too much work for little benefit, but instead of this a more > generic "setts" bitstream filter might be implemented which can be used to > set both PTS and DTS similar to how the setpts/asetpts filter works for > frames. New version (ready to merge) is here:

[FFmpeg-devel] libavcodec: add timer bitstream filter

2019-06-28 Thread Andreas Håkon
Hi, This is a refined version of the initial version for the new “timer” BSF. Supersedes: https://patchwork.ffmpeg.org/patch/13699/ Changes from the last version: 1. Name changed from “delayer” to “timer”. 2. Enabled negative offset values (aka time advance). 3. Improved less verbose log

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-27 Thread Andreas Håkon
Hi Reimar, > Minor note: I'd suggest a different name, "delayer" is too easily read as > e.g. "de-layer". > Could be something like add_delay for example. Good point! Or perhaps "timer" will be preferable. Ideas? Regards. A.H. --- ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Andreas Håkon
Hi Moritz, > > Wouldn't this be better if extended to be a BSF version of setpts? In > > addition to delays, rescaling as well as other ops could be carried out > > on TS. > > I second that notion, or at least the suggestion of a setpts bsf. > > IMO, there is probably some functionality in

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-26 Thread Andreas Håkon
Hi Marton, > Ok. But I believe the correct term for this is "interleaved". I have > never heard "interlaced" used for TS packets. I feel you're right: the name "interleaved mux mode" is preferable. Thank you for pointing it out! > > > > +#define PES_START 1 /* 0001 / > > > > +#define

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Andreas Håkon
Hi Gyan, > > > Example of use: > > > ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a > > > delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts > > > You can use it with VIDEO, AUDIO or DATA streams. > > > > What's the advantage over output_ts_offset? > > To answer that

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-26 Thread Andreas Håkon
Hi, > - Andreas Rheinhardt: > > Example of use: > > ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a > > delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts > > The delay applied here depends on the timebase. Wouldn't it be more > user-friendly to let the user input the

[FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-25 Thread Andreas Håkon
Example of use: ffmpeg -f mpegts -i INPUT.ts -map i:101 -c:v copy -map i:102 -bsf:a delayer=offset=3600 -c:a copy -f mpegts OUTPUT.ts You can use it with VIDEO, AUDIO or DATA streams. Regards. A.H. ---From 414a3c78dfa208b8253448d5c09fde9a8bee56cb Mon Sep 17 00:00:00 2001 From: Andreas Hakon

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-13 Thread Andreas Håkon
Hi Andriy, I'm glad you're interested in this patch. > > This patch implements a new optional "parallel muxing mode" in the MPEGTS > > muxer. > > The strategy that implements the current mux (selected by default) is based > > on > > writing full PES packages sequentially. This mode can be

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-11 Thread Andreas Håkon
Hi, An additional comment on the matter... ‐‐‐ Original Message ‐‐‐ On Monday, 10 de June de 2019 19:29, Andreas Håkon wrote: > Hi, > > --- > > --- > From aa02575cc11bed0fd2ae2a01368c8673ad48e64b Mon Sep 17 00:00:00 2001 > > From: Andreas Hakon < >

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-10 Thread Andreas Håkon
Hi, Here is a list of comments on this patch: (Note: I use for all the tests the file https://samples.ffmpeg.org/HDTV/bshi01.tp) - By default the current behavior is selected. You can verify that this patch doesn’t alter the original behavior with this simple test: $ ffmpeg-original -i

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Andreas Håkon
Hi, I need to admit that I'm completely wrong in the end. After spending a lot of time on a patch to solve the problem (making the MPEG-2 QSV encoder compatible with broadcasts), I discovered that this solution works: $ ffmpeg ... -c:v mpeg2_qsv -bsf:v 'dump_extra' -f mpegts ... Using this

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Andreas Håkon
Hi A. Rheinhardt , > > Take note that the "dump_extra" filter with the parameter "remove" can be > > used to remove > > the repetition. But contrary to popular belief (IMHO), there is no way to > > repeat these > > headers using a bitstream filter. So for this reason this patch is > >

[FFmpeg-devel] Force PCR pid in a PROGRAM

2019-06-04 Thread Andreas Håkon
Hi, Before coding of a new patch, I prefer to ask here for your ideas and thus improve the changes of acceptance of the patch. I posted before a patch to select which pid will carry the PCR timestamps. This makes sense in several scenarios: when using a non-video stream to carry PCR, when

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-06-04 Thread Andreas Håkon
Hi Marton, ‐‐‐ Original Message ‐‐‐ On Thursday, 30 de May de 2019 20:48, Reimar Döffinger wrote: > On 28.05.2019, at 12:48, Andreas Håkonandreas.ha...@protonmail.com wrote: > > > Hi, > > This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) > > A new (simpler and

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-06-04 Thread Andreas Håkon
Hi Marton, Thank you for taking the time to review this patch! ‐‐‐ Original Message ‐‐‐ On Sunday, 2 de June de 2019 1:38, Marton Balint wrote: > On Wed, 22 May 2019, Andreas Håkon wrote: > > > Hi, > > Patch to generate aligned Teletext PES packets using the MPEG

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Håkon
Hi Michael, > with which software has the generated mpeg-ts been tested ? > do you have any testecases ? Our test cases are mainly DVB-C broadcasts and mobile streaming. All clients play well. And internal testing is done using the well-known DVB Inspector. Regards. A.H. ---

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Håkon
Hi A. Rheinhardt, ‐‐‐ Original Message ‐‐‐ On Tuesday, 28 de May de 2019 13:24, Andreas Rheinhardt wrote: > > Can someone please tell me who is the official maintainer of the MPEG-TS > > muxer? > > I'm still waiting for comments regarding this patch. > > We've been using it for a

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-28 Thread Andreas Håkon
Hi, ‐‐‐ Original Message ‐‐‐ On Wednesday, 22 de May de 2019 17:04, Andreas Håkon wrote: > Patch to generate aligned Teletext PES packets using the MPEG-TS muxer > when the TS header contains data. Can someone please tell me who is the official maintainer of the MPEG-TS muxe

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

2019-05-28 Thread Andreas Håkon
Hi Andreas (Rheinhardt) and Reimar, Thank you for your comments. You're right and the code needs refactoring. I prepared a new implementation, please review it: https://patchwork.ffmpeg.org/patch/13316/ In any case, please note that the software encoder "mpeg2video" every time writes the

[FFmpeg-devel] [PATCH] libavformat/qsvenc: repeat mpeg2 missing headers [v2]

2019-05-28 Thread Andreas Håkon
Hi, This patch supersedes #13105 (https://patchwork.ffmpeg.org/patch/13105/) A new (simpler and more robust) implementationof of the reinsertion of the missing headers in the MPEG-2 bitstream from the HW QSV encoder. The problem is quite simple: The bitstream generated by the MPEG-2 QSV encoder

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-05-22 Thread Andreas Håkon
Hi, Patch to generate aligned Teletext PES packets using the MPEG-TS muxer when the TS header contains data. Regards. A.H. ---From 5b476153e0fcced53afa1b77543c2e386f08c504 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Wed, 22 May 2019 15:36:50 +0100 Subject: [PATCH] libavformat/mpegtsenc:

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding

2019-05-15 Thread Andreas Håkon
> > > > > > It is closer to be merged, but need to confirm which exact line of code > > > make difference. > > > (Your verification on Windows was appreciated.) > > > > As I pointed, the QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) check fails > > in Windows. > > This version runs without problems

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding

2019-05-15 Thread Andreas Håkon
Hi, > > The difference? > > In addition to a few extra little checks, It seems that the > > QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) check fails every time in > > Windows (almost in my environment). > > If QSV_RUNTIME_VERSION_ATLEAST(q->ver, 1, 11) always equal to zero, then co3 > won't be

Re: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding

2019-05-15 Thread Andreas Håkon
Hi, > > Subject: [FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding > > Fixes bug #7839 > > https://trac.ffmpeg.org/ticket/7839 > > Supersedes: > > #12935 - https://patchwork.ffmpeg.org/patch/12935/ > > #12872 - https://patchwork.ffmpeg.org/patch/12872/ > > Regards. > > A.H. > > It was

Re: [FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

2019-05-15 Thread Andreas Håkon
Hi Andreas, > I know nothing about QSV, but I know a bit about MPEG-2 and have > therefore taken a quick look at this: I'm running a lot of tests with QSV. So I know a little bit about that. > 1. > > > + if ((p_buf[7] & 0x1) == 1) { > > +

[FFmpeg-devel] [PATCH] libavcodec/qsvenc: fix mpeg2 encoding

2019-05-14 Thread Andreas Håkon
Fixes bug #7839 https://trac.ffmpeg.org/ticket/7839 Supersedes: #12935 - https://patchwork.ffmpeg.org/patch/12935/ #12872 - https://patchwork.ffmpeg.org/patch/12872/ Regards. A.H. ---From 49aa7d21026051dc353a8658509d2ba81520bf78 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Tue, 14 May

[FFmpeg-devel] [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

2019-05-14 Thread Andreas Håkon
Hi, A fix for the missing in-band Sequence Headers from the QSV MPEG-2 HW Encoder. Regards. A.H. ---From a0b8525e0ebfd1a3b91bad7a21cc9de5c5a01e0e Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Tue, 14 May 2019 11:07:10 +0100 Subject: [PATCH] libavformat/qsvenc: fix mpeg2 missing headers

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-05-10 Thread Andreas Håkon
Ping. Waiting to review. A.H. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: enforce PCR packets without payload

2019-04-29 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Thursday, 25 de April de 2019 11:07, Andreas Håkon wrote: > Hi, > > A patch for a new optional parameter for the mpegtsenc muxer. > > Regards. > A.H. > Hi Ali KIZIL, You do the validation tests? Hi Michael Niedermayer, Have yo

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-29 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 14:03, Andreas Håkon wrote: > > Thank you Moritz! > All applied. > > In addition, one correction regarding the initialization. > Sorry, but first version has an error. This is clean! > > Regards. > A.H.

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: enforce PCR packets without payload

2019-04-25 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Thursday, 25 de April de 2019 17:36, Ali KIZIL wrote: > Andreas Håkon andreas.ha...@protonmail.com, 25 Nis 2019 Per, 17:49 > tarihinde şunu yazdı: > > I got the point. Yet, sorry for being curious, would can affect TR101 290 > analyze resu

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: enforce PCR packets without payload

2019-04-25 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Thursday, 25 de April de 2019 16:23, Ali KIZIL wrote: > Andreas Håkon andreas.ha...@protonmail.com, 25 Nis 2019 Per, 12:07 > tarihinde şunu yazdı: > > > Hi, > > A patch for a new optional parameter for the mpegtsenc muxer.

[FFmpeg-devel] [PATCH] libavformat/mpegtsenc: enforce PCR packets without payload

2019-04-25 Thread Andreas Håkon
Hi, A patch for a new optional parameter for the mpegtsenc muxer. Regards. A.H. ---From 7f9f1a992615e15121b661d4cd1b9c1e32e1c894 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Thu, 25 Apr 2019 09:49:29 +0100 Subject: [PATCH] libavformat/mpegtsenc: enforce PCR packets without payload This

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-24 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Wednesday, 24 de April de 2019 0:58, Michael Niedermayer wrote: > On Tue, Apr 23, 2019 at 11:55:59PM +0200, Michael Niedermayer wrote: > > > On Tue, Apr 23, 2019 at 07:16:07AM +0000, Andreas Håkon wrote: > > > > &g

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 14:20, Moritz Barsnick wrote: > On Tue, Apr 23, 2019 at 12:03:11 +0000, Andreas Håkon wrote: > > > In addition, one correction regarding the initialization. > > Sorry, but first version has an error. This is cle

Re: [FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 13:43, Moritz Barsnick wrote: > On Tue, Apr 23, 2019 at 11:15:40 +0000, Andreas Håkon wrote: > > Nits: > > > Subject: libavformat: forced PCR pid in mpegts muxer > > "libavformat/mpegtsenc: allow to f

[FFmpeg-devel] [PATCH] libavformat: forced PCR pid in mpegts muxer

2019-04-23 Thread Andreas Håkon
New optional parameter “-force_prc_pid” for the mpegtsenc muxer. Regards. A.H. ---From ecda0e2f9b0e01a62f06cfb00684d11de6eb6dc2 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Tue, 23 Apr 2019 12:05:40 +0100 Subject: [PATCH] libavformat: forced PCR pid in mpegts muxer This patch provides a

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 9:29, Andreas Håkon wrote: > ‐‐‐ Original Message ‐‐‐ > On Tuesday, 23 de April de 2019 8:39, Li, Zhong zhong...@intel.com wrote: > > > I belive they are different. If you extend the MARCIO, they are act

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 8:39, Li, Zhong wrote: > > I belive they are different. If you extend the MARCIO, they are actually: > > > IMHO, your patch is only needed when disable "QSV_HAVE_CO3", but tiket#7839 > is not root caused now. > I will consider to

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 1:07, Michael Niedermayer wrote: > On Mon, Apr 22, 2019 at 11:42:57AM +0000, Andreas Håkon wrote: > > > > Please, revise the code! I hope you understand it when you look at my > > descriptions. > >

Re: [FFmpeg-devel] [PATCH] libavformat: fix copyts and muxrate in mpegts muxer

2019-04-23 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Tuesday, 23 de April de 2019 0:36, Michael Niedermayer wrote: > > > From c59569ca9426fef455edabfa648cb2ff678c1640 Mon Sep 17 00:00:00 2001 > > From: Andreas Hakon andreas.ha...@protonmail.com > > Date: Fri, 19 Apr 2019 09:32:33 +0100 > > Subject: [PATCH]

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Monday, 22 de April de 2019 14:17, myp...@gmail.com wrote: > On Mon, Apr 22, 2019 at 7:38 PM Li, Zhong zhong...@intel.com wrote: > > > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > > Of Andreas Håkon via

Re: [FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-22 Thread Andreas Håkon
‐‐‐ Original Message ‐‐‐ On Monday, 22 de April de 2019 13:33, Li, Zhong wrote: > > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf > > Of Andreas Håkon via ffmpeg-devel > > Sent: Thursday, April 18, 2019 6:11 PM > > To: FFmpeg development

  1   2   >