Re: [FFmpeg-devel] [PATCH] libavformat: fix copyts and muxrate in mpegts muxer

2019-04-19 Thread Andreas Håkon via ffmpeg-devel
‐‐‐ Original Message ‐‐‐ On Thursday, 18 de April de 2019 11:01, Andreas Håkon via ffmpeg-devel wrote: > Hi, > > This patch resolves one very specific use case: > > - When you use the mpegts muxer; > - And use the global parameter “-copyts”; > - And use th

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-19 Thread Andreas Håkon via ffmpeg-devel
‐‐‐ Original Message ‐‐‐ On Thursday, 18 de April de 2019 22:07, Michael Niedermayer wrote: > > fails to apply cleanly > > Applying: libavformat: fix inputs initialization in mpegts muxer with filters > Using index info to reconstruct a base tree... > error: patch failed:

Re: [FFmpeg-devel] [PATCH] libavformat: improve logs with cur_dts

2019-04-19 Thread Andreas Håkon via ffmpeg-devel
‐‐‐ Original Message ‐‐‐ On Thursday, 18 de April de 2019 22:13, Michael Niedermayer wrote: > On Thu, Apr 18, 2019 at 07:46:43AM +0000, Andreas Håkon via ffmpeg-devel > wrote: > > > Hi, > > This is the second part of my previous patch: > > https://patch

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
‐‐‐ Original Message ‐‐‐ On Thursday, 18 de April de 2019 13:14, Andreas Håkon wrote: > > On Wed, Apr 17, 2019 at 08:28:39PM +, Andreas Håkon via ffmpeg-devel > > wrote: > > > > > This patch solves the initialization of the inputs when using fil

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
> On Wed, Apr 17, 2019 at 08:28:39PM +0000, Andreas Håkon via ffmpeg-devel > wrote: > > > This patch solves the initialization of the inputs when using filters (a > > graph filter) with the mpegts muxer. > > This bug seems to be generated by a simple forgetting

[FFmpeg-devel] [PATCH] libavcodec: QSV protect GPB code with CO3 define

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
Hi, In response to this ticket I provide the first part of the patch: https://trac.ffmpeg.org/ticket/7839 This QSV_HAVE_GPB code needs to be protected by QSV_HAVE_CO3. Regards. A.H. ---From d43c81f5bba49e55ea867bd6afd2eef878dc0ad3 Mon Sep 17 00:00:00 2001 From: Andreas Hakon Date: Thu, 18 Apr

[FFmpeg-devel] [PATCH] libavformat: fix copyts and muxrate in mpegts muxer

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
Hi, This patch resolves one very specific use case: - When you use the mpegts muxer; - And use the global parameter “-copyts”; - And use the parameter “-muxrate” for the mpegts muxer; - And use too the parameter “-mpegts_copyts”. The problem is created because the member “first_pcr” of the

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
> Hi Carl, > > > Please split the patch. > > Carl Eugen > > OK. Here the relevant part regargind the bug fix. > I'll send another new with the log enhancement. > > Regards. > A.H. > This supersedes my previous PATCH: https://patchwork.ffmpeg.org/patch/12783/ So, please, mark it as superseded.

[FFmpeg-devel] [PATCH] libavformat: improve logs with cur_dts

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
Hi, This is the second part of my previous patch: https://patchwork.ffmpeg.org/patch/12783/ It improves the logs when the message "cur_dts is invalid" appears. If helps to identify which stream generates the trouble, and the status of the stream. A lot of users suffers with the message, and the

Re: [FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-18 Thread Andreas Håkon via ffmpeg-devel
Hi Carl, > > Please split the patch. > > Carl Eugen > OK. Here the relevant part regargind the bug fix. I'll send another new with the log enhancement. Regards. A.H. From af81338c21c67c0ef2c30ab2009c7094b32327f4 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Andreas=20H=C3=A5kon?= Date: Wed, 17

[FFmpeg-devel] [PATCH] libavformat: fix inputs initialization in mpegts muxer with filters

2019-04-17 Thread Andreas Håkon via ffmpeg-devel
This patch solves the initialization of the inputs when using filters (a graph filter) with the mpegts muxer. This bug seems to be generated by a simple forgetting to copy. The same code is repeated two times, but only in one case the variable “inputs_done” is initialized. Compare the two