Re: [FFmpeg-devel] [PATCH] [libdav1d.c]: Add option to output all the spatial layers.

2019-11-14 Thread Andrey Semashev
On 2019-11-14 20:48, James Almer wrote: On 11/14/2019 2:31 PM, Andrey Semashev wrote: On 2019-11-14 20:19, James Almer wrote: On 11/14/2019 2:15 PM, Thierry Foucu wrote: Set the option to false by default, to match libaomdec wrapper. ---   libavcodec/libdav1d.c | 4   1 file changed, 4

Re: [FFmpeg-devel] [PATCH] [libdav1d.c]: Add option to output all the spatial layers.

2019-11-14 Thread Andrey Semashev
On 2019-11-14 20:19, James Almer wrote: On 11/14/2019 2:15 PM, Thierry Foucu wrote: Set the option to false by default, to match libaomdec wrapper. --- libavcodec/libdav1d.c | 4 1 file changed, 4 insertions(+) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-30 Thread Andrey Semashev
On 2019-10-30 14:40, Michael Niedermayer wrote: On Tue, Oct 29, 2019 at 04:39:16PM +0300, Andrey Semashev wrote: On 2019-10-26 14:05, Andrey Semashev wrote: The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-29 Thread Andrey Semashev
On 2019-10-26 14:05, Andrey Semashev wrote: The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works around this decoder limitation and marks I-frames and keyframes based

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Andrey Semashev
On 2019-10-26 21:15, Michael Niedermayer wrote: On Sat, Oct 26, 2019 at 02:05:27PM +0300, Andrey Semashev wrote: The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works

Re: [FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Andrey Semashev
On 2019-10-26 15:49, Carl Eugen Hoyos wrote: Am Sa., 26. Okt. 2019 um 13:12 Uhr schrieb Andrey Semashev : The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works around

[FFmpeg-devel] [PATCH] libavcodec/h261dec: Fix keyframe markup and frame skipping.

2019-10-26 Thread Andrey Semashev
The decoder never marks pictures as I-frames, which results in no keyframe indication and incorrect frame skipping, in cases when keyframes should be decoded. This commit works around this decoder limitation and marks I-frames and keyframes based on "freeze picture release" bit in h261 picture

Re: [FFmpeg-devel] [PATCH v2] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-22 Thread Andrey Semashev
On 2019-10-22 17:14, Andrey Semashev wrote: On 2019-10-22 17:09, James Almer wrote: On 10/22/2019 11:01 AM, Andrey Semashev wrote: On 2019-10-18 02:18, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer --- Now unconditionally

Re: [FFmpeg-devel] [PATCH v2] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-22 Thread Andrey Semashev
On 2019-10-22 17:09, James Almer wrote: On 10/22/2019 11:01 AM, Andrey Semashev wrote: On 2019-10-18 02:18, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer --- Now unconditionally propagating the field, since checking its value

Re: [FFmpeg-devel] [PATCH v2] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-22 Thread Andrey Semashev
On 2019-10-18 02:18, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer --- Now unconditionally propagating the field, since checking its value is not correct usage of the field. James, do you still plan working on this patch?

Re: [FFmpeg-devel] [PATCH v3] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-18 Thread Andrey Semashev
On 2019-10-18 15:52, James Almer wrote: On 10/18/2019 7:22 AM, Andrey Semashev wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer Updated to avoid extra memory allocations on 64-bit platforms. Signed-off-by: Andrey Semashev Please stop

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-18 Thread Andrey Semashev
On 2019-10-18 10:01, Andrey Semashev wrote: On 2019-10-18 02:16, James Almer wrote: On 10/17/2019 7:46 PM, Andrey Semashev wrote: On 2019-10-18 01:28, James Almer wrote: On 10/17/2019 7:13 PM, Andrey Semashev wrote: On 2019-10-17 23:11, James Almer wrote: Actually reorder the values

[FFmpeg-devel] [PATCH v3] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-18 Thread Andrey Semashev
Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer Updated to avoid extra memory allocations on 64-bit platforms. Signed-off-by: Andrey Semashev --- libavcodec/libdav1d.c | 46 ++- 1 file changed, 45

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-18 Thread Andrey Semashev
On 2019-10-18 02:16, James Almer wrote: On 10/17/2019 7:46 PM, Andrey Semashev wrote: On 2019-10-18 01:28, James Almer wrote: On 10/17/2019 7:13 PM, Andrey Semashev wrote: On 2019-10-17 23:11, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-17 Thread Andrey Semashev
Please, ignore this patch. On 2019-10-18 01:44, James Almer wrote: On 10/17/2019 7:34 PM, Andrey Semashev wrote: Actually reorder the values. Should effectively fix ticket #8300. Not sure why you decided to send a modified patch by another dev, and with the author name changed, but that's

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-17 Thread Andrey Semashev
On 2019-10-18 01:28, James Almer wrote: On 10/17/2019 7:13 PM, Andrey Semashev wrote: On 2019-10-17 23:11, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer ---   libavcodec/libdav1d.c | 21 -   1 file

[FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-17 Thread Andrey Semashev
Actually reorder the values. Should effectively fix ticket #8300. --- libavcodec/libdav1d.c | 26 +- 1 file changed, 25 insertions(+), 1 deletion(-) diff --git a/libavcodec/libdav1d.c b/libavcodec/libdav1d.c index 8aa248e6cd..774e741db8 100644 --- a/libavcodec/libdav1d.c

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-17 Thread Andrey Semashev
On 2019-10-18 01:27, Hendrik Leppkes wrote: On Fri, Oct 18, 2019 at 12:13 AM Andrey Semashev wrote: On 2019-10-17 23:11, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 21

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-17 Thread Andrey Semashev
On 2019-10-17 23:11, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavcodec/libdav1d.c

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-17 Thread Andrey Semashev
On 2019-10-18 00:43, Andrey Semashev wrote: On 2019-10-17 23:11, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer ---   libavcodec/libdav1d.c | 21 -   1 file changed, 20 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fix setting AVFrame reordered_opaque

2019-10-17 Thread Andrey Semashev
On 2019-10-17 23:11, James Almer wrote: Actually reorder the values. Should effectively fix ticket #8300. Signed-off-by: James Almer --- libavcodec/libdav1d.c | 21 - 1 file changed, 20 insertions(+), 1 deletion(-) diff --git a/libavcodec/libdav1d.c

Re: [FFmpeg-devel] Is it ok to add G.722.1 decoder as external lib?

2019-09-17 Thread Andrey Semashev
On 2019-09-17 03:29, Hyun Yoo wrote: I implemented a g.722.1 decoder by linking FreeSwitch's libg722_1 as external lib like libilbc, libspeex(ex. configure --enable-libg722_1) (https://github.com/traviscross/freeswitch/tree/master/libs/libg722_1) I believe, the correct upstream link is

Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.

2019-09-08 Thread Andrey Semashev
On 2019-09-02 20:10, Paul B Mahol wrote: On 9/2/19, Andrey Semashev wrote: Ping? I would like this to make it into 4.2 as well. Applied to master. Thanks. Could you also merge it to 4.2 branch? On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev wrote: The current code in libavfilter

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-07 Thread Andrey Semashev
On 2019-09-07 18:32, Limin Wang wrote: On Sat, Sep 07, 2019 at 05:19:55PM +0200, Michael Niedermayer wrote: On Wed, Aug 28, 2019 at 06:32:37PM +0300, Andrey Semashev wrote: Because lavf_container is sometimes called with only 2 arguments, fate tests produce bash errors like this: tests

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-06 Thread Andrey Semashev
Could someone take a look at this small fix, please? I'd like it to make it into 4.2.1. On 2019-09-02 13:54, Andrey Semashev wrote: Ping? On 2019-08-28 18:32, Andrey Semashev wrote: Because lavf_container is sometimes called with only 2 arguments, fate tests produce bash errors like

Re: [FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.

2019-09-02 Thread Andrey Semashev
Ping? I would like this to make it into 4.2 as well. On Wed, Aug 28, 2019 at 11:16 PM Andrey Semashev wrote: > > The current code in libavfilter/af_sofalizer.c requires > mysofa_neighborhood_init_withstepdefine function, which only appeared > in libmysofa 0.7. Use this function

Re: [FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-09-02 Thread Andrey Semashev
Ping? On 2019-08-28 18:32, Andrey Semashev wrote: Because lavf_container is sometimes called with only 2 arguments, fate tests produce bash errors like this: tests/fate-run.sh: 299: test: =: unexpected operator This commit fixes this. --- tests/fate-run.sh | 2 +- 1 file changed, 1

[FFmpeg-devel] [PATCH v2] configure: Update libmysofa check with a new symbol.

2019-08-28 Thread Andrey Semashev
The current code in libavfilter/af_sofalizer.c requires mysofa_neighborhood_init_withstepdefine function, which only appeared in libmysofa 0.7. Use this function in configure script to bail out early if a too old libmysofa is found in the system instead of failing at compile time. --- configure |

Re: [FFmpeg-devel] [PATCH] configure: Update libmysofa check with a new symbol.

2019-08-28 Thread Andrey Semashev
On 2019-08-28 21:34, Carl Eugen Hoyos wrote: Am Mi., 28. Aug. 2019 um 17:33 Uhr schrieb Andrey Semashev : The current code in libavfilter/af_sofalizer.c requires mysofa_neighborhood_init_withstepdefine function, which only appeared in libmysofa 0.7. Add this function to configure script

Re: [FFmpeg-devel] [PATCH] configure: Update libmysofa check with a new symbol.

2019-08-28 Thread Andrey Semashev
On 2019-08-28 18:41, James Almer wrote: On 8/28/2019 12:24 PM, Andrey Semashev wrote: The current code in libavfilter/af_sofalizer.c requires mysofa_neighborhood_init_withstepdefine function, which only appeared in libmysofa 0.7. Add this function to configure script to bail out early if a too

[FFmpeg-devel] [PATCH] tests: Fix bash errors in lavf_container tests.

2019-08-28 Thread Andrey Semashev
Because lavf_container is sometimes called with only 2 arguments, fate tests produce bash errors like this: tests/fate-run.sh: 299: test: =: unexpected operator This commit fixes this. --- tests/fate-run.sh | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/tests/fate-run.sh

[FFmpeg-devel] [PATCH] configure: Update libmysofa check with a new symbol.

2019-08-28 Thread Andrey Semashev
The current code in libavfilter/af_sofalizer.c requires mysofa_neighborhood_init_withstepdefine function, which only appeared in libmysofa 0.7. Add this function to configure script to bail out early if a too old libmysofa is found in the system instead of failing at compile time. --- configure |

Re: [FFmpeg-devel] [Compiled Failed] Trying to compile FFmpeg with mysofa and it failed at af_sofalizer.c:164:32

2019-08-27 Thread Andrey Semashev
On 12/29/18 10:15 PM, James Almer wrote: On 12/29/2018 8:09 AM, Paul B Mahol wrote: On 12/29/18, Ysy wrote: I was trying to compile FFmpeg with `--enable-libmysofa`, and it failed with this message below: src/libavfilter/af_sofalizer.c:164:32: error: implicit declaration of function

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-07-30 Thread Andrey Semashev
On 7/30/19 12:11 PM, Andrey Semashev wrote: On 7/30/19 5:39 AM, Juan De León wrote: I tried to fix all you suggested, please have a look and let me know what you think. design doc: https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing Signed-off

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-07-30 Thread Andrey Semashev
On 7/30/19 5:39 AM, Juan De León wrote: I tried to fix all you suggested, please have a look and let me know what you think. design doc: https://docs.google.com/document/d/1WClt3EqhjwdGXhEw386O0wfn3IBQ1Ib-_5emVM1gbnA/edit?usp=sharing Signed-off-by: Juan De León --- libavutil/Makefile

Re: [FFmpeg-devel] [PATCH] Extract QP from h264 encoded videos

2019-07-29 Thread Andrey Semashev
Just a few random comments. Disclaimer: I'm not a maintainer. On 7/29/19 9:09 PM, Juan De León wrote: Changes to libavcodec, hope this addresses all your comments. Cheers. Signed-off-by: Juan De León --- libavutil/Makefile | 2 + libavutil/frame.h | 6 ++

Re: [FFmpeg-devel] lavd: Remove libndi_newtek

2019-03-10 Thread Andrey Semashev
On 3/10/19 9:39 PM, Nicolas George wrote: Andrey Semashev (12019-03-10): But I think decisions like this should be based exclusively on technical grounds. Political or populist arguments are not valid for technical decisions, regardless how "good" or aligned with your pers

Re: [FFmpeg-devel] lavd: Remove libndi_newtek

2019-03-10 Thread Andrey Semashev
On 3/10/19 8:28 PM, Jean-Baptiste Kempf wrote: On Sun, 10 Mar 2019, at 18:04, Martin Vignali wrote: This discussion just send bad message to contributors. You're just encourage them to keep code improvement in their own version of ffmpeg. Maintaining an FFmpeg is hard and costly. This gives

Re: [FFmpeg-devel] [PATCH 1/3] avutil/attributes: add av_likely and av_unlikely

2019-01-25 Thread Andrey Semashev
On 1/24/19 11:53 PM, Rostislav Pehlivanov wrote: On Thu, 24 Jan 2019 at 20:38, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/APIchanges | 3 +++ libavutil/attributes.h | 8 libavutil/version.h| 2 +- 3 files changed, 12 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf: Add general API for IO buffer synchronization.

2018-12-24 Thread Andrey Semashev
On 12/21/18 2:48 AM, Michael Niedermayer wrote: On Thu, Dec 20, 2018 at 11:00:32AM +0100, Nicolas George wrote: Andrey Semashev (2018-12-10): This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media

Re: [FFmpeg-devel] [PATCH v3 1/2] lavf: Add general API for IO buffer synchronization.

2018-12-14 Thread Andrey Semashev
Ping? On December 10, 2018 3:05:54 PM Andrey Semashev wrote: This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media. The most obvious target for this extension if the filesystem streams. Invoking IO

[FFmpeg-devel] [PATCH v3 2/2] lavf/file: Add support for file syncing.

2018-12-10 Thread Andrey Semashev
This commit adds support for IO synchronization API to the file backend. --- libavformat/file.c | 11 +++ libavformat/os_support.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 1d321c4205..58fd55b928 100644 ---

[FFmpeg-devel] [PATCH v3 1/2] lavf: Add general API for IO buffer synchronization.

2018-12-10 Thread Andrey Semashev
This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media. The most obvious target for this extension if the filesystem streams. Invoking IO synchronization allows user applications to ensure that all written

Re: [FFmpeg-devel] [PATCH v2 1/2] lavf: Add general API for IO buffer synchronization.

2018-12-06 Thread Andrey Semashev
On 12/6/18 10:34 PM, Nicolas George wrote: Andrey Semashev (2018-12-06): Could you provide an example where ENOTSUP (i.e. the error code) would make more sense for a sync operation, as opposed to AVIO_SYNC_NOT_SUPPORTED (i.e. the success code)? It is not a matter making more sense, both

Re: [FFmpeg-devel] [PATCH v2 1/2] lavf: Add general API for IO buffer synchronization.

2018-12-06 Thread Andrey Semashev
On 12/6/18 9:29 PM, Nicolas George wrote: Andrey Semashev (2018-12-04): This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media. The most obvious target for this extension if the filesystem streams

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: Added an option to disable SIDX atom

2018-12-06 Thread Andrey Semashev
On 12/6/18 8:07 AM, Karthick J wrote: --- doc/muxers.texi | 4 libavformat/movenc.c | 12 ++-- libavformat/movenc.h | 1 + 3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index f1cc6f5fee..ca10741900 100644 ---

Re: [FFmpeg-devel] [PATCH v3] avformat/movenc: Added an option to disable SIDX atom

2018-12-06 Thread Andrey Semashev
On 12/6/18 12:20 PM, Andrey Semashev wrote: On 12/6/18 8:07 AM, Karthick J wrote: ---   doc/muxers.texi  |  4   libavformat/movenc.c | 12 ++--   libavformat/movenc.h |  1 +   3 files changed, 15 insertions(+), 2 deletions(-) diff --git a/doc/muxers.texi b/doc/muxers.texi index

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming.

2018-12-05 Thread Andrey Semashev
On 12/4/18 2:47 PM, Andrey Semashev wrote: On 12/4/18 11:49 AM, Jeyapal, Karthick wrote: On 11/29/18 8:28 PM, Andrey Semashev wrote: On 11/28/18 7:25 PM, Jeyapal, Karthick wrote: On 11/28/18 4:41 PM, Andrey Semashev wrote: The global_sidx flag causes errors like the following in movenc

[FFmpeg-devel] [PATCH v2 1/2] lavf: Add general API for IO buffer synchronization.

2018-12-04 Thread Andrey Semashev
This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media. The most obvious target for this extension if the filesystem streams. Invoking IO synchronization allows user applications to ensure that all written

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming.

2018-12-04 Thread Andrey Semashev
On 12/4/18 11:49 AM, Jeyapal, Karthick wrote: On 11/29/18 8:28 PM, Andrey Semashev wrote: On 11/28/18 7:25 PM, Jeyapal, Karthick wrote: On 11/28/18 4:41 PM, Andrey Semashev wrote: The global_sidx flag causes errors like the following in movenc when media segment removal is enabled via

[FFmpeg-devel] [PATCH v2 2/2] lavf/file: Add support for file syncing.

2018-12-04 Thread Andrey Semashev
This commit adds support for IO synchronization API to the file backend. --- libavformat/file.c | 11 +++ libavformat/os_support.h | 2 ++ 2 files changed, 13 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 1d321c4205..58fd55b928 100644 ---

Re: [FFmpeg-devel] [PATCH 2/2] lavf/file: Add support for file syncing.

2018-12-03 Thread Andrey Semashev
On 12/3/18 3:46 PM, Nicolas George wrote: Andrey Semashev (2018-12-03): This commit adds support for IO synchronization API to the file backend. --- libavformat/file.c | 10 ++ libavformat/os_support.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/libavformat/file.c

Re: [FFmpeg-devel] [PATCH 1/2] lavf: Add general API for IO buffer synchtonization.

2018-12-03 Thread Andrey Semashev
On 12/3/18 3:43 PM, Nicolas George wrote: Andrey Semashev (2018-12-03): This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media. The most obvious target for this extension if the filesystem streams

[FFmpeg-devel] [PATCH 1/2] lavf: Add general API for IO buffer synchtonization.

2018-12-03 Thread Andrey Semashev
This commit adds a new set of functions to avio and url subsystems, which allow users to invoke IO buffer synchronization with the underlying media. The most obvious target for this extension if the filesystem streams. Invoking IO synchronization allows user applications to ensure that all written

[FFmpeg-devel] [PATCH 2/2] lavf/file: Add support for file syncing.

2018-12-03 Thread Andrey Semashev
This commit adds support for IO synchronization API to the file backend. --- libavformat/file.c | 10 ++ libavformat/os_support.h | 2 ++ 2 files changed, 12 insertions(+) diff --git a/libavformat/file.c b/libavformat/file.c index 1d321c4205..9765fd76c7 100644 ---

[FFmpeg-devel] [PATCH v3] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-12-03 Thread Andrey Semashev
This commit ensures that all (potentially, long) filesystem activity is performed when the user calls av_write_trailer on the DASH libavformat context, not when freeing the context. Also, this defers media segment deletion until after the media trailers are written. --- libavformat/dashenc.c | 85

Re: [FFmpeg-devel] [PATCH v2] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-12-03 Thread Andrey Semashev
On 12/3/18 8:45 AM, Jeyapal, Karthick wrote: On 11/30/18 11:42 AM, Jeyapal, Karthick wrote: On 11/29/18 11:58 PM, Andrey Semashev wrote: This commit ensures that all (potentially, long) filesystem activity is performed when the user calls av_write_trailer on the DASH libavformat context

[FFmpeg-devel] [PATCH v2] lavf/dashenc: Use avpriv_io_delete to delete files.

2018-11-30 Thread Andrey Semashev
This fixes incorrect handling of file pseudo-URIs (i.e. when the filename starts with "file:"). --- libavformat/dashenc.c | 9 +++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index 6ce70e0076..412d7c8a21 100644 ---

Re: [FFmpeg-devel] [PATCH 1/2] lavf/file: Add proper support for authority in file URIs.

2018-11-29 Thread Andrey Semashev
On 11/29/18 10:16 PM, Nicolas George wrote: Andrey Semashev (2018-11-29): Nowdays, there is one common interface for interacting with ffmpeg, and this interface is URIs (or raw local paths). There is no third pseudo-URI option, AFAICT. So, in my humble

Re: [FFmpeg-devel] [PATCH 1/2] lavf/file: Add proper support for authority in file URIs.

2018-11-29 Thread Andrey Semashev
On 11/29/18 9:47 PM, Nicolas George wrote: Andrey Semashev (2018-11-29): It does. avformat_open_input, avio_open and ffurl_open[_whitelist] docs all say it's an URL and they don't perform any conversion. So the file backend should be prepared to receive a URL, with a scheme and authority. So

Re: [FFmpeg-devel] [PATCH 1/2] lavf/file: Add proper support for authority in file URIs.

2018-11-29 Thread Andrey Semashev
On 11/29/18 9:24 PM, Nicolas George wrote: Andrey Semashev (2018-11-29): Previously, URIs with authority field were incorrectly interpreted as if the authority was part of the path. The "file:" prefix does not indicate a file:// URI but a path for the file: protocol of FFmpeg.

[FFmpeg-devel] [PATCH v2] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-11-29 Thread Andrey Semashev
This commit ensures that all (potentially, long) filesystem activity is performed when the user calls av_write_trailer on the DASH libavformat context, not when freeing the context. Also, this defers media segment deletion until after the media trailers are written. --- libavformat/dashenc.c | 82

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Fix file URI handling when deleting files.

2018-11-29 Thread Andrey Semashev
On 11/29/18 2:17 PM, Andrey Semashev wrote: On 11/29/18 2:15 PM, Andrey Semashev wrote: On 11/28/18 7:47 PM, Jeyapal, Karthick wrote: On 11/28/18 4:46 PM, Andrey Semashev wrote: The URI used to open the output streams may be an actual URI with "file" scheme, accordin

[FFmpeg-devel] [PATCH 1/2] lavf/file: Add proper support for authority in file URIs.

2018-11-29 Thread Andrey Semashev
Previously, URIs with authority field were incorrectly interpreted as if the authority was part of the path. This commit adds more complete file URI parsing according to https://tools.ietf.org/html/rfc8089. In particular, the file backend now recognizes URIs with authority field and ensures that

[FFmpeg-devel] [PATCH 2/2] lavf/dashenc: Use avpriv_io_delete to delete files.

2018-11-29 Thread Andrey Semashev
This fixes incorrect handling of file URIs (i.e. when the filename starts with "file:", possibly followed by URI authority). --- libavformat/dashenc.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming.

2018-11-29 Thread Andrey Semashev
On 11/28/18 7:25 PM, Jeyapal, Karthick wrote: On 11/28/18 4:41 PM, Andrey Semashev wrote: The global_sidx flag causes errors like the following in movenc when media segment removal is enabled via windos_size or remove_at_exit: Non-consecutive fragments, writing incorrect sidx Unable to re

Re: [FFmpeg-devel] [PATCH v2 2/2] avformat/dashenc: Added an option to ignore io errors

2018-11-29 Thread Andrey Semashev
On 11/28/18 8:06 PM, Karthick J wrote: When dashenc has to run for long duration(say 24x7 live stream), one can enable this option to ignore the io failure of few segment's upload due to an intermittent network issues. When the network connection recovers dashenc will continue with the upload

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Fix file URI handling when deleting files.

2018-11-29 Thread Andrey Semashev
On 11/29/18 2:15 PM, Andrey Semashev wrote: On 11/28/18 7:47 PM, Jeyapal, Karthick wrote: On 11/28/18 4:46 PM, Andrey Semashev wrote: The URI used to open the output streams may be an actual URI with "file" scheme, according to https://tools.ietf.org/html/rfc8089. This commit

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Fix file URI handling when deleting files.

2018-11-29 Thread Andrey Semashev
On 11/28/18 7:47 PM, Jeyapal, Karthick wrote: On 11/28/18 4:46 PM, Andrey Semashev wrote: The URI used to open the output streams may be an actual URI with "file" scheme, according to https://tools.ietf.org/html/rfc8089. This commit makes file deletion routine recognize file URIs a

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-11-29 Thread Andrey Semashev
On 11/29/18 9:27 AM, Jeyapal, Karthick wrote: On 11/28/18 5:13 PM, Andrey Semashev wrote: This commit ensures that all (potentially, long) filesystem activity is performed when the user calls av_write_trailer on the DASH libavformat context, not when freeing the context. Also, this defers

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-11-29 Thread Andrey Semashev
On 11/29/18 9:27 AM, Jeyapal, Karthick wrote: On 11/28/18 5:13 PM, Andrey Semashev wrote: This commit ensures that all (potentially, long) filesystem activity is performed when the user calls av_write_trailer on the DASH libavformat context, not when freeing the context. Also, this defers

[FFmpeg-devel] [PATCH] lavf/dashenc: Write media trailers when DASH trailer is written.

2018-11-28 Thread Andrey Semashev
This commit ensures that all (potentially, long) filesystem activity is performed when the user calls av_write_trailer on the DASH libavformat context, not when freeing the context. Also, this defers media segment deletion until after the media trailers are written. --- libavformat/dashenc.c | 19

[FFmpeg-devel] [PATCH 2/2] lavf/dashenc: Delete HLS manifests on trailer writing if remove_at_exit is set.

2018-11-28 Thread Andrey Semashev
This fixes HLS manifests being left behind if remove_at_exit is set. --- libavformat/dashenc.c | 12 1 file changed, 12 insertions(+) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index a7d8c4e237..af3f0ee167 100644 --- a/libavformat/dashenc.c +++

[FFmpeg-devel] [PATCH 1/2] lavf/dashenc: Don't put non-mp4 streams in HLS manifests.

2018-11-28 Thread Andrey Semashev
The only native HLS implementation in the wild (Safari browser) doesn't support WebM. And at least some MSE-based players (e.g. shaka-player) cannot handle WebM media segments when playing HLS. So just skip non-mp4 streams from HLS manifests. Note that such streams will still be described by the

[FFmpeg-devel] [PATCH] lavf/dashenc: Fix file URI handling when deleting files.

2018-11-28 Thread Andrey Semashev
The URI used to open the output streams may be an actual URI with "file" scheme, according to https://tools.ietf.org/html/rfc8089. This commit makes file deletion routine recognize file URIs and extract the actual filesystem path from it. It also fixes strerror use, which may not be thread-safe.

[FFmpeg-devel] [PATCH] lavf/dashenc: Remove global_sidx from movenc params for live streaming.

2018-11-28 Thread Andrey Semashev
The global_sidx flag causes errors like the following in movenc when media segment removal is enabled via windos_size or remove_at_exit: Non-consecutive fragments, writing incorrect sidx Unable to re-open output file for the second pass (faststart) --- libavformat/dashenc.c | 2 +- 1 file

Re: [FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-26 Thread Andrey Semashev
On Wed, Nov 21, 2018 at 3:45 PM Jeyapal, Karthick wrote: > On 11/20/18 6:01 PM, Andrey Semashev wrote: > > On 11/18/18 1:55 PM, Jeyapal, Karthick wrote: > > > Thanks for sending these excellent patches. The entire patchset looks > > > good to me. > > >

[FFmpeg-devel] [PATCH] lavf/dashenc: Fix segment duration overflow on fine time bases.

2018-11-20 Thread Andrey Semashev
When stream time bases are very fine grained (e.g. nanoseconds), 32-bit segment duration may overflow for even for rather small segment duration (about 4 seconds long). Therefore we use 64-bit values for segment duration. --- libavformat/dashenc.c | 6 +++--- 1 file changed, 3 insertions(+), 3

Re: [FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-20 Thread Andrey Semashev
On 11/18/18 1:55 PM, Jeyapal, Karthick wrote: Thanks for sending these excellent patches. The entire patchset looks good to me. Also, many thanks for your patience and taking the earlier review comments in the right spirit. Ping for merging it then? On 11/17/18 11:10 PM, Andrey Semashev

[FFmpeg-devel] [PATCH 3/4] lavf/dashdec: Add webm to the list of allowed extensions.

2018-11-17 Thread Andrey Semashev
This is in coherence with dashenc, which can now generate segments with webm file name extension by default. Dashdec should be able to handle such streams by default as well. --- libavformat/dashdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavformat/dashdec.c

[FFmpeg-devel] [PATCH 2/4] lavf/dashenc: Add support for format-specific file extensions.

2018-11-17 Thread Andrey Semashev
The file name template options now support a new "$ext$" placeholder, which is replaced with a filename extension specific for the selected file format. This is useful for the new "auto" format mode, when different streams may use different file formats, and it is not possible to specify the

[FFmpeg-devel] [PATCH 4/4] lavf/dashenc: Fix AVDictionary leaks in case of various init errors.

2018-11-17 Thread Andrey Semashev
--- libavformat/dashenc.c | 13 +++-- 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/libavformat/dashenc.c b/libavformat/dashenc.c index f552503564..2c872f93a1 100644 --- a/libavformat/dashenc.c +++ b/libavformat/dashenc.c @@ -833,12 +833,12 @@ static int

[FFmpeg-devel] [PATCH 1/4] lavf/dashenc: Add DASH segment type auto and make it the default

2018-11-17 Thread Andrey Semashev
This commit restores the ability to create DASH streams with codecs that require different containers that was lost after commit 2efdbf7367989cf9d296c25fa3d2aff8d6e25fdd. It adds a new "auto" value for the dash_segment_type option and makes it the default. When in this mode, the segment format

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-14 Thread Andrey Semashev
On 11/14/18 4:52 PM, Jeyapal, Karthick wrote: On 11/14/18 1:41 PM, Andrey Semashev wrote: On 11/12/18 3:55 PM, Andrey Semashev wrote: Suppose you want to create a DASH stream consisting of VP8, H264, Vorbis and Opus substreams to cover the best compatibility with clients (which are mostly

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-14 Thread Andrey Semashev
On 11/12/18 3:55 PM, Andrey Semashev wrote: On 11/12/18 3:12 PM, Jeyapal, Karthick wrote: On 11/12/18 5:20 PM, Andrey Semashev wrote: On 11/12/18 8:20 AM, Jeyapal, Karthick wrote: On 11/8/18 10:27 PM, Andrey Semashev wrote: This commit restores the ability to create DASH streams

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-12 Thread Andrey Semashev
On 11/12/18 3:12 PM, Jeyapal, Karthick wrote: On 11/12/18 5:20 PM, Andrey Semashev wrote: On 11/12/18 8:20 AM, Jeyapal, Karthick wrote: On 11/8/18 10:27 PM, Andrey Semashev wrote: This commit restores the ability to create DASH streams with codecs that require different containers

Re: [FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-12 Thread Andrey Semashev
On 11/12/18 8:20 AM, Jeyapal, Karthick wrote: On 11/8/18 10:27 PM, Andrey Semashev wrote: This commit restores the ability to create DASH streams with codecs that require different containers that was lost after commit 2efdbf7367989cf9d296c25fa3d2aff8d6e25fdd. It extends the dash_segment_type

[FFmpeg-devel] [PATCH] lavf/dashenc: Add support for per-stream container type selection.

2018-11-08 Thread Andrey Semashev
This commit restores the ability to create DASH streams with codecs that require different containers that was lost after commit 2efdbf7367989cf9d296c25fa3d2aff8d6e25fdd. It extends the dash_segment_type option syntax to allow to specify segment container types for individual streams, in addition

Re: [FFmpeg-devel] [PATCH] lavfi/tests: Fix 16-bit vf_blend test to avoid memory not aligned to 2 bytes

2018-05-29 Thread Andrey Semashev
On 05/24/18 00:07, Andrey Semashev wrote: Generic C implementation of vf_blend performs reads and writes of 16-bit elements, which requires the buffers to be aligned to at least 2-byte boundary. Also, the change fixes source buffer overrun caused by src_offset being added to to test handling

[FFmpeg-devel] [PATCH] lavfi/tests: Fix 16-bit vf_blend test to avoid memory not aligned to 2 bytes

2018-05-23 Thread Andrey Semashev
Generic C implementation of vf_blend performs reads and writes of 16-bit elements, which requires the buffers to be aligned to at least 2-byte boundary. Also, the change fixes source buffer overrun caused by src_offset being added to to test handling of misaligned buffers. Fixes: #7226 ---