Re: [FFmpeg-devel] [PATCHv4] af_hdcd: more FATE tests

applied. -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv4] af_hdcd: more FATE tests

. It is the first second of filter/hdcd.flac, with the 16-bit LSB copied into bit 20 of a 24-bit stream. There isn't an actual non-16-bit HDCD sample available to test. Signed-off-by: Burt P <pbu...@gmail.com> --- tests/fate/filter-audio.mak | 84 +++--

Re: [FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

On Tue, Dec 20, 2016 at 11:57 AM, Michael Niedermayer wrote: > did you post links to any of the files or how can the new files be > added ? Yes, in IRC. Thank you for uploading. -- Burt ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

On Sun, Dec 18, 2016 at 6:54 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Dec 18, 2016 at 12:48:45PM -0600, Burt P wrote: >> Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. >> >> Changed fate-suite sample files: >> *

[FFmpeg-devel] [PATCHv3] af_hdcd: more FATE tests

. There isn't an actual non-16-bit HDCD sample available to test. Net change -34K. Would be -944K if hdcd.flac could be removed. Signed-off-by: Burt P <pbu...@gmail.com> --- tests/fate/filter-audio.mak | 86 ++--- 1 file changed, 74 insertions(

[FFmpeg-devel] [PATCHv2] af_hdcd: more FATE tests

. There isn't an actual non-16-bit HDCD sample available to test. Net change -34K. Would be -944K if hdcd.flac could be removed. Signed-off-by: Burt P <pbu...@gmail.com> --- tests/fate/filter-audio.mak | 86 ++--- 1 file changed, 74 insertions(

Re: [FFmpeg-devel] [PATCH] af_hdcd: more FATE tests

On Sun, Dec 18, 2016 at 3:30 AM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Sun, Dec 18, 2016 at 8:42 AM, Burt P <pbu...@gmail.com> wrote: >> Additional/Modified FATE tests improve code coverage from 63.7% to 98.1%. >> >> Changed fate-suite sample

[FFmpeg-devel] [PATCH] af_hdcd: more FATE tests

/hdcd.flac (910K) removed, although it was a nice tune and the samples that replace it are terrible sounds. Net change +290K. Signed-off-by: Burt P <pbu...@gmail.com> --- tests/fate/filter-audio.mak | 86 ++--- 1 file changed, 74 insertions(+), 12 del

Re: [FFmpeg-devel] [PATCH 5/5] af_hdcd: add experimental 20 and 24-bit decoding support

applied split into two commits -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/5] af_hdcd: add mono as a supported channel layout

applied -- Burt On Sun, Oct 2, 2016 at 2:46 AM, Burt P <pbu...@gmail.com> wrote: > Signed-off-by: Burt P <pbu...@gmail.com> > --- > libavfilter/af_hdcd.c | 5 - > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/libavfilter/af_hdcd.c b/libavfi

Re: [FFmpeg-devel] [PATCH 4/5] af_hdcd: hdcd_scan() and hdcd_integrate() handle stereo and single channel

applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/5] af_hdcd: allow all HDCD sample rates

applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 2/5] af_hdcd: support s16p (WavPack) directly

The buffer is already being copied anyway, so interlace the planar format during the copy and remove one use of auto-convert. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 15 --- 1 file changed, 12 insertions(+), 3 deletions(-) diff --git a/libav

[FFmpeg-devel] Alternate HDCD format/rate support

According to the Users' Manual, the PM Model Two would encode HDCD in any CD or DVD-Audio sampler rates, and at 16, 20, or 24-bit output. While HDCD was (afaik) only published on CD, and therefor 16-bit@44100Hz, audio may exist in any other other formats supported by the encoding equipment, so

[FFmpeg-devel] [PATCH 1/5] af_hdcd: allow all HDCD sample rates

The PM Model Two could output HDCD-encoded audio in CD and all DVD-Audio sample rates. (44100, 48000, 88200, 96000, 176400, and 192000 Hz) Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 14 -- 1 file changed, 8 insertions(+), 6 deletions(-) diff

Re: [FFmpeg-devel] [PATCH 2/5] af_hdcd: hdcd_analyze_gen() using int instead of float

applied as is for now. Thanks for the comment. I will look into a faster way of doing it. I only needed to change from the float version because it was giving different results for i686 than for amd64. I don't know why, exactly, but I do know that this version gives bit-perfect results

Re: [FFmpeg-devel] [PATCH 1/5] af_hdcd: some types renamed to remove _t

applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/5] af_hdcd: fix possible integer overflow

applied with fix: uint64_t sustain_reset = (uint64_t)cdt_ms * rate / 1000; Thank you, Michael. -- Burt On Tue, Sep 6, 2016 at 5:00 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Mon, Sep 05, 2016 at 06:18:43AM -0500, Burt P wrote: >> Signed-off-by: Burt P &l

Re: [FFmpeg-devel] [PATCH 4/5] af_hdcd: move decoding setup from init to config_input

applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 5/5] af_hdcd: tweak hdcd_analyze_prepare() a bit

applied On Mon, Sep 5, 2016 at 6:18 AM, Burt P <pbu...@gmail.com> wrote: > * use the actual sample rate > * use a more sensible frequency for the tone > * update fate test result > > Signed-off-by: Burt P <pbu...@gmail.com> > --- > libavfilter/af_hdcd.c |

Re: [FFmpeg-devel] [PATCH 5/5] af_hdcd: tweak hdcd_analyze_prepare() a bit

On Tue, Sep 6, 2016 at 6:12 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-09-06 13:02 GMT+02:00 Burt P. <pbu...@gmail.com>: >> On Tue, Sep 6, 2016 at 5:22 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >>> 2016-09-05 13:18 GMT+02:00 Burt P <p

Re: [FFmpeg-devel] [PATCH 5/5] af_hdcd: tweak hdcd_analyze_prepare() a bit

On Tue, Sep 6, 2016 at 5:22 AM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2016-09-05 13:18 GMT+02:00 Burt P <pbu...@gmail.com>: >> * use the actual sample rate > > Is hdcd supposed to work for sample_rates > different from 44100? As I understand it, yes.

[FFmpeg-devel] [PATCH 3/5] af_hdcd: fix possible integer overflow

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 9 - 1 file changed, 4 insertions(+), 5 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index c8bda82..c249589 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1004,16 +1

[FFmpeg-devel] [PATCH 1/5] af_hdcd: some types renamed to remove _t

Following a suggestion by Diego Biurrun. _t is reserved for POSIX, apparently. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 58 +-- 1 file changed, 29 insertions(+), 29 deletions(-) diff --git a/libavfilter/af_hd

[FFmpeg-devel] [PATCH 4/5] af_hdcd: move decoding setup from init to config_input

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 40 +--- 1 file changed, 21 insertions(+), 19 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index c249589..1487a0b 100644 --- a/libavfilter/af_hdcd.c

[FFmpeg-devel] [PATCH 5/5] af_hdcd: tweak hdcd_analyze_prepare() a bit

* use the actual sample rate * use a more sensible frequency for the tone * update fate test result Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 9 ++--- tests/fate/filter-audio.mak | 2 +- 2 files changed, 7 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH 0/5] af_hdcd changes

Hi. Patches follow. -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: for easier maintenance alongside libhdcd

applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

Thanks for looking at it. On Wed, Aug 24, 2016 at 1:06 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > Hi! > > 2016-08-24 16:38 GMT+02:00 Burt P. <pbu...@gmail.com>: >> On Tue, Aug 23, 2016 at 2:29 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >>&

Re: [FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

On Tue, Aug 23, 2016 at 2:29 PM, Carl Eugen Hoyos wrote: > It seems safer to me to use the actual number of channels than the > channel layout. Alright, new patch version incoming. -- Burt ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCHv2] af_hdcd: for easier maintenance alongside libhdcd

of filter_frame() into hdcd_analyze_prepare(), from libhdcd * moved some macro definitions to the top so they are all together Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 271 -- 1 file changed, 172 insertions(+), 99 del

Re: [FFmpeg-devel] [PATCH 2/3] af_hdcd: check return value of av_frame_copy_props()

applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/3] fate: add test for af_hdcd analyze mode

applied -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 0/3] libhdcd and things

On Tue, Aug 23, 2016 at 3:04 AM, Paul B Mahol wrote: > So you basically saying that foo* something will not use this lib, but > lavfi will? > > What is point of lib than? To use it in things other than ffmpeg. I personally use deadbeef and quodlibet as music players, I would

Re: [FFmpeg-devel] [PATCH 0/3] libhdcd and things

Hi. On Mon, Aug 22, 2016 at 7:52 PM, James Almer wrote: > A couple comments about the library. > > -The name hdcd_decode2 is still used in some places after your rename > commit, like the installed header and main c file. That is intentional. I want to keep the code there

[FFmpeg-devel] [PATCH 1/3] fate: add test for af_hdcd analyze mode

Signed-off-by: Burt P <pbu...@gmail.com> --- tests/fate/filter-audio.mak | 6 ++ 1 file changed, 6 insertions(+) diff --git a/tests/fate/filter-audio.mak b/tests/fate/filter-audio.mak index d1d9d59..2066fa9 100644 --- a/tests/fate/filter-audio.mak +++ b/tests/fate/filter-audio.mak @@

[FFmpeg-devel] [PATCH 3/3] af_hdcd: for easier maintenance alongside libhdcd

of filter_frame() into hdcd_analyze_prepare(), from libhdcd * moved some macro definitions to the top so they are all together Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 275 -- 1 file changed, 175 insertions(+), 100 del

[FFmpeg-devel] [PATCH 2/3] af_hdcd: check return value of av_frame_copy_props()

Anton Khirnov: "[av_frame_copy_props()] potentially contains memory allocation, so the return value needs to be checked." Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfi

[FFmpeg-devel] [PATCH 0/3] libhdcd and things

I have created a stand-alone library of the HDCD decoder from af_hdcd, and called it libhdcd. [ https://github.com/bp0/libhdcd ] I hope to use it in patches/plugins to some media players, and still be able to easily maintain them both together. There is some concern that I wanted to remove the

Re: [FFmpeg-devel] [PATCHv5] af_hdcd: Extract generic HDCD decoder, wrap for ffmpeg

I've reconsidered and I think this change may not be a good idea at this time. -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] af_volumedetect: Work with sample formats other than s16/s16p

On Sat, Aug 13, 2016 at 4:23 AM, Paul B Mahol wrote: > > Also, swresample already does what converting code do, but faster. Doing the conversion in the filter itself instead of using the auto-inserted conversion filter is that the original data is left completely untouched.

Re: [FFmpeg-devel] [PATCHv2] avfiltergraph.c: restore disabling of auto conversions

applied On Wed, Aug 10, 2016 at 4:09 AM, Burt P <pbu...@gmail.com> wrote: > Restore a check added in 440af105f2306d3c7b3b3f4d7530bab910d49cb9 > but lost sometime after. avfilter_graph_set_auto_convert() will > have an effect once again. > > Signed-off-by: Bur

Re: [FFmpeg-devel] avfilter_graph_set_auto_convert() appears to do nothing

Now reading to the end of the original message by Nicolas George, which I should have done before, I can see that it is already known to be lost. -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH] avfiltergraph.c: restore disabling of auto conversions

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/avfiltergraph.c | 8 1 file changed, 8 insertions(+) diff --git a/libavfilter/avfiltergraph.c b/libavfilter/avfiltergraph.c index 4275113..1685b76 100644 --- a/libavfilter/avfiltergraph.c +++ b/libavfilter/avfilterg

[FFmpeg-devel] [PATCHv2] avfiltergraph.c: restore disabling of auto conversions

Restore a check added in 440af105f2306d3c7b3b3f4d7530bab910d49cb9 but lost sometime after. avfilter_graph_set_auto_convert() will have an effect once again. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/avfiltergraph.c | 8 1 file changed, 8 insertions(+) diff

[FFmpeg-devel] avfilter_graph_set_auto_convert() appears to do nothing

As suggested by Nicolas George, I've recently tried avfilter_graph_set_auto_convert(ctx->graph, AVFILTER_AUTO_CONVERT_NONE) in a filter init() function, but it did not prevent auto-inserted resampling filters from appearing. I looked around a bit and could not find a place where the member of

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

s used and removing the invasive scan. On Mon, Aug 8, 2016 at 5:16 AM, Nicolas George <geo...@nsup.org> wrote: > Le primidi 21 thermidor, an CCXXIV, Burt P. a écrit : >> Are you now talking about plans of the future or this specific case? > > Both. > >> As it is, automatic con

Re: [FFmpeg-devel] [PATCHv5] af_hdcd: Add analyze mode

applied On Sun, Aug 7, 2016 at 2:50 AM, Burt P <pbu...@gmail.com> wrote: > A new mode, selected by filter option, to aid in analysis of HDCD > encoded audio. In this mode the audio is replaced by a solid tone and > the amplitude is adjusted to signal some specified aspect

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

Are you now talking about plans of the future or this specific case? As it is, automatic conversion is very helpful, for example from WavePack, which uses s16p. This filter is only looking at the AVFilterLinks between filters, not at the filters themselves. This scan and warn behavior was added

Re: [FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

On Sun, Aug 7, 2016 at 12:20 PM, Nicolas George wrote: > Sorry if it has been addressed before, but what are these tests? Why is this > filter invading other filters' privacy? The HDCD codes are stored in the LSB of consecutive samples, and anything that would change a sample

[FFmpeg-devel] [PATCHv2] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index e4e37e2..ebfe0f1 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1714,7 +

[FFmpeg-devel] [PATCH] af_hdcd: Don't warn if converting from AV_SAMPLE_FMT_S16P

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index e4e37e2..36da409 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1714,7 +

[FFmpeg-devel] [PATCHv5] af_hdcd: Add analyze mode

can see where different features or states are present. Signed-off-by: Burt P <pbu...@gmail.com> --- doc/filters.texi | 32 ++ libavfilter/af_hdcd.c | 163 +++--- 2 files changed, 187 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCHv4] af_hdcd: Add analyze mode (v4)

can see where different features or states are present. Signed-off-by: Burt P <pbu...@gmail.com> --- doc/filters.texi | 32 ++ libavfilter/af_hdcd.c | 163 +++--- 2 files changed, 187 insertions(+), 8 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 2/2] aacenc: unmark the fast coder as experimental

"The ANMR coder requires -strict -2 and some may be removed in the future" should have "some" removed. On Sat, Aug 6, 2016 at 6:51 PM, Rostislav Pehlivanov wrote: > This version has had much testing so there's little point in keeping it > maked as experimental. > >

Re: [FFmpeg-devel] [PATCH 1/2] af_hdcd: convert AVOptions from INT to BOOL

applied thx :) On Fri, Aug 5, 2016 at 4:54 PM, Burt P <pbu...@gmail.com> wrote: > As suggested by Timothy Gu. > > Signed-off-by: Burt P <pbu...@gmail.com> > --- > libavfilter/af_hdcd.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > >

[FFmpeg-devel] [PATCHv3] af_hdcd: Add analyze mode (v3)

can see where different features or states are present. Signed-off-by: Burt P <pbu...@gmail.com> --- doc/filters.texi | 32 ++ libavfilter/af_hdcd.c | 164 +++--- 2 files changed, 188 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCHv2] af_hdcd: Add analyze mode

can see where different features or states are present. Signed-off-by: Burt P <pbu...@gmail.com> --- doc/filters.texi | 32 ++ libavfilter/af_hdcd.c | 164 +++--- 2 files changed, 188 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/2] af_hdcd: convert AVOptions from INT to BOOL

As suggested by Timothy Gu. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index ef3c369..610dd9e 100644 --- a/libavfilter/af_hdcd.c +++ b/libav

[FFmpeg-devel] [PATCH 2/2] af_hdcd: Add analyze mode

can see where different features or states are present. Signed-off-by: Burt P <pbu...@gmail.com> --- doc/filters.texi | 32 ++ libavfilter/af_hdcd.c | 164 +++--- 2 files changed, 188 insertions(+), 8 deletions(-) diff --git

[FFmpeg-devel] [PATCH 0/2] Analyze mode

1. Converts a couple AVOptions from INT to BOOL as suggested. 2. Adds a mode that is useful to analyze the HDCD encoding, and find interesting samples to examine more closely. Thanks for any comments. -- Burt ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] FFmpeg 3.1.2

Can this small fix be applied to 3.1? http://ffmpeg.org/pipermail/ffmpeg-devel/2016-July/196268.html Although, if you can, please fix my typo in the subject, bing -> being. :/ On Thu, Aug 4, 2016 at 5:25 AM, Michael Niedermayer wrote: > Hi all > > ill soon make FFmpeg

[FFmpeg-devel] [PATCHv2] af_hdcd: Process stereo channels together, fix #5727

both channels together. * target_gain applied will be the last matching target_gain. * The old single channel functions remain as an option. They can be used by: -af hdcd=process_stereo=0. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c

[FFmpeg-devel] af_hdcd: add flags to AVOption defs

Fix for options not showing up in ffmpeg --help filter=hdcd Apply after the earlier set of 7 patches where options were introduced. -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] af_hdcd: add flags to AVOption defs

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 2d7fe8d..7c90861 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -903,11 +

[FFmpeg-devel] [PATCH] MAINTAINERS: Add myself for af_hdcd

Signed-off-by: Burt P <pbu...@gmail.com> --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 6d4c9f9..932e6fb 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -308,6 +308,7 @@ Filters: af_chorus.c Paul B

[FFmpeg-devel] [PATCH 3/7] af_hdcd: Improve error detection logging

* Moves the filter context member out of state and into HDCDContext * More useful information when an error is detected * Gives a location near where the error was detected Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 34 +++--- 1 file c

[FFmpeg-devel] [PATCH 4/7] af_hdcd: add force_pe filter option

Used to attempt replication of some results from http://www.audiomisc.co.uk/HFN/HDCD/Examined.html May not be generally useful, defaults to off. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 26 ++ 1 file changed, 22 insertions(+), 4 del

[FFmpeg-devel] [PATCH 2/7] af_hdcd: give cdt expired counter a value for never set

The counter is now -1 if the code detect timer was never set, and 0 if it was set but never expired. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 17 ++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libav

[FFmpeg-devel] [PATCH 1/7] af_hdcd: fix a minor annoyance

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 6f3eb1e..b860077 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -23,12

[FFmpeg-devel] [PATCH 6/7] af_hdcd: Process stereo channels together, fix #5727

both channels together. * target_gain applied will be the last matching target_gain. * The old single channel functions remain as an option. They can be used by: -af hdcd=process_stereo=0. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c

[FFmpeg-devel] [PATCH 0/7] fix(v2) for #5727 split up, plus other things

Here is a set with the earlier patch split into smaller patches. Added to the old version is hdcd_control_stereo() that logs information about the mismatched target_gain so that problem samples can be found more easily. Also, a patch for warning about problems in the AVFilterLink chain. Thanks

Re: [FFmpeg-devel] [PATCH 0/1] af_hdcd: Process stereo channels together, fix #5727

> My suggestion is that you send your public key to > Michael and commit yourself including adding yourself > as maintainer of hdcd. I don't know enough about what that would mean. I'm also not an expert user of git. >> One strange case is John Mellencamp - [1994] Mr. Happy Go Lucky >> 06.

[FFmpeg-devel] [PATCH] af_hdcd: Process stereo channels together, fix #5727

(), hdcd_sustain_reset(). * This is against master, so it also includes the changes in an earlier patch set for HDCD detection, PE mode, cdt counter, and code comments. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 463 +-

[FFmpeg-devel] [PATCH 0/1] af_hdcd: Process stereo channels together, fix #5727

For review, a fix for #5727. Please test and comment. I've made new versions of the processing functions that process stereo channels together so that the rule regarding target_gain can be implemented. The target_gain used for both channels will now be the last valid target_gain that matched

[FFmpeg-devel] [PATCH] af_hdcd: Add counter for cdt expirations

Adds a counter for when the "code detect timer" expired without finding a valid packet. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter

[FFmpeg-devel] [PATCH 4/4] af_hdcd: Report PE as being intermittent or permanent

The Peak Extend feature could be enabled permanently or only when needed. This is now reported. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 30 ++ 1 file changed, 26 insertions(+), 4 deletions(-) diff --git a/libavfilter/af_hd

Re: [FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

On Sat, Jul 23, 2016 at 5:41 PM, Michael Niedermayer wrote: > > this looks like 2 unrelated changes > one is improving documentation the other is changing ths detect code > can you split these in 2 patches ? Ok, I've submitted a new set.

[FFmpeg-devel] [PATCH 3/4] af_hdcd: Add counter for cdt expirations

Adds a counter for when the code detect timer expired without finding a valid packet. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 14 -- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 7

[FFmpeg-devel] [PATCH 1/4] af_hdcd: Improve HDCD detection

HDCD is now only considered detected if a valid packet is active in both channels simultaneously. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 8 ++-- 1 file changed, 6 insertions(+), 2 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c

[FFmpeg-devel] [PATCH 2/4] af_hdcd: more comments in state struct

Add some comments describing the fields in hdcd_state_t. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 34 +- 1 file changed, 21 insertions(+), 13 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index f

[FFmpeg-devel] [PATCH 0/4] HDCD filter improvements

I've split an earlier patch as requested, and added a couple more to the set. -- Burt ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

kets. I am attempting this. On Fri, Jul 22, 2016 at 1:49 AM, Carl Eugen Hoyos <ceho...@ag.or.at> wrote: > Burt P gmail.com> writes: > >> HDCD is only "detected" if a valid code is active in both >> channels simultaneously > > Does your patch fix ticket #5727

[FFmpeg-devel] [PATCH] af_hdcd: Improve HDCD detection

HDCD is only "detected" if a valid code is active in both channels simultaneously, as described here: https://hydrogenaud.io/index.php/topic,79427.msg900371.html#msg900371 Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 34 --

[FFmpeg-devel] [PATCH] fate: Add HDCD filter tests for false positive and error detection

Signed-off-by: Burt P <pbu...@gmail.com> --- tests/fate-run.sh | 3 ++- tests/fate/filter-audio.mak | 12 2 files changed, 14 insertions(+), 1 deletion(-) diff --git a/tests/fate-run.sh b/tests/fate-run.sh index c898695..5841b0c 100755 --- a/tests/fate-run.sh +++ b

[FFmpeg-devel] [PATCH 2/5] af_hdcd: fewer false positives by ignoring code_counterC in HDCD detection

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 73a0b93..48f87f6 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1094,7 +1094,7 @@

[FFmpeg-devel] [PATCH 3/5] af_hdcd: only hdcd_update_info() when something changes

Only call hdcd_update_info() when the control code changes instead of every frame, so the counters are more meaningful. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 34 +- 1 file changed, 13 insertions(+), 21 deletions(-) diff

[FFmpeg-devel] [PATCH 5/5] af_hdcd: detect and report encoding errors and oddities

Count and report when a code is signaled but fails to match a known pattern. For example try Līve - Secret Samadhi. Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 73 --- 1 file changed, 58 insertions(+), 15 deletions(-)

[FFmpeg-devel] [PATCH 4/5] af_hdcd: don't log full HDCD stats if HDCD was not detected

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 16 +--- 1 file changed, 9 insertions(+), 7 deletions(-) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 4104935..8acbdda 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -1

[FFmpeg-devel] [PATCH 0/5] Split up HDCD filter patch

This is the previous patch split into smaller patches, as requested. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH] af_hdcd.c: only hdcd_update_info() when something changes, add error detection

for others to examine. An example with many errors is Līve - Secret Samadhi, if anyone wants to look into it. Patch is attached. Any comments would be appreciated. From 63a2736dd8444fe64d8c5bc885d61979bfe93f6b Mon Sep 17 00:00:00 2001 From: Burt P <pbu...@gmail.com> Date: Mon, 11 Jul 2016 17:08:20

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

:00 2001 From: Burt P <pbu...@gmail.com> Date: Tue, 5 Jul 2016 12:23:33 -0500 Subject: [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report The new HDCD filter really does nothing to show that it is working or that HDCD control information was even detected in the stream. This

[FFmpeg-devel] [PATCH] small fix in af_hdcd.c where gain was not bing adjusted for "attenuate slowly"

Signed-off-by: Burt P <pbu...@gmail.com> --- libavfilter/af_hdcd.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavfilter/af_hdcd.c b/libavfilter/af_hdcd.c index 16bdcb0..92f3c9e 100644 --- a/libavfilter/af_hdcd.c +++ b/libavfilter/af_hdcd.c @@ -949,6 +949,7 @@ static int hdcd_en

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

: Burt P <pbu...@gmail.com> Date: Sun, 3 Jul 2016 21:46:10 -0500 Subject: [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report The new HDCD filter really does nothing to show that it is working or that HDCD control information was even detected in the stream. This patch collects infor

Re: [FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

? It is only used in that one function, but unfortunately twice, so I thought a macro would do well there. On Sun, Jul 3, 2016 at 6:34 AM, Moritz Barsnick <barsn...@gmx.net> wrote: > On Sat, Jul 02, 2016 at 23:53:20 -0500, Burt P. wrote: > >> static int integrate(hdcd_state_t

[FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

The new HDCD filter really does nothing to show that it is working or that HDCD control information was even detected in the stream. This patch collects information about the decode, like which features were used, and reports it to the user at the end. Signed-off-by: Burt P <pbu...@gmail.

[FFmpeg-devel] [PATCH] libavfilter/af_hdcd.c: Collect HDCD stats and report

The new HDCD filter really does nothing to show that it is working or that HDCD control information was even detected in the stream. This patch collects information about the decode, like which features were used, and reports it to the user at the end. First patch I've ever tried to submit to