Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-20 Thread Carl Eugen Hoyos
> Something like this doesn't deserve anything but the lowest level of > criticism. But the lowest level of criticism is not allowed here. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 4/4] avcodec/hqx: Check the input data against the image size

2019-07-20 Thread Carl Eugen Hoyos
> Am 21.07.2019 um 00:36 schrieb Lynne : > > Jul 20, 2019, 11:08 PM by mich...@niedermayer.cc: > >> Fixes: Timeout (22 -> 7 sec) >> Fixes: >> 15173/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HQX_fuzzer-5662556846292992 >> >> Found-by: continuous fuzzing process >>

Re: [FFmpeg-devel] [PATCH] avformat/aacdec: resync to the next aac sample on invalid data instead of aborting

2019-07-20 Thread Carl Eugen Hoyos
> Am 20.07.2019 um 15:13 schrieb James Almer : > > Should fix ticket #6634 > > Signed-off-by: James Almer > --- > libavformat/aacdec.c | 44 +--- > 1 file changed, 29 insertions(+), 15 deletions(-) > > diff --git a/libavformat/aacdec.c

Re: [FFmpeg-devel] patch2 Add-multithreading-for-swscale-filter.patch

2019-07-19 Thread Carl Eugen Hoyos
Am Fr., 19. Juli 2019 um 14:37 Uhr schrieb Pawlowski, Slawomir : > -res = alloc_slice(>slice[0], c->srcFormat, c->srcH, c->chrSrcH, > c->chrSrcHSubSample, c->chrSrcVSubSample, 0); > -if (res < 0) goto cleanup; > +if(!c->parent) { > +res = alloc_slice(>slice[0], c->srcFormat,

Re: [FFmpeg-devel] [PATCH] matroskadec: Remove redundant const

2019-07-18 Thread Carl Eugen Hoyos
Am Do., 18. Juli 2019 um 21:15 Uhr schrieb Andreas Rheinhardt : > The typedef used to define EbmlSyntax already includes a const qualifier > so that it is unnecessary to include another const qualifier in future > definitions and declarations. Given that MSVC warns about this, this > commit

Re: [FFmpeg-devel] [PATCH] avformat/mpegenc - reject unsupported audio streams

2019-07-17 Thread Carl Eugen Hoyos
> Am 08.07.2019 um 14:05 schrieb Gyan : > > > >> On 25-04-2019 01:48 PM, Gyan wrote: >> >> >>> On 25-04-2019 01:23 PM, Ali KIZIL wrote: >>> >>> There are also Dolby Codecs (ac3 & eac3). Will it also throw error for >>> these codecs ? >> >> AC3 is supported before and after this

Re: [FFmpeg-devel] [PATCH 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-15 Thread Carl Eugen Hoyos
Am Mo., 15. Juli 2019 um 12:39 Uhr schrieb Linjie Fu : > > Add docs for autoscale/noautoscale. > > Update information for autorotate according to ffplay. > > Signed-off-by: Linjie Fu > --- > doc/ffmpeg.texi | 11 +++ > 1 file changed, 11 insertions(+) > > diff --git a/doc/ffmpeg.texi

Re: [FFmpeg-devel] dash: add descriptor which is useful to the scheme defined by ISO/IEC 23009-1:2014/Amd.2:2015.

2019-07-14 Thread Carl Eugen Hoyos
Am Fr., 12. Juli 2019 um 10:31 Uhr schrieb leozhang : > > Reference ISO/IEC 23009-1:2014/Amd.2:2015, a spatial relationship descriptor > is defined as a spatial part of a content component (e.g. a region of > interest, or a tile) > and represented by either an Adaptation Set or a

Re: [FFmpeg-devel] [PATCH] avformat/rawenc: avoid divide by 0 when writing adx trailer

2019-07-13 Thread Carl Eugen Hoyos
> Am 13.07.2019 um 22:50 schrieb Andriy Gelman : > > From: Andriy Gelman > > Fixes #7985 Did you check the patch mentioned there? Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [FFmpeg-cvslog] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-07-10 Thread Carl Eugen Hoyos
> Am 07.07.2019 um 07:43 schrieb Calvin Walton : > > ffmpeg | branch: master | Calvin Walton | Fri Jun > 21 09:08:03 2019 -0400| [2bd21b96096320bc12532119a6b0f7a974db6c19] | > committer: Gyan Doshi > > vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables > > Changes to

Re: [FFmpeg-devel] [PATCH] mlpenc: fix lossless failures, add sanity checks

2019-07-09 Thread Carl Eugen Hoyos
> Am 09.07.2019 um 19:23 schrieb Jai Luthra : > > Signed-off-by: Jai Luthra > --- > libavcodec/mlpenc.c | 72 +++-- > 1 file changed, 37 insertions(+), 35 deletions(-) > > diff --git a/libavcodec/mlpenc.c b/libavcodec/mlpenc.c > index

Re: [FFmpeg-devel] [PATCH]lavc/vc2enc_dwt: Avoid left-shifting a negative value

2019-07-03 Thread Carl Eugen Hoyos
Am Mi., 3. Juli 2019 um 21:24 Uhr schrieb Michael Niedermayer : > > On Tue, Jul 02, 2019 at 11:40:52AM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch intends to fix ticket #7985. > > > > Please comment, Carl Eugen > > > vc2enc_dwt.c |

Re: [FFmpeg-devel] [PATCH]lavc/frame_thread_encoder: Do not memcpy() from NULL

2019-07-02 Thread Carl Eugen Hoyos
Am Di., 2. Juli 2019 um 08:31 Uhr schrieb Reimar Döffinger : > > On 01.07.2019, at 00:51, Carl Eugen Hoyos wrote: > > I believe attached patch fixes undefined behaviour and ticket #7981. > > Same here, I think it makes more sense to check the "size" instead of the

[FFmpeg-devel] [PATCH]lavc/vc2enc_dwt: Avoid left-shifting a negative value

2019-07-02 Thread Carl Eugen Hoyos
Hi! Attached patch intends to fix ticket #7985. Please comment, Carl Eugen From 740f1a95336b70ff3f8e6d46f0c61115890ee3e7 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Tue, 2 Jul 2019 11:38:14 +0200 Subject: [PATCH] lavc/vc2enc_dwt: Avoid left-shifting a negative value. Fixes ticket

Re: [FFmpeg-devel] [PATCH] ifv: populate creation_time

2019-07-01 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 14:26 Uhr schrieb Peter Ross : > > --- > Small patch, to extract timestamp from IFV file header. lgtm if tested. Thank you, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

[FFmpeg-devel] [PATCH]lavc/r210enc: Fix undefined behaviour encoding r10k

2019-07-01 Thread Carl Eugen Hoyos
Hi! Attached patch fixes an invalid left shift reported in ticket #7982. Please comment, Carl Eugen From cfe1ae9a1e95dee72ff0e0a45ce8caab98a1bd0b Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 1 Jul 2019 13:06:02 +0200 Subject: [PATCH] lavc/r210enc: Fix undefined behaviour encoding

[FFmpeg-devel] [PATCH]lavc/zmbvenc: Do not left-shift negative values

2019-06-30 Thread Carl Eugen Hoyos
Hi! Attached patch fixes the only (remaining) issue I see with the sample of ticket #7980. Please comment, Carl Eugen From e6ff8f43c0d9275b52290e18231438ce7770 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 1 Jul 2019 01:45:36 +0200 Subject: [PATCH] lavc/zmbvenc: Do not left

[FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument

2019-06-30 Thread Carl Eugen Hoyos
Hi! Undefined behaviour was reported in ticket #7981, attached patch tries to fix it. Please review, Carl Eugen From d77386d4a18d6d749d15516b5eb6df90507bf1eb Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 1 Jul 2019 01:09:19 +0200 Subject: [PATCH] lavf/nutenc: Do not call memcmp

Re: [FFmpeg-devel] [PATCH]lavf/nutenc: Do not call memcmp() with NULL argument

2019-06-30 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 01:12 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Undefined behaviour was reported in ticket #7981, attached patch tries Actually #7980. > to fix it. > > Please review, Carl Eugen ___ ffmpeg-devel mail

[FFmpeg-devel] [PATCH]lavc/frame_thread_encoder: Do not memcpy() from NULL

2019-06-30 Thread Carl Eugen Hoyos
Hi! I believe attached patch fixes undefined behaviour and ticket #7981. Please comment, Carl Eugen From d72fe544d6d7cdf816a75df858b17f1744049d97 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 1 Jul 2019 00:49:44 +0200 Subject: [PATCH] lavc/frame_thread_encoder: Do not memcpy() from

Re: [FFmpeg-devel] [PATCH]lavf/rawenc: Only accept the appropriate stream type for raw muxers

2019-06-30 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 00:40 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch fixes ticket #7979 for me. Now attached. > Please comment, Carl Eugen From 702506c37b239bf26335fb8f42d06511b8604bb5 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 1 Jul 2019

[FFmpeg-devel] [PATCH]lavf/rawenc: Only accept the appropriate stream type for raw muxers

2019-06-30 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7979 for me. Please comment, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org

Re: [FFmpeg-devel] [PATCH]lavf/rawenc: Do not allow encoding 0 audio channels

2019-06-30 Thread Carl Eugen Hoyos
Am Mo., 1. Juli 2019 um 00:12 Uhr schrieb James Almer : > > On 6/30/2019 7:01 PM, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #7979 for me, please comment. > > > > Thank you, Carl Eugen > > > > > > 0001-lavf-rawenc-Do-

[FFmpeg-devel] [PATCH]lavf/rawenc: Do not allow encoding 0 audio channels

2019-06-30 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7979 for me, please comment. Thank you, Carl Eugen From 976b294c10be32667852729c3652dbec466ac091 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Mon, 1 Jul 2019 00:00:38 +0200 Subject: [PATCH] lavf/rawenc: Do not allow encoding 0 audio channels. Fixes

Re: [FFmpeg-devel] Changes in cofigure script

2019-06-29 Thread Carl Eugen Hoyos
Am Sa., 29. Juni 2019 um 14:23 Uhr schrieb Dmitry A : > What is right way to make changes in the cofigure script? > I hacked it for building ffmpeg for android since clang doesn't > support -mcpu and -march or something else. Please elaborate, building for Android works fine here. Carl eugen

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add back alpha processing removed in 9cefb9e7ec

2019-06-28 Thread Carl Eugen Hoyos
Am Fr., 28. Juni 2019 um 20:29 Uhr schrieb Paul B Mahol : > > On 6/28/19, Carl Eugen Hoyos wrote: > > Am Fr., 28. Juni 2019 um 19:48 Uhr schrieb Paul B Mahol : > >> > >> Signed-off-by: Paul B Mahol > >> --- > >> libavcodec/cfhd.c | 2 ++ > >&

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add back alpha processing removed in 9cefb9e7ec

2019-06-28 Thread Carl Eugen Hoyos
Am Fr., 28. Juni 2019 um 19:48 Uhr schrieb Paul B Mahol : > > Signed-off-by: Paul B Mahol > --- > libavcodec/cfhd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index 846d334b9b..49a5a2c30a 100644 > --- a/libavcodec/cfhd.c > +++

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpeg_parser: use ff_mjpeg_decode_header to parse frame info

2019-06-27 Thread Carl Eugen Hoyos
Am Do., 27. Juni 2019 um 14:59 Uhr schrieb Zhong Li : > +/* return the 8 bit start code value and update the search > + state. Return -1 if no start code found */ > +static int find_frame_header_marker(const uint8_t **pbuf_ptr, const uint8_t > *buf_end) > +{ > +const uint8_t *buf_ptr; > +

Re: [FFmpeg-devel] [PATCH 2/3] lavc/mjpeg_parser: use ff_mjpeg_decode_header to parse frame info

2019-06-27 Thread Carl Eugen Hoyos
Am Do., 27. Juni 2019 um 14:59 Uhr schrieb Zhong Li : > > Signed-off-by: Zhong Li > --- > libavcodec/mjpeg_parser.c | 158 > +- > 1 file changed, 157 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/mjpeg_parser.c b/libavcodec/mjpeg_parser.c >

Re: [FFmpeg-devel] [PATCH 1/3] lavc/mjpegdec: add function ff_mjpeg_decode_header

2019-06-27 Thread Carl Eugen Hoyos
Am Do., 27. Juni 2019 um 14:59 Uhr schrieb Zhong Li : > -if (s->avctx->pix_fmt == s->hwaccel_sw_pix_fmt && !size_change) { > +if (!(s->got_picture && s->interlaced && (s->bottom_field == > !s->interlace_polarity))) { > +if (s->avctx->pix_fmt == s->hwaccel_sw_pix_fmt &&

Re: [FFmpeg-devel] [PATCH 1/5] lavu/pixfmt: add Y210/AYUV/Y410 pixel formats

2019-06-27 Thread Carl Eugen Hoyos
Am Do., 27. Juni 2019 um 16:28 Uhr schrieb Linjie Fu : > > Previously, media driver provided planar format(like 420 8 bit), but > for HEVC Range Extension (422/444 8/10 bit), the decoded image > is produced in packed format. (The question "why" and the answer "because Windows expects it" come to

Re: [FFmpeg-devel] [PATCH 4/5] lavc/qsvdec: add ChromaFormat support for YUV422/YUV444

2019-06-27 Thread Carl Eugen Hoyos
Am Do., 27. Juni 2019 um 16:31 Uhr schrieb Linjie Fu : > > Currently, ChromaFormat passed to libmfx is set to YUV42O by default. > > Modify to choose ChromaFormat according to fourCC. Sorry if I misunderstand: Doesn't 3/5 depend on this patch? Carl Eugen

Re: [FFmpeg-devel] [PATCH, v3] lavc/pthread_frame: update context in child thread in multi-thread mode

2019-06-27 Thread Carl Eugen Hoyos
Am Do., 27. Juni 2019 um 13:56 Uhr schrieb Linjie Fu : > libavcodec/internal.h | 7 +++ > libavcodec/pthread_frame.c | 21 ++--- > 2 files changed, 25 insertions(+), 3 deletions(-) > > diff --git a/libavcodec/internal.h b/libavcodec/internal.h > index 5096ffa..a85

Re: [FFmpeg-devel] [PATCH v14 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-06-25 Thread Carl Eugen Hoyos
Am Di., 25. Juni 2019 um 12:17 Uhr schrieb Jing Sun : > diff --git a/libavcodec/version.h b/libavcodec/version.h > index 2709163..3583499 100644 > --- a/libavcodec/version.h > +++ b/libavcodec/version.h > @@ -29,7 +29,7 @@ > > #define LIBAVCODEC_VERSION_MAJOR 58 > #define

Re: [FFmpeg-devel] [PATCH]Fix build with --enable-hardcoded-tables

2019-06-23 Thread Carl Eugen Hoyos
Am Mi., 19. Juni 2019 um 20:54 Uhr schrieb Michael Niedermayer : > > On Wed, Jun 19, 2019 at 01:43:28PM +0200, Carl Eugen Hoyos wrote: > > Hi! > > > > Attached patch fixes ticket #7962 for me, please comment. > > > > Thank you, Carl Eugen > > > tab

Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-21 Thread Carl Eugen Hoyos
> Am 21.06.2019 um 14:53 schrieb Nicolas George : > > greg Luce (12019-06-21): >> I had them in a single patch before but split them as requested here >> http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245613.html >> Is there something I'm missing that allows me to split the patch but >>

Re: [FFmpeg-devel] [PATCH v3] vf_drawtext - Add variables

2019-06-20 Thread Carl Eugen Hoyos
Am 20.06.2019 um 00:01 schrieb greg Luce : >> Who has written the patch that you attached? >> >> Thank you, Carl Eugen > > The C code was written by kepstin > I wrote the change to the documentation with help from several people > There's a trac ticket at https://trac.ffmpeg.org/ticket/7947

Re: [FFmpeg-devel] [PATCH v3] vf_drawtext - Add variables

2019-06-19 Thread Carl Eugen Hoyos
> Am 19.06.2019 um 22:45 schrieb greg Luce : > > Adds pkt_pos, pkt_duration, and pkt_size to drawtext as variables for > text expansion, and adds documentation for pict_type which already > exists. Who has written the patch that you attached? Thank you, Carl Eugen

[FFmpeg-devel] [PATCH]Fix build with --enable-hardcoded-tables

2019-06-19 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7962 for me, please comment. Thank you, Carl Eugen From 2b82532897074d3f17c0a5f0a17da3a601d821d7 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Wed, 19 Jun 2019 13:41:01 +0200 Subject: [PATCH] lavc/tableprint_vlc: Remove avpriv_request_sample() from

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/bitstream: Check for integer code truncation in build_table()

2019-06-19 Thread Carl Eugen Hoyos
Am Fr., 14. Juni 2019 um 21:40 Uhr schrieb Michael Niedermayer : > > ffmpeg | branch: master | Michael Niedermayer | Wed > Jun 5 12:18:54 2019 +0200| [e78b0f83748f92ea9e93b21c36082e0dd04d7cb1] | > committer: Michael Niedermayer > > avcodec/bitstream: Check for integer code truncation in

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-06-02 Thread Carl Eugen Hoyos
Am So., 2. Juni 2019 um 19:54 Uhr schrieb Derek Buitenhuis : > > On 31/05/2019 23:08, Carl Eugen Hoyos wrote: > > So is your patch meant to wait until this merge is done? > > I would suggest so... > > Soon has a (TM) beside it for a reason (there needs to be some > wor

Re: [FFmpeg-devel] Build ffmpeg with clang lto

2019-06-01 Thread Carl Eugen Hoyos
Am Sa., 1. Juni 2019 um 17:45 Uhr schrieb Adrian Tong : > Anyone has experience compiling ffmpeg with clang LTO before ? I tried > ./configure --cc=clang --cxx=clang++ --enable-lto and it did not work. cxx should never be needed. "did not work" is not a useful problem description... (clang is

Re: [FFmpeg-devel] [PATCH] avfilter/vf_gblur: add x86 SIMD optimizations

2019-05-31 Thread Carl Eugen Hoyos
Am Do., 30. Mai 2019 um 05:46 Uhr schrieb Ruiling Song : > > For details of the implementation, please refer to the comment > inlined in the assembly code. This sentence sounds unneeded to me. > It improves the horizontal pass > performance about 100% under single thread. I am not a native

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-31 Thread Carl Eugen Hoyos
Am Di., 28. Mai 2019 um 19:29 Uhr schrieb Derek Buitenhuis : > * The C bindings for rav1e currently live in the crav1e repo. This will > be merged into rav1e's repo Soon(TM), when stuff stabalizes. So is your patch meant to wait until this merge is done? I would suggest so... Carl

Re: [FFmpeg-devel] [PATCH] avformat/hcom: Remove unused variables

2019-05-31 Thread Carl Eugen Hoyos
Am Fr., 31. Mai 2019 um 23:43 Uhr schrieb Andreas Rheinhardt : > > The variables huffcount, rsrc_size and data_size were all set but not > used. Therefore they have been removed. The entailed a chance to > compactify calls to avio_skip; it has been used. > This fixes -Wunused-but-set-variable

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/tiff: Recognize DNG/CinemaDNG images

2019-05-31 Thread Carl Eugen Hoyos
Am Do., 30. Mai 2019 um 19:38 Uhr schrieb Nick Renieris : > diff --git a/libavcodec/tiff.h b/libavcodec/tiff.h > index 4b08650108..81913c6b1a 100644 > --- a/libavcodec/tiff.h > +++ b/libavcodec/tiff.h > @@ -20,7 +20,7 @@ > > /** > * @file > - * TIFF tables > + * TIFF constants & data

Re: [FFmpeg-devel] [PATCH 1/3] lavf/qsv_vpp: add frame format option

2019-05-31 Thread Carl Eugen Hoyos
Am Fr., 31. Mai 2019 um 10:01 Uhr schrieb Zhong Li : > @@ -104,6 +109,8 @@ static const AVOption options[] = { > { "width", "Output video width", OFFSET(ow), AV_OPT_TYPE_STRING, { > .str="cw" }, 0, 255, .flags = FLAGS }, > { "h", "Output video height", OFFSET(oh),

Re: [FFmpeg-devel] [PATCH 3/3] lavf/qsv: use av_cold for init/uninit

2019-05-31 Thread Carl Eugen Hoyos
Am Fr., 31. Mai 2019 um 10:01 Uhr schrieb Zhong Li : > > Signed-off-by: Zhong Li > --- > libavfilter/vf_deinterlace_qsv.c | 2 +- > libavfilter/vf_overlay_qsv.c | 2 +- > libavfilter/vf_scale_qsv.c | 4 ++-- > 3 files changed, 4 insertions(+), 4 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/vf_zscale: add slice threading

2019-05-31 Thread Carl Eugen Hoyos
Am Fr., 31. Mai 2019 um 16:40 Uhr schrieb Lynne : > Number of threads should not have any impact at all on quality ever. Afair, it has for x264... (not necessarily related to this patch though) Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH 2/7] libavfilter/vf_overlay.c: Add '\' for every line of the blend_slice_yuv function by vim column edit

2019-05-24 Thread Carl Eugen Hoyos
Am Fr., 24. Mai 2019 um 11:36 Uhr schrieb : > > From: Limin Wang > > --- > libavfilter/vf_overlay.c | 52 > 1 file changed, 26 insertions(+), 26 deletions(-) > > diff --git a/libavfilter/vf_overlay.c b/libavfilter/vf_overlay.c > index

Re: [FFmpeg-devel] [PATCH] avcodec/ffv1dec_template: Optimize common case in run mode

2019-05-23 Thread Carl Eugen Hoyos
Am Do., 23. Mai 2019 um 01:47 Uhr schrieb Michael Niedermayer : > > Fixes: Timeout (14sec -> 9sec) > Fixes: > 13398/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_FFV1_fuzzer-5664106709778432 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Carl Eugen Hoyos
Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > diff --git a/configure b/configure > index 9b4305cf0d..61eb774116 100755 > --- a/configure > +++ b/configure > @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" > vorbis_decoder_select="mdct" >

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread Carl Eugen Hoyos
Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : > > May 21, 2019, 8:44 AM by pr...@xvid.org : > > > --- > > > > what's changed: > > * apply #if CONFIG_VP4_DECODER around large vp4 code blocks > > * improved vp4_read_mb_value thanks to reminars suggestions > > * improved

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use unspecified language by default

2019-05-20 Thread Carl Eugen Hoyos
Am So., 19. Mai 2019 um 20:10 Uhr schrieb Marton Balint : > English was used before. A version bump is necessary. I would also like a Changelog entry, most people prefer an entry to apichanges though. Carl Eugen ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-20 Thread Carl Eugen Hoyos
Am Di., 14. Mai 2019 um 20:41 Uhr schrieb Lynne : > Attached a version with fft-template.c's copyright and mine Thank you! Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] avcodec/cpia: Check input size also against linesizes and EOL

2019-05-20 Thread Carl Eugen Hoyos
Am So., 19. Mai 2019 um 17:43 Uhr schrieb Michael Niedermayer : > > Fixes: Timeout (14sec -> 29ms) > Fixes: > 14733/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_CPIA_fuzzer-5707022445576192 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-20 Thread Carl Eugen Hoyos
Marton, Am Mo., 13. Mai 2019 um 13:42 Uhr schrieb Daniel Kucera : > > From: Daniel Kucera > > Signed-off-by: Daniel Kucera > --- > doc/ffplay.texi | 2 ++ > fftools/ffplay.c | 8 > 2 files changed, 10 insertions(+) > > diff --git a/doc/ffplay.texi b/doc/ffplay.texi > index

Re: [FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

2019-05-18 Thread Carl Eugen Hoyos
> Am 18.05.2019 um 16:48 schrieb Marton Balint : > > > >>> On Tue, 14 May 2019, Hendrik Leppkes wrote: >>> >>> On Tue, May 14, 2019 at 10:34 PM Marton Balint wrote: >>> >>> >>> >>>> On Sun, 5 May 2019, Carl

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-14 Thread Carl Eugen Hoyos
> Am 14.05.2019 um 19:17 schrieb Lynne : > I've attached the latest version. This patch is still not ok, please do not commit. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 22:46 Uhr schrieb Hendrik Leppkes : > > On Mon, May 13, 2019 at 10:37 PM Carl Eugen Hoyos wrote: > > > > Am Mo., 13. Mai 2019 um 22:32 Uhr schrieb James Almer : > > > > > > On 5/13/2019 5:23 PM, Carl Eugen Hoyos wrote: > > >

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 22:32 Uhr schrieb James Almer : > > On 5/13/2019 5:23 PM, Carl Eugen Hoyos wrote: > > Am Mo., 13. Mai 2019 um 22:18 Uhr schrieb James Almer : > >> > >> On 5/13/2019 5:13 PM, Carl Eugen Hoyos wrote: > >>> Am Mo., 13. Mai 2019 um 22

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 22:18 Uhr schrieb James Almer : > > On 5/13/2019 5:13 PM, Carl Eugen Hoyos wrote: > > Am Mo., 13. Mai 2019 um 22:10 Uhr schrieb Marton Balint : > >> > >> On Sun, 28 Apr 2019, Marton Balint wrote: > >> > >>> Hi All, > &

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 22:10 Uhr schrieb Marton Balint : > > On Sun, 28 Apr 2019, Marton Balint wrote: > > > Hi All, > > > > There has been discussion on the mailing list several times about the > > inclusion of support for closed source components (codecs, formats, > > filters, etc) in the main

Re: [FFmpeg-devel] [PATCH] libswcale: Fix possible string overflow in test

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 20:33 Uhr schrieb Adam Richter : > Thanks for reviewing that possible string overflow found by cppcheck > and proposing to try to make a better fix. I'll assume no further > action on my part for this fix is necessary unless anyone tells me > otherwise. See:

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-13 Thread Carl Eugen Hoyos
Am Mi., 10. Apr. 2019 um 13:26 Uhr schrieb Mathieu Duponchelle : > No problem I don't see an updated patch. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 13:31 Uhr schrieb Paul B Mahol : > > On 5/13/19, Carl Eugen Hoyos wrote: > > Am Mo., 13. Mai 2019 um 13:24 Uhr schrieb Lynne : > > > >> I'll ignore Carl's messages for now as I agree with the others that > >> authorship is alway

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 13:24 Uhr schrieb Lynne : > I'll ignore Carl's messages for now as I agree with the others that > authorship is always > preserved through git history. > If he disagrees then it becomes a project-wide issue as > copyright headers have sometimes not been preserved through

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 13:24 Uhr schrieb Lynne : > I'll ignore Carl's messages for now as I agree with the others that > authorship is always > preserved through git history. This is not the question here. > If he disagrees then it becomes a project-wide issue as > copyright headers have

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-13 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 11:00 Uhr schrieb Daniel Kucera : > +#ifdef SDL_WINDOW_ALWAYS_ON_TOP > +{ "alwaysontop", OPT_BOOL, { }, "window always on top" }, > +#endif You could remove the condition here... > { "volume", OPT_INT | HAS_ARG, { _volume}, "set startup volume > 0=min

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Carl Eugen Hoyos
Am Mo., 13. Mai 2019 um 00:55 Uhr schrieb James Almer : > > On 5/12/2019 7:42 PM, Carl Eugen Hoyos wrote: > > Am So., 12. Mai 2019 um 23:58 Uhr schrieb Lynne : > >> I need *technical* feedback about the API. > > > > I understand that. > > Then, if you can't

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 23:58 Uhr schrieb Lynne : > I need *technical* feedback about the API. I understand that. Please understand that the patch cannot be committed as-is. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 22:59 Uhr schrieb Hendrik Leppkes : > > On Sun, May 12, 2019 at 10:38 PM Carl Eugen Hoyos wrote: > > > > Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : > > > > > > On 5/12/19, Carl Eugen Hoyos wrote: > > > >

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 22:40 Uhr schrieb Paul B Mahol : > > On 5/12/19, Carl Eugen Hoyos wrote: > > Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : > >> > >> On 5/12/19, Carl Eugen Hoyos wrote: > >> > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb L

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 22:37 Uhr schrieb Paul B Mahol : > > On 5/12/19, Carl Eugen Hoyos wrote: > > Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : > >> > >> Patch updated again. > >> Made some more cleanups to the transforms, the tables and the main &g

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-12 Thread Carl Eugen Hoyos
Am Fr., 10. Mai 2019 um 17:15 Uhr schrieb Lynne : > > Patch updated again. > Made some more cleanups to the transforms, the tables and the main context. > API changed again, now the init function populates the function pointer for > transform. > I decided that having a separate function would

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 08:12 Uhr schrieb Peter Ross : > i have incorporated all suggestions from the first patch posted jan 2019. > > if there's nothing further to change, i will apply it a good week or so. > > cheers, > > > Changelog |1 + > doc/general.texi|2 + >

Re: [FFmpeg-devel] [PATCH 1/2] VP4 video decoder

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 09:41 Uhr schrieb Paul B Mahol : > Also you need real review. He needs to request a review which I believe he did. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add NV24 and NV42 pixel formats

2019-05-12 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 05:38 Uhr schrieb Fu, Linjie : > I'm working on adding support for HEVC 4:2:2/ 4:4:4, 8/10 bit, in vaapi > decoding. > And I'm aslo thinking of add some new pix_fmt for packed FourCC: > 444 8 bit : AYUV > 444 10 bit: Y410 > 422 10 bit: Y210 Do I understand correctly

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-11 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 02:51 Uhr schrieb Pedro Arthur : > > Em sáb, 11 de mai de 2019 às 20:26, James Almer escreveu: > > > > On 5/11/2019 8:08 PM, Carl Eugen Hoyos wrote: > > > Am So., 12. Mai 2019 um 01:00 Uhr schrieb Lynne : > > >> > > &g

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-11 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 01:26 Uhr schrieb James Almer : > > On 5/11/2019 8:08 PM, Carl Eugen Hoyos wrote: > > Am So., 12. Mai 2019 um 01:00 Uhr schrieb Lynne : > >> > >> May 11, 2019, 11:08 PM by ceffm...@gmail.com: > >> > >>> Am Sa., 11. M

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-11 Thread Carl Eugen Hoyos
Am So., 12. Mai 2019 um 01:00 Uhr schrieb Lynne : > > May 11, 2019, 11:08 PM by ceffm...@gmail.com: > > > Am Sa., 11. Mai 2019 um 14:41 Uhr schrieb Lynne <> d...@lynne.ee > > > >: > > > >> > >> May 10, 2019, 8:59 PM by >> ceffm...@gmail.com > >>

Re: [FFmpeg-devel] [PATCH 1/3] avutil: Add NV24 and NV42 pixel formats

2019-05-11 Thread Carl Eugen Hoyos
Am Sa., 11. Mai 2019 um 20:32 Uhr schrieb Philip Langdale : > > These are the 4:4:4 variants of the semi-planar NV12/NV21 formats. > > These formats are not used much, so we've never had a reason to add > them until now. VDPAU recently added support HEVC 4:4:4 content > and when you use the OpenGL

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-11 Thread Carl Eugen Hoyos
Am Sa., 11. Mai 2019 um 14:41 Uhr schrieb Lynne : > > May 10, 2019, 8:59 PM by ceffm...@gmail.com: > > > Am Fr., 10. Mai 2019 um 19:54 Uhr schrieb Lynne <> d...@lynne.ee > > > >: > > > >> > >> May 10, 2019, 4:14 PM by >> d...@lynne.ee >> : > >> > >> >

Re: [FFmpeg-devel] [PATCH 2/6] lavc/avpacket: check NULL before using the pointer

2019-05-10 Thread Carl Eugen Hoyos
Am Fr., 10. Mai 2019 um 18:13 Uhr schrieb Jun Zhao : > > From: Jun Zhao > > Need to check NULL before using the pointer > > Signed-off-by: Jun Zhao > --- > libavcodec/avpacket.c |3 ++- > 1 files changed, 2 insertions(+), 1 deletions(-) > > diff --git a/libavcodec/avpacket.c

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-10 Thread Carl Eugen Hoyos
Am Fr., 10. Mai 2019 um 19:54 Uhr schrieb Lynne : > > May 10, 2019, 4:14 PM by d...@lynne.ee: > > > Patch updated again. > > Made some more cleanups to the transforms, the tables and the main context. > > API changed again, now the init function populates the function pointer for > > transform. >

Re: [FFmpeg-devel] [PATCH] swscale: Add support for NV24 and NV42

2019-05-10 Thread Carl Eugen Hoyos
Am Fr., 10. Mai 2019 um 07:59 Uhr schrieb Philip Langdale : > > I don't think this is terribly useful, as the only thing out there that > can even handle NV24 content is VDPAU and the only time you have to > deal with it is when doing VDPAU OpenGL interop where swscale is > irrelevant. In the

Re: [FFmpeg-devel] [PATCH] avfilter/vf_unsharp: enable slice threading

2019-05-10 Thread Carl Eugen Hoyos
Am Fr., 10. Mai 2019 um 08:50 Uhr schrieb Song, Ruiling : > > > -Original Message- > > From: Song, Ruiling > > Sent: Thursday, May 9, 2019 3:43 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Song, Ruiling > > Subject: [PATCH] avfilter/vf_unsharp: enable slice threading > > > > Signed-off-by:

Re: [FFmpeg-devel] [PATCH] fix issues with transparent crop. (see https://trac.ffmpeg.org/ticket/7890)

2019-05-09 Thread Carl Eugen Hoyos
> Am 09.05.2019 um 18:23 schrieb Bjorn Roche : > > This patch should be attributed to Jacob Graff . Then please resend with the correct attribution. Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [FFmpeg-cvslog] avcodec/cuviddec: add capability check for maximum macroblock count

2019-05-08 Thread Carl Eugen Hoyos
Am Mi., 8. Mai 2019 um 12:08 Uhr schrieb Ruta Gadkari : > diff --git a/libavcodec/cuviddec.c b/libavcodec/cuviddec.c > index d59d1faf9e..acee78cf2c 100644 > --- a/libavcodec/cuviddec.c > +++ b/libavcodec/cuviddec.c > @@ -805,6 +805,12 @@ static int cuvid_test_capabilities(AVCodecContext *avctx, >

Re: [FFmpeg-devel] [PATCH] avutil: Add NV24 and NV42 pixel formats

2019-05-08 Thread Carl Eugen Hoyos
Am Mi., 8. Mai 2019 um 00:20 Uhr schrieb Philip Langdale : > > On 2019-05-07 14:43, Carl Eugen Hoyos wrote: > > Am Di., 7. Mai 2019 um 06:33 Uhr schrieb Philip Langdale > > : > >> > >> These are the 4:4:4 variants of the semi-planar NV12/NV21 formats. > >&

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-08 Thread Carl Eugen Hoyos
Am Mi., 8. Mai 2019 um 00:52 Uhr schrieb Reimar Döffinger : > > On 07.05.2019, at 12:00, Swaraj Hota wrote: > > > On Sun, May 05, 2019 at 09:59:01PM +0200, Reimar Döffinger wrote: > >> > >> > >>> +/*read video index*/ > >>> +avio_seek(s->pb, 0xf8, SEEK_SET); > >> [...] > >>> +

Re: [FFmpeg-devel] [PATCH] avutil: Add NV24 and NV42 pixel formats

2019-05-07 Thread Carl Eugen Hoyos
Am Di., 7. Mai 2019 um 06:33 Uhr schrieb Philip Langdale : > > These are the 4:4:4 variants of the semi-planar NV12/NV21 formats. > > I'm surprised we've not had a reason to add them until now, but > they are the format that VDPAU uses when doing interop for 4:4:4 > surfaces. Is there already a

Re: [FFmpeg-devel] [PATCH] libavutil: add an FFT & MDCT implementation

2019-05-06 Thread Carl Eugen Hoyos
Am Di., 7. Mai 2019 um 00:03 Uhr schrieb James Almer : > > On 5/6/2019 6:26 PM, Michael Niedermayer wrote: > > also i agree with paul, the API looks good > > implementation not really reviewed > > I don't like the avfft_* namespace. It's unlike other modules we have. > > Since av_fft_* is taken by

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-06 Thread Carl Eugen Hoyos
Am Mo., 6. Mai 2019 um 05:41 Uhr schrieb Jun Li : > +uint8_t* sd = NULL; Wouldn't it simplify the patch if this were a pointer to int32_t? Or is there a aliasing violation that can't be avoided? > +if (entry) { > +orientation = atoi(entry->value); > +sd =

Re: [FFmpeg-devel] [PATCH]lavf/utils: Do not read "@" without ":" as user name separator

2019-05-05 Thread Carl Eugen Hoyos
Am So., 5. Mai 2019 um 21:56 Uhr schrieb Hendrik Leppkes : > > On Sun, May 5, 2019 at 9:47 PM Carl Eugen Hoyos wrote: > > > > Am So., 5. Mai 2019 um 21:18 Uhr schrieb Hendrik Leppkes > > : > > > > > > On Sun, May 5, 2019 at 9:08 PM Carl Eug

Re: [FFmpeg-devel] [PATCH v2] avformat/ifv: added support for ifv cctv files

2019-05-05 Thread Carl Eugen Hoyos
Am So., 5. Mai 2019 um 21:59 Uhr schrieb Reimar Döffinger : > > +avio_skip(s->pb, 0x5c); > > If for any of these skips you have any idea what data they > contain, it would be nice to document it. Iirc, all values we understood are used now. > > +if (aud_magic == MKTAG('G','R','A','W'))

Re: [FFmpeg-devel] [PATCH]lavf/utils: Do not read "@" without ":" as user name separator

2019-05-05 Thread Carl Eugen Hoyos
Am So., 5. Mai 2019 um 21:18 Uhr schrieb Hendrik Leppkes : > > On Sun, May 5, 2019 at 9:08 PM Carl Eugen Hoyos wrote: > > > > Hi! > > > > Attached patch fixes ticket #7871 without re-introducing #7816. > > > > There is no patch here. However, plea

Re: [FFmpeg-devel] [PATCH]lavf/utils: Do not read "@" without ":" as user name separator

2019-05-05 Thread Carl Eugen Hoyos
Am So., 5. Mai 2019 um 21:08 Uhr schrieb Carl Eugen Hoyos : > > Hi! > > Attached patch fixes ticket #7871 without re-introducing #7816. And with the attachment. Carl Eugen From 969e30264d4f64885a943d347a5fa397efc0cd17 Mon Sep 17 00:00:00 2001 From: Carl Eugen Hoyos Date: Sun, 5 Ma

[FFmpeg-devel] [PATCH]lavf/utils: Do not read "@" without ":" as user name separator

2019-05-05 Thread Carl Eugen Hoyos
Hi! Attached patch fixes ticket #7871 without re-introducing #7816. Please comment, Carl Eugen ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

2019-05-05 Thread Carl Eugen Hoyos
Am So., 5. Mai 2019 um 20:51 Uhr schrieb Marton Balint : > > This reverts commit dd06f022b07438d650c82255dff16908ba04244a. > > Fixes ticket #7871 and reopens ticket #7816. I'll send an alternative patch in a moment. Carl Eugen ___ ffmpeg-devel mailing

  1   2   3   4   5   6   7   8   9   10   >