[FFmpeg-devel] [PATCH] Don't trigger errors for multiple id3 tags.

2019-02-28 Thread Dale Curtis
/wpt/webaudio/resources/4ch-440.wav Signed-off-by: Dale Curtis From 14c2244631e7d02d6f66a6d5a678125002b89675 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Thu, 28 Feb 2019 13:51:30 -0800 Subject: [PATCH] Don't trigger errors for multiple id3 tags. Such errors may make sense for specific

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Check parents remaining length

2019-02-22 Thread Dale Curtis
Sent http://ffmpeg.org/pipermail/ffmpeg-devel/2019-February/240418.html - which passes fate and fixes the issue with our test clip. - dale On Fri, Feb 22, 2019 at 12:31 PM Dale Curtis wrote: > +steve who submitted the original patch. > > - dale > > > On Thu, Feb 21, 2019 at 2

[FFmpeg-devel] [PATCH] Fix handling of unknown length case for matroska files.

2019-02-22 Thread Dale Curtis
Unknown length has a special encoding which is not uint64_t(-1). Signed-off-by: Dale Curtis --- libavformat/matroskadec.c | 13 - 1 file changed, 8 insertions(+), 5 deletions(-) From 2bf28a1edb54297f44021771b4c3d847c1f923f4 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 22

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Check parents remaining length

2019-02-22 Thread Dale Curtis
+steve who submitted the original patch. - dale On Thu, Feb 21, 2019 at 2:30 PM Dale Curtis wrote: > One of our test clips is behaving differently after this patch: > https://cs.chromium.org/chromium/src/media/test/data/bear-320x240-live.webm > > The printed log message is: >

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Check parents remaining length

2019-02-21 Thread Dale Curtis
One of our test clips is behaving differently after this patch: https://cs.chromium.org/chromium/src/media/test/data/bear-320x240-live.webm The printed log message is: [matroska,webm @ 0x1516c84f4e00] Invalid length 0xff > 0x12f in parent Looking through the code I'm

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-26 Thread Dale Curtis
Yes, all your suggestions silence the errors. Thanks! - dale On Fri, Oct 26, 2018 at 4:05 PM James Almer wrote: > On 10/26/2018 7:31 PM, Dale Curtis wrote: > > The following warnings show up when compiling with clang: > > ../../third_party/ffmpeg/libavcodec/libdav1d.c:92:24:

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-26 Thread Dale Curtis
On Fri, Oct 26, 2018 at 4:00 PM James Almer wrote: > On 10/26/2018 7:50 PM, Dale Curtis wrote: > > One more piece of feedback, this is not obeying the > > AVCodecContext.get_buffer2 API. > > It's not using it on purpose, wrapping the buffers dav1d allocated > itself

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-26 Thread Dale Curtis
One more piece of feedback, this is not obeying the AVCodecContext.get_buffer2 API. - dale On Fri, Oct 26, 2018 at 3:31 PM Dale Curtis wrote: > The following warnings show up when compiling with clang: > ../../third_party/ffmpeg/libavcodec/libdav1d.c:92:24: error: suggest > brac

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-26 Thread Dale Curtis
The following warnings show up when compiling with clang: ../../third_party/ffmpeg/libavcodec/libdav1d.c:92:24: error: suggest braces around initialization of subobject [-Werror,-Wmissing-braces] Dav1dPicture p = { 0 }; ^ {}

Re: [FFmpeg-devel] [PATCH v3] avcodec: libdav1d AV1 decoder wrapper.

2018-10-23 Thread Dale Curtis
On Fri, Oct 19, 2018 at 4:50 PM James Almer wrote: > +s.n_tile_threads = dav1d->tile_threads; > +s.n_frame_threads = dav1d->frame_threads; > Did you consider using the AVCodecContext.threads value along AVCodecContext.thread_type flags? That seems to be how this is handled elsewhere. -

Re: [FFmpeg-devel] Reduce static table size for VLC tables in h264_cavlc.c

2018-09-17 Thread Dale Curtis
On Sat, Sep 8, 2018 at 5:49 PM Michael Niedermayer wrote: > dont all modern OS assign physical memory only once something is stored > in these tables? > This seems to be correct. I was misreading the tooling which indicated these were taking up size. So this patch can be abandoned. Sorry for

[FFmpeg-devel] Reduce static table size for VLC tables in h264_cavlc.c

2018-09-07 Thread Dale Curtis
These tables represent ~70k so moving the allocation to when they're actually used reduces memory usage in cases where the h264 decoder isn't used. From e1cbe52a1f41a39698136efb4695d8d019117853 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 31 Aug 2018 16:50:23 -0700 Subject: [PATCH

[FFmpeg-devel] Don't calculate duration using AV_NOPTS_VALUE for start_time.

2018-09-07 Thread Dale Curtis
Found by ClusterFuzz, https://crbug.com/879852 From 68614e9a099ee4ae754da5fa36fbb6a570f4aa73 Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Fri, 7 Sep 2018 15:37:09 -0700 Subject: [PATCH] Don't calculate duration using AV_NOPTS_VALUE for start_time. Found by ClusterFuzz, https://crbug.com

[FFmpeg-devel] [mov] Error on too large stsd entry counts.

2018-08-30 Thread Dale Curtis
to atom.size / 8. Signed-off-by: Dale Curtis From 3e1663d84068ff7615f7e84fa1c1122729a531da Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Thu, 30 Aug 2018 15:18:25 -0700 Subject: [PATCH] Error on too large stsd entry counts. Entries are always at least 8 bytes per the parsing code, so if we see

[FFmpeg-devel] Correct opus-in-mp4 pre-skip to be uint16_t versus int16_t.

2018-08-21 Thread Dale Curtis
This field is a uint16_t, see docs: http://opus-codec.org/docs/opus_in_isobmff.html#4.3.2 Signed-off-by: Dale Curtis From 7f1588bc92ef4a70025aa140a8e660a36875c89c Mon Sep 17 00:00:00 2001 From: Dale Curtis Date: Tue, 21 Aug 2018 15:42:31 -0700 Subject: [PATCH] Correct opus-in-mp4 pre-skip

Re: [FFmpeg-devel] Respect AR and NM overrides for Windows builds.

2018-04-17 Thread Dale Curtis
On Tue, Apr 17, 2018 at 6:00 AM Derek Buitenhuis <derek.buitenh...@gmail.com> wrote: > On 4/17/2018 12:28 AM, Dale Curtis wrote: > > Necessary for clang-cl cross compiling builds to work on Linux. > > Looks fairly reasonable, I think. > > Are you manually ov

[FFmpeg-devel] Respect AR and NM overrides for Windows builds.

2018-04-16 Thread Dale Curtis
Necessary for clang-cl cross compiling builds to work on Linux. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From caf65ca502f9a38aff3b39f4464af9f071a28167 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Mon, 16 Apr 2018 16:26:47 -0700 Subject: [PATCH

Re: [FFmpeg-devel] [PATCH] configure: fix clang-cl detection

2018-04-13 Thread Dale Curtis
lgtm, I was able to build ffmpeg for windows on Linux with this patch by following my notes here: https://bugs.chromium.org/p/chromium/issues/detail?id=783021#c6 - dale On Thu, Feb 1, 2018 at 2:52 AM Alexander Bilyak wrote: > When using clang-cl it expects

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-28 Thread Dale Curtis
On Mon, Feb 26, 2018 at 3:07 PM, Michael Niedermayer wrote: > > The way parsers are intended to work (that is years ago and i dont remember > that there was a proposal to change this) > is to never drop data. Thats how the stuff was intended to work. > > On top of that it

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-26 Thread Dale Curtis
On Fri, Feb 23, 2018 at 7:01 PM, Michael Niedermayer wrote: > > this goes the wrong direction. > Parsers should not discard data by default. The code we have for tags is a > hack. > There are many better ways to handle this. > Something similar to a AV_PKT_FLAG_CORRUPT

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-23 Thread Dale Curtis
Whoops, that version spams on every flush; changed to only print when buf_size > 0. - dale On Fri, Feb 23, 2018 at 10:37 AM, Dale Curtis <dalecur...@chromium.org> wrote: > After some deeper testing it looks like this mechanism can actually fully > replace the existing ID3 and AP

Re: [FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-23 Thread Dale Curtis
After some deeper testing it looks like this mechanism can actually fully replace the existing ID3 and APE tag skips; so I've simplified the patch to do so. - dale On Thu, Feb 22, 2018 at 4:46 PM, Dale Curtis <dalecur...@chromium.org> wrote: > The parser should only return valid m

[FFmpeg-devel] [mpegaudio_parser] Skip trailing junk data when flushing parser.

2018-02-22 Thread Dale Curtis
when flushing. This should fix all sorts of mp3 files with trailing garbage. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From 1ede24ef6a0992dace2b86bd333cfd8044e64b93 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Thu, 22 Feb 2018 16:43:37 -0800 Sub

Re: [FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

2018-02-20 Thread Dale Curtis
r to do this. This patch set also changes the attribution from Robert Swain to Maxim Gavrilov based on svn blame of the SoC repository after discussion at https://trac.ffmpeg.org/ticket/1693#comment:34 From 8e5a3cc04400a1186df0714524ccb24dbe3f627d Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur.

[FFmpeg-devel] [aacdec] Parse and drop gain control data, so that SSR packets decode.

2018-02-20 Thread Dale Curtis
/aac.c and adds AOT_AAC_SSR to decode_audio_specific_config_gb(). Signed-off-by: Dale Curtis <dalecur...@chromium.org> Co-authored-by: Robert Swain <robert.sw...@gmail.com> From 97380752ef12337d9b9a01801a9a84df3b4b9c0a Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium

Re: [FFmpeg-devel] [mp3] Skip APE tags when parsing mp3 packets.

2018-01-30 Thread Dale Curtis
On Tue, Jan 30, 2018 at 6:44 AM, wm4 wrote: > In theory we could have a flag that controls this (I thought there > actually was such a flag, but didn't find anything). If we ever find > that discarding data is a problem, maybe such a flag could be added. > > Also I still

[FFmpeg-devel] [mp3] Skip APE tags when parsing mp3 packets.

2018-01-29 Thread Dale Curtis
Otherwise the decoder will throw "Missing header" errors when the packets are sent for decoding. From 05f5e837862a958fb8791668ab3cdf8fc7766fe5 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Mon, 29 Jan 2018 15:10:26 -0800 Subject: [PATCH] [mp3] Sk

Re: [FFmpeg-devel] [PATCH] avcodec/arm/sbrdsp_neon: Use a free register instead of putting 2 things in one

2018-01-12 Thread Dale Curtis
lgtm, resolves the issue on our end. - dale On Thu, Jan 11, 2018 at 1:47 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > Fixes high pitched shriek > Fixes: 25420848_1478428308873746_4255813235963330560_n.mp4 > > Reported-by: Dale Curtis <dalecur...@goo

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-12-01 Thread Dale Curtis
40d8f4523641502dbea;hb=HEAD#l319 WDYT? Here's a patch to do this and fail on AVERROR w/o the AV_EF_EXPLODE restriction. - dale From a6f5e47b54a08ac0ab2461b5e5189748059c7a9f Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Tue, 28 Nov 2017 13:40:20 -0800 Subject: [

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-30 Thread Dale Curtis
e is now always using AV_EF_EXPLODE, so either works for our usage. - dale From e47bd6161b4e062c669dad1989d2289fd1e3a8dc Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Tue, 28 Nov 2017 13:40:20 -0800 Subject: [PATCH] Respect AVERROR codes returned by ogg parsers. Fixes t

[FFmpeg-devel] [vorbis] Fix another 1 << 31 > int32_t::max() with 1u.

2017-11-30 Thread Dale Curtis
Didn't notice this one when 9648cc6d was landed. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From 2f7c0ee007cb28b8f3bf201279d7f17ca671728d Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Thu, 30 Nov 2017 12:20:36 -0800 Subject: [PATCH] [vorbis] F

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-29 Thread Dale Curtis
On Tue, Nov 28, 2017 at 4:32 PM, Michael Niedermayer wrote: > > > This breaks converting of this: > ./ffmpeg -i bgc.sub.dub.ogm -vf subtitles=bgc.sub.dub.ogm -an file.avi > > https://samples.ffmpeg.org/ogg/bgc.sub.dub.ogm > > That's due to the vorbis parser returning

[FFmpeg-devel] [oggvp8] Don't manipulate duration when it's AV_NOPTS_VALUE.

2017-11-28 Thread Dale Curtis
This leads to signed integer overflow. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From c1fa869b79aeb314f30746a561903fcfa8f305fb Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Tue, 28 Nov 2017 14:26:55 -0800 Subject: [PATCH] [oggvp8] Don't manipul

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-28 Thread Dale Curtis
Fixes bad parens in the above patch. - dale On Tue, Nov 28, 2017 at 2:03 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Actually packet() was broken too, updated the patch to fix this case too. > > - dale > > On Tue, Nov 28, 2017 at 1:41 PM, Dale Curtis <dalecur.

Re: [FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-28 Thread Dale Curtis
Actually packet() was broken too, updated the patch to fix this case too. - dale On Tue, Nov 28, 2017 at 1:41 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Fixes ticket #6804. All of the ogg header parsers may return > standard AVERROR codes; these return values should not

[FFmpeg-devel] [ogg] Free opus extradata before reallocating.

2017-11-28 Thread Dale Curtis
Otherwise ff_alloc_extradata() just leaks any existing allocated memory. Similar to the patch for ogm extradata leaks. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From ac7f2deaa48ac0578be19b178b7c0bc8040bc278 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org&g

[FFmpeg-devel] [ogg] Respect AVERROR codes returned by ogg header parsing.

2017-11-28 Thread Dale Curtis
Fixes ticket #6804. All of the ogg header parsers may return standard AVERROR codes; these return values should not be treated as success. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From 34d68a511a2d933b111964f84cfd2d0a289dec97 Mon Sep 17 00:00:00 2001 From: Dale Curtis &l

Re: [FFmpeg-devel] [mov] Remove concept of ctts entries with count > 1.

2017-11-27 Thread Dale Curtis
Any discussion on this one? Would make the oom fix John put together simpler I think. - dale On Mon, Aug 28, 2017 at 4:09 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Previous ctts patches have all changed the system to always using > count=1 since we expect ctts da

Re: [FFmpeg-devel] [ogm] Free extradata before reallocating.

2017-11-27 Thread Dale Curtis
Ping? On Tue, Nov 21, 2017 at 3:12 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Otherwise ff_alloc_extradata() just leaks any existing allocated > memory. > > Signed-off-by: Dale Curtis <dalecur...@chromium.org> > > ___

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-11-27 Thread Dale Curtis
On Thu, Nov 23, 2017 at 3:54 PM, Carl Eugen Hoyos wrote: > > @Dale: > Could you do that? > Thanks to John for putting out a patch for this. - dale ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-22 Thread Dale Curtis
On Tue, Nov 21, 2017 at 7:05 PM, Michael Niedermayer wrote: > > I dont think wrap_bits can/should be > 64 or do i miss something ? > Good point, this seems true with the current code. > > maybe a av_assert* for that would be better. > Done; used av_assert2().

[FFmpeg-devel] [vorbis] 1 << 31 > int32_t::max(), so use 1u << 31 instead.

2017-11-22 Thread Dale Curtis
vorbis_fix_v1.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [mov] Increment stsd_count while processing stsd data; avoids leaks.

2017-11-21 Thread Dale Curtis
In the event of ff_mov_read_stsd_entries() failure, sc->stsd_count is not updated, even if the function allocates extradata memory. Instead update the sc->stsd_count as entries are parsed so that mov_read_close() can do the right thing. Signed-off-by: Dale Curtis <dalecur...@chromium.

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-21 Thread Dale Curtis
Ah, realized this approach can work for wrap_bits == 64 too. Updated the patch. On Mon, Nov 20, 2017 at 5:42 PM, Dale Curtis <dalecur...@chromium.org> wrote: > On Mon, Nov 20, 2017 at 2:24 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >> >> I thin

[FFmpeg-devel] [ogm] Free extradata before reallocating.

2017-11-21 Thread Dale Curtis
Otherwise ff_alloc_extradata() just leaks any existing allocated memory. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From 15db35021f026296aba46699cc282d77bd1d295e Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Tue, 21 Nov 2017 15:10:08 -0800 Sub

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Dale Curtis
On Mon, Nov 20, 2017 at 2:24 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > > I think that could end with the correct result > > Thanks for the review. Done. - dale From fc7fb3511aa40810e64d9dacbd33d1e9336d0c52 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur.

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Dale Curtis
On Mon, Nov 20, 2017 at 12:34 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Nov 20, 2017 at 12:01:11PM -0800, Dale Curtis wrote: > > Derp, that's the wrong comment for this; I meant that for another thread. > > Returning an error for optional user d

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Dale Curtis
On Mon, Nov 20, 2017 at 12:40 PM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Mon, Nov 20, 2017 at 12:05:05PM -0800, Dale Curtis wrote: > > On Sat, Nov 18, 2017 at 2:44 AM, Michael Niedermayer > <mich...@niedermayer.cc > > > wrote: > > > >

[FFmpeg-devel] [ogg] Close ogg stream upon error when using AV_EF_EXPLODE.

2017-11-20 Thread Dale Curtis
Without this there can be multiple memory leaks with unknown ogg streams. - dale From 4fc9d288c50891a9740facc549c895da066af71b Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Mon, 20 Nov 2017 12:07:57 -0800 Subject: [PATCH] [ogg] Close ogg stream upon error when

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-20 Thread Dale Curtis
On Sat, Nov 18, 2017 at 2:44 AM, Michael Niedermayer wrote: > > this would skip the code for wrap_bits >= 63, this does not look > correct > Why do you think that's incorrect? The max int64_t value is 1 << 63 and 2 << 63 == 1 << 64 ? - dale

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Dale Curtis
Derp, that's the wrong comment for this; I meant that for another thread. Returning an error for optional user data seems a bit harsh, but if that's what you want, I'm happy to change it. Please let me know if this is the route you want to take. - dale On Mon, Nov 20, 2017 at 11:55 AM, Dale

Re: [FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-20 Thread Dale Curtis
On Fri, Nov 17, 2017 at 6:22 PM, Michael Niedermayer wrote: > > Not sure what is best but > throwing part of the version silently away is not correct > most likely erroring out and asking for a sample video to be uploaded > would make sense if such a file is encountered

[FFmpeg-devel] [mpeg4video] Fix undefined shift on assumed 8-bit input.

2017-11-17 Thread Dale Curtis
Curtis <dalecur...@chromium.org> From 0373fed23fb495161267607230e99c8ed36e444a Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Fri, 17 Nov 2017 16:05:30 -0800 Subject: [PATCH] [mpeg4video] Fix undefined shift on assumed 8-bit input. decode_user_data() attemp

[FFmpeg-devel] [mov] Fix leak of frame_duration_buffer in mov_fix_index().

2017-11-17 Thread Dale Curtis
Should be unconditionally freed at the end of mov_fix_index() in case it hasn't been used during the fix up. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From bbdf90542a98bb297d4143949e3281500815d0b1 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date:

[FFmpeg-devel] [mpegaudio] Use ff_thread_once for fixed, float table init.

2017-11-17 Thread Dale Curtis
These tables are static so they should only be initialized once instead of on every call to ff_mpadsp_init(). Signed-off-by: Dale Curtis <dalecur...@chromium.org> From 70ffbeb41f0432c72701f6147385e9aa47bf8419 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date:

Re: [FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-17 Thread Dale Curtis
Derp, actually, 2 << 63 doesn't fit in int64_t either, this check should be < 63. Fixed. On Fri, Nov 17, 2017 at 1:38 PM, Dale Curtis <dalecur...@chromium.org> wrote: > 2 << (wrap_bits=64 - 1) does not fit in int64_t; apply the check > used in other places that

[FFmpeg-devel] [avformat] Prevent undefined shift with wrap_bits > 63.

2017-11-17 Thread Dale Curtis
2 << (wrap_bits=64 - 1) does not fit in int64_t; apply the check used in other places that handle wrap bits to ensure the values are <= 63. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From c566067623760a24f729ac5197c20531b9e518ae Mon Sep 17 00:00:00 2001 From: Dale

Re: [FFmpeg-devel] [PATCH] lavf/mov: don't read outside frag_index bounds

2017-11-17 Thread Dale Curtis
lgtm, fixes the crash and doesn't regress any of our tests. - dale On Fri, Nov 17, 2017 at 8:21 AM, John Stebbins wrote: > Potentially fixes: > https://bugs.chromium.org/p/chromium/issues/detail?id=786269#c1 > > In theory, the crash can be triggered by an invalid

Re: [FFmpeg-devel] Avoid corrupting diagnostic state with _Pragma changes.

2017-11-13 Thread Dale Curtis
Ping? On Fri, Nov 3, 2017 at 5:13 PM, Dale Curtis <dalecur...@chromium.org> wrote: > The macros for ICC and MSVC correctly push and pop the diagnostic > state of the compiler when disabling deprecation warnings. The > ones for clang/gcc should do the same. Without thi

[FFmpeg-devel] Avoid corrupting diagnostic state with _Pragma changes.

2017-11-03 Thread Dale Curtis
with FF_ENABLE_DEPRECATION_WARNINGS. Signed-off-by: Dale Curtis <dalecur...@chromium.org> From 73a488e07a328d05aa2b507a551b0c1e4b8a81c8 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Fri, 3 Nov 2017 17:10:55 -0700 Subject: [PATCH] Avoid corrupting diagnostic state with _Pr

[FFmpeg-devel] Don't use _tzcnt instrinics with clang for windows w/o BMI.

2017-10-24 Thread Dale Curtis
s presence or exclude the usage of these intrinics when clang is present. See also: https://ffmpeg.org/pipermail/ffmpeg-devel/2015-November/183404.html https://bugs.llvm.org/show_bug.cgi?id=30506 http://lists.llvm.org/pipermail/cfe-dev/2016-October/051034.html Signed-off-by: Dale Curtis <dalecur...

Re: [FFmpeg-devel] [PATCH] libopus: Add channel mapping 2 support in libopusdec

2017-10-23 Thread Dale Curtis
Any update on this patch? We've been carrying it in Chrome for a while. - dale On Fri, Apr 7, 2017 at 11:14 AM, Felicia Lim wrote: > Hi, > > Just wanted to follow up and check if there any changes I should add to > this patch? > > Thanks for taking a look. > >

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-18 Thread Dale Curtis
On Wed, Oct 18, 2017 at 4:00 PM, Sasi Inguva wrote: > Thanks for the patch. The bug is because mov_fix_index updates > skip_samples correctly, but not start_pad. Can you instead of taking the > max, just update the mov_fix_index function so that start_pad = > skip_samples

Re: [FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-16 Thread Dale Curtis
More details on the issue which uncovered this can be seen here https://bugs.chromium.org/p/chromium/issues/detail?id=775042#c13 - dale On Mon, Oct 16, 2017 at 2:22 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Previously the start padding was used to blindly overwrite any skip

[FFmpeg-devel] [mov] When both edit list and start padding present, take maximum.

2017-10-16 Thread Dale Curtis
from https://cs.chromium.org/chromium/src/third_party/WebKit/LayoutTests/webaudio/resources/media/440hz-10ms.m4a - dale From 4d241904bc9f923f3c9cd93f19daae08bafbdae1 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Mon, 16 Oct 2017 14:17:35 -0700 Subject: [PATCH] [mov

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-31 Thread Dale Curtis
Ping, without the patch in the previous message you can get crashes when encountering these types of files. - dale On Mon, Aug 28, 2017 at 2:45 PM, Dale Curtis <dalecur...@chromium.org> wrote: > On Fri, Aug 25, 2017 at 6:09 PM, Michael Niedermayer < > mich...@nieder

[FFmpeg-devel] [mov] Remove concept of ctts entries with count > 1.

2017-08-28 Thread Dale Curtis
Previous ctts patches have all changed the system to always using count=1 since we expect ctts data to be 1:1 with samples. This deletes the concept of count>1 samples for clarity and performance. Requires "[mov] Bail when invalid sample data is present." to land first.\ - dale

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-28 Thread Dale Curtis
On Fri, Aug 25, 2017 at 10:18 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > > hmm > > maybe i misunderstand but assuming we insert a block of dummy blank > entries (without breaking monotonicity) and keep a pointer to that > block > > then add entries with a av_add_index_entry() > and

Re: [FFmpeg-devel] [PATCH] avformat/mov: prevent duplication of first fragment's ctts_data

2017-08-28 Thread Dale Curtis
lgtm, my patch is still necessary to ensure ctts samples aren't trampled when new headers do need to be read. This should prevent unnecessary work and spammy logs. - dale On Sat, Aug 5, 2017 at 6:04 PM, Daniel Glöckner wrote: > MP4 files with fragments might have the first

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-28 Thread Dale Curtis
On Fri, Aug 25, 2017 at 6:09 PM, Michael Niedermayer wrote: > > This changes the printed duration start time and bitrate for > MAV_0034.3G2 > see > https://trac.ffmpeg.org/ticket/2757 Thanks, I've restored the ability to query these types of files. That file also

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread Dale Curtis
On Mon, Aug 28, 2017 at 12:56 PM, wm4 wrote: > > LTO seems unlikely to help in this situation - the linker can't know > whether struct members and their initializers are unused. > Correct. > > But I think there's much much bigger fish to fry to save space. For > example,

Re: [FFmpeg-devel] [PATCH] Use NULL_IF_CONFIG_SMALL for AVOption tables.

2017-08-28 Thread Dale Curtis
On Mon, Aug 28, 2017 at 2:28 AM, wm4 wrote: > > > Seems way too intrusive and the result makes AVOption tables even > uglier and harder to read. Agree it's ugly. Any suggestions? I tried some way of forcing the AVOption entry to have zero-storage (thus null always), but

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-25 Thread Dale Curtis
ck of code. It passes all the fate test cases and those we have in Chrome. Let me know if fails any of your private test cases. - dale From 049f885ee972b0efb6dcbf456025e56dd627b8b9 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Mon, 31 Jul 2017 13:44:22 -0700 Subje

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-24 Thread Dale Curtis
On Thu, Aug 24, 2017 at 2:27 AM, Michael Niedermayer wrote: > > can the insertions be done in groups instead of one at a time ? > so that it basically merges 2 lists (O(n)) instead of inserting > one at a time O(n^2) > ? > This would significantly improve the worst case

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-24 Thread Dale Curtis
+michael This patch is also necessary now that you've applied the ctts fixes in the previous patch. Thanks. - dale On Fri, Aug 4, 2017 at 4:04 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Sample sent privately. I didn't find any non-fuzzer samples that no longer > demux i

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-23 Thread Dale Curtis
On Sat, Aug 19, 2017 at 3:50 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Sun, Aug 20, 2017 at 12:48:30AM +0200, Michael Niedermayer wrote: > > On Fri, Aug 18, 2017 at 03:57:45PM -0700, Dale Curtis wrote: > > > Anything else here? It'd be nice to get th

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-18 Thread Dale Curtis
Anything else here? It'd be nice to get this landed soon if no one has any other comments. - dale On Thu, Aug 10, 2017 at 1:02 PM, Dale Curtis <dalecur...@chromium.org> wrote: > On Tue, Aug 8, 2017 at 6:48 PM, Michael Niedermayer < > mich...@niedermayer.cc> wrote: > >

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-10 Thread Dale Curtis
tis/buck480p30_na.mp4 - dale From 6e77ff3deaa6e0ac04fb4e51dba1d4a0e69e9d5d Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Mon, 17 Jul 2017 17:38:09 -0700 Subject: [PATCH] Fix trampling of ctts during seeks when sidx support is enabled. When sidx box support is enabled,

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-07 Thread Dale Curtis
rst insert and total entries count, but their are several conditionals in av_add_index_entry() which may cause a bail out and such failure would be unrecoverable (maybe painfully?) if we moved everything ahead of time. - dale From 4938dac2d9f3b40c62822d9129046edbde44468d Mon Sep 17 00:00:00 2001

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-07 Thread Dale Curtis
On Fri, Aug 4, 2017 at 4:38 PM, Michael Niedermayer wrote: > so theres no easy way to create a smaller file then 64mb ? > Ah no, I didn't realize you had a size limit; I just meant none of the existing clips were large enough / worked. I've truncated the clip at

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-08-04 Thread Dale Curtis
Any comments here? +rodger who wrote the original sidx processing for review. - dale On Mon, Jul 31, 2017 at 3:01 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Whoops, that patch accidentally reverted to an earlier version. Here's the > fixed one that works with the mpg samp

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-08-04 Thread Dale Curtis
Sample sent privately. I didn't find any non-fuzzer samples that no longer demux in our Chrome test corpus or in fate. - dale On Wed, Aug 2, 2017 at 1:43 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2017-07-31 23:40 GMT+02:00 Dale Curtis <dalecur...@chromium.org>: >

Re: [FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-07-31 Thread Dale Curtis
I'm not convinced my original patch catches all cases. So here's an updated one which explicitly verifies the contract. - dale On Mon, Jul 31, 2017 at 2:40 PM, Dale Curtis <dalecur...@chromium.org> wrote: > [mov] Bail when invalid sample data is present. > > ctts data i

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-31 Thread Dale Curtis
Whoops, that patch accidentally reverted to an earlier version. Here's the fixed one that works with the mpg sample mentioned above. - dale On Mon, Jul 31, 2017 at 2:29 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Here's an updated patch with a fate test attached. You'll ne

[FFmpeg-devel] [mov] Bail when invalid sample data is present.

2017-07-31 Thread Dale Curtis
sc->sample_count > 0, sc->chunk_count is too. This should be applied on top of the ctts fixes in my previous patch. From e3b51516046255540c5a76b41e02cee7f0902541 Mon Sep 17 00:00:00 2001 From: Dale Curtis <dalecur...@chromium.org> Date: Mon, 31 Jul 2017 13:44:22 -0700 Subject: [PATC

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-31 Thread Dale Curtis
the existing samples, but you need a clip long enough that the entire index isn't generated from the start. - dale On Tue, Jul 25, 2017 at 1:03 PM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Mon, Jul 24, 2017 at 02:32:41PM -0700, Dale Curtis wrote: > > On Thu, Jul 2

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-24 Thread Dale Curtis
On Thu, Jul 20, 2017 at 5:00 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > Hi > > On Wed, Jul 19, 2017 at 07:30:01PM -0700, Dale Curtis wrote: > > Thanks will take a look. Is this test not part of fate? make fate passed > > no, we should have tests for

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-19 Thread Dale Curtis
017 at 7:30 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Thanks will take a look. Is this test not part of fate? make fate passed > for me. The attached patch fixes this; the issue was that the index entries > are 1 to 1 with ctts values. When samples are added without ctts e

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-19 Thread Dale Curtis
017 at 11:49:26AM -0700, Dale Curtis wrote: > > Updated patch that fixes other ctts modification code to use the new > > ctts_allocated_size value; I've verified this passes fate. > > > > - dale > > > > On Tue, Jul 18, 2017 at 9:53 AM, Dale Curtis <dalecur

Re: [FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-18 Thread Dale Curtis
Updated patch that fixes other ctts modification code to use the new ctts_allocated_size value; I've verified this passes fate. - dale On Tue, Jul 18, 2017 at 9:53 AM, Dale Curtis <dalecur...@chromium.org> wrote: > Resending as it's own message per contribution rules. I've also

[FFmpeg-devel] [mov] Fix trampling of ctts during seeks when sidx support is enabled.

2017-07-18 Thread Dale Curtis
that iterates O(n) over all samples with an O(1) when no non-1 count samples are present. Signed-off-by: Dale Curtis <dalecur...@chromium.org> --- libavformat/isom.h | 1 + libavformat/mov.c | 46 +++--- 2 files changed, 32 insertions(+), 15 del

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2017-07-17 Thread Dale Curtis
Okay the following patch should fix this issue. Chromium/reviewable version here https://chromium-review.googlesource.com/c/572585/ - dale On Fri, Jul 14, 2017 at 6:31 PM, Dale Curtis <dalecur...@chromium.org> wrote: > On Fri, Jul 14, 2017 at 5:38 PM, Michael Niedermayer

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2017-07-14 Thread Dale Curtis
On Fri, Jul 14, 2017 at 5:38 PM, Michael Niedermayer wrote: > > I dont think CTTS is the only affected atom. > > Thanks for the response. Yes, I think that's likely true. The ctts one is just likely the most important since it controls timestamp ordering. > what you

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2017-07-14 Thread Dale Curtis
On Fri, Jun 30, 2017 at 2:56 PM, Dale Curtis <dalecur...@chromium.org> wrote: > Hmm, finally got around to looking into this again and this still isn't > fixed. Just seeking a few times in ffplay can trigger this issue with the > clip linked in my original me

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2017-06-30 Thread Dale Curtis
Hmm, finally got around to looking into this again and this still isn't fixed. Just seeking a few times in ffplay can trigger this issue with the clip linked in my original message: http://storage.googleapis.com/dalecurtis-shared/buck480p30_na.mp4 ./ffplay -v debug -drp 1

Re: [FFmpeg-devel] [PATCH] lavf/mov: add support for sidx fragment indexes

2015-12-11 Thread Dale Curtis
This patch seems to be causing some issues with some h264 video-only content. Attempting to play the following in ffplay with "-v debug -drp 1" (disables pts/dts fixups and purely uses pts) will cause jerky playback after seeking around a few times due to dropped out of order frames. These are

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-28 Thread Dale Curtis
On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje wrote: > > So this is likely because we init all tables instead of just these that we > need, right? So how about having one ff_once per table? That should be > trivial to implement. Just so we're all on the same page, this

Re: [FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-26 Thread Dale Curtis
On Sun, Oct 25, 2015 at 4:56 AM, Ronald S. Bultje wrote: > > So this is likely because we init all tables instead of just these that we > need, right? So how about having one ff_once per table? That should be > trivial to implement. > (from the right account this time) Just

[FFmpeg-devel] [PATCH] Use ff_thread_once() to initialize sin/cos static tables.

2015-10-23 Thread Dale Curtis
Changes from partial initialization which happens for every initialize call to a full initialization once per process. Changes as discussed on list by wm4 and rbultje. Passes fft-test and fate suite. Signed-off-by: Dale Curtis <dalecur...@chromium.org> --- libavcodec/fft_template.

Re: [FFmpeg-devel] [PATCH] Don't needlessly reinitialize ff_cos_## tables.

2015-10-23 Thread Dale Curtis
http://ffmpeg.org/pipermail/ffmpeg-devel/2015-October/181938.html makes the changes to use ff_thread_once; this review may be abandoned. On Fri, Oct 23, 2015 at 5:15 AM, Derek Buitenhuis wrote: > On 10/23/2015 12:35 PM, wm4 wrote: >> There are 2 possibilities: >> 1.

  1   2   >