Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-21 Thread Devin Heitmueller
> On Sep 21, 2019, at 4:44 PM, Michael Niedermayer > wrote: > >> The patch just expands 4:2:0 to 4:2:2 while properly supporting interlaced >> chroma. > > 4:2:0 and 4:2:2 have a chroma plane with different resolution. > converting between planes of different resolution is what i called

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-20 Thread Devin Heitmueller
Hello Michael, > On Sep 20, 2019, at 12:10 PM, Michael Niedermayer > wrote: > > On Fri, Sep 20, 2019 at 11:55:17PM +0800, lance.lmw...@gmail.com wrote: >> From: Limin Wang >> >> Signed-off-by: Limin Wang >> --- >> libavcodec/v210_template.c | 20 >> libavcodec/v210enc.c

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: adjust for timecode lag

2019-08-20 Thread Devin Heitmueller
> A couple of follow-up Qs: > > Is auto-detection available for all Decklink devices? No, but AFAIK it is for all devices which support SDI. Generally it's the older analog capture devices which don't support it. > For those for which it is available, are there any edge cases in which > it sets

Re: [FFmpeg-devel] [CALL] New FFmpeg developers meeting

2019-08-17 Thread Devin Heitmueller
On Sat, Aug 17, 2019 at 4:18 PM James Almer wrote: > Start by drafting a list of subjects to discuss, and proposing a date > (at least two weeks from now) or asking for suggestions. Then wait to > see how many developers agree with it and confirm they will be there. Indeed, having some form of

Re: [FFmpeg-devel] [PATCH]Support for Frame Doubling/ Tripling in FFMPEG's HEVC Decoder by parsing the picture_struct SEI value (Support for http://ffmpeg.org/pipermail/ffmpeg-devel/2019-June/245521.h

2019-08-01 Thread Devin Heitmueller
er I’ve seen which puts out modes 11/12 and hence that would be useful as well. I suspect supporting that would be a relatively small incremental step from making modes 1/2 work. Reach out to me privately if anybody is interested in doing such a project. Devin --- D

Re: [FFmpeg-devel] [PATCH v4] avfilter/avf_aphasemeter: Add out-of-phase and mono detection

2019-07-05 Thread Devin Heitmueller
On Wed, Jul 3, 2019 at 9:34 AM Romane Lafon wrote: > > I've added documentation for the extension of aphasemeter filter. > Also, I'm not sure that "phasing" is the right word to describe the > detection. In some commercial analyzers I've also seen audio phase presented using the term "lissajous"

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-20 Thread Devin Heitmueller
On Mon, May 20, 2019 at 8:36 AM Phil Burr wrote: > > Thank you for the feedback. I will look into adding documentation for the > atsc metadata. ATSC requires in addition to the tables I've added, the STT > and EIT0-EIT3 tables. I'm thinking of adding support for STT and at least > producing

Re: [FFmpeg-devel] [PATCH v2] libavformat/mpegtsenc: Add minimal support for ATSC PSIP tables

2019-05-19 Thread Devin Heitmueller
Hello Phillip, On Thu, May 16, 2019 at 9:32 AM Phillip Burr wrote: > > Minimal support for ATSC PSIP tables. Does not support STT or > EIT tables and so is not compliant with terrestrial ATSC. > ATSC tables are not created by default, and will only be transmitted > if either "atsc_name" or

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use all Closed Captions side data

2019-05-19 Thread Devin Heitmueller
Hello Paul, On Fri, May 17, 2019 at 4:44 AM Paul B Mahol wrote: > > On 5/17/19, Mathieu Duponchelle wrote: > > There isn't one, as I said the added indentation is because of the new loop! > > To get this committed to tree you need to comply to review requests. I think Mathieu's point is that

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: fix checking video mode in SDK version 11

2019-05-05 Thread Devin Heitmueller
we don’t know what the effects are on other cards. Regards, Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Using copyts with mpegts output fails after 26, 5 hours

2019-05-03 Thread Devin Heitmueller
streams longer than 26.5 hours and expecting seeking to work properly seem like they are not compatible concepts. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] There may be a bug for .mp4 reader.

2019-04-01 Thread Devin Heitmueller
esn’t have any support for delivering individual fields. Decoders are expected to reassemble fields into frames before providing them back to callers. Presumably this is some sort of PAFF encoded stream? Does it decode properly when using the software h.264 decoder? Devin --- Devin

Re: [FFmpeg-devel] AVPixelFormat for YUYV 10 bit.

2019-03-25 Thread Devin Heitmueller
e it regularly with the Blackmagic cards (i.e. you can look at libavdevice/decklink_enc.cpp, decklink_dec.cpp for usage). Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH v7] mpeg12enc: Use Closed Captions if available

2019-02-16 Thread Devin Heitmueller
> It would be better to test against a decoder from a unrelated codebase > Otherwise its a bit like testing your new language skills by talking with > yourself. It should be pretty easy to just play the resulting TS in VLC and confirm the captions are present and play correctly. Devin -- Devin

Re: [FFmpeg-devel] [PATCH v4] mpeg12enc: Use Closed Captions if available

2019-02-08 Thread Devin Heitmueller
quick length check is reasonable to avoid a possible buffer overflow, so I would just write a log message and throw the entire array on the floor. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mai

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

2019-02-07 Thread Devin Heitmueller
> On Feb 7, 2019, at 1:22 PM, Mathieu Duponchelle > wrote: > > > > On 2/7/19 7:21 PM, Devin Heitmueller wrote: >> Isn’t this calculation incorrect? The max cc_count possible is 31 (0x1F), >> hence the max size should be 93. >> > > True that, u

Re: [FFmpeg-devel] [PATCH] mpeg12enc: Use Closed Captions if available

2019-02-07 Thread Devin Heitmueller
>pb, 8, '4'); > +put_bits(>pb, 8, 3); // > user_data_type_code > +put_bits(>pb, 8, > +((side_data->size / 3) & 0x1f) | 0x40); // flags, > cc_count > + put_bits(>pb, 8, 0xff); /

Re: [FFmpeg-devel] [PATCH] configure: request explicitly enabled components

2019-02-05 Thread Devin Heitmueller
On Tue, Feb 5, 2019 at 6:29 AM Carl Eugen Hoyos wrote: > How would this be better than printing a warning if the feature > could not be enabled as it is already done in some situations? In most systems I've worked with, if I say "enable something" and it cannot be enabled I want the ./configure

Re: [FFmpeg-devel] Decklink Output Problem

2019-01-30 Thread Devin Heitmueller
king anything else. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Devin Heitmueller
On Mon, Jan 14, 2019 at 12:45 PM Michael Niedermayer wrote: > well, there are other types of side data too. for example motion > vectors would need to be updated on crop depending on which rectangle > is croped out Ah, yes, of course. I thought we were just discussing captions. So are you

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Devin Heitmueller
> > In short, a centralized function would be good, but we probably need > > to think through what the API looks like so we don't have to introduce > > a new API in libavutil and then deprecate it once we want to make the > > splitting/combining logic work according to the spec. > > I fear that no

Re: [FFmpeg-devel] yadif frame doubling - incorrect closed captioning

2019-01-14 Thread Devin Heitmueller
On Mon, Jan 14, 2019 at 3:31 AM Michael Niedermayer wrote: > Thus a new function should be added which does all this, and that then > be used For what it's worth, the fix is actually incorrect both here and in vf_vps. When doubling the framerate, the correct behavior is to split the content

Re: [FFmpeg-devel] [PATCH]lavc/mpeg12dec: Read Closed Captions from second field

2018-11-29 Thread Devin Heitmueller
On Thu, Nov 29, 2018 at 12:55 PM Michael Niedermayer wrote: > > +if (s1->a53_caption) { > > +AVFrameSideData *sd; > > +av_frame_remove_side_data(s->current_picture_ptr->f, > > AV_FRAME_DATA_A53_CC); > > +sd = av_frame_new_side_data( > > +

[FFmpeg-devel] [PATCH] decklink: Fix compile breakage on OSX

2018-10-19 Thread Devin Heitmueller
Make the function static, or else Clang complains with: error: no previous prototype for function 'decklink_get_attr_string' [-Werror,-Wmissing-prototypes] Signed-off-by: Devin Heitmueller --- libavdevice/decklink_common.cpp | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/3] lavc/h264: create AVFrame side data from H.264 timecodes

2018-10-09 Thread Devin Heitmueller
> On Oct 9, 2018, at 4:02 PM, Carl Eugen Hoyos wrote: > > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >> From: Devin Heitmueller >> >> Create SMPTE ST 12-1 timecodes based on H.264 SEI picture timing >> info. >> >> For framerates &g

Re: [FFmpeg-devel] [PATCH 2/3] lavf/timecode: document SMPTE struct

2018-10-09 Thread Devin Heitmueller
> On Oct 9, 2018, at 4:07 PM, Carl Eugen Hoyos wrote: > > 2018-10-09 15:32 GMT+02:00, jos...@ob-encoder.com : >> From: Devin Heitmueller >> >> There are a number of different binary representations in which >> SMPTE timecodes can use. Make clear

Re: [FFmpeg-devel] [PATCH] avcodec: libdav1d AV1 decoder wrapper

2018-09-29 Thread Devin Heitmueller
On Sat, Sep 29, 2018 at 6:04 AM Rostislav Pehlivanov wrote: > I'd much rather go with the original intent which was to merge the decoder > into lavc. Ronald can correct me if I'm wrong, but I suspect a key goal behind the decoder was to have a standalone library which could be shared across a

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Add option to align Capture start time

2018-09-27 Thread Devin Heitmueller
to that and it seems like a good bit more trouble than it’s worth. I withdrawal any objections I had to the original patch. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: Add option to align Capture start time

2018-09-24 Thread Devin Heitmueller
filter or a BSF). Does anyone else have an suggestions as to a better place to do this? Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

2018-09-11 Thread Devin Heitmueller
On Mon, Sep 10, 2018 at 8:00 PM, Marton Balint wrote: > Yes, just put the same value to both line 12 (or whichever line the user > selects) and its pair line in the other field. Ok, will take care of this today. Thanks for reviewing. Devin -- Devin J. Heitmueller - Kernel Labs

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

2018-09-09 Thread Devin Heitmueller
Hi James, > Shouldn't this new packet side data be handled in libavcodec/decode.c > ff_decode_frame_props() as well? I have a patch which does this as part of a patch series which adds AFD parsing to decklink capture, ensures it gets preserved in ff_decode_frame_props, and encodes the resulting

Re: [FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

2018-09-09 Thread Devin Heitmueller
On Sun, Sep 9, 2018 at 4:59 PM, Marton Balint wrote: > Thanks, I applied patches 1-4. > >> decklink: Add support for output of Active Format Description (AFD) > > > Regarding this one, I noticed you always set the AFD in line 12. Are you > sure that it is OK to use line 12 for all resolutions?

[FFmpeg-devel] [PATCH 5/5] decklink: Add support for output of Active Format Description (AFD)

2018-09-07 Thread Devin Heitmueller
Implement support for including AFD in decklink output when putting out 10-bit VANC data. Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos and Aaron Levinson . Signed-off-by: Devin Heitmueller --- libavdevice/decklink_enc.cpp | 54

[FFmpeg-devel] [PATCH 4/5] v210enc: Pass through Active Format Description (AFD) data

2018-09-07 Thread Devin Heitmueller
When encoding to V210, make sure the AFD side data makes it through in the resulting AVPacket. This is needed so the decklink output module can put out AFD when in 10-bit mode. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 8 1 file changed, 8 insertions(+) diff --git

[FFmpeg-devel] [PATCH 2/5] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-09-07 Thread Devin Heitmueller
at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos , Aaron Levinson , and Moritz Barsnick Signed-off-by: Devin Heitmueller --- configure | 4 + libavdevice/decklink_common.cpp | 16 +++- libavdevice/decklink_common.h

[FFmpeg-devel] [PATCH 3/5] Allow AFD data to be embedded in AVPacket

2018-09-07 Thread Devin Heitmueller
Create a new AVPacket side data type for Active Format Description, which mirrors the side data type found in AVFrame. The primary use case for this is ensuring AFD gets preserved in the V210 encoder, so that the decklink libavdevice can output AFD. Signed-off-by: Devin Heitmueller

[FFmpeg-devel] [PATCH 0/5] Support for Decklink output of EIA-708 and AFD

2018-09-07 Thread Devin Heitmueller
bail out if there was a problem with any VANC data, even if all the other VANC data was perfectly valid). Devin Heitmueller (5): v210enc: Pass through A53 CC data libavdevice/decklink: Add support for EIA-708 output over SDI Allow AFD data to be embedded in AVPacket v210enc: Pass through

[FFmpeg-devel] [PATCH 1/5] v210enc: Pass through A53 CC data

2018-09-07 Thread Devin Heitmueller
When encoding to V210, make sure the CC side data makes it through in the resulting AVPacket. This is needed so the decklink output module can put out captions when in 10-bit mode. Signed-off-by: Devin Heitmueller --- libavcodec/v210enc.c | 9 + 1 file changed, 9 insertions(+) diff

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-27 Thread Devin Heitmueller
> On Aug 26, 2018, at 11:34 AM, Marton Balint wrote: > > Hello Marton, Ok, I’ll take another pass and send an updated patch. Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-27 Thread Devin Heitmueller
Hello Vittorio, Thanks for the feedback. > > I think you should add an entry in ff_decode_frame_props() so that pkt side > data can propagate to frame side data > -- > Vittorio I’ve got a whole patch series related to capture of AFD from decklink and getting it through the pipeline (to be

[FFmpeg-devel] [PATCH] Support 64-bit integers for av_get_frame_filename2()

2018-08-24 Thread Devin Heitmueller
s -vsync 0 -i foo.ts -frame_pts 1 -enc_time_base -1 foo_%d.png Signed-off-by: Devin Heitmueller --- libavformat/avformat.h | 2 ++ libavformat/img2enc.c | 2 +- libavformat/utils.c| 9 +++-- 3 files changed, 10 insertions(+), 3 deletions(-) diff --git a/libavformat/avformat.h b/l

[FFmpeg-devel] [PATCH 1/2] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-08-22 Thread Devin Heitmueller
at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos , Aaron Levinson , and Moritz Barsnick Signed-off-by: Devin Heitmueller --- configure | 4 + libavcodec/v210enc.c| 9 ++ libavdevice/decklink_common.cpp

[FFmpeg-devel] [PATCH 0/2] Support for Decklink output of EIA-708 and AFD

2018-08-22 Thread Devin Heitmueller
The following patches add support for output of 708 and AFD over the Decklink SDI interface. This series is a subset of a series submitted in early January, with the hope of getting the less controversial parts merged upstream. Devin Heitmueller (2): libavdevice/decklink: Add support for EIA

[FFmpeg-devel] [PATCH 2/2] decklink: Add support for output of Active Format Description (AFD)

2018-08-22 Thread Devin Heitmueller
Implement support for including AFD in decklink output. This includes making sure the AFD data is preserved when going from an AVFrame to a V210 packet (needed for 10-bit support). Updated to reflect feedback from Marton Balint , Carl Eugen Hoyos and Aaron Levinson . Signed-off-by: Devin

Re: [FFmpeg-devel] [PATCH] h264: Support multi-field closed captions by using AVBufferRef and not resetting per field

2018-08-16 Thread Devin Heitmueller
mber of commercial hardware encoders I’ve worked with. We can debate the mechanics of how the buffers are referenced (which is why I believe it wasn’t merged last year), but I can say that this is a very real problem and at least this patch results in those streams playing properly. Cheers,

Re: [FFmpeg-devel] Why not integrate libyuv as a scale filter

2018-07-23 Thread Devin Heitmueller
e optimized assembly worth looking closer at, but my gut reaction is that it’s likely just that libswscale’s defaults to a higher quality scaler (at the associated cost), and you can achieve comparable numbers as found in libyuv by tweaking the configuration. Devin --- Devin

Re: [FFmpeg-devel] [PATCH] Limited timecode support for lavd/decklink

2018-07-16 Thread Devin Heitmueller
> On Jul 16, 2018, at 2:56 PM, Jonathan Morley wrote: > > That is really interesting feedback guys. I have been thinking about things > mostly in a MOV independent timecode track (or tracks) kind of way, but I > know OMF, MXF, AAF, etc handle it more analogously to packet/frame side data. >

Re: [FFmpeg-devel] [PATCH] Limited timecode support for lavd/decklink

2018-07-16 Thread Devin Heitmueller
ert a split filter on the video stream and feed both the actual video encoder and a second encoder instance which throws away the video frames and just acts on the side data to create the caption stream. And of course you have same problem in the other direction - if you receive the timeco

Re: [FFmpeg-devel] Ffmpeg, UDP input source from satellite audio sync issues

2018-06-20 Thread Devin Heitmueller
Hello Ibrahim, > I do have another issue with Audio sync when segmenting live content coming > from satellite but without encoding (stream copying only). And since you > cannot use aresample when copying I am unsure how you would go about to > solve that issue. I can make a few general

Re: [FFmpeg-devel] [PATCH] Limited timecode support for lavd/decklink

2018-05-31 Thread Devin Heitmueller
> > I'd rather see a new AVPacketSideData type which will contain the timecode as > a string, so you can set it frame-by-frame. For what it’s worth, this is what I’ve done on the decklink output side. I’ve introduced a new side data type and I’m able to decode timecodes provided in H.264

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

2018-05-18 Thread Devin Heitmueller
> The issue is that the PMT PID advertised in the PAT contains multiple PMTs > for different programs. This is because the broadcaster decided to re-use > the same PID for multiple program PMTs. Ugh, ok. I understand the case you're talking about now. Thanks for clarifying. > To be clear, this

Re: [FFmpeg-devel] Stream selection algorithm crossing program boundaries

2018-05-18 Thread Devin Heitmueller
Hello Gyan, Thanks for your comments. See inline: > On May 18, 2018, at 10:24 AM, Gyan Doshi wrote: > If nb_input_files is 1, coupling the stream selection seems to me an > improvement. But in the scenario of multiple inputs and no -map options, > users usually intend to

[FFmpeg-devel] Stream selection algorithm crossing program boundaries

2018-05-18 Thread Devin Heitmueller
dio/video in MPEG-TS streams behave differently than other formats). Thoughts? Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: add skip_unknown_pmt option

2018-05-18 Thread Devin Heitmueller
Hello Aman, On Thu, May 17, 2018 at 8:04 PM, Aman Gupta wrote: > From: Aman Gupta > > Some filtered mpegts streams may erroneously include PMTs for programs > that are not advertised in the PAT. This confuses ffmpeg and most > players because multiple audio/video

Re: [FFmpeg-devel] [RFC][ALT PATCHES] Code of Conduct Enforcement

2018-05-15 Thread Devin Heitmueller
> I'm leaning toward 2, but there would need to be some other way to deal > with people not getting along. Maybe Mumble conferences where the > involved parties get to air their feelings on whatever is at issue? I > dunno I'm not weighing in on the CoC so much as offering my experience with other

Re: [FFmpeg-devel] ? Inserting an image in the middle of a video stream

2018-04-25 Thread Devin Heitmueller
Hi John, On Wed, Apr 25, 2018 at 5:11 PM, John P Poet wrote: > I am working on a project where I need to insert a repeating image (10 > seconds) in the middle of a video stream while also transcoding from one > video codec to another. The images are going to be either png or

Re: [FFmpeg-devel] State of decklink_ctx vs. decklink_cctx

2018-03-27 Thread Devin Heitmueller
Hi Grady, > On Mar 27, 2018, at 3:05 PM, grady player wrote: > > So I haven't looked in great detail so this may all be info that you know, > and maybe not helpful... > > 1. You can easily link C objects to C++ code by marking it `extern "C"` > 2. You can not easily link

[FFmpeg-devel] State of decklink_ctx vs. decklink_cctx

2018-03-27 Thread Devin Heitmueller
g new features to both capture and output, it would be good to better understand which of the two structs is appropriate to own the state information. Thanks in advance, Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltngloba

Re: [FFmpeg-devel] Moving enum AVFieldOrder to libavutil?

2018-03-26 Thread Devin Heitmueller
Hello all, > On Mar 24, 2018, at 6:37 AM, Michael Niedermayer <mich...@niedermayer.cc> > wrote: > > On Sat, Mar 24, 2018 at 01:07:48AM +0100, Marton Balint wrote: >> >> >> On Fri, 23 Mar 2018, Devin Heitmueller wrote: >> >>> Hello, &g

[FFmpeg-devel] Moving enum AVFieldOrder to libavutil?

2018-03-23 Thread Devin Heitmueller
the scaler for format conversion as needed). Devin --- Devin Heitmueller - LTN Global Communications dheitmuel...@ltnglobal.com ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-22 Thread Devin Heitmueller
t, but I really do think things like V210 should be a raw frame colorspace rather than a codec. Then we would be able to use a wrapped avframe for everything and wouldn’t lose all that data when translating from an AVFrame to an AVPacket. Devin --- Devin Heitmueller - LTN Global Commun

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Devin Heitmueller
Hi James, > No, this is done after that, while processing a packet. > It is also making changes to the output codecpar after write_header() > was called, which is wrong. > > libavformat used to delay writing the header until you feed it the first > packet, an internal functionality this code

Re: [FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Devin Heitmueller
Hi Marton, > As far as I remember ffmpeg.c has code for this around line 1220: > > if (in_picture->interlaced_frame) { > if (enc->codec->id == AV_CODEC_ID_MJPEG) >mux_par->field_order = in_picture->top_field_first ? > AV_FIELD_TT:AV_FIELD_BB; > else >

[FFmpeg-devel] Field order during libavformat write_header

2018-03-21 Thread Devin Heitmueller
Hello, I’m doing some debugging of format selection for the decklink device, and in particular trying to get it to properly support interlaced formats. One thing that came to my attention was the following commit:

Re: [FFmpeg-devel] [PATCH 4/8] h264_metadata: Add support for A/53 closed captions

2018-03-12 Thread Devin Heitmueller
> Does extracting really make sense? Doesn't the data end up out of > order and basically unusable? For what it’s worth, I’ve got a video filter which extracts the A53 side data and saves it into an MCC file (Telestream MacCaption format). If people think that’s something that would be

Re: [FFmpeg-devel] [PATCH] doc/outdevs: Add declink signal generator example

2018-03-09 Thread Devin Heitmueller
> The decklink outdev finds the correct mode by searching for the properties > (frame rate, field order, dimension) of the stream which is provided to it. > So specifying the format_code should not be needed. In principle you are correct that it "should not be needed". However there are numerous

Re: [FFmpeg-devel] [PATCH] doc/outdevs: Add declink signal generator example

2018-03-09 Thread Devin Heitmueller
>> +ffmpeg -re -f lavfi -i "testsrc=s=1920x1080:rate=3/1000" -f lavfi -i >> "sine=frequency=1000:sample_rate=48000" +-ac 2 -acodec pcm_s16le >> -pix_fmt uyvy422 -format_code Hi30 -f decklink 'DeckLink Studio 2' > > You should not need the -re flag, the decklink outdev blocks if it

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore scte20 captions when a53 data is also present

2018-03-07 Thread Devin Heitmueller
> From what I've seen in US broadcast television, scte20 is only used on > standard-def content and everything else uses normal a53. A53 is definitely the more popular standard, and all that is approved for distribution in digital over the air broadcasts. SCTE-20 would only be found further

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg12dec: ignore scte20 captions when a53 data is also present

2018-03-07 Thread Devin Heitmueller
> On Mar 7, 2018, at 12:49 PM, Michael Niedermayer > wrote: > > On Tue, Mar 06, 2018 at 02:25:12PM -0800, Aman Gupta wrote: >> From: Aman Gupta >> >> Some streams include both a53 and scte20 data. Before this commit, >> the scte20 data would be used

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract NTSC VANC

2018-02-05 Thread Devin Heitmueller
Hi Marton, > > Have you found which standard contains reference to interleaved VANC? So SMPTE falls back onto the earlier standards for digital video bitstreams as defined in ITU BT.656 (for SD) and BT.1120 (for HD). > >> >> That said, the list of modes should probably be expanded to

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract NTSC VANC

2018-02-05 Thread Devin Heitmueller
Hello Marton, > I thought you are working on an updated patch, or I just missed the new one? > The email you replied to here definitely contains the old, without > interleaved VANC autodetection or proper width for get_metadata. I did some digging into this after discussion with Ray (both by

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-25 Thread Devin Heitmueller
Hi Ray, > > Please find updated patch attatched. I reverted the vanc lines changes and > found that all my tests worked as expected, so not sure what was wrong w/ > my original test. The need to extract vanc from the entire line vs just the > luma in NTSC is still required. It’s helpful if in

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-23 Thread Devin Heitmueller
Hi Ray, > On Jan 22, 2018, at 11:20 PM, Ray Tiley wrote: > > I'm reading 334-1:2017 Sec 4 > "When the ANC packets defined in this standard are carried in a high > definition signal, they shall be carried in the Y stream." > > I couldn't find anywhere in the document where

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Devin Heitmueller
Hi Ray, > On Jan 22, 2018, at 10:47 PM, Ray Tiley wrote: >> Could you confirm whether you are capturing via SDI or analog (i.e. >> composite/component)? Also what is the capturing device and SDK version >> you are using? I’ve found various bugs in the numbering of VANC

Re: [FFmpeg-devel] [PATCH] avdevice/decklink_dec: Extract 1080i and NTSC VANC

2018-01-22 Thread Devin Heitmueller
Hi Ray, Thanks for your patch. A few questions: Could you confirm whether you are capturing via SDI or analog (i.e. composite/component)? Also what is the capturing device and SDK version you are using? I’ve found various bugs in the numbering of VANC lines in some cards, particularly with

Re: [FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

2018-01-12 Thread Devin Heitmueller
Hello Marton, Thank you for the feedback. Comments inline. >> +vanc_ctx->callback_context = _ctx; >> +int ret = klvanc_packet_parse(vanc_ctx, lineNr, decoded_words, >> sizeof(decoded_words) / (sizeof(uint16_t))); > > A parity error also causes a negative return value? Or

Re: [FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-01-10 Thread Devin Heitmueller
Hello Moritz, > On Wed, Jan 10, 2018 at 14:29:43 +0100, Moritz Barsnick wrote: >>> +for (size_t i = 0; i < cc_count; i++) { >> Declare i outside the clause. >>> +for (int i = 0; i < vanc_lines.num_lines; i++) { >> Same here. > > Sorry, this rule may not apply to C++ files, as it's

[FFmpeg-devel] [PATCH 11/11] decklink: Fix compilation of module on OSX

2018-01-08 Thread Devin Heitmueller
SDK sources, so suppress the warning just for that one #include. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 11 +++ 1 file changed, 11 insertions(+) diff --git a/libavdevice/decklink_common.cpp b/libavdevice/decklink_common.cpp

[FFmpeg-devel] [PATCH 10/11] decklink: log Blackmagic SDK version compiled against

2018-01-08 Thread Devin Heitmueller
Add a line to show the SDK version used in the build, if loglevel is set to verbose. This is simply to aid in debugging when building against different SDKs. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_common.cpp | 4 1 file changed, 4 inse

[FFmpeg-devel] [PATCH 08/11] decklink: Add support for compressed AC-3 output over SDI

2018-01-08 Thread Devin Heitmueller
> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_enc.cpp | 100 --- 1 file changed, 85 insertions(+), 15 deletions(-) diff --git a/libavdevice/decklink_enc.cpp b/libavdevice/decklink_enc.cpp index f

[FFmpeg-devel] [PATCH 09/11] decklink: Suppress warning about misuse of struct instead of class

2018-01-08 Thread Devin Heitmueller
When building with Clang, the following warning is shown: warning: struct 'IDeckLinkVideoFrame' was previously declared as a class [-Wmismatched-tags] The function incorrectly casts IDeckLinkVideoFrame as a struct instead of a class pointer. Signed-off-by: Devin Heitmueller <dheitm

[FFmpeg-devel] [PATCH 04/11] Preserve AFD side data when going from AVPacket to AVFrame

2018-01-08 Thread Devin Heitmueller
This is needed to ensure that AFD data continues to work when capturing V210 video with the Decklink libavdevice input. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/decode.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavcodec/decode.c b/liba

[FFmpeg-devel] [PATCH 07/11] decklink: Add support for SCTE-104 to decklink capture

2018-01-08 Thread Devin Heitmueller
Buitenhuis <derek.buitenh...@gmail.com> and Aaron Levinson <alevinsn_...@levland.net> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- doc/indevs.texi | 4 +++ libavcodec/avcodec.h| 1 + libavcodec/codec_desc.c | 6 l

[FFmpeg-devel] [PATCH 06/11] decklink: Add support for using libklvanc from within capture module

2018-01-08 Thread Devin Heitmueller
n <alevinsn_...@levland.net> Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavdevice/decklink_dec.cpp | 136 +++ 1 file changed, 136 insertions(+) diff --git a/libavdevice/decklink_dec.cpp b/libavdevice/decklink_dec.cpp index

[FFmpeg-devel] [PATCH 01/11] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-01-08 Thread Devin Heitmueller
at: https://github.com/stoth68000/libklvanc Updated to reflect feedback from Marton Balint <c...@passwd.hu>, Carl Eugen Hoyos <ceffm...@gmail.com>, and Aaron Levinson <alevinsn_...@levland.net>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- configure

[FFmpeg-devel] [PATCHv4 00/11] Decklink updates

2018-01-08 Thread Devin Heitmueller
This patch series provides a number of enhancements for both capture and output using the decklink module, including addressing comments from Marton Balint, Derek Buitenhuis, James Almer, Carl Eugen Hoyos, and Aaron Levinson. Devin Heitmueller (11): libavdevice/decklink: Add support for EIA-708

[FFmpeg-devel] [PATCH 02/11] decklink: Add support for output of Active Format Description (AFD)

2018-01-08 Thread Devin Heitmueller
t; and Aaron Levinson <alevinsn_...@levland.net>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/avcodec.h | 6 ++ libavcodec/v210enc.c | 8 libavdevice/decklink_enc.cpp | 44 ++-- 3 file

[FFmpeg-devel] [PATCH 03/11] decklink: Introduce support for capture of multiple audio streams

2018-01-08 Thread Devin Heitmueller
<a...@fem.tu-ilmenau.de>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- doc/indevs.texi | 8 ++- libavdevice/decklink_common.cpp | 12 libavdevice/decklink_common.h | 8 ++- libavdevice/decklink_common_c.h | 6 ++ libavdevice/d

[FFmpeg-devel] [PATCH 05/11] Support encoding of Active Format Description (AFD) in libx264

2018-01-08 Thread Devin Heitmueller
types (i.e. videotoolbox, etc). Updated to reflect feedback from Derek Buitenhuis <derek.buitenh...@gmail.com> and Aaron Levinson <alevinsn_...@levland.net>. Signed-off-by: Devin Heitmueller <dheitmuel...@ltnglobal.com> --- libavcodec/internal.h | 3 +++ libavcod

Re: [FFmpeg-devel] [PATCH 8/8] decklink: Add support for compressed AC-3 output over SDI

2018-01-05 Thread Devin Heitmueller
Hi Aaron, >> +static int create_s337_payload(AVPacket *pkt, enum AVCodecID codec_id, >> uint8_t **outbuf, int *outsize) >> +{ >> +uint8_t *s337_payload; >> +uint8_t *s337_payload_start; >> +int i; >> + >> +/* Encapsulate AC3 syncframe into SMPTE 337 packet */ >> +*outsize =

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2018-01-05 Thread Devin Heitmueller
Hello Matthias, Thanks for the feedback. Comments inline: > On Jan 2, 2018, at 4:52 AM, Matthias Hunstock <a...@fem.tu-ilmenau.de> wrote: > > Am 29.12.2017 um 19:12 schrieb Devin Heitmueller: >> To support the existing use case where multi-channel audio can be >> ca

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2018-01-05 Thread Devin Heitmueller
>> +if (ctx->max_audio_channels > DECKLINK_MAX_AUDIO_CHANNELS) { >> +av_log(avctx, AV_LOG_WARNING, "Decklink card reported support for >> more channels than ffmpeg supports\n"); > > "Decklink" -> "DeckLink", "ffmpeg" -> "FFmpeg". Also, I think it is > preferable to not state

Re: [FFmpeg-devel] [PATCH 7/8] decklink: Add support for SCTE-104 to decklink capture

2018-01-05 Thread Devin Heitmueller
> On Dec 30, 2017, at 3:11 AM, Aaron Levinson <alevinsn_...@levland.net> wrote: > > On 12/29/2017 10:12 AM, Devin Heitmueller wrote: >> Make use of libklvanc to parse SCTE-104 packets and announce them >> as a new stream. Right now we just pass the payload st

Re: [FFmpeg-devel] [PATCH 6/8] Add suppoort for using libklvanc from within decklink capture module

2018-01-05 Thread Devin Heitmueller
Hi Aaron, > On Dec 30, 2017, at 2:34 AM, Aaron Levinson wrote: > > Patch title: "suppoort" -> "support", also "decklink" -> “DeckLink" Ok. >>ff_decklink_cleanup(avctx); >> avpacket_queue_end(>queue); >> +klvanc_context_destroy(ctx->vanc_ctx); > >

Re: [FFmpeg-devel] [PATCH 5/8] Support encoding of Active Format Description (AFD) in libx264

2018-01-05 Thread Devin Heitmueller
Hi Aaron, >> +ret = ff_alloc_afd_sei(frame, 0, _data, _size); >> +if (ret < 0) { >> +for (i = 0; i < num_payloads; i++) >> +av_free(x4->pic.extra_sei.payloads[i].payload); >> +av_free(x4->pic.extra_sei.payloads); > >

Re: [FFmpeg-devel] [PATCH 1/8] libavdevice/decklink: Add support for EIA-708 output over SDI

2018-01-05 Thread Devin Heitmueller
Hi Aaron, Comments inline: > > Most of the changes in this set of patches appear to only be relevant in the > case that libklvanc is enabled. Nevertheless, a number of the changes are > not wrapped in #if CONFIG_LIBKLVANC, which means that they will be exercised > even if libklvanc is not

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2018-01-05 Thread Devin Heitmueller
Hello Aaron, Thanks for the feedback. Comments inline. On Sat, Dec 30, 2017 at 12:34 AM, Aaron Levinson wrote: > Technically, there are a number of 2K and 4K video modes supported by some > DeckLink cards that have a 16x9 aspect ratio as well. This code would treat

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 Thread Devin Heitmueller
> On Dec 29, 2017, at 4:17 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 22:14 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: >> Hi Carl, >> >>> On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos <ceffm...@gmail.com>

Re: [FFmpeg-devel] [PATCH 2/8] decklink: Add support for output of Active Format Description (AFD)

2017-12-29 Thread Devin Heitmueller
> On Dec 29, 2017, at 4:09 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 22:02 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: >> >>> On Dec 29, 2017, at 3:48 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: >>>

Re: [FFmpeg-devel] [PATCH 3/8] decklink: Introduce support for capture of multiple audio streams

2017-12-29 Thread Devin Heitmueller
Hi Carl, > On Dec 29, 2017, at 3:55 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > > 2017-12-29 19:12 GMT+01:00 Devin Heitmueller <dheitmuel...@ltnglobal.com>: > >> +for (int i = 0; i < ctx->max_audio_channels / 2; i++) { >> +

  1   2   >