Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 98 -
1 file changed, 89 insertions(+), 9 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 6e7eae0..1153d65 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
The current algorithm is just "try all the combinations, and pick the best".
It's not very fast either, probably due to a lot of copying, but will do for
an initial implementation.
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 420
The current algorithm is just "try all the combinations, and pick the best".
It's not very fast either, probably due to a lot of copying, but will do for
an initial implementation.
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 420
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 11 ++-
1 file changed, 6 insertions(+), 5 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index eae778b..cb1cebb 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -856,13 +856,13 @@ static int
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 10 +-
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index eae778b..7a5c464 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -856,13 +856,13 @@ static int
---
libavcodec/pngdec.c | 47 +++
1 file changed, 27 insertions(+), 20 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 60c4975..eae778b 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -643,6 +643,11 @@ static int
The current algorithm is just "try all the combinations, and pick the best".
It's not very fast either, probably due to a lot of copying, but will do for
an initial implementation.
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 420
On 13 July 2015 at 20:50, Ronald S. Bultje wrote:
> Hi,
>
> On Mon, Jul 13, 2015 at 4:26 AM, Donny Yang wrote:
>
> > Hello
> >
> > I'm trying to fix ffmpeg's APNG decoding for images with the PREVIOUS
> > dispose op while trying to keep it multithr
ds work?
Or should I just disable threading?
PS. I already asked my GSoC mentor about this and he said to disable
threading, but I submitted a patch a while ago to disable threading and
another dev was against that.
From f801fd3934f83d0bc0edf389a50967207c6be168 Mon Sep 17 00:00:00 2001
From: Donny
---
libavformat/apngenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/apngenc.c b/libavformat/apngenc.c
index dcf6b90..9b2c634 100644
--- a/libavformat/apngenc.c
+++ b/libavformat/apngenc.c
@@ -173,7 +173,7 @@ static void flush_packet(AVFormatContext *format_con
The current algorithm is just "try all the combinations, and pick the best".
It's not very fast either, probably due to a lot of copying, but will do for
an initial implementation.
---
libavcodec/pngenc.c | 423 +++-
1 file changed, 387 insertions(+)
Fixed so threading isn't removed completely.
Sorry this took so long. Took too long to figure out that decode_ihdr_chunk()
was being called in each thread and thus overwriting the cur_w/h value set by
update_thread_context().
("Remove threading support" patch can be ignored now)
_
frame should be disposed
This patch fixes ffmpeg's behaviour to match those of the spec, which involved
a rewrite of the blending function
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 179 +++-
1 file changed, 92 insertions(+), 87 deletion
On 3 June 2015 at 04:15, Ronald S. Bultje wrote:
> Hi,
>
> On Tue, Jun 2, 2015 at 1:42 PM, Donny Yang wrote:
>
> > On 3 June 2015 at 03:31, Paul B Mahol wrote:
> >
> > > Dana 2. 6. 2015. 17:49 osoba "Donny Yang" napisala je:
> > > >
&
On 3 June 2015 at 03:38, Paul B Mahol wrote:
> Dana 2. 6. 2015. 17:50 osoba "Donny Yang" napisala je:
> >
> > Signed-off-by: Donny Yang
> > ---
> > libavcodec/pngdec.c | 8 +++-
> > 1 file changed, 7 insertions(+), 1 deletion(-)
> >
On 3 June 2015 at 03:31, Paul B Mahol wrote:
> Dana 2. 6. 2015. 17:49 osoba "Donny Yang" napisala je:
> >
> > Each frame depends on the previous frame any way, and it will
> > cause bugs with frame disposal
> >
> > Signed-off-by: Donny
Currently restricted to blending pixels that only contain either
0 or 255 in their alpha components
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 15 ++-
1 file changed, 14 insertions(+), 1 deletion(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 1667530
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 8 +++-
1 file changed, 7 insertions(+), 1 deletion(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 1f5c433..1667530 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -891,7 +891,8 @@ static int
frame should be disposed
This patch fixes ffmpeg's behaviour to match those of the spec, which involved
a rewrite of the blending function
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 166 +---
1 file changed, 80 insertions(+), 86 deletion
This time with bug fixes and feature additions properly separated
[PATCH 1/6] avcodec/apng: Remove threading support
[PATCH 2/6] avcodec/apng: Remove blending support for AV_PIX_FMT_ARGB
[PATCH 3/6] avcodec/apng: Dispose previous frame properly
[PATCH 4/6] avcodec/apng: Add blending support for no
ARGB is not a supported PNG pixel format
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 7 +--
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 2ea3e8b..5571d20 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 15 +++
1 file changed, 15 insertions(+)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 90bf725..1f5c433 100644
--- a/libavcodec/pngdec.c
+++ b/libavcodec/pngdec.c
@@ -58,6 +58,7 @@ typedef struct PNGDecContext
Each frame depends on the previous frame any way, and it will
cause bugs with frame disposal
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 2512799..2ea3e8b 100644
al support for blending AV_PIX_FMT_PAL8 with alpha
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 203 +---
1 file changed, 113 insertions(+), 90 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 2ea3e8b..4063347 10
Each frame depends on the previous frame any way, and it will
cause bugs with frame disposal
Signed-off-by: Donny Yang
---
libavcodec/pngdec.c | 11 +--
1 file changed, 1 insertion(+), 10 deletions(-)
diff --git a/libavcodec/pngdec.c b/libavcodec/pngdec.c
index 2512799..2ea3e8b 100644
[PATCH 1/2] avcodec/apng: Remove threading support
[PATCH 2/2] avcodec/apng: Dispose previous frame properly
Patches have been tested against:
- https://people.mozilla.org/~dolske/apng/
- http://littlesvr.ca/apng/images/clock.png
-
http://upload.wikimedia.org/wikipedia/commons/1/14/Animated_PN
On 23 April 2015 at 23:38, Nicolas George wrote:
> Le quartidi 4 floréal, an CCXXIII, Michael Niedermayer a écrit :
> > without really thinking about it, the idea to remove the extension
> > for apng or change it to .apng, seems like a good idea
>
> It looks like it is an officially supported ext
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 22 --
1 file changed, 12 insertions(+), 10 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 4349d1a..8699b80 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -27,6 +27,7 @@
#include
On 2 April 2015 at 00:23, Michael Niedermayer wrote:
> On Wed, Apr 01, 2015 at 01:17:50PM +0000, Donny Yang wrote:
> > On 1 April 2015 at 23:28, Michael Niedermayer wrote:
> >
> > > On Wed, Apr 01, 2015 at 12:07:46PM +, Donny Yang wrote:
> > > > On 1 Apri
On 1 April 2015 at 23:28, Michael Niedermayer wrote:
> On Wed, Apr 01, 2015 at 12:07:46PM +0000, Donny Yang wrote:
> > On 1 April 2015 at 22:57, Paul B Mahol wrote:
> >
> > > On 4/1/15, Donny Yang wrote:
> > > > On 1 April 2015 at 17:03, Paul B Mahol wrot
On 1 April 2015 at 22:57, Paul B Mahol wrote:
> On 4/1/15, Donny Yang wrote:
> > On 1 April 2015 at 17:03, Paul B Mahol wrote:
> >
> >> Dana 31. 3. 2015. 22:59 osoba "Donny Yang" napisala je:
> >> > +#include
> >>
> >>
On 1 April 2015 at 17:03, Paul B Mahol wrote:
> Dana 31. 3. 2015. 22:59 osoba "Donny Yang" napisala je:
> > +#include
>
> This is missing dependency on zlib in configure.
>
Fixed
From 83de9b22f63542c5190a76dde299335297f781d4 Mon Sep 17 00:00:00 2001
From: Donny Yan
Signed-off-by: Donny Yang
---
configure | 1 +
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 2 +-
libavcodec/pngenc.c| 149 ++---
4 files changed, 143 insertions(+), 10 deletions(-)
diff --git a/configure b/configure
Additionally, update some documentation with support for APNG
Signed-off-by: Donny Yang
---
Changelog| 1 +
doc/general.texi | 2 +
libavformat/Makefile | 1 +
libavformat/allformats.c | 2 +-
libavformat/apngenc.c| 269
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 142 +++-
1 file changed, 84 insertions(+), 58 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index c913cce..bf7c49e 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec
Additionally, update some documentation with support for APNG
Signed-off-by: Donny Yang
---
Changelog| 1 +
doc/general.texi | 2 +
libavformat/Makefile | 1 +
libavformat/allformats.c | 2 +-
libavformat/apngenc.c| 269
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 142 +++-
1 file changed, 84 insertions(+), 58 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index ca0ed25..e7c343b 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 12
1 file changed, 8 insertions(+), 4 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 8fff0f3..ca0ed25 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -307,12 +307,16 @@ static int
Signed-off-by: Donny Yang
---
configure | 1 +
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 2 +-
libavcodec/pngenc.c| 151 +
4 files changed, 144 insertions(+), 11 deletions(-)
diff --git a/configure b/configure
On 30 March 2015 at 02:48, Michael Niedermayer wrote:
> On Sun, Mar 29, 2015 at 11:05:41AM +0000, Donny Yang wrote:
> > Signed-off-by: Donny Yang
> > ---
> > libavcodec/pngenc.c | 2 --
> > 1 file changed, 2 deletions(-)
> >
> > diff --git a/libavcodec/p
Additionally, update some documentation with support for APNG
Signed-off-by: Donny Yang
---
Changelog| 1 +
doc/general.texi | 2 +
libavformat/Makefile | 1 +
libavformat/allformats.c | 2 +-
libavformat/apngenc.c| 250
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 27 ++-
1 file changed, 14 insertions(+), 13 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 0a215f2..410a829 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -299,7 +299,6
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 146 +++-
1 file changed, 86 insertions(+), 60 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 410a829..0264575 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 2 --
1 file changed, 2 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 3697dbb..bd3aae5 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -373,8 +373,6 @@ static int encode_frame(AVCodecContext *avctx
Signed-off-by: Donny Yang
---
configure | 1 +
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 2 +-
libavcodec/pngenc.c| 53 ++
4 files changed, 52 insertions(+), 5 deletions(-)
diff --git a/configure b/configure
index
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 124 +++-
1 file changed, 65 insertions(+), 59 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 6c8fec2..0a215f2 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 22 ++
1 file changed, 10 insertions(+), 12 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index bd3aae5..6c8fec2 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -382,19 +382,19 @@ static
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 19 +++
1 file changed, 15 insertions(+), 4 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index d6233d0..3697dbb 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -360,12 +360,23 @@ static int
On 29 March 2015 at 14:02, Carl Eugen Hoyos wrote:
> Donny Yang kota.moe> writes:
>
> > +{ "final_delay_num", "Force delay numerator after the last frame",
> > OFFSET(last_delay_num),
> > + AV_OPT_TYPE_INT, { .i64 = 0 }, 0, USHRT_MAX, EN
On 29 March 2015 at 03:15, Michael Niedermayer wrote:
> you can try AVCodecContext->frame_number, if that doesnt work
> you need to keep track of if you already had received a frame
>
I've tried both, but it turns out that AVCodecContext->frame_number seems
to be thread-specific. That is, it star
Additionally, update some documentation with support for APNG
Signed-off-by: Donny Yang
---
Changelog| 1 +
doc/general.texi | 2 +
libavformat/Makefile | 1 +
libavformat/allformats.c | 2 +-
libavformat/apngenc.c| 249
Signed-off-by: Donny Yang
---
configure | 1 +
libavcodec/Makefile| 1 +
libavcodec/allcodecs.c | 2 +-
libavcodec/pngenc.c| 40
libavcodec/version.h | 2 +-
5 files changed, 40 insertions(+), 6 deletions(-)
diff --git a
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 286 ++--
1 file changed, 163 insertions(+), 123 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index d6233d0..0264575 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 0231bf7..d6233d0 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -399,9 +399,9 @@ static int encode_frame
On 29 March 2015 at 00:08, Michael Niedermayer wrote:
> git send-email should send one patch per mail
Okay, here's my try with that
> pts == 0 is not a reliable way to detect the first picture
What would be the recommended way, then?
> this patchset also breaks PAL8
Yes, I know.
The only reason
Signed-off-by: Donny Yang
---
libavcodec/pngenc.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/libavcodec/pngenc.c b/libavcodec/pngenc.c
index 9bdefc4..0231bf7 100644
--- a/libavcodec/pngenc.c
+++ b/libavcodec/pngenc.c
@@ -512,9 +512,9 @@ static int encode_frame
unks to fdAT where needed.
On 28 March 2015 at 18:24, Paul B Mahol wrote:
> Dana 28. 3. 2015. 04:56 osoba "Donny Yang" napisala je:
> > On 28 March 2015 at 04:36, Paul B Mahol wrote:
> >>
> >> The style of code inside patch do not match other files in codebase
On 25 March 2015 at 04:18, Michael Niedermayer wrote:
> the generated png files seem to differ
>
> ./ffmpeg -i lena.pnm ref.png
>
> -rw-r- 1 michael michael 180438 Mar 24 18:11 after-patches.png
> -rw-r- 1 michael michael 180987 Mar 24 18:14 before-patches.png
>
It's because the non-APNG
226d5eae722c9f1cd650 Mon Sep 17 00:00:00 2001
From: Donny Yang
Date: Tue, 24 Mar 2015 09:47:20 +1100
Subject: [PATCH 1/2] apng: Make the PNG encoder output only a stream of bytes
in APNG mode
This is in preparation for the APNG muxer which will take the bytes and
add the headers there
--
user can
switch back (with `-f image2`)?
From d340772705fb1bd38b57c83ec2607f553a3613e6 Mon Sep 17 00:00:00 2001
From: Donny Yang
Date: Tue, 24 Mar 2015 09:47:20 +1100
Subject: [PATCH 1/2] apng: Make the PNG encoder output only a stream of bytes
in APNG mode
This is in preparation for the APNG
On 23 March 2015 at 21:50, Donny Yang wrote:
> Hello
>
> I was told to send my patch to ffmpeg-devel as well, so here it is.
> Please comment/critique on it and how I should improve the patch.
>
> Regards,
> Donny
>
> -- Forwarded message --
> From
Hello
I was told to send my patch to ffmpeg-devel as well, so here it is.
Please comment/critique on it and how I should improve the patch.
Regards,
Donny
-- Forwarded message --
From: Donny Yang
Date: 22 March 2015 at 01:10
Subject: GSoC: APNG
To: one...@gmail.com
Hello
I
62 matches
Mail list logo