Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-13 Thread Fāng-ruì Sòng
On Thu, Mar 14, 2019 at 10:36 AM Fāng-ruì Sòng wrote: > > On Thu, Mar 14, 2019 at 9:59 AM Henrik Gramner wrote: > > > > On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng > > wrote: > > > --- a/libavutil/mem.h > > > +++ b/libavutil/mem.h > > &g

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-13 Thread Fāng-ruì Sòng
On Thu, Mar 14, 2019 at 9:59 AM Henrik Gramner wrote: > > On Wed, Feb 20, 2019 at 8:03 PM Fāng-ruì Sòng > wrote: > > --- a/libavutil/mem.h > > +++ b/libavutil/mem.h > > > > +#if defined(__GNUC__) && !(defined(_WIN32) || defined(__CYGWIN__)) >

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-13 Thread Fāng-ruì Sòng
objects (used for C++ exceptions), etc On Thu, Mar 7, 2019 at 11:53 AM Fāng-ruì Sòng wrote: > Sorry, wrong signed-off-by line.. > > (isn't using my usual mail client mutt and i get very sick of the > webmail...) > > On Thu, Mar 7, 2019 at 11:36 AM Fāng-ruì Sòng wrote: >

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-06 Thread Fāng-ruì Sòng
Sorry, wrong signed-off-by line.. (isn't using my usual mail client mutt and i get very sick of the webmail...) On Thu, Mar 7, 2019 at 11:36 AM Fāng-ruì Sòng wrote: > On Wed, Mar 6, 2019 at 4:14 PM Carl Eugen Hoyos > wrote: > >> 2019-02-21 2:37 GMT+01:00, Fāng-ruì Sòng &l

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-06 Thread Fāng-ruì Sòng
On Wed, Mar 6, 2019 at 4:14 PM Carl Eugen Hoyos wrote: > 2019-02-21 2:37 GMT+01:00, Fāng-ruì Sòng >: > > Sorry if this doesn't attach to the correct thread as I didn't > > subscribe to this list and don't know the Message-ID of the thread. > > The thr

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-03-04 Thread Fāng-ruì Sòng
On Thu, Feb 21, 2019 at 10:06 AM Fāng-ruì Sòng wrote: > > > Why is it a good idea to remove them from the linker command line? > > In short, it improves portability. I'm not suggesting removing > -Bsymbolic or --version-script from the ffmpeg build system. I mean > us

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-02-20 Thread Fāng-ruì Sòng
nce that can be avoided. On Thu, Feb 21, 2019 at 9:37 AM Fāng-ruì Sòng wrote: > > Sorry if this doesn't attach to the correct thread as I didn't > subscribe to this list and don't know the Message-ID of the thread. > > > The word "also" indicates

Re: [FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-02-20 Thread Fāng-ruì Sòng
Sorry if this doesn't attach to the correct thread as I didn't subscribe to this list and don't know the Message-ID of the thread. > The word "also" indicates here that this should be an independent patch. I added `#if defined(__GNUC__) && !(defined(_WIN32) || defined(__CYGWIN__))`, not `#if (def

[FFmpeg-devel] [PATCH] avutil/mem: Mark DECLARE_ASM_ALIGNED as visibility("hidden") for __GNUC__

2019-02-20 Thread Fāng-ruì Sòng
Inline asm code assumes these DECLARE_ASM_ALIGNED declared global constants are non-preemptive, e.g. libavcodec/x86/cabac.h "lea"MANGLE(ff_h264_cabac_tables)", %0 \n\t" On ELF platforms, if -Wl,-Bsymbolic -Wl,--version-script,libavcodec/libavcodec.ver are removed from the linker