Re: [FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-19 Thread Guillaume Desmottes
Hi James, On 19/02/2019 17:14, James Almer wrote: On 2/11/2019 1:59 PM, Guillaume Desmottes wrote: CDG doesn't ensure a constant framerate as we can have holes in the CDG stream. So there is no guarantee of the duration of a single frame, it will be displayed until a new packet with CDG

Re: [FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-17 Thread Guillaume Desmottes
On 13/02/2019 16:28, Carl Eugen Hoyos wrote: Thanks for testing my patch. I wasn't aware of this specific test, sorry about that. What would be the proper way to address this? Should the fate reference be updated? Yes, unless the change is wrong. Ok thanks. So, who should I ask to review

Re: [FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-13 Thread Guillaume Desmottes
On 11/02/2019 23:41, Michael Niedermayer wrote: breaks fate-cdgraphics Hi Michael, Thanks for testing my patch. I wasn't aware of this specific test, sorry about that. What would be the proper way to address this? Should the fate reference be updated? The test file is still properly

[FFmpeg-devel] [PATCH] libavformat/cdg: unset duration on packets

2019-02-11 Thread Guillaume Desmottes
CDG doesn't ensure a constant framerate as we can have holes in the CDG stream. So there is no guarantee of the duration of a single frame, it will be displayed until a new packet with CDG instruction arrives in the stream. Signed-off-by: Guillaume Desmottes --- libavformat/cdg.c | 1 + 1 file