Re: [FFmpeg-devel] [PATCH v2 3/3] lavc/libdavs2: correct frame type setting

2018-10-31 Thread Huiwen Ren
At 2018-11-01 08:40:50, "Carl Eugen Hoyos" wrote: >2018-10-31 23:15 GMT+01:00, Mark Thompson : >> On 31/10/18 10:23, hwren wrote: > >>> +switch (pic->type) { >>> +case DAVS2_PIC_I: >>> +frame->pict_type = AV_PICTURE_TYPE_I; >>> +break; >>> +case

Re: [FFmpeg-devel] [PATCH v7 1/2] lavc, doc, configure: add libxavs2 video encoder wrapper

2018-09-09 Thread Huiwen Ren
r the default of five was? If you did I >might have missed it. (In particular, I'm wondering what happens if you run >it on a processor with fewer than five real threads.) Should be 0(auto) and fixed, thanks. > >> +{ "initial_qp" , "Quantization parameter" , >> OFFSET(initial_qp) , AV_OPT_TYPE_INT, {.i64 = 34 }, 1, 63, VE }, >> +{ "max_qp" , "max qp for rate control" , >> OFFSET(max_qp) , AV_OPT_TYPE_INT, {.i64 = 55 }, 0, 63, VE }, >> +{ "min_qp" , "min qp for rate control" , >> OFFSET(min_qp) , AV_OPT_TYPE_INT, {.i64 = 20 }, 0, 63, VE }, >> +{ "speed_level" , "Speed level, higher is better but slower", >> OFFSET(preset_level), AV_OPT_TYPE_INT, {.i64 = 0 }, 0, 9, VE }, >> +{ "hierarchical_ref", "hierarchical reference" , >> OFFSET(hierarchical_reference), AV_OPT_TYPE_BOOL,{.i64 = 1 }, 0, 1, >> VE }, >> +{ "xavs2-params", "set the xavs2 configuration using a >> :-separated list of key=value parameters", OFFSET(xavs2_opts), >> AV_OPT_TYPE_STRING, { 0 }, 0, 0, VE }, >> +{ NULL }, >> +}; >> + ... Also added log_level and qp, and moved min_qp/max_qp/initial_qp to the case with no bit_rate. Hope this version looks better :) Cheers, Huiwen Ren ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v6 1/2] lavc, doc, configure: add libxavs2 video encoder wrapper

2018-09-06 Thread Huiwen Ren
s. If "RateControl" is opened, the "initial_qp" will be used for the first frame and kept for all the other frames (constant-QP) and if there is no rate control, the initial_qp will only work for the first frame (xavs2 will always initial the qp for the first frame). So...maybe better with "initial"? Thanks, Huiwen Ren ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH v4 1/2] lavc, doc, configure: add libxavs2 video encoder wrapper

2018-09-05 Thread Huiwen Ren
At 2018-09-05 19:52:23, "Mark Thompson" wrote: >On 05/09/18 08:19, Huiwen Ren wrote: >> At 2018-09-05 08:46:18, "Mark Thompson" wrote: >>> On 03/09/18 03:42, hwren wrote: >>>> Signed-off-by: hwren >>>> --- >> [..

Re: [FFmpeg-devel] [PATCH v4 1/2] lavc, doc, configure: add libxavs2 video encoder wrapper

2018-09-05 Thread Huiwen Ren
; + >> +if (av_new_packet(pkt, cae->packet.len) < 0){ >> +av_log(avctx, AV_LOG_ERROR, "packet alloc failed\n"); >> +return AVERROR(EINVAL); > >ENOMEM. You probably need to unref the xavs2 pack

Re: [FFmpeg-devel] [PATCH] lavc/extract_extradata_bsf.c: add AVS2

2018-08-21 Thread Huiwen Ren
ping On 08/06/2018 21:42, hwren wrote: Signed-off-by: hwren --- libavcodec/extract_extradata_bsf.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavcodec/extract_extradata_bsf.c b/libavcodec/extract_extradata_bsf.c index 6deb663..f37427c 100644 --- a/libavcodec/extract_extradata_bsf.

Re: [FFmpeg-devel] [PATCH v2] lavf: add raw AVS2 demuxer

2018-08-21 Thread Huiwen Ren
file mode 100644 index 000..73daa69 --- /dev/null +++ b/libavformat/davs2.c @@ -0,0 +1,71 @@ +/* + * AVS2 video stream probe. + * + * Copyright (C) 2018 Huiwen Ren, + * + * This file is part of FFmpeg. + * + * FFmpeg is free software; you can redistribute it and/or + * modify it under the terms

Re: [FFmpeg-devel] [PATCH v3] avs2: Correct expression error and simplify log

2018-08-07 Thread Huiwen Ren
d follow the instructions for >> installing the library. Then pass @code{--enable-libdavs2} to configure to >> diff --git a/libavcodec/avs2_parser.c b/libavcodec/avs2_parser.c >> index 520e98a..1c9b342 100644 >> --- a/libavcodec/avs2_parser.c >> +++ b/libavcodec/avs2_parser.c &

Re: [FFmpeg-devel] [PATCH] avs2: Correct expression error and simplify log

2018-08-06 Thread Huiwen Ren
在 2018-08-07 02:09:34,"James Almer" 写道: >On 8/6/2018 11:21 AM, Gyan Doshi wrote: >> >> >> On 06-08-2018 07:13 PM, hwren wrote: >> >>> -    .long_name  = NULL_IF_CONFIG_SMALL("Decoder for AVS2/IEEE >>> 1857.4"), >>> +    .long_name  = NULL_IF_CONFIG_SMALL("Decoder for >>> AVS2-P2/IEEE18

Re: [FFmpeg-devel] [PATCH 2/2] fate: add decoder test for avs2

2018-07-31 Thread Huiwen Ren
The avs2 sample used in this patch could be temporary found in https://gitee.com/hwren/avs2_samples/blob/master/ES/BasketballPass_416x240_50_ai/test.avs2 please download test.avs2 and put it as fate-suite/avs2/test.avs2 At 2018-07-31 20:17:12, "hwren" wrote: >Signed-off-by: hwren >---