[FFmpeg-devel] [PATCH v3 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-21 Thread Jörg Krause
_XOPEN_SOURCE=600 to be defined. Signed-off-by: Jörg Krause --- Changes v2 -> v3: - set _XOPEN_SOURCE as default in case no C library can be detected Changes v1 -> v2: - do not set _XOPEN_SOURCE twice for glibc and uclibc --- configure | 3 +++ 1 file changed, 3 insertions(+) diff --git a/confi

Re: [FFmpeg-devel] [PATCH v2 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-20 Thread Jörg Krause
On 09/18/2014 07:10 PM, Reimar Döffinger wrote: On 18.09.2014, at 17:26, Michael Niedermayer wrote: On Thu, Sep 18, 2014 at 04:22:27PM +0200, Jörg Krause wrote: glibc, uclibc, and musl uses feature test macros to expose definitions conforming to the standards ISO C, POSIX and extensions

Re: [FFmpeg-devel] [PATCH v2 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-20 Thread Jörg Krause
On 09/19/2014 01:05 PM, Hendrik Leppkes wrote: On Thu, Sep 18, 2014 at 8:24 PM, Jörg Krause wrote: On 09/18/2014 07:10 PM, Reimar Döffinger wrote: On 18.09.2014, at 17:26, Michael Niedermayer wrote: On Thu, Sep 18, 2014 at 04:22:27PM +0200, Jörg Krause wrote: glibc, uclibc, and musl

Re: [FFmpeg-devel] [PATCH v2 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-18 Thread Jörg Krause
On 09/18/2014 07:10 PM, Reimar Döffinger wrote: On 18.09.2014, at 17:26, Michael Niedermayer wrote: On Thu, Sep 18, 2014 at 04:22:27PM +0200, Jörg Krause wrote: glibc, uclibc, and musl uses feature test macros to expose definitions conforming to the standards ISO C, POSIX and extensions

Re: [FFmpeg-devel] [PATCH v2 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-18 Thread Jörg Krause
On 09/18/2014 05:26 PM, Michael Niedermayer wrote: On Thu, Sep 18, 2014 at 04:22:27PM +0200, Jörg Krause wrote: glibc, uclibc, and musl uses feature test macros to expose definitions conforming to the standards ISO C, POSIX and extensions. According to which feature test macros are defined by

[FFmpeg-devel] [PATCH v2 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-18 Thread Jörg Krause
the header file, which is assumed to be specific to glibc, uclibc, and musl. Signed-off-by: Jörg Krause --- Changes v1 -> v2: - do not set _XOPEN_SOURCE twice for glibc and uclibc --- configure | 17 ++--- 1 file changed, 10 insertions(+), 7 deletions(-) diff --git a/configur

[FFmpeg-devel] [PATCH 1/1] configure: Refactor setting of feature test macro _XOPEN_SOURCE

2014-09-18 Thread Jörg Krause
the header file, which is assumed to be specific to glibc, uclibc, and musl. Signed-off-by: Jörg Krause --- configure | 5 + 1 file changed, 5 insertions(+) diff --git a/configure b/configure index 110a3fd..528e4fc 100755 --- a/configure +++ b/configure @@ -4182,6 +4182,11 @@ esac

[FFmpeg-devel] [PATCH 1/1] configure: fix check_cmd in check_host_cpp

2014-09-11 Thread Jörg Krause
Use correct cpp and c flags variables for the host libc. Signed-off-by: Jörg Krause --- configure | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/configure b/configure index e66519d..7a711a2 100755 --- a/configure +++ b/configure @@ -1244,7 +1244,7 @@ check_host_cpp

Re: [FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

2014-09-04 Thread Jörg Krause
On 09/04/2014 05:27 PM, Hendrik Leppkes wrote: On Wed, Sep 3, 2014 at 11:53 AM, Jörg Krause wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r

Re: [FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

2014-09-04 Thread Jörg Krause
On 09/04/2014 05:24 PM, wm4 wrote: On Thu, 04 Sep 2014 10:07:19 +0200 Jörg Krause wrote: On 09/03/2014 08:12 PM, Michael Niedermayer wrote: On Wed, Sep 03, 2014 at 11:53:39AM +0200, Jörg Krause wrote: Add the feature test macro which is required for building with the musl toolchain. The

Re: [FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

2014-09-04 Thread Jörg Krause
On 09/03/2014 08:12 PM, Michael Niedermayer wrote: On Wed, Sep 03, 2014 at 11:53:39AM +0200, Jörg Krause wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r

[FFmpeg-devel] [PATCH v2 1/4] libavutil/error: fix build with musl toolchain

2014-09-03 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r(). Signed-off-by: Jörg Krause --- Changes v1 -> v2: - fixed wrong macro name - add a comment --- libavu

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-03 Thread Jörg Krause
On 09/02/2014 11:49 PM, Reimar Döffinger wrote: On Tue, Sep 02, 2014 at 11:31:39PM +0200, Jörg Krause wrote: The maintainers of the musl C library states that looking for __GLIBC__ or __UCLIBC__ and making assumptions about the implemented feature set is not the best way. Instead should be

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-03 Thread Jörg Krause
On 09/02/2014 06:03 PM, wm4 wrote: On Tue, 2 Sep 2014 12:33:26 +0200 Jörg Krause wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r(). Signed-off-by: Jörg

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
On 09/02/2014 07:41 PM, Reimar Döffinger wrote: On Tue, Sep 02, 2014 at 05:03:56PM +0200, Michael Niedermayer wrote: On Tue, Sep 02, 2014 at 01:52:24PM +0200, Jörg Krause wrote: Am 02.09.2014 12:40 schrieb Michael Niedermayer: On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote

Re: [FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Am 02.09.2014 12:40 schrieb Michael Niedermayer: On Tue, Sep 02, 2014 at 12:33:26PM +0200, Jörg Krause wrote: Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r(). is

[FFmpeg-devel] [PATCH v2 3/4] libavutil/file: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: mkstemp(): _POSIX_C_SOURCE >= 200112L Signed-off-by: Jörg Krause --- Changes v1 -> v2: - Fixed commit message --- libavutil/file.c | 2 ++ 1 file changed, 2 inse

[FFmpeg-devel] [PATCH 4/4] libavutil/file_open: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: fdopen(): _POSIX_C_SOURCE >= 1 Signed-off-by: Jörg Krause --- libavutil/file_open.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/file_open.c b/libavu

[FFmpeg-devel] [PATCH 3/4] libavutil/file: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: fdopen(): _POSIX_C_SOURCE >= 1 Signed-off-by: Jörg Krause --- libavutil/file.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/file.c b/libavutil/file.c in

[FFmpeg-devel] [PATCH 2/4] libavutil/time: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The required feature test macro is: nanosleep(): _POSIX_C_SOURCE >= 199309L Signed-off-by: Jörg Krause --- libavutil/time.c | 2 ++ 1 file changed, 2 insertions(+) diff --git a/libavutil/time.c b/libavu

[FFmpeg-devel] [PATCH 1/4] libavutil/error: fix build with musl toolchain

2014-09-02 Thread Jörg Krause
Add the feature test macro which is required for building with the musl toolchain. The feature test macro _XOPEN_SOURCE = 600 provides the XSI-compliant version of strerror_r(). Signed-off-by: Jörg Krause --- libavutil/error.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavutil

Re: [FFmpeg-devel] ffmpeg and musl toolchain support

2014-09-02 Thread Jörg Krause
On 09/01/2014 04:59 PM, wm4 wrote: On Mon, 01 Sep 2014 16:14:52 +0200 Jörg Krause wrote: When building against musl instead of glibc, compilation fails at libavutil/error.c CC libavutil/error.o libavutil/error.c: In function 'av_strerror': libavutil/error.c:68:9: error: implicit d

[FFmpeg-devel] ffmpeg and musl toolchain support

2014-09-01 Thread Jörg Krause
When building against musl instead of glibc, compilation fails at libavutil/error.c CC libavutil/error.o libavutil/error.c: In function 'av_strerror': libavutil/error.c:68:9: error: implicit declaration of function 'strerror_r' [-Werror=implicit-function-declaration] cc1: some warnings being trea