Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/libopenmpt: Probe file format from file data if possible

On 03/20/2018 10:37 PM, Michael Niedermayer wrote: On Sun, Mar 18, 2018 at 09:10:47PM +, Josh de Kock wrote: On 2018/03/18 8:23, wm4 wrote: On Sun, 18 Mar 2018 08:44:12 +0100 Jörn Heusipp <osm...@problemloesungsmaschine.de> wrote: On 03/04/2018 08:55 AM, Jörn Heusipp wrote: On

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/libopenmpt: Probe file format from file data if possible

On 03/04/2018 08:55 AM, Jörn Heusipp wrote: On 02/21/2018 12:11 PM, Jörn Heusipp wrote:   libavformat/libopenmpt.c | 57   1 file changed, 57 insertions(+) Uhm, ping? So, my patches have been waiting without any further comment for more

Re: [FFmpeg-devel] [PATCH v4 2/2] avformat/libopenmpt: Probe file format from file data if possible

On 02/21/2018 12:11 PM, Jörn Heusipp wrote: libavformat/libopenmpt.c | 57 1 file changed, 57 insertions(+) Uhm, ping? Regards, Jörn ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http

[FFmpeg-devel] [PATCH v4 2/2] avformat/libopenmpt: Probe file format from file data if possible

in tools/probetest for all of its module formats combined (currently 41 modules formats in libopenmpt 0.3.4 and 234 file formats in FFmpeg). Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 57 1 file c

[FFmpeg-devel] [PATCH v4 1/2] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 30c3d6e..5efbdc4 100644 --- a/libavformat/libopenmpt.c +++ b/libav

Re: [FFmpeg-devel] [PATCH v3 4/4] avformat/libopenmpt: Probe file format from file data if possible

On 01/11/2018 09:11 AM, Jörn Heusipp wrote: Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 57 1 file changed, 57 insertions(+) Does anyone have any further comments on patches 3/4 a

[FFmpeg-devel] [PATCH v3 2/4] avformat/libopenmpt: Update to libopenmpt 0.3 API

is still supported. Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 2e22290..30c3d6e 100644 --- a/libav

[FFmpeg-devel] [PATCH v3 1/4] avformat/libopenmpt: Fix mixed code and declarations

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index af6eb1a..2e22290 100644 --- a/libavformat/libopenmpt.c

[FFmpeg-devel] [PATCH v3 3/4] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 30c3d6e..5efbdc4 100644 --- a/libavformat/libopenmpt.c +++ b/libav

[FFmpeg-devel] [PATCH v3 4/4] avformat/libopenmpt: Probe file format from file data if possible

in tools/probetest for all of its module formats combined (currently 41 modules formats in libopenmpt 0.3.4 and 234 file formats in FFmpeg). Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 57 1 file c

Re: [FFmpeg-devel] [PATCH v2 4/4] avformat/libopenmpt: Probe file format from file data if possible

On 01/10/2018 12:55 PM, Carl Eugen Hoyos wrote: 2018-01-10 12:18 GMT+01:00 Jörn Heusipp <osm...@problemloesungsmaschine.de>: When building with libopenmpt 0.3, use the libopenmpt file header probing functions for probing. libopenmpt probing functions are allocation-free and de

[FFmpeg-devel] [PATCH v2 2/4] avformat/libopenmpt: Update to libopenmpt 0.3 API

is still supported. Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 2e22290..30c3d6e 100644 --- a/libav

[FFmpeg-devel] [PATCH v2 3/4] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 30c3d6e..5efbdc4 100644 --- a/libavformat/libopenmpt.c +++ b/libav

[FFmpeg-devel] [PATCH v2 4/4] avformat/libopenmpt: Probe file format from file data if possible

in tools/probetest for all of its module formats combined (currently 41 modules formats in libopenmpt 0.3.4 and 234 file formats in FFmpeg). Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 57 1 file c

[FFmpeg-devel] [PATCH v2 0/4] libopenmpt 0.3 updates

re real-world examples of going through av_probe_input_format() on all files in FATE show an even smaller relative increase: 11043671 / 10846094 - 1 = 0.018 ~= 2%. Note that in actual use, the to be probed data will likely not be in page cache. Jörn Heusipp (4): avformat/libopenmpt: Fix mix

[FFmpeg-devel] [PATCH v2 1/4] avformat/libopenmpt: Fix mixed code and declarations

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index af6eb1a..2e22290 100644 --- a/libavformat/libopenmpt.c

Re: [FFmpeg-devel] [PATCH 4/4] avformat/libopenmpt: Probe file format from file data if possible

On 01/08/2018 12:57 AM, Carl Eugen Hoyos wrote: 2018-01-07 15:40 GMT+01:00 Jörn Heusipp <osm...@problemloesungsmaschine.de>: On 01/06/2018 04:10 PM, Carl Eugen Hoyos wrote: 2018-01-06 11:07 GMT+01:00 Jörn Heusipp <osm...@problemloesungsmaschine.de>: libopenmpt file he

Re: [FFmpeg-devel] [PATCH 3/4] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

On 01/08/2018 12:48 AM, Carl Eugen Hoyos wrote: 2018-01-07 15:40 GMT+01:00 Jörn Heusipp <osm...@problemloesungsmaschine.de>: On 01/06/2018 04:06 PM, Carl Eugen Hoyos wrote: 2018-01-06 11:07 GMT+01:00 Jörn Heusipp <osm...@problemloesungsmaschine.de>: -.extensions = &quo

Re: [FFmpeg-devel] [PATCH 4/4] avformat/libopenmpt: Probe file format from file data if possible

On 01/06/2018 04:10 PM, Carl Eugen Hoyos wrote: 2018-01-06 11:07 GMT+01:00 Jörn Heusipp <osm...@problemloesungsmaschine.de>: libopenmpt file header probing is tested regularly against the FATE suite and other diverse file collections by libopenmpt upstream in order to avoid false pos

Re: [FFmpeg-devel] [PATCH 3/4] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

On 01/06/2018 04:06 PM, Carl Eugen Hoyos wrote: 2018-01-06 11:07 GMT+01:00 Jörn Heusipp <osm...@problemloesungsmaschine.de>: Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-)

[FFmpeg-devel] [PATCH 4/4] avformat/libopenmpt: Probe file format from file data if possible

lename = argv[i]; memset(buf, 0, sizeof(buf)); f = fopen(pd.filename, "rb"); size = fread(buf, 1, BUFSIZE, f); fclose(f); pd.buf_size = size; av_probe_input_format(, 1); } return 0; } Signed-of

[FFmpeg-devel] [PATCH 2/4] avformat/libopenmpt: Update to libopenmpt 0.3 API

is still supported. Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 25 + 1 file changed, 25 insertions(+) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 2e22290..30c3d6e 100644 --- a/libav

[FFmpeg-devel] [PATCH 3/4] avformat/libopenmpt: Update file extensions list for libopenmpt 0.3

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 30c3d6e..5efbdc4 100644 --- a/libavformat/libopenmpt.c +++ b/libav

[FFmpeg-devel] [PATCH 1/4] avformat/libopenmpt: Fix mixed code and declarations

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 11 ++- 1 file changed, 6 insertions(+), 5 deletions(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index af6eb1a..2e22290 100644 --- a/libavformat/libopenmpt.c

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

On 10/16/2017 11:38 PM, Hendrik Leppkes wrote: On Mon, Oct 16, 2017 at 11:02 PM, James Almer <jamr...@gmail.com> wrote: The remaining issue after this patchset is applied is linking to the C++ standard library with some external deps. According to Jörn Heusipp, the libopenmpt main

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

On 10/17/2017 03:04 AM, Carl Eugen Hoyos wrote: 2017-10-16 23:02 GMT+02:00 James Almer : and by hardcoding a -lstdc++ ldflag in configure checks we're apparently breaking detection on systems where the compiler uses libc++, like it seems to be the case with Clang on MacOS.

Re: [FFmpeg-devel] [PATCH] configure: add libm ldflags globally

On 10/17/2017 12:13 AM, Jan Ekstrom wrote: On Tue, Oct 17, 2017 at 12:38 AM, Hendrik Leppkes wrote: Perhaps such libraries shouldn't hardcode -lstdc++ in there, but dynamically put whichever C++ library they built against in there instead? Its not like you can actually

Re: [FFmpeg-devel] [PATCH] avformat/libopenmpt: Query duration and metadata after selecting subsong

On 09/17/2017 03:35 PM, Jörn Heusipp wrote: Duration depends on the selected subsong and thus must be queried after selecting the subsong. There is no compelling reason to query other metadata earlier either. Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> ---

[FFmpeg-devel] [PATCH] avformat/libopenmpt: Query duration and metadata after selecting subsong

Duration depends on the selected subsong and thus must be queried after selecting the subsong. There is no compelling reason to query other metadata earlier either. Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 17 + 1 file c

Re: [FFmpeg-devel] FFmpeg 3.3

On 01/23/2017 02:11 AM, Michael Niedermayer wrote: I also intend to make some new point releases from the currently maintained branches if someone wants to backport something https://git.ffmpeg.org/gitweb/ffmpeg.git/commit/367cac7827870054ae3bd6d4517e7b13f4f3f72c needs to be applied to the

Re: [FFmpeg-devel] [PATCH] libopenmpt: add missing avio_read return value check

On 01/09/2017 08:20 PM, Jörn Heusipp wrote: On 01/01/2017 08:27 PM, Andreas Cadhalpun wrote: This fixes heap-buffer-overflows in libopenmpt caused by interpreting the negative size value as unsigned size_t. Signed-off-by: Andreas Cadhalpun <andreas.cadhal...@googlemail.com> --- libav

Re: [FFmpeg-devel] [PATCH] libopenmpt: add missing avio_read return value check

On 01/01/2017 08:27 PM, Andreas Cadhalpun wrote: This fixes heap-buffer-overflows in libopenmpt caused by interpreting the negative size value as unsigned size_t. Signed-off-by: Andreas Cadhalpun --- libavformat/libopenmpt.c | 5 + 1 file changed, 5

Re: [FFmpeg-devel] [PATCH 2/3 v3] libopenmpt: add subsong support

On 07/19/2016 11:33 PM, Josh de Kock wrote: --- libavformat/libopenmpt.c | 26 +++--- 1 file changed, 23 insertions(+), 3 deletions(-) +{ "subsong", "set subsong",OFFSET(subsong), AV_OPT_TYPE_INT,{ .i64 = -2 }, -2, INT_MAX, A | D,

Re: [FFmpeg-devel] [PATCH] libopenmpt: add subsong support

On 07/18/2016 02:59 PM, Josh de Kock wrote: libavformat/libopenmpt.c | 8 1 file changed, 8 insertions(+) +{"subsong", "set subsong",OFFSET(subsong), AV_OPT_TYPE_INT,{.i64 = 0}, 0, 1000, A|D}, 1. -1 is a valid

[FFmpeg-devel] [PATCH 2/3] libavformat/libopenmpt: Actually set stream duration and fix the confusion around the used time base.

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 58a02be..7b1dd5b 100644 --- a/libavformat/libopenmpt.c +++ b/libav

[FFmpeg-devel] [PATCH 1/3] libavformat/libopenmpt: Fix memory leak in error path in read_header_openmpt().

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index fd38828..58a02be 100644 --- a/libavformat/libopenmpt.c +++ b/libav

[FFmpeg-devel] [PATCH 3/3] libavformat/libopenmpt: Add "date" to metadata.

Signed-off-by: Jörn Heusipp <osm...@problemloesungsmaschine.de> --- libavformat/libopenmpt.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/libopenmpt.c b/libavformat/libopenmpt.c index 7b1dd5b..997c13d 100644 --- a/libavformat/libopenmpt.c +++ b/libavformat/libopenmpt.c @@

Re: [FFmpeg-devel] [PATCH 2/2] avformat/libmodplug: Remove code that has become redundant

On 07/16/2016 03:49 PM, Josh de Kock wrote: On Sat, Jul 16, 2016, at 02:31 PM, Jörn Heusipp wrote: [...] Unless one of libopenmpt and libmodplug demuxers lowers its own file extension probing score, this will not work, as they both handle pretty much the same file formats. This could

Re: [FFmpeg-devel] [PATCHv4] lavf: add libopenmpt demuxer

On 06/30/2016 02:49 AM, Josh de Kock wrote: Fixes ticket #5623 TODO: bump lavf minor --- I looked more thoroughly at your patch again. I'm commenting from libopenmpt perspective of course. +openmpt->module = openmpt_module_create_from_memory(buf, size, openmpt_logfunc, s, NULL); +

Re: [FFmpeg-devel] [PATCHv4] lavf: add libopenmpt demuxer

On 07/08/2016 10:17 PM, Nicolas George wrote: Le primidi 21 messidor, an CCXXIV, Jörn Heusipp a écrit : Regarding AVProbeData: Looking at AVProbeData, I can see no (optional) field describing the file size: typedef struct AVProbeData { const char *filename; unsigned char *buf

Re: [FFmpeg-devel] [PATCHv4] lavf: add libopenmpt demuxer

Hello! On 06/30/2016 02:49 AM, Josh de Kock wrote: Fixes ticket #5623 TODO: bump lavf minor (I am one of the libopenmpt maintainers) We have been following the ffmpeg libopenmpt demuxer patches and we already gave feedback at https://bugs.openmpt.org/view.php?id=817 (for reference). I'm