Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: sync avctx w/ codecpar

2019-06-25 Thread James Almer
On 6/25/2019 1:44 PM, Chris Cunningham wrote: > Friendly ping. > > On Thu, Jun 20, 2019 at 11:17 AM Chris Cunningham > wrote: > >> On Thu, Feb 28, 2019 at 9:13 AM James Almer wrote: >> >>> On 2/26/2019 10:18 PM, Chris Cunningham wrote: >>>>

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/hevc_ps: Change num_tile_rows/columns checks to sps->ctb_height/weight

2019-06-25 Thread James Almer
On 6/25/2019 5:55 AM, Michael Niedermayer wrote: > Suggested-by: James Almer > > Signed-off-by: Michael Niedermayer > --- > libavcodec/hevc_ps.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/libavcodec/hevc_ps.c b/libavcodec/hevc

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-25 Thread James Almer
On 6/25/2019 10:30 AM, James Almer wrote: > On 6/25/2019 5:55 AM, Michael Niedermayer wrote: >> +num_tile_columns_minus1 >= sps->width - 1) { > > Should be sps->ctb_width > > From 7.4.3.3.1: > > "num_tile_columns_minus1 plus 1 specifies

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/hevc_ps: Fix integer overflow with num_tile_rows and num_tile_columns

2019-06-25 Thread James Almer
On 6/25/2019 5:55 AM, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type > 'int' > Fixes: > 14880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5130977304641536 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] movsub_bsf: Fix mov2textsub regression

2019-06-24 Thread James Almer
On 6/23/2019 10:26 PM, Philip Langdale wrote: > On Sun, 23 Jun 2019 06:46:12 +0200 > Andreas Rheinhardt wrote: > >> The mov flavour of timed text uses the first two bytes of the packet >> as a length field. And up until 11bef2fe said length field has been >> read correctly in the mov2textsub

Re: [FFmpeg-devel] [PATCH 12/13] avformat/matroskadec: Improve read error/EOF checks II

2019-06-24 Thread James Almer
On 6/23/2019 8:42 PM, Andreas Rheinhardt wrote: > This commit fixes a number of bugs: > > 1. There was no check that no read error/EOF occured during > ebml_read_uint, ebml_read_sint and ebml_read_float. > 2. ebml_read_ascii and ebml_read_binary did sometimes not forward > error codes; instead

Re: [FFmpeg-devel] [PATCH 13/13] avformat/matroskadec: Improve error/EOF checks III

2019-06-24 Thread James Almer
On 6/23/2019 8:42 PM, Andreas Rheinhardt wrote: > Up until now, when an element was skipped, it was relied upon > ffio_limit to make sure that there is enough data available to skip. > ffio_limit itself relies upon the availability of the file's size. As > this needn't be available, the check has

Re: [FFmpeg-devel] [PATCH 16/37] avformat/matroskadec: Treat SimpleBlock as EBML_BIN

2019-06-24 Thread James Almer
On 5/16/2019 7:30 PM, Andreas Rheinhardt wrote: > Up until now, the SimpleBlock was treated specially: It basically had > its own EBML category and it was also included in the BlockGroup EBML > syntax (although a SimpleBlock must not exist in a BlockGroup according > to the Matroska

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: Improve read error/EOF checks I

2019-06-24 Thread James Almer
On 6/24/2019 10:08 PM, Andreas Rheinhardt wrote: > ebml_read_num had a number of flaws: > > 1. The check for read errors/EOF was totally wrong. E.g. an EBML number > beginning with the invalid 0x00 would be considered a read error, > although it is just invalid data. > 2. The check for read

Re: [FFmpeg-devel] [PATCH 11/13] avformat/matroskadec: Improve read error/EOF checks I

2019-06-24 Thread James Almer
On 6/23/2019 8:42 PM, Andreas Rheinhardt wrote: > ebml_read_num had a number of flaws: > > 1. The check for read errors/EOF was totally wrong. E.g. an EBML number > beginning with the invalid 0x00 would be considered a read error, > although it is just invalid data. > 2. The check for read

Re: [FFmpeg-devel] [PATCH 04/37] avformat/matroskadec: Don't zero unnecessarily

2019-06-24 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > It is only necessary to zero the initial allocated memory used to store > the size of laced frames if the block used Xiph lacing. Otherwise no > unintialized data was ever used, so use av_malloc instead of av_mallocz. > > Also use the correct type

Re: [FFmpeg-devel] [PATCH 11/37] avformat/matroskadec: Improve read error/EOF checks I

2019-06-23 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > ebml_read_num had a number of flaws: > > 1. The check for read errors/EOF was totally wrong. E.g. an EBML number > beginning with the invalid 0x00 would be considered a read error, > although it is just invalid data. > 2. The check for read

Re: [FFmpeg-devel] [PATCH 12/37] avformat/matroskadec: Improve read error/EOF checks II

2019-06-23 Thread James Almer
On 6/23/2019 1:01 PM, Andreas Rheinhardt wrote: > James Almer: >> On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: >>> This commit fixes a number of bugs: >>> >>> 1. There was no check that no read error/EOF occured during >>> ebml_read_ui

Re: [FFmpeg-devel] [PATCH 12/37] avformat/matroskadec: Improve read error/EOF checks II

2019-06-23 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > This commit fixes a number of bugs: > > 1. There was no check that no read error/EOF occured during > ebml_read_uint, ebml_read_sint and ebml_read_float. > 2. ebml_read_ascii and ebml_read_binary did sometimes not forward > error codes; instead

Re: [FFmpeg-devel] [PATCH 05/37] avformat/matroskadec: Get rid of cluster size field assumption

2019-06-23 Thread James Almer
On 6/23/2019 1:28 AM, Andreas Rheinhardt wrote: > James Almer: >> On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: >>> The earlier code relied on the length of clusters always being coded on >>> eight bytes as was the behaviour of libavformat's Matroska muxer until >&

Re: [FFmpeg-devel] [PATCH 09/37] avformat/matroskadec: Remove redundant initialization

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > Every new element of an EbmlList is zeroed initially in > ebml_parse_elem, so that in particular a SimpleBlock's duration is > initialized to zero. Therefore it is unnecessary to initialize this > field again (for SimpleBlocks) in

Re: [FFmpeg-devel] [PATCH 15/37] avformat/matroskadec: Don't keep old blocks

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > Before this commit, the Matroska muxer would read a block when required > to do so, parse the block, create and return the necessary AVPackets and > yet keep the blocks (in a dynamically allocated list), although they > aren't used at all any more.

Re: [FFmpeg-devel] [PATCH 05/37] avformat/matroskadec: Get rid of cluster size field assumption

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > The earlier code relied on the length of clusters always being coded on > eight bytes as was the behaviour of libavformat's Matroska muxer until > recently. But given that our own Matroska muxer now (and mkvmerge from > time immemorial) creates

Re: [FFmpeg-devel] [PATCH 07/37] avformat/matroskadec: Set offset of first cluster

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > By default, the data_offset member of the AVFormatInternal of the > AVFormatContext associated with the MatroskaDemuxContext has not been > initialized explicitly by any Matroska-specific function, so that it was > initialized by default to the

Re: [FFmpeg-devel] [PATCH 14/37] avformat/matroskadec: Remove non-incremental parsing of clusters

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > When the new incremental parser was introduced, the old parser was > kept, because the new parser was unable to handle the way SSA packets > are put into Matroska. But since 2014 (since c7d8dbad) this is no > longer needed, so that the old parser

Re: [FFmpeg-devel] [PATCH 06/37] avformat/matroskadec: Use generic size check for signed integers

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > and drop the redundant checks contained in ebml_read_uint and > ebml_read_sint. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskadec.c | 7 +-- > 1 file changed, 1 insertion(+), 6 deletions(-) > > diff --git

Re: [FFmpeg-devel] [PATCH 08/37] avformat/matroskadec: Don't copy attached pictures

2019-06-22 Thread James Almer
On 5/16/2019 7:29 PM, Andreas Rheinhardt wrote: > This commit replaces copying attached pictures by using references to > the already existing buffers. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/matroskadec.c | 16 ++-- > 1 file changed, 10 insertions(+), 6

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-06-22 Thread James Almer
I'd rather not change h2645_parse for this and risk unpredictable behavior from the decoder. > > James Almer: >> As defined in section F.14.2.8 and F.14.3.8 >> >> Signed-off-by: James Almer >> --- >> https://trac.ffmpeg.org/attachment/ticket/7965/

Re: [FFmpeg-devel] [PATCH v3] ffprobe: Fix memory leak

2019-06-21 Thread James Almer
On 6/21/2019 11:41 AM, Derek Buitenhuis wrote: > This packet was not necessarily unreferenced. > > Signed-off-by: Derek Buitenhuis > --- > fftools/ffprobe.c | 4 +--- > 1 file changed, 1 insertion(+), 3 deletions(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index

Re: [FFmpeg-devel] [PATCH v2] ffprobe: Fix memory leak

2019-06-21 Thread James Almer
On 6/21/2019 11:39 AM, Derek Buitenhuis wrote: > On 21/06/2019 15:26, James Almer wrote: >> Remove the three lines below as well before pushing. They are >> superfluous as av_packet_unref() does the same internally. > > OK. > > The documentation for av_packet_unref

Re: [FFmpeg-devel] [PATCH v2] ffprobe: Fix memory leak

2019-06-21 Thread James Almer
On 6/21/2019 11:15 AM, Derek Buitenhuis wrote: > This packet was not necessarily unreferenced. > > Signed-off-by: Derek Buitenhuis > --- > fftools/ffprobe.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index 3becb6330e..dac70ba5a1 100644 >

Re: [FFmpeg-devel] [PATCH] ffprobe: Fix memory leak

2019-06-21 Thread James Almer
On 6/21/2019 11:13 AM, Derek Buitenhuis wrote: > On 21/06/2019 14:46, James Almer wrote: >> Why not just call this unconditionally instead of the init() + zero below? > > I wasn't sure from a quick skim if these packets were > referenced elsewhere (and thus unref

Re: [FFmpeg-devel] [PATCH] ffprobe: Fix memory leak

2019-06-21 Thread James Almer
On 6/21/2019 10:36 AM, Derek Buitenhuis wrote: > This packet was not necessarily unreferenced. > > Signed-off-by: Derek Buitenhuis > --- > fftools/ffprobe.c | 10 +- > 1 file changed, 9 insertions(+), 1 deletion(-) > > diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c > index

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h265: fix valid range of num_tile_{columns, rows}_minus1 in H265RawPPS

2019-06-21 Thread James Almer
On 6/21/2019 1:24 AM, Gyan wrote: > > > On 20-06-2019 11:15 PM, James Almer wrote: >> The spec states they can't be higher than the respective dimensions of >> the >> stream in CTBs. >> >> Signed-off-by: James Almer >> --- >> I don't think

[FFmpeg-devel] [PATCH] avcodec/cbs_h265: add support for Alpha Channel Info SEI messages

2019-06-20 Thread James Almer
As defined in section F.14.2.8 and F.14.3.8 Signed-off-by: James Almer --- https://trac.ffmpeg.org/attachment/ticket/7965/puppets_with_alpha_hevc.mov libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h265.h | 12 + libavcodec/cbs_h265_syntax_template.c | 37

Re: [FFmpeg-devel] [PATCH] libavcodec: Reduce the size of some arrays

2019-06-20 Thread James Almer
On 6/19/2019 4:08 PM, Michael Niedermayer wrote: > On Wed, Jun 19, 2019 at 04:39:47AM +0200, Andreas Rheinhardt wrote: >> This commit uses smaller types for some static const arrays to reduce >> their size in case the entries can be represented in the smaller type. >> The biggest savings came from

[FFmpeg-devel] [PATCH 1/2] avcodec/cbs_h265: fix valid range of num_tile_{columns, rows}_minus1 in H265RawPPS

2019-06-20 Thread James Almer
The spec states they can't be higher than the respective dimensions of the stream in CTBs. Signed-off-by: James Almer --- I don't think it's wise further limiting the range to the maximum currently defined for level 6.2 using those two HEVC_ defines, since a stream could in theory go beyond them

[FFmpeg-devel] [PATCH 2/2] avcodec/cbs_h265: fix valid range of column_{width, height}_minus1 in H265RawPPS

2019-06-20 Thread James Almer
The spec states they are in units of CTBs. Signed-off-by: James Almer --- libavcodec/cbs_h265_syntax_template.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavcodec/cbs_h265_syntax_template.c b/libavcodec/cbs_h265_syntax_template.c index d2a20ddb35..571c9d3544

Re: [FFmpeg-devel] [PATCH v4 1/5] lavc/h265_profile_level: Fix DPB size calculation

2019-06-20 Thread James Almer
On 6/2/2019 1:48 PM, Mark Thompson wrote: > On 06/05/2019 22:02, Mark Thompson wrote: >> The maxDpbPicBuf value which is used in the DPB size calculation depends >> on the profile (it's usually 6, but 7 for screen-extended profiles). >> --- >> libavcodec/h265_profile_level.c | 86

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-19 Thread James Almer
On 6/19/2019 3:59 PM, James Almer wrote: > On 6/19/2019 3:13 PM, Michael Niedermayer wrote: >> On Wed, Jun 19, 2019 at 12:54:25PM -0300, James Almer wrote: >>> On 6/19/2019 6:22 AM, Michael Niedermayer wrote: >>>> On Mon, Jun 17, 2019 at 07:55:45PM -0300, James Almer

Re: [FFmpeg-devel] [PATCH] avformat/oggdec: only parse headers before data

2019-06-19 Thread James Almer
On 6/19/2019 11:11 PM, Chris Cunningham wrote: > On Wed, Jun 19, 2019 at 11:25 AM Michael Niedermayer > wrote: > > breaks: > ./ffmpeg -i bgc.sub.dub.ogm -vframes 3 -y test.webm > sample: http://samples.mplayerhq.hu/ogg/bgc.sub.dub.ogm > > [...] > > -- > Michael     

Re: [FFmpeg-devel] [FFmpeg-cvslog] av_format/hlsenc: fix %v handling by format_name function

2019-06-19 Thread James Almer
On 6/19/2019 3:19 PM, Bodecs Bela wrote: > > 2019.06.19. 19:37 keltezéssel, Michael Niedermayer írta: >> On Wed, Jun 19, 2019 at 10:03:51AM +, Bodecs Bela wrote: >>> ffmpeg | branch: master | Bodecs Bela | Mon Jun >>> 17 23:05:21 2019 +0200| [09a4853930e7950f423e9161004871afe659ed84] | >>>

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-19 Thread James Almer
On 6/19/2019 3:13 PM, Michael Niedermayer wrote: > On Wed, Jun 19, 2019 at 12:54:25PM -0300, James Almer wrote: >> On 6/19/2019 6:22 AM, Michael Niedermayer wrote: >>> On Mon, Jun 17, 2019 at 07:55:45PM -0300, James Almer wrote: >>>> On 6/17/2019 6:54 PM, Michael N

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-19 Thread James Almer
On 6/19/2019 6:22 AM, Michael Niedermayer wrote: > On Mon, Jun 17, 2019 at 07:55:45PM -0300, James Almer wrote: >> On 6/17/2019 6:54 PM, Michael Niedermayer wrote: >>> On Sun, Jun 16, 2019 at 11:10:43PM -0300, James Almer wrote: >>>> On 6/13/2019 3:32 PM, Michael

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-17 Thread James Almer
On 6/17/2019 6:54 PM, Michael Niedermayer wrote: > On Sun, Jun 16, 2019 at 11:10:43PM -0300, James Almer wrote: >> On 6/13/2019 3:32 PM, Michael Niedermayer wrote: >>> Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in >>> type 'int' >&g

Re: [FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-17 Thread James Almer
On 6/17/2019 11:34 AM, Andreas Rheinhardt wrote: > James Almer: >> On 6/17/2019 9:44 AM, James Almer wrote: >>> On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: >>>> Up until now, ff_cbs_write_packet always initialized the packet >>>> structure it r

Re: [FFmpeg-devel] [PATCH 11/18] cbs_h264, h264_metadata: Deleting SEI messages never fails

2019-06-17 Thread James Almer
On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: > Deleting a unit from a fragment in CBS only fails if there is no unit > in the fragment corresponding to the position given as argument to > ff_cbs_delete_unit. Given that ff_cbs_h264_delete_sei_message asserts > this to be so, we know that the

Re: [FFmpeg-devel] [PATCH 10/18] cbs: Remove superfluous checks for ff_cbs_delete_unit

2019-06-17 Thread James Almer
On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: > ff_cbs_delete_unit never fails if the index of the unit to delete is > valid; document this behaviour explicitly and remove the checks for > whether ff_cbs_delete_unit failed, because all the callers of > ff_cbs_delete_unit already make sure that

Re: [FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-17 Thread James Almer
On 6/17/2019 9:44 AM, James Almer wrote: > On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: >> Up until now, ff_cbs_write_packet always initialized the packet >> structure it received without documenting this behaviour; furthermore, >> the packet's buffer would (on su

Re: [FFmpeg-devel] [PATCH 01/18] cbs: Allow non-blank packets in ff_cbs_write_packet

2019-06-17 Thread James Almer
On 6/17/2019 12:42 AM, Andreas Rheinhardt wrote: > Up until now, ff_cbs_write_packet always initialized the packet > structure it received without documenting this behaviour; furthermore, > the packet's buffer would (on success) be overwritten with the new > buffer without unreferencing the old.

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/hevc_ps: Fix integer overflow with num_tile_rows

2019-06-16 Thread James Almer
On 6/13/2019 3:32 PM, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2147483648 - 1 cannot be represented in type > 'int' > Fixes: > 14880/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5130977304641536 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/bink: Reorder operations in init to avoid memleak on error

2019-06-16 Thread James Almer
On 6/15/2019 7:00 PM, Michael Niedermayer wrote: > Fixes: Direct leak of 536 byte(s) in 1 object(s) > Fixes: > 15266/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_BINK_fuzzer-5629530426834944 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH] avformat/oggparseogm: unknown codec triggers error

2019-06-14 Thread James Almer
On 6/14/2019 11:52 AM, Reimar Döffinger wrote: > > > On 14.06.2019, at 03:15, Chris Cunningham wrote: > >> Only "succeed" to read a header if the codec is valid. Otherwise >> return AVERROR_INVALIDDATA. > > That doesn't sound right to me, an unknown codec in (possibly) a single > stream is

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread James Almer
_INVALID_BITSTREAM, FF_DECODE_ERROR_MISSING_REFERENCE, or both, since as you mentioned they describe the errors that could take place in ff_h264_execute_decode_slices() just fine. > > Thanks > > > On Sun, Jun 9, 2019 at 10:15 PM James Almer wrote: > >> On 6/10/2019 12

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-09 Thread James Almer
On 6/10/2019 12:03 AM, Amir Pauker wrote: > set AVFrame decode_error_flags in case h->slice_ctx->er.error_occurred is set > after the call to ff_h264_execute_decode_slices. This allows the user to > detect > concealed decoding errors in the call to avcodec_receive_frame > > Signed-off-by: Amir

Re: [FFmpeg-devel] [PATCH] avformat/id3v2enc: write CTOC too

2019-06-04 Thread James Almer
On 6/4/2019 11:45 AM, Paul B Mahol wrote: > Signed-off-by: Paul B Mahol > --- > libavformat/id3v2enc.c | 36 > 1 file changed, 36 insertions(+) > > diff --git a/libavformat/id3v2enc.c b/libavformat/id3v2enc.c > index ffe358f019..9b72614447 100644 > ---

Re: [FFmpeg-devel] [PATCH] avcodec/cbs_h264: add support for Alternative Transfer Characteristics SEI message

2019-06-03 Thread James Almer
On 6/2/2019 1:38 PM, Mark Thompson wrote: > On 26/05/2019 19:40, James Almer wrote: >> Signed-off-by: James Almer >> --- >> libavcodec/cbs_h264.h | 6 ++ >> libavcodec/cbs_h2645.c| 1 + >> libavcodec/cbs_h264_syntax_templa

Re: [FFmpeg-devel] [PATCH v1 1/1] vaapi_encode: replace av_new_packet with ff_alloc_packet2

2019-06-03 Thread James Almer
On 6/3/2019 3:39 AM, Sun, Jing A wrote: > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > James Almer > Sent: Saturday, June 1, 2019 3:06 AM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v1 1/1] vaa

Re: [FFmpeg-devel] [PATCH v1 1/1] vaapi_encode: replace av_new_packet with ff_alloc_packet2

2019-05-31 Thread James Almer
On 5/31/2019 5:26 AM, Jing Sun wrote: > ff_alloc_packet2 should be used if encode2 API vaapi_encode seems to be using send/receive API, though, and not encode2. I see ff_vaapi_encode_receive_packet() -> vaapi_encode_output(), and the former is the callback function used in all vaapi encoders as

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread James Almer
On 5/31/2019 12:50 AM, Jing Sun wrote: > Signed-off-by: Zhengxu Huang > Signed-off-by: Hassene Tmar > Signed-off-by: Jun Zhao > Signed-off-by: Jing Sun > --- > configure| 4 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/libsvt_hevc.c

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread James Almer
On 5/30/2019 11:16 PM, Sun, Jing A wrote: > -Original Message- > From: ffmpeg-devel [mailto:ffmpeg-devel-boun...@ffmpeg.org] On Behalf Of > James Almer > Sent: Thursday, May 30, 2019 11:35 PM > To: ffmpeg-devel@ffmpeg.org > Subject: Re: [FFmpeg-devel] [PATCH v13 1/2]

Re: [FFmpeg-devel] [PATCH] avutil/dynarry.h: fix comment grammar mistakes of FF_DYNARRAY_ADD

2019-05-30 Thread James Almer
On 5/30/2019 11:29 AM, Steven Liu wrote: > Signed-off-by: Steven Liu > --- > libavutil/dynarray.h | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/dynarray.h b/libavutil/dynarray.h > index 034a9fedfe..3a7e146422 100644 > --- a/libavutil/dynarray.h > +++

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/30/2019 1:37 PM, Derek Buitenhuis wrote: > On 30/05/2019 17:27, James Almer wrote: >> All three options are important to get decent and/or fast encodings, so >> if you'd rather not add options for them, you should document what >> key=value combinations can be passed to

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/30/2019 1:15 PM, Derek Buitenhuis wrote: > On 30/05/2019 15:51, James Almer wrote: >> You could add tile-columns, tile-rows, and speed options. > > I'm of two minds here. > > One one hand, it is convenient. > > On the other hand, you may end up with a crappy pil

Re: [FFmpeg-devel] [PATCH v13 1/2] lavc/svt_hevc: add libsvt hevc encoder wrapper

2019-05-30 Thread James Almer
On 5/30/2019 8:04 AM, Jing Sun wrote: > Signed-off-by: Zhengxu Huang > Signed-off-by: Hassene Tmar > Signed-off-by: Jun Zhao > Signed-off-by: Jing Sun > --- > configure| 4 + > libavcodec/Makefile | 1 + > libavcodec/allcodecs.c | 1 + > libavcodec/libsvt_hevc.c |

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-30 Thread James Almer
On 5/29/2019 3:28 PM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > Changes since v2: > > * Removed 4:0:0 support; seems broken in rav1e (ref:

Re: [FFmpeg-devel] [PATCH v3] avcodec: Add librav1e encoder

2019-05-29 Thread James Almer
On 5/29/2019 3:28 PM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > Changes since v2: > > * Removed 4:0:0 support; seems broken in rav1e (ref:

Re: [FFmpeg-devel] [PATCH v2] avcodec: Add librav1e encoder

2019-05-29 Thread James Almer
On 5/29/2019 11:41 AM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Port to the new send/receive API by: James Almer . > > Signed-off-by: Derek Buitenhuis > --- > The only thing I didn't address from the last set of replies was the > second 'ret'

Re: [FFmpeg-devel] [PATCH] avcodec/h264_slice: set the SEI parameters early on the AVCodecContext

2019-05-29 Thread James Almer
On 5/29/2019 10:16 AM, Steve Lhomme wrote: > It's better to do it before the buffers are actually created. At least in VLC > we currently don't support changing some parameters dynamically easily so we > don't use the information if it comes after the buffer are created. > > Co-aut

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread James Almer
On 5/28/2019 4:49 PM, Derek Buitenhuis wrote: > On 28/05/2019 20:32, James Almer wrote: >>> +default: >>> +// This should be impossible >>> +return (RaChromaSampling) -1; >> >> If it's not meant to happen, then it should probably be

Re: [FFmpeg-devel] [PATCH] avcodec: Add librav1e encoder

2019-05-28 Thread James Almer
On 5/28/2019 2:29 PM, Derek Buitenhuis wrote: > Uses the crav1e C bindings for rav1e. > > Missing version bump and changelog entry. > > Signed-off-by: Derek Buitenhuis > --- > Hoping to get some eyes on this, and maybe help some people who want to > test out rav1e without having to use Y4Ms or

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: add master display and light level sei for HDR10

2019-05-27 Thread James Almer
On 5/27/2019 7:13 PM, Timo Rothenpieler wrote: > On 27.05.2019 23:49, Lance Wang wrote: >> On Saturday, May 25, 2019, James Almer wrote: >> >>> On 5/22/2019 3:59 AM, lance.lmw...@gmail.com wrote: >>>> From: Limin Wang >>>> >>

Re: [FFmpeg-devel] [PATCH v2] avcodec/hevcdec: set the SEI parameters early on the AVCodecContext

2019-05-27 Thread James Almer
On 5/27/2019 11:06 AM, Steve Lhomme wrote: > It's better to do it before the buffers are actually created. At least in VLC > we currently don't support changing some parameters dynamically easily so we > don't use the information if it comes after the buffer are created. > > Co-aut

Re: [FFmpeg-devel] [PATCH] avcodec/h264_parse: Use 64bit for expectedpoc

2019-05-26 Thread James Almer
On 5/23/2019 8:25 PM, Michael Niedermayer wrote: > Fixes: signed integer overflow: -2142516591 + -267814575 cannot be > represented in type 'int' > Fixes: > 14450/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_H264_fuzzer-5716105319940096 > > Found-by: continuous fuzzing process >

[FFmpeg-devel] [PATCH] avcodec/cbs_h264: add support for Alternative Transfer Characteristics SEI message

2019-05-26 Thread James Almer
Signed-off-by: James Almer --- libavcodec/cbs_h264.h | 6 ++ libavcodec/cbs_h2645.c| 1 + libavcodec/cbs_h264_syntax_template.c | 17 + 3 files changed, 24 insertions(+) diff --git a/libavcodec/cbs_h264.h b/libavcodec/cbs_h264.h index

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-25 Thread James Almer
On 5/25/2019 6:03 PM, James Almer wrote: > On 5/25/2019 12:50 PM, Derek Buitenhuis wrote: >> On 25/05/2019 04:25, James Almer wrote: >>>> + >>> >>> Unnecessary empty line. >> >> Fixed. >> >>> Could we not? The idea is to eventual

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-25 Thread James Almer
On 5/25/2019 12:50 PM, Derek Buitenhuis wrote: > On 25/05/2019 04:25, James Almer wrote: >>> + >> >> Unnecessary empty line. > > Fixed. > >> Could we not? The idea is to eventually kill these, so we should at >> least try to not make them even more wi

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/nvenc: add master display and light level sei for HDR10

2019-05-25 Thread James Almer
On 5/22/2019 3:59 AM, lance.lmw...@gmail.com wrote: > From: Limin Wang > > The testing command for the HDR10 output with nvenc: > $ ./ffmpeg_g -y -i 4K.mp4 -c:v hevc_nvenc -g 7 -color_primaries bt2020 > -colorspace bt2020_ncl -color_trc smpte2084 -sei hdr10 \ > -master_display >

Re: [FFmpeg-devel] [PATCH] avcodec/hevcdec: set the SEI parameters early on the AVCodecContext

2019-05-24 Thread James Almer
solution worked :D > > Co-authored-by: James Almer > --- > The same problem may exist with H264 alternative_transfer but I don't have a > sample to test with and the code seems a bit different. Should be a matter of moving the relevant chunk to h264_init_ps(), i think. > --- &

Re: [FFmpeg-devel] [PATCH] avcodec/libx265: Support full range videos

2019-05-24 Thread James Almer
On 5/24/2019 12:23 PM, Derek Buitenhuis wrote: > Signed-off-by: Derek Buitenhuis > --- > libavcodec/libx265.c | 18 +- > 1 file changed, 17 insertions(+), 1 deletion(-) > > diff --git a/libavcodec/libx265.c b/libavcodec/libx265.c > index 07bca81aef..f56def53d5 100644 > ---

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use unspecified language by default

2019-05-23 Thread James Almer
On 5/23/2019 4:32 PM, Marton Balint wrote: > > > On Mon, 20 May 2019, Carl Eugen Hoyos wrote: > >> Am So., 19. Mai 2019 um 20:10 Uhr schrieb Marton Balint : >> >>> English was used before. >> >> A version bump is necessary. >> >> I would also like a Changelog entry, most people prefer an entry

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-23 Thread James Almer
On 5/23/2019 9:51 AM, Lynne wrote: > May 23, 2019, 12:22 PM by pr...@xvid.org: > >> On Tue, May 21, 2019 at 08:39:59PM +0200, Carl Eugen Hoyos wrote: >> >>> Am Di., 21. Mai 2019 um 19:18 Uhr schrieb Lynne : May 21, 2019, 8:44 AM by pr...@xvid.org : > ---

Re: [FFmpeg-devel] [PATCH 04/11] cbs_mpeg2: Fix storage type for frame_centre_*_offset

2019-05-21 Thread James Almer
On 5/21/2019 10:04 PM, Andreas Rheinhardt wrote: > The frame_centre_horizontal/vertical_offset values contained in picture > display extensions are actually signed values (i.e. it is possible to > indicate that the display device should add black bars/pillars). > > The files sony-ct3.bs and

Re: [FFmpeg-devel] [PATCH v2 06/11] cbs: Add support functions for handling unit content references

2019-05-21 Thread James Almer
On 5/20/2019 8:02 PM, Mark Thompson wrote: > Use the unit type table to determine what we need to do to clone the > internals of the unit content when making copies for refcounting or > writeability. (This will still fail for units with complex content > if they do not have a defined clone

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread James Almer
On 5/21/2019 3:42 PM, Carl Eugen Hoyos wrote: > Am Di., 21. Mai 2019 um 09:45 Uhr schrieb Peter Ross : > >> diff --git a/configure b/configure >> index 9b4305cf0d..61eb774116 100755 >> --- a/configure >> +++ b/configure >> @@ -2825,6 +2825,7 @@ vc1image_decoder_select="vc1_decoder" >>

Re: [FFmpeg-devel] [PATCHv4] VP4 video decoder

2019-05-21 Thread James Almer
On 5/21/2019 6:34 AM, Tomas Härdin wrote: > tis 2019-05-21 klockan 17:44 +1000 skrev Peter Ross: >> --- >> >> what's changed: >> * apply #if CONFIG_VP4_DECODER around large vp4 code blocks >> * improved vp4_read_mb_value thanks to reminars suggestions >> * improved configure vp3_decoder_select >>

Re: [FFmpeg-devel] [PATCH v2 01/11] cbs: Mention all codecs in unit type comment

2019-05-20 Thread James Almer
On 5/20/2019 8:02 PM, Mark Thompson wrote: > --- > libavcodec/cbs.h | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/cbs.h b/libavcodec/cbs.h > index 967dcd1468..e8b2d41ecb 100644 > --- a/libavcodec/cbs.h > +++ b/libavcodec/cbs.h > @@ -49,6 +49,8 @@ struct

[FFmpeg-devel] [PATCH] avformat/matroskadec: request frame header parsing for HEVC

2019-05-20 Thread James Almer
-by: James Almer --- libavformat/matroskadec.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/libavformat/matroskadec.c b/libavformat/matroskadec.c index cba2b3d1f8..e282c01fc1 100644 --- a/libavformat/matroskadec.c +++ b/libavformat/matroskadec.c @@ -2525,8 +2525,7 @@ static

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-20 Thread James Almer
On 5/20/2019 5:43 PM, Daniel Kučera wrote: > po 20. 5. 2019 o 21:12 James Almer napísal(a): >> >> On 5/20/2019 4:01 PM, Marton Balint wrote: >>> >>> On Mon, 20 May 2019, Carl Eugen Hoyos wrote: >>> >>>> Marton, >>>

Re: [FFmpeg-devel] [PATCH] avcodec/libdav1d: fine tune thread distribution

2019-05-20 Thread James Almer
On 5/13/2019 11:31 AM, James Almer wrote: > As suggested by Ronald, don't map auto threads to frame threads only, and > instead distribute them between frame and tile more efficiently. > Add a new framethreads override option, similar to the tilethreads one. > > Signed-off-

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-20 Thread James Almer
On 5/20/2019 4:01 PM, Marton Balint wrote: > > On Mon, 20 May 2019, Carl Eugen Hoyos wrote: > >> Marton, >> >> Am Mo., 13. Mai 2019 um 13:42 Uhr schrieb Daniel Kucera >> : >>> >>> From: Daniel Kucera >>> >>> Signed-off-by: Daniel Kucera >>> --- >>>  doc/ffplay.texi  | 2 ++ >>>  

Re: [FFmpeg-devel] [PATCH] web/download: set realistic release schedule

2019-05-20 Thread James Almer
On 5/20/2019 4:00 PM, Lou Logan wrote: > Major releases have been every 6 months approximately; not every 3 months. > > Signed-off-by: Lou Logan > --- > src/download | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/src/download b/src/download > index 07f4439..9544de2

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use unspecified language by default

2019-05-20 Thread James Almer
On 5/20/2019 6:58 AM, Carl Eugen Hoyos wrote: > Am So., 19. Mai 2019 um 20:10 Uhr schrieb Marton Balint : > >> English was used before. > > A version bump is necessary. > > I would also like a Changelog entry, most people prefer an entry to > apichanges though. No API is being changed or

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-19 Thread James Almer
On 5/19/2019 4:22 AM, Peter Ross wrote: > On Fri, May 17, 2019 at 08:13:51PM +0200, Reimar Döffinger wrote: >> On Fri, May 17, 2019 at 08:09:45PM +1000, Peter Ross wrote: >>> ah, i see what you did there! it works perfectly, just missing >>> UPDATE_CACHE at the start and in the loop. >>> >>> test

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-19 Thread James Almer
On 5/19/2019 6:43 AM, Daniel Kučera wrote: > Dňa pi 17. 5. 2019, 21:12 Daniel Kučera > napísal(a): > >> >> >> Dňa št 16. 5. 2019, 12:04 Daniel Kučera >> napísal(a): >> >>> >>> >>> Dňa st 15. 5. 2019, 11:14 Daniel Kučera >>> napísal(a): >>> > > Ping. > > -- > > S

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-18 Thread James Almer
On 5/18/2019 9:24 AM, Paul B Mahol wrote: > On 5/18/19, Reimar Döffinger wrote: >> Voting is not yet another mobbing tool for when you get tired of other ways. >> If you wish for an end to that feud, you can ask other developers to try and >> help, but you've kept this going for years and usually

Re: [FFmpeg-devel] [DECISION] Ban Nicolas George from project

2019-05-17 Thread James Almer
On 5/17/2019 4:25 PM, Paul B Mahol wrote: > Hi, > > $subject. > > He is constantly against my patches, and derailing it with other things > to just block them. > > He is also misguiding other fellow developers with unreasonable and > impossible refactoring task, see that frame rotating patch

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 6:06 PM, Lynne wrote: > May 16, 2019, 8:43 PM by geo...@nsup.org: > >> Lynne (12019-05-16): >> >>> I'm not, I still want the 2 checks. >>> >> >> Arguments please. As I explained, the first check is harmful to >> applications because it hides bug. >> > > Nevermind, its not really

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 3:11 PM, Nicolas George wrote: > James Almer (12019-05-16): >> There are two precedents in the codebase, one checking for both the >> passed argument and then the struct pointer pointed by it (av_bsf_free >> and av_buffer_unref as i mentioned above),

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 11:31 AM, Nicolas George wrote: > James Almer (12019-05-16): >> An assert is meant to detect developer errors, not user errors. Crashing >> the user's whole application because they misused the API is not really >> acceptable. >> >> I can't find

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread James Almer
On 5/16/2019 5:03 AM, Nicolas George wrote: > Ruiling Song (12019-05-16): >> ctx is a pointer to pointer here. >> >> Signed-off-by: Ruiling Song >> --- >> libavutil/tx.c | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/libavutil/tx.c b/libavutil/tx.c >> index

Re: [FFmpeg-devel] [PATCHv3] VP4 video decoder

2019-05-16 Thread James Almer
On 5/16/2019 8:35 AM, Peter Ross wrote: > --- > > what's changed: > * reordered AV_CODEC_ID_VP4 > * minor read_mb_values improvement (reproducible 0.5% speedup) > * configure/Makefile fix > * squished data tables to fill 80 columns. > > UNCHECKED_BITSTREAM_READER doesn't give any performance

Re: [FFmpeg-devel] [PATCH] avutil/tx: should check against (*ctx)

2019-05-15 Thread James Almer
On 5/16/2019 1:47 AM, Ruiling Song wrote: > ctx is a pointer to pointer here. > > Signed-off-by: Ruiling Song > --- > libavutil/tx.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/libavutil/tx.c b/libavutil/tx.c > index 934ef27c81..2bf4aa1c28 100644 > ---

Re: [FFmpeg-devel] [PATCH v2] libavutil: add an FFT & MDCT implementation

2019-05-15 Thread James Almer
On 5/15/2019 2:57 PM, Lynne wrote: > May 14, 2019, 7:41 PM by d...@lynne.ee: > >> May 14, 2019, 7:12 PM by > one...@gmail.com > : >> >>> On 5/14/19, Carl Eugen Hoyos <> >> ceffm...@gmail.com >>> >> > ceffm...@gmail.com >>>

Re: [FFmpeg-devel] [PATCH 2/2] avformat/mp3enc: Avoid SEEK_END as it is unsupported

2019-05-14 Thread James Almer
On 5/14/2019 8:04 AM, Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/mp3enc.c | 3 ++- > 1 file changed, 2 insertions(+), 1 deletion(-) > > diff --git a/libavformat/mp3enc.c b/libavformat/mp3enc.c > index dd662f5473..f4814be80e 100644 > ---

  1   2   3   4   5   6   7   8   9   10   >