Re: [FFmpeg-devel] fate/hap : add test for hap encoding

2018-04-24 Thread James Cowgill
On 23/04/18 10:11, Carl Eugen Hoyos wrote: > 2018-03-14 7:31 GMT+01:00, Martin Vignali : > >> In that case we can let the test using "none" >> compression (bypass the snappy part) > > These tests are also broken, please fix or > remove them: >

Re: [FFmpeg-devel] [PATCH] avformat/libssh: check the user provided a password before trying to use it

2018-01-11 Thread James Cowgill
Hi, On 11/06/17 18:47, jamrial at gmail.com (James Almer) wrote: > Fixes ticket #6413 > > Signed-off-by: James Almer > --- > The public key authentication also tries to use the password variable. I > don't know if NULL is valid in that case or not. > Perhaps for that one it would be better to

[FFmpeg-devel] [PATCH] avformat/dashenc: fix min_seg_duration option size

2017-11-18 Thread James Cowgill
In the DASHContext structure, min_seg_duration is declared as an int, but the AVOption list claimed it was an INT64. Change the option list to use the correct size, which should fix some initialization errors seen on big-endian platforms. Signed-off-by: James Cowgill <jcowg...@debian.

Re: [FFmpeg-devel] [PATCH] lavc: reset codec on receiving packet after EOF in compat_decode

2017-11-09 Thread James Cowgill
Hi, On 09/11/17 14:02, Hendrik Leppkes wrote: > On Thu, Nov 9, 2017 at 1:21 PM, James Cowgill <jcowg...@debian.org> wrote: >> In commit 061a0c14bb57 ("decode: restructure the core decoding code"), the >> deprecated avcodec_decode_* APIs were reworked so t

[FFmpeg-devel] [PATCH] lavc: reset codec on receiving packet after EOF in compat_decode

2017-11-09 Thread James Cowgill
r as the old API did, in the majority of cases it works and it does not require changes to any other part of the decoding code. Fixes ticket #6775 Signed-off-by: James Cowgill <jcowg...@debian.org> --- libavcodec/decode.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavcodec/decode.c b

[FFmpeg-devel] [PATCH v2] avcodec/arm: Fix SIGBUS on ARM when compiled with binutils 2.29

2017-08-29 Thread James Cowgill
2.29 and pre-2.29, use .eqv to pre-calculate the function address without the automatic +1 fixup. Then use these new symbols as the function addresses to be loaded. Fixes ticket 6571. Related binutils bug: https://sourceware.org/bugzilla/show_bug.cgi?id=21458 Signed-off-by: James Cowgill <jc

[FFmpeg-devel] [PATCH] Fix SIGBUS on ARM when compiled with binutils 2.29

2017-08-28 Thread James Cowgill
2.29 and pre-2.29, use .eqv to pre-calculate the function address without the automatic +1 fixup. Then use these new symbols as the function addresses to be loaded. See: https://sourceware.org/bugzilla/show_bug.cgi?id=21458 Fixes ticket 6571. Signed-off-by: James Cowgill <jcowg...@debian.

[FFmpeg-devel] [PATCH v2] swscale: fix gbrap16 alpha channel issues

2017-08-03 Thread James Cowgill
Fixes filter-pixfmts-scale test failing on big-endian systems due to alpSrc not being cast to (const int32_t**). Also fixes distortions in the output alpha channel values by copying the alpha channel code from the rgba64 case found elsewhere in output.c. Fixes ticket 6555. Signed-off-by: James

Re: [FFmpeg-devel] [PATCH] swscale: fix gbrap16 alpha channel issues

2017-08-03 Thread James Cowgill
Hi, On 02/08/17 23:21, Michael Niedermayer wrote: > On Wed, Aug 02, 2017 at 03:32:04PM +0100, James Cowgill wrote: >> Hi, >> >> On 02/08/17 14:18, Michael Niedermayer wrote: >>> On Tue, Aug 01, 2017 at 02:46:22PM +0100, James Cowgill wrote: >>>> Fixe

Re: [FFmpeg-devel] [PATCH] swscale: fix gbrap16 alpha channel issues

2017-08-02 Thread James Cowgill
Hi, On 02/08/17 14:18, Michael Niedermayer wrote: > On Tue, Aug 01, 2017 at 02:46:22PM +0100, James Cowgill wrote: >> Fixes filter-pixfmts-scale test failing on big-endian systems due to >> alpSrc not being cast to (const int32_t**). >> >> Also fixes distortions in the

[FFmpeg-devel] [PATCH] swscale: fix gbrap16 alpha channel issues

2017-08-01 Thread James Cowgill
Fixes filter-pixfmts-scale test failing on big-endian systems due to alpSrc not being cast to (const int32_t**). Also fixes distortions in the output alpha channel values by copying the alpha channel code from the rgba64 case found elsewhere in output.c. Fixes ticket 6555. Signed-off-by: James

[FFmpeg-devel] [PATCH] mips/float_dsp: fix vector_fmul_window_mips on mips64

2015-03-18 Thread James Cowgill
assembly which also needed porting. This patch fixes a bus error in the fate-float-dsp test when run on 64-bit mips. Signed-off-by: James Cowgill james...@cowgill.org.uk Cc: Nedeljko Babic nedeljko.ba...@imgtec.com --- libavutil/mips/float_dsp_mips.c | 12 ++-- 1 file changed, 6 insertions

[FFmpeg-devel] [PATCH v3] mips/asmdefs: use _ABI64 as defined by gcc

2015-03-11 Thread James Cowgill
Unfortunately android api 21 (lollipop) doesn't have the sgidefs.h header, the easiest way around this is to just use the preprocessor definitions from gcc / clang. Signed-off-by: James Cowgill james...@cowgill.org.uk --- Hi, Sorry I forgot about this a little. I think that doing it this way

Re: [FFmpeg-devel] [PATCH] mips/asmdefs: use asm/sgidefs.h header on linux

2015-03-07 Thread James Cowgill
On Sat, 2015-03-07 at 18:06 +0100, wm4 wrote: On Sat, 7 Mar 2015 10:13:23 + James Cowgill james...@cowgill.org.uk wrote: Unfortunately android api 21 (lollipop) doesn't have the sgidefs.h header, but the linux kernel does in asm/sgidefs.h. So use that header if we can. Change

[FFmpeg-devel] [PATCH] mips/asmdefs: change include guard to read AVUTIL_ instead of AVCODEC_

2015-03-07 Thread James Cowgill
Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavutil/mips/asmdefs.h | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/libavutil/mips/asmdefs.h b/libavutil/mips/asmdefs.h index 3660e98..04c036e 100644 --- a/libavutil/mips/asmdefs.h +++ b/libavutil/mips/asmdefs.h

Re: [FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-07 Thread James Cowgill
On Sat, 2015-03-07 at 10:15 +0100, Michael Niedermayer wrote: On Sat, Mar 07, 2015 at 02:47:51AM -0300, James Almer wrote: On 05/03/15 2:40 PM, James Cowgill wrote: diff --git a/libavutil/mips/asmdefs.h b/libavutil/mips/asmdefs.h new file mode 100644 index 000..4d2922c --- /dev

[FFmpeg-devel] [PATCH] mips/asmdefs: use asm/sgidefs.h header on linux

2015-03-07 Thread James Cowgill
Unfortunately android api 21 (lollipop) doesn't have the sgidefs.h header, but the linux kernel does in asm/sgidefs.h. So use that header if we can. Change _ABI64 to _MIPS_SIM_ABI64 which is defined in both headers. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavutil/mips

[FFmpeg-devel] [PATCH v2] mips/asmdefs: use asm/sgidefs.h header on linux

2015-03-07 Thread James Cowgill
Unfortunately android api 21 (lollipop) doesn't have the sgidefs.h header, but the linux kernel does have an almost equivalent asm/sgidefs.h which will do so use that header if we can. Change _ABI64 to _MIPS_SIM_ABI64 which is defined in both headers. Signed-off-by: James Cowgill james

Re: [FFmpeg-devel] [PATCH v2] mips/asmdefs: use asm/sgidefs.h header on linux

2015-03-07 Thread James Cowgill
On Sat, 2015-03-07 at 13:32 +0100, Michael Niedermayer wrote: On Sat, Mar 07, 2015 at 10:56:45AM +, James Cowgill wrote: Unfortunately android api 21 (lollipop) doesn't have the sgidefs.h header, but the linux kernel does have an almost equivalent asm/sgidefs.h which will do so use

[FFmpeg-devel] [PATCH v2 3/4] mips: port optimizations to mips n64

2015-03-05 Thread James Cowgill
registers containing pointers. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aacdec_mips.c | 21 +-- libavcodec/mips/aacdec_mips.h | 9 ++--- libavcodec/mips/aacpsdsp_mips.c | 43 +++--- libavcodec/mips/aacpsy_mips.h

[FFmpeg-devel] [PATCH v2 1/4] mips/aacdec: remove uses of mips32r2 specific ext instructions

2015-03-05 Thread James Cowgill
Removing these removes the dependency of this code on mips32r2 which would allow it to be used on processors which have FPU instructions, but not r2 instructions (like the mips64el debian port for instance). Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aacdec_mips.h

[FFmpeg-devel] [PATCH v2 2/4] configure, mips: remove MIPS32R2, merging it with MIPSFPU

2015-03-05 Thread James Cowgill
there as well. Also remove the last occurence of HAVE_MIPS32R2 (which is coupled to HAVE_MIPSFPU anyway). mips32r2 is left in the list of options form compatability so that using --disable-mips32r2 doesn't break anything. Signed-off-by: James Cowgill james...@cowgill.org.uk --- Makefile

[FFmpeg-devel] [PATCH v2 4/4] changelog: add mips 64-bit port

2015-03-05 Thread James Cowgill
--- Changelog | 1 + 1 file changed, 1 insertion(+) diff --git a/Changelog b/Changelog index 1374cbc..2a5d6b8 100644 --- a/Changelog +++ b/Changelog @@ -36,6 +36,7 @@ version next: - Canopus HQX decoder - RTP depacketization of T.140 text (RFC 4103) - VP9 RTP payload format (draft 0)

[FFmpeg-devel] [PATCH v2 0/4] mips cleanups and port to mips64

2015-03-05 Thread James Cowgill
entry in the changelog for the mips 64-bit port. Thanks, James James Cowgill (4): mips/aacdec: remove uses of mips32r2 specific ext instructions configure, mips: remove MIPS32R2, merging it with MIPSFPU mips: port optimizations to mips n64 changelog: add mips 64-bit port Changelog

Re: [FFmpeg-devel] [PATCH 09/12] mips: port optimizations to mips n64

2015-03-04 Thread James Cowgill
On Wed, 2015-03-04 at 11:52 +0100, Michael Niedermayer wrote: On Wed, Mar 04, 2015 at 10:10:15AM +, Nedeljko Babic wrote: LGTM seems this does not apply cleanly on HEAD Applying: mips: port optimizations to mips n64 error: patch failed: libavcodec/mips/acelp_filters_mips.c:82 error:

Re: [FFmpeg-devel] [PATCH 02/12] mips/float_dsp: replace assembly with C implementations

2015-03-04 Thread James Cowgill
On Wed, 2015-03-04 at 11:08 +, Nedeljko Babic wrote: The assembly versions have a few problems - They only work with mips32r2 enabled - They don't work on 64-bits - They're massive and complex So replace them with C implementations which solve these problems and let GCC magically

Re: [FFmpeg-devel] [PATCH 07/12] mips/aacdec: remove uses of mips32r2 specific ext instructions

2015-03-03 Thread James Cowgill
On Tue, 2015-03-03 at 12:42 +, Nedeljko Babic wrote: Removing these removes the dependency of this code on mips32r2 which would allow it to be used on processors which have FPU instructions, but not r2 instructions (like the mips64el debian port for instance). I would be more

[FFmpeg-devel] [PATCH 07/12] mips/aacdec: remove uses of mips32r2 specific ext instructions

2015-02-26 Thread James Cowgill
Removing these removes the dependency of this code on mips32r2 which would allow it to be used on processors which have FPU instructions, but not r2 instructions (like the mips64el debian port for instance). Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aacdec_mips.h

[FFmpeg-devel] [PATCH 03/12] mips/aacpsdsp: fix definition of ps_decorrelate_mips

2015-02-26 Thread James Cowgill
Q_fract should have be declared as 'const float*'. Also fix the constness of some local variables affected by this. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aacpsdsp_mips.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/libavcodec/mips

[FFmpeg-devel] [PATCH 08/12] configure, mips: remove MIPS32R2, merging it with MIPSFPU

2015-02-26 Thread James Cowgill
there as well. Also remove the last occurence of HAVE_MIPS32R2 (which is coupled to HAVE_MIPSFPU anyway). Signed-off-by: James Cowgill james...@cowgill.org.uk --- Makefile | 2 +- arch.mak | 1 - configure | 19

[FFmpeg-devel] [PATCH 04/12] mips/fft: remove some useless assembly

2015-02-26 Thread James Cowgill
Remove some assembly that the compiler can easily handle optimally on its own. GCC produces almost identical assembly. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/fft_mips.c | 26 ++ 1 file changed, 2 insertions(+), 24 deletions(-) diff --git

[FFmpeg-devel] [PATCH 05/12] mips/sbrdsp: remove sbr_neg_odd_64_mips

2015-02-26 Thread James Cowgill
The optimized C version of this code actually runs faster than this version, so remove it. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/sbrdsp_mips.c | 34 -- 1 file changed, 34 deletions(-) diff --git a/libavcodec/mips/sbrdsp_mips.c b

[FFmpeg-devel] [PATCH 02/12] mips/float_dsp: replace assembly with C implementations

2015-02-26 Thread James Cowgill
unrolled 4 times (like the assembly code). With the addition of a few restrict keywords, the functions produce almost identical assembly to the original versions when compiled with gcc -O3. Since this code now uses no fpu assembly, drop the HAVE_MIPSFPU guard as well. Signed-off-by: James Cowgill

[FFmpeg-devel] [PATCH 10/12] mips: use float* to hold pointer instead of int

2015-02-26 Thread James Cowgill
This is obviously needed for 64-bit support. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aacdec_mips.c | 2 +- libavcodec/mips/aacpsdsp_mips.c | 12 ++-- libavcodec/mips/sbrdsp_mips.c | 10 +- 3 files changed, 12 insertions(+), 12 deletions

[FFmpeg-devel] [PATCH 12/12] mips/aaccoder: use variables instead of using register names directly

2015-02-26 Thread James Cowgill
to avoid a variable name conflict. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aaccoder_mips.c | 929 +--- 1 file changed, 477 insertions(+), 452 deletions(-) diff --git a/libavcodec/mips/aaccoder_mips.c b/libavcodec/mips

[FFmpeg-devel] [PATCH 00/12] mips cleanups and port to mips64

2015-02-26 Thread James Cowgill
to disable DSP otherwise I get a lot of SIGILL). Since this was what the code was doing before, I just left it instead of messing up all the MIPS configure options (more than I have done). Thanks, James James Cowgill (12): mips/mathops: remove 64-bit code mips/float_dsp: replace assembly with C

[FFmpeg-devel] [PATCH 01/12] mips/mathops: remove 64-bit code

2015-02-26 Thread James Cowgill
GCC is perfectly happy generating optimized multiplication code on its own for 64-bit arches. GCC refuses to optimize the loongson code when in 32-bit mode, so I've left that. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/mathops.h | 26 -- 1

[FFmpeg-devel] [PATCH 09/12] mips: port optimizations to mips n64

2015-02-26 Thread James Cowgill
registers containing pointers. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aacdec_mips.c | 21 +-- libavcodec/mips/aacdec_mips.h | 9 ++--- libavcodec/mips/aacpsdsp_mips.c | 43 +++--- libavcodec/mips/aacpsy_mips.h

[FFmpeg-devel] [PATCH 06/12] mips/aacdec: refactor out duplicated assembly code

2015-02-26 Thread James Cowgill
The float_copy and fmul_and_reverse functions are refactored out from the multiple copies in this file. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips/aacdec_mips.c | 612 -- 1 file changed, 111 insertions(+), 501 deletions

[FFmpeg-devel] [PATCH 11/12] mips/acelp_filters: fix incorrect register constraint

2015-02-26 Thread James Cowgill
Change register constraint on the v variable from = to +. This was causing GCC to think that the v variable was never read and therefore not initialize it. This fixes about 20 fate failures on mips64el. Signed-off-by: James Cowgill james...@cowgill.org.uk --- libavcodec/mips

Re: [FFmpeg-devel] [PATCH 02/12] mips/float_dsp: replace assembly with C implementations

2015-02-26 Thread James Cowgill
On Thu, 2015-02-26 at 13:51 +, Derek Buitenhuis wrote: On 2/26/2015 1:42 PM, James Cowgill wrote: The assembly versions have a few problems - They only work with mips32r2 enabled - They don't work on 64-bits - They're massive and complex So replace them with C implementations