Re: [FFmpeg-devel] [PATCH] Change libvpxenc default to crf=32.

2019-10-07 Thread James Zern
On Sat, Oct 5, 2019 at 1:23 PM James Zern wrote: > > On Tue, Sep 24, 2019 at 4:31 PM Elliott Karpilovsky > wrote: > > > > Current default is 200kbps, which produces inconsistent > > results (too high for low-res, too low for hi-res). Use > > CRF instead, which w

Re: [FFmpeg-devel] [PATCH] Change libvpxenc default to crf=32.

2019-10-05 Thread James Zern
On Tue, Sep 24, 2019 at 4:31 PM Elliott Karpilovsky wrote: > > Current default is 200kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). Use > CRF instead, which will adapt. Affects VP9. Also have > VP8 use a default bitrate of 256kbps. > --- >

Re: [FFmpeg-devel] [PATCH] tools/patcheck: remove gcc-2.95 compat check

2019-09-21 Thread James Zern
On Fri, Sep 20, 2019 at 12:38 AM Paul B Mahol wrote: > > LGTM > > On 9/20/19, James Zern wrote: > > this conflicts with the current contributing guidance: > > http://ffmpeg.org/developer.html#Contributing > > FFmpeg is programmed in the ISO C90 language with a fe

[FFmpeg-devel] [PATCH] tools/patcheck: remove gcc-2.95 compat check

2019-09-20 Thread James Zern
this conflicts with the current contributing guidance: http://ffmpeg.org/developer.html#Contributing FFmpeg is programmed in the ISO C90 language with a few additional features from ISO C99, namely: ... for loops with variable definition (‘for (int i = 0; i < 8; i++)’); Signed-off-by: James Z

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

2019-09-20 Thread James Zern
On Wed, Sep 18, 2019 at 11:42 AM James Zern wrote: > > On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky > wrote: > > > > --- > > libavcodec/libaomenc.c | 14 +- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > lgtm. This

Re: [FFmpeg-devel] [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

2019-09-20 Thread James Zern
On Wed, Sep 18, 2019 at 12:03 PM James Zern wrote: > > On Wed, Sep 18, 2019 at 7:54 AM Guo, Yejun wrote: > > > > > > > > > -Original Message- > > > From: Guo, Yejun > > > Sent: Thursday, September 12, 2019 6:25 PM > > > To:

Re: [FFmpeg-devel] [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

2019-09-18 Thread James Zern
On Wed, Sep 18, 2019 at 7:54 AM Guo, Yejun wrote: > > > > > -Original Message- > > From: Guo, Yejun > > Sent: Thursday, September 12, 2019 6:25 PM > > To: ffmpeg-devel@ffmpeg.org > > Cc: Guo, Yejun > > Subject: [PATCH V9] avcodec/libvpxenc: add ROI-based encoding support for > > VP8/VP9

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

2019-09-18 Thread James Zern
On Wed, Sep 18, 2019 at 11:42 AM James Zern wrote: > > On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky > wrote: > > > > --- > > libavcodec/libaomenc.c | 14 +- > > 1 file changed, 5 insertions(+), 9 deletions(-) > > > > lgtm. This

Re: [FFmpeg-devel] [PATCH] Delete unused branch in libaomenc

2019-09-18 Thread James Zern
On Sun, Sep 15, 2019 at 2:03 PM Elliott Karpilovsky wrote: > > --- > libavcodec/libaomenc.c | 14 +- > 1 file changed, 5 insertions(+), 9 deletions(-) > lgtm. This is leftover from libvpxenc, only vp8 can hit the path there. > diff --git a/libavcodec/libaomenc.c

Re: [FFmpeg-devel] [PATCH V8] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9

2019-09-12 Thread James Zern
Hi, On Tue, Sep 10, 2019 at 6:13 PM Guo, Yejun wrote: > > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 188 >

Re: [FFmpeg-devel] [PATCH] Change libvpx-vpx default to crf=32.

2019-09-04 Thread James Zern
Hi, On Wed, Aug 28, 2019 at 2:26 PM Elliott Karpilovsky wrote: > > Current default is 200kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). Use > CRF instead, which will adapt. Affects vp8/vp9. Also > have VP8 use a default bitrate of 256kbps. > --- >

Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-29 Thread James Zern
On Wed, Aug 28, 2019 at 10:20 PM Guo, Yejun wrote: > > > > > -Original Message- > > From: James Zern [mailto:jz...@google.com] > > Sent: Thursday, August 29, 2019 12:39 PM > > To: Guo, Yejun > > Cc: FFmpeg development discussions and patches &g

Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-28 Thread James Zern
Hi, On Mon, Aug 26, 2019 at 11:30 PM Guo, Yejun wrote: > > > > > -Original Message- > > From: James Zern [mailto:jz...@google.com] > > Sent: Tuesday, August 27, 2019 12:03 PM > > To: FFmpeg development discussions and patches > > Cc: Guo, Yejun &g

Re: [FFmpeg-devel] [PATCH V5] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-26 Thread James Zern
Hi, On Thu, Aug 22, 2019 at 5:56 PM Guo, Yejun wrote: > > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 194 >

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

2019-08-23 Thread James Zern
On Wed, Aug 21, 2019 at 6:03 PM James Zern wrote: > > On Wed, Aug 21, 2019 at 12:18 PM Elliott Karpilovsky > wrote: > > > > From: elliottk > > > > Current default is 256kbps, which produces inconsistent > > results (too high for low-res, too low

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

2019-08-22 Thread James Zern
Hi, On Thu, Aug 22, 2019 at 12:25 AM Moritz Barsnick wrote: > > On Wed, Aug 21, 2019 at 18:03:23 -0700, James Zern wrote: > > > From: elliottk > > > Current default is 256kbps, which produces inconsistent > > > results (too high for low-res, too low for hi-r

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=32.

2019-08-21 Thread James Zern
On Wed, Aug 21, 2019 at 12:18 PM Elliott Karpilovsky wrote: > > From: elliottk > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 9 + > 1 file changed, 5

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

2019-08-21 Thread James Zern
On Tue, Aug 20, 2019 at 5:31 PM Elliott Karpilovsky wrote: > > I believe the documentation is out of date. I added some debug > statements and verified that variable was being used to pull CRF > values when AOM_Q mode is set. I have > https://aomedia-review.googlesource.com/c/aom/+/94104 out to

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-20 Thread James Zern
Hi, On Tue, Aug 13, 2019 at 8:29 PM Guo, Yejun wrote: > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 197 >

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

2019-08-16 Thread James Zern
Hi, On Thu, Aug 15, 2019 at 1:22 PM elliottk wrote: > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 9 + > 1 file changed, 5 insertions(+), 4

Re: [FFmpeg-devel] [PATCH] Change libaom default to crf=28.

2019-08-14 Thread James Zern
Hi, On Tue, Aug 13, 2019 at 8:23 PM elliottk wrote: > > Current default is 256kbps, which produces inconsistent > results (too high for low-res, too low for hi-res). > Use CRF instead, which will adapt. > --- > libavcodec/libaomenc.c | 8 > 1 file changed, 4 insertions(+), 4

Re: [FFmpeg-devel] [PATCH, RFC, v2 3/3] lavc/libvpxenc: add dynamic resolution encode support for libvpx

2019-08-13 Thread James Zern
Hi, On Tue, Aug 13, 2019 at 2:30 AM Linjie Fu wrote: > > According to spec, libvpx should support dynamic resolution changes. > > Add dynamic resolution encoding support in libvpx. > > Only single pass mode with no look ahead is supported for variable > resolution encoding without

Re: [FFmpeg-devel] [PATCH V2] avcodec/libvpxenc: add ROI-based encoding support for VP8/VP9 support

2019-08-13 Thread James Zern
Hi, On Tue, Aug 13, 2019 at 1:18 AM Guo, Yejun wrote: > > example command line to verify it: > ./ffmpeg -i input.stream -vf addroi=0:0:iw/3:ih/3:-0.8 -c:v libvpx -b:v 2M > tmp.webm > > Signed-off-by: Guo, Yejun > --- > configure | 7 ++ > libavcodec/libvpxenc.c | 197 >

Re: [FFmpeg-devel] [PATCH, v2 3/3] lavc/libvpxenc: add dynamic resolution encode support for libvpx

2019-07-31 Thread James Zern
Hi, On Tue, Jul 30, 2019 at 10:06 PM Linjie Fu wrote: > [...] > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index feb52ea..800ba18 100644 > --- a/libavcodec/libvpxenc.c > +++ b/libavcodec/libvpxenc.c > @@ -1067,6 +1067,15 @@ static int vpx_encode(AVCodecContext *avctx,

[FFmpeg-devel] [PATCH] avcodec/utils, avcodec_open2: close codec on failure

2019-07-09 Thread James Zern
after a successful init if the function fails for another reason close the codec without requiring FF_CODEC_CAP_INIT_CLEANUP which is meant to cover init failures themselves. fixes a memory leak in those cases. BUG=oss-fuzz:15529 Signed-off-by: James Zern --- libavcodec/utils.c | 5 - 1

Re: [FFmpeg-devel] [PATCH V4] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-12 Thread James Zern
On Fri, Mar 8, 2019 at 5:07 AM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 150 > + > 1 file changed, 150 insertions(+) > > [...] > +active_map.active_map = av_malloc(active_map.rows * active_map.cols); >

Re: [FFmpeg-devel] [PATCH V3] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-07 Thread James Zern
On Thu, Feb 28, 2019 at 11:23 PM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > libavcodec/libvpxenc.c | 150 > + > 1 file changed, 150 insertions(+) > > diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c > index

Re: [FFmpeg-devel] [PATCH 2/2] configure: use vpx_codec_vp8_dx/cx for libvpx-vp8 checking

2019-03-06 Thread James Zern
On Mon, Mar 4, 2019 at 6:19 AM Guo, Yejun wrote: > > Signed-off-by: Guo, Yejun > --- > configure | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > lgtm. This is a remnant from when vp8 was the only codec in the library. ___ ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-03-01 Thread James Zern
On Fri, Mar 1, 2019 at 4:51 AM Derek Buitenhuis wrote: > > On 01/03/2019 03:18, Guo, Yejun wrote: > > yes, that's the reason I pending VP9 work. As for VP8 ROI, another thinking > > is to first push vp8 roi, since libvpx is an external dependency and we > > don't > > know the time when it is

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 support for ROI-based encoding

2019-02-28 Thread James Zern
> > > > > +if (avctx->codec_id == AV_CODEC_ID_VP8) > > > +vp8_encode_set_roi(avctx, frame); > > > > The API only exists for VP8, or is this due to different quant scales or > > something? > > currently, VP9 ROI does not work, see my discussion at >

Re: [FFmpeg-devel] lavc/libvpxenc: Deprecate lossless option

2019-02-11 Thread James Zern
On Sat, Feb 9, 2019 at 3:15 AM Carl Eugen Hoyos wrote: > > 2019-02-09 7:49 GMT+01:00, Gyan : > > > > > > On 09-02-2019 02:26 AM, Carl Eugen Hoyos wrote: > >> 2019-02-08 6:08 GMT+01:00, Gyan : > >>> > >>> On 08-02-2019 03:31 AM, Carl Eugen Hoyos wrote: > . > No strong opinion here, I

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-24 Thread James Zern
On Fri, Dec 21, 2018 at 7:38 PM James Zern wrote: > > On Fri, Dec 21, 2018 at 1:36 PM Rene Claus > wrote: > > > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Sign

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 11:24 AM James Almer wrote: > > On 12/21/2018 1:09 PM, James Zern wrote: > > On Thu, Dec 20, 2018 at 7:51 PM Rene Claus > > wrote: > >> > >> This commit adds configuration options to libvpxenc.c that can be used to > >>

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Fri, Dec 21, 2018 at 1:36 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-21 Thread James Zern
On Thu, Dec 20, 2018 at 7:51 PM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 6 ++ > 2 files

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread James Zern
On Wed, Dec 19, 2018 at 2:03 PM James Almer wrote: > > On 12/19/2018 6:52 PM, Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > > tune the sharpness parameter for VP8 and VP9. > > > > Signed-off-by: Rene Claus > > --- > > doc/encoders.texi |

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8/9 sharpness config option

2018-12-19 Thread James Zern
On Wed, Dec 19, 2018 at 10:24 AM Rene Claus wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > tune the sharpness parameter of the loop filter for VP8 and VP9. > > Signed-off-by: Rene Claus > --- > doc/encoders.texi | 4 > libavcodec/libvpxenc.c | 5

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

2018-11-19 Thread James Zern
On Fri, Nov 16, 2018 at 8:59 PM James Zern wrote: > > On Wed, Nov 14, 2018 at 12:56 PM Ard Oerlemans > wrote: > > > > This commit adds configuration options to libvpxenc.c that can be used to > > enable VP8 temporal scalability. It also adds a way to programmatically

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

2018-11-16 Thread James Zern
On Wed, Nov 14, 2018 at 12:56 PM Ard Oerlemans wrote: > > This commit adds configuration options to libvpxenc.c that can be used to > enable VP8 temporal scalability. It also adds a way to programmatically set > the > per-frame encoding flags which can be used to control usage and updates of >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: add VP8 temporal scalability configuration options

2018-11-13 Thread James Zern
On Mon, Nov 12, 2018 at 10:37 AM Ard Oerlemans wrote: > > Thanks for the suggestion. I have updated the patch. > Try to keep the original patch message so it's easier to apply. > Ard > > --- > doc/encoders.texi | 28 +++ > libavcodec/libvpxenc.c | 79

Re: [FFmpeg-devel] [PATCH] libvpxenc,vp9: add enable-tpl option

2018-11-09 Thread James Zern
On Thu, Nov 8, 2018 at 2:46 PM James Zern wrote: > > On Sat, Nov 3, 2018 at 2:01 PM James Zern wrote: > > > > enables temporal dependency model > > > > Signed-off-by: James Zern > > --- > > doc/encoders.texi | 2 ++ > > libavcodec/libvp

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-08 Thread James Zern
On Mon, Nov 5, 2018 at 5:03 PM James Zern wrote: > > On Mon, Nov 5, 2018 at 5:02 PM James Zern wrote: > > > > vp9 now supports [0, 6] > > > > Signed-off-by: James Zern > > --- > > doc/encoders.texi | 1 + > > libavcodec/libvpxenc.c | 6

Re: [FFmpeg-devel] [PATCH] libvpxenc,vp9: add enable-tpl option

2018-11-08 Thread James Zern
On Sat, Nov 3, 2018 at 2:01 PM James Zern wrote: > > enables temporal dependency model > > Signed-off-by: James Zern > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 11 +++ > 2 files changed, 13 insertions(+) > If there aren't any comment

[FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-05 Thread James Zern
vp9 now supports [0, 6] Signed-off-by: James Zern --- doc/encoders.texi | 1 + libavcodec/libvpxenc.c | 6 -- 2 files changed, 5 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 899faac49b..3c6f5cd70b 100644 --- a/doc/encoders.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-05 Thread James Zern
On Mon, Nov 5, 2018 at 5:02 PM James Zern wrote: > > vp9 now supports [0, 6] > > Signed-off-by: James Zern > --- > doc/encoders.texi | 1 + > libavcodec/libvpxenc.c | 6 -- > 2 files changed, 5 insertions(+), 2 deletions(-) > This version moves the

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-05 Thread James Zern
On Mon, Nov 5, 2018 at 4:45 PM James Zern wrote: > > On Sat, Nov 3, 2018 at 2:31 PM James Almer wrote: > > > > On 11/3/2018 6:04 PM, James Zern wrote: > > > On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote: > > >> [...] > > >> #define COMMON

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-05 Thread James Zern
On Sat, Nov 3, 2018 at 2:31 PM James Almer wrote: > > On 11/3/2018 6:04 PM, James Zern wrote: > > On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote: > >> [...] > >> #define COMMON_OPTIONS \ > >> { "auto-alt

Re: [FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-03 Thread James Zern
On Sat, Nov 3, 2018 at 2:02 PM James Zern wrote: > [...] > #define COMMON_OPTIONS \ > { "auto-alt-ref","Enable use of alternate reference " \ > - "frames (2-pass only)", > OFFSET(auto_alt_ref),

[FFmpeg-devel] [PATCH] libvpxenc,vp9: add enable-tpl option

2018-11-03 Thread James Zern
enables temporal dependency model Signed-off-by: James Zern --- doc/encoders.texi | 2 ++ libavcodec/libvpxenc.c | 11 +++ 2 files changed, 13 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 899faac49b..fced8d7369 100644 --- a/doc/encoders.texi +++ b/doc

[FFmpeg-devel] [PATCH] libvpxenc: extend auto-alt-ref range

2018-11-03 Thread James Zern
vp9 now supports [0, 6] Signed-off-by: James Zern --- doc/encoders.texi | 1 + libavcodec/libvpxenc.c | 2 +- 2 files changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 899faac49b..3c6f5cd70b 100644 --- a/doc/encoders.texi +++ b/doc

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

2018-10-30 Thread James Zern
On Mon, Oct 29, 2018 at 10:58 PM James Zern wrote: > > On Sat, Oct 27, 2018 at 1:54 PM James Almer wrote: > > > > On 10/27/2018 5:52 PM, James Zern wrote: > > > a thread count of 0 is treated the same as 1, use av_cpu_count() to get > > > the correct thread

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

2018-10-30 Thread James Zern
On Sat, Oct 27, 2018 at 1:54 PM James Almer wrote: > > On 10/27/2018 5:52 PM, James Zern wrote: > > a thread count of 0 is treated the same as 1, use av_cpu_count() to get > > the correct thread count when auto threads is requested. > > > > this matches the fi

[FFmpeg-devel] [PATCH] avcodec/libvpxdec: fix setting auto threads

2018-10-27 Thread James Zern
a thread count of 0 is treated the same as 1, use av_cpu_count() to get the correct thread count when auto threads is requested. this matches the fix in libvpxenc: 27df34bf1f avcodec/libvpxenc: fix setting amount of threads used for encoding Signed-off-by: James Zern --- libavcodec/libvpxdec.c

Re: [FFmpeg-devel] [PATCH] avformat/vpcc: fix values in VP9 level detection heuristics

2018-09-14 Thread James Zern
On Fri, Sep 14, 2018 at 6:39 PM James Almer wrote: > > On 8/27/2018 10:59 PM, James Almer wrote: > > The levels are stored as decimal values, not hexadecimal. > > > > Signed-off-by: James Almer > > --- > > libavformat/vpcc.c | 28 ++-- > > 1 file changed, 14

Re: [FFmpeg-devel] [PATCH] lavc/libaomenc: Add -tile-columns/-tile-rows

2018-08-31 Thread James Zern
On Fri, Aug 31, 2018 at 9:40 AM James Almer wrote: > > On 8/31/2018 1:00 PM, Kagami Hiiragi wrote: > > On 31/08/18 18:18, James Almer wrote: > >> On 8/31/2018 11:52 AM, Kagami Hiiragi wrote: > >>> On 31/08/18 02:58, James Almer wrote: > On 8/20/2018 2:56 PM, Kagami Hiiragi wrote: > >

Re: [FFmpeg-devel] [PATCH] avcodec/libvpxenc: fix setting amount of threads used for encoding

2018-05-21 Thread James Zern
On Sat, May 19, 2018 at 11:16 AM James Almer wrote: > The libvpx doxy says that a value of 0 for the g_threads field is > equivalent to a value of 1, whereas for avctx->thread_count it means > the maximum amount of threads possible for the host system. > Use av_cpu_count() to

Re: [FFmpeg-devel] [PATCH] avcodec/vp9: mark frame as finished on decode_tiles() failure

2017-12-13 Thread James Zern
fps_10bit_420.y4m.vp9.noaltref.webm.ivf.s149104_r01-05_b6-.ivf > Fixes: ducks_take_off_444_720p50.y4m.vp9.webm.ivf.s107375_r01-05_b6-.ivf > > Reported-by: James Zern <jz...@google.com> > Signed-off-by: Michael Niedermayer <mich...@niedermayer.cc> > --- > libavcodec/vp9.c | 4 +++- > 1 file c

Re: [FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

2017-11-28 Thread James Zern
On Mon, Nov 27, 2017 at 10:55 AM, James Zern <jz...@google.com> wrote: > On Mon, Nov 20, 2017 at 5:36 PM, James Zern <jz...@google.com> wrote: >> Corpus VBR mode is a variant of standard VBR where the complexity >> distribution midpoint is passed in rather than calcul

Re: [FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

2017-11-27 Thread James Zern
On Mon, Nov 20, 2017 at 5:36 PM, James Zern <jz...@google.com> wrote: > Corpus VBR mode is a variant of standard VBR where the complexity > distribution midpoint is passed in rather than calculated for a specific > clip or chunk. > > The valid range is [0, 1]. 0 (defau

[FFmpeg-devel] [PATCH] libvpxenc, vp9: add corpus-complexity option

2017-11-20 Thread James Zern
Corpus VBR mode is a variant of standard VBR where the complexity distribution midpoint is passed in rather than calculated for a specific clip or chunk. The valid range is [0, 1]. 0 (default) uses standard VBR. Signed-off-by: James Zern <jz...@google.com> --- doc/encoders.texi

Re: [FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern <jz...@google.com> wrote: > Signed-off-by: James Zern <jz...@google.com> > --- > libavcodec/libvpxdec.c | 25 - > 1 file changed, 25 deletions(-) > applied. _

Re: [FFmpeg-devel] [PATCH 4/4] libvpxenc: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern <jz...@google.com> wrote: > Signed-off-by: James Zern <jz...@google.com> > --- > libavcodec/libvpxenc.c | 25 +++-- > 1 file changed, 3 insertions(+), 22 deletions(-) > applied. ___

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Fri, Nov 17, 2017 at 5:50 PM, James Zern <jz...@google.com> wrote: > Signed-off-by: James Zern <jz...@google.com> > --- > libavcodec/libvpx.c | 12 +--- > 1 file changed, 1 insertion(+), 11 deletions(-) > applied. _

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Mon, Nov 20, 2017 at 11:51 AM, James Almer <jamr...@gmail.com> wrote: > On 11/20/2017 4:38 PM, James Zern wrote: >> On Mon, Nov 20, 2017 at 11:17 AM, James Zern <jz...@google.com> wrote: >>> On Sun, Nov 19, 2017 at 6:03 AM, James Almer <jamr...@gmail.com>

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Mon, Nov 20, 2017 at 11:17 AM, James Zern <jz...@google.com> wrote: > On Sun, Nov 19, 2017 at 6:03 AM, James Almer <jamr...@gmail.com> wrote: >> On 11/17/2017 10:50 PM, James Zern wrote: >>> this will simplify libvpxenc/dec.c and ensure more stable versions

Re: [FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-20 Thread James Zern
On Sun, Nov 19, 2017 at 5:57 AM, James Almer <jamr...@gmail.com> wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> Signed-off-by: James Zern <jz...@google.com> >> --- >> libavcodec/libvpx.c | 12 +--- >> 1 file changed, 1 insertion(+), 11 del

Re: [FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-20 Thread James Zern
On Sun, Nov 19, 2017 at 6:03 AM, James Almer <jamr...@gmail.com> wrote: > On 11/17/2017 10:50 PM, James Zern wrote: >> this will simplify libvpxenc/dec.c and ensure more stable versions of >> the codecs are present. >> >> Signed-off-by: James Zern <jz...@g

[FFmpeg-devel] [PATCH 1/4] configure: require libvpx-1.4.0 for vp[89] support

2017-11-17 Thread James Zern
this will simplify libvpxenc/dec.c and ensure more stable versions of the codecs are present. Signed-off-by: James Zern <jz...@google.com> --- configure | 20 ++-- 1 file changed, 10 insertions(+), 10 deletions(-) diff --git a/configure b/configure index c8e2e35192..bfb1

[FFmpeg-devel] [PATCH 3/4] libvpxdec: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxdec.c | 25 - 1 file changed, 25 deletions(-) diff --git a/libavcodec/libvpxdec.c b/libavcodec/libvpxdec.c index ad0ea3b02a..2ae29d202a 100644 --- a/libavcodec/libvpxdec.c +++ b/libavcodec/libvp

[FFmpeg-devel] [PATCH 2/4] libvpx: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpx.c | 12 +--- 1 file changed, 1 insertion(+), 11 deletions(-) diff --git a/libavcodec/libvpx.c b/libavcodec/libvpx.c index 1eca97a081..36f915a8e5 100644 --- a/libavcodec/libvpx.c +++ b/libavcodec/libvpx.c @@ -40,9

[FFmpeg-devel] [PATCH 4/4] libvpxenc: remove pre-1.4.0 checks

2017-11-17 Thread James Zern
Signed-off-by: James Zern <jz...@google.com> --- libavcodec/libvpxenc.c | 25 +++-- 1 file changed, 3 insertions(+), 22 deletions(-) diff --git a/libavcodec/libvpxenc.c b/libavcodec/libvpxenc.c index fbb842499b..0258396d08 100644 --- a/libavcodec/libvpxenc.c +++ b/liba

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-17 Thread James Zern
On Mon, Nov 13, 2017 at 4:01 PM, James Zern <jz...@google.com> wrote: > Signed-off-by: James Zern <jz...@google.com> > --- > doc/encoders.texi | 2 ++ > libavcodec/libvpxenc.c | 20 > 2 files changed, 22 insertions(+) > Applied with an

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-16 Thread James Zern
On Nov 14, 2017 18:53, "James Zern" <jz...@google.com> wrote: On Mon, Nov 13, 2017 at 6:05 PM, James Zern <jz...@google.com> wrote: > On Mon, Nov 13, 2017 at 4:43 PM, James Almer <jamr...@gmail.com> wrote: >> On 11/13/2017 9:01 PM, James Zern wrote: >>&g

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-14 Thread James Zern
On Mon, Nov 13, 2017 at 6:05 PM, James Zern <jz...@google.com> wrote: > On Mon, Nov 13, 2017 at 4:43 PM, James Almer <jamr...@gmail.com> wrote: >> On 11/13/2017 9:01 PM, James Zern wrote: >>> Signed-off-by: James Zern <jz...@google.com> >>> --- >&g

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-13 Thread James Zern
On Mon, Nov 13, 2017 at 4:43 PM, James Almer <jamr...@gmail.com> wrote: > On 11/13/2017 9:01 PM, James Zern wrote: >> Signed-off-by: James Zern <jz...@google.com> >> --- >> doc/encoders.texi | 2 ++ >> libavcodec/libvpxenc.c | 20

[FFmpeg-devel] [PATCH] lavc/libvpxenc: add tune-content option

2017-11-13 Thread James Zern
Signed-off-by: James Zern <jz...@google.com> --- doc/encoders.texi | 2 ++ libavcodec/libvpxenc.c | 20 2 files changed, 22 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 431777c457..23451b7b92 100644 --- a/doc/encoders.texi +++

Re: [FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-21 Thread James Zern
On Sat, Aug 19, 2017 at 8:04 AM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Fri, Aug 18, 2017 at 11:31 PM, James Zern <jz...@google.com> wrote: >> >> this is undocumented in the vp9 bitstream and decoding specification >> doc, but matches lib

[FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-18 Thread James Zern
this is undocumented in the vp9 bitstream and decoding specification doc, but matches libvpx Signed-off-by: James Zern <jz...@google.com> --- libavcodec/vp9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7d8aced8c8..9443

Re: [FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-18 Thread James Zern
On Fri, Aug 18, 2017 at 8:31 PM, James Zern <jz...@google.com> wrote: > this is undocumented in the vp9 bitstream and decoding specification > doc, but matches libvpx > this came up in comparing decode results of ffvp9 and libvpx with source from a hardware encoder. > Signed-

[FFmpeg-devel] [PATCH] vp9: set color range to MPEG for intraonly profile 0

2017-08-18 Thread James Zern
this is undocumented in the vp9 bitstream and decoding specification doc, but matches libvpx Signed-off-by: James Zern <jz...@google.com> --- libavcodec/vp9.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/vp9.c b/libavcodec/vp9.c index 7d8aced8c8..9443

Re: [FFmpeg-devel] [PATCH 1/2] avformat/matroskaenc: also write chapters when output is WebM

2017-06-01 Thread James Zern
On Thu, Jun 1, 2017 at 7:51 PM, James Almer wrote: > WebM supports a subset of elements from the Chapters master. > See https://www.webmproject.org/docs/container/#chapters > > Addresses ticket #6425 > > Signed-off-by: James Almer > --- >

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-28 Thread James Zern
On Thu, Apr 20, 2017 at 3:06 PM, James Zern <jz...@google.com> wrote: > On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: >> Hi, >> >> On Thu, Apr 20, 2017 at 2:42 PM, James Zern <jzern-at-google@ffmpeg.org> >> wrote:

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-20 Thread James Zern
On Thu, Apr 20, 2017 at 1:42 PM, Ronald S. Bultje <rsbul...@gmail.com> wrote: > Hi, > > On Thu, Apr 20, 2017 at 2:42 PM, James Zern <jzern-at-google@ffmpeg.org> > wrote: > >> On Thu, Apr 13, 2017 at 6:44 PM, James Zern <jz...@google.com> wrote: >> &

Re: [FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-20 Thread James Zern
On Thu, Apr 13, 2017 at 6:44 PM, James Zern <jz...@google.com> wrote: > this was added in 1.6.0 > > Signed-off-by: James Zern <jz...@google.com> > --- > doc/encoders.texi | 2 +- > libavcodec/libvpxenc.c | 3 ++- > 2 files changed, 3 insertions(+), 2 dele

Re: [FFmpeg-devel] [PATCH] doc/encoders.texi: document libvpxenc's -row-mt

2017-04-18 Thread James Zern
On Mon, Apr 17, 2017 at 5:06 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Thu, Apr 13, 2017 at 06:53:26PM -0700, James Zern wrote: >> added in: >> 734d760e2f lavc/libvpxenc: add -row-mt option >> >> Signed-off-by: James Zern <jz...@google.c

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest: Add option to specify bandwidth

2017-04-17 Thread James Zern
On Thu, Apr 13, 2017 at 6:20 PM, James Zern <jz...@google.com> wrote: > On Tue, Apr 11, 2017 at 9:33 PM, Vignesh Venkatasubramanian > <vigneshv-at-google@ffmpeg.org> wrote: >> Add an option to webm_dash_manifest demuxer to specify a value for >> "ba

[FFmpeg-devel] [PATCH] doc/encoders.texi: document libvpxenc's -row-mt

2017-04-13 Thread James Zern
added in: 734d760e2f lavc/libvpxenc: add -row-mt option Signed-off-by: James Zern <jz...@google.com> --- doc/encoders.texi | 2 ++ 1 file changed, 2 insertions(+) diff --git a/doc/encoders.texi b/doc/encoders.texi index 594c612b5a..7f4754d160 100644 --- a/doc/encoders.texi +++

[FFmpeg-devel] [PATCH] libvpxenc: allow aq-mode 4 (equator360)

2017-04-13 Thread James Zern
this was added in 1.6.0 Signed-off-by: James Zern <jz...@google.com> --- doc/encoders.texi | 2 +- libavcodec/libvpxenc.c | 3 ++- 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/encoders.texi b/doc/encoders.texi index 594c612b5a..f8f187664c 100644 --- a/doc/encoder

Re: [FFmpeg-devel] [PATCH] webm_dash_manifest: Add option to specify bandwidth

2017-04-13 Thread James Zern
On Tue, Apr 11, 2017 at 9:33 PM, Vignesh Venkatasubramanian wrote: > Add an option to webm_dash_manifest demuxer to specify a value for > "bandwidth" field in the DASH manifest. The value is then used by > the muxer. Fixes an existing FIXME in the code. > >

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-06 Thread James Zern
On Fri, Mar 3, 2017 at 4:52 PM, James Zern <jz...@google.com> wrote: > On Fri, Mar 3, 2017 at 2:20 AM, Kagami Hiiragi <kag...@genshiken.org> wrote: >> [...] >> >> Updated. I don't think -slices would fit logically because -row-mt is >> boolean and -slic

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-03 Thread James Zern
On Fri, Mar 3, 2017 at 2:20 AM, Kagami Hiiragi wrote: > [...] > > Updated. I don't think -slices would fit logically because -row-mt is boolean > and -slices is integer. > > --- > libavcodec/libvpxenc.c | 11 +++ > 1 file changed, 11 insertions(+) > Looks all

Re: [FFmpeg-devel] [PATCH] lavc/libvpxenc: add -row-mt option

2017-03-02 Thread James Zern
On Thu, Mar 2, 2017 at 11:00 AM, Kagami Hiiragi wrote: > From ae3856c302284d60761c3ad122ff49b7b9b68114 Mon Sep 17 00:00:00 2001 > From: Kagami Hiiragi > Date: Thu, 2 Mar 2017 21:19:09 +0300 > Subject: [PATCH] lavc/libvpxenc: add -row-mt option > > ---

Re: [FFmpeg-devel] [PATCH] libvpxenc: Don't spam level errors for VP8 encodes

2016-12-12 Thread James Zern
On Mon, Dec 12, 2016 at 12:12 PM, Alex Converse wrote: > Fixes "Failed to set VP9E_GET_LEVEL codec control: Codec does not > implement requested capability" log messages on VP8 encodes. > --- > libavcodec/libvpxenc.c | 3 ++- > 1 file changed, 2 insertions(+), 1

Re: [FFmpeg-devel] [PATCH] libvpxenc: Report encoded VP9 level

2016-11-28 Thread James Zern
On Mon, Nov 28, 2016 at 10:34 AM, Alex Converse wrote: > Report the actual level of the encoded output if a level is > targeted or the level is passively tracked with a target of 0. > --- > libavcodec/libvpxenc.c | 32 > 1 file changed,

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-28 Thread James Zern
On Mon, Nov 28, 2016 at 10:32 AM, Alex Converse <alex.conve...@gmail.com> wrote: > On Tue, Nov 22, 2016 at 3:10 PM, James Zern <jz...@google.com> wrote: >> On Tue, Nov 22, 2016 at 12:08 PM, James Zern <jz...@google.com> wrote: >>> On Tue, Nov 22, 2016 at 12

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:08 PM, James Zern <jz...@google.com> wrote: > On Tue, Nov 22, 2016 at 12:04 PM, James Zern <jz...@google.com> wrote: >> On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse <alex.conve...@gmail.com> >> wrote: >>> Report the act

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Tue, Nov 22, 2016 at 12:04 PM, James Zern <jz...@google.com> wrote: > On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse <alex.conve...@gmail.com> > wrote: >> Report the actual level of the encoded output if a level is >> targeted or the level is passiv

Re: [FFmpeg-devel] [PATCH 2/2] libvpxenc: Report encoded VP9 level

2016-11-22 Thread James Zern
On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse wrote: > Report the actual level of the encoded output if a level is > targeted or the level is passively tracked with a target of 0. > --- > libavcodec/libvpxenc.c | 31 +++ > 1 file changed, 31

Re: [FFmpeg-devel] [PATCH 1/2] libvpxenc: Support targeting a VP9 level

2016-11-18 Thread James Zern
On Fri, Nov 18, 2016 at 2:01 PM, Alex Converse wrote: > Levels are specified at https://www.webmproject.org/vp9/levels/ > --- > libavcodec/libvpxenc.c | 10 ++ > 1 file changed, 10 insertions(+) > lgtm > diff --git a/libavcodec/libvpxenc.c

Re: [FFmpeg-devel] [PATCH] avformat/matroskadec: fix DiscardPadding element parsing

2016-11-07 Thread James Zern
On Sat, Nov 5, 2016 at 1:50 PM, James Almer wrote: > If the value is negative then it means padding at the start of the packet > instead of at the end. > > Based on a patch by Hendrik Leppkes. > > Signed-off-by: James Almer > --- > libavformat/matroskadec.c

  1   2   >