Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-17 Thread Jeremy Luce
It appears that c/C doesn't pause the input threads, which results in higher CPU usage than the 'p' pause method. Also, since the input threads continue to read data, the input buffer will continue to grow, which may lead to undesirable results. I'm not sure if this is by design or not, so I'm

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-16 Thread Jeremy Luce
Here is the updated patch with documentation and proper line breaks. Jeremy On Fri, Mar 13, 2015 at 1:02 PM, Michael Niedermayer michae...@gmx.at wrote: On Wed, Mar 11, 2015 at 08:34:39AM -0500, Jeremy Luce wrote: Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
, Jeremy Luce wrote: Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause transcoding with 'p' key and upause with 'u' key over stdin. Pauses in the main transcode loop as well as the input_thread loop. [...] @@ -3346,7 +3371,9 @@ static int check_keyboard_interaction

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
It's been a couple days, so I wanted to follow up. Would someone mind providing some feedback on this? Thanks! ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-13 Thread Jeremy Luce
than ideal. Jeremy On Fri, Mar 13, 2015 at 11:12 AM, Michael Niedermayer michae...@gmx.at wrote: On Fri, Mar 13, 2015 at 08:34:48AM -0500, Jeremy Luce wrote: It's been a couple days, so I wanted to follow up. Would someone mind providing some feedback on this? Thanks! what is the advantage

[FFmpeg-devel] [PATCH] Add ability to pause transcoding via keyboard interaction

2015-03-12 Thread Jeremy Luce
Resubmitting with [PATCH] tag and unified diff. Adds functionality to pause transcoding with 'p' key and upause with 'u' key over stdin. Pauses in the main transcode loop as well as the input_thread loop. - diff --git a/ffmpeg.c b/ffmpeg.c index 6604ff0..37b351a 100644 ---

[FFmpeg-devel] Add ability to pause transcoding via keyboard interaction

2015-03-12 Thread Jeremy Luce
Useful where ffmpeg is used by applications that transcode on the fly and want to provide some throttling (among other things) From e2f3aa14979675a373a210bd9a028b01a5a0c7eb Mon Sep 17 00:00:00 2001 From: jluce50 jeremyl...@gmail.com Date: Fri, 6 Mar 2015 17:13:40 -0600 Subject: [PATCH 1/4] Add