Re: [FFmpeg-devel] Reimbursement request

2019-10-30 Thread Kieran Kunhya
On Tue, 29 Oct 2019, 05:02 Paul B Mahol, wrote: > On 10/29/19, Steven Liu wrote: > > Hi, > > I'm requesting the reimbursement of travel expenses for the Google Mentor > > Summit. > > I mentored the Derain project, more details can be found in [1]. > > > > > > Flight (CNY) ¥ 7062.00 > >

Re: [FFmpeg-devel] [PATCH v4 2/2] avcodec/v210dec: add the frame and slice threading support

2019-10-13 Thread Kieran Kunhya
> > Michael, I have updated the patch to limit thread_count to [1,1, > avctx->height/4], > why height/4, it's borrowed from dxv.c, please give comments whether it's > proper. > For the lack of big speed improvement, make sure you are giving each thread a slice in order. Kieran

Re: [FFmpeg-devel] Add on-the-fly bitrate adjustment for encoding

2019-10-11 Thread Kieran Kunhya
On Fri, 11 Oct 2019 at 10:16, Moritz Barsnick wrote: > On Thu, Oct 10, 2019 at 09:24:08 -0700, Adrian Cable wrote: > > This is an addition to ffmpeg.c which enables on-the-fly encoder (e.g. > H.264) bitrate adjustment using ffmpeg interactive mode. For example, > specify “-b:v 299k -bufsize

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-23 Thread Kieran Kunhya
> > I agree with your guys. Can I submit a patch to remove AV_PIX_FMT_YUV422P, > it's not belong > to v210 encoder also? It make me misunderstanding it's acceptable to add > other format. > Nope, YUV422P is perfectly fine, it's the correct pixel format, there are no conversions from another

Re: [FFmpeg-devel] [PATCH v1] avcodec/v210enc: add yuv420p/yuv420p10 input pixel format support

2019-09-22 Thread Kieran Kunhya
is exponentiated. Patch rejected Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] blended telecine... possible?

2019-09-04 Thread Kieran Kunhya
On Wed, 4 Sep 2019, 07:34 Kieran O Leary, wrote: > Hi, > > On Wed, 4 Sep 2019, 04:09 Mark Filipak, < > markfilipak.windows+ffm...@gmail.com> wrote: > > > No one has responded. What does that indicate? Lack of interest? Lack of > > knowledge? Lack of time? Shunning of anyone who's not a current >

Re: [FFmpeg-devel] [PATCH 1/1] avcodec/h264: Fix poc_lsb in open gop context

2019-09-02 Thread Kieran Kunhya
On Mon, 2 Sep 2019 at 09:01, Gaullier Nicolas wrote: > >Envoyé : mardi 23 juillet 2019 14:09 > >When no IDR nor mmco_reset is found, prev_poc_lsb is undefined and shall > not be assumed to be zero > >--- > > libavcodec/h264_parse.c | 2 ++ > > libavcodec/h264dec.c| 2 +- > > 2 files changed, 3

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Kieran Kunhya
> > > Lets check H264 > claim "They do not have a timestamp" > immedeatly after the pic_struct field which tells you about the repeating > behavior there is a loop for each repeated value with a timestamp. > This timestamp is lost, if at CFR one can call it that way. > > about "Every encoded frame

Re: [FFmpeg-devel] [PATCH 5/6] avcodec/qtrle: return last frame even if unchanged

2019-08-26 Thread Kieran Kunhya
> > "time of origin, capture" is clearly a timecode, not a timestamp in > the sense we're talking about here (plus that the bitstream codes it > in hours/minutes/seconds). I expect you know the difference. > If these timecodes are considered useful it would be trivial to expose > them from the

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/mpeg4videodec: Fix integer overflow in mpeg4_decode_studio_block()

2019-08-23 Thread Kieran Kunhya
On Thu, 22 Aug 2019 at 23:55, Michael Niedermayer wrote: > Fixes: signed integer overflow: 24023040 * 112 cannot be represented in > type 'int' > Fixes: > 16570/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5173275211071488 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Kieran Kunhya
On Tue, 20 Aug 2019 at 18:06, Michael Niedermayer wrote: > On Tue, Aug 20, 2019 at 05:09:51PM +0100, Kieran Kunhya wrote: > > On Tue, 20 Aug 2019 at 14:16, Carl Eugen Hoyos > wrote: > > > > > Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol < > one...@g

Re: [FFmpeg-devel] [REQUEST] avcodec/scpr: revert d70276921348

2019-08-20 Thread Kieran Kunhya
On Tue, 20 Aug 2019 at 14:16, Carl Eugen Hoyos wrote: > Am Di., 20. Aug. 2019 um 14:48 Uhr schrieb Paul B Mahol >: > > > I kindly ask that following commit: > d702769213487923c0fb0abe4b61f4d9ebddb88b > > I still believe what the patch does is a very good idea and a revert would > hurt FFmpeg. >

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/h264_parser: Reuse the RBSP buffer

2019-08-16 Thread Kieran Kunhya
On Fri, 16 Aug 2019 at 06:08, Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Kieran Kunhya: > > On Fri, 16 Aug 2019 at 04:20, Andreas Rheinhardt < > > andreas.rheinha...@gmail.com> wrote: > > > >> Up until now, the H.264 parser has allocated

Re: [FFmpeg-devel] [PATCH 05/11] avcodec/h264_parser: Reuse the RBSP buffer

2019-08-15 Thread Kieran Kunhya
On Fri, 16 Aug 2019 at 04:20, Andreas Rheinhardt < andreas.rheinha...@gmail.com> wrote: > Up until now, the H.264 parser has allocated a new buffer for every > frame in order to store the unescaped RBSP in case the part of the RBSP > that will be unescaped contains 0x03 escape bytes. This is

Re: [FFmpeg-devel] [PATCH 1/2] avutil: Add Simple loop detector

2019-08-08 Thread Kieran Kunhya
> > You argue that it does not NEED to be in lavu, but not that it SHOULD > note. > > > Plus, its not really common av code, and don't let its name mislead > > you, its more of a hack. > > I will disregard the insulting subtext of this sentence. > There is nothing insulting about this sentence.

Re: [FFmpeg-devel] [PATCH v3] avformat/rtpdec_rfc4175: Fix incorrect copy_offset calculation

2019-08-05 Thread Kieran Kunhya
On Mon, 5 Aug 2019 at 17:10, Michael Niedermayer wrote: > On Thu, Jun 27, 2019 at 06:06:22AM +, Jacob Siddall wrote: > > The previous calculation code did not account for the fact that the > > copy_offset for the start of the frame array is at index 0, yet the > > scan line number from the

Re: [FFmpeg-devel] [RFC] samples.ffmpeg.org

2019-08-04 Thread Kieran Kunhya
On Sat, 3 Aug 2019 at 18:35, Michael Niedermayer wrote: > Hi all > > It seems we do not have a list of people volunteering to do uploads to > samples. And no place to send such requests to except here, where they > sometimes get ignored. > Just give everyone with push access right to upload.

Re: [FFmpeg-devel] [PATCH] avcodec/rl2: set dimensions

2019-07-23 Thread Kieran Kunhya
> > What was the cause of the slow decoding? Does this actually fix it, or > does it just swipe it "under the carpet"? > If someone ever found a sample with a different solution, how would they > know that they shouldn't just remove this again? Without any kind of > comment on the point of this

Re: [FFmpeg-devel] [PATCH v1] Config files for NetBeans IDE

2019-07-05 Thread Kieran Kunhya
I would ignore what Paul says and perhaps start a Github project with your patch. I think it would be useful for developers using the NetBeans IDE. Kieran On Fri, 5 Jul 2019 at 23:33, Paul B Mahol wrote: > If this is meant to be applied to our tree I'm against. > We do not need this bloat. > >

Re: [FFmpeg-devel] [PATCH] avcodec/cfhd: add back alpha processing removed in 9cefb9e7ec

2019-06-29 Thread Kieran Kunhya
On Sat, 29 Jun 2019 at 08:09, Paul B Mahol wrote: > Fixes #7886. > > Signed-off-by: Paul B Mahol > --- > libavcodec/cfhd.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index 846d334b9b..49a5a2c30a 100644 > --- a/libavcodec/cfhd.c > +++

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Kieran Kunhya
> > If it is so easy, you could do it instead of arguing. If it is not so > easy, you cannot demand somebody do it. > I'm happy to do it now that I am aware of the issue. I will do it when I am at home in a few days. > > It is beyond comprehension how removing more code and making the >

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Kieran Kunhya
On Thu, 27 Jun 2019 at 20:52, Nicolas George wrote: > Kieran Kunhya (12019-06-27): > > Why can this not be fixed properly? > > It can. If you have time and motivation to do it, please go ahead. > Barring that, removing dead code is still an improvement. > > Regard

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Kieran Kunhya
On Thu, 27 Jun 2019 at 20:01, Nicolas George wrote: > Andreas Rheinhardt (12019-06-27): > > The code is indeed dead atm. To quote myself from ticket 7886: > > "Commit c64c97b972c7325a71440a352a7d541a8c92b2da has added support for > > alpha channel decoding in Cineform HD (thereby fixing #6265),

Re: [FFmpeg-devel] [PATCH] avcodec/pngdec: Check input space

2019-05-14 Thread Kieran Kunhya
On Tue, 14 May 2019 at 20:42, Michael Niedermayer wrote: > Fixes: Timeout (33sec -> 78ms) > Fixes: > 14668/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_LSCR_fuzzer-5767073352908800 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-08 Thread Kieran Kunhya
> > if you dont return 3 fields you break the normative specification. This > speaks > about the "output of the decoding process" not how to interpret the output. > > I bring MPEG2 up here because we dont do what the normative spec says > because it doesnt make sense for us. It does make sense if

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-03 Thread Kieran Kunhya
> > > Kieran, > > Can you point to evidence on the same? An active legal threat to "a > developer writing an open source implementation of NDI"? > > With that in place, it wouldn't be ignored as a material fact, would it? > https://trac.ffmpeg.org/ticket/7589 Discussed in there. A few people in

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-03 Thread Kieran Kunhya
On Fri, 3 May 2019, 06:27 Jeyapal, Karthick, wrote: > > On Sun, Apr 28, 2019 at 4:02 PM Marton Balint wrote: > > > (In this case, NDI plugin is already open source). This is untrue. Furthermore, I am amazed you are all ignoring the fact this is an Open Source hostile company, actively

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Kieran Kunhya
> > [1] http://lists.ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242574.html There are numerous inactive people in the voting committee, some for years. Why are they arbitrarily allowed to vote on this? Kieran ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] News: Removal of libndi

2019-03-25 Thread Kieran Kunhya
On Mon, 25 Mar 2019 at 13:56 Kieran Kunhya wrote: > On Mon, 25 Mar 2019 at 13:02 Yufei He wrote: > >> Hardware codecs and software codecs are taking different responsibilities. >> >> Thanks a lot. >> >> Yufei. >> > > Hi, > > You should

Re: [FFmpeg-devel] [PATCH] News: Removal of libndi

2019-03-25 Thread Kieran Kunhya
On Mon, 25 Mar 2019 at 13:02 Yufei He wrote: > Hardware codecs and software codecs are taking different responsibilities. > > Thanks a lot. > > Yufei. > Hi, You should expose the APIs to the hardware, people will buy more of them if they can program the chip to do things as they want. I

Re: [FFmpeg-devel] AVPixelFormat for YUYV 10 bit.

2019-03-25 Thread Kieran Kunhya
On Mon, 25 Mar 2019 at 13:53 Yufei He wrote: > Hi > > I think there may be one format missing in AVPixelFormat. > > AV_PIX_FMT_YUYV210 > For various reasons v210 and friends are implemented as a codec in FFmpeg. Kieran ___ ffmpeg-devel mailing list

[FFmpeg-devel] [PATCH] News: Removal of libndi

2019-03-19 Thread Kieran Kunhya
0001-News-Removal-of-libndi.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/mpeg4videodec: Check idx in mpeg4_decode_studio_block()

2019-03-11 Thread Kieran Kunhya
On Sun, 10 Mar 2019 at 04:43 Michael Niedermayer wrote: > Fixes: Out of array access > Fixes: > 13500/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5769760178962432 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] lavd: Remove libndi_newtek

2019-03-09 Thread Kieran Kunhya
They have not responded to any communications: https://trac.ffmpeg.org/ticket/7589 Kieran 0001-lavd-Remove-libndi_newtek.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] avcodec/mpeg4videodec: Clear interlaced_dct for studio profile

2019-02-15 Thread Kieran Kunhya
ok On Fri, 15 Feb 2019 at 00:58 Michael Niedermayer wrote: > Fixes: Out of array access > Fixes: > 13090/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5408668986638336 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg >

[FFmpeg-devel] [PATCH] vf_showinfo: Fix timecode display

2019-01-24 Thread Kieran Kunhya
$subj - Indexing is wrong, off by one Kieran 0001-vf_showinfo-Fix-timecode-display.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avcodec/rscc: Avoid returning frames that have nearly no undamaged pixels in them

2019-01-16 Thread Kieran Kunhya
On Thu, 17 Jan 2019 at 00:44 Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 12192/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > > Before: > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RSCC_fuzzer-6279038004363264 > in 15423 ms > After: >

Re: [FFmpeg-devel] Transparency of sponsored works (was: avcodec: add photocd decoder)

2019-01-11 Thread Kieran Kunhya
On Fri, 11 Jan 2019 at 15:31 Nicolas George wrote: > Carl Eugen Hoyos (12019-01-11): > > I believe amount is never published (so far at least afair). > > I think it should. I wonder what other people think. > Are you completely out of your mind? Rega

Re: [FFmpeg-devel] [PATCH 1/3] avutil/imgutils: Optimize writing 4 bytes in memset_bytes()

2018-12-25 Thread Kieran Kunhya
On Tue, 25 Dec 2018 at 22:17 Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 11502/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > Before: Executed > clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_WCMV_fuzzer-5664893810769920 > in 11294 ms > After :

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/lagarith: Optimize case with singleton probability distribution

2018-12-24 Thread Kieran Kunhya
> > commit 0ca7a8deeffd33e05ae15a447259b32b6678c727 (HEAD -> master) > Author: Michael Niedermayer > Date: Mon Dec 24 01:14:50 2018 +0100 > > avcodec/lagarith: Optimize case with singleton probability distribution > > Fixes: Timeout > Fixes: >

Re: [FFmpeg-devel] [RFC] VDD FFmpeg session and community survey

2018-11-23 Thread Kieran Kunhya
> > > What if a majority of the committee is biased and bans everyone they > disagree with to take over the project? They certainly could. > What if the committee's decision is something the majority of the > developers disagree with? > > This is why I'm against formalizing such prodecures.

[FFmpeg-devel] Fwd: [OpenMedia] FOSDEM 2019 Open Media room - Call for speakers participation

2018-11-01 Thread Kieran Kunhya
-- Forwarded message - From: Zohar Babin Date: Fri, 12 Oct 2018 at 12:50 Subject: [OpenMedia] FOSDEM 2019 Open Media room - Call for speakers participation To: FOSDEM , Open Media devroom < open-media-devr...@lists.fosdem.org> Hi all, Join us on February 2, 2019 in Brussels for

[FFmpeg-devel] [PATCH] mpeg4video: Add SStP FATE test

2018-09-22 Thread Kieran Kunhya
0001-mpeg4video-Add-SStP-FATE-test.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv2] mpeg4video: Add Studio DPCM support

2018-08-23 Thread Kieran Kunhya
0001-mpeg4video-Add-Studio-DPCM-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add Studio DPCM support

2018-08-22 Thread Kieran Kunhya
On Wed, 22 Aug 2018 at 10:44 Carl Eugen Hoyos wrote: > 2018-08-22 1:29 GMT+02:00, Kieran Kunhya : > > $subj > > Please split the re-indentation and please fix the indentation of "else". > Would you mind explaining th

[FFmpeg-devel] [PATCH] mpeg4video: Add Studio DPCM support

2018-08-21 Thread Kieran Kunhya
$subj Depends on Michael's patch. I have a FATE sample frame. 0001-mpeg4video-Add-Studio-DPCM-support.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [GSOC][PATCH 2/3] lavc/cfhd:corrected decompanding for table 9 used in cfhd

2018-08-15 Thread Kieran Kunhya
On Tue, 14 Aug 2018 at 08:43 Gagandeep Singh wrote: > Second patch for fixing decompanding in table 9. > > Gagandeep Singh > Seems ok Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] Sponsoring request

2018-07-19 Thread Kieran Kunhya
On Thu, 19 Jul 2018 at 14:04 Paul B Mahol wrote: > Hi, > > I want that FFmpeg community sponsor addition of new code I gonna > develop in following days/months. > > Thanks. > What code? I am happy to sponsor cleanup of libavfilter to be usable outside of ffmpeg.c and in a realtime environment.

Re: [FFmpeg-devel] [PATCH 2/2] avcodec/cfhd: Use bytestream2 for peaks

2018-07-15 Thread Kieran Kunhya
On Sat, 14 Jul 2018 at 00:14 Michael Niedermayer wrote: > This fixes out of array accesses > No testcase known > > Signed-off-by: Michael Niedermayer > Looks ok if Gagandeep is ok Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [GSOC][PATCH] lavc/cfhd:IP frame decoding (inverse 3d transform) introduced

2018-05-31 Thread Kieran Kunhya
Hi On Thu, 31 May 2018 at 12:25 Gagandeep Singh wrote: > --- > libavcodec/cfhd.c | 462 > ++ > libavcodec/cfhd.h | 15 +- > 2 files changed, 411 insertions(+), 66 deletions(-) > > diff --git a/libavcodec/cfhd.c b/libavcodec/cfhd.c > index

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: deinterlacing introduced in cfhd

2018-05-21 Thread Kieran Kunhya
> > +static inline void interlaced_vertical_filter(int16_t *output, int16_t > *low, int16_t *high, > + int width, int linesize, int plane) > +{ > +int i; > +int16_t even, odd; > +for (i = 0; i < width; i++) { > + even = (*low - *high)/2; > + odd =

Re: [FFmpeg-devel] [PATCH] lavc/cfhd: deinterlacing introduced in cfhd

2018-05-21 Thread Kieran Kunhya
Not really "deinterlacing", it would be "add interlaced file support" or similar. On Mon, 21 May 2018 at 20:17 Gagandeep Singh wrote: > +static inline void peak_table(int16_t *band, Peak *peak, int length) > +{ > +int i; > +for (i = 0; i < length; i++) > +

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/mpeg4videode: Eliminate out of loop VOP startcode reading for studio profile

2018-05-02 Thread Kieran Kunhya
> > About the past, it appears to me that there is a deeply rooted aversion by > some people toward some code. This just doesnt belong here. > Correct, mpeg4video decoding is some of the least understandable and undocumented code in the entirety of libavcodec. Decoding spans the following files

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4video: Detect reference studio streams as studio streams

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 22:57 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4video.h| 2 ++ > libavcodec/mpeg4videodec.c | 25 - > 2 files changed, 18 insertions(+), 9

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/mpeg4videode: Eliminate out of loop VOP startcode reading for studio profile

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 20:20 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 4 > 1 file changed, 4 deletions(-) > > diff --git a/libavcodec/mpeg4videodec.c b/libavcodec/mpeg4videodec.c >

Re: [FFmpeg-devel] [PATCH 1/3] avformat/m4vdec: Fix detection of raw MPEG-4 ES Studio

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 22:57 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavformat/m4vdec.c | 6 ++ > 1 file changed, 6 insertions(+) > > diff --git a/libavformat/m4vdec.c b/libavformat/m4vdec.c > index

Re: [FFmpeg-devel] [PATCH 2/3] avcodec/mpeg4video_parser: Fix incorrect spliting of MPEG-4 studio frames

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 22:57 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4video_parser.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/libavcodec/mpeg4video_parser.c >

Re: [FFmpeg-devel] [PATCH 1/5] avcodec/mpeg4videodec: Move decode_studiovisualobject() parsing in the branch for visual object parsing

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 20:20 Michael Niedermayer wrote: > Fixes: runtime error: shift exponent -1 is negative > Fixes: > 7510/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_MPEG4_fuzzer-5024523356209152 > > Found-by: continuous fuzzing process >

Re: [FFmpeg-devel] [PATCH 4/5] avcodec/mpeg4videodec: Do not corrupt bits_per_raw_sample

2018-04-29 Thread Kieran Kunhya
On Sun, 29 Apr 2018 at 20:20 Michael Niedermayer wrote: > Signed-off-by: Michael Niedermayer > --- > libavcodec/mpeg4videodec.c | 8 +--- > 1 file changed, 5 insertions(+), 3 deletions(-) > OK ___

Re: [FFmpeg-devel] [GSoC] FFserver further development direction

2018-04-25 Thread Kieran Kunhya
On Wed, 25 Apr 2018 at 23:18 Nicolas George wrote: > Josh de Kock (2018-04-25): > > If anything, this should have never been added and a suitable > > external library should have been picked. > > This opinion should have been expressed three years ago. It was decided

Re: [FFmpeg-devel] lavc/mpeg4videodec: Do not ask for samples we already have

2018-04-02 Thread Kieran Kunhya
PCM samples. That one only has a small number of DPCM blocks which I can't even see when playing them back. Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv5] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-04-01 Thread Kieran Kunhya
0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] lavc/cfhd:fixed alpha channel decoding in gbrap12

2018-03-20 Thread Kieran Kunhya
> > ticket #6265, oops forgot this > Can you confirm this makes the png in the ticket look as expected? I was expecting the companding curve to also change for alpha. Kieran ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] Revert "Remove battleforthenet widget"

2018-03-04 Thread Kieran Kunhya
On Sun, 4 Mar 2018 at 22:59 Michael Niedermayer wrote: > On Sun, Mar 04, 2018 at 09:45:03AM -0500, Ronald S. Bultje wrote: > > Hi, > > > > On Sun, Mar 4, 2018 at 9:24 AM, Compn wrote: > > > > > On Thu, 1 Mar 2018 06:59:45 -0500, "Ronald S. Bultje" > > >

Re: [FFmpeg-devel] [PATCH] Revert "Remove battleforthenet widget"

2018-03-04 Thread Kieran Kunhya
On Sun, 4 Mar 2018 at 14:50 Ronald S. Bultje wrote: > Hi, > > On Sun, Mar 4, 2018 at 9:24 AM, Compn wrote: > > > On Thu, 1 Mar 2018 06:59:45 -0500, "Ronald S. Bultje" > > wrote: > > > Again, please: no advertising, no politics. It was

Re: [FFmpeg-devel] FFmpeg 3.5 / 4.0

2018-02-19 Thread Kieran Kunhya
On Mon, 19 Feb 2018 at 16:06 James Almer wrote: > On 2/19/2018 5:54 AM, Paul B Mahol wrote: > > On 2/19/18, James Almer wrote: > >> On 2/18/2018 10:50 PM, Michael Niedermayer wrote: > >>> Hi > >>> > >>> Its 4 months since 3.4 was branched so its time for a

[FFmpeg-devel] [PATCHv4] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-02-10 Thread Kieran Kunhya
$subj. Still depends on simple_idct template patch Fixes crashes in ER 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-28 Thread Kieran Kunhya
Possibly fixed by below patch but frankly the ER code is impenetrable. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-28 Thread Kieran Kunhya
Patch updated to fix threading related crashes, thanks to Paul Mahol for assistance. Also fix segfaults on cut files by disabling unchecked bitstream reading. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data

Re: [FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-27 Thread Kieran Kunhya
Patch updated to possibly fix thread related bug reports. Tsan is better but not perfect. 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH 3/3] avcodec/mpeg4videodec: Avoid possibly aliasing violating casts

2018-01-27 Thread Kieran Kunhya
All 3 ok. ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCHv3] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-27 Thread Kieran Kunhya
Patch updated. Still depends on [PATCH] simple_idct: Template functions to support an input bitdepth parameter. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data ___ ffmpeg-devel mailing list

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Sat, Jan 27, 2018 at 12:33 AM, Michael Niedermayer < mich...@niedermayer.cc> wrote: > On Fri, Jan 26, 2018 at 08:04:39PM +0000, Kieran Kunhya wrote: > > On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer > <mich...@niedermayer.cc > > > wrote: > > >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 10:53 AM, Carl Eugen Hoyos wrote: > 2018-01-22 11:41 GMT+01:00 Marton Balint : > > > Your command line shows gcc 4.7. Maybe this is > > some compiler issue then? > > I can also reproduce the issue with vanilla gcc 6.3.0, > so I don't

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-26 Thread Kieran Kunhya
On Mon, Jan 22, 2018 at 2:07 AM, Michael Niedermayer <mich...@niedermayer.cc > wrote: > On Sun, Jan 21, 2018 at 12:37:21PM +0000, Kieran Kunhya wrote: > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer > <mich...@niedermayer.cc> > > wrote: > > > >

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 10:06 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 22:45 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote: > > > >>

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 2:42 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 15:34 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > >> > >> Only that I can not reproduce without your patch (and that I have > >> never seen this issu

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
> > Only that I can not reproduce without your patch (and that I have > never seen this issue before). > > Carl Eugen > I cannot reproduce this issue with ffplay on Ubuntu Linux. I would recommend running "make distclean" and recompiling. Kieran ___

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:42 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 14:33 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote: > > > >>

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:30 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 14:22 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > Can you reproduce the following issue that I see here? > When testing with ffplay, in ~50% of tries, videos look fine,

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 1:08 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 14:03 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos <ceffm...@gmail.com> > > wrote: > > > >>

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Sun, Jan 21, 2018 at 12:53 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2018-01-21 13:37 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer wrote: > > > >> Hi > > > > Patch upd

Re: [FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2018-01-21 Thread Kieran Kunhya
On Mon, Jan 1, 2018 at 7:01 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > Hi Patch updated. Some of the review comments I decided not to implement in order to keep closer to the spec. Regards, Kieran Kunhya 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-P

[FFmpeg-devel] [PATCH] mpeg4video: Add support for MPEG-4 Simple Studio Profile.

2017-12-29 Thread Kieran Kunhya
$subj I'm not to happy about the s->block2 stuff, there are many ways of trying to resolve this (e.g union), so review welcome. I will add DPCM support in a later (currently unfinished) patch. Kieran 0001-mpeg4video-Add-support-for-MPEG-4-Simple-Studio-Prof.patch Description: Binary data

Re: [FFmpeg-devel] [RFC][PATCH] simple_idct: Template functions to support an input bitdepth parameter

2017-12-27 Thread Kieran Kunhya
On Wed, 27 Dec 2017 at 19:53 Michael Niedermayer wrote: > please call the functions ff_simple_idct_int16_10bit or something that > makes it > clear what the 2 numbers mean. > done > [...] is that faster than checking row 4-7 for 0 with sparse matrixes as occuring > in

[FFmpeg-devel] [RFC][PATCH] simple_idct: Template functions to support an input bitdepth parameter

2017-12-26 Thread Kieran Kunhya
For MPEG-4 Simple Studio Profile, I need to be able to support int32_t input coeffcients to the IDCT functions. I have attempted to implement this with the attached patch. Any comments would be appreciated, I'm pretty sure it is not optimal as-is. Regards, Kieran Kunhya 0001-simple_idct

Re: [FFmpeg-devel] [PATCH] tools/target_dec_fuzzer: Limit error concealment to max_pixels

2017-11-20 Thread Kieran Kunhya
> > On Mon, 20 Nov 2017 at 17:26 Michael Niedermayer > wrote: > Error concealment is time consuming, limiting it in a pixel dependant way > allows > the decoder to be fuzzed with more frames quicker > How is this a reasonable fix considering you have submitted numerous

[FFmpeg-devel] [PATCH 2/2] h264dec: Remove mpegvideo dependency, it's not needed any more

2017-11-18 Thread Kieran Kunhya
$subj 0002-h264dec-Remove-mpegvideo-dependency-it-s-not-needed-.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

[FFmpeg-devel] [PATCH 1/2] libavcodec: Move ff_print_debug_info2 to mpegutils.c.

2017-11-18 Thread Kieran Kunhya
$subj 0001-libavcodec-Move-ff_print_debug_info2-to-mpegutils.c.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org http://ffmpeg.org/mailman/listinfo/ffmpeg-devel

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/snowdec: Check intra block dc differences.

2017-11-16 Thread Kieran Kunhya
On Thu, 16 Nov 2017 at 18:21 Ronald S. Bultje wrote: > We are re-hashing old arguments here. I'm not really interested in that. > > My review comment is and remains: please remove the log msg. Otherwise, the > patch is perfectly fine. > I agree with Ronald's argument. I

Re: [FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 22:33 Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2017-11-04 21:27 GMT+01:00 Kieran Kunhya <kieran...@googlemail.com>: > > > I need to remove MPEG-4 support from mpegvideo in order > > to upstream the following code: > > https://github.

[FFmpeg-devel] [RFC] Removing mpeg4video from mpegvideo

2017-11-04 Thread Kieran Kunhya
a new idct or use an existing (e.g ProRes) if applicable - DPCM mode (a bit like h264's mode) In particular I think this will break lowres. Is this ok or will the patch be blocked? Regards, Kieran Kunhya ___ ffmpeg-devel mailing list ffmpeg-devel

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 4 Nov 2017 at 18:28 Michael Niedermayer wrote: > > The UUID can be corrupt as well. > > We shouldn't be printing random data from the bitstream to the users > > terminal. > > i agree > Ok, I will push unless someone objects. Kieran

Re: [FFmpeg-devel] libavcodec/h264_sei: Don't log random user data.

2017-11-04 Thread Kieran Kunhya
On Sat, 6 May 2017 at 17:51 James Almer wrote: > The proper change here would be to look at the uuid and print only those > known to store printable strings, and of course after making sure they > are in fact printable. > As of now, that means x264's uuid only. > The UUID can

[FFmpeg-devel] PATCH] h2645: Allocate a single buffer per packet. Drastically reduces memory usage on pathological streams.

2017-11-03 Thread Kieran Kunhya
This patch fixes very high memory usage on pathological streams. 0001-h2645-Allocate-a-single-buffer-per-packet.-Drastical.patch Description: Binary data ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH] web/template_head2: Remove net neutrality script

2017-11-03 Thread Kieran Kunhya
On Thu, 2 Nov 2017 at 21:12 Lou Logan wrote: > I would prefer it if the site did not involve politics. > > I implemented a client side solution using an ad blocker, so consider > this patch dropped. > I agree, the popup is annoying. I would like to save the bees, whales,

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-11-02 Thread Kieran Kunhya
> > The idea would be that there would only be one uint8_t buffer and the > 2000 entries from te pool would point into that. > So as a larger NAL shifts through the 2000 the pointers would get > distributed differently but the size would not grow > Any variable size buffer the H2645NAL needs would

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-31 Thread Kieran Kunhya
On Tue, 31 Oct 2017 at 22:36 Niki Bowe wrote: > I was going to prepare a patch, but it sounds like Kieran is going to. > Thank you Kieran. Let me know if there's anything you want me to do, or if > you would prefer me to do it for the experience. > > As for the

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-31 Thread Kieran Kunhya
> > Am I missing something here? > > P.S. I see Kieran mailed the same thing as I wrote this. > Further to Derek's excellent explanation, I think the best way is to go back to the old "in-place" NAL parsing code for H264. I will prepare a patch to do this. Kieran

Re: [FFmpeg-devel] [PATCH] Fix quadratic memory use in ff_h2645_extract_rbsp() when multiple NALUs exist in packet.

2017-10-31 Thread Kieran Kunhya
> > This reduces memory consumption to linear from qudratic but i think > it still can be made to allocate very large amounts of memory. > That is with many small NAL units MAX_MBPAIR_SIZE would be allocated > for each.in worst case. > So this does fix the qudratic issue but not the OOM issue. >

  1   2   3   4   >