Regardless -- it can be left as is . I digress from the topic.
Thank you,
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
> so that seems like a terrible idea that would achieve
> the opposite result.
I respectfully disagree.
Neither approach is universal or POSIX specified.
So while I agree it can be left as-is since only
a basic Bourne shell is needed, I would not just
dismiss it/write it off as a terrible idea.
> +#!/bin/sh
Might I suggest `#!/usr/bin/env sh` instead for this case?
I tend to prefer it from a portability and usability perspective,
but I can imagine for sh it might not matter.
I am not close to the patch that you are working on.
But thought to throw this out there in case there is a
> Is \N a special sequence in ASS-speak
\N is the special line break sequence in ASS
I’m not sure of other special sequences following the \ character, I yield
to Oneric on this question.
Best,
Marth64
___
ffmpeg-devel mailing list
ffmpeg-de
> I'm confused by this, what kind of \N
> sequences might appear in an ASS file?
> Can you show an offending sequence?
Good day Stefano,
The one I tested with was something like :
Jim\Nancy
I made this up while testing. But I have seen similar in real world
scenarios particularly in ASS files
Works for me. Looks great now. Thank you!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
If it's not too late, I thought these fixes would make
the section look nicer for this big release.
---
Changelog | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/Changelog b/Changelog
index a65c8ceee5..7ed638514b 100644
--- a/Changelog
+++ b/Changelog
@@ -40,17 +40,17
Thank you Stefano & all who helped facilitate this through.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
Djikstra is nice
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..734fc65752 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Signed-off-by: Marth64
---
doc/muxers.texi | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index a10a8e216f..c960af1bdc 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3038,19 +3038,18 @@ ogg files can
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/rcwtenc.c b/libavformat/rcwtenc.c
index f2459ef1d3..ed613d45f5 100644
--- a/libavformat/rcwtenc.c
+++ b/libavformat/rcwtenc.c
@@ -159,7 +159,6 @@ static int rcwt_write_trailer
original presentation.
Signed-off-by: Marth64
---
doc/demuxers.texi| 30 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 122 +++
4 files changed, 154 insertions(+)
create mode 100644
happens to pass an empty cue or wants to
use av_get_packet() to read bytes, there are no unnecessary
operations on the packet after it is allocated.
Signed-off-by: Marth64
---
libavformat/subtitles.c | 23 +++
libavformat/subtitles.h | 2 +-
2 files changed, 16 insertions
Since v9:
* Removes .bin extension association in demuxer and muxer
* Updates examples in documentation
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
Sorry for the delay, v11 coming shortly with the fix.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
> i think the entry for extensions should be removed (which fixes this)
> having a ".bin" is not a strong indication that its rcwt
> Is this blocking or can it be addressed later? Also, if this needs to
> be modified the muxer should be as well.
I can address both today in a new set. .bin is
Tomas Härdin :
> once I get my srtdec patchset through there will
> be something to follow.
I see the patch now. I agree, this looks like a good step. Thank you!
> Nah it can be done at a later point as an enhancement if you prefer
Yes, please. I am happy to do it, but I think will be
smoother to
Tomas Härdin:
> Can we please get away from this way of reading subtitles? Every other
> type of media (audio, video) are capable of being streamed, but not
> subtitles, precisely because all of them do all parsing in the
> read_header() call. We have a perfectly good generic index and seeking
>
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..fc14737181 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Signed-off-by: Marth64
---
doc/muxers.texi | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index a10a8e216f..4161401059 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3038,19 +3038,18 @@ ogg files can
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
original presentation.
Signed-off-by: Marth64
---
doc/demuxers.texi| 30 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 123 +++
4 files changed, 155 insertions(+)
create mode 100644
happens to pass an empty cue or wants to
use av_get_packet() to read bytes, there are no unnecessary
operations on the packet after it is allocated.
Signed-off-by: Marth64
---
libavformat/subtitles.c | 23 +++
libavformat/subtitles.h | 2 +-
2 files changed, 16 insertions
Since v7/8:
* Addresses last known feedback (about av_assert call)
* Changelog entry removed, since v7.0 is cut and there is no "next" space yet
(will make patch once available)
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing l
Stefano, v10 coming shortly. Thank you!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Thanks for checking Stefano, I have been behind a bit. I will follow up
with the fix once possible.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
,
Marth64
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
ams are in the source file? We can probe this to some extent,
but what if the eia608 bytes don’t show until halfway through the source?
Open to ideas, thoughts, as I’m gathering my own on this in a notebook over
the past few weeks.
Respectfully,
Marth64
___
ffm
Recent advice plus my own experience agree that this pattern
is error-prone. Instead, set `ret` in its own line and do
the error validation after. Also, explicitly return 0 on success
in dvdvideo_chapters_setup_preindex()
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 132
Ping on this set authored by Oneric as well.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Was already applied. Thanks Stefano and Leo!
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> is the move needed? (but not blocking)
It is not needed, but the code flows better I think in terms of
readability. I think it feels cleaner to say, "set up `sub` then add it to
the array" vs. "set up sub's data, add it to the array, then set up its
other fields". But, I am good either way and
Ping if possible. The patches still apply. 3 of the 5 patches are
documentation only and the demuxer itself is much smaller now. The muxer
already made it in, so was hoping the demuxer could go too :fingers_crossed:
___
ffmpeg-devel mailing list
This should be withheld until after 7.0. In the same bug report it appears
that 1 user is making use of the erroneous tags via an external script for
a valid purpose. I don’t want to break people’s workflow even though it’s
invalid ASS.
After 7.0 I will revive this patchset and with additional
This also fixes https://trac.ffmpeg.org/ticket/10927 (recently reported by
a user)
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
I had actually applied this patch while looking into a ticket near the same
code path. LGTM.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
v2 on the way.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Since log statements printing int64 were made portable in
4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
inttypes.h explicitly (as it is unclear where PRId64 and
such are coming from now).
Reported-by: Traneptora
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 2 ++
1 file
Will send v2 with fix. I actually prefer it, I wasn't sure if it would be
seen the same way.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
accordingly.
Signed-off-by: Marth64
---
libavcodec/ccaption_dec.c | 34 ++--
tests/ref/fate/ffmpeg-fix_sub_duration| 14 +-
.../fate/ffmpeg-fix_sub_duration_heartbeat| 16 +-
tests/ref/fate/sub-cc | 10 +-
tests/ref/fate/sub-cc-realtime
.
Signed-off-by: Marth64
---
libavcodec/ccaption_dec.c | 13 ++-
tests/ref/fate/sub-cc | 2 +-
tests/ref/fate/sub-cc-realtime | 8 +-
tests/ref/fate/sub-cc-scte20 | 4 +-
tests/ref/fate/sub-scc | 146 -
5 files changed, 91 insertions
Since v3:
* Added trace logging of coordinates (requested in feedback)
* Improved calculation of coordinates by using NTSC base resolution
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..fc14737181 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Signed-off-by: Marth64
---
doc/muxers.texi | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index a10a8e216f..4161401059 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -3038,19 +3038,18 @@ ogg files can
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
original presentation.
Signed-off-by: Marth64
---
Changelog| 2 +-
doc/demuxers.texi| 30 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 123 +++
5 files changed, 156
happens to pass an empty cue or wants to
use av_get_packet() to read bytes, there are no unnecessary
operations on the packet after it is allocated.
Signed-off-by: Marth64
---
libavformat/subtitles.c | 24
libavformat/subtitles.h | 2 +-
2 files changed, 17 insertions
Since v7/8:
* Simplified demuxer error handling logic
* Fixes buggy change to ff_subtitles_queue_insert()
* Documentation improvements
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman
Since log statements printing int64 were made portable in
4464b7eeb194e98ac115f18d2b6be67361407c8a, let us include
inttypes.h explicitly (as it is unclear where PRId64 and
such are coming from now).
Reported-by: Traneptora
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 1 +
1 file
Thank you Andreas, for walking me through this in detail.
I will update accordingly and test.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
original presentation.
Signed-off-by: Marth64
---
Changelog| 2 +-
doc/demuxers.texi| 30 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 125 +++
5 files changed, 158
This is in response to the last paragraph of feedback in
https://ffmpeg.org//pipermail/ffmpeg-devel/2024-March/323858.html
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..fc14737181 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Signed-off-by: Marth64
---
doc/muxers.texi | 29 +++--
1 file changed, 19 insertions(+), 10 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index d9dd72e613..0695a317d4 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -2987,19 +2987,18 @@ ogg files can
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
original presentation.
Signed-off-by: Marth64
---
Changelog| 2 +-
doc/demuxers.texi| 30 ++
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 123 +++
5 files changed, 156
, if a subtitle demuxer happens to pass an empty
cue or wants to use av_get_packet() to read bytes, there
are no unnecessary operations on the packet after it is
allocated.
Signed-off-by: Marth64
---
libavformat/subtitles.c | 4
libavformat/subtitles.h | 2 +-
2 files changed, 5 insertions(+), 1
Since v7:
* Demuxer is simplified, reduced to 92 LOC
* Documentation feedback addressed
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit
> what is ASSA?
This should just be ASS, will update
> let's expand SCC
> for the sake of exclicitness, I'd avoid more acronyms, I'd guess this
> is source Closed Caption?
Actually SCC is a format itself (Scenarist Closed Caption) of which FFmpeg
has a muxer and demuxer.
SCC is one of the
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..fc14737181 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Signed-off-by: Marth64
---
doc/demuxers.texi | 26 ++
doc/muxers.texi | 29 +++--
2 files changed, 45 insertions(+), 10 deletions(-)
diff --git a/doc/demuxers.texi b/doc/demuxers.texi
index b70f3a38d7..47e82eda55 100644
--- a/doc/demuxers.texi
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
to this, the next best solution was FFmpeg's SCC muxer, but SCC itself
is not compatible with ccextractor (which is a de facto OSS CC processing tool)
and it is a proprietary format.
Tests will follow.
Signed-off-by: Marth64
---
Changelog| 2 +-
libavformat/Makefile | 1 +
libavformat
Since v5:
* probe check is more strict, passes probetest fuzz
* documentation typos
Signed-off-by: Marth64
--
2.34.1
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
Yes, v6 is on the way with fix (validated working with probetest parameters
above). I can check the format version, of which there is only 1 known
version.
Thanks for catching this.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
Hi Oneric,
I was able to validate the whole set. Here are the tests I did ...
(1) test conversion from vtt->ass with bidi mark and visually check display
-- pass
(2) test slash escape fix with a string e.g. \\Nancy, verify broken before
and fixed by patch -- pass
(3) test curly brace escape fix
Signed-off-by: Marth64
---
doc/indevs.texi | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/doc/indevs.texi b/doc/indevs.texi
index d1b2bacf8b..fc14737181 100644
--- a/doc/indevs.texi
+++ b/doc/indevs.texi
@@ -1069,9 +1069,9 @@ ffplay -f lavfi
"movie=test.avi[out0];a
Signed-off-by: Marth64
---
doc/muxers.texi | 25 +
1 file changed, 17 insertions(+), 8 deletions(-)
diff --git a/doc/muxers.texi b/doc/muxers.texi
index d9dd72e613..9e8de3dc42 100644
--- a/doc/muxers.texi
+++ b/doc/muxers.texi
@@ -2987,16 +2987,15 @@ ogg files can
The high level summary of RCWT can be delegated doc/muxers, which
makes it easier to maintain and more consistent with the documentation
of the demuxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 5 -
1 file changed, 5 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat
Signed-off-by: Marth64
---
Changelog| 2 +-
doc/demuxers.texi| 29
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat/rcwtdec.c| 148 +++
5 files changed, 180 insertions(+), 1 deletion
Thank you, v5 on the way with documentation updates and examples.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with
Bump on this small demuxer if possible. v4 in the last reply. Thank you.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org
to this, the next best solution was FFmpeg's SCC muxer, but SCC itself
is not compatible with ccextractor (which is a de facto OSS CC processing tool)
and it is a proprietary format.
Tests will follow.
Signed-off-by: Marth64
---
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat
Hi Stefano,
I would like to withdraw this patch for now.
I have found content where this breaks center
justified text further (which is already not supported).
I will instead try to implement center justification
and incorporate this through that route.
Please ignore it.
Thank you for
I get it now. Disregard patch. Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
> The code block changes str and str is later accessed (via splitconf).
Sorry, for the lack of awareness, but I am confused how.
strstr() shouldn't modify the string right?
The only change I see is in the unused remove_tilde[]
Thank you, for taking a look and explaining.
races back to 69cf626f9c1ba29e66ff62e2b835dcfc3031db8d
and even there, I cannot find a purpose for it.
Remove the variable and it's related loop where the assignment occurs,
which resolves the warning.
Signed-off-by: Marth64
---
fftools/opt_common.c | 8 +---
1 file changed, 1 insertion(+), 7
I have not interacted with this user and I am just a mediocre contributor.
But from my experience running forums and IRC networks in the past,
this always ends in one process...
1. toxic user comes along
2. upsets people repeatedly, which also wastes time
3. admins ponder ban, which
> SEGA FILM (.cpk) muxer.
> This format was used as internal format for several SEGA games.
> For more information regarding the Sega FILM file format
(trivial nit) Sega should be capitalized SEGA I believe, this would make it
consistent in all 3 lines.
But it's still fine.
LGTM.
LGTM
On Tue, Mar 12, 2024 at 4:01 PM Stefano Sabatini wrote:
> ---
> doc/muxers.texi | 11 +++
> 1 file changed, 11 insertions(+)
>
> diff --git a/doc/muxers.texi b/doc/muxers.texi
> index de4b9b01f5..64d9221198 100644
> --- a/doc/muxers.texi
> +++ b/doc/muxers.texi
> @@ -1612,6
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 15 ---
1 file changed, 8 insertions(+), 7 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index a182f95097..761ac97ec6 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
Fix on the way with PRId64
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index a182f95097..19efc068cb 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -392,7 +392,7
v2 on the way
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
a particular
source.
Signed-off-by: Marth64
---
libavcodec/mpeg12dec.c | 64 --
1 file changed, 61 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index 3a2f17e508..4ad1eb6572 100644
--- a/libavcodec/mpeg
Signed-off-by: Marth64
---
libavformat/dvdvideodec.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/libavformat/dvdvideodec.c b/libavformat/dvdvideodec.c
index a182f95097..0ae2110cd2 100644
--- a/libavformat/dvdvideodec.c
+++ b/libavformat/dvdvideodec.c
@@ -423,7 +423,7
Will address, thanks for the review.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".
Signed-off-by: Marth64
---
libavformat/sccdec.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/libavformat/sccdec.c b/libavformat/sccdec.c
index 5f2f95d80e..f6d5f29a0a 100644
--- a/libavformat/sccdec.c
+++ b/libavformat/sccdec.c
@@ -24,7 +24,6 @@
#include "internal.h"
#include &q
to this, the next best solution was FFmpeg's SCC muxer, but SCC itself
is not compatible with ccextractor (which is a de facto OSS CC processing tool)
and it is a proprietary format.
Tests will follow.
Signed-off-by: Marth64
---
libavformat/Makefile | 1 +
libavformat/allformats.c | 1 +
libavformat
similarly to this muxer.
Signed-off-by: Marth64
---
libavformat/rcwtenc.c | 21 +++--
1 file changed, 7 insertions(+), 14 deletions(-)
diff --git a/libavformat/rcwtenc.c b/libavformat/rcwtenc.c
index a6060ba7c4..ed72de81ef 100644
--- a/libavformat/rcwtenc.c
+++ b/libavformat/rcwtenc.c
@@
hex code in the entry table to match
casing of the other hex codes.
Signed-off-by: Marth64
---
libavcodec/ccaption_dec.c | 9 ++---
1 file changed, 6 insertions(+), 3 deletions(-)
diff --git a/libavcodec/ccaption_dec.c b/libavcodec/ccaption_dec.c
index 9d4a93647c..25b0f2e064 100644
CCs in a bit-exact way from both ffmpeg and ccextractor.
The added benefit is this allows for easy archival of CCs
for later processing.
(6) Fix an unused include in SCC demuxer
FATE tests pass.
There is still more to do, I will slowly work on this.
Thank you,
Signed-off-by: Marth64
in a cue is honored by ASS anyway.
Don't write multiple \an and \pos tags.
Also, update tests accordingly.
Signed-off-by: Marth64
---
libavcodec/ccaption_dec.c | 8 +-
tests/ref/fate/sub-cc | 2 +-
tests/ref/fate/sub-cc-realtime | 8 +-
tests/ref/fate/sub-cc-scte20 | 4 +-
tests
a particular
source.
Signed-off-by: Marth64
---
libavcodec/mpeg12dec.c | 67 --
1 file changed, 64 insertions(+), 3 deletions(-)
diff --git a/libavcodec/mpeg12dec.c b/libavcodec/mpeg12dec.c
index 3a2f17e508..8961a290a3 100644
--- a/libavcodec/mpeg
I am working on an improved patchset to consolidate these patches, also
address feedback and other improvements. Will submit soon, thank you!
On Mon, Mar 11, 2024 at 11:38 AM Stefano Sabatini
wrote:
> On date Sunday 2024-03-10 19:44:11 -0500, Marth64 wrote:
> > In Closed Captions (US)
Thanks, will follow up with a v3 set (consolidating/resolving feedback on
the other CC fixes as well).
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
Agreed on both points, I will address them. Thanks.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link above, or email
ffmpeg-devel-requ...@ffmpeg.org with subject
> This breaks fate
Looking into it - thanks.
PS, sorry for previous top-posting in replies. Will be more cautious of
that.
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
https://ffmpeg.org/mailman/listinfo/ffmpeg-devel
To unsubscribe, visit link
1 - 100 of 281 matches
Mail list logo
