Re: [FFmpeg-devel] [PATCH v3 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-22 Thread Marton Balint
On Sun, 21 Jul 2019, lance.lmw...@gmail.com wrote: From: Limin Wang This patch haven't make other pixel format usable yet to make sure the test result is same with rgb32 format. Reviewed-by: Marton Balint You should only add this if you got an explicit LGTM for a patch. Signed-off

Re: [FFmpeg-devel] [PATCH v3 3/3] lavc/libdavs2.c: use decoder data directly instead of memcpy

2019-07-22 Thread Marton Balint
On Sat, 13 Jul 2019, hwren wrote: At 2019-07-13 01:38:55, "Marton Balint" wrote: On Fri, 12 Jul 2019, hwrenx wrote: Can effectivly improved decoding speed when memcpy becomes a limitation for proccessing high resolution source. Tested under i7-8700k with `ffmpeg -i 7680

Re: [FFmpeg-devel] [PATCH v2 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-20 Thread Marton Balint
On Sat, 20 Jul 2019, Limin Wang wrote: On Fri, Jul 19, 2019 at 09:26:06PM +0200, Marton Balint wrote: On Fri, 19 Jul 2019, lance.lmw...@gmail.com wrote: >From: Limin Wang > >This patch haven't make other pixel format usable yet to make sure the test >result is same with

Re: [FFmpeg-devel] [PATCH v2 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-19 Thread Marton Balint
On Fri, 19 Jul 2019, lance.lmw...@gmail.com wrote: From: Limin Wang This patch haven't make other pixel format usable yet to make sure the test result is same with rgb32 format. Signed-off-by: Limin Wang --- libavfilter/f_select.c | 34 ++ 1 file changed, 30

Re: [FFmpeg-devel] [PATCH v2 3/3] lavf/f_select: make the more pixel format usable to avoid autoscale to rgb

2019-07-19 Thread Marton Balint
On Fri, 19 Jul 2019, lance.lmw...@gmail.com wrote: From: Limin Wang Below is the tested results for the new added pixel format without autoscale to rgb24: 1. AV_PIX_FMT_YUVJ420P time ./ffprobe -of compact=p=0 -show_entries frame=pkt_pts:frame_tags -bitexact -f lavfi \

Re: [FFmpeg-devel] [PATCH 3/3] lavf/f_select: make the more pixel format usable to avoid autoscale to rgb

2019-07-16 Thread Marton Balint
On Tue, 16 Jul 2019, lance.lmw...@gmail.com wrote: From: Limin Wang Signed-off-by: Limin Wang --- libavfilter/f_select.c | 6 ++ tests/ref/fate/filter-metadata-scenedetect | 16 2 files changed, 14 insertions(+), 8 deletions(-) diff --git

Re: [FFmpeg-devel] [PATCH 1/3] lavf/f_select: support scenecut with more pixel formats

2019-07-16 Thread Marton Balint
On Tue, 16 Jul 2019, lance.lmw...@gmail.com wrote: From: Limin Wang This patch haven't make other pixel format usable yet to make sure the test result is same with rgb format. Signed-off-by: Limin Wang --- libavfilter/f_select.c | 34 ++ 1 file changed, 30

Re: [FFmpeg-devel] [PATCH] lavf/vf_freezedetect: improve for the freeze frame detection

2019-07-15 Thread Marton Balint
On Mon, 15 Jul 2019, Limin Wang wrote: [...] >>>if (s->width[plane]) { >>>uint64_t plane_sad; >>>s->sad(frame->data[plane], frame->linesize[plane], >>>@@ -140,8 +146,12 @@ static int is_frozen(FreezeDetectContext *s, AVFrame *reference, AVFrame *frame) >>>

Re: [FFmpeg-devel] [PATCH] lavf/vf_freezedetect: improve for the freeze frame detection

2019-07-14 Thread Marton Balint
On Sun, 14 Jul 2019, Limin Wang wrote: On Sat, Jul 13, 2019 at 07:24:59PM +0200, Marton Balint wrote: On Sat, 13 Jul 2019, lance.lmw...@gmail.com wrote: >From: Limin Wang > >I have samples failed to detect the freeze frame with the default -60dB >noise(-40dB is OK to det

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-13 Thread Marton Balint
On Sat, 13 Jul 2019, mikroh...@gmail.com wrote: From: Jernej Fijacko Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD

Re: [FFmpeg-devel] [PATCH] fate: add hls fmp4 segment type test case

2019-07-13 Thread Marton Balint
On Sat, 13 Jul 2019, Steven Liu wrote: Signed-off-by: Steven Liu --- tests/fate/hlsenc.mak | 12 +++ tests/ref/fate/hls-fmp4 | 198 2 files changed, 210 insertions(+) create mode 100644 tests/ref/fate/hls-fmp4 diff --git

Re: [FFmpeg-devel] [PATCH] lavf/vf_freezedetect: improve for the freeze frame detection

2019-07-13 Thread Marton Balint
On Sat, 13 Jul 2019, lance.lmw...@gmail.com wrote: From: Limin Wang I have samples failed to detect the freeze frame with the default -60dB noise(-40dB is OK to detect), after apply the patch, it's ok to detect. I run the testing with fate-suite sample for your testing: old: no freeze

Re: [FFmpeg-devel] [PATCHv2] avformat/movenc: use unspecified language by default

2019-07-12 Thread Marton Balint
On Thu, 11 Jul 2019, Marton Balint wrote: On Tue, 9 Jul 2019, Marton Balint wrote: English was used before. Will apply this soon. Applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman

Re: [FFmpeg-devel] [PATCH] avformat/mpegts: respect program number when merging streams

2019-07-12 Thread Marton Balint
On Tue, 9 Jul 2019, Aman Gupta wrote: On Tue, Jul 9, 2019 at 2:07 PM Marton Balint wrote: merge_pmt_versions was not usable if multiple programs were present because when it was searching for candidate streams it did not make sure that the PMT was of the same program. This caused

Re: [FFmpeg-devel] [PATCH] libavfilter: add photosensitivity filter

2019-07-12 Thread Marton Balint
On Fri, 12 Jul 2019, Paul B Mahol wrote: From: Vladimir Panteleev I guess you should mention ticket #2104. Regards, Marton Signed-off-by: Paul B Mahol --- doc/filters.texi | 20 ++ libavfilter/Makefile | 1 + libavfilter/allfilters.c | 1 +

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-12 Thread Marton Balint
On Fri, 12 Jul 2019, Jernej wrote: Here's the fixed patch. I'm not familiar with providing patches via a mailing list. If replying doesn't work, I'll just use a new git send-mail. Yes, please, preferably with --in-reply-to= Thanks, Marton Signed-off-by: Jernej Fijacko ---

Re: [FFmpeg-devel] [PATCH v3 3/3] lavc/libdavs2.c: use decoder data directly instead of memcpy

2019-07-12 Thread Marton Balint
On Fri, 12 Jul 2019, hwrenx wrote: Can effectivly improved decoding speed when memcpy becomes a limitation for proccessing high resolution source. Tested under i7-8700k with `ffmpeg -i 7680x4320.avs2 -vsync 0 -f null -` got performance 23fps => 42fps Signed-off-by: hwrenx ---

Re: [FFmpeg-devel] [PATCH] Add support for Display Definition Segment to DVB Subtitle encoder

2019-07-11 Thread Marton Balint
On Thu, 11 Jul 2019, mikroh...@gmail.com wrote: Current version of dvbsub encoder doesn't support HD DVB subtitles. The high resolution bitmaps are muxed into the stream but without the DDS (display definition segment) the players asume that the DVB subtitles are in SD (720x576) resolution

Re: [FFmpeg-devel] [PATCHv2] avformat/movenc: use unspecified language by default

2019-07-11 Thread Marton Balint
On Tue, 9 Jul 2019, Marton Balint wrote: English was used before. Will apply this soon. Regards, Marton Signed-off-by: Marton Balint --- Changelog | 1 + libavformat/movenc.c | 2 +- libavformat/version.h

[FFmpeg-devel] [PATCH] avformat/mpegts: respect program number when merging streams

2019-07-09 Thread Marton Balint
is to make the parsing resilient to PID changes, and that is still working as expected. Signed-off-by: Marton Balint --- libavformat/mpegts.c | 10 ++ 1 file changed, 6 insertions(+), 4 deletions(-) diff --git a/libavformat/mpegts.c b/libavformat/mpegts.c index 8a84e5cc19..47d8d5f877

[FFmpeg-devel] [PATCHv2] avformat/movenc: use unspecified language by default

2019-07-09 Thread Marton Balint
English was used before. Signed-off-by: Marton Balint --- Changelog | 1 + libavformat/movenc.c | 2 +- libavformat/version.h | 2 +- tests/ref/acodec/alac | 2 +- tests/ref/acodec

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself to the AMF section

2019-07-04 Thread Marton Balint
On Thu, 4 Jul 2019, Hendrik Leppkes wrote: On Thu, Jul 4, 2019 at 12:42 AM Lynne wrote: NAK for reasons said on IRC For everyones benefit, why don't you actually formulate your reasons here instead of asking people to piece them together from some chat history, that way people can

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-30 Thread Marton Balint
On Wed, 26 Jun 2019, Andreas Håkon wrote: > > > -ts_st->payload = av_mallocz(ts->pes_payload_size); > > > +ts_st->payload = av_mallocz(ts->parallel_mux ? MAX_PES_PAYLOAD : ts->pes_payload_size); > > > > Could you clarify why this needs to be changed? > > Sure! Because

Re: [FFmpeg-devel] [PATCH] avcodec: add delayer bitstream filter

2019-06-27 Thread Marton Balint
On Thu, 27 Jun 2019, Andreas Håkon wrote: Hi Reimar, Minor note: I'd suggest a different name, "delayer" is too easily read as e.g. "de-layer". Could be something like add_delay for example. Good point! Or perhaps "timer" will be preferable. Ideas? Maybe it's too much work for little

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: new interlaced mux mode

2019-06-23 Thread Marton Balint
On Thu, 13 Jun 2019, Andreas Håkon wrote: Hi Andriy, I'm glad you're interested in this patch. > This patch implements a new optional "parallel muxing mode" in the MPEGTS muxer. > The strategy that implements the current mux (selected by default) is based on > writing full PES packages

Re: [FFmpeg-devel] Force PCR pid in a PROGRAM

2019-06-23 Thread Marton Balint
On Tue, 4 Jun 2019, Andreas Håkon wrote: Hi, Before coding of a new patch, I prefer to ask here for your ideas and thus improve the changes of acceptance of the patch. I posted before a patch to select which pid will carry the PCR timestamps. This makes sense in several scenarios: when

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Marton Balint
On Wed, 12 Jun 2019, Michael Niedermayer wrote: On Wed, Jun 12, 2019 at 10:09:08AM +0200, Marton Balint wrote: On Wed, 12 Jun 2019, Michael Niedermayer wrote: On Tue, Jun 11, 2019 at 03:21:41PM -0500, Amir Z wrote: Thanks Michael Niedermayer for looking into this What I am trying

Re: [FFmpeg-devel] [PATCH] set AVFrame decode_error_flags in case of decoding error by h264dec

2019-06-12 Thread Marton Balint
On Wed, 12 Jun 2019, Michael Niedermayer wrote: On Tue, Jun 11, 2019 at 03:21:41PM -0500, Amir Z wrote: Thanks Michael Niedermayer for looking into this What I am trying to solve is having a way to detect concealed decoding errors by the caller to avcodec_receive_frame. Should I add a

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-06-04 Thread Marton Balint
On Tue, 4 Jun 2019, Andreas Håkon wrote: Hi Marton, Thank you for taking the time to review this patch! ‐‐‐ Original Message ‐‐‐ On Sunday, 2 de June de 2019 1:38, Marton Balint wrote: On Wed, 22 May 2019, Andreas Håkon wrote: > Hi, > Patch to generate aligned Telete

Re: [FFmpeg-devel] [PATCH] libavformat/mpegtsenc: adaptive alignment for teletext PES packets

2019-06-01 Thread Marton Balint
On Wed, 22 May 2019, Andreas Håkon wrote: Hi, Patch to generate aligned Teletext PES packets using the MPEG-TS muxer when the TS header contains data. The code that generates the PES packets for Teletext data aligns the PES packets with the boundaries of the TS packets. The strategy used

Re: [FFmpeg-devel] [PATCH] doc/filters: move reference to framesync options from lut3d to haldclut

2019-06-01 Thread Marton Balint
On Sat, 1 Jun 2019, Paul B Mahol wrote: ok Thanks, applied. Regards, Marton On 5/31/19, Marton Balint wrote: Signed-off-by: Marton Balint --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 4fdcfe919e

[FFmpeg-devel] [PATCH] doc/filters: move reference to framesync options from lut3d to haldclut

2019-05-31 Thread Marton Balint
Signed-off-by: Marton Balint --- doc/filters.texi | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/filters.texi b/doc/filters.texi index 4fdcfe919e..e2cbc373d2 100644 --- a/doc/filters.texi +++ b/doc/filters.texi @@ -10844,6 +10844,8 @@ Default is @code{1}. @code

Re: [FFmpeg-devel] [PATCH 2/4] avcodec/qtrle: return last frame even if unchanged

2019-05-31 Thread Marton Balint
On Thu, 30 May 2019, Michael Niedermayer wrote: Fixes: Ticket7880 Signed-off-by: Michael Niedermayer --- libavcodec/qtrle.c| 42 +++ tests/ref/fate/qtrle-8bit | 1 + 2 files changed, 39 insertions(+), 4 deletions(-) diff --git a/libavcodec/qtrle.c

Re: [FFmpeg-devel] Is this a regression or not?

2019-05-28 Thread Marton Balint
On Tue, 28 May 2019, Nomis101  wrote: I regularly build HandBrake against the latest FFmpeg master to check if all works as expected or something is broken and I need to open a bug. With the latest master I found some issues, but I'm unsure if this is a regression or not. After commit

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v6] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-26 Thread Marton Balint
On Sat, 25 May 2019, Antonin Gouzer wrote: Hello, Shame on me, I didn't test the patch with the json format, only xml and flat. It's ok now. ok for XML too. Thanks! Thanks, applied. Regards, Marton Le sam. 25 mai 2019 à 00:27, Marton Balint a écrit : On Fri, 24 May 2019, Antonin

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v6] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-24 Thread Marton Balint
ct: [PATCH] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC) Slightly modified by Marton Balint to produce valid json as well. Signed-off-by: Marton Balint --- doc/ffprobe.xsd | 14 ++ fftools/ffprobe.c | 18 +- 2 files changed, 31 insertions(+),

Re: [FFmpeg-devel] [PATCH 1/2] avfilter/f_loop: fix video loop issues with 0 size or when size is bigger than input

2019-05-24 Thread Marton Balint
On Fri, 24 May 2019, Paul B Mahol wrote: On 5/23/19, Marton Balint wrote: Fixes infinte loop with -vf loop=loop=1 and also fixes looping when the input is less frames than the specified loop size. Possible regressions since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton

Re: [FFmpeg-devel] [PATCH 1/2] avcodec/scpr: fix checking ret value of decode_run_i

2019-05-24 Thread Marton Balint
On Thu, 23 May 2019, Paul B Mahol wrote: On 5/23/19, Marton Balint wrote: Fixes Coverity CID 1441460. Signed-off-by: Marton Balint --- libavcodec/scpr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index 10fc994ecf..317950dafb

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix stream ordering for program ID stream specifiers

2019-05-24 Thread Marton Balint
On Thu, 23 May 2019, Marton Balint wrote: On Sun, 19 May 2019, Marton Balint wrote: Fixes a regression introduced in dbfd042983eed8586d4048795c00af820f5b6b1f. Will apply soon. Applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg

[FFmpeg-devel] [PATCH 1/2] avfilter/f_loop: fix video loop issues with 0 size or when size is bigger than input

2019-05-23 Thread Marton Balint
Fixes infinte loop with -vf loop=loop=1 and also fixes looping when the input is less frames than the specified loop size. Possible regressions since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton Balint --- libavfilter/f_loop.c | 8 +--- 1 file changed, 5 insertions(+), 3

[FFmpeg-devel] [PATCH 2/2] avfilter/f_loop: warn about unset loop sizes

2019-05-23 Thread Marton Balint
Signed-off-by: Marton Balint --- libavfilter/f_loop.c | 13 + 1 file changed, 13 insertions(+) diff --git a/libavfilter/f_loop.c b/libavfilter/f_loop.c index fcbd742eb4..5ec44d9da2 100644 --- a/libavfilter/f_loop.c +++ b/libavfilter/f_loop.c @@ -55,6 +55,15 @@ typedef struct

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-23 Thread Marton Balint
On Thu, 23 May 2019, Paul B Mahol wrote: On 5/23/19, Marton Balint wrote: On Wed, 22 May 2019, Alexander Strasser wrote: Hi! On 2019-05-20 20:51 +0200, Marton Balint wrote: On Mon, 20 May 2019, Gyan wrote: > On 20-05-2019 02:18 AM, Marton Balint wrote: > > > > On S

[FFmpeg-devel] [PATCH 2/2] avcodec/scpr3: fix checking ret value of decode_run_i

2019-05-23 Thread Marton Balint
Fixes Coverity CID 1441461. Signed-off-by: Marton Balint --- libavcodec/scpr3.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/scpr3.c b/libavcodec/scpr3.c index 5cfad9f4d2..b4d2e21a17 100644 --- a/libavcodec/scpr3.c +++ b/libavcodec/scpr3.c @@ -1007,7 +1007,7

[FFmpeg-devel] [PATCH 1/2] avcodec/scpr: fix checking ret value of decode_run_i

2019-05-23 Thread Marton Balint
Fixes Coverity CID 1441460. Signed-off-by: Marton Balint --- libavcodec/scpr.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/scpr.c b/libavcodec/scpr.c index 10fc994ecf..317950dafb 100644 --- a/libavcodec/scpr.c +++ b/libavcodec/scpr.c @@ -359,7 +359,7 @@ static

Re: [FFmpeg-devel] [PATCH] avformat/movenc: use unspecified language by default

2019-05-23 Thread Marton Balint
On Mon, 20 May 2019, Carl Eugen Hoyos wrote: Am So., 19. Mai 2019 um 20:10 Uhr schrieb Marton Balint : English was used before. A version bump is necessary. I would also like a Changelog entry, most people prefer an entry to apichanges though. I can do both. Do people prefer to delay

Re: [FFmpeg-devel] [PATCH] avformat/utils: fix stream ordering for program ID stream specifiers

2019-05-23 Thread Marton Balint
On Sun, 19 May 2019, Marton Balint wrote: Fixes a regression introduced in dbfd042983eed8586d4048795c00af820f5b6b1f. Will apply soon. Thanks, Marton Signed-off-by: Marton Balint --- doc/fftools-common-opts.texi | 5 - libavformat/utils.c | 16 +++- 2 files

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-23 Thread Marton Balint
On Wed, 22 May 2019, Alexander Strasser wrote: Hi! On 2019-05-20 20:51 +0200, Marton Balint wrote: On Mon, 20 May 2019, Gyan wrote: > On 20-05-2019 02:18 AM, Marton Balint wrote: > > > > On Sun, 19 May 2019, Paul B Mahol wrote: > > > > > On

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v5] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-23 Thread Marton Balint
On Wed, 22 May 2019, Antonin Gouzer wrote: --- Change structure to conserve one SEI data=one side data with multiple timecode elements Thanks for the changes, patch is looking good except for some minor issues. However, you need to extend doc/ffprobe.xsd to support the changed XML

Re: [FFmpeg-devel] [PATCH] ffplay: added option always on top for video window

2019-05-20 Thread Marton Balint
On Mon, 20 May 2019, Carl Eugen Hoyos wrote: Marton, Am Mo., 13. Mai 2019 um 13:42 Uhr schrieb Daniel Kucera : From: Daniel Kucera Signed-off-by: Daniel Kucera --- doc/ffplay.texi | 2 ++ fftools/ffplay.c | 8 2 files changed, 10 insertions(+) diff --git a/doc/ffplay.texi

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-20 Thread Marton Balint
On Mon, 20 May 2019, Gyan wrote: On 20-05-2019 02:18 AM, Marton Balint wrote: On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: Fixes infinte loop with -vf loop=loop=1. Possible

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: Fixes infinte loop with -vf loop=loop=1. Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Paul B Mahol wrote: On 5/19/19, Marton Balint wrote: Fixes infinte loop with -vf loop=loop=1. Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton Balint --- libavfilter/f_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Nicolas George wrote: Marton Balint (12019-05-19): Fixes infinte loop with -vf loop=loop=1. The subject line talks about loop=0, this line about loop=1. Typo somewhere, or am I missing something? loop=1 is the loop count (number of loops), not the loop size (number

[FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Marton Balint
Fixes infinte loop with -vf loop=loop=1. Possible regression since ef1aadffc785b48ed62c45d954289e754f43ef46. Signed-off-by: Marton Balint --- libavfilter/f_loop.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavfilter/f_loop.c b/libavfilter/f_loop.c index d9d55f9837

[FFmpeg-devel] [PATCH] avformat/movenc: use unspecified language by default

2019-05-19 Thread Marton Balint
English was used before. Signed-off-by: Marton Balint --- libavformat/movenc.c | 2 +- tests/ref/acodec/alac | 2 +- tests/ref/acodec/pcm-s16be | 2 +- tests/ref/acodec/pcm-s24be | 2 +- tests/ref/acodec

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v4] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-19 Thread Marton Balint
On Sun, 19 May 2019, Antonin Gouzer wrote: --- Add the index of the timecode in case of multiple timecodes values Limit to 3 the number of timecodes remove break Am I reading this correctly, you'd get XML like right? The problem is that your output now looks as if the frame have 3

[FFmpeg-devel] [PATCH] avformat/utils: fix stream ordering for program ID stream specifiers

2019-05-18 Thread Marton Balint
Fixes a regression introduced in dbfd042983eed8586d4048795c00af820f5b6b1f. Signed-off-by: Marton Balint --- doc/fftools-common-opts.texi | 5 - libavformat/utils.c | 16 +++- 2 files changed, 15 insertions(+), 6 deletions(-) diff --git a/doc/fftools-common-opts.texi b

Re: [FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

2019-05-18 Thread Marton Balint
On Sat, 18 May 2019, Carl Eugen Hoyos wrote: Am 18.05.2019 um 16:48 schrieb Marton Balint : On Tue, 14 May 2019, Hendrik Leppkes wrote: On Tue, May 14, 2019 at 10:34 PM Marton Balint wrote: On Sun, 5 May 2019, Carl Eugen Hoyos wrote: Am So., 5. Mai 2019 um 20:51 Uhr schrieb

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v2] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-18 Thread Marton Balint
On Sat, 18 May 2019, Antonin Gouzer wrote: Thank you for your response, I don't have any example of such a file. I was thinking that GOP timecode was reserved to MPEG2 files and S12M to H265/H264 files ? In every writer the type of timecode is already an attribute: side_data_type. With the

Re: [FFmpeg-devel] [FFMPEG DEVEL] [PATCH v2] fftools/ffprobe: Add S12M Timecode output as side data (such as SEI TC)

2019-05-18 Thread Marton Balint
On Fri, 17 May 2019, Antonin Gouzer wrote: Thanks in advance. --- fftools/ffprobe.c | 8 1 file changed, 8 insertions(+) diff --git a/fftools/ffprobe.c b/fftools/ffprobe.c index dea489d02e..4763ce6d98 100644 --- a/fftools/ffprobe.c +++ b/fftools/ffprobe.c @@ -2199,6 +2199,14 @@

Re: [FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

2019-05-18 Thread Marton Balint
On Tue, 14 May 2019, Hendrik Leppkes wrote: On Tue, May 14, 2019 at 10:34 PM Marton Balint wrote: On Sun, 5 May 2019, Carl Eugen Hoyos wrote: > Am So., 5. Mai 2019 um 20:51 Uhr schrieb Marton Balint : >> >> This reverts commit dd06f022b07438d650c82255dff16908ba04244a. >

Re: [FFmpeg-devel] [PATCH] avcodec/qtrle: return last frame even if unchanged

2019-05-16 Thread Marton Balint
On Wed, 15 May 2019, Michael Niedermayer wrote: Fixes: Ticket7880 Signed-off-by: Michael Niedermayer --- libavcodec/qtrle.c| 27 +-- tests/ref/fate/qtrle-8bit | 1 + 2 files changed, 26 insertions(+), 2 deletions(-) diff --git a/libavcodec/qtrle.c

Re: [FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

2019-05-14 Thread Marton Balint
On Sun, 5 May 2019, Carl Eugen Hoyos wrote: Am So., 5. Mai 2019 um 20:51 Uhr schrieb Marton Balint : This reverts commit dd06f022b07438d650c82255dff16908ba04244a. Fixes ticket #7871 and reopens ticket #7816. I'll send an alternative patch in a moment. Ping for this, I still think

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-14 Thread Marton Balint
On Wed, 8 May 2019, Michael Niedermayer wrote: On Tue, May 07, 2019 at 02:03:22AM +0200, Marton Balint wrote: On Tue, 7 May 2019, Michael Niedermayer wrote: On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. I

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-13 Thread Marton Balint
On Sun, 28 Apr 2019, Marton Balint wrote: Hi All, There has been discussion on the mailing list several times about the inclusion of support for closed source components (codecs, formats, filters, etc) in the main ffmpeg codebase. Also the removal of libNDI happened without general

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-12 Thread Marton Balint
On Sun, 12 May 2019, Nicolas George wrote: Marton Balint (12019-05-12): Why would you want to do pitch scaling and tempo scaling in a single filter? Because that is the same thing. Pitch scaling is a combo of asetrate and aresample as far as I understand. You are mistaken: if you do

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-12 Thread Marton Balint
On Sun, 12 May 2019, Paul B Mahol wrote: Signed-off-by: Paul B Mahol --- This filter can dynamically change both tempo and pitch of audio. Also scale range is bigger, from 0.01 to 100. Why would you want to do pitch scaling and tempo scaling in a single filter? Pitch scaling is a combo

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-05-08 Thread Marton Balint
On Sun, 28 Apr 2019, Marton Balint wrote: Hi All, There has been discussion on the mailing list several times about the inclusion of support for closed source components (codecs, formats, filters, etc) in the main ffmpeg codebase. Also the removal of libNDI happened without general

Re: [FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-06 Thread Marton Balint
On Tue, 7 May 2019, Michael Niedermayer wrote: On Sun, May 05, 2019 at 08:51:08PM +0200, Marton Balint wrote: This reverts commit a9dacdeea6168787a142209bd19fdd74aefc9dd6. I don't think it is a good idea to drop frames from CFR input just because they are duplicated, that can cause issues

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-06 Thread Marton Balint
On Mon, 6 May 2019, Marton Balint wrote: On Mon, 6 May 2019, Paul B Mahol wrote: On 5/6/19, Marton Balint wrote: On Sat, 4 May 2019, John Warburton wrote: On Sat, May 4, 2019 at 3:34 PM Nicolas George wrote: John Warburton (12019-05-04): > Is there a patch I can use to t

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-06 Thread Marton Balint
On Mon, 6 May 2019, Paul B Mahol wrote: On 5/6/19, Marton Balint wrote: On Sat, 4 May 2019, John Warburton wrote: On Sat, May 4, 2019 at 3:34 PM Nicolas George wrote: John Warburton (12019-05-04): > Is there a patch I can use to test scaletempo to compare it against atempo? >

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-05 Thread Marton Balint
On Sat, 4 May 2019, John Warburton wrote: On Sat, May 4, 2019 at 3:34 PM Nicolas George wrote: John Warburton (12019-05-04): > Is there a patch I can use to test scaletempo to compare it against atempo? > It'll be no trouble to do that with the normal audio that is time-adjusted > on that

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: fix checking video mode in SDK version 11

2019-05-05 Thread Marton Balint
On Sun, 5 May 2019, Devin Heitmueller wrote: Hello Marton, On May 5, 2019, at 2:28 PM, Marton Balint wrote: On Wed, 1 May 2019, Marton Balint wrote: Apparently in the new SDK one cannot query if VANC output is supported, so we will fall back to non-VANC output if enabling the video

[FFmpeg-devel] [PATCH 2/2] Revert "lavf/utils: Allow url credentials to contain a slash."

2019-05-05 Thread Marton Balint
there are better ways to fix the original issue, like being able to specify HTTP username and password as a protocol option, or adding a protocol option to percent-decode the URL first. Signed-off-by: Marton Balint --- libavformat/utils.c | 5 + 1 file changed, 1 insertion(+), 4 deletions(-) diff --git

[FFmpeg-devel] [PATCH 1/2] Revert "avcodec/qtrle: Do not output duplicated frames on insufficient input"

2019-05-05 Thread Marton Balint
frame. Fixes ticket #7880. Signed-off-by: Marton Balint --- libavcodec/qtrle.c| 12 ++--- tests/ref/fate/qtrle-8bit | 109 ++ 2 files changed, 115 insertions(+), 6 deletions(-) diff --git a/libavcodec/qtrle.c b/libavcodec/qtrle.c index

Re: [FFmpeg-devel] [PATCH] avfilter/vf_freezedetect: fix missing freeze_start when the freeze length is around the detection duration

2019-05-05 Thread Marton Balint
On Wed, 1 May 2019, Marton Balint wrote: Fixes ticket #7875. Applied. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel

Re: [FFmpeg-devel] [PATCH] avdevice/decklink: fix checking video mode in SDK version 11

2019-05-05 Thread Marton Balint
On Wed, 1 May 2019, Marton Balint wrote: Apparently in the new SDK one cannot query if VANC output is supported, so we will fall back to non-VANC output if enabling the video output with VANC fails. Fixes ticket #7867. Applied. Regards, Marton

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Marton Balint
On Sun, 5 May 2019, Nicolas George wrote: Paul B Mahol (12019-05-05): Because Nicolas objected on initial implementation. Dunno if he still object something on current updated patch. Did it have a proper review on the mailing list? If yes, then I do not oppose it. If no, then I oppose it.

[FFmpeg-devel] [PATCH] avfilter/vf_freezedetect: fix missing freeze_start when the freeze length is around the detection duration

2019-05-01 Thread Marton Balint
Fixes ticket #7875. Signed-off-by: Marton Balint --- libavfilter/vf_freezedetect.c | 7 +++ 1 file changed, 3 insertions(+), 4 deletions(-) diff --git a/libavfilter/vf_freezedetect.c b/libavfilter/vf_freezedetect.c index 299a5dfbf6..cc086afee6 100644 --- a/libavfilter/vf_freezedetect.c

[FFmpeg-devel] [PATCH] avdevice/decklink: fix checking video mode in SDK version 11

2019-05-01 Thread Marton Balint
Apparently in the new SDK one cannot query if VANC output is supported, so we will fall back to non-VANC output if enabling the video output with VANC fails. Fixes ticket #7867. Signed-off-by: Marton Balint --- libavdevice/decklink_common.cpp | 16 +--- libavdevice/decklink_enc.cpp

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-29 Thread Marton Balint
On Mon, 29 Apr 2019, Carl Eugen Hoyos wrote: 2019-04-29 1:02 GMT+02:00, Marton Balint : On Mon, 29 Apr 2019, Carl Eugen Hoyos wrote: 2019-04-28 22:02 GMT+02:00, Marton Balint : 1) Should libNDI support be removed from the ffmpeg codebase? This sounds to me as if you know

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Sun, 28 Apr 2019, Jean-Baptiste Kempf wrote: On Mon, 29 Apr 2019, at 00:23, Marton Balint wrote: >> On Sun, 28 Apr 2019, at 22:02, Marton Balint wrote: >>> 2) Should patches using closed source libraries which are not considered >>> "System Libraries"

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Sun, 28 Apr 2019, Marton Balint wrote: Hi All, There has been discussion on the mailing list several times about the inclusion of support for closed source components (codecs, formats, filters, etc) in the main ffmpeg codebase. Also the removal of libNDI happened without general

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Mon, 29 Apr 2019, Carl Eugen Hoyos wrote: 2019-04-28 22:02 GMT+02:00, Marton Balint : 1) Should libNDI support be removed from the ffmpeg codebase? This sounds to me as if you know of an alternative to not endorsing a company that profits from FFmpeg while at the same time violating

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Sun, 28 Apr 2019, Marton Balint wrote: On Sun, 28 Apr 2019, Jean-Baptiste Kempf wrote: On Sun, 28 Apr 2019, at 22:02, Marton Balint wrote: 2) Should patches using closed source libraries which are not considered "System Libraries" according to the GPL be rejected? You m

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Sun, 28 Apr 2019, Mark Thompson wrote: On 28/04/2019 21:02, Marton Balint wrote: ... closed source libraries which are not considered "System Libraries" according to the GPL ... Please can you define this in a precise way which does not rely upon interpreti

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Sun, 28 Apr 2019, Jean-Baptiste Kempf wrote: On Sun, 28 Apr 2019, at 22:02, Marton Balint wrote: 2) Should patches using closed source libraries which are not considered "System Libraries" according to the GPL be rejected? You mean "major components"? (at no

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Sun, 28 Apr 2019, Carl Eugen Hoyos wrote: 2019-04-28 22:02 GMT+02:00, Marton Balint : 2) Should patches using closed source libraries which are not considered "System Libraries" according to the GPL be rejected? Do I understand correctly that this question is equivalent to

Re: [FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
On Sun, 28 Apr 2019, James Almer wrote: On 4/28/2019 5:02 PM, Marton Balint wrote: Hi All, There has been discussion on the mailing list several times about the inclusion of support for closed source components (codecs, formats, filters, etc) in the main ffmpeg codebase. Also the removal

Re: [FFmpeg-devel] [PATCH 4/5] avformat/mxfdec: take into account run-in in find_partition_by_offset

2019-04-28 Thread Marton Balint
On Sun, 14 Apr 2019, Tomas Härdin wrote: fre 2019-04-12 klockan 01:09 +0200 skrev Marton Balint: > Signed-off-by: Marton Balint ---  libavformat/mxfdec.c | 8  1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 2362948

Re: [FFmpeg-devel] [PATCH 5/5] avformat/mxfdec: fix and enhance RIP KLV length checks

2019-04-28 Thread Marton Balint
On Sun, 14 Apr 2019, Tomas Härdin wrote: fre 2019-04-12 klockan 01:09 +0200 skrev Marton Balint: KLV length is BER encoded (variable size), but the code assumed the encoding to always use 4 bytes. Fixes parsing Random Index Pack in samples/MXF/issue2160/PW0805A0V01.4C5B5636.EFA330.mxf

Re: [FFmpeg-devel] [PATCH 2/5] avformat/mxfdec: rework mxf_essence_container_end

2019-04-28 Thread Marton Balint
On Sun, 14 Apr 2019, Tomas Härdin wrote: fre 2019-04-12 klockan 01:09 +0200 skrev Marton Balint: We find the last essence container much faster if we go through the partitions backwards... Good catch > Signed-off-by: Marton Balint ---  libavformat/mxfdec.c | 9 +++--  1 file chan

Re: [FFmpeg-devel] [PATCHv2 3/5] avformat/mxfdec: guess wrapping of tracks by other tracks with the same body sid

2019-04-28 Thread Marton Balint
On Fri, 26 Apr 2019, Tomas Härdin wrote: ons 2019-04-24 klockan 22:31 +0200 skrev Marton Balint: On Wed, 24 Apr 2019, Tomas Härdin wrote: > mån 2019-04-22 klockan 19:15 +0200 skrev Marton Balint: > > This affects the following samples: > > > > samples/ffmpeg-b

[FFmpeg-devel] [DECISION] Project policy on closed source components

2019-04-28 Thread Marton Balint
Hi All, There has been discussion on the mailing list several times about the inclusion of support for closed source components (codecs, formats, filters, etc) in the main ffmpeg codebase. Also the removal of libNDI happened without general consensus, so a vote is necessary to justify the

Re: [FFmpeg-devel] [PATCHv2 3/5] avformat/mxfdec: guess wrapping of tracks by other tracks with the same body sid

2019-04-24 Thread Marton Balint
On Wed, 24 Apr 2019, Tomas Härdin wrote: mån 2019-04-22 klockan 19:15 +0200 skrev Marton Balint: This affects the following samples: samples/ffmpeg-bugs/roundup/issue1775/av_seek_frame_failure.mxf samples/ffmpeg-bugs/trac/ticket1957/16ch.mxf samples/ffmpeg-bugs/trac/ticket5016/r0.mxf

[FFmpeg-devel] [PATCHv2 3/5] avformat/mxfdec: guess wrapping of tracks by other tracks with the same body sid

2019-04-22 Thread Marton Balint
/trac/ticket5316/hqx.MXF Some AVPacket->pos values are changed because for frame wrapped tracks we point to the KLV offset and not the data. Signed-off-by: Marton Balint --- libavformat/mxfdec.c | 18 ++ 1 file changed, 18 insertions(+) diff --git a/libavformat/mxfdec.

Re: [FFmpeg-devel] [PATCH v3] avcodec: add AV_CODEC_FLAG_DROPCHANGED to flags

2019-04-20 Thread Marton Balint
On Sat, 20 Apr 2019, Gyan wrote: On 19-04-2019 08:41 PM, Gyan wrote: On 16-04-2019 01:12 PM, Gyan wrote: Patch revised as per http://www.ffmpeg.org/pipermail/ffmpeg-devel/2019-April/242591.html If no more changes, plan to push tomorrow morning. Pushed as

Re: [FFmpeg-devel] [PATCH 3/3] avdevice/decklink_common: add support for DeckLink SDK 11

2019-04-15 Thread Marton Balint
On Tue, 9 Apr 2019, Marton Balint wrote: Fixes ticket #7789. Pushed the series. Regards, Marton ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email

Re: [FFmpeg-devel] [PATCH] mxfdec: Constrain run-in to 64k

2019-04-15 Thread Marton Balint
On Mon, 15 Apr 2019, Tomas Härdin wrote: This isn't likely to be a huge problem, but it allows us to reason more about run-in. It also exposes my gripe about klv_read_packet() using mxf_read_sync() I would allow 65536 bytes as well for run-in, even if that is against the standard. The MXF

Re: [FFmpeg-devel] [PATCH] avformat/mxfdec: use operational_pattern_ul instead of operational_pattern for metadata

2019-04-14 Thread Marton Balint
On Sun, 14 Apr 2019, Tomas Härdin wrote: sön 2019-04-14 klockan 18:51 +0200 skrev Marton Balint: This makes it more consistent with other metadata keys. Signed-off-by: Marton Balint ---  libavformat/mxfdec.c   | 2 +-  tests/ref/fate/mxf-probe-d10   | 2 +-  tests/ref/fate/mxf-probe

  1   2   3   4   5   6   7   8   9   10   >