[FFmpeg-devel] [PATCH 4/4] tests/fate/vcodec: Add 10bit 2pass FFv1 test

(this covers ticket5405) Signed-off-by: Michael Niedermayer --- tests/fate/vcodec.mak | 5 - tests/ref/vsynth/vsynth1-ffv1-2pass10 | 4 tests/ref/vsynth/vsynth2-ffv1-2pass10 | 4 tests/ref/vsynth/vsynth3-ffv1-2pass10 | 4 tests/ref/vsynth

[FFmpeg-devel] [PATCH 3/4] avcodec/ffv1enc: Fix >8bit context size

Fixes: Ticket5405 Signed-off-by: Michael Niedermayer --- libavcodec/ffv1enc.c | 18 ++ 1 file changed, 10 insertions(+), 8 deletions(-) diff --git a/libavcodec/ffv1enc.c b/libavcodec/ffv1enc.c index 1c37f61adaf..a6f405289eb 100644 --- a/libavcodec/ffv1enc.c +++ b/libavcodec

[FFmpeg-devel] [PATCH 2/4] avformat/movenc: Fix ffv1 support

Fixes: Ticket9975 Signed-off-by: Michael Niedermayer --- libavformat/movenc.c | 1 + 1 file changed, 1 insertion(+) diff --git a/libavformat/movenc.c b/libavformat/movenc.c index d20e45cf810..c88461ab8a0 100644 --- a/libavformat/movenc.c +++ b/libavformat/movenc.c @@ -8582,6 +8582,7 @@ static

[FFmpeg-devel] [PATCH 1/4] avcodec/ffv1dec: Blow up if user asks for explosion

Fixes: Ticket8403 Signed-off-by: Michael Niedermayer --- libavcodec/ffv1dec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavcodec/ffv1dec.c b/libavcodec/ffv1dec.c index 415c66be636..0afdeabd915 100644 --- a/libavcodec/ffv1dec.c +++ b/libavcodec/ffv1dec.c @@ -354,6 +354,9 @@ static

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Wed, Aug 14, 2024 at 02:41:55PM +0200, Michael Niedermayer wrote: > Hi all > > Are there any upcoming LTS releases that want to/could include FFmpeg 7.1 ? > If so please reply here and list the date before which we would have to > finish the 7.1 release so it can be included w

Re: [FFmpeg-devel] [PATCH 10/10] avcodec/xan: Add basic input size check

On Sun, Sep 22, 2024 at 11:56:45PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71739/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_WC3_fuzzer-6170301405134848 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mas

Re: [FFmpeg-devel] [PATCH 09/10] avcodec/vble: Allocate buffer later

On Sun, Sep 22, 2024 at 11:56:44PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71727/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VBLE_fuzzer-6126342574243840 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 08/10] swscale/swscale_unscaled: Fix odd height with nv24_to_yuv420p_chroma()

On Mon, Sep 23, 2024 at 12:42:22AM +0200, Ramiro Polla wrote: > Hi, > > On Mon, Sep 23, 2024 at 12:04 AM Michael Niedermayer > wrote: > > > > Fixes: out of array read > > Fixes: 71726/clusterfuzz-testcase-ffmpeg_SWS_fuzzer-5876893532880896 > > > > Found

Re: [FFmpeg-devel] [PATCH 07/10] avcodec/sgirl edec: Check input length

On Sun, Sep 22, 2024 at 11:56:42PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71712/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGIRLE_fuzzer-5763700835811328 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 06/10] avcodec/imm4: Check input size

On Sun, Sep 22, 2024 at 11:56:41PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71324/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IMM4_fuzzer-5388489435185152 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 04/10] avcodec/svq3: Check for minimum size input

On Sun, Sep 22, 2024 at 11:56:39PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-441125111808 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 03/10] tools/target_swr_fuzzer: Limit the number of samples

On Sun, Sep 22, 2024 at 11:56:38PM +0200, Michael Niedermayer wrote: > Fixes: OOM and Timeout > Fixes: 71254/clusterfuzz-testcase-minimized-ffmpeg_SWR_fuzzer-5941896977907712 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg

Re: [FFmpeg-devel] [PATCH 01/10] tools/target_dec_fuzzer: Add threshold for SRGC

On Sun, Sep 22, 2024 at 11:56:36PM +0200, Michael Niedermayer wrote: > Fixes: Timeout > Fixes: > 71234/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SRGC_fuzzer-5098445864501248 > > Found-by: continuous fuzzing process > https://github.com/google/oss-fuzz/tree/mast

Re: [FFmpeg-devel] [PATCH 1/9] avcodec/osq: Treat sum = 0 as k = 0

On Fri, Sep 20, 2024 at 12:56:31AM +0200, Michael Niedermayer wrote: > We have no valid sample that triggers this so we do not know if this would > decode > correctly, but -inf is not the correct k value > > Fixes: Assertion n>=0 && n<=32 failed at libavcodec/ge

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

On Fri, Sep 20, 2024 at 06:05:46PM +0100, Frank Plowman wrote: > On 20/09/2024 01:54, James Almer wrote: > > On 9/19/2024 9:34 PM, Michael Niedermayer wrote: > >> On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: > >>> On 9/19/2024 7:56 PM, Michael Niederma

Re: [FFmpeg-devel] [PATCH 10/14] swscale/range_convert: fix mpeg ranges in yuv range conversion for non-8-bit pixel formats

On Mon, Sep 23, 2024 at 02:40:13PM +0200, Ramiro Polla wrote: > There is an issue with the constants used in YUV to YUV range conversion, > where the upper bound is not respected when converting to mpeg range. > > With this commit, the constants are calculated at runtime, depending on > the bit de

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Fri, Aug 23, 2024 at 03:43:54PM -0400, Neal Gompa wrote: > On Wed, Aug 14, 2024 at 11:11 AM Michael Niedermayer > wrote: > > > > Hi all > > > > Are there any upcoming LTS releases that want to/could include FFmpeg 7.1 ? > > If so please reply here and list

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

On Mon, Sep 23, 2024 at 09:56:52PM +0200, Anton Khirnov wrote: > Quoting Kieran Kunhya via ffmpeg-devel (2024-09-23 21:30:09) > > > On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel > > > wrote: [...] > > I think the OP is correct here that the behaviour makes no sense. If > > someth

Re: [FFmpeg-devel] A change in r_frame_rate values after upgrade to FFmpeg 6.1

On Mon, Sep 23, 2024 at 08:30:09PM +0100, Kieran Kunhya via ffmpeg-devel wrote: > > On Mon, Sep 23, 2024 at 4:45 PM Kieran Kunhya via ffmpeg-devel > > wrote: > >> > >> On Mon, Sep 23, 2024 at 3:27 PM Anton Khirnov wrote: > >> > > >> > Quoting Antoni Bizoń (2024-09-23 10:09:51) > >> > > I underst

Re: [FFmpeg-devel] [PATCH] doc: Add email URLs for Fate samples-request

On Fri, Sep 20, 2024 at 12:27:19PM +0200, Martin Schitter wrote: > v2 adds the address as a second (L: ...)-entry > to the Fate info in MAINTAINERS. > > I'm not sure if this is correct because I couldn't find other lines, > where the same kind of entry gets used twice. > > Btw.: the fate info a

[FFmpeg-devel] [PATCH 7/7] avcodec/hevc/hevcdec: initialize qp_y_tab

/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/hevc/hevcdec.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/hevc/hevcdec.c b/libavcodec/hevc/hevcdec.c index d915d74d22e..0b50bbd2754 100644 --- a/libavcodec/hevc/hevcdec.c +++ b/libavcodec/hevc

[FFmpeg-devel] [PATCH 6/7] avcodec/get_bits: dont add a null to a 0

Fixes: undefined behavior Fixes: 71747/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_HEVC_fuzzer-5427736120721408 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/get_bits.h | 2 +- 1 file

[FFmpeg-devel] [PATCH 5/7] avformat/qcp: Check for read failure in header

Fixes: Use of uninitialized value Fixes: 71551/clusterfuzz-testcase-minimized-ffmpeg_dem_QCP_fuzzer-4647386712965120 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/qcp.c | 3 ++- 1 file

[FFmpeg-devel] [PATCH 4/7] avcodec/eatgq: Check bytestream2_get_buffer() for failure

Fixes: Use of uninitialized memory Fixes: 71546/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EATGQ_fuzzer-5607656650244096 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/eatgq.c | 3

[FFmpeg-devel] [PATCH 3/7] avcodec/eatgq: move array to where it is used

Signed-off-by: Michael Niedermayer --- libavcodec/eatgq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/eatgq.c b/libavcodec/eatgq.c index d326c053907..190c57f1c00 100644 --- a/libavcodec/eatgq.c +++ b/libavcodec/eatgq.c @@ -156,7 +156,6 @@ static int

[FFmpeg-devel] [PATCH 2/7] avformat/mxfdec: Check avio_read() success in mxf_decrypt_triplet()

Fixes: Use of uninitialized memory Fixes: 71444/clusterfuzz-testcase-minimized-ffmpeg_dem_MXF_fuzzer-5448597561212928 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 3 ++- 1 file

[FFmpeg-devel] [PATCH 1/7] avcodec/ilbcdec: Initialize tempbuff2

Fixes: Use of uninitialized value Fixes: 71350/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_ILBC_fuzzer-6322020827070464 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/ilbcdec.c | 2

Re: [FFmpeg-devel] PATCH] Make H.274 film grain support optional for H.264. Saves ~779kb.

On Wed, Aug 14, 2024 at 08:29:37AM +0200, Christophe Gisquet wrote: > Hi, > > Le mar. 13 août 2024 à 23:39, Dale Curtis a écrit : > > > > On Tue, Aug 13, 2024 at 1:11 PM Hendrik Leppkes wrote: > > > > > Disabling random codec features seems like an anti-feature to me, in > > > the future it'll m

[FFmpeg-devel] [PATCH 10/10] avcodec/xan: Add basic input size check

Fixes: Timeout Fixes: 71739/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_XAN_WC3_fuzzer-6170301405134848 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpe Signed-off-by: Michael Niedermayer --- libavcodec/xan.c | 3 +++ 1 file changed, 3

[FFmpeg-devel] [PATCH 09/10] avcodec/vble: Allocate buffer later

Fixes: Timeout Fixes: 71727/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VBLE_fuzzer-6126342574243840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vble.c | 8 1 file changed

[FFmpeg-devel] [PATCH 08/10] swscale/swscale_unscaled: Fix odd height with nv24_to_yuv420p_chroma()

Fixes: out of array read Fixes: 71726/clusterfuzz-testcase-ffmpeg_SWS_fuzzer-5876893532880896 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libswscale/swscale_unscaled.c | 2 ++ 1 file changed, 2

[FFmpeg-devel] [PATCH 07/10] avcodec/sgirl edec: Check input length

Fixes: Timeout Fixes: 71712/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SGIRLE_fuzzer-5763700835811328 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/sgirledec.c | 3 +++ 1 file

[FFmpeg-devel] [PATCH 06/10] avcodec/imm4: Check input size

Fixes: Timeout Fixes: 71324/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_IMM4_fuzzer-5388489435185152 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/imm4.c | 4 1 file changed, 4

[FFmpeg-devel] [PATCH 05/10] avcodec/vvc/thread: Check frame to be non NULL

Fixes: NULL pointer dereference Fixes: 71303/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-4875859050168320 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/vvc/thread.c | 3

[FFmpeg-devel] [PATCH 04/10] avcodec/svq3: Check for minimum size input

Fixes: Timeout Fixes: 71295/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SVQ3_fuzzer-441125111808 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/svq3.c | 3 +++ 1 file changed, 3

[FFmpeg-devel] [PATCH 03/10] tools/target_swr_fuzzer: Limit the number of samples

Fixes: OOM and Timeout Fixes: 71254/clusterfuzz-testcase-minimized-ffmpeg_SWR_fuzzer-5941896977907712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_swr_fuzzer.c | 3 +++ 1 file changed, 3

[FFmpeg-devel] [PATCH 02/10] MAINTAINERS: aacdec seems unmaintained, aacdec_usac seems maintained by Lynne

CC: Lynne Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 ++ 1 file changed, 2 insertions(+) diff --git a/MAINTAINERS b/MAINTAINERS index 5b6fbfdc48d..882ecae1d32 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -146,6 +146,8 @@ Codecs: 4xm.c [2] Michael

[FFmpeg-devel] [PATCH 01/10] tools/target_dec_fuzzer: Add threshold for SRGC

Fixes: Timeout Fixes: 71234/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SRGC_fuzzer-5098445864501248 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 1 + 1 file changed

Re: [FFmpeg-devel] [PATCH 03/11] avcodec/aac/aacdec: Check if frame is allocated in frame_configure_elements()

On Mon, Jul 01, 2024 at 01:12:42AM +0200, Michael Niedermayer wrote: > I did not investigate exactly why frame is NULL, happy to provide the sample > if someone wants to investigate further > > Fixes: NULL pointer dereference > Fixes: > 69893/clusterfuzz-

Re: [FFmpeg-devel] [PATCH 12/13] avcodec/vc1dec: Reenable debug-info output for field pictures

On Mon, Jul 01, 2024 at 02:16:09PM +0200, Andreas Rheinhardt wrote: > Effectively reverts c59b5e3d1e0121ea23b5b326529f5bdca44cf982. > This is possible now that ff_print_debug_info2() uses > the MPVPicture dimensions. > > Signed-off-by: Andreas Rheinhardt > --- > libavcodec/vc1dec.c | 6 ++ >

Re: [FFmpeg-devel] [PATCH 04/13] avcodec/h263dec: Clean intra tables in decoder, not ff_mpv_reconstruct_mb

Hi On Mon, Jul 01, 2024 at 02:16:01PM +0200, Andreas Rheinhardt wrote: > This is a more appropriate place than a function designed > to reconstruct a macroblock. It furthermore limits these checks > to the codecs that actually need it (and removes it from e.g. > RV10 and RV20 -- the latter actuall

Re: [FFmpeg-devel] [PATCH 09/13] avcodec/mpegvideo_enc: Add AV_CODEC_CAP_DR1

On Mon, Jul 01, 2024 at 02:16:06PM +0200, Andreas Rheinhardt wrote: > The mpegvideo-based encoders do one uncommon thing with > the packet's data given by ff_alloc_packet(): They potentially > reallocate it. But this only affects the internal buffer > and is not user-facing at all, so one can never

Re: [FFmpeg-devel] [PATCH 1/3] - libavcodec/aom_film_grain: Handle byte alignment when multiple film grain parameters sets are present in the bitstream

On Fri, Sep 20, 2024 at 12:42:47AM +, Segall, Andrew via ffmpeg-devel wrote: > More info: Series of patches to align the implementation of aom_film_grain.c > with the AOM specification. > > First time committing. Suggestions very welcome. > > Signed-off-by: Andrew Segall mailto:aseg...@amaz

Re: [FFmpeg-devel] [PATCH] doc: Add email URLs for Fate sample-request

On Fri, Sep 20, 2024 at 02:50:18AM +0200, Martin Schitter wrote: > Because I'm now waiting for one week that someone finally puts my > contributed DNxUncompressed sample files to the Fate sample repo > (see: > https://lists.ffmpeg.org/pipermail/ffmpeg-devel/2024-September/333471.html), > I frequen

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

On Fri, Sep 20, 2024 at 02:34:25AM +0200, Michael Niedermayer wrote: > On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: > > On 9/19/2024 7:56 PM, Michael Niedermayer wrote: > > > Fixes: shift exponent 62 is too large for 32-bit type 'int' > > > Fix

Re: [FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

On Thu, Sep 19, 2024 at 08:53:07PM -0300, James Almer wrote: > On 9/19/2024 7:56 PM, Michael Niedermayer wrote: > > Fixes: shift exponent 62 is too large for 32-bit type 'int' > > Fixes: > > 71020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-644

[FFmpeg-devel] [PATCH 9/9] avcodec/eacmv: Check input size for intra frames

Fixes: Timeout Fixes: 71135/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_EACMV_fuzzer-6251879028293632 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/eacmv.c | 5 - 1 file changed

[FFmpeg-devel] [PATCH 8/9] tools/target_dec_fuzzer: Adapt threshold for RASC

Fixes: Timeout Fixes: 71108/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_RASC_fuzzer-4799330484027392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- tools/target_dec_fuzzer.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 6/9] avcodec/aac/aacdec: use correct index in deallocation

Fixes: memleak Fixes: 71084/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_AAC_LATM_fuzzer-5857751899635712 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavcodec/aac/aacdec.c | 2 +- 1 file

[FFmpeg-devel] [PATCH 7/9] avcodec/encode: Check bitrate

Fixes: -1.80923e+19 is outside the range of representable values of type 'long' Fixes: 71103/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_SNOW_fuzzer-6542773681979392 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH 5/9] avcodec/cbs_h266_syntax_template: Check bit depth with range extension

Fixes: shift exponent 62 is too large for 32-bit type 'int' Fixes: 71020/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VVC_fuzzer-6444916325023744 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael N

[FFmpeg-devel] [PATCH 4/9] avcodec/osq: use unsigned for decorrelation

Signed-off-by: Michael Niedermayer --- libavcodec/osq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/osq.c b/libavcodec/osq.c index 2b75364c18c..1bf62646994 100644 --- a/libavcodec/osq.c +++ b/libavcodec/osq.c @@ -342,7 +342,7 @@ static int do_decode(AVCodecCont

[FFmpeg-devel] [PATCH 3/9] avcodec/jfdctint_template: use unsigned z* in row_fdct()

peg Signed-off-by: Michael Niedermayer --- libavcodec/jfdctint_template.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libavcodec/jfdctint_template.c b/libavcodec/jfdctint_template.c index aa2680132ee..58827b677e6 100644 --- a/libavcodec/jfdctint_template.c +++ b/

[FFmpeg-devel] [PATCH 2/9] avformat/asf: Check picsize

Fixes: signed integer overflow: 1073750247 * 2 cannot be represented in type 'int' Fixes: 70722/clusterfuzz-testcase-minimized-ffmpeg_dem_ASF_O_fuzzer-5447231587549184 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH 1/9] avcodec/osq: Treat sum = 0 as k = 0

We have no valid sample that triggers this so we do not know if this would decode correctly, but -inf is not the correct k value Fixes: Assertion n>=0 && n<=32 failed at libavcodec/get_bits.h:423 Fixes: -inf is outside the range of representable values of type 'int' Fixes: 70709/clusterfuzz-test

Re: [FFmpeg-devel] [PATCH] avformat/utils: added av_get_frame_filename3() (changed parameter int -> int64_t)

On Mon, Sep 16, 2024 at 10:32:00PM +0100, Filip Mašić wrote: > fix for ticket 11194 (frame_pts codepath requires a larger integer capacity > for normal workloads) > > Signed-off-by: Filip Mašić > --- > libavformat/avformat.h | 5 - > libavformat/img2enc.c | 6 ++ > libavformat/utils.

Re: [FFmpeg-devel] [PATCH 2/7] avcodec/vc2enc: basic sanity check on slice_max_bytes

On Fri, Sep 13, 2024 at 01:33:32AM +0200, Michael Niedermayer wrote: > Fixes: left shift of 896021632 by 3 places cannot be represented in type 'int' > Fixes: > 70544/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC2_fuzzer-6685593652756480 > > Found-by: continuous

Re: [FFmpeg-devel] [PATCH 4/7] avformat/mxfdec: Check timecode for overflow

On Sun, Sep 15, 2024 at 08:28:16PM +0200, Tomas Härdin wrote: > fre 2024-09-13 klockan 01:33 +0200 skrev Michael Niedermayer: > > Fixes: signed integer overflow: 9223372036840103968 + 538976288 > > cannot be represented in type 'long' > > Fixes: 70604

Re: [FFmpeg-devel] [PATCH 5/7] avformat/mxfdec: More offset_temp checks

On Mon, Sep 16, 2024 at 09:59:11AM +0200, Tomas Härdin wrote: > sön 2024-09-15 klockan 22:28 +0200 skrev Tomas Härdin: > > fre 2024-09-13 klockan 01:33 +0200 skrev Michael Niedermayer: > > > Fixes: signed integer overflow: 9223372036854775807 - - > > > 19274914302560340

Re: [FFmpeg-devel] [PATCH 7/7] avformat/flvdec: Free metaVideoColor

On Fri, Sep 13, 2024 at 10:15:28AM +0800, Steven Liu wrote: > Michael Niedermayer 于2024年9月13日周五 07:44写道： > > > > Fixes: memeleak > > Fixes: > > 70659/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-4539872627458048 > > > > Found-by: continuous fuzzing

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

On Sun, Sep 15, 2024 at 09:09:39PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-09-13 19:48:46) [...] > > > > > > > +#include "libavcodec/internal.h" > > > > > > I dislike this as well. > > > > I am fine with

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

On Mon, Sep 16, 2024 at 11:30:34AM -0300, James Almer wrote: > On 9/13/2024 2:48 PM, Michael Niedermayer wrote: > > On Fri, Sep 13, 2024 at 12:08:45PM +0200, Anton Khirnov wrote: > > > Quoting Michael Niedermayer (2024-09-13 01:33:31) > > > > We do not supp

Re: [FFmpeg-devel] [PATCH] avcodec/h264: ignore POC when flag is set

On Thu, Sep 12, 2024 at 10:40:17PM -0700, kevmo...@gmail.com wrote: > From: Kevin Wang > > When the flag AV_CODEC_FLAG_OUTPUT_CORRUPT or AV_CODEC_FLAG2_SHOW_ALL > is set, ignore any out of order POC's as they may still be valid > frames. > > Fixes https://trac.ffmpeg.org/ticket/11190. > > Signe

Re: [FFmpeg-devel] [PATCH] MAINTAINERS: add myself as vf_xfade_vulkan maintainer

On Wed, Sep 11, 2024 at 09:32:12PM +0200, Marvin Scholz wrote: > --- > MAINTAINERS | 1 + > 1 file changed, 1 insertion(+) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040B0FAB Its not that you shouldnt use gotos but rather that you should write readable co

Re: [FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

On Fri, Sep 13, 2024 at 12:08:45PM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-09-13 01:33:31) > > We do not support more channels. For example avcodec_open2() limits > > channels this way too > > > > The example file contains multiple chunks wi

Re: [FFmpeg-devel] [FFmpeg-cvslog] fftools/ffmpeg_mux_init: default to input timebase for streamcopy

On Tue, Jul 09, 2024 at 09:19:54AM +, Anton Khirnov wrote: > ffmpeg | branch: master | Anton Khirnov | Fri Jul 5 > 12:30:04 2024 +0200| [10185e2d4c1e9839bc58a1d6a63c861677b13fd0] | committer: > Anton Khirnov > > fftools/ffmpeg_mux_init: default to input timebase for streamcopy > > Stop tr

[FFmpeg-devel] [PATCH 7/7] avformat/flvdec: Free metaVideoColor

Fixes: memeleak Fixes: 70659/clusterfuzz-testcase-minimized-ffmpeg_dem_KUX_fuzzer-4539872627458048 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/flvdec.c | 1 + 1 file changed, 1 insertion

[FFmpeg-devel] [PATCH 6/7] swscale/output: Fix undefined integer overflow in yuv2rgba64_2_c_template()

Fixes: signed integer overflow: -1082982400 + -1083218484 cannot be represented in type 'int' Fixes: 70657/clusterfuzz-testcase-minimized-ffmpeg_SWS_fuzzer-6707819712675840 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH 5/7] avformat/mxfdec: More offset_temp checks

cts/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index 8eae9f87afa..41281c5196d 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -1924,6 +1924,11 @@

[FFmpeg-devel] [PATCH 4/7] avformat/mxfdec: Check timecode for overflow

Signed-off-by: Michael Niedermayer --- libavformat/mxfdec.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/mxfdec.c b/libavformat/mxfdec.c index ac63c0d5add..8eae9f87afa 100644 --- a/libavformat/mxfdec.c +++ b/libavformat/mxfdec.c @@ -2391,6 +2391,9 @@

[FFmpeg-devel] [PATCH 3/7] swscale/swscale: Use unsigned operation to avoid undefined behavior

https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libswscale/swscale.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/libswscale/swscale.c b/libswscale/swscale.c index df0d5708aa8..8b6a3a84b4e 100644 --- a/libswscale/swscale.c

[FFmpeg-devel] [PATCH 2/7] avcodec/vc2enc: basic sanity check on slice_max_bytes

Fixes: left shift of 896021632 by 3 places cannot be represented in type 'int' Fixes: 70544/clusterfuzz-testcase-minimized-ffmpeg_AV_CODEC_ID_VC2_fuzzer-6685593652756480 Found-by: continuous fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-b

[FFmpeg-devel] [PATCH 1/7] avformat/mov_chan: Check for FF_SANE_NB_CHANNELS

fuzzing process https://github.com/google/oss-fuzz/tree/master/projects/ffmpeg Signed-off-by: Michael Niedermayer --- libavformat/mov_chan.c | 5 + 1 file changed, 5 insertions(+) diff --git a/libavformat/mov_chan.c b/libavformat/mov_chan.c index cc5b3331290..2cc6b2a7797 100644 --- a/libavformat

Re: [FFmpeg-devel] [PATCH 3/5] avcodec/decode: Check progress before dereferencing

On Tue, Jun 25, 2024 at 09:51:32PM +0200, Andreas Rheinhardt wrote: > Michael Niedermayer: > > On Sat, Apr 27, 2024 at 01:13:54PM +0200, Andreas Rheinhardt wrote: > >> Michael Niedermayer: > >>> Fixes: NULL pointer dereference > >>> Fixes:

Re: [FFmpeg-devel] [PATCH 01/60] fftools/ffmpeg_opt: fix variable shadowing

On Sun, Sep 08, 2024 at 07:14:10PM +0200, Marvin Scholz wrote: > --- > fftools/ffmpeg_opt.c | 6 ++ > 1 file changed, 2 insertions(+), 4 deletions(-) btw, iam not sure its needed to post patches for things like shadow fixes. Maybe we can fix the shadowing stuff quicker without posting patches

Re: [FFmpeg-devel] is libswscale maintained?

Hi On Wed, Sep 11, 2024 at 02:45:59AM +0300, Andrew Randrianasulu wrote: > I can't find entry about it in ffmpeg/MAINTAINERS I do try to maintain swscale. But iam surely happy if others help If you have a patch that needs to be reviewed or applied i can look at it > > bugs meanwhile exist > >

Re: [FFmpeg-devel] [PATCH] web/index: Add news entry about coverity

Hi (also adding tara as i think he is interrested about the news entry) On Fri, Aug 16, 2024 at 09:20:06AM +0200, Anton Khirnov wrote: > Quoting Michael Niedermayer (2024-08-15 23:50:18) > > Based on suggestion of Jonatas > > > > CC: "Jonatas L. Nogueira&qu

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Sun, Sep 08, 2024 at 09:34:39AM +0200, Jean-Baptiste Kempf wrote: > Hello, > > On Sat, 7 Sep 2024, at 22:46, Michael Niedermayer wrote: > > I intend to branch 7.1 in the next 24h > > Could you wait a tiny bit more, please? I could if someone opens corresponding issues o

Re: [FFmpeg-devel] [PATCH 1/5] MAINTAINERS: Mark parts from Robert as unmaintained

On Sat, Aug 31, 2024 at 11:44:45PM +0200, Michael Niedermayer wrote: > Last mail and commit from Robert seems from 2011, thats 13 years ago > > CC: Rob > Signed-off-by: Michael Niedermayer > --- > MAINTAINERS | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-)

Re: [FFmpeg-devel] [PATCH 2/2] MAINTAINERS: remove Aurelien and David from matroska*

On Sun, Sep 01, 2024 at 04:27:22PM +0200, Michael Niedermayer wrote: > Aurelien last activity in git is from 2017, last activity on the ML is from > 2018 > David last activity in git is from 2011, and ML from 2013 > > matroska* is actively maintained > > CC: Aurelien Jacob

Re: [FFmpeg-devel] [RFC] 7.1 Release

On Sat, Aug 24, 2024 at 10:31:28PM +0200, Michael Niedermayer wrote: > On Wed, Aug 14, 2024 at 02:41:55PM +0200, Michael Niedermayer wrote: > > Hi all > > > > Are there any upcoming LTS releases that want to/could include FFmpeg 7.1 ? > > If so please reply here and li

Re: [FFmpeg-devel] [PATCH v1] XPSNR: add maintainers

to MAINTAINERS > --- > > diff --git a/MAINTAINERS b/MAINTAINERS > --- a/MAINTAINERS > +++ b/MAINTAINERS > @@ -344,6 +344,7 @@ >vf_readvitc.c Tobias Rapp (CC t.rapp at > noa-archive dot com) >vf_scale.c[2] Michael

Re: [FFmpeg-devel] [PATCH v5] avfilter: add XPSNR filter

On Wed, Aug 28, 2024 at 01:40:39PM +, Helmrich, Christian wrote: > Following up on this: attached a (final, in our view) v5. Changes over v3: > > > - cleanup and align to psnr filter > - add metadata > - add xpsnr tests for yuv and rgb will apply thx [...] -- Michael GnuPG fingerprin

Re: [FFmpeg-devel] [PATCH] configure: enable warnings for shadowed variables

On Sat, Sep 07, 2024 at 08:52:41PM +0200, Timo Rothenpieler wrote: > These can easily lead to incredibly confusing errors, and should > practically never happen. > I'd have loved to make this a -Werror even, but sadly there is way too > many instances in the codebase right now that first needs to b

Re: [FFmpeg-devel] [PATCH] libavcodec: implementation of DNxUncompressed decoder

On Thu, Sep 05, 2024 at 04:35:04AM +0200, Martin Schitter wrote: > This is a second attempt to contribute the corrected code of an > AVID DNxUncompressed / SMTPE RDD 50 decoder. > > Thanks > Martin > > --- > Changelog | 1 + > doc/general_contents.texi | 1 + > libavcodec/Mak

Re: [FFmpeg-devel] [PATCH 06/42] lavc: add HEVC Multiview Main profile

On Tue, Aug 27, 2024 at 05:04:46PM +0200, Anton Khirnov wrote: > --- > doc/APIchanges| 3 +++ > libavcodec/defs.h | 1 + > libavcodec/hevc/ps.c | 21 + > libavcodec/profiles.c | 1 + > libavcodec/version.h | 2 +- > 5 files changed, 15 insertions(+), 13 deleti

Re: [FFmpeg-devel] [PATCH] doc/filters: update uspp availability status

On Wed, Sep 04, 2024 at 01:33:50PM +0530, Gyan Doshi wrote: > The filter was disabled in 95054bfa48 and re-enabled in 771c27119d > --- > doc/filters.texi | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) LGTM thx [...] -- Michael GnuPG fingerprint: 9FF2128B147EF6730BADF133611EC787040

Re: [FFmpeg-devel] [PATCH 2/2] MAINTAINERS: mark vf_volumedetect as unmaintained

On Wed, Sep 04, 2024 at 09:26:19PM +0200, Michael Niedermayer wrote: > Hi Yiğithan Yiğit > > On Mon, Sep 02, 2024 at 11:52:52PM +0200, Yigithan Yigit wrote: > > Hi Michael, > > > > I am new to community, and I am not sure about qualifications of maintainer > &g

Re: [FFmpeg-devel] [PATCH 2/2] MAINTAINERS: mark vf_volumedetect as unmaintained

Hi Yiğithan Yiğit On Mon, Sep 02, 2024 at 11:52:52PM +0200, Yigithan Yigit wrote: > Hi Michael, > > I am new to community, and I am not sure about qualifications of maintainer > but If you prefer I can be the maintainer. some libavfilter filters may be difficult to maintain currently (thats be

Re: [FFmpeg-devel] [PATCH 1/2] MAINTAINERS: aacdec_usac seems not actively maintained

On Tue, Sep 03, 2024 at 06:22:00AM +0200, Lynne via ffmpeg-devel wrote: > On 02/09/2024 16:32, Michael Niedermayer wrote: > > My ping on a patch on 21 Jul has no reaction > > > > Signed-off-by: Michael Niedermayer > > --- > > MAINTAINERS | 1 + > > 1 fil

[FFmpeg-devel] [PATCH 2/2] MAINTAINERS: mark vf_volumedetect as unmaintained

A ping from last month by Yigithan Yigit had no reaction Signed-off-by: Michael Niedermayer --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index d73536370a0..0b323962ed4 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -324,6 +324,7 @@ Filters

[FFmpeg-devel] [PATCH 1/2] MAINTAINERS: aacdec_usac seems not actively maintained

My ping on a patch on 21 Jul has no reaction Signed-off-by: Michael Niedermayer --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index a513bec72a9..d73536370a0 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -146,6 +146,7 @@ Codecs: 4xm.c

Re: [FFmpeg-devel] [PATCH 2/2] MAINTAINERS: remove Aurelien and David from matroska*

; > > > CC: Aurelien Jacobs mailto:au...@gnuage.org>> > > CC: David Conrad mailto:lesse...@gmail.com>> > > Signed-off-by: Michael Niedermayer > <mailto:mich...@niedermayer.cc>> > > --- > > MAINTAINERS | 6 +++--- > > 1 file changed, 3 ins

Re: [FFmpeg-devel] [PATCH v5] avfilter: add XPSNR filter

On Wed, Aug 28, 2024 at 01:40:39PM +, Helmrich, Christian wrote: > Following up on this: attached a (final, in our view) v5. Changes over v3: [...] > doc/filters.texi | 68 ++ > libavfilter/Makefile |1 > libavfilter/allfilters.c |

[FFmpeg-devel] [PATCH 2/2] MAINTAINERS: remove Aurelien and David from matroska*

Aurelien last activity in git is from 2017, last activity on the ML is from 2018 David last activity in git is from 2011, and ML from 2013 matroska* is actively maintained CC: Aurelien Jacobs CC: David Conrad Signed-off-by: Michael Niedermayer --- MAINTAINERS | 6 +++--- 1 file changed, 3

[FFmpeg-devel] [PATCH 1/2] MAINTAINER: iamf is maintained by James

CC: James Almer Signed-off-by: Michael Niedermayer --- MAINTAINERS | 1 + 1 file changed, 1 insertion(+) diff --git a/MAINTAINERS b/MAINTAINERS index 14aebe147f8..911d01cc42f 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -400,6 +400,7 @@ Muxers/Demuxers: gxf.c

Re: [FFmpeg-devel] [PATCH] swscale/aarch64/rgb2rgb: add deinterleaveBytes neon implementation

On Sun, Sep 01, 2024 at 12:51:48PM +0200, Ramiro Polla wrote: > On Sat, Aug 31, 2024 at 10:40 PM Michael Niedermayer > wrote: > > On Fri, Aug 30, 2024 at 08:56:55PM +0200, Ramiro Polla wrote: > > > A55 A76 >

Re: [FFmpeg-devel] [PATCH 1/5] MAINTAINERS: Mark parts from Robert as unmaintained

On Sat, Aug 31, 2024 at 11:44:45PM +0200, Michael Niedermayer wrote: What my summary mail said, that git decided to not send :) was, that this is a bit trial and error on how to best update MAINTAINERs also people are welcome to update their entries in MANITAINERs as well as add entries for

[FFmpeg-devel] [PATCH 5/5] MAINTAINERS: Add status to icecast

Last icecast threads have Marvin in them so it seems maintained CC: Marvin Scholz Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index f540595ee24..14aebe147f8 100644 --- a/MAINTAINERS +++ b

[FFmpeg-devel] [PATCH 4/5] MAINTAINERS: Rangecoder looks quite familiar, ill maintain it

Signed-off-by: Michael Niedermayer --- MAINTAINERS | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/MAINTAINERS b/MAINTAINERS index 809baa855df..f540595ee24 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -122,7 +122,7 @@ Generic Parts: DSP utilities: dsputils.c

  1   2   3   4   5   6   7   8   9   10   >