Hello,
I am removing myself from MAINTAINERS list as MIPS maintainer.
Manojkumar Bhosale agreed to maintain MIPS related code, so I am adding him to
the list.
Thanks,
Nedeljko
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/ma
Manojkumar is taking over MIPS maintenance.
Signed-off-by: Nedeljko Babic
---
MAINTAINERS | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/MAINTAINERS b/MAINTAINERS
index 32408e6..60aae12 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -514,7 +514,7 @@ Operating systems / CPU
LGTM
- Nedeljko
Od: Jovan Zelincevic
Poslato: 29. mart 2016 9:43
Za: ffmpeg-devel@ffmpeg.org
Cc: Zeljko Lukac; Nedeljko Babic; Jovan Zelincevic
Tema: [PATCH] avcodec/mips: Optimization synced to the newest code base.
FFT expanded to 2^17.
Signed-off-by
I applied all the patches and it worked fine.
But, there is a problem with the first patch indeed.
There is one 'fi' command added that looks misplaced.
It looks like patch 12 fixes problem caused with patch 1 by adding appropriate
'if'.
-Nedeljko
__
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 12/13] Improve detection of MIPS ISAs, FPU and ASEs (DSP, MSA)
Signed-off-by
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 11/13] Remove the MIPS "generic" core in favor of "*"
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 13/13] Add support for MIPS R6
Understanding the mips32r6 and mips64r6 ISAs
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 08/13] Add mips64r2 architecture variant
Signed-off-by: Vicente Olivert
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 09/13] Add mips32r6 architecture variant
Signed-off-by: Vicente Olivert
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 10/13] Put "disable mipsfpu" in a better place for loongson
Let
It looks to me that there is an error in patch name.
Other than that LGTM.
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 06/13
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 05/13] Add MIPS i6400 core optimizations
Signed-off-by: Vicente Olivert
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 04/13] Remove --mips64r6 configure option
Having a configure option with the
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 07/13] MIPS i6400 core is not mips32r2, so disable mips32r2
Signed-off-by
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 03/13] Add MIPS p5600 core optimizations
Signed-off-by: Vicente Olivert
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 02/13] Remove --mips32r5 configure option
Having a configure option with the
LGTM
Thanks,
Nedeljko
Od: Vincent Olivert Riera
Poslato: 16. novembar 2015 15:57
Za: ffmpeg-devel@ffmpeg.org
Cc: Nedeljko Babic; Shivraj Patil; Vincent Olivert Riera
Tema: [PATCH 01/13] Rename mipsdspr1 to mipsdsp
Signed-off-by: Vicente Olivert Riera
>> On 11.11.2015 13:46, Michael Niedermayer wrote:
>> > On Sun, Nov 08, 2015 at 09:26:21PM +0100, Andreas Cadhalpun wrote:
>> >> On 08.11.2015 20:17, Michael Niedermayer wrote:
>> >>> but the patch does not look like an optimal solution
>> >>
>> >> It's certainly not pretty, but it fixes the crashe
>>
>> On the other hand, if cpu option is used with some cpu that is not supported
>> in
>> the list, configuration will break since “-march” is set to that cpu value.
>
>Are you sure? What happen if you pass --cpu=mips32r2? Then -march will
>be set to mips32r2 which is valid :-)
Yes, you are co
Hello,
>Signed-off-by: Vicente Olivert Riera
>---
> configure |9 +
> 1 files changed, 9 insertions(+), 0 deletions(-)
>
>diff --git a/configure b/configure
>index 7e55e92..cd27ad7 100755
>--- a/configure
>+++ b/configure
>@@ -4130,6 +4130,15 @@ elif enabled mips; then
> di
improvement to the optimized
code to justify their existence, they are removed (which improves
maintainability of the optimized code).
Optimizations disabled in 97437bd are enabled again.
Signed-off-by: Nedeljko Babic
---
libavcodec/mips/aaccoder_mips.c | 134
and patches; Nedeljko Babic
Tema: mips & aac breakage
Hi
you probably already saw it but just to be sure its not missed
mips optimizations where broken again today:
CC libavcodec/mips/aaccoder_mips.o
ffmpeg/libavcodec/mips/aaccoder_mips.c: In function ‘ff_aac_coder_init_mips’:
ff
>>>
>>>
>>> Patch attached.
>>>
>>> I thought it was worth a review.
>>>
>>> It does include lots of copypaste.
>>>
>>> FTR, I tested MIPS 74Kf and x86_64 with make fate-aac
>>
>> full fate passes on qemu mips here as well!
>
>If there's no objections then, I will be pushing it later today,
>before
Code in aaccoder_mips.c was not synced with changes in aaccoder.c for
some time.
That was cause for some fate-aac tests failing.
This patch fixes the problems.
Optimizations disabled in 933309a are enabled again.
Signed-off-by: Nedeljko Babic
---
libavcodec/mips/aaccoder_mips.c | 89
I synced the functions.
This fixes the problem with the fate tests.
Although this solves a problem, in the long run duplicated code will need to be
removed as Claudio suggested in order to simplify the maintenance.
-Nedeljko
___
ffmpeg-devel mailing list
Hi,
Thanks Michael.
I'll look in to it.
-Nedeljko
Od: Michael Niedermayer [michae...@gmx.at]
Poslato: 2. septembar 2015 13:11
Za: FFmpeg development discussions and patches
Cc: Nedeljko Babic
Tema: MIPS and PNS
Hi
Enabling pns by de
2nd channel makes sense only for CPE type.
Skip 2nd channel in preparation for resampler (in spectral_to _sample())
depending on block type.
Fixes fate failure with clang ftrapv.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacdec_template.c | 3 ++-
1 file changed, 2 insertions(+), 1
>> for(j = 0; j> -che->ch[0].ret[j] =
>> (int32_t)av_clipl_int32((int64_t)che->ch[0].ret[j]<<7)+0x8000;
>> -che->ch[1].ret[j] =
>> (int32_t)av_clipl_int32((int64_t)che->ch[1].ret[j]<<7)+0x8000;
>> +che->c
Add type cast of result of av_clipl_int32() to 64 bit to avoid overflow in
addition later.
Fixes fate failure with clang ftrapv.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacdec_template.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/libavcodec/aacdec_template.c b
From: Nedeljko Babic
There was fixed number of loops (2048) in preparation for resampler, so
when number of samples is smaller than this, there would be an overflow on
ret_buf.
For some reason this behavior popped out only under valgrind with
--disable-memory-poisoning option.
This is now
>>On Sat, Jul 25, 2015 at 05:37:56AM +0200, Michael Niedermayer wrote:
>>> On Mon, Jul 20, 2015 at 01:36:21PM +0200, Nedeljko Babic wrote:
>>> > Signed-off-by: Nedeljko Babic
>>> > ---
>>> > tests/fate/aac.mak | 58
>>> > +
Hi,
>On Sat, Jul 25, 2015 at 05:37:56AM +0200, Michael Niedermayer wrote:
>> On Mon, Jul 20, 2015 at 01:36:21PM +0200, Nedeljko Babic wrote:
>> > Signed-off-by: Nedeljko Babic
>> > ---
>> > tests/fate/aac.mak | 58
>> > ++
>> +/**
>> + * Rounding-to-nearest used.
>> + */
>> +static av_always_inline void av_sincos_sf(int a, int *s, int *c)
>
>this function seems to be buggy
>the sine values are very accurate but the cosine values are not
>
>look: (tested with libavutil/softfloat-test and tightened up thresholds)
Coul
>On Mon, Jul 20, 2015 at 8:50 AM, Nedeljko Babic
> wrote:
>>>This commit moves the tables required for encoding and decoding
>>>LTP and TNS AAC files out of the decoder's standalone tables file
>>>and into the shared aactab.h, where they can be used
>Thanks for your response.
>If you are okay with it then it would make sense to push this patch to
>master first then because you have to rebase aactab.* to INTFLOATs anyway.
>
I am ok with that.
As I said, I don't have a problem to make necessary changes to my patch set if
this patch is accepted
>This commit moves the tables required for encoding and decoding
>LTP and TNS AAC files out of the decoder's standalone tables file
>and into the shared aactab.h, where they can be used by both the
>encoder and the decoder.
>
>This commit does not break the already-broken aac_fixed decoder.
Not su
From: Djordje Pesut
Add fixed poind code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 5 +-
libavcodec/aac.h | 52 +---
libavcodec/aac_defines.h | 78 ++
libavcodec/aacdec_template.c | 14 +-
libavcodec/aacsbr.c | 1 +
libavcodec
From: Djordje Pesut
Move the existing code to a new template file.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacsbr.c| 1428 +---
libavcodec/aacsbr.h| 45 +
libavcodec/{aacsbr.c => aacsbr_template.c} |
From: Jovan Zelincevic
Signed-off-by: Nedeljko Babic
---
Changelog| 1 +
doc/general.texi | 2 +-
doc/mips.txt | 4
libavcodec/version.h | 2 +-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Changelog b/Changelog
index 6374f68..d29ecf4 100644
--- a
Signed-off-by: Nedeljko Babic
---
tests/fate/aac.mak | 58 +-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 34823be..7ebec45 100644
--- a/tests/fate/aac.mak
+++ b/tests/fate/aac.mak
From: Jovan Zelincevic
Add fixed point implementation of functions for generating tables.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacps_fixed_tablegen.c| 24 +++
libavcodec/aacps_fixed_tablegen.h| 402 +++
libavcodec/aacps_tablegen.c
From: Jovan Zelincevic
Create tables for fixed point code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile| 5 +-
.../{aacsbr_tablegen.c => aacsbr_fixed_tablegen.c} | 7 +-
.../{aacsbr_tablegen.c => aacsbr_fixed_tablegen.h} | 21 +-
liba
From: Djordje Pesut
Add fixed point implementation.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 14 ++-
libavcodec/aac_defines.h | 36 ++
libavcodec/aacps.c| 255 --
libavcodec/aacps.h
All the patches from “Implementation of fixed point AAC decoder” patch set
that are not accepted yet (patches for SBR and PS module as well as some
additional patches) are rebased to the newest version so they can be
applied cleanly.
Please have a look.
Thanks,
-Nedeljko
_
Use macros from aac_defines.h for adding suffixes
instead of local macros.
Signed-off-by: Nedeljko Babic
---
libavcodec/cbrt_tablegen.h | 5 ++---
libavcodec/cbrt_tablegen_template.c| 2 +-
libavcodec/sinewin.h | 17 +
libavcodec
>On Tue, Jun 30, 2015 at 11:53:07AM +0200, Nedeljko Babic wrote:
>> From: Djordje Pesut
>>
>> Move the existing code to a new template file.
>>
>> Signed-off-by: Nedeljko Babic
>> ---
>> libavcodec/aacsbr.c| 1419
>> +
>On Tue, Jun 30, 2015 at 11:53:08AM +0200, Nedeljko Babic wrote:
>> From: Jovan Zelincevic
>>
>> Create tables for fixed point code.
>
>Can you make the first line of the commit messages a bit more
>informative
>
>when looking at it with git log --oneline
>
From: Djordje Pesut
Add fixed point implementation.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 14 ++-
libavcodec/aac_defines.h | 36 ++
libavcodec/aacps.c| 255 --
libavcodec/aacps.h
From: Djordje Pesut
Add fixed poind code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 5 +-
libavcodec/aac.h | 52 +---
libavcodec/aac_defines.h | 78 ++
libavcodec/aacdec_template.c | 14 +-
libavcodec/aacsbr.c | 1 +
libavcodec
From: Jovan Zelincevic
Move existing code to the new template files
Signed-off-by: Nedeljko Babic
---
libavcodec/aacdec.c| 3132 +---
libavcodec/{aacdec.c => aacdec_template.c} | 623 +---
libavcodec/cbrt_tablege
From: Jovan Zelincevic
Signed-off-by: Nedeljko Babic
---
Changelog| 1 +
doc/general.texi | 2 +-
doc/mips.txt | 4
libavcodec/version.h | 2 +-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Changelog b/Changelog
index 6e9ca8e..00f67de 100644
--- a
Use macros from aac_defines.h for adding suffixes
instead of local macros.
Signed-off-by: Nedeljko Babic
---
libavcodec/cbrt_tablegen.h | 5 ++---
libavcodec/cbrt_tablegen_template.c| 2 +-
libavcodec/sinewin.h | 17 +
libavcodec
Signed-off-by: Nedeljko Babic
---
tests/fate/aac.mak | 58 +-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 34823be..7ebec45 100644
--- a/tests/fate/aac.mak
+++ b/tests/fate/aac.mak
From: Jovan Zelincevic
Add fixed point implementation of functions for generating tables.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacps_fixed_tablegen.c| 24 +++
libavcodec/aacps_fixed_tablegen.h| 402 +++
libavcodec/aacps_tablegen.c
From: Djordje Pesut
Add fixed point implementation
Signed-off-by: Nedeljko Babic
---
libavcodec/aac.h | 80 ++--
libavcodec/aacdec.c | 5 +
libavcodec/aacdec_fixed.c| 444 +++
libavcodec/aacdec_template.c | 421
From: Jovan Zelincevic
Add fixed point implementation of functions for generating tables
Signed-off-by: Nedeljko Babic
---
libavcodec/aac.h | 23 +
libavcodec/aacdectab.h | 34 +-
libavcodec/aactab.c
From: Jovan Zelincevic
Create tables for fixed point code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile| 5 +-
.../{aacsbr_tablegen.c => aacsbr_fixed_tablegen.c} | 7 +-
.../{aacsbr_tablegen.c => aacsbr_fixed_tablegen.h} | 21 +-
liba
From: Djordje Pesut
Move the existing code to a new template file.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacsbr.c| 1419 +---
libavcodec/aacsbr.h| 45 +
libavcodec/{aacsbr.c => aacsbr_template.c} |
In this patch set patches are formed using -C option of git format-patch in
order for the patches to be more readable.
Commit message for one of the patches is changed so some warnings are explained.
Patchset rebased to the newest code base.
Please take a look.
Thanks,
Nedeljko
___
and there is no fixed point
version of this table.
Signed-off-by: Nedeljko Babic
---
configure | 1 +
libavcodec/Makefile | 13 ++---
libavcodec/aacdec.c | 1 -
libavcodec/aacdec_fixed.c | 1 -
libavcodec/allcodecs.c| 1 +
5 files changed, 12
>>
>> Cause for these warnings is similar as for the first ones: needed
>> definitions are added in later patches (that make changes in sbr module).
>> When all the patches are applied there are no warnings here.
>
>if it breaks nothing then temporary warnings are probably ok.
>Some people might ar
>On Sat, Jun 27, 2015 at 02:43:31AM +0200, Michael Niedermayer wrote:
>> On Fri, Jun 12, 2015 at 08:15:51AM +, Nedeljko Babic wrote:
>> > >On Thu, Jun 11, 2015 at 4:08 PM, Nedeljko Babic
>> > > wrote:
>> > >> From: Jovan Zelincevic
>> >
>> From: Jovan Zelincevic
>>
>> Build system modified
>>
>> Signed-off-by: Nedeljko Babic
>> ---
>> configure | 1 +
>> libavcodec/Makefile | 13 ++---
>> libavcodec/aacdec.c | 1 -
>> libavco
These are all the patches for implementing fixed point AAC decoder in ffmpeg
for now.
-Nedeljko
Od: ffmpeg-devel-boun...@ffmpeg.org [ffmpeg-devel-boun...@ffmpeg.org] u ime
korisnika Cary Tetrick [ctetri...@gmail.com]
Poslato: 27. jun 2015 1:31
Za: FFmpeg
>On Thu, Jun 11, 2015 at 4:08 PM, Nedeljko Babic
> wrote:
>> From: Jovan Zelincevic
>>
>> Move existing code to the new template files
>>
>
>Please setup your Git to track renames (add -M parameter), this is
>really hard to review in this form.
This patc
From: Djordje Pesut
Move the existing code to a new template file.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacsbr.c | 1419 +-
libavcodec/aacsbr.h | 45 ++
libavcodec/aacsbr_template.c | 1401
From: Djordje Pesut
Add fixed point implementation.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 14 ++-
libavcodec/aac_defines.h | 36 ++
libavcodec/aacps.c| 255 --
libavcodec/aacps.h
From: Djordje Pesut
Add fixed point implementation
Signed-off-by: Nedeljko Babic
---
libavcodec/aac.h | 80 ++--
libavcodec/aacdec.c | 5 +
libavcodec/aacdec_fixed.c| 444 +++
libavcodec/aacdec_template.c | 419
From: Jovan Zelincevic
Signed-off-by: Nedeljko Babic
---
Changelog| 1 +
doc/general.texi | 2 +-
doc/mips.txt | 4
libavcodec/version.h | 2 +-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Changelog b/Changelog
index aa5753e..33a0525 100644
--- a
From: Jovan Zelincevic
Add fixed point implementation of functions for generating tables.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacps_fixed_tablegen.c| 24 +++
libavcodec/aacps_fixed_tablegen.h| 402 +++
libavcodec/aacps_tablegen.c
Signed-off-by: Nedeljko Babic
---
tests/fate/aac.mak | 58 +-
1 file changed, 57 insertions(+), 1 deletion(-)
diff --git a/tests/fate/aac.mak b/tests/fate/aac.mak
index 34823be..7ebec45 100644
--- a/tests/fate/aac.mak
+++ b/tests/fate/aac.mak
From: Djordje Pesut
Add fixed poind code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 5 +-
libavcodec/aac.h | 52 +---
libavcodec/aac_defines.h | 78 ++
libavcodec/aacdec_template.c | 14 +-
libavcodec/aacsbr.c | 1 +
libavcodec
Use macros from aac_defines.h for adding suffixes
instead of local macros.
Signed-off-by: Nedeljko Babic
---
libavcodec/cbrt_tablegen.h | 5 ++---
libavcodec/cbrt_tablegen_template.c| 2 +-
libavcodec/sinewin.h | 17 +
libavcodec
From: Jovan Zelincevic
Create tables for fixed point code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 5 +-
libavcodec/aacsbr_fixed_tablegen.c | 40 +++
libavcodec/aacsbr_fixed_tablegen.h | 32 +++
libavcodec/aacsbr_tablegen.c| 1 +
libavcodec
From: Jovan Zelincevic
Add fixed point implementation of functions for generating tables
Signed-off-by: Nedeljko Babic
---
libavcodec/aac.h | 23 ++
libavcodec/aacdectab.h | 34 +--
libavcodec/aactab.c| 486
From: Jovan Zelincevic
Build system modified
Signed-off-by: Nedeljko Babic
---
configure | 1 +
libavcodec/Makefile | 13 ++---
libavcodec/aacdec.c | 1 -
libavcodec/aacdec_fixed.c | 1 -
libavcodec/allcodecs.c| 1 +
5 files changed, 12 insertions
The patch set is rebased to the newest version.
Please have a look.
Thanks,
-Nedeljko
___
ffmpeg-devel mailing list
ffmpeg-devel@ffmpeg.org
http://ffmpeg.org/mailman/listinfo/ffmpeg-devel
The function cannot be used from the test file, so the new file is created for
it and appropriate changes to Makefile are made
Signed-off-by: Nedeljko Babic
---
libavutil/Makefile | 1 +
libavutil/softfloat.c | 49
libavutil/softfloat_trig.c | 70
>> On Fri, Jun 05, 2015 at 08:05:33PM +0200, Michael Niedermayer wrote:
>>> On Fri, Jun 05, 2015 at 07:59:47PM +0200, Michael Niedermayer wrote:
>>>> On Fri, Jun 05, 2015 at 10:04:54AM -0400, Ronald S. Bultje wrote:
>>>>> Hi,
>>>>>
>>
New functions are added to fixed_dsp, so the documentation is changed
accordingly.
Signed-off-by: Nedeljko Babic
---
doc/APIchanges | 7 +++
libavutil/version.h | 2 +-
2 files changed, 8 insertions(+), 1 deletion(-)
diff --git a/doc/APIchanges b/doc/APIchanges
index 5c36dca..bcf4fe6
>> >> -while((a.mant + 0x2000U)<0x4000U){
>> >> +while((FFABS(a.mant) + 0x2000U)<0x4000U){
>> >
>> >when exactly is this needed and how does a.mant reach that value
>> >for which this is needed?
>> >FFABS would significantly slow this down i suspect and it just looks
>> Add functions needed for implementation of fixed point aac dec.
>>
>> Signed-off-by: Nedeljko Babic
>
>applied
>
>these also need a update to doc/APIchanges and version.h
>i saw a version.h update in a later patch, not sure if theres a
>doc/APIchange one
>> From: Jovan Zelincevic
>>
>> Move existing code to the new template files
>>
>> Signed-off-by: Nedeljko Babic
>> ---
>> libavcodec/aacdec.c| 3101
>> +---
&
>> diff --git a/libavutil/softfloat.h b/libavutil/softfloat.h
>> index 8097d28..182e517 100644
>> --- a/libavutil/softfloat.h
>> +++ b/libavutil/softfloat.h
>> @@ -47,7 +47,7 @@ static const SoftFloat FLOAT_099= { 0x3BCE,
>> 0};
>> static av_const SoftFloat av_normalize_sf(SoftFloat
av_normalize_sf doesn't properly address case when negative numbers are out
of defined range.
av_normalize1_sf doesn't properly address border case when mantis is
exactly 0x4000.
This patch solves both of these problems.
Signed-off-by: Nedeljko Babic
---
libavutil/softfloat.h |
>>
>> Configuration that I am using is:
>> ./configure --samples=../fate_tests --enable-gpl --enable-memory-poisoning
>> --enable-avresample --enable-debug=2 --disable-iconv --target-os=linux
>> --disable-yasm
>
>probably needs --assert-level=2
Yes, that was it.
The problem is in edge cases in
From: Jovan Zelincevic
Signed-off-by: Nedeljko Babic
---
Changelog | 1 +
doc/general.texi| 2 +-
doc/mips.txt| 4
libavutil/version.h | 2 +-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Changelog b/Changelog
index 193ca43..bea12e8 100644
--- a
Add functions needed for implementation of fixed point aac dec.
Signed-off-by: Nedeljko Babic
---
libavutil/fixed_dsp.c | 62 +++
libavutil/fixed_dsp.h | 59
2 files changed, 121 insertions(+)
diff
>On Fri, May 29, 2015 at 03:46:32PM +0200, Nedeljko Babic wrote:
>> Signed-off-by: Nedeljko Babic
>> ---
>> tests/fate/aac.mak | 58
>> +-
>> 1 file changed, 57 insertions(+), 1 deletion(-)
>
>These te
> Added functions needed for implementation of fixed point aac dec.
>>
>> Signed-off-by: Nedeljko Babic
>> ---
>> libavutil/fixed_dsp.c | 60
>> +++
>> libavutil/fixed_dsp.h | 53 ++
>> @@ -57,7 +57,7 @@
>>
>> #define LIBAVUTIL_VERSION_MAJOR 54
>> #define LIBAVUTIL_VERSION_MINOR 26
>> -#define LIBAVUTIL_VERSION_MICRO 100
>> +#define LIBAVUTIL_VERSION_MICRO 101
>
>a minor bump is probably more correct for addition of a new decoder
Ok. I'll change this.
Thanks,
-Nedeljko
Added functions needed for implementation of fixed point aac dec.
Signed-off-by: Nedeljko Babic
---
libavutil/fixed_dsp.c | 60 +++
libavutil/fixed_dsp.h | 53 +
2 files changed, 113 insertions(+)
diff
Changes to libavutil are moved and split in two new patches.
Changes are made so the code is buildable after every patch is applied, so some
patches became redundant.
Most of the changes requested in last review implemented.
The documentation about implementation of butterflies_fixed is not chan
From: Jovan Zelincevic
Create tables for fixed point code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 5 +-
libavcodec/aacsbr_fixed_tablegen.c | 40 +++
libavcodec/aacsbr_fixed_tablegen.h | 32 +++
libavcodec/aacsbr_tablegen.c| 1 +
libavcodec
From: Jovan Zelincevic
Add fixed point implementation of functions for generating tables.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacps_fixed_tablegen.c| 24 +++
libavcodec/aacps_fixed_tablegen.h| 402 +++
libavcodec/aacps_tablegen.c
From: Djordje Pesut
Add fixed point implementation
Signed-off-by: Nedeljko Babic
---
libavcodec/aac.h | 80 ++--
libavcodec/aacdec.c | 5 +
libavcodec/aacdec_fixed.c| 444 +++
libavcodec/aacdec_template.c | 419
Use macros from aac_defines.h for adding suffixes
instead of local macros.
Signed-off-by: Nedeljko Babic
---
libavcodec/cbrt_tablegen.h | 5 ++---
libavcodec/cbrt_tablegen_template.c| 2 +-
libavcodec/sinewin.h | 17 +
libavcodec
From: Djordje Pesut
Add fixed poind code.
Signed-off-by: Nedeljko Babic
---
libavcodec/Makefile | 5 +-
libavcodec/aac.h | 52 +---
libavcodec/aac_defines.h | 78 ++
libavcodec/aacdec_template.c | 14 +-
libavcodec/aacsbr.c | 1 +
libavcodec
From: Djordje Pesut
Move the existing code to a new template file.
Signed-off-by: Nedeljko Babic
---
libavcodec/aacsbr.c | 1419 +-
libavcodec/aacsbr.h | 45 ++
libavcodec/aacsbr_template.c | 1401
From: Jovan Zelincevic
Signed-off-by: Nedeljko Babic
---
Changelog | 1 +
doc/general.texi| 2 +-
doc/mips.txt| 4
libavutil/version.h | 2 +-
4 files changed, 7 insertions(+), 2 deletions(-)
diff --git a/Changelog b/Changelog
index 3f47490..7445333 100644
--- a
1 - 100 of 235 matches
Mail list logo
