Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-18 Thread Neil Birkbeck
On Fri, Jan 18, 2019 at 7:48 AM Vittorio Giovara wrote: > On Fri, Jan 18, 2019 at 6:43 AM Carl Eugen Hoyos > wrote: > > > 2019-01-18 4:48 GMT+01:00, Neil Birkbeck : > > > On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck > > > > wrote: > > > > > &

Re: [FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-17 Thread Neil Birkbeck
On Thu, Jan 17, 2019 at 7:43 PM Neil Birkbeck wrote: > This allows preservation of color values set from the container, > while still letting the bitstream take precedent when its values > are specified to some actual value (e.g., not *UNSPECIFIED). > > Signed-off-by

[FFmpeg-devel] [PATCH] avcodec/proresdec2: only set avctx->color* when values are specified

2019-01-17 Thread Neil Birkbeck
This allows preservation of color values set from the container, while still letting the bitstream take precedent when its values are specified to some actual value (e.g., not *UNSPECIFIED). Signed-off-by: Neil Birkbeck --- libavcodec/proresdec2.c | 9 ++--- 1 file changed, 6 insertions

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-12-07 Thread Neil Birkbeck
On Sat, Dec 2, 2017 at 5:25 PM, Carl Eugen Hoyos <ceffm...@gmail.com> wrote: > 2017-12-01 20:08 GMT+01:00 Neil Birkbeck <neil.birkb...@gmail.com>: > > On Thu, Nov 30, 2017 at 9:52 AM, Michael Niedermayer wrote: > > >> > For that sample, I feel like it

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-12-01 Thread Neil Birkbeck
On Thu, Nov 30, 2017 at 9:52 AM, Michael Niedermayer wrote: > > > Perfect, thanks Michael. Let me check those samples out. > > there are 2 more in 2939 which change: > https://trac.ffmpeg.org/ticket/2939 > It seems the swscale_unscaled code paths do not get reconfigured

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-29 Thread Neil Birkbeck
On Wed, Nov 29, 2017 at 7:40 PM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > >> >> If you are searching for a case where the patch makes a difference >> one is: >> ./ffmpeg -i ~/tickets/4493/AVCI100.mov out.nut >> file should be here: >> http://

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-29 Thread Neil Birkbeck
> > > > If you are searching for a case where the patch makes a difference > one is: > ./ffmpeg -i ~/tickets/4493/AVCI100.mov out.nut > file should be here: > http://samples.ffmpeg.org/ffmpeg-bugs/trac/ticket524/ > > if you want more cases that change, ill see if i can find more > Perfect, thanks

Re: [FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-28 Thread Neil Birkbeck
On Tue, Nov 28, 2017 at 5:14 PM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > -//The srcBpc check is possibly wrong but we seem to lack a definitive > reference to test this > -//and what we have in ticket 2939 looks better with this check > -if (need_reinit

[FFmpeg-devel] [PATCH] swscale/utils: Remove bpc==8 gating init_range_convert

2017-11-28 Thread Neil Birkbeck
her edge cases where range conversion doesn't work unless explicitly set (e.g., when no scale is happening) Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libswscale/utils.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/libswscale/utils.c b/libswscale/util

Re: [FFmpeg-devel] [PATCH] avformat/utils: check for overflow before reallocating side data

2016-11-21 Thread Neil Birkbeck
On Sat, Nov 19, 2016 at 3:28 PM, James Almer wrote: > On 11/19/2016 7:19 PM, Michael Niedermayer wrote: > > On Sat, Nov 19, 2016 at 03:09:15PM -0300, James Almer wrote: > >> This makes av_stream_add_side_data() consistent with > av_packet_add_side_data(). > >> > >>

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use metadata key/value to set mastering metadata

2016-11-04 Thread Neil Birkbeck
On Wed, Jun 8, 2016 at 11:27 PM, Dave Rice <d...@dericed.com> wrote: > > > On Jun 8, 2016, at 11:03 PM, Neil Birkbeck <neil.birkb...@gmail.com> > wrote: > > > > The most recent patch should still apply cleanly (unless we have a > > better way to set thes

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: add early support for colour elements

2016-11-04 Thread Neil Birkbeck
> > > This seems to have been made official now, as usual under version 4 > like every other new element. > https://github.com/Matroska-Org/libmatroska/commit/ > cd05bc14b42bd88218c61837208fa2b6c79b1de4 > > Could you confirm there were no changes to the draft and remove the > experimental checks

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use dyn_buf to write header elements for non-seekable outputs.

2016-10-10 Thread Neil Birkbeck
On Sun, Oct 9, 2016 at 6:45 PM, James Almer <jamr...@gmail.com> wrote: > On 10/9/2016 10:13 PM, Neil Birkbeck wrote: > > For non-seekable output files, larger elements written in write_header > > (like larger attachments, or possibly many tags) can go over > > IO_BUFFE

[FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use dyn_buf to write header elements for non-seekable outputs.

2016-10-09 Thread Neil Birkbeck
data mimetype: test/data Stream #0:3: Attachment: none Metadata: filename: data mimetype: test/data Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libavformat/matroskaenc.c| 101 +++---

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use metadata key/value to set mastering metadata

2016-06-08 Thread Neil Birkbeck
The most recent patch should still apply cleanly (unless we have a better way to set these elements). Thanks On Tue, Apr 19, 2016 at 8:12 AM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > Updated patch attached. > > On Sat, Apr 16, 2016 at 7:08 PM, Michael Niedermayer > <m

Re: [FFmpeg-devel] [PATCH] lavu: Adding hybrid-log gamma enum value and transfer function.

2016-05-31 Thread Neil Birkbeck
Any other thoughts on we should move forward with the _ARIB_STD name or to use something like HYBRID_LOG_GAMMA? On Thu, Apr 21, 2016 at 5:04 PM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > Thanks Hendrik. > > For now, I've updated the patch with a better comment and c

Re: [FFmpeg-devel] [PATCH] lavu: Adding hybrid-log gamma enum value and transfer function.

2016-04-21 Thread Neil Birkbeck
referred to as Perceptual Quantizer or PQ). On Thu, Apr 21, 2016 at 2:03 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Thu, Apr 21, 2016 at 10:57 PM, Neil Birkbeck <neil.birkb...@gmail.com> > wrote: >> The standard: >> http://www.arib.or.jp/english/html/

Re: [FFmpeg-devel] [PATCH] Add support for spherical uuid in mov

2016-04-20 Thread Neil Birkbeck
If you use "spherical-video" and put it in the stream's metadata, it will more naturally agree with location in stream-level tag in mkv: https://github.com/google/spatial-media/blob/master/docs/spherical-video-rfc.md On Wed, Apr 20, 2016 at 6:24 PM, Colin McFadden wrote: >

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use metadata key/value to set mastering metadata

2016-04-19 Thread Neil Birkbeck
Updated patch attached. On Sat, Apr 16, 2016 at 7:08 PM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Sun, Apr 03, 2016 at 03:38:33PM -0700, Neil Birkbeck wrote: >> Use "master_display" key/value pair to specify mastering metadata in a >> similar fo

Re: [FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use metadata key/value to set mastering metadata

2016-04-11 Thread Neil Birkbeck
ot written in the matroska tags, only to the colour elements. I'm happy to consider alternatives, but wasn't sure there was a precedent for instantiating the packet side data from command line. On Sun, Apr 3, 2016 at 5:13 PM, Dave Rice <d...@dericed.com> wrote: > >> On Apr 3, 2016,

[FFmpeg-devel] [PATCH] lavf/matroskaenc.c: use metadata key/value to set mastering metadata

2016-04-03 Thread Neil Birkbeck
transmuxed (mkv -> mkv). Perhaps we want to also use this same metadata key in matroskadec to also allow for the metadata to propagate during transcoding. From b30d80f6ba4b09811039f64af3e7f709d86df5fe Mon Sep 17 00:00:00 2001 From: Neil Birkbeck <neil.birkb...@gmail.com> Date: Fri, 1 Apr

[FFmpeg-devel] [PATCH] lavf/matroskaenc.c: add early support for colour elements

2016-03-07 Thread Neil Birkbeck
discussion around these. The new elements are exposed under strict experimental mode. Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libavformat/matroskaenc.c | 63 ++- 1 file changed, 62 insertions(+), 1 deletion(-) diff

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Add early support for colour elements

2016-03-03 Thread Neil Birkbeck
And yet another revision, where the syntax lists are actually terminated... On Thu, Mar 3, 2016 at 12:09 PM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > I've attached a slightly cleaner (more isolated) patch that moves the > parsing into a helper function. > > On Mon, Feb 2

Re: [FFmpeg-devel] [PATCH] lavf/matroskadec: Add early support for colour elements

2016-03-03 Thread Neil Birkbeck
I've attached a slightly cleaner (more isolated) patch that moves the parsing into a helper function. On Mon, Feb 29, 2016 at 5:15 PM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > Adding early support for a subset of the proposed colour elements > according to the latest ver

[FFmpeg-devel] [PATCH] lavf/dump.c: Print mastering display metadata

2016-02-29 Thread Neil Birkbeck
Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libavformat/dump.c | 21 + 1 file changed, 21 insertions(+) diff --git a/libavformat/dump.c b/libavformat/dump.c index 56c285d..9e7c12b 100644 --- a/libavformat/dump.c +++ b/libavformat/dump.c @@ -26,6

[FFmpeg-devel] [PATCH] lavf/matroskadec: Add early support for colour elements

2016-02-29 Thread Neil Birkbeck
these, and the max_cll/max_fall are currently not propagated as there is not yet side data for them. The new elements are exposed under strict experimental mode. Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libavformat/matroska.h| 28 ++ libavformat/matroskadec.c

Re: [FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-02-08 Thread Neil Birkbeck
frames were dropped in some part of the filter chain. On Thu, Feb 4, 2016 at 11:04 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Fri, Feb 5, 2016 at 3:05 AM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: >> According to the ITU-T H.265 v3, in Table D - 1,

Re: [FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-02-04 Thread Neil Birkbeck
SEI comes before the IDR, I don't see a great way to do this aside from initializing the flag to 2 and decrementing (when > 0) when we see an IDR. On Tue, Feb 2, 2016 at 7:13 AM, Michael Niedermayer <mich...@niedermayer.cc> wrote: > On Mon, Feb 01, 2016 at 12:11:10PM -0800, Neil Birkbec

Re: [FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-02-01 Thread Neil Birkbeck
Please see updated patch. On Mon, Jan 25, 2016 at 11:39 PM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > I guess png is another example; 10 is the denominator for the 32-bit > integer: > https://github.com/FFmpeg/FFmpeg/blob/b58cfa616c169c90166938608e7135cdab5820e0/liba

[FFmpeg-devel] [PATCH] libavutil/mastering_display_metadata.h: change fields to be rationals as this is how they are typically coded.

2016-01-26 Thread Neil Birkbeck
From: "Vittorio Gambaletta (VittGam)" <ffmpeg-...@vittgam.net> (this structure is not referenced anywhere yet) Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libavutil/mastering_display_metadata.h | 10 ++ libavutil/version.h| 3 +

Re: [FFmpeg-devel] [PATCH] libavutil/mastering_display_metadata.h: change fields to be rationals as this is how they are typically coded.

2016-01-26 Thread Neil Birkbeck
Some sort of squash fail. Apologies. On Tue, Jan 26, 2016 at 1:13 PM, Vittorio Gambaletta (VittGam) < ffmpeg-...@vittgam.net> wrote: > Hi, > > On 26/01/2016 22:09:02 CET, Neil Birkbeck wrote: > >> From: "Vittorio Gambaletta (VittGam)" <ffmpeg-...@vi

Re: [FFmpeg-devel] [PATCH] libavutil/mastering_display_metadata.h: change fields to be rationals as this is how they are typically coded.

2016-01-26 Thread Neil Birkbeck
Patch with corrected "From:" is attached. On Tue, Jan 26, 2016 at 2:28 PM, Vittorio Gambaletta (VittGam) <ffmpeg-...@vittgam.net> wrote: > On 26/01/2016 23:05:22 CET, Neil Birkbeck wrote: >> >> Some sort of squash fa

Re: [FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-01-25 Thread Neil Birkbeck
the avutil struct float internal fields to rational. On Mon, Jan 25, 2016 at 1:43 PM, Hendrik Leppkes <h.lepp...@gmail.com> wrote: > On Mon, Jan 25, 2016 at 10:37 PM, Michael Niedermayer > <mich...@niedermayer.cc> wrote: > > On Fri, Jan 22, 2016 at 02:54:21PM -0800, Neil Bir

Re: [FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-01-22 Thread Neil Birkbeck
Also, the mkv adjustments are here: https://mailarchive.ietf.org/arch/search/?email_list=cellar=1=sZyfPTM-QY69P-0omfOIiTN622o On Fri, Jan 22, 2016 at 2:54 PM, Neil Birkbeck <neil.birkb...@gmail.com> wrote: > Hmm. I don't have a good idea of how likely it is for this conversion t

[FFmpeg-devel] [PATCH] Add missing conversions from side data enum to name

2016-01-21 Thread Neil Birkbeck
Add names for recently added enums to av_frame_side_data_name. Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libavutil/frame.c | 4 1 file changed, 4 insertions(+) diff --git a/libavutil/frame.c b/libavutil/frame.c index f2097e9..92bbe09 100644 --- a/libavutil/frame.c

[FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-01-21 Thread Neil Birkbeck
Add support for parsing SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data. Primaries are ordered in RGB order and the values are converted to the natural ranges ([0,1] for CEI 1931 Chroma coords, and cd/m^2 for luma). Signed-off-by: Neil

Re: [FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-01-21 Thread Neil Birkbeck
21, 2016 at 02:26:39PM -0800, Neil Birkbeck wrote: > > Add support for parsing SEI_TYPE_MASTERING_DISPLAY_INFO and propagate > contents into > > the AVMasteringDisplayMetadata side data. Primaries are ordered in RGB > order and > > the values are converted to the natural ra

[FFmpeg-devel] [PATCH] lavc/hevc Parse SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data.

2016-01-21 Thread Neil Birkbeck
Add support for parsing SEI_TYPE_MASTERING_DISPLAY_INFO and propagate contents into the AVMasteringDisplayMetadata side data. Primaries are ordered in RGB order and the values are converted to the natural ranges ([0,1] for CEI 1931 Chroma coords, and cd/m^2 for luma). Signed-off-by: Neil

Re: [FFmpeg-devel] [PATCH] libavutil: add mastering display metadata sidedata

2016-01-20 Thread Neil Birkbeck
ar=1=sZyfPTM-QY69P-0omfOIiTN622o > > > > > > so it is similar to SEI FPA / stereo_mode in MKV and as such > this patch follows how AVStereo3D is implemented. > > > > > > > > > > > > I'll add support to HEVC in a follow-up (and MKV when spe

[FFmpeg-devel] [PATCH] libavutil: add mastering display metadata sidedata

2016-01-16 Thread Neil Birkbeck
/arch/search/?email_list=cellar=1=sZyfPTM-QY69P-0omfOIiTN622o so it is similar to SEI FPA / stereo_mode in MKV and as such this patch follows how AVStereo3D is implemented. I'll add support to HEVC in a follow-up (and MKV when spec is approved). Signed-off-by: Neil Birkbeck <neil.bi

[FFmpeg-devel] [PATCH] libavformat/mov.c: allow QuickTime metadata to come after traks

2015-12-03 Thread Neil Birkbeck
QuickTime metadata can come after trak data. Add indicator for which trak is being parsed (-1 if none) so that global metadata after the trak can be parsed. Signed-off-by: Neil Birkbeck <neil.birkb...@gmail.com> --- libavformat/isom.h | 1 + libavformat/mov.c | 6 +- 2 files chan

[FFmpeg-devel] [PATCH] libavformat/matroskaenc.c: fix small memory leaks on error

2015-08-19 Thread Neil Birkbeck
Fixing small leaks that can occur when mkv_write_tracks fails in mkv_write_header (e.g., if video track has unknown codec). Also changing mkv_write_seekhead to take the MatroskaMuxContext to avoid having dangling pointers. Signed-off-by: Neil Birkbeck neil.birkb...@gmail.com --- libavformat

[FFmpeg-devel] [PATCH] avfilter/vf_yadif: fix extra leading dup frame when deint=1

2014-11-29 Thread Neil Birkbeck
] [Parsed_showinfo_1 @ 0x1e307d0] n:1 pts:2 pts_time:0.04 pos:-1 fmt:gray sar:0/1 s:352x432 i:P iskey:1 type:I checksum:4E674BC7 plane_checksum:[4E674BC7] mean:[125] stdev:[46.0] (Outputs 50 frames) Signed-off-by: Neil Birkbeck neil.birkb...@gmail.com --- libavfilter/vf_yadif.c | 6 +++--- 1 file changed

[FFmpeg-devel] [PATCH] avfilter/vf_idet: Fixing idet for single-frame inputs.

2014-11-28 Thread Neil Birkbeck
:0 pos:-1 fmt:gray sar:0/1 s:352x432 ... [Parsed_idet_0 @ 0x18f9bb0] Repeated Fields: Neither: 1 Top: 0 Bottom: 0 Fate looks good. Signed-off-by: Neil Birkbeck neil.birkb...@gmail.com --- libavfilter/vf_idet.c | 9 + 1 file changed, 5 insertions(+), 4 deletions(-) diff

[FFmpeg-devel] [PATCH] avfilter/vf_idet: Fixes issue with idet not flushing last frame.

2014-10-22 Thread Neil Birkbeck
will also need a subsequent patch for single frame input) Signed-off-by: Neil Birkbeck neil.birkb...@gmail.com --- libavfilter/vf_idet.c | 31 +++ libavfilter/vf_idet.h | 1 + tests/ref/fate/filter-idet | 2 +- 3 files changed, 33 insertions(+), 1 deletion