Re: [FFmpeg-devel] [PATCH 2/3] lavf/aviobuf: make AVSEEK_SIZE usable from outside.

2019-07-19 Thread Nicolas George
uble-parentheses is an obvious and unobtrusive way of silencing it. (Personally I would prefer explicitly "!= 0", but that is not FFmpeg's coding style.) Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing li

Re: [FFmpeg-devel] [PATCH 2/3] lavf/aviobuf: make AVSEEK_SIZE usable from outside.

2019-07-19 Thread Nicolas George
he preferred way. We already have a few instances in the code base, not all of them mine. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-

Re: [FFmpeg-devel] [PATCH 3/6] avcodec/ffwavesynth: use uint32_t to compute difference, it is enough

2019-07-19 Thread Nicolas George
Fix backward lcg_seek() avcodec/ffwavesynth: Simplify lcg_seek(), avoid negative case If you checked they generate the same sequence, then ok and thanks. If not, then I can do the testing tomorrow. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH v1] filter select - avoid 2 times rounding

2019-07-19 Thread Nicolas George
the 2nd. By a completely negligible difference. And that is assuming it would hold for other values of 10.2, which I am not convinced. You are wasting your time and making the code less readable for no actual benefit. Regards, -- Nicolas George signature.asc Description: PGP signature _

Re: [FFmpeg-devel] [PATCH v1] filter select - avoid 2 times rounding

2019-07-19 Thread Nicolas George
frame->pts * time_base.nom) with "(double)time_base.den". There is no rounding, all is done in double. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.or

Re: [FFmpeg-devel] [PATCH v1] filter select - avoid 2 times rounding

2019-07-19 Thread Nicolas George
frame->pkt_pos; > select->var_values[VAR_KEY] = frame->key_frame; > select->var_values[VAR_CONCATDEC_SELECT] = get_concatdec_select(frame, > av_rescale_q(frame->pts, inlink->time_base, AV_TIME_BASE_Q)); Regards, -- Nicolas George signature.asc Descripti

Re: [FFmpeg-devel] [PATCH 3/3] lavf/concat: implement FFSEEK_SIZE.

2019-07-19 Thread Nicolas George
Andreas Rheinhardt (12019-07-19): > The commit title is wrong: It's AVSEEK_SIZE. Locally fixed, thanks. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH, v3 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-19 Thread Nicolas George
Linjie Fu (12019-07-20): > Add docs for autoscale. In the same patch. Why would you want to separate? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/ffwavesynth: Check sample rate before use

2019-07-19 Thread Nicolas George
igned-off-by: Michael Niedermayer > --- > libavcodec/ffwavesynth.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) All three patches look good to me. Thanks for fixing it. Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH 1/3] tools/aviocat: add verbose mode.

2019-07-19 Thread Nicolas George
hat happens when AVSEEK_SIZE is used before the first patch. > > +exit(0); > Leftover from your testing? Thank you for catching it. Locally fixed. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel

Re: [FFmpeg-devel] patch2 Add-multithreading-for-swscale-filter.patch

2019-07-19 Thread Nicolas George
wscale/swscale_internal.h | 46 + > libswscale/utils.c| 152 +++- > 11 files changed, 547 insertions(+), 137 deletions(-) See this review: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/246770.html When sending a second version of a patch, it is nice to t

Re: [FFmpeg-devel] Patch: Add-multithreading-for-swscale-filter

2019-07-19 Thread Nicolas George
a uniform color", 0, > AV_OPT_TYPE_CONST, { .i64 = SWS_ALPHA_BLEND_UNIFORM},INT_MIN, INT_MAX, > VE, "alphablend" }, > { "checkerboard","blend onto a checkerboard", 0, > AV_OPT_TYPE_CONST, { .i64 =

Re: [FFmpeg-devel] [PATCH] libavformat/subfile: Fix SEEK_CUR and SEEK_END seeking

2019-07-19 Thread Nicolas George
his patch is necessary, and I intend to apply it. But in the meantime, can you test if this patch: https://ffmpeg.org/pipermail/ffmpeg-devel/2019-July/246765.html does resolve the problem with concat: that made you look into it? Regards, -- Nicolas George sign

[FFmpeg-devel] [PATCH 3/3] lavf/concat: implement FFSEEK_SIZE.

2019-07-19 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/concat.c | 7 ++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/libavformat/concat.c b/libavformat/concat.c index 19c83c309a..ea3bc1dfde 100644 --- a/libavformat/concat.c +++ b/libavformat/concat.c @@ -38,6 +38,7 @@ struct

[FFmpeg-devel] [PATCH 2/3] lavf/aviobuf: make AVSEEK_SIZE usable from outside.

2019-07-19 Thread Nicolas George
Signed-off-by: Nicolas George --- libavformat/aviobuf.c | 3 +++ 1 file changed, 3 insertions(+) diff --git a/libavformat/aviobuf.c b/libavformat/aviobuf.c index 6a5cd97b0a..750326f62d 100644 --- a/libavformat/aviobuf.c +++ b/libavformat/aviobuf.c @@ -255,6 +255,9 @@ int64_t avio_seek

[FFmpeg-devel] [PATCH 1/3] tools/aviocat: add verbose mode.

2019-07-19 Thread Nicolas George
For now: print the input size as detected by AVSEEK_SIZE. Signed-off-by: Nicolas George --- tools/aviocat.c | 15 +-- 1 file changed, 13 insertions(+), 2 deletions(-) diff --git a/tools/aviocat.c b/tools/aviocat.c index 2aa08b92ed..7dca4f52b5 100644 --- a/tools/aviocat.c +++ b

Re: [FFmpeg-devel] [PATCH] Setup for extracting quantization parameters from encoded streams

2019-07-19 Thread Nicolas George
Juan De León (12019-07-17): > +FILE *stats_file; I do not judge whether this filter would be useful and should be included, but if so, then I would appreciate that the output be done using AVIO, so that it can go to any supported protocol. Regards, -- Nicolas George signature.

Re: [FFmpeg-devel] [PATCH] fftools/ffprobe: process show_frame/show_packets last

2019-07-19 Thread Nicolas George
Gupta > --- > fftools/ffprobe.c | 38 -- > 1 file changed, 20 insertions(+), 18 deletions(-) Been there, tried that: it will miss all streams that appear late, like subtitles in MPEG-PS. It needs to be an option. Regards, -- Nicolas George

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-18 Thread Nicolas George
Ulf Zibis (12019-07-18): > Maybe we could add another macro FFSGN. Then maintainers of individual > code parts could check the usage over the time. Or maybe write robust code that does not need that kind of hair splitting. Regards, -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] how to create sub project / git repo under FFMPEG

2019-07-18 Thread Nicolas George
thing like that: relying on GitHub or any commercial / proprietary Git infrastructure, and depending on web-based features. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-18 Thread Nicolas George
put destination. That is not enough. You have to tell the user that this option will most likely not work at all, and why. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

Re: [FFmpeg-devel] [PATCH, v2 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-17 Thread Nicolas George
be > +handled next. Since this is completely hackish in lavfi, I think it needs to warn the user much more strongly to expect problems. > @end table > > @section Advanced Video options Regards, -- Nicolas George ___ ffmpeg-devel mailing

Re: [FFmpeg-devel] FFmpeg classification

2019-07-17 Thread Nicolas George
l variable > > Game codec, or not > VQ based, or not > Palette based, or not > Intra-only, or not > Supported sample depths/pixel formats > Supported frame rates/sample rates Community-driven or industry-driven. Regards, -- Nicolas George __

Re: [FFmpeg-devel] [PATCH v1] Bug #8027 - Wrong result for FFSIGN(0)

2019-07-17 Thread Nicolas George
Ulf Zibis (12019-07-17): > Because anyone I ask including mathematicians, is the opinion that the > sign of 0 is positive. They were not very competent mathematicians. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmp

Re: [FFmpeg-devel] [PATCH 2/2] doc/ffmpeg.texi: update docs for autoscale/autorotate

2019-07-15 Thread Nicolas George
resolution. You neglected to explain the drawbacks. > + > @end table > > @section Video Options Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https

Re: [FFmpeg-devel] [PATCHv4] avcodec: Add librav1e encoder

2019-07-13 Thread Nicolas George
use the no-op benefits from av_fast_realloc(), which > only trigger if newsize <= size. av_fast_realloc() also allocates 17/16 of the requested memory, which makes the incremental building of a buffer linear instead of quadratic. Regards, -- Nicolas George signatu

Re: [FFmpeg-devel] [PATCH] Display decoded frame number on error

2019-07-12 Thread Nicolas George
Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

Re: [FFmpeg-devel] [PATCH] Display decoded frame number on error

2019-07-12 Thread Nicolas George
on the way ffmpeg processes the frames, including seek: it is not robust. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH] Display decoded frame number on error

2019-07-12 Thread Nicolas George
input_files[ist->file_index]->ctx->url, ist->frames_decoded + 1, > ist->st->index); frames_decoded is uint64_t, not long long; %lld is for long long. Also: what is the use case for this change? > if (exit_on_error) > exit_program(1); >

Re: [FFmpeg-devel] [PATCH] avfilter: add rawdump filter

2019-07-10 Thread Nicolas George
Eoff, Ullysses A (12019-07-10): > Agree. There are many ways to specify format. But there are some formats > which one might want to dump that some hw drivers can't output directly > without conversion. In that case, your goal to avoid conversion is moot. Regards, -- Nicol

Re: [FFmpeg-devel] [PATCH] avfilter: add rawdump filter

2019-07-10 Thread Nicolas George
ppending on successive reinit's (e.g. frame resolution changes). Thus, > would need a better solution to achieve the same result without > influencing other instances of the filter. The variable needs to be in the filter's private context, nothing more. Regards, -- Nicolas George si

Re: [FFmpeg-devel] [PATCH] avfilter: add rawdump filter

2019-07-10 Thread Nicolas George
U. Artie Eoff (12019-07-09): > +FILE *rawdump_file; Independently from the question of whether this filter is useful or not, I think the dump should have used AVIO. Regards, -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH 1/4] avcodec/mediacodec_wrapper: add missing include

2019-07-04 Thread Nicolas George
e following API around MediaCodec and MediaFormat is based on the > * NDK one provided by Google since Android 5.0. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.

Re: [FFmpeg-devel] [PATCH v4] Add 2 timestamp print formats

2019-07-03 Thread Nicolas George
ered the option of making them a single function with a parameter to select the format? That may make it easier to add new formats later, and have them supported by any component where this is relevant. Regards, -- Nicolas George signature.asc Description

Re: [FFmpeg-devel] [PATCH] libavformat/subfile: Improve AVSEEK_SIZE/SEEK_END seeking

2019-07-01 Thread Nicolas George
n of transport streams isn't correctly determined when > this option is used. This is fixed in this patch. > > Signed-off-by: Andreas Rheinhardt > --- > libavformat/subfile.c | 12 +--- > 1 file changed, 9 insertions(+), 3 deletions(-) Sorry, I forgot about this patch. A

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Nicolas George
r to understand :D I do not understand what you are saying now. With your patch, I think the message would appear: [http @ 0x7ff64540c200] URL read error: (-541478725)End of file And I do not think the -541478725 brings any good. Regards, -- Nicolas George signature.asc De

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Nicolas George
Liu Steven (12019-07-01): > Just leave the old numeric code to some people like it. I think the > better to remove it, but i cannot sure if that is useful to other > people :D. Many places only print the error message. I see no difference specific to this specific place. Regards, --

Re: [FFmpeg-devel] [PATCH] avformat/http: add string of the error when only return error number

2019-07-01 Thread Nicolas George
Steven Liu (12019-07-01): > Signed-off-by: Steven Liu > --- > libavformat/http.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) Any reason to leave the nummeric code at all? Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Nicolas George
Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org wit

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Nicolas George
omprehension how removing more code and making the situation > worse improves things. Dead code is never good. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffm

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Nicolas George
Kieran Kunhya (12019-06-27): > Why can this not be fixed properly? It can. If you have time and motivation to do it, please go ahead. Barring that, removing dead code is still an improvement. Regards, -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Nicolas George
clarifying. If it is dead, it can be removed. If it is needed back, then it can be added back. Steven, go ahead if you want. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org h

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Nicolas George
uld be removed, unless there is a technical reason nobody mentioned yet. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH 1/3] avcodec/cfhd: remove unused function

2019-06-27 Thread Nicolas George
dead code in the source tree. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffm

Re: [FFmpeg-devel] [PATCH v2] ffprobe: Fix memory leak

2019-06-21 Thread Nicolas George
Derek Buitenhuis (12019-06-21): > The previous instructions is not an unref if it hits one of the breaks > in the loop above. Of course. Sorry for wasting your time. Regards, -- Nicolas George signature.asc Description: PGP signature ___

Re: [FFmpeg-devel] [PATCH v2] ffprobe: Fix memory leak

2019-06-21 Thread Nicolas George
not be unreferenced when the very previous instruction is av_packet_unref()? All the code paths I see either pass through the existing av_packet_unref() before reaching the new one or arrive with a blank packet. Am I missing something? > av_init_packet(); > pkt.data = NULL; > pkt.size =

Re: [FFmpeg-devel] [PATCH v5] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-21 Thread Nicolas George
ge? If not, you need to change the From line of the commit. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscr

Re: [FFmpeg-devel] [PATCH v4] vf_drawtext: Add pkt_pos, pkt_duration, pkt_size as variables

2019-06-21 Thread Nicolas George
you to split was, I think, a mistake: a new feature and its documentation belong in the same commit, even if they were written by different persons. Just make sure the commit message states authorship accurately. Regards, -- Nicolas George signature.asc Description: P

Re: [FFmpeg-devel] [PATCH v8 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-06-08 Thread Nicolas George
bsumed by strtol() but is retained because it is used extensively in existing code. If the number is not known to be in range, strtol() should be used because atoi() is not required to perform any error checking. Regards, -- Nicolas George signature.asc Descriptio

Re: [FFmpeg-devel] [PATCH] avfilter/framesync: fix shortest with eof_action=pass

2019-06-05 Thread Nicolas George
Gyan (12019-06-05): > With current order, shortest gets ignored with eof_action=pass Enabling both does not make much sense. A warning may be a better idea. But no objection. Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH v1 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-27 Thread Nicolas George
namic > processing based on frame's orientation, but the filter args still need to > set resolution info. You can have the filter examine the metadata directly, as an option. > Addressed in the new version. Did you send it? If so I missed it. Regards, -- Nicolas George sig

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-27 Thread Nicolas George
re using the same code, i.e. calling the same functions to do the actual work. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

Re: [FFmpeg-devel] [PATCH v1 2/2] fftools/ffmpeg: add exif orientation support per frame's metadata

2019-05-25 Thread Nicolas George
mething? > @@ -1191,6 +1207,7 @@ int ifilter_parameters_from_frame(InputFilter *ifilter, > const AVFrame *frame) > ifilter->width = frame->width; > ifilter->height = frame->height; > ifilter->sample_aspect_ratio = frame->

Re: [FFmpeg-devel] [PATCH v1 1/2] lavf/vf_transpose: add exif orientation support

2019-05-25 Thread Nicolas George
de will copy the frame instead of just passing it unchanged. Did I miss something? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/

Re: [FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

2019-05-23 Thread Nicolas George
t that I see. Something that makes it harder to follow the code from the call site to the actual function is not good for maintenance. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-deve

Re: [FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

2019-05-23 Thread Nicolas George
Gyan (12019-05-23): > -unlink(buffername); > -av_freep(); > +ret = avpriv_io_delete(buffername); Is there a reason you replace unlink() with avpriv_io_delete()? unlink() is more direct, and cache does not support non-file cache. Regards, -- Nicolas George sign

Re: [FFmpeg-devel] [PATCH] avformat/cache - delete cache file after closing handle

2019-05-22 Thread Nicolas George
t;PRId64"\n", > c->cache_hit, c->cache_miss); > > close(c->fd); > +ret = avpriv_io_delete(c->filename); > +if (ret < 0) > + av_log(h, AV_LOG_ERROR, "Could not delete %s. Error is %s\n", > c->filename, av_er

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Nicolas George
Marton Balint (12019-05-19): > loop=1 is the loop count (number of loops), not the loop size (number of > frames to loop) which is also 0 by default. Issue is present with any > nonzero loop count, 1 is just an example. Ok, thanks for explaining. Regards, -- Nicolas George sign

Re: [FFmpeg-devel] [PATCH] avfilter/f_loop: do not loop if loop size is 0

2019-05-19 Thread Nicolas George
Marton Balint (12019-05-19): > Fixes infinte loop with -vf loop=loop=1. The subject line talks about loop=0, this line about loop=1. Typo somewhere, or am I missing something? Regards, -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Nicolas George
uments. Just revert if you try to go against the policy. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Nicolas George
Paul B Mahol (12019-05-17): > If you or anyone does not propose some reasonable alternative solution > in due time, I gonna apply this patch. As already said: a single filter named atempo with compatibility options, or it is rejected. And see with Michael about lswr. -- Nicolas

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-17 Thread Nicolas George
Paul B Mahol (12019-05-17): > Because lack of testers, I will apply this patch as is. Absolutely not. The consensus was to have a single filter, and even possibly make it part of lswr. This is what is currently discussed. -- Nicolas Geo

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread Nicolas George
Lynne (12019-05-16): > I'm not, I still want the 2 checks. Arguments please. As I explained, the first check is harmful to applications because it hides bug. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-de

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

2019-05-16 Thread Nicolas George
te it beforehand. > I verified the VLC, they do the flip during playing, exactly as you > suggested. > The reason I didn't do that is, to keep the code change small to address > the ticket only. > Surely will address it if you think it's necessary. In the end, you decide what you

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread Nicolas George
d (either with an assert or a NULL deref) immediately, so they can fix it. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread Nicolas George
You made the same mistake as me. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ff

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread Nicolas George
> Actually that is what the original code does. What you appear to want > is > > if (!*ctx) Indeed. It is for example what avfilter_link_free(), av_bsf_list_free(), etc., do. It correspond to a useful programming pattern. The current code is clearly a mistake. Regards, --

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread Nicolas George
Lynne (12019-05-16): > LGTM As I said, not to me. Please take all comments into account. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listi

Re: [FFmpeg-devel] [PATCH v3 2/2] fftools/ffmpeg: add support for per frame rotation and flip

2019-05-16 Thread Nicolas George
flip) > +INSERT_FILT("hflip", NULL); > +} else if (fabs(theta - 90) < 1.0) { > INSERT_FILT("transpose", "clock"); > +if (hflip) > +INSERT_FILT("hflip", NULL); > } else if (fab

Re: [FFmpeg-devel] [PATCH V2] avutil/tx: add check against (*ctx)

2019-05-16 Thread Nicolas George
ebody stupid enough to call av_tx_uninit(NULL) instead of av_tx_uninit(). A hard crass is completely warranted in this case. An assert would be acceptable. > return; > > av_free((*ctx)->pfatab); Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
ly output at any sample rate, at a cost much lower than resampling afterwards. Therefore, it makes most sense to have a single filter with all three parameters (sample rate, speed adjustment and pitch adjustment). Regards, -- Nicolas George signature.asc Description: PGP

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Paul B Mahol (12019-05-12): > You can not merge filters by removing other filters as that will break > user scripts. I know how do avoid that, thank you very much. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel m

Re: [FFmpeg-devel] [PATCH] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
e same way. I am sure you have at some point in your life heard an audio recording played at a different speed, did you not? Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
inconsistent values instead of just overriding them. Merging all this is one of my easy TODO list items. > why should we not have both atempo and apitch? Because a single filter that can do both is less confusing: users do not need to hesitate about which one to use. -- Nicolas George

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
Tim Jones (12019-05-12): > Coming from the audio world, tempo, and pitch are different things. Tempo and pitch are not the same thing. But changing them is the same thing. Regards, -- Nicolas George signature.asc Description: PGP signat

Re: [FFmpeg-devel] Discussion of all-inclusive full stack builds

2019-05-12 Thread Nicolas George
this one, on the other hand, there will be opposition: we do not want encourage users to use proprietary software. In fact, there is currently a discussion to refuse including new proprietary components, and possibly getting rid of the ones we included without thinking. Regards, -- Nicol

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
e SAR exists in the library), it is even better. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpe

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
deed, I missed the fact that you did not understand: No, there will no be an apitch filter, whether it lives in af_apitch.c or af_atempo.c. There will be a single filter, named atempo, that will bring the best quality to all users, existing and new ones. -- Nicolas George sign

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-12 Thread Nicolas George
ent atempo full replacement. > (atempo would be just this filter but with same first two options but > with swapped positions). Swapping the position will break existing scripts. It should be avoided. > Options are self-explanatory, at least first two. > Documentation will appear later. Ok.

Re: [FFmpeg-devel] [PATCH][TESTERS WANTED] avfilter: add apitch filter

2019-05-11 Thread Nicolas George
avfilter/af_apitch.c | 764 +++ > libavfilter/allfilters.c | 1 + > 3 files changed, 766 insertions(+) > create mode 100644 libavfilter/af_apitch.c For usability and maintenance reasons already explained, must be part of atempo. Also, missing doc. -- Nicolas George sign

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-05-11 Thread Nicolas George
I refuse. And I will revert this patch if it is applied without following the rules. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To un

Re: [FFmpeg-devel] [PATCH] avfilter: add colorhold filter

2019-05-11 Thread Nicolas George
ist on legitimizing an invalid vote, then I will act on the fake invalid vote that I posted. Ask, politely, that somebody review this patch. That is easy. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-de

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-11 Thread Nicolas George
wonder maybe we just need a function to rotate/flip the frame > data, rather than using filter ? Do you mind sharing some advice ? That would not change anything, since it was for the wrong problem. Regards, -- Nicolas George signature.asc Description: PGP signature __

Re: [FFmpeg-devel] [PATCH]lavf/utils: Do not read "@" without ":" as user name separator

2019-05-09 Thread Nicolas George
"." / "_" / "~" sub-delims = "!" / "$" / "&" / "'" / "(" / ")" / "*" / "+" / "," / ";" /

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Nicolas George
Paul B Mahol (12019-05-09): > Also atempo does not do pitch adjustments. Pitch and speed adjustments are the same thing. -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org ht

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Paul B Mahol (12019-05-09): > Merging of what filters? transpose and rotate when it is an integer quarter of turns. But apparently they are already merged. > Your reasoning is illogical. Your reasoning is absent. -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [DECISION] scaletempo filter

2019-05-09 Thread Nicolas George
ers and another dozen of de-noising filters. We cannot go back in time to prevent that proliferation, but we can prevent it from spreading farther, do resamplers and other kind of filters. Regards, -- Nicolas George signature.asc Description

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
flip ? You will also need rotate, I think. Merging the filters is the best option, I think. I realize it requires more work, but I do not think we can achieve something that works well otherwise. Regards, -- Nicolas George signature.asc Desc

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
Jun Li (12019-05-09): > The image's exif ("orientation") info is kept inside of frame metadata, > maybe the filter can directly read from frame, instead of re-config > the stream level metadata ? That is exactly what I was suggesting. Regards, -- Nicolas George signat

Re: [FFmpeg-devel] [PATCH 3/3] tools/crypto_bench: update the comment about build command

2019-05-09 Thread Nicolas George
Jun Zhao (12019-05-09): > From: Jun Zhao > > commit cd62f9d557f missing the comment about build > > Signed-off-by: Jun Zhao > --- > tools/crypto_bench.c |2 +- > 1 files changed, 1 insertions(+), 1 deletions(-) LGTM. Regards, -- Nicolas George signat

Re: [FFmpeg-devel] [PATCH 2/3] tools/crypto_bench: check malloc fail before using it

2019-05-09 Thread Nicolas George
Jun Zhao (12019-05-09): > From: Jun Zhao > > Need to check malloc fail before using it, so adjust the location > in the code. > > Signed-off-by: Jun Zhao > --- > tools/crypto_bench.c |8 +--- > 1 files changed, 5 insertions(+), 3 deletions(-) Ok. Reg

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-09 Thread Nicolas George
that: lavfi does not support real reconfiguration of the stream properties. Therefore, this filter must be added to the small list of "temporary" exceptions in the framework. And the user will need to insert scale/pad/crop to normalize the output. That needs to be documented. Regards, -- Nic

Re: [FFmpeg-devel] [PATCH v2 2/2] fftools/ffmpeg: Add stream metadata from first frame's metadata

2019-05-06 Thread Nicolas George
on? Regards, -- Nicolas George ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-requ...@ffmpeg.org with subject "unsubscribe".

Re: [FFmpeg-devel] Quo vadis, code of conduct?

2019-05-05 Thread Nicolas George
Nicolas George (12019-05-06): > Hi. Replying in private to avoid feeding the flame. Well, fumbled that. Yet, what I said was true and I made no judgement in my mail. I singled somebody, but since it was specifically who would have been in breach of the CoC just today, the singling was warran

Re: [FFmpeg-devel] Quo vadis, code of conduct?

2019-05-05 Thread Nicolas George
people spoke strongly against it, and it mostly died. As you can guess, Paul was amongst them. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpe

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Nicolas George
ongst other things. Regards, -- Nicolas George signature.asc Description: PGP signature ___ ffmpeg-devel mailing list ffmpeg-devel@ffmpeg.org https://ffmpeg.org/mailman/listinfo/ffmpeg-devel To unsubscribe, visit link above, or email ffmpeg-devel-

[FFmpeg-devel] Insults

2019-05-05 Thread Nicolas George
Paul B Mahol (12019-05-05): > You are so full of yourself and ignorant, that you are so lazy to even look > at patch to comment. And you insulted me again. Therefore, you owe me an apology, again. -- Nicolas George signature.asc Description: PGP sig

Re: [FFmpeg-devel] [DECISION] colorhold filter

2019-05-05 Thread Nicolas George
at you neglected to explain what you changed in this new version of the patch. That would have made it easier to decide. > This is to move forward and not be held back with blocking "arguments". So the question is: shall Paul be allowed to push significant patches that have not been revie

[FFmpeg-devel] About the scaletempo mess

2019-05-05 Thread Nicolas George
Nicolas George (12019-05-04): > Either both votes are invalid (my point) or both are. So, now that I do not have a train to catch, I can take a little more time to explain the issue here and how to move forward. First, I apologize to the rest of the project for the noise caused by this stunt.

Re: [FFmpeg-devel] [DECISION] Individual absolute power

2019-05-04 Thread Nicolas George
Nicolas George (12019-05-04): > Please vote about the following motion: > > Nicolas George shall have the authority to > kick any member of the FFmpeg project (commit rights and voting > rights) for any reason and without discussion. > > Voting is open u

  1   2   3   4   5   6   7   8   9   10   >